[issue23996] _PyGen_FetchStopIterationValue() crashes on unnormalised exceptions

2015-08-03 Thread Guido van Rossum
Guido van Rossum added the comment: Please try to make sure this is fixed before 3.5 rc 1. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23996 ___

[issue23996] _PyGen_FetchStopIterationValue() crashes on unnormalised exceptions

2015-08-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Could you provide tests covering all branches (normalized exception, unnormalized exception, absent value, non-tuple value, empty tuple value, non-empty tuple value...) Stefan? -- nosy: +serhiy.storchaka stage: patch review - test needed

[issue24383] consider implementing __await__ on concurrent.futures.Future

2015-08-03 Thread Alex Grönholm
Alex Grönholm added the comment: Why do you want to keep threads separate from asyncio? What's the downside here? The use of helper functions is justifiable when integrating a third party framework or similar with asyncio, but standard library components should just integrate well with each

[issue20362] longMessage attribute is ignored in unittest.TestCase.assertRegexpMatches etc

2015-08-03 Thread Ilia Kurenkov
Ilia Kurenkov added the comment: Thanks for the feedback, folks. Adding the updated patch. -- Added file: http://bugs.python.org/file40115/20362_py35.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20362

[issue24781] Improve UX of IDLE Highlighting configuration tab

2015-08-03 Thread Mark Roseman
Mark Roseman added the comment: The squares next to foreground/background are placeholders for those controls I can't remember what they're called (colour wells?) where it shows the current colour, and clicking it brings up a colour picker allowing you to change. So separate ones for

[issue24383] consider implementing __await__ on concurrent.futures.Future

2015-08-03 Thread Guido van Rossum
Guido van Rossum added the comment: Sorry, there's no space in this issue for an answer. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24383 ___

[issue24667] OrderedDict.popitem()/__str__() raises KeyError

2015-08-03 Thread Eric Snow
Eric Snow added the comment: It's looking like the problem is in _odict_add_new_node. If that's the case then I should be able to resolve this issue soon. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24667

[issue24786] Changes in the devguide repository are not published online in HTML

2015-08-03 Thread R. David Murray
R. David Murray added the comment: I see your change made on the 30th on the web. I don't see where the copyright is displayed, so I can't confirm that one, but Brett's change on the second is there. So, I don't see a bug here. -- nosy: +r.david.murray

[issue24754] argparse add_argument with action=store_true, type=bool should not crash

2015-08-03 Thread R. David Murray
Changes by R. David Murray rdmur...@bitdance.com: -- stage: - resolved ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24754 ___ ___

[issue23888] Fixing fractional expiry time bug in cookiejar

2015-08-03 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- versions: +Python 3.4, Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23888 ___

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-08-03 Thread Robert Collins
Robert Collins added the comment: I can't find any reference to a discussion to deprecate tempdir outside of this issue. Nothing on python-dev/python-ideas/peps. I can see that there's an argument that it should be deprecated, but AFAICT the idea to do so originated here. I'd like to see

[issue24759] Idle: add ttk widgets as an option

2015-08-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0511b1165bb6 by Terry Jan Reedy in branch '2.7': Issue #24759: Revert 8203fc75b3d2. https://hg.python.org/cpython/rev/0511b1165bb6 New changeset 06852194f541 by Terry Jan Reedy in branch '3.4': Issue #24759: Revert 13a8782a775e.

[issue24021] Add docstring to urllib.urlretrieve

2015-08-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 659f5adc2354 by Robert Collins in branch '3.4': Issue #24021: docstring for urllib.urlcleanup. https://hg.python.org/cpython/rev/659f5adc2354 New changeset 6fd69aeb8a3b by Robert Collins in branch '3.5': Issue #24021: docstring for

[issue24771] Cannot import _tkinter in Python 3.5 on Windows

2015-08-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset e9f91d47c8ab by Steve Dower in branch '3.5': Issue #24771: Adds vcruntime DLL to tcltk package https://hg.python.org/cpython/rev/e9f91d47c8ab New changeset 14dee84ab900 by Steve Dower in branch 'default': Issue #24771: Adds vcruntime DLL to tcltk

[issue24787] csv.Sniffer guesses M instead of \t or , as the delimiter

2015-08-03 Thread Tiago Wright
New submission from Tiago Wright: csv.Sniffer().sniff() guesses M for the delimiter of the first dataset below. The same error occurs when the , is replaced by \t. However, it correctly guesses , for the second dataset. ---Dataset 1 Invoice File,Credit Memo,Amount

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-08-03 Thread R. David Murray
R. David Murray added the comment: Well, something is wrong, because if we are deprecating :data:`tmpdir` we shouldn't be cross referencing it from the non-deprecated docs. The explanation of how the default value is calculated should be moved up to gettmpdir. My understanding is that now

[issue23888] Fixing fractional expiry time bug in cookiejar

2015-08-03 Thread Robert Collins
Robert Collins added the comment: Thanks for the patch. -- nosy: +rbcollins resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23888

[issue24786] Changes in the devguide repository are not published online in HTML

2015-08-03 Thread Jesús Cea Avión
New submission from Jesús Cea Avión: I change content and configuration in the devguide repository and I don't see the changes available in HTML in https://docs.python.org/devguide/ even after some days. -- assignee: docs@python components: Documentation messages: 247961 nosy:

[issue24787] csv.Sniffer guesses M instead of \t or , as the delimiter

2015-08-03 Thread Skip Montanaro
Skip Montanaro added the comment: How are you calling the sniff() method? Note that it takes a sample of the CSV file. For example, this works for me: f = open(sniff1.csv) dialect = csv.Sniffer().sniff(next(open(sniff1.csv))) dialect.delimiter ',' dialect.lineterminator '\r\n' where

[issue23888] Fixing fractional expiry time bug in cookiejar

2015-08-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1c1c508d1b98 by Robert Collins in branch '3.4': Issue #23888: Handle fractional time in cookie expiry. Patch by ssh. https://hg.python.org/cpython/rev/1c1c508d1b98 New changeset 06406205ae99 by Robert Collins in branch '3.5': Issue #23888: Handle

[issue24754] argparse add_argument with action=store_true, type=bool should not crash

2015-08-03 Thread Douglas Bagnall
Douglas Bagnall added the comment: Thanks paul.j3 and r.david.murray, I see your points. What led me to this was automatically generating command line options from a Gstreamer element, mapping the Gstreamer property types to Python types. Then I special-cased the action=store_true for the

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-08-03 Thread Robert Collins
Robert Collins added the comment: mktemp is clearly insecure. I'd just move the tmpdir up above the Deprecation section start -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23725 ___

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-08-03 Thread R. David Murray
R. David Murray added the comment: Heh. This was really bugging me. I remembered it clearly, but I couldn't find an issue. Thought maybe it was a comment in the code, but nope. Google led me to this line in the docs: It is no longer necessary to use the global tempdir variable. Checking

[issue24021] Add docstring to urllib.urlretrieve

2015-08-03 Thread Peter Lovett
Peter Lovett added the comment: Updated patch to 3.6 urlretrieve now has a decent docstring; this patch just adds a docstring to urlcleanup. -- nosy: +PeterLovett versions: +Python 3.6 -Python 2.7 Added file: http://bugs.python.org/file40121/issue-24021.patch

[issue24771] Cannot import _tkinter in Python 3.5 on Windows

2015-08-03 Thread Steve Dower
Steve Dower added the comment: Rather than change the tcl and tk project files (which is not as easy as updating the Python projects - I spent an hour trying), I've added the vcruntime DLL to the MSI with tkinter. Distutils has already been updated to not include it any more, and I really

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-08-03 Thread Zbyszek Jędrzejewski-Szmek
Zbyszek Jędrzejewski-Szmek added the comment: Updated version (based on issue-23725.patch from rbcollins): - move tempdir description at the end of the main section, before Examples - do not add my name second time in ACKS -- Added file:

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-08-03 Thread Zbyszek Jędrzejewski-Szmek
Zbyszek Jędrzejewski-Szmek added the comment: I don't think tempdir should be removed. I just think it should not be used. So what about moving the description of tempdir to the end, as it was in the last patch, but calling the section Other functions and variables. --

[issue24021] Add docstring to urllib.urlretrieve

2015-08-03 Thread Robert Collins
Robert Collins added the comment: Applied to 3.4 and up. Thanks for the patch. -- nosy: +rbcollins resolution: - fixed stage: needs patch - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24021

[issue24777] sys.getrefcount takes no arguments

2015-08-03 Thread Ankoor Patil
Ankoor Patil added the comment: Thanks Berker Peksag. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24777 ___ ___ Python-bugs-list mailing list

[issue24778] mailcap.findmatch() ........ Shell Command Injection in filename

2015-08-03 Thread R. David Murray
R. David Murray added the comment: Hmm. I see. The problem is that our desire to quote conflicts with mailcap's attempts to quote. I now agree with you that run-mailcap's approach is correct, but creating a temporary alias is out of scope for findmatch. That would need to be done by

[issue24786] Changes in the devguide repository are not published online in HTML

2015-08-03 Thread Mark Lawrence
Mark Lawrence added the comment: The copyright is right at the bottom of the page. From the link given by Jesús on the very first page it now reads 2011-2015. I clicked next but still 2011-2014, next again 2011-2014, then gave up. -- nosy: +BreamoreBoy

[issue17570] Improve devguide Windows instructions

2015-08-03 Thread Peter Lovett
Peter Lovett added the comment: Tiny change on case of Windows file 'mercurial.ini' Although Windows is case-insensitive on filenames, the file itself is named in lowercase (I'm using TortoiseHg v3.4.2; I'm assuming older versions of TortoiseHg also name it in this way.) -- nosy:

[issue17570] Improve devguide Windows instructions

2015-08-03 Thread Peter Lovett
Peter Lovett added the comment: Also a similar change to patch.rst ./python.exe should be: PCbuild\target\python.exe -- Added file: http://bugs.python.org/file40124/issue17570-2.patch ___ Python tracker rep...@bugs.python.org

[issue24595] InteractiveInterpreter always prints to stdout

2015-08-03 Thread Martin Panter
Martin Panter added the comment: Terry: perhaps you’re thinking of https://docs.python.org/dev/library/contextlib.html#contextlib.redirect_stdout :) -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24595

[issue24786] Changes in the devguide repository are not published online in HTML

2015-08-03 Thread R. David Murray
R. David Murray added the comment: Huh. I don't see a copyright, but I do see it if I do view source. The fact that not all pages are updated is probably due to those pages not having any internal changes and therefore not being regenerated. Someone would have to clear the build cache on

[issue24595] InteractiveInterpreter always prints to stdout

2015-08-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: There is also redirect_stderr, but not for stdin. I am not sure what specific issue is left here, of if this should be closed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24595

[issue12869] PyOS_StdioReadline is printing the prompt on stderr

2015-08-03 Thread Martin Panter
Martin Panter added the comment: Results of experimenting on 3.6: * The startup messages are written to standard error. * The interactive interpreter prompts to the original standard error if Readline not used. But with Gnu Readline, prompts do go to the original standard output, as does

[issue22397] test_socket failure on AIX

2015-08-03 Thread R. David Murray
Changes by R. David Murray rdmur...@bitdance.com: -- resolution: - fixed stage: needs patch - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22397 ___

[issue24272] PEP 484 docs

2015-08-03 Thread Mark Shannon
Changes by Mark Shannon m...@hotpy.org: -- nosy: +Mark.Shannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24272 ___ ___ Python-bugs-list

[issue20362] longMessage attribute is ignored in unittest.TestCase.assertRegexpMatches etc

2015-08-03 Thread Berker Peksag
Berker Peksag added the comment: Sorry for my late response, Ilia. Your reply to my first question looks correct to me. Please send your updated patch and I'll apply. -- assignee: - berker.peksag versions: +Python 3.4, Python 3.6 ___ Python tracker

[issue23996] _PyGen_FetchStopIterationValue() crashes on unnormalised exceptions

2015-08-03 Thread Stefan Behnel
Stefan Behnel added the comment: The fix wasn't applied yet, so the current code in 3.4 and later branches is still incorrect. Any of the last two patches (*_value) will fix it, with my preference on the last one. -- versions: +Python 3.6 ___

[issue23996] _PyGen_FetchStopIterationValue() crashes on unnormalised exceptions

2015-08-03 Thread Antoine Pitrou
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +giampaolo.rodola, gvanrossum, haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23996 ___

[issue20362] longMessage attribute is ignored in unittest.TestCase.assertRegexpMatches etc

2015-08-03 Thread Arnon Yaari
Arnon Yaari added the comment: * The removal of the 'kot' test is ok. That's what the fix is about. With longMessage set to False, we should only see the custom message, 'Message', and not the message about the regex that contains 'kot'. * Please update the patch for 3.5 to use assertRegex and

[issue24784] Build fails --without-threads

2015-08-03 Thread Louis Dassy
New submission from Louis Dassy: Build of default branch fails using --without-threads. I added the WITH_THREAD check around PyGILState_Check -- components: Build files: without-threads.patch keywords: patch messages: 247921 nosy: berker.peksag, louis.dassy, python-dev priority: normal

[issue24383] consider implementing __await__ on concurrent.futures.Future

2015-08-03 Thread Guido van Rossum
Guido van Rossum added the comment: Every individual use case can be dealt with easily by adding simple helper functions. I really want to keep async and threads separate. And it's no coincidence that concurrent.futures is threadsafe; that's part of its spec. --

[issue23996] _PyGen_FetchStopIterationValue() crashes on unnormalised exceptions

2015-08-03 Thread Yury Selivanov
Yury Selivanov added the comment: Any of the last two patches (*_value) will fix it, with my preference on the last one. Stefan, the last patch looks good to me. Do you think we can have a unittest for this? -- ___ Python tracker

[issue23996] _PyGen_FetchStopIterationValue() crashes on unnormalised exceptions

2015-08-03 Thread Stefan Behnel
Stefan Behnel added the comment: Regarding tests, it looks like iteration isn't currently tested at the C level at all. At least, the xx test modules don't have any types that use it. I can write one up next week, or add it to one of the existing types (Xxo_Type?). Unlikely that I'll make the

[issue10708] Misc/porting should be folded into the development FAQ or the devguide

2015-08-03 Thread Paul Anton Letnes
Paul Anton Letnes added the comment: I believe someone should also commit the following command: hg rm Misc/porting in the main python repository, since the contents of this file are now found in the devguide. -- ___ Python tracker

[issue24778] mailcap.findmatch() ........ Shell Command Injection in filename

2015-08-03 Thread R. David Murray
R. David Murray added the comment: In this case os.system is an appropriate API, because it mirrors the API of mailcap itself (that is, mailcap entries are shell commands). I'm not convinced there is a security bug here. It seems to me that there are two cases: either the filename is

[issue24754] argparse add_argument with action=store_true, type=bool should not crash

2015-08-03 Thread paul j3
paul j3 added the comment: Right, the only arguments that a `store_true` Action class accepts are: option_strings, dest, default=False,required=False, help=None parser.add_argument() massages its parameters a bit, and then uses the 'action' parameter to construct an Action subclass

[issue24775] Python client failing to connect to server but completing as if successful

2015-08-03 Thread R. David Murray
R. David Murray added the comment: If whatever change fixed this has not already been backported to 2.7, it is likely that whatever it was was deemed to complex for backport. If someone can figure out what the fix was and propose a reasonable way to back port it, we would most likely do so.

[issue24647] Document argparse.REMAINDER as being equal to ...

2015-08-03 Thread paul j3
paul j3 added the comment: Also, argparse.PARSER is '+...' '? * +' have closely matched analogs in regex patterns. '...' and '+...' do not. So Python users will have an intuitive idea of what nargs='*' means. nargs='...' is not so obvious. As a general rule, the document does not expose

[issue24129] Incorrect (misleading) statement in the execution model documentation

2015-08-03 Thread R. David Murray
R. David Murray added the comment: Your ping after a month is very appropriate. It looks like yes, this is waiting for another review. Based on the fact that the previous patches were reviewed by core devs and you have responded, I'm moving it to 'commit review', but I haven't looked at the

[issue24739] allow argparse.FileType to accept newline argument

2015-08-03 Thread paul j3
paul j3 added the comment: argparse.FileType serves 2 purposes - handling filenames for simple quick shell-like scripts - as a model for custom 'types', specifically one that uses a class to generate the desired type callable. Other bug-issues show that it hasn't aged well. It doesn't work

[issue23996] _PyGen_FetchStopIterationValue() crashes on unnormalised exceptions

2015-08-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Is it possible to test from Python level? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23996 ___ ___

[issue24736] argparse add_mutually_exclusive_group do not print help

2015-08-03 Thread paul j3
paul j3 added the comment: These two types of groups serve different purposes and aren't designed to nest or interact. An argument group groups arguments in the help lines. It does not affect parsing at all. It can't be used to add a 'group' of arguments to another group. A mutually

[issue24785] Document asyncio.futures.wrap_future()

2015-08-03 Thread Berker Peksag
Berker Peksag added the comment: This is a duplicate of issue 24755. -- nosy: +berker.peksag resolution: - duplicate stage: - resolved status: open - closed superseder: - asyncio.wrap_future undocumented ___ Python tracker rep...@bugs.python.org

[issue24755] asyncio.wrap_future undocumented

2015-08-03 Thread Alex Grönholm
Changes by Alex Grönholm alex.gronholm+pyt...@nextday.fi: -- nosy: +alex.gronholm ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24755 ___ ___

[issue24778] mailcap.findmatch() ........ Shell Command Injection in filename

2015-08-03 Thread Bernd Dietzel
Bernd Dietzel added the comment: @David Thanks for the comment :-) I think if you read the Documentation https://docs.python.org/2/library/mailcap.html this may lead new programmers, wich may never heard of Shell Injections before, step by step directly to write insecure webbbrowsers and/or

[issue24782] Merge 'configure extensions' into main IDLE config dialog

2015-08-03 Thread Mark Roseman
Mark Roseman added the comment: Screenshot extdlg.png shows result -- Added file: http://bugs.python.org/file40119/extdlg.png ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24782 ___

[issue22397] test_socket failure on AIX

2015-08-03 Thread STINNER Victor
STINNER Victor added the comment: I'm not interested to investigate the issue on AIX. IMHO the feature is just not supported by the kernel so there is nothing to investigate except if you want to hack AIX kernel. -- title: test_socket not running all tests on AIX - test_socket failure

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-08-03 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- versions: +Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23725 ___ ___

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-08-03 Thread Robert Collins
Robert Collins added the comment: I'm not 100% sure that tempfile.tempdir should be deprecated. Its much less convenient to control global behaviour with that. I agree that mktemp should be. I've updated the patch though. -- nosy: +rbcollins Added file:

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

2015-08-03 Thread Robert Collins
Robert Collins added the comment: So I'm confused. Is this applicable or not? Its in commit review, but there's discussion of politics here :(. -- nosy: +rbcollins status: open - pending ___ Python tracker rep...@bugs.python.org

[issue24780] unittest assertEqual difference output foiled by newlines

2015-08-03 Thread R. David Murray
R. David Murray added the comment: In this particular case the problem is the lack of a trailing newline on the input string. It might be possible to improve the extended display algorithm by making sure there is a new line before the carrot line, but care must be taken to account for the

[issue24782] Merge 'configure extensions' into main IDLE config dialog

2015-08-03 Thread Mark Roseman
Mark Roseman added the comment: I've attached extdlg.patch, which changes the UI for the configure extensions dialog. In particular, it replaces the stacked tabs with a listbox on the left, with the details of each extension appearing in a labelframe on the right. The inside of the

[issue19475] Add timespec optional flag to datetime isoformat() to choose the precision

2015-08-03 Thread Alessandro Cucci
Alessandro Cucci added the comment: uploaded a new patch! -- Added file: http://bugs.python.org/file40117/issue19475_v3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19475 ___

[issue24272] PEP 484 docs

2015-08-03 Thread Guido van