[issue25820] Clean up run_gdb() calls

Serhiy Storchaka added the comment: LGTM. -- nosy: +serhiy.storchaka stage: patch review -> commit review ___ Python tracker ___

[issue23788] test_urllib2_localnet.test_bad_address fails: OSError not raised by urlopen

Martin Panter added the comment: I propose this patch which merges test_bad_address() from test_urllib2_localnet.py into test_urllibnet.py. It includes applying r75111 to test_urllibnet.py, which adds a trailing dot to the domain name. -- keywords: +patch stage: -> patch review

[issue22758] Regression in Python 3.2 cookie parsing

Tim Graham added the comment: Given the inactivity here, I guess the patch won't be applied before Python 3.2 is end-of-life so I'm going to close the ticket. -- resolution: -> wont fix status: open -> closed ___ Python tracker

[issue24454] Improve the usability of the match object named group API

Eric V. Smith added the comment: Here's the patch. I added some more tests, including tests for ''.format_map(). I think the format_map() tests convince me that keeping None for non-matched groups makes sense. -- assignee: -> eric.smith keywords: +easy, needs review, patch stage:

[issue25624] shutil.make_archive makes invalid directory entries

Changes by Serhiy Storchaka : -- status: closed -> open ___ Python tracker ___ ___

[issue25761] Improve unpickling errors handling

Roundup Robot added the comment: New changeset 001514146c21 by Serhiy Storchaka in branch 'default': Issue #25761: Fixed reference leak added in previous changeset (5c670af0100f). https://hg.python.org/cpython/rev/001514146c21 -- ___ Python tracker

[issue10351] Add autocompletion for keys in dictionaries

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka versions: +Python 3.6 -Python 3.5 ___ Python tracker ___

[issue25624] shutil.make_archive makes invalid directory entries

Serhiy Storchaka added the comment: Larry, is this fix included in 3.5.1? -- ___ Python tracker ___ ___

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

Serhiy Storchaka added the comment: The patch LGTM. Thanks Martin. -- ___ Python tracker ___ ___

[issue23788] test_urllib2_localnet.test_bad_address fails: OSError not raised by urlopen

Martin Panter added the comment: Sorry the revision adding the precondition is 6adab7448272. -- ___ Python tracker ___

[issue15873] datetime: add ability to parse RFC 3339 dates and times

Changes by Piotr Dobrogost : -- nosy: +piotr.dobrogost ___ Python tracker ___

[issue25638] Verify the etree_parse and etree_iterparse benchmarks are working appropriately

Serhiy Storchaka added the comment: The iterparse benchmark in 3.6 still is 30% slower than in 2.7. The parse benchmark is 70% slower. Hence there are other causes of the slowing down. One of causes is that in 3.x an empty dict instead of None is passed to start handler as attrib parameter if

[issue25718] itertools.accumulate __reduce__/__setstate__ bug

Kristján Valur Jónsson added the comment: This could be fixed by saving the accumulate state in a tuple. It would break protocol, though. I don't recall the rules for backwards compatibility of pickles. I've argued before that the state of runtime structures such as generators is so

[issue15068] fileinput requires two EOF when reading stdin

Changes by Kristján Valur Jónsson : -- nosy: -kristjan.jonsson ___ Python tracker ___

[issue25820] Clean up run_gdb() calls

New submission from Martin Panter: This small patch cleans up two oddities calling run_gdb() in /Lib/test/test_gdb.py that I noticed. They were both added in revision b71cda2f48c6. The first one is a whole GDB command being passed to GDB as extra arguments. Notice “gdb --batch -nx” is in the

[issue25821] Documentation for threading.enumerate / threading.Thread.is_alive is contradictory.

Changes by Anthony Green : -- assignee: docs@python components: Documentation nosy: anthonygreen, docs@python, pitrou priority: normal severity: normal status: open title: Documentation for threading.enumerate / threading.Thread.is_alive is contradictory. versions:

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

Martin Panter added the comment: I committed my patch to 3.5+. I will leave this open in case someone wants to look into how things work in 2.7. I presume things might be different in Python 2; all I know is there are two kinds of classes and objects, and the slots are a bit different

[issue25718] itertools.accumulate __reduce__/__setstate__ bug

Serhiy Storchaka added the comment: Well, we can fix this without breaking the protocol. The accumulate() object with state is None can be reconstructed as islice(accumulate(chain([None], iterator)), 1, None). Proposed patch implements this solution. -- Added file:

[issue25819] print "Hi" in python 3 exception handling doesn't work

Zachary Ware added the comment: Also, if you only need to support Python 2.6+, you can use 'from __future__ import print_function' and get all the benefits of 'print' as a function in Python 2 (except the 'flush' argument, which was added in Python 3.3). -- nosy: +zach.ware

[issue25089] Can't run Python Launcher on Windows

Mark Lawrence added the comment: After running the 3.5.1 64 bit web installer the py launcher has again been lost, i.e. "'py' is not recognized as an internal or external command, operable program or batch file." Running the web installer in "repair" mode hasn't made any difference. I've

[issue12509] test_gdb fails on debug build when builddir != srcdir

Martin Panter added the comment: Looks like Mark ment Mercurial revision number 77824, corresponding to abcd29c9a791 (the link assumes Subversion). I think it made it into 3.3 but not 3.2 nor 2.7, so I am closing this. -- nosy: +martin.panter resolution: -> fixed stage: patch review

[issue17772] test_gdb doesn't detect a gdb built with python3.3 (or higher)

Martin Panter added the comment: The change in the patch was applied as part of the commits for Issue 19308, so I assume this is fixed. -- nosy: +martin.panter resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python

[issue23137] Python 2.7.9 test_gdb fails on CentOS 7

Martin Panter added the comment: All the op@entry=. . . stuff suggests that this is the same problem as in Issue 17126; maybe a duplicate? -- nosy: +martin.panter ___ Python tracker

[issue25716] typeobject.c call_method & call_maybe can leak references on 'func'

Myron Walker added the comment: Found this with code inspection -- ___ Python tracker ___ ___

[issue25089] Can't run Python Launcher on Windows

Steve Dower added the comment: There's a separate issue in the 3.5.1 installer where the launcher is always deselected on upgrade. I'm currently working on a fix to force it to always install and we might push out a new 3.5.1 build later today. If you go through Modify rather than Repair then

[issue25591] improve test coverage for the imaplib

Maciej Szulik added the comment: I've just found the original issue where I wanted to submit the new tests. I'm closing this in favor of http://bugs.python.org/issue22137. -- resolution: -> duplicate status: open -> closed ___ Python tracker

[issue25816] https://www.python.org/downloads/ not working for 3.5.1 for windows 10 users

Brett Cannon added the comment: Reported at https://github.com/python/pythondotorg/issues/863 -- nosy: +brett.cannon resolution: -> not a bug status: open -> closed ___ Python tracker

[issue22137] Test imaplib API on all methods specified in RFC 3501

Maciej Szulik added the comment: Resubmitting from http://bugs.python.org/issue25591, which I filled in unnecessarily. Here are the rewritten test case I've developed during PyCon sprints along with David. Once we'll have the entire test suite in place it'll be safer to introduce any

[issue25591] improve test coverage for the imaplib

Changes by Maciej Szulik : -- superseder: -> Test imaplib API on all methods specified in RFC 3501 ___ Python tracker ___

[issue25716] typeobject.c call_method & call_maybe can leak references on 'func'

Myron Walker added the comment: I think this usage of 'call_method' from typeobject.c would cause it to leak. static PyObject* slot_sq_slice(PyObject *self, Py_ssize_t i, Py_ssize_t j) { static PyObject *getslice_str; if (PyErr_WarnPy3k("in 3.x, __getslice__ has been removed; "

[issue25716] typeobject.c call_method & call_maybe can leak references on 'func'

Myron Walker added the comment: I'll file a seperate bug on 'countformat' -- ___ Python tracker ___ ___

[issue25817] modsupport: 'countformat' does not handle strings without bracket levels correctly

New submission from Myron Walker: 'countformat' does not appear to be handling the case where a format string is passed with no parenthesis or brackets correctly. Here is an example of a usage that might cause issues from typedobject.c: static PyObject* slot_sq_slice(PyObject *self, Py_ssize_t

[issue25768] compileall functions do not document or test return values

Brett Cannon added the comment: Your solution to the problem SGTM. And testing compile_path() can be separate method. -- ___ Python tracker ___

[issue21815] imaplib truncates some untagged responses

Maciej Szulik added the comment: Hey Lita, final call ;) Can you address berkerpeksag comments from review? Otherwise, I'm planning to take ownership of this issue and resubmit your patch with addressed comments. -- ___ Python tracker

[issue25817] modsupport: 'countformat' does not handle strings without bracket levels correctly

R. David Murray added the comment: Can you post a reproducer? -- nosy: +r.david.murray ___ Python tracker ___

[issue25716] typeobject.c call_method & call_maybe can leak references on 'func'

Emanuel Barry added the comment: Could you provide actual code where a reference is leaked? To me, this looks like hypothetical failure rather than something that has a chance of occurring - feel free to prove me wrong, though :) Please also include relevant tests. -- nosy: +ebarry

[issue25089] Can't run Python Launcher on Windows

Mark Lawrence added the comment: Using "modify" rather than "repair" fixed the launcher issue, a pity about this. py Python 3.5.1 (v3.5.1:37a07cee5969, Dec 6 2015, 01:54:25) [MSC v.1900 64 bit (AMD64)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> import

[issue25818] If protocol_factory raises an error, the connection closes but no stacktrace is printed on the server.

New submission from Isaac Dickinson: This makes it a nightmare to figure out why your connections are abruptly closing. It should print an error at least. -- components: asyncio files: broken.py messages: 256081 nosy: SunDwarf, gvanrossum, haypo, yselivanov priority: normal severity:

[issue25818] asyncio: If protocol_factory raises an error, the connection closes but no stacktrace is printed on the server.

Changes by Isaac Dickinson : -- title: If protocol_factory raises an error, the connection closes but no stacktrace is printed on the server. -> asyncio: If protocol_factory raises an error, the connection closes but no stacktrace is printed on the server.

[issue25818] asyncio: If protocol_factory raises an error, the connection closes but no stacktrace is printed on the server.

Isaac Dickinson added the comment: I completely forgot asyncio has a debug mode. Ignore this. -- resolution: -> not a bug ___ Python tracker ___

[issue25819] print "Hi" in python 3 exception handling doesn't work

New submission from Calvin Simpkinson: When you execute the code: try: print "Hi" except: print("Hello") in python 3.5, it creates a syntax error in Terminal on Mac and a pop-up error in IDLE, while it should just print Hello in the console. -- messages: 256083 nosy: Calvin

[issue25818] asyncio: If protocol_factory raises an error, the connection closes but no stacktrace is printed on the server.

Changes by Emanuel Barry : -- stage: -> resolved status: open -> closed ___ Python tracker ___

[issue25819] print "Hi" in python 3 exception handling doesn't work

Emanuel Barry added the comment: The reason you are experiencing this behviour is because of the way Python works. Python needs to compile your code before it can execute it. It parses the code, sees an invalid token ('print "Hi"'), fails to compile and throws an error. Your code never gets

[issue25817] modsupport: 'countformat' does not handle strings without bracket levels correctly

Myron Walker added the comment: There is not reproducer for this currently. Its a case of implied or shared usage between a function and the code that uses it. This function is only used in the Python core, so unless it is used incorrectly, by a python extension or modification, it may never

[issue25089] Can't run Python Launcher on Windows

Steve Dower added the comment: Did you deselect everything else? That will remove it all. -- ___ Python tracker ___

[issue25089] Can't run Python Launcher on Windows

Mark Lawrence added the comment: Of course I deselected everything, the only thing I wanted modified was the launcher, I wanted everything else left alone. -- ___ Python tracker

[issue25817] modsupport: 'countformat' does not handle strings without bracket levels correctly

Myron Walker added the comment: There are format string like "O&" being passed in to Py_BuildValue which eventually make their way to 'countformat'. It looks like it would just break after the first & and not count anything else. So Im not sure it gives an accurate count. --

[issue25817] modsupport: 'countformat' does not handle strings without bracket levels correctly

Martin Panter added the comment: I am not seeing any problem. The function is declared static, and is only called with nonzero endchar from do_mkvalue() that I can see. It should not be directly callable from elsewhere. -- nosy: +martin.panter ___

[issue25819] print "Hi" in python 3 exception handling doesn't work

R. David Murray added the comment: By the way, if your goal is to write python2/3 compatible code, notice that 'print("hello")' is valid in python2 and will do the same thing as print "hello"...as long as you don't use commas in the argument list to print. -- nosy: +r.david.murray

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

Roundup Robot added the comment: New changeset 50711c80ff76 by Martin Panter in branch '3.5': Issue #25701: Document C API functions that both set and delete objects https://hg.python.org/cpython/rev/50711c80ff76 New changeset 7bb7173cd97a by Martin Panter in branch 'default': Issue #25701:

[issue25817] modsupport: 'countformat' does not handle strings without bracket levels correctly

Martin Panter added the comment: The breaking for “&” is to keep the count right, because the preceding “O” would already have been counted as one. The “es” code is only documented for parsing values, not for building values. I suggest to close this, unless you can find a specific bug.

[issue25821] Documentation for threading.enumerate / threading.Thread.is_alive is contradictory.

Anthony Green added the comment: The following example comes from IRC user ztane: > import threading, time > > main_thread = threading.current_thread() > > def foo(): > time.sleep(10) > print(main_thread.is_alive()) > print(list(threading.enumerate())) > > t =

[issue25816] https://www.python.org/downloads/ not working for 3.5.1 for windows 10 users

New submission from Laura Creighton: webmaster has heard from 2 windows 10 users who say that when they click on 'download windows 3.5.1' they are sent to this page https://www.python.org/downloads/windows/ instead of actually getting a download. -- messages: 256063 nosy: lac

[issue25821] Documentation for threading.enumerate / threading.Thread.is_alive is contradictory.

New submission from Anthony Green: The documentation at https://docs.python.org/3/library/threading.html#threading.Thread.is_alive relates: > The module function enumerate() returns a list of all alive threads. The documentation at

[issue25817] modsupport: 'countformat' does not handle strings without bracket levels correctly

Myron Walker added the comment: Yes, there are some other cases that look odd to me as if the code is not up to date though. I was looking at the documentation and it mentions format character combinations like 'es' which contain two characters sequences. When I look at this function, it

[issue25089] Can't run Python Launcher on Windows

Steve Dower added the comment: The convention when modifying installations is to specify the end-state that you're want, so unchecking something indicates that you want to remove it. This could be made clearer, but it's probably a significant redesign of the UI. At the least we could specify

[issue25089] Can't run Python Launcher on Windows

Mark Lawrence added the comment: If by "in the text" you mean here https://docs.python.org/3/using/windows.html then yes please, as I find a few minutes of RTFM can save hours of wasted time. -- ___ Python tracker