[issue24110] zipfile.ZipFile.write() does not accept bytes arcname

[Patrik Dufresne]

Patrik Dufresne added the comment:

Manage to work around this issue by using surrogateescape for arcname and 
filename. For me it's no longer an issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7850] platform.system() should be "macosx" instead of "Darwin" on OSX

[Nicholas Chammas]

Nicholas Chammas added the comment:

As of Python 3.5.1 [0], it looks like

1) the `aliased` and `terse` parameters of `platform.platform()` are documented 
to take integers instead of booleans (contrary to what Marc-Andre requested), 
and 

2) calling `platform.platform()` with `aliased` set to 1 or True still returns 
"Darwin" on OS X.

Is this by design?

[0] https://docs.python.org/3.5/library/platform.html#platform.platform

--
nosy: +Nicholas Chammas

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26173] test_ssl.bad_cert_test() exception handling

[Martin Panter]

Martin Panter added the comment:

Updated patch; thanks for the comments Berker

--
Added file: http://bugs.python.org/file41763/separate-test-py3.v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23252] Add support of writing to unseekable file in zipfile

[Patrik Dufresne]

Patrik Dufresne added the comment:

While this path provide support to create Zip file for non-seekable stream. It 
doesn't support reading a file from a non-seekable stream.

--
nosy: +Patrik Dufresne

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26223] decimal.to_eng_string() does not implement engineering notation in all cases.

[Serge Stroobandt]

Serge Stroobandt added the comment:

Related issue:
https://bugs.python.org/issue8060

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Martin Panter]

Martin Panter added the comment:

Seems like a reasonable enhancement. A couple of points:

* Watch out for the parameter names. Should it be “bytes” or “data”?
* Z_DEFAULT_COMPRESSION is -1 not 6 (see Issue 26244)
* Needs a version changed notice, and probably a What’s New update

--
nosy: +martin.panter
stage:  -> patch review
type: behavior -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26244] zlib.compressobj level default value documentation

[Martin Panter]

Martin Panter added the comment:

I’m not sure that is perfectly correct. It really does default to -1, and that 
is passed to the underlying zlib library (-1 = Z_DEFAULT_COMPRESSION). It is 
the zlib library that decides that this means 6, but in theory I guess it could 
be configured or modified in the future with a different default. Perhaps we 
should clarify the text in the documentation (including the doc string) to say 
this instead?

At the very least, the documentation should continue to say that -1 is 
acceptable, and what it means.

--
nosy: +martin.panter
stage:  -> patch review
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25690] Replacement for unittest.mock.mock_open

[Niv Ben-David]

Niv Ben-David added the comment:

Regarding the documentation changes, my version simply mocks `open` more 
"closely", so for the most part I can't think of any changes to the 
documentation. I've added a bit about the mock object acting as a map of file 
names to mock objects. Should I add anything else?

Regarding the tests, I've tried changing as little as possible to make sure I 
don't have any backward compatibility issues. However, some changes had to be 
made:
* By default, `open`'s mode is 'r', the new mock_open imitates this behavior, 
and so the test shows. Also, calling `open` as a context manager will call 
`close` in `__exit__`. These are the majority of changes to the testing code.
* test_mock_open_write and test_mock_open_read_with_argument: These 
functionalities' testing is taken care of by the new mock_open tests.
* test_readlines_data: I removed the `create` argument to `patch`. Must've been 
by accident. Fixed this in the new patch.

Sorry about the (very) late response, I've been preoccupied lately.

--
Added file: http://bugs.python.org/file41762/mock_open.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26241] repr() and str() are identical for floats in 3.5

[Eric V. Smith]

Changes by Eric V. Smith :


--
nosy: +eric.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26242] reST formatting error in Doc/library/importlib.rst

[Berker Peksag]

Berker Peksag added the comment:

I just fixed a similar one in 23cc4b894caf :) Thanks!

--
nosy: +berker.peksag
resolution:  -> fixed
stage:  -> resolved
status: open -> closed
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24905] Allow incremental I/O to blobs in sqlite3

[Aviv Palivoda]

Aviv Palivoda added the comment:

I opened a pull request for blob support in the pysqlite github repository:
https://github.com/ghaering/pysqlite/pull/93

I will do the needed changes for python3 and will post a patch soon.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26242] reST formatting error in Doc/library/importlib.rst

[Alex Gaynor]

New submission from Alex Gaynor:

https://hg.python.org/cpython/file/default/Doc/library/importlib.rst#l1124

the spacing is wrong, it should be:

.. versionchanged:: 3.5

--
assignee: docs@python
components: Documentation
messages: 259263
nosy: alex, docs@python, eric.araujo, ezio.melotti, georg.brandl
priority: normal
severity: normal
status: open
title: reST formatting error in Doc/library/importlib.rst
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26209] TypeError in smtpd module with string arguments

[Berker Peksag]

Berker Peksag added the comment:

There is a strong change that smtpd is going to be deprecated in Python 3.6. 
See issue 25008 for details.

+1 for improving documentation.

--
assignee:  -> docs@python
components: +Documentation -Library (Lib)
keywords: +easy
nosy: +berker.peksag, docs@python
stage:  -> needs patch
type: behavior -> enhancement
versions: +Python 2.7, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26244] zlib.compressobj level default value documentation

[Aviv Palivoda]

New submission from Aviv Palivoda:

In the zlib.compressobj documentation the default value of the compress level 
is -1 while it is actually 6.

patch is included

--
assignee: docs@python
components: Documentation, Extension Modules
files: zlib-compressobj-level-doc.patch
keywords: patch
messages: 259267
nosy: docs@python, nadeem.vawda, palaviv, twouters
priority: normal
severity: normal
status: open
title: zlib.compressobj level default value documentation
versions: Python 3.6
Added file: http://bugs.python.org/file41761/zlib-compressobj-level-doc.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Aviv Palivoda]

New submission from Aviv Palivoda:

Currently zlib.compress allow only positional arguments. For code readability 
reasons i think that we should allow the level argument to be keyword argument. 
Now when someone uses zlib.compress he will be able to do 
zlib.compess(some_data, level=7) instead of zlib.compress(some_data, 7).

There is a patch included with the change.

--
components: Extension Modules
files: zlib-compress-level-keyword.patch
keywords: patch
messages: 259266
nosy: nadeem.vawda, palaviv, twouters
priority: normal
severity: normal
status: open
title: zlib.compress level as keyword argument
type: behavior
versions: Python 3.6
Added file: http://bugs.python.org/file41760/zlib-compress-level-keyword.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26039] More flexibility in zipfile interface

[Thomas Kluyver]

Thomas Kluyver added the comment:

Thanks Martin for more review; updated open-to-write patch attached.

--
Added file: http://bugs.python.org/file41759/zipfile-open-w4.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26242] reST formatting error in Doc/library/importlib.rst

[Roundup Robot]

Roundup Robot added the comment:

New changeset 9a31895a1c9d by Berker Peksag in branch '3.5':
Issue #26242: Fix another one in importlib.rst
https://hg.python.org/cpython/rev/9a31895a1c9d

New changeset 5452e4b5c007 by Berker Peksag in branch 'default':
Issue #26242: Fix another one in importlib.rst
https://hg.python.org/cpython/rev/5452e4b5c007

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1475692] replacing obj.__dict__ with a subclass of dict

[Josh Rosenberg]

Josh Rosenberg added the comment:

Just FYI, if you're only trying to make immutable objects, that's what 
subclassing tuple with properties and __slots__ = () is for 
(collections.namedtuple does exactly this, building the Python declaration as a 
string and then eval-ing it to produce a tuple subclass with named property 
accessors). The only negative is that it still acts like a sequence, but 
usually that's not a big problem.

--
nosy: +josh.r

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23076] list(pathlib.Path().glob("")) fails with IndexError

[Berker Peksag]

Berker Peksag added the comment:

Thanks for the patch, Thomas!

> Though I've been reading the developer guide, I'm a bit unfamiliar with the 
> process here so I'm not totally sure I'm doing this right.

You did everything right :) I just tweaked the test a bit.

> I created the patch relative to the current default branch (even though the 
> discussion here seems to indicate it should maybe be applied going back a few 
> versions).

Backporting a patch is (most of the time) the core developer's responsibility. 
However, if the patch is going to be very different in maintenance branches 
(let's say 2.7 for example), it would be really helpful to attach a separate 
patch for 2.7.

--
nosy: +berker.peksag
resolution:  -> fixed
stage:  -> resolved
status: open -> closed
type:  -> behavior
versions:  -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23076] list(pathlib.Path().glob("")) fails with IndexError

[Roundup Robot]

Roundup Robot added the comment:

New changeset 35bf4f9e68f3 by Berker Peksag in branch '3.5':
Issue #23076: Path.glob() now raises a ValueError if it's called with an
https://hg.python.org/cpython/rev/35bf4f9e68f3

New changeset 0a6290195f7c by Berker Peksag in branch 'default':
Issue #23076: Path.glob() now raises a ValueError if it's called with an
https://hg.python.org/cpython/rev/0a6290195f7c

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26241] repr() and str() are identical for floats in 3.5

[Anders Rundgren]

Anders Rundgren added the comment:

Apparently the docs have changed since 2.7:
https://docs.python.org/3.5/tutorial/floatingpoint.html

However, the documentation still "sort of" mentions repr() as the most accurate 
form which isn't entirely correct since it nowadays is identical to str() for 
floats.

No big deal, I just thought I was doing something wrong :-)

related: http://bugs.python.org/issue26229

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26039] More flexibility in zipfile interface

[Thomas Kluyver]

Thomas Kluyver added the comment:

Updated version of the ZipInfo.from_file() patch attached.

--
Added file: http://bugs.python.org/file41758/zipinfo-from-file5.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20024] Py_BuildValue() can call Python code with an exception set

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Committed patch fixed the issue only for tuples, but not for lists or dicts. 
See more general patch in issue26168.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26168] Py_BuildValue may leak 'N' arguments on PyTuple_New failure

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Previous attempt to fix reference leaks was in issue984722.

Proposed patch uses different approach. It correctly fixes reference leaks 
after error in processing dict items (like "{()s(())N"), fixes leaksafter 
memory errors on creating tuple, list or dict, fixes issue20024 for lists and 
dicts, fixes use-after-free issue described in msg259242.

But the patch has a disadvantage in comparison with current code. If user 
converter ("O&") accepts Python objects and steal its reference (as "N"), this 
reference will be leaked. This is a price for avoiding potential use-after-free 
issues. Current stdlib code doesn't use converters that steal Python object 
reference. May be we should document this limitation.

--
nosy: +mwh, rhettinger, shredwheat
Added file: http://bugs.python.org/file41757/pybuildvalue_leak2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4806] Function calls taking a generator as star argument can mask TypeErrors in the generator

[Martin Panter]

Martin Panter added the comment:

In Python 2, the old-style “instance” objects are making it hard to fix this 
like in Python 3. And completely removing the custom error message seems a bit 
drastic for 2.7.

Instead, I propose to just check for a generator type after the TypeError is 
caught, and don’t bother checking for other kinds of iterables and sequences.

--
stage: commit review -> patch review
Added file: http://bugs.python.org/file41756/check-generator-py2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26241] repr() and str() are identical for floats in 3.5

[Mark Dickinson]

Changes by Mark Dickinson :


--
nosy: +mark.dickinson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26185] zipfile.ZipInfo slots can raise unexpected AttributeError

[Thomas Kluyver]

Changes by Thomas Kluyver :


--
nosy: +takluyver

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26241] repr() and str() are identical for floats in 3.5

[Martin Panter]

Martin Panter added the comment:

This discrepancy was supposed to be eliminated in 3.2; see Issue 9337. So 
assuming you are looking at the right version, it is the documentation that is 
at fault.

--
assignee:  -> docs@python
components: +Documentation -Interpreter Core
nosy: +docs@python, martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26168] Py_BuildValue may leak 'N' arguments on PyTuple_New failure

[Martin Panter]

Martin Panter added the comment:

I was going to suggest just documenting your use-after-free case as a 
limitation of the N format. I doubt there is much demand to give away a 
borrowed reference with N _and_ rely on that borrowed reference staying alive 
for other parameters. It seems a lot of churn just to avoid a theoretical 
problem.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26216] run runtktests.py error when test tkinter

[Martin Panter]

Martin Panter added the comment:

According to Issue 18018, the SystemError is changed to ImportError in 3.6, and 
in Python 2 (or before 3.3) it raised ValueError.

To me, the more important question is: is running runtktests.py as a file meant 
to be supported, or should it be run as python -m tkinter.test.runtktests?

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26241] repr() and str() are identical for floats in 3.5

[Mark Dickinson]

Mark Dickinson added the comment:

Closing: as Martin pointed out, the behaviour is intentional, and without a 
reference to a particular part of the documentation this issue isn't useful. 
(Anders: if you find a part of the 3.5 documentation that does state that str 
and repr are different for floats, please feel free to re-open and link to that 
section of the documentation so that it can be fixed.)

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26241] repr() and str() are identical for floats in 3.5

[Eryk Sun]

Eryk Sun added the comment:

> A test with a 100 million random and selected IEEE 64-bit values 
> returned no differences

The float type's tp_str and tp_repr both call float_repr in 
Objects/floatobject.c. See the 3.5.1 PyFloat_Type definition [1].

Perhaps you were reading something in reference to Python 2, which has separate 
float_str and float_repr functions. See the 2.7.11 PyFloat_Type definition [2] 
and the header file where PyFloat_STR_PRECISION is defined to be 12 digits [3].

[1]: https://hg.python.org/cpython/file/v3.5.1/Objects/floatobject.c#l1839
[2]: https://hg.python.org/cpython/file/v2.7.11/Objects/floatobject.c#l2118
[3]: https://hg.python.org/cpython/file/v2.7.11/Include/floatobject.h#l24

--
nosy: +eryksun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26222] Missing code in linux_distribution python 2.7.11

[Berker Peksag]

Changes by Berker Peksag :


--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26241] repr() and str() are identical for floats in 3.5

[SilentGhost]

SilentGhost added the comment:

Would you mind linking to the relevant part of documentation?

--
nosy: +SilentGhost

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26229] Make number serialization ES6/V8 compatible

[Anders Rundgren]

Anders Rundgren added the comment:

As I said, the problem is close to fixed in 3.5.

You should not consider the JCS specification as the [sole] target but the 
ability to creating a normalized JSON object which has many uses including 
calculating a hash of such objects.

##
# Convert a Python double/float into an ES6/V8 compatible string #
##
def convert2Es6Format(value):
# Convert double/float to str using the native Python formatter
pyDouble = str(value)
pySign = ''
if pyDouble.find('-') == 0:
#
# Save sign separately, it doesn't have any role in the rest
#
pySign = '-'
pyDouble = pyDouble[1:]
pyExpStr = ''
pyExpVal = 0
q = pyDouble.find('e')
if q > 0:
#
# Grab the exponent and remove it from the number
#
pyExpStr = pyDouble[q:]
if pyExpStr[2:3] == '0':
#
# Supress leading zero on exponents
#
pyExpStr = pyExpStr[0:2] + pyExpStr[3:]
pyDouble = pyDouble[0:q]
pyExpVal = int(pyExpStr[1:])
#
# Split number in pyFirst + pyDot + pyLast
#
pyFirst = pyDouble
pyDot = ''
pyLast = ''
q = pyDouble.find('.')
if q > 0:
pyDot = '.'
pyFirst = pyDouble[0:q]
pyLast = pyDouble[q + 1:]
#
# Now the string is split into: pySign + pyFirst + pyDot + pyLast + pyExpStr
#
if pyLast == '0':
#
# Always remove trailing .0
#
pyDot = ''
pyLast = ''
if pyExpVal > 0 and pyExpVal < 21:
#
# Integers are shown as is with up to 21 digits
#
pyFirst += pyLast
pyLast = ''
pyDot = ''
pyExpStr = ''
q = pyExpVal - len(pyFirst)
while q >= 0:
q -= 1;
pyFirst += '0'
elif pyExpVal < 0 and pyExpVal > -7:
#
# Small numbers are shown as 0.etc with e-6 as lower limit
#
pyLast = pyFirst + pyLast
pyFirst = '0'
pyDot = '.'
pyExpStr = ''
q = pyExpVal
while q < -1:
q += 1;
pyLast = '0' + pyLast
#
# The resulting sub-strings are concatenated
#
return pySign + pyFirst + pyDot + pyLast + pyExpStr

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26241] repr() and str() are identical for floats in 3.5

[Anders Rundgren]

New submission from Anders Rundgren:

According to the documentation repr() and str() are different when it comes to 
number formatting.  A test with a 100 million random and selected IEEE 64-bit 
values returned no differences

--
components: Interpreter Core
messages: 259244
nosy: anders.rundgren@gmail.com
priority: normal
severity: normal
status: open
title: repr() and str() are identical for floats in 3.5
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4806] Function calls taking a generator as star argument can mask TypeErrors in the generator

[Roundup Robot]

Roundup Robot added the comment:

New changeset 1a8dc350962b by Martin Panter in branch '3.5':
Issue #4806: Avoid masking original TypeError in call with * unpacking
https://hg.python.org/cpython/rev/1a8dc350962b

New changeset 1261f5f6fc95 by Martin Panter in branch 'default':
Issue #4806: Merge * unpacking fix from 3.5
https://hg.python.org/cpython/rev/1261f5f6fc95

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com