[issue27059] find_spec and find_loader ignore package/path argument

Gerrit Ansmann added the comment: > If you think the docs aren't clear enough then please feel free to submit a > patch to make them a bit clearer. I intend to do that. However, before I do so: Given that `find_loader` shall be superseded by `find_spec`, how would I use the latter to find the

[issue27070] Add ability to freeze (seal) mutable objects

Марк Коренберг added the comment: Great. Do you have information why this PEP was rejected? This was exactly what I want. -- ___ Python tracker ___

[issue27071] unittest.TestCase.assertCountEqual is a very misleading name

Vitaly added the comment: The new name by itself does not sufficiently reflect the subtlety of element-by-element counts, which does a disservice to the readability of test code. And it's also an unnecessary incompatibility between 2.7 and 3.x. --

[issue27060] Documentation of assertItemsEqual in unittest is VERY misleading in 2.7

Vitaly added the comment: ... and an unnecessary incompatibility between 2.7 and 3.x -- ___ Python tracker ___

[issue27060] Documentation of assertItemsEqual in unittest is VERY misleading in 2.7

Vitaly added the comment: Yes, this caused me to examine Counter, which I had not used before, and now I understand it, too. However, the new name by itself does not sufficiently reflect the subtlety of element-by-element counts, which does a disservice to the readability of test code.

[issue27060] Documentation of assertItemsEqual in unittest is VERY misleading in 2.7

Terry J. Reedy added the comment: It compares element by element counts, as indicated by "Equivalent to: assertEqual(Counter(list(first)), Counter(list(second))) ..." and the failure messages. Since I understand Counter equality, I ignore the rest. -- resolution: -> not a bug stage:

[issue27071] unittest.TestCase.assertCountEqual is a very misleading name

New submission from Vitaly: Somewhere in 3.x assertItemsEqual was renamed to assertCountEqual. assertCountEqual sounds like a really inappropriate, misleading name for what it does. It misleads users into thinking that it only compares the number of elements in each sequence, whereas it

[issue17866] TestCase.assertItemsEqual exists in 2.7, not in 3.3

Vitaly added the comment: Folks, assertCountEqual sounds like a really bad name. It misleads users into thinking that it only compares the number of elements in each sequence, whereas it actually asserts that equivalent items are present in both sequences, regardless of order. The original

[issue27060] Documentation of assertItemsEqual in unittest is VERY misleading in 2.7

Vitaly added the comment: I think that we can close this as not a bug, as concerning 2.7. However, I think that 3.x made the wrong decision when it renamed assertItemsEqual with assertCountEqual, which now misleads users into thinking that it compares counts. --

[issue27060] Documentation of assertItemsEqual in unittest is VERY misleading in 2.7

Vitaly added the comment: Thanks Terry, your assessment is correct. The maintainers appear to have drawn the wrong conclusion in #17866, which mislead me about the existing assertItemsEqual in 2.7, which appears to work correctly after all! import unittest as u class Test(u.TestCase): def

[issue27070] Add ability to freeze (seal) mutable objects

Eric V. Smith added the comment: See the rejected PEP 351: https://www.python.org/dev/peps/pep-0351/ -- nosy: +eric.smith ___ Python tracker ___

[issue27060] Documentation of assertItemsEqual in unittest is VERY misleading in 2.7

Vitaly added the comment: According to comment http://bugs.python.org/issue17866#msg188052 in #17866, the maintainers renamed `assertItemsEqual` to `assertCountEqual` somewhere in the 3.x development timeframe. They apparently latched on to the implementation of `assertItemsEqual` in 2.7.x,

[issue27070] Add ability to freeze (seal) mutable objects

ppperry added the comment: Python is not the type of language in which one applies such memory micro-optimizations. In any case, if you really need to do this, use a custom class that subclasses `list` and overrides the modification methods to add a check. --

[issue27070] Add ability to freeze (seal) mutable objects

Марк Коренберг added the comment: making tuples (from lists), fronzensets(from sets) and bytes (from bytearray) requires memory copying. Especially for bytearrays. -- ___ Python tracker

[issue27070] Add ability to freeze (seal) mutable objects

ppperry added the comment: Use tuples, frozensets, and bytes for the first three cases instead. I don't quite see what the benefit of this is. It seems arbitrarily restrictive. -- nosy: +ppperry ___ Python tracker

[issue27064] Make py.exe default to Python 3 when used interactively

Terry J. Reedy added the comment: +1 By 'interactive use', I presume you mean at console command line path\to\somewhere>py... When I installed 3.4.4, I wondered if it would overwrite py with older version. Great that 3.5.x does not. I think each installer should have latest version of

[issue27060] Documentation of assertItemsEqual in unittest is VERY misleading in 2.7

Terry J. Reedy added the comment: Here is the specific test code so you can replace my lists with examples that you think malfunction. import unittest as u class Test(u.TestCase): def test_Count(self): self.assertItemsEqual([1,2,3], [1,2,4]) u.main() --

[issue27060] Documentation of assertItemsEqual in unittest is VERY misleading in 2.7

Terry J. Reedy added the comment: Note: 2.7 doc says that this is renamed assertCountEqual in 3.x. It was added in 2.7 and 3.2. The 3.x doc is essentially the same, but with this instead: "Equivalent to: assertEqual(Counter(list(first)), Counter(list(second))) ...". If the method

[issue26877] tarfile use wrong code when read from fileobj

Марк Коренберг added the comment: Can not reproduce in Linux. Will reopen if reproduced on MacOS X or BSD. #!/usr/bin/python3.5 import os import signal p = os.getpid() if os.fork() == 0: while True: try: os.kill(p, signal.SIGCHLD) except (ProcessLookupError,

[issue16858] tarfile silently hides errors

Марк Коренберг added the comment: OOPS, closed wrong task, reopening. -- resolution: wont fix -> status: closed -> open ___ Python tracker ___

[issue16858] tarfile silently hides errors

Марк Коренберг added the comment: Can not reproduce in Linux. Will reopen if reproduced on MacOS X or BSD. #!/usr/bin/python3.5 import os import signal p = os.getpid() if os.fork() == 0: while True: try: os.kill(p, signal.SIGCHLD) except (ProcessLookupError,

[issue27070] Add ability to freeze (seal) mutable objects

New submission from Марк Коренберг: I mean making mutable object immutable. I speak about List(), Set(), bytearray(), memoryview(), mmap() and so on. bytearray already have `hold`, to lock size only, but it still not represented in Python. -- components: Library (Lib) messages:

[issue27064] Make py.exe default to Python 3 when used interactively

Zachary Ware added the comment: I'm very much +1 on the patch. A couple thoughts: - Note that 2.7 doesn't come with a launcher. - As I understand it, the 3.5+ installer won't overwrite a newer launcher than what it would install, but the 3.4- installer will. So the only really confusing (to

[issue26865] Meta-issue: support of the android platform

Zachary Ware added the comment: Xavier: It's been long enough that I don't remember whether regular Users can adjust Dependencies, but since you didn't do it yourself I assume they can't. I've just given you the Developer role, so you can now :) -- nosy: +zach.ware

[issue27067] Improve curses tests

Berker Peksag added the comment: LGTM. I left some comments on Rietveld. -- nosy: +berker.peksag stage: patch review -> commit review ___ Python tracker

[issue27064] Make py.exe default to Python 3 when used interactively

Paul Moore added the comment: Thanks Ned. Personally, I'm still inclined *not* to add this to 2.7/3.5. People will get it when the install the 3.6 alphas, sure, but that seems to me to be a relatively obvious consequence of installing an alpha that includes a component that's used for all

[issue27063] Some unittest loader tests are silently skipped by mistake

Serhiy Storchaka added the comment: Thank you for review. I found this when wrote patches for removing deprecated features. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue27063] Some unittest loader tests are silently skipped by mistake

Roundup Robot added the comment: New changeset e715ffd2d938 by Serhiy Storchaka in branch '3.5': Issue #27063: Some unittest loader tests were silently skipped. https://hg.python.org/cpython/rev/e715ffd2d938 New changeset f4f615edb6b1 by Serhiy Storchaka in branch 'default': Issue #27063: Some

[issue27063] Some unittest loader tests are silently skipped by mistake

Robert Collins added the comment: LGTM too -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27063] Some unittest loader tests are silently skipped by mistake

Berker Peksag added the comment: LGTM. Just curious, did you find it by reading code or by using some tool? -- nosy: +berker.peksag stage: patch review -> commit review ___ Python tracker

[issue27064] Make py.exe default to Python 3 when used interactively

Ned Deily added the comment: I don't have a strong opinion one way on the matter since I don't have any experience with the launcher. I think I understand the issue of the Windows installer providing "release-independent" components (and, FTR, the OS X installer has a somewhat similar issue

[issue26168] Py_BuildValue may leak 'N' arguments on PyTuple_New failure

Serhiy Storchaka added the comment: Thank you for your review Martin. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue26168] Py_BuildValue may leak 'N' arguments on PyTuple_New failure

Roundup Robot added the comment: New changeset 4e605f809551 by Serhiy Storchaka in branch '3.5': Issue #26168: Fixed possible refleaks in failing Py_BuildValue() with the "N" https://hg.python.org/cpython/rev/4e605f809551 New changeset 0285173d81b4 by Serhiy Storchaka in branch '2.7': Issue

[issue27056] pickle: constant propagation in _Unpickler_Read()

STINNER Victor added the comment: Serhiy Storchaka: > I think that integer overflow in _Unpickler_Read() is possible. n is read > from file and can be arbitrary (up to PY_SSIZE_T_MAX). This likely cause > raising an exception later, but integer overflow itself causes undefined > behavior, and

[issue27056] pickle: constant propagation in _Unpickler_Read()

Roundup Robot added the comment: New changeset 3d7b7aa89437 by Victor Stinner in branch 'default': Issue #27056: Fix _Unpickler_Read() to avoid integer overflow https://hg.python.org/cpython/rev/3d7b7aa89437 -- ___ Python tracker

[issue24712] Docs page's sidebar vibrates on mouse wheel scroll on Chrome.

Mike Taylor added the comment: The bug for Chrome to ship support of position: sticky is here: https://bugs.chromium.org/p/chromium/issues/detail?id=231752 -- it's in active development. But this patch fixes the jerky sidebar in Firefox as well. --

[issue24712] Docs page's sidebar vibrates on mouse wheel scroll on Chrome.

Mike Taylor added the comment: OK, so uh, somehow a few months escaped me before I could get to this. >_> (I've also just signed the Contributor Agreement with the PSF) -- keywords: +patch Added file: http://bugs.python.org/file42917/docs-sidebar.patch

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue27064] Make py.exe default to Python 3 when used interactively

Paul Moore added the comment: Because of the nature of the launcher, there's not much we can do about that IMO. And there was no real objection to changing the default on the python-ideas thread (at least for interactive use). But I'll wait to see if Ned has anything to add. --

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Changes by Berker Peksag : -- dependencies: +Update test_base64 to use test.support.script_helper, Update test_capi to use test.support.script_helper ___ Python tracker

[issue24398] Update test_capi to use test.support.script_helper

Changes by Berker Peksag : -- components: +Tests keywords: +easy stage: -> needs patch type: -> enhancement ___ Python tracker

[issue27064] Make py.exe default to Python 3 when used interactively

Steve Dower added the comment: It'll change their default behavior if they get an alpha release of 3.6 though, and uninstalling the alpha won't revert it. That said, I don't really feel like the launcher is an "alpha" product, even if the core Python engine is in that state. Possibly the RM

[issue25533] Make pkgutil.iter_modules() yield built-in modules

Martin Panter added the comment: iter-builtins-flag.patch has support for built-in modules via the builtins=True flag, but I removed the support for frozen modules. -- stage: -> patch review Added file: http://bugs.python.org/file42916/iter-builtins-flag.patch

[issue27069] webbrowser creates zombi processes in the background mode

Martin Panter added the comment: I think the Firefox command will exit immediately if it just signals an existing Firefox process and window, but becomes the main Firefox process if there isn’t already one running. Background = False sounds like it won’t help. Don’t we want the opposite?

[issue27056] pickle: constant propagation in _Unpickler_Read()

Serhiy Storchaka added the comment: I think that integer overflow in _Unpickler_Read() is possible. n is read from file and can be arbitrary (up to PY_SSIZE_T_MAX). This likely cause raising an exception later, but integer overflow itself causes undefined behavior, and we should avoid it.

[issue27069] webbrowser creates zombi processes in the background mode

STINNER Victor added the comment: I checked how "xdg-open http://www.python.org/; works. It looks like the command works as webbrowser: create a child process "firefox URL", but then it waits until the command completes. In fact, "firefox URL" exits quickly. So we can try "background = False"

[issue27068] Add a detach() method to subprocess.Popen

Martin Panter added the comment: In this example, I think we want to drop the zombie so the “init” process will call wait() on it. My pseudocode is similar to your fork() suggestion in Issue 27069. Fork returns the child’s PID, but we would ignore the PID and exit the intermediate parent

[issue27068] Add a detach() method to subprocess.Popen

STINNER Victor added the comment: Martin Panter: > One potential way to fix Issue 27069 (leave a webbrowser running in the > background) might be to use a detach() method. Pseudocode: Your code is a workaround to hide the warning, it doesn't fix the bug (creating a zombi process). --

[issue27068] Add a detach() method to subprocess.Popen

Martin Panter added the comment: One potential way to fix Issue 27069 (leave a webbrowser running in the background) might be to use a detach() method. Pseudocode: launcher = """\ import subprocess, sys proc = subprocess.Popen(sys.argv) # Popen object gives up “ownership” of child. # Caller

[issue26741] subprocess.Popen should emit a ResourceWarning in destructor if the process is still running

STINNER Victor added the comment: > At this point, the Python interpreter has a child process “chromium” which is > left as a zombie when it exits. The new ResourceWarning is the confirmation that there is an issue. Creating a zombi process is not a good idea :-) I opened the issue #27069 to

[issue27069] webbrowser creates zombi processes in the background mode

New submission from STINNER Victor: The webbrowser opens almost all browsers in background mode, it looks like only Elinks is not opened in this mode. Problem: the webbrowser doesn't read the exit status of the browser, and so create zombi process. On Python 3.6, the subprocess module now

[issue26741] subprocess.Popen should emit a ResourceWarning in destructor if the process is still running

Martin Panter added the comment: I tried out your code on the webbrowser module, and it does raise a warning: >>> import webbrowser >>> b = webbrowser.get("chromium") >>> b.open("https://bugs.python.org/issue26741;) /home/proj/python/cpython/Lib/subprocess.py:1011: ResourceWarning: running

[issue26814] [WIP] Add a new _PyObject_FastCall() function which avoids the creation of a tuple or dict for arguments

STINNER Victor added the comment: > unpickle_list: 1.11x faster This result was unfair: my fastcall branch contained the optimization of the issue #27056. I just pushed this optimization into the default branch. I ran again the benchmark: the result is now "not significant", as expected,

[issue26741] subprocess.Popen should emit a ResourceWarning in destructor if the process is still running

Changes by STINNER Victor : -- resolution: fixed -> status: closed -> open ___ Python tracker ___

[issue26970] Replace OpenSSL's CPRNG with system entropy source

Christian Heimes added the comment: My remark was ambiguous. I meant that I have to create an second implementation of _PyOS_URandom and use it in _ssl_osrandom_bytes. Let's discuss the details on IRC after PyCon. I'm busy with preparations. -- ___

[issue25285] regrtest: run tests in subprocesses with -j1 on buildbots

STINNER Victor added the comment: changeset: 101449:6f7e5b51c8fb user:Victor Stinner date:Fri May 20 13:15:55 2016 +0200 files: Lib/test/libregrtest/cmdline.py Misc/NEWS Tools/buildbot/test.bat description: regrtest doesn't ignore -j1 anymore *

[issue27068] Add a detach() method to subprocess.Popen

STINNER Victor added the comment: Hum, I had to patch asyncio to avoid a ResourceWarning because asyncio polls the status of the child process using a child watcher, whereas the Popen object is not aware of the child watcher: New changeset 72946937536e by Victor Stinner in branch '3.5':

[issue26741] subprocess.Popen should emit a ResourceWarning in destructor if the process is still running

Roundup Robot added the comment: New changeset 72946937536e by Victor Stinner in branch '3.5': asyncio: fix ResourceWarning related to subprocesses https://hg.python.org/cpython/rev/72946937536e New changeset 911f398c6396 by Victor Stinner in branch 'default': Merge 3.5 (issue #26741)

[issue26530] tracemalloc: add C API to manually track/untrack memory allocations

STINNER Victor added the comment: Nathaniel, Antoine: ping again? No reaction to the new shiny C API of tracemalloc that *you* requested? :-p -- ___ Python tracker

[issue26741] subprocess.Popen should emit a ResourceWarning in destructor if the process is still running

STINNER Victor added the comment: Martin Panter: > I think the basic idea of adding the warning is good. Cool. I pushed an enhanced version of my patch: * I fixed _execute_child() to set correctly the returncode attribute * I splitted the patch into multiple commits and I documented the doc *

[issue26741] subprocess.Popen should emit a ResourceWarning in destructor if the process is still running

Roundup Robot added the comment: New changeset b122011b139e by Victor Stinner in branch 'default': Use "with popen:" in test_subprocess https://hg.python.org/cpython/rev/b122011b139e New changeset 4c02b983bd5f by Victor Stinner in branch 'default': Issue #26741: POSIX implementation of

[issue27068] Add a detach() method to subprocess.Popen

Changes by STINNER Victor : -- nosy: +martin.panter ___ Python tracker ___ ___

[issue27068] Add a detach() method to subprocess.Popen

New submission from STINNER Victor: The issue #26741 modified the subprocess.Popen destructor to emit a ResourceWarning if the child process is still running. According to Martin Panter, it can be deliberate to let the subprocess running if the management of the subprocess is delegated to a

[issue26858] android: setting SO_REUSEPORT fails

Xavier de Gaye added the comment: Should use boolean 'is_android' being added to module test.support by issue #27027, instead of platform.android_ver()[0]. -- ___ Python tracker

[issue26850] PyMem_RawMalloc(): update also sys.getallocatedblocks() in debug mode

STINNER Victor added the comment: I'm not convinced myself by this change, it may make detection of memory leaks much more tricky for a little gain. I prefer to reject my own issue ;-) -- resolution: -> rejected status: open -> closed ___ Python

[issue27056] pickle: constant propagation in _Unpickler_Read()

STINNER Victor added the comment: Serhiy Storchaka: "I forgot to note that the comment before _Unpickler_Read() becomes not correct, but you already addressed this in the second patch. unpickle_read-2.patch LGTM." Cool, pushed. "Few months ago I tried to optimize reading in pickle, but

[issue27056] pickle: constant propagation in _Unpickler_Read()

Roundup Robot added the comment: New changeset f9b85b47f9c8 by Victor Stinner in branch 'default': Optimize pickle.load() and pickle.loads() https://hg.python.org/cpython/rev/f9b85b47f9c8 -- nosy: +python-dev ___ Python tracker

[issue26931] android: test_distutils fails

Xavier de Gaye added the comment: This new patch adds a dependency to issue #27027. -- Added file: http://bugs.python.org/file42915/android-sh-path_2.patch ___ Python tracker

[issue26948] Simplify PyImport_ImportModuleLevelObject: avoid temporary tuple of str.partition/rpartition

STINNER Victor added the comment: I modified my patch to address Serhiy's comments. Thanks for the your review Serhiy. changeset: 101442:779563dd701c tag: tip user:Victor Stinner date:Fri May 20 11:36:13 2016 +0200 files:

[issue27056] pickle: constant propagation in _Unpickler_Read()

Serhiy Storchaka added the comment: I forgot to note that the comment before _Unpickler_Read() becomes not correct, but you already addressed this in the second patch. unpickle_read-2.patch LGTM. Few months ago I tried to optimize reading in pickle, but didn't see significant benefit. After

[issue26369] unicode.decode and str.encode are unnecessarily confusing for non-ascii

Ben Spiller added the comment: Thanks for considering this, anyway. I'll admit I'm disappointed we couldn't fix this on the 2.7 train, as to me fixing a method that takes an errors='ignore' argument and then throws an exception anyway seems a little more like a bug than a feature (and

[issue19695] Clarify how to use various import-related locks

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue27056] pickle: constant propagation in _Unpickler_Read()

STINNER Victor added the comment: Updated patch 2 to address Serhiy's comments. -- Added file: http://bugs.python.org/file42914/unpickle_read-2.patch ___ Python tracker

[issue26856] android does not have pwd.getpwall()

Xavier de Gaye added the comment: This new patch adds a dependency to issue #27027. -- Added file: http://bugs.python.org/file42913/pwd_2.patch ___ Python tracker

[issue26647] ceval: use Wordcode, 16-bit bytecode

STINNER Victor added the comment: I regenerated wpy8.patch with Mercurial. I had to fix a minor conflict in Lib/importlib/_bootstrap_external.py. (I didn't read the patch.) -- ___ Python tracker

[issue26647] ceval: use Wordcode, 16-bit bytecode

Changes by STINNER Victor : Added file: http://bugs.python.org/file42912/wpy8.patch ___ Python tracker ___

[issue26647] ceval: use Wordcode, 16-bit bytecode

Serhiy Storchaka added the comment: Added new comments on Rietveld. -- stage: -> patch review ___ Python tracker ___

[issue26919] android: test_cmd_line fails

Xavier de Gaye added the comment: This new patch adds a dependency to issue #27027. -- Added file: http://bugs.python.org/file42911/retrofit_osx_3.patch ___ Python tracker

[issue27027] add is_android in test.support to detect Android platform

Xavier de Gaye added the comment: The patch adds a dependency to issue #26855. -- keywords: +patch Added file: http://bugs.python.org/file42910/is_android.patch ___ Python tracker

[issue27067] Improve curses tests

New submission from Serhiy Storchaka: Proposed patch improves curses tests. Main improvements are: * Tests now run even if sys.stdout is not terminal. * The screen is not spoiled during tests. * Reported the name and arguments of failed function. * Testing optional functionality is extracted in

[issue26369] unicode.decode and str.encode are unnecessarily confusing for non-ascii

Marc-Andre Lemburg added the comment: Ben, the methods on stings and Unicode objects in Python 2.x are direct interfaces to the underlying codecs. The codecs can handle any number of input and output types, so there are some which only work on 8-bit strings (bytes) and others which take

[issue27064] Make py.exe default to Python 3 when used interactively

Paul Moore added the comment: Thanks Steve. I wasn't sure over versioning, which is why I decided to be conservative. Also, it's probably not good to change the default behaviour on people when they just install a patch release of 3.5. -- ___

[issue26632] __all__ decorator

Franklin? Lee added the comment: I like how ``@public`` keeps the declaration close to the definition. I am iffy about using ``public`` to define other values. That part might be considered unpythonic. Implementation issues: - ``__module__`` is not reliable. ``functools.wraps`` changes

[issue26632] __all__ decorator

Changes by Serhiy Storchaka : -- nosy: -serhiy.storchaka ___ Python tracker ___

[issue26632] __all__ decorator

Berker Peksag added the comment: +1 for the idea. I saw a lot of different 'all' or 'public' decorators in the wild. It would be nice to have a complete solution in Python. It would be good to add a note to Doc/whatsnew/3.6.rst. -- components: +Interpreter Core nosy: +berker.peksag

[issue27065] robotparser user agent considered hostile by mod_security rules.

Berker Peksag added the comment: Thanks for the report. This is a duplicate of issue 15851. -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Lib/robotparser.py doesn't accept setting a user agent string, instead it uses the