[issue27341] mock.patch decorator fails silently on generators

New submission from Shoshana Berleant: (at least in my case) I committed two tests before I realized the tests were not being run: https://github.com/nipy/nipype/blob/abe7920a051f1570ccce4b71f26f50102d6e4e12/nipype/testing/tests/test_utils.py#L23 I realized this afternoon, while writing some

[issue23360] Content-Type when sending data with urlopen()

Martin Panter added the comment: Fixed conflicts with recent changes -- versions: +Python 2.7 -Python 3.4 Added file: http://bugs.python.org/file43428/non-urlencoded.6.patch ___ Python tracker

[issue23740] http.client request and send method have some datatype issues

Changes by Martin Panter : -- dependencies: +bytes-like objects with socket.sendall(), SSL, and http.client ___ Python tracker ___

[issue27340] bytes-like objects with socket.sendall(), SSL, and http.client

New submission from Martin Panter: According to the documentation, HTTPSConnection.request() should accept arbitrary bytes-like objects, but this is not the case. Currently (since Issue 23756), a “bytes-like object” is defined to be anything that works with Python’s buffer API, as long as it

[issue26867] test_ssl test_options fails on ubuntu 16.04

Martin Panter added the comment: FWIW I imagine Ubuntu overriding the option will break the example code in the documentation of clearing SSL_OP_NO_SSLv3: . If we keep that documentation, I think we should continue to

[issue25724] SSLv3 test failure on Ubuntu 16.04 LTS

Martin Panter added the comment: This patch was also posted to Issue 26867, with a bit more discussion and analysis, so closing as a duplicate. -- resolution: -> duplicate status: open -> closed superseder: -> test_ssl test_options fails on ubuntu 16.04

[issue14562] urllib2 maybe blocks too long with small chunks

Changes by Martin Panter : -- versions: -Python 3.2 ___ Python tracker ___ ___

[issue27335] Clarify that writing to locals() inside a class body is supported

Martin Panter added the comment: I think my proposed patch for Issue 17546 addresses this. That patch was also written to address Issue 17960. -- nosy: +martin.panter ___ Python tracker

[issue27278] py_getrandom() uses an int for syscall() result

STINNER Victor added the comment: > Adding a cast would solve this compiler warning: I changed the code to use the long type. It should fix the warning, even if it was no more a real bug: the original bug was already fixed. I close the issue, it's now solved. -- resolution: -> fixed

[issue27278] py_getrandom() uses an int for syscall() result

Roundup Robot added the comment: New changeset 193f50babfa4 by Victor Stinner in branch '3.5': py_getrandom(): use long type for the syscall() result https://hg.python.org/cpython/rev/193f50babfa4 -- ___ Python tracker

[issue27339] Security Issue: Typosquatting

STINNER Victor added the comment: Hum, I guess that you are talking about https://pypi.python.org/pypi ? If yes, you should open an issue in their bug tracker: https://bitbucket.org/pypa/pypi/issues By the way, I don't see any obvious fix for typo squatting. -- nosy: +haypo

[issue26171] heap overflow in zipimporter module

Vlad K. added the comment: Here's the patch that I made for FreeBSD's Python 3.3 port. With this patch, on FreeBSD, Python 3.3 built fine and passed the zipimport related unit tests. It's basically the same code from 3.4, 3.5 and 2.7, just placed at appropriate place in the source.

[issue26439] ctypes.util.find_library fails when ldconfig/glibc not available (e.g., AIX)

Michael Felt added the comment: updated patch for Python 2.7 (shall adopt and submit new patch for Python3 based on this - next week) used gnu diff to generate diff output. Additional tests in util.py are for demo only, would expect them to be removed, however, the additional test in

[issue26171] heap overflow in zipimporter module

Ned Deily added the comment: reopening for 3.3.7 evaluation. Georg? -- nosy: +georg.brandl, ned.deily priority: normal -> resolution: fixed -> stage: resolved -> needs patch status: closed -> open versions: +Python 3.3 ___ Python tracker

[issue26439] ctypes.util.find_library fails when ldconfig/glibc not available (e.g., AIX)

Michael Felt added the comment: The patch for Python2 - however, only now see the change in selections for version. Will need to redo/test Lib/ctypes/*.py in newer version. Note also, the additional tests in util.py are for my testing - I do not expect them to stay, but I do want you aware of

[issue26439] ctypes.util.find_library fails when ldconfig/glibc not available (e.g., AIX)

Michael Felt added the comment: _aixutil.py to be paired with Python2.Lib.ctypes.16.06.11.patch -- Added file: http://bugs.python.org/file43425/_aixutil.py ___ Python tracker

[issue27336] --without-threads build fails due to undeclared _PyGILState_check_enabled

STINNER Victor added the comment: issue27336.diff LGTM with a minor comment on the review. -- ___ Python tracker ___

[issue27336] --without-threads build fails due to undeclared _PyGILState_check_enabled

STINNER Victor added the comment: @Alex Willmer: Why do you build Python without threads? -- ___ Python tracker ___

[issue26171] heap overflow in zipimporter module

Vlad K. added the comment: I believe this should be applied to Python 3.3 as well, since the same problem (unchecked data_size before adding +1 for bytes_size) exists there too, and is thus a security issue. -- nosy: +vladk ___ Python tracker

[issue27339] Security Issue: Typosquatting

New submission from YoSTEALTH: I read this new article that explains Typosquatting well: http://incolumitas.com/2016/06/08/typosquatting-package-managers/ making it known here so python developers can address this issue accordingly! -- messages: 268692 nosy: YoSTEALTH priority: normal

[issue27338] python 2.7 platform.system reports wrong on Mac OS X El Capitan

Changes by Audric D'Hoest (Dr. Pariolo) : -- resolution: -> works for me status: open -> closed ___ Python tracker ___

[issue27338] python 2.7 platform.system reports wrong on Mac OS X El Capitan

Audric D'Hoest (Dr. Pariolo) added the comment: Hello Ned, That is a brilliant answer! After reporting this initially, I tried with 3.5.1, and uname... Convinced it was a 2.7.1, I could not be more wrong! What a stupid and confusing output does the OS report. platform.mac_ver() does the

[issue27336] --without-threads build fails due to undeclared _PyGILState_check_enabled

Berker Peksag added the comment: The attached patch should fix this. -- keywords: +patch nosy: +berker.peksag Added file: http://bugs.python.org/file43424/issue27336.diff ___ Python tracker

[issue27336] --without-threads build fails due to undeclared _PyGILState_check_enabled

Changes by Berker Peksag : -- nosy: +haypo stage: -> patch review type: -> behavior ___ Python tracker ___

[issue27338] python 2.7 platform.system reports wrong on Mac OS X El Capitan

Ned Deily added the comment: Python's platform module has both platform-independent and platform-dependent functions as noted in its documentation. While it isn't as clearly documented as perhaps it should be, on most "Unix-y" platforms, like OS X, much of the platform-independent system

[issue27330] Possible leaks in ctypes

Roundup Robot added the comment: New changeset e04c054beb53 by Serhiy Storchaka in branch '2.7': Issue #27330: Fixed possible leaks in the ctypes module. https://hg.python.org/cpython/rev/e04c054beb53 New changeset 41f99ee19804 by Serhiy Storchaka in branch '3.5': Issue #27330: Fixed possible

[issue27338] python 2.7 platform.system reports wrong on Mac OS X El Capitan

Changes by Audric D'Hoest (Dr. Pariolo) : -- title: python 2.7 platform.system reports wrong -> python 2.7 platform.system reports wrong on Mac OS X El Capitan ___ Python tracker

[issue27338] python 2.7 platform.system reports wrong

New submission from Audric D'Hoest (Dr. Pariolo): Mac mini late 2014, upgraded to El capitan. Out of the box python 2.7 reports the wrong system info. platform.system() should report El Capitan platform.release() should report 10.11.5 -- components: Macintosh files: pybug.png

[issue27337] 3.6.0a2 tarball has weird paths

Changes by Ned Deily : -- Removed message: http://bugs.python.org/msg268685 ___ Python tracker ___

[issue27337] 3.6.0a2 tarball has weird paths

Ned Deily added the comment: That's unfortunate and my fault, basically, the .tgz tarball was built with a BSD-ish tar while the .xz one was built with a GNU tar, as intended. I hate to do a stealth update, unless absolutely necessary, and I don't get see any errors unpacking the .tgz one

[issue27337] 3.6.0a2 tarball has weird paths

Ned Deily added the comment: That's unfortunate and my fault, basically, the .tgz tarball was built with a BSD-ish while the .xz one was built with GNU tar, as intended. I hate to do a stealth update, unless absolutely necessary, and I don't get see any errors unpacking the .tgz one with a

[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

Changes by Christoph Gohlke : -- nosy: +cgohlke ___ Python tracker ___ ___ Python-bugs-list

[issue27337] 3.6.0a2 tarball has weird paths

Changes by Ned Deily : -- assignee: -> ned.deily priority: normal -> high ___ Python tracker ___

[issue27337] 3.6.0a2 tarball has weird paths

Changes by Berker Peksag : -- nosy: +ned.deily ___ Python tracker ___ ___

[issue27337] 3.6.0a2 tarball has weird paths

New submission from Peter Eisentraut: The file Python-3.6.0a2.tgz contains paths that start with "..", e.g., $ tar tf Python-3.6.0a2.tgz | head ../Python-3.6.0a2/ ../Python-3.6.0a2/Doc/ ../Python-3.6.0a2/Grammar/ ../Python-3.6.0a2/Include/ ../Python-3.6.0a2/LICENSE ../Python-3.6.0a2/Lib/

[issue27336] --without-threads build fails due to undeclared _PyGILState_check_enabled

New submission from Alex Willmer: Building current tip (rev 102062:3d726dbfca31), on Ubuntu 16.04/x86_64, using --without-thread fails; with the following error gcc -c -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes-Werror=declaration-after-statement

[issue27335] Clarify that writing to locals() inside a class body is supported

New submission from Steven D'Aprano: The docs for locals() warn not to write to the dict returned, as it may not have the intended effect of modifying the actual variables seen by the interpreter. https://docs.python.org/3/library/functions.html#locals But as I understanding it, using

[issue24887] Sqlite3 has no option to provide open flags

Changes by Berker Peksag : -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue27139] Increased test coverage for statistics.median_grouped

Steven D'Aprano added the comment: Thanks Julio, I hope to get to this over the next week. Please feel free to prod me if you see no action by then. -- ___ Python tracker

[issue27334] pysqlite3 context manager not performing rollback when a database is locked elsewhere for non-DML statements

Berker Peksag added the comment: You may also want to check that the method_name is "commit". A test case would nice to have. Note that the connection context manager will still fail cases like nested context managers. See issue 16958. -- nosy: +berker.peksag, ghaering stage: ->

[issue27139] Increased test coverage for statistics.median_grouped

Julio C Cardoza added the comment: Updated patch file to condense four functions into one function -- Added file: http://bugs.python.org/file43421/test_median_grouped.patch ___ Python tracker

[issue27334] pysqlite3 context manager not performing rollback when a database is locked elsewhere for non-DML statements

New submission from Luca Citi: I have reported this bug to the pysqlite module for python2 ( https://github.com/ghaering/pysqlite/issues/103 ) but I also report it here because it applies to python3 too. The pysqlite3 context manager does not perform a rollback when a transaction fails

[issue27333] validate_step in rangeobject.c, incorrect code logic but right result

Changes by Xiang Zhang : -- components: +Interpreter Core type: -> behavior versions: +Python 2.7, Python 3.5, Python 3.6 ___ Python tracker

[issue27333] validate_step in rangeobject.c, incorrect code logic but right result

New submission from Xiang Zhang: Here is a drawback in validate_step of rangeobject. PyNumber_AsSsize_t returns clipped value and won't set an exception when the argument *exc* is set NULL. So if step overflows, istep is always PY_SSIZE_MAX or PY_SSIZE_MIN. But the following code is to check

[issue27332] Clinic: first parameter for module-level functions should be PyObject*, not PyModuleDef*

New submission from Petr Viktorin: Currently, Argument Clinic generates "PyModuleDef * module" for the first argument of module-level functions. But, the functions are passed the actual module object, not the ModuleDef. The correct type to use is PyObject*, which is used for modules in the

[issue26171] heap overflow in zipimporter module

Changes by STINNER Victor : -- versions: +Python 2.7, Python 3.4, Python 3.5 ___ Python tracker ___

[issue27256] email header indentation destroyed

Hans-Peter Jansen added the comment: Sorry guys for not providing this earlier. It turned out, that the sub optimal behaviour is related to a unfortunate policy choice: email.policy.SMTP. -- Added file: http://bugs.python.org/file43417/email_flatten.py

[issue27257] get_addresses results in traceback with an addrspec with an empty local part.

Hans-Peter Jansen added the comment: Sorry guys for not providing this earlier. It turned out, that the sub optimal behaviour is related to a unfortunate policy choice: email.policy.SMTP. -- Added file: http://bugs.python.org/file43416/email_flatten.py

[issue27258] Exception in BytesGenerator.flatten

Hans-Peter Jansen added the comment: Sorry guys for not providing this earlier. It turned out, that the sub optimal behaviour is related to a unfortunate policy choice: email.policy.SMTP. -- Added file: http://bugs.python.org/file43415/email_flatten.py

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

Changes by Berker Peksag : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue26985] Information about CodeType in inspect documentation is outdated

Xiang Zhang added the comment: Hmm, when I am going to delete the list in the docstring, I find other functions get lists too in inspect.py. So maybe we should open another issue to clean them after first merging this thread? -- ___ Python tracker

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

Robert Haschke added the comment: Uploaded a "hg diff" against the recent 2.7 branch of the source repo. -- Added file: http://bugs.python.org/file43414/minidom.insertBefore.patch ___ Python tracker

[issue6057] sqlite3 error classes should be documented

Jaysinh shukla added the comment: Adding forgotten reference of ProgrammingError to last patch. Please review issue6057_python3_6_v2.diff Thanks! -- Added file: http://bugs.python.org/file43413/issue6057_python3_6_v2.diff ___ Python tracker

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

Berker Peksag added the comment: Please attach the patch in unified diff format. See https://docs.python.org/devguide/patch.html for details. -- nosy: +berker.peksag ___ Python tracker

[issue27282] Raise BlockingIOError in os.urandom if kernel is not ready

Changes by Donald Stufft : -- nosy: -dstufft ___ Python tracker ___ ___ Python-bugs-list

[issue27266] Always use getrandom() in os.random() on Linux and add block=False parameter to os.urandom()

Changes by Donald Stufft : -- nosy: -dstufft ___ Python tracker ___ ___ Python-bugs-list

[issue27250] Add os.urandom_block()

Changes by Donald Stufft : -- nosy: -dstufft ___ Python tracker ___ ___ Python-bugs-list

[issue27288] secrets should use getrandom() on Linux

Changes by Donald Stufft : -- nosy: -dstufft ___ Python tracker ___ ___ Python-bugs-list

[issue27297] Add support for /dev/random to "secrets"

Changes by Donald Stufft : -- nosy: -dstufft ___ Python tracker ___ ___ Python-bugs-list

[issue22636] avoid using a shell in ctypes.util: replace os.popen with subprocess

Serhiy Storchaka added the comment: ctypes_util_popen-6.py2.patch LGTM. -- ___ Python tracker ___ ___

[issue6057] sqlite3 error classes should be documented

Jaysinh shukla added the comment: Submitting the patch for Python 3.6. -- keywords: +patch Added file: http://bugs.python.org/file43412/issue6057_python3_6.diff ___ Python tracker

[issue27292] Warn users that os.urandom() can return insecure values

Changes by Donald Stufft : -- nosy: -dstufft ___ Python tracker ___ ___ Python-bugs-list

[issue27292] Warn users that os.urandom() can return insecure values

STINNER Victor added the comment: > As far as I can see (looking at Python/random.c and configure.ac), the > Solaris version should also use GRND_NONBLOCK: Oh, you're right: I didn't notice that GRND_NONBLOCK was also used on Solaris. The change is not deliberate, but it is good to do that

[issue22228] Adapt bash readline operate-and-get-next function

Lele Gaifax added the comment: I will try to address your concerns. -- ___ Python tracker ___ ___

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

GuiHome added the comment: kindly ping -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27292] Warn users that os.urandom() can return insecure values

Martin Panter added the comment: Rebased so Rietveld can work with it, earlier version was my fault. As far as I can see (looking at Python/random.c and configure.ac), the Solaris version should also use GRND_NONBLOCK: #ifdef MS_WINDOWS #elif defined(HAVE_GETENTROPY) && !defined(sun) #else

[issue27292] Warn users that os.urandom() can return insecure values

STINNER Victor added the comment: Strange, I don't see the [Review] button. .. versionchanged:: 3.5.2 - On Linux, if ``getrandom()`` blocks (the urandom entropy pool is not + If ``getrandom()`` blocks (the urandom entropy pool is not initialized yet), fall back on reading

[issue22228] Adapt bash readline operate-and-get-next function

Martin Panter added the comment: I will try to have a closer look at this some time, but my immediate worry is it looks like you are directly copying Bash code (GPL) into Python (less restrictive license). Perhaps a more general solution would be to expose rl_add_defun() to native Python

[issue27330] Possible leaks in ctypes

Martin Panter added the comment: Mostly looks good. I left a two comments. -- nosy: +martin.panter ___ Python tracker ___

[issue22228] Adapt bash readline operate-and-get-next function

Changes by Berker Peksag : -- nosy: +martin.panter ___ Python tracker ___ ___

[issue22228] Adapt bash readline operate-and-get-next function

Berker Peksag added the comment: The review comments are at http://bugs.python.org/review/8/#ps12743 (you can also click to the 'review' link above) -- ___ Python tracker

[issue27258] Exception in BytesGenerator.flatten

Berker Peksag added the comment: Thanks for helping to triage this, Pedro. I think there is a typo in your example: ``email.message_from_binary_file(fp)`` needs to be passed to ``bs.flatten()``. With the following script I'm also unable to reproduce the issue in Python 3.4+: import email

[issue22228] Adapt bash readline operate-and-get-next function

Lele Gaifax added the comment: The patch does not apply cleanly anymore, with current 3.6a3. If there is any chance it could be taken into consideration, I will try to rebase it on top of current version. @Berker: as I don't use Rietveld, is it possible for me to reach the comment you

[issue27292] Warn users that os.urandom() can return insecure values

Martin Panter added the comment: Here is a possible patch for 3.5+ based on my modest understanding of the concerns about insecure results and blocking. I hope that my wording is clear, couldn’t be confused with Linux’s /dev/random blocking and running out of fresh entropy, etc. I also tried

[issue27140] Opcode for creating dict with constant keys

STINNER Victor added the comment: Nice enhancement. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue10839] email module should not allow some header field repetitions

Berker Peksag added the comment: > Right, that's what I meant by "plumb". :) Sorry, apparently I can't read in the mornings :) I have just opened issue 27331 to implement this idea. -- ___ Python tracker

[issue27331] Add a policy argument to email.mime.MIMEBase

New submission from Berker Peksag: Quoting Barry's message msg268430 from issue 10839: On Jun 13, 2016, at 06:38 AM, Berker Peksag wrote: >I don't know if it's a good idea or API but can we add a 'policy' keyword >argument to email.mime.base.MIMEBase? Right now, this is the only

[issue27213] Rework CALL_FUNCTION* opcodes

Serhiy Storchaka added the comment: Do you take this for your Demur? -- ___ Python tracker ___ ___

[issue27140] Opcode for creating dict with constant keys

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue27324] Error when building Python extension

Mark added the comment: The problem is that I don't have the choice, the compiler we use for the project is VS13. Anyway, my colleagues are aware of this limitation but they could build their extensions all the same. I set the variables as you recommended, and the obj files have been created.

[issue27130] zlib: OverflowError while trying to compress 2^32 bytes or more

Xiang Zhang added the comment: Sorry, I suddenly find that I've misunderstood one of your comments. I changed according then. Please use the new version. -- Added file: http://bugs.python.org/file43408/64bit_support_for_zlib_v3.patch ___ Python

[issue27292] Warn users that os.urandom() can return insecure values

Martin Panter added the comment: As far as this bug goes, 3.5 is not very different from 2.7 -- nosy: +martin.panter versions: +Python 2.7 ___ Python tracker

[issue27130] zlib: OverflowError while trying to compress 2^32 bytes or more

Xiang Zhang added the comment: I'm willing to and thanks for your work too :) I have replied to your comments and adjusted my patch accordingly. But there are still several I am confused or want to negotiate more. I now upload the adjusted patch. -- Added file:

[issue6057] sqlite3 error classes should be documented

Changes by Jaysinh shukla : -- nosy: +jaysinh.shukla ___ Python tracker ___ ___

[issue27165] Skip callables when displaying exception fields in cgitb

Senthil Kumaran added the comment: Hi Adam, Thanks for the patch. I reviewed it. It's a good change. As you mentioned in the comments, making both HTML and Text formatter behave consistently and skip, underscores, callables, _callables will be a good idea. Please include change. Also, if

[issue27330] Possible leaks in ctypes

New submission from Serhiy Storchaka: Proposed patch fixes memory leaks in ctypes in case of errors. -- components: Extension Modules, ctypes files: ctypes_leaks.patch keywords: patch messages: 268646 nosy: amaury.forgeotdarc, belopolsky, meador.inge, serhiy.storchaka priority: normal

[issue27258] Exception in BytesGenerator.flatten

Pedro Lacerda added the comment: I was unable to reproduce this bug using the following snippet import email, sys from email.generator import BytesGenerator from email.mime.text import MIMEText fp = open('flatten-exception.mail', 'rb') email.message_from_binary_file(fp)

[issue27268] Incorrect error message on float('')

Pedro Lacerda added the comment: Following the bug pointed by Adam and Eryk. -- keywords: +patch nosy: +Pedro Lacerda Added file: http://bugs.python.org/file43405/float.patch ___ Python tracker

[issue26836] Add memfd_create to os module

Pedro Lacerda added the comment: Maybe useful at mmapmodule.c replacing /* SVR4 method to map anonymous memory is to open /dev/zero */ fd = devzero = _Py_open("/dev/zero", O_RDWR); tagname is unused at UNIX version of new_mmap_object() so if provided something like could be