[issue27570] Avoid memcpy(. . ., NULL, 0) etc calls

2016-08-02 Thread Martin Panter
Martin Panter added the comment: Patch 3 fixes some more cases I found in the array module: >>> a + a Modules/arraymodule.c:809:5: runtime error: null pointer passed as argument 1, which is declared to never be null Modules/arraymodule.c:809:5: runtime error: null pointer passed as argument 2,

[issue20215] socketserver.TCPServer can not listen IPv6 address

2016-08-02 Thread Paul Marks
Paul Marks added the comment: > if the user specifically wants to bind to a numeric IPv4 address, is there > any advantage of choosing the dual-stack [...]? If you're in a position to write AF_INET6-only code, then dualstack sockets can make things a bit cleaner (one family for all IP

[issue1005895] curses for win32

2016-08-02 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue20215] socketserver.TCPServer can not listen IPv6 address

2016-08-02 Thread Martin Panter
Martin Panter added the comment: Paul, if the user specifically wants to bind to a numeric IPv4 address, is there any advantage of choosing the dual-stack IPV6_V6ONLY=0 mode with a mapped :::a.b.c.d address? -- ___ Python tracker

[issue20215] socketserver.TCPServer can not listen IPv6 address

2016-08-02 Thread Paul Marks
Paul Marks added the comment: First off, the server_address=('localhost', port) case: this feature is fundamentally broken without support for multiple sockets, because the server can listen on at most one address, and any single choice will often be inconsistent with clients' expectations.

[issue27621] Finish IDLE Query dialog appearance and behavior.

2016-08-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: The file has the correct format for review, applies cleanly, and tests pass. The relief is gone (easy). The buttons are no longer symmetrical; this looks 'wrong' to me. (My reaction might be different if the widget was much wider, so the buttons were

[issue20215] socketserver.TCPServer can not listen IPv6 address

2016-08-02 Thread Martin Panter
Martin Panter added the comment: I also have reservations about using getaddrinfo() like this. Some potential problems: 1. IPv4-only compatibility: On my Linux computer, getaddrinfo("localhost", 0) returns AF_INET6 before AF_INET. Some programs, like Firefox and BSD netcat, will try both v4

[issue26988] Add AutoNumberedEnum to stdlib

2016-08-02 Thread Ethan Furman
Ethan Furman added the comment: Okay, I think I'm done making changes unless any more mistakes are found. Thanks everyone for the pushing, prodding, and feedback! -- Added file: http://bugs.python.org/file43986/issue26988.stoneleaf.05.patch ___

[issue20215] socketserver.TCPServer can not listen IPv6 address

2016-08-02 Thread Paul Marks
Changes by Paul Marks : -- nosy: +Paul Marks ___ Python tracker ___ ___ Python-bugs-list

[issue27670] Use https instead of http in the PYTHON_VERSION constant

2016-08-02 Thread Stéphane Wirtel
Changes by Stéphane Wirtel : -- keywords: +patch Added file: http://bugs.python.org/file43985/issue27670.diff ___ Python tracker ___

[issue27670] Use https instead of http in the PYTHON_VERSION constant

2016-08-02 Thread Stéphane Wirtel
New submission from Stéphane Wirtel: The current url for bugs.python.org uses http and not https. I propose a patch with https, -- components: Interpreter Core messages: 271867 nosy: matrixise priority: normal severity: normal status: open title: Use https instead of http in the

[issue27669] Bug in re.fullmatch() specific to Windows XP

2016-08-02 Thread Matthew Barnett
Matthew Barnett added the comment: When I tried it, I got matches for both 'match' and 'fullmatch' (output attached as 'output.txt') as expected. -- Added file: http://bugs.python.org/file43984/output.txt ___ Python tracker

[issue20215] socketserver.TCPServer can not listen IPv6 address

2016-08-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: TL;DR - We really need reliable tests for the exact behavior we want before coming up with patches. attached is a patch (-gps01) that would do the same thing as Lib/smtpd.py does... But I'm not convinced it is a good idea. Would forcing a

[issue23710] C API doc for PyObject_HEAD is outdated

2016-08-02 Thread Stéphane Wirtel
Changes by Stéphane Wirtel : -- nosy: +matrixise ___ Python tracker ___ ___

[issue20215] socketserver can not listen IPv6 address

2016-08-02 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___

[issue27669] Bug in re.fullmatch() specific to Windows XP

2016-08-02 Thread Geoffrey Odhner
Geoffrey Odhner added the comment: I'm quite sure it's the same regular expression with the same code. It was a puzzling bug, and I thought it might take more to track it down than it did. I tried changing the file encoding on both the code and the data, and found that the problem didn't

[issue26267] UUID docs should say how to get "standard form"

2016-08-02 Thread Ammar Askar
Ammar Askar added the comment: Whoops, didn't export the patch properly there so it didn't get picked up by the review tool, this should fix it. -- Added file: http://bugs.python.org/file43980/uuiddocs.diff3 ___ Python tracker

[issue26267] UUID docs should say how to get "standard form"

2016-08-02 Thread Ammar Askar
Ammar Askar added the comment: Fixed the str() representation as per Evelyn's comment. -- Added file: http://bugs.python.org/file43979/uuiddocs.diff2 ___ Python tracker

[issue27669] Bug in re.fullmatch() specific to Windows XP

2016-08-02 Thread Matthew Barnett
Matthew Barnett added the comment: FTR, I can't reproduce it. This is what I get on Windows XP (32-bit): Python 3.4.3 (v3.4.3:9b73f1c3e601, Feb 24 2015, 22:43:06) [MSC v.1600 32 bit (In tel)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> import re >>>

[issue23710] C API doc for PyObject_HEAD is outdated

2016-08-02 Thread Evelyn Mitchell
Evelyn Mitchell added the comment: Changed to commit review. -- stage: needs patch -> commit review ___ Python tracker ___

[issue27661] Add tzinfo= argument to datetime.combine

2016-08-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset adce94a718e3 by Alexander Belopolsky in branch 'default': Closes #27661: Added tzinfo keyword argument to datetime.combine. https://hg.python.org/cpython/rev/adce94a718e3 -- nosy: +python-dev resolution: -> fixed stage: commit review ->

[issue23710] C API doc for PyObject_HEAD is outdated

2016-08-02 Thread Evelyn Mitchell
Evelyn Mitchell added the comment: There is a patch, and it looks good to me. This should be moved into 'commit review' state. -- nosy: +Evelyn Mitchell ___ Python tracker

[issue20767] Some python extensions can't be compiled with clang 3.4

2016-08-02 Thread Evelyn Mitchell
Evelyn Mitchell added the comment: Stefan, I've commented on the llvm bugzilla. Thanks for suggesting that. -- ___ Python tracker ___

[issue20767] Some python extensions can't be compiled with clang 3.4

2016-08-02 Thread koobs
koobs added the comment: @Stefan I've notified our FreeBSD Clang/LLVM people of the upstream bug status, though there are indications that the "-Wl,-rpath" method is considered the recommended/canonical/future way to do things properly. -- ___

[issue26988] Add AutoNumberedEnum to stdlib

2016-08-02 Thread John Hagen
John Hagen added the comment: @Ethan I reviewed your latest patch. I think it's a good step forward in terms of simplicity. Most of my comments were not major. Even before this patch, I was mulling around how enum.Unique, enum.UniqueEnum, and enum.unique seemed to violate the "There should

[issue27669] Bug in re.fullmatch() specific to Windows XP

2016-08-02 Thread Zachary Ware
Zachary Ware added the comment: Since this is not a security issue, 3.4 is in security fix only mode, and Windows XP is no longer supported in Python 3.5+, this will not be fixed. Thus, I'm closing the issue. However, this is bizarre :). There is no Windows-version-specific code in the re

[issue27669] Bug in re.fullmatch() specific to Windows XP

2016-08-02 Thread Geoffrey Odhner
New submission from Geoffrey Odhner: I have found a bug in python’s re.fullmatch() function when it’s running on Windows XP. On Mac OS X or Windows 7 the bug doesn’t occur. When I use fullmatch() with a regular expression that ends with ‘$’ it fails to match the string (on XP, but it

[issue20767] Some python extensions can't be compiled with clang 3.4

2016-08-02 Thread Stefan Krah
Stefan Krah added the comment: We can of course commit this, but could you also lobby here? https://llvm.org/bugs/show_bug.cgi?id=18164 I'm seeing this quite often that we fix something here and no one insists on the upstream bug trackers. --

[issue20767] Some python extensions can't be compiled with clang 3.4

2016-08-02 Thread Evelyn Mitchell
Evelyn Mitchell added the comment: I think this patch should pass to the next stage. Thank you, koobs. -- ___ Python tracker ___

[issue20767] Some python extensions can't be compiled with clang 3.4

2016-08-02 Thread koobs
koobs added the comment: Nothing is required (as far as I'm aware) other than commit/merge on a two line change scoped only to FreeBSD. The issue was reported for and on FreeBSD and the patch has been carried locally in all FreeBSD Python ports/packages (2.7, 3.3, 3.4, 3.5) for over two

[issue27241] Catch exceptions raised in pstats add (repl)

2016-08-02 Thread Stefan Krah
Changes by Stefan Krah : -- assignee: -> skrah resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.5 ___ Python tracker

[issue27241] Catch exceptions raised in pstats add (repl)

2016-08-02 Thread Stefan Krah
Stefan Krah added the comment: Yes, I agree this is nicer. Thanks for the patch. -- nosy: +skrah ___ Python tracker ___

[issue27241] Catch exceptions raised in pstats add (repl)

2016-08-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset d9e25fe35f46 by Stefan Krah in branch '3.5': Issue #27241: Catch exception when running pstats as main. https://hg.python.org/cpython/rev/d9e25fe35f46 -- nosy: +python-dev ___ Python tracker

[issue22557] Local import is too slow

2016-08-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 64f195790a3a by Serhiy Storchaka in branch 'default': Issue #22557: Now importing already imported modules is up to 2.5 times faster. https://hg.python.org/cpython/rev/64f195790a3a -- nosy: +python-dev

[issue22557] Local import is too slow

2016-08-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your review Brett. -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue20767] Some python extensions can't be compiled with clang 3.4

2016-08-02 Thread Evelyn Mitchell
Evelyn Mitchell added the comment: The patch looks reasonable, but needs to be tested on FreeBSD. -- nosy: +Evelyn Mitchell ___ Python tracker ___

[issue26109] _Py_DumpTraceback should be PyAPI_FUNC

2016-08-02 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. This has already been fixed in 4f5e4155c259 ( Python 3.5+) -- nosy: +berker.peksag resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker

[issue24082] Obsolete note in argument parsing (c-api/arg.rst)

2016-08-02 Thread Berker Peksag
Berker Peksag added the comment: The patch looks good to me. Note that the patch in issue 24278 also removes the same note. -- nosy: +berker.peksag stage: -> patch review type: -> behavior versions: +Python 3.5, Python 3.6 -Python 3.4 ___ Python

[issue27638] int.to_bytes() and int.from_bytes() should support 'net' and 'host' byte orders

2016-08-02 Thread Raymond Hettinger
Raymond Hettinger added the comment: Марк, thank you for the suggestion, but we've decided to decline the request. -- nosy: +rhettinger resolution: -> rejected status: open -> closed ___ Python tracker

[issue27638] int.to_bytes() and int.from_bytes() should support 'net' and 'host' byte orders

2016-08-02 Thread Guido van Rossum
Guido van Rossum added the comment: I'm also -1. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27241] Catch exceptions raised in pstats add (repl)

2016-08-02 Thread Joe Jevnik
Joe Jevnik added the comment: bump -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24214] UTF-8 incremental decoder doesn't support surrogatepass correctly

2016-08-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The patch slows down decoding up to 20%. $ ./python -m timeit -s 'b = b"\xc4\x80"*1' -- 'b.decode()' Unpatched: 1 loops, best of 3: 50.8 usec per loop Patched:1 loops, best of 3: 63.3 usec per loop And I'm not sure that fixing only for the

[issue27638] int.to_bytes() and int.from_bytes() should support 'net' and 'host' byte orders

2016-08-02 Thread Марк Коренберг
Марк Коренберг added the comment: Well, I provide the patch, as you can see it is very simple. -- ___ Python tracker ___

[issue27638] int.to_bytes() and int.from_bytes() should support 'net' and 'host' byte orders

2016-08-02 Thread Марк Коренберг
Changes by Марк Коренберг : -- nosy: +gvanrossum ___ Python tracker ___ ___

[issue27638] int.to_bytes() and int.from_bytes() should support 'net' and 'host' byte orders

2016-08-02 Thread Марк Коренберг
Марк Коренберг added the comment: @skrah, what about integers with length not equal to 2 or 4 bytes, and also signed ? -- ___ Python tracker ___

[issue27638] int.to_bytes() and int.from_bytes() should support 'net' and 'host' byte orders

2016-08-02 Thread Марк Коренберг
Марк Коренберг added the comment: 1. I forgot to say: since I add new items to `if.. elif...elif.` chain after testing for 'big' and 'little', this change will not slowdown current external code. 2. Well, slowdown of to_bytes() between 'big' and 'net' on my PC give about 3 percents. 3.

[issue27638] int.to_bytes() and int.from_bytes() should support 'net' and 'host' byte orders

2016-08-02 Thread Stefan Krah
Stefan Krah added the comment: Марк, sorry for all this negativity. ;) But I'm also -1. What is wrong with socket.ntohs() etc.? -- nosy: +skrah ___ Python tracker

[issue27574] Faster parsing keyword arguments

2016-08-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27638] int.to_bytes() and int.from_bytes() should support 'net' and 'host' byte orders

2016-08-02 Thread Марк Коренберг
Changes by Марк Коренберг : -- keywords: +patch Added file: http://bugs.python.org/file43978/host_net.patch ___ Python tracker ___

[issue27242] Make the docs for NotImplemented & NotImplementedError unambiguous

2016-08-02 Thread Ethan Furman
Ethan Furman added the comment: Fixed the typos (thanks!), removed the self-reference, and went with "similar names and purposes". -- ___ Python tracker

[issue27242] Make the docs for NotImplemented & NotImplementedError unambiguous

2016-08-02 Thread Emanuel Barry
Emanuel Barry added the comment: Thanks Ethan for the improved patch! Pointed out a typo and some nits, but other than that it's mostly good. I'm not that good at brevity, and I think your patch is much better on that regard :) -- ___ Python

[issue27242] Make the docs for NotImplemented & NotImplementedError unambiguous

2016-08-02 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___

[issue27242] Make the docs for NotImplemented & NotImplementedError unambiguous

2016-08-02 Thread Ethan Furman
Ethan Furman added the comment: Did a little rewording and trimming (and formatting). Tried to keep the ideas while not being so verbose. -- Added file: http://bugs.python.org/file43977/issue27242.stoneleaf.01.patch ___ Python tracker

[issue27594] Assertion failure when running "test_ast" tests with coverage.

2016-08-02 Thread Quentin Pradet
Changes by Quentin Pradet : -- nosy: +Quentin.Pradet ___ Python tracker ___ ___

[issue24637] locals dictionary in PyRun_String

2016-08-02 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: the patch makes sense for me. -- nosy: +matrixise ___ Python tracker ___

[issue24637] locals dictionary in PyRun_String

2016-08-02 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> patch review versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4 ___ Python tracker

[issue27660] Replace size_t with Py_ssize_t as the type of local variable in list_resize

2016-08-02 Thread Xiang Zhang
Xiang Zhang added the comment: So how about list_resize_v2.patch? -- Added file: http://bugs.python.org/file43976/list_resize_v2.patch ___ Python tracker

[issue6926] socket module missing IPPROTO_IPV6, IPPROTO_IPV4

2016-08-02 Thread Berker Peksag
Berker Peksag added the comment: Py_WINVER has been updated to use 0x0600 (_WIN32_WINNT_VISTA) in 57e2549cc9a6 (issue 23451) Since the consensus was to keep 2.7 as is I'm closing this as 'out of date'. -- nosy: +berker.peksag resolution: -> out of date stage: needs patch -> resolved

[issue27660] Replace size_t with Py_ssize_t as the type of local variable in list_resize

2016-08-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: True. Then we should use the condition "new_allocated > PY_SSIZE_T_MAX". This can be even more efficient. -- ___ Python tracker

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

2016-08-02 Thread Dima Tisnek
Dima Tisnek added the comment: Can someone review Aviv's patch? -- ___ Python tracker ___ ___ Python-bugs-list

[issue24844] Python 3.5rc1 compilation error with Apple clang 4.2 included with Xcode 4

2016-08-02 Thread Mojca Miklavec
Changes by Mojca Miklavec : Removed file: http://bugs.python.org/file43974/python3.5.2-should-not-use-libatomic-with-old-clang.diff ___ Python tracker

[issue24844] Python 3.5rc1 compilation error with Apple clang 4.2 included with Xcode 4

2016-08-02 Thread Mojca Miklavec
Changes by Mojca Miklavec : Added file: http://bugs.python.org/file43975/python3.5.2-should-not-use-libatomic-with-old-clang.diff ___ Python tracker

[issue24844] Python 3.5rc1 compilation error with Apple clang 4.2 included with Xcode 4

2016-08-02 Thread Mojca Miklavec
Changes by Mojca Miklavec : -- keywords: +patch Added file: http://bugs.python.org/file43974/python3.5.2-should-not-use-libatomic-with-old-clang.diff ___ Python tracker

[issue27242] Make the docs for NotImplemented & NotImplementedError unambiguous

2016-08-02 Thread Emanuel Barry
Emanuel Barry added the comment: Obligatory monthly ping. -- ___ Python tracker ___ ___ Python-bugs-list

[issue27657] urlparse fails if the path is numeric

2016-08-02 Thread R. David Murray
R. David Murray added the comment: Ah, good point, I misread the scope of the problem. -- ___ Python tracker ___

[issue27558] SystemError with bare `raise` in threading or multiprocessing

2016-08-02 Thread Berker Peksag
Berker Peksag added the comment: The test code in issue27558_v2.patch looks OK to me. -- ___ Python tracker ___

[issue27657] urlparse fails if the path is numeric

2016-08-02 Thread Martin Panter
Martin Panter added the comment: Depends on how you define “looks like an IP address”. Does the www.cwi.nl:80 case look like an IP address? What about “path:80” or “localhost:80”? If there is any code relying on the bug, it may just as easily involve host name as a numeric IP address.

[issue27435] ctypes library loading and AIX - also for 2.7.X (and later)

2016-08-02 Thread Martin Panter
Martin Panter added the comment: If you are still figuring out Mercurial, maybe see and if you haven’t already. -- ___

[issue27435] ctypes library loading and AIX - also for 2.7.X (and later)

2016-08-02 Thread Martin Panter
Martin Panter added the comment: For 2.7, adding the automatic RTLD_MEMBER mode does not seem like a bug fix to me. Currently, I understand this code could load two separate libraries: file = CDLL("libcrypto.a(libcrypto.so.1.0.0)") member = CDLL("libcrypto.a(libcrypto.so.1.0.0)", DEFAULT_MODE

[issue27666] "stack smashing detected" in PyCursesWindow_Box

2016-08-02 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: -> needs patch ___ Python tracker ___

[issue27668] list illogical affectation

2016-08-02 Thread Emanuel Barry
Emanuel Barry added the comment: To add to what SilentGhost just said; the '*' operator for lists doesn't create new lists, but simply creates new references to the same list (i.e. it doesn't re-evaluate the expression). To create separate lists, you can do a list comprehension such as:

[issue27668] list illogical affectation

2016-08-02 Thread SilentGhost
SilentGhost added the comment: Because elements of the tab list are the same list. And since list is a mutable type, modifying list object will be visible to via all the reference / names that point to that object. There are various ways to work around this behaviour, typically a list

[issue27668] list illogical affectation

2016-08-02 Thread antoine Zellmeyer
New submission from antoine Zellmeyer: >>> tab = [['x']*3]*3 >>> tab [['x', 'x', 'x'], ['x', 'x', 'x'], ['x', 'x', 'x']] >>> tab[1][0] = 5 >>> tab [[5, 'x', 'x'], [5, 'x', 'x'], [5, 'x', 'x']] >>> why not only the element tab[1][0] is changed ? -- assignee: terry.reedy components:

[issue26439] ctypes.util.find_library fails when ldconfig/glibc not available (e.g., AIX)

2016-08-02 Thread Martin Panter
Martin Panter added the comment: For the record, I presume you are referring to Issue 27435. -- ___ Python tracker ___

[issue12319] [http.client] HTTPConnection.request not support "chunked" Transfer-Encoding to send data

2016-08-02 Thread Rolf Krahl
Rolf Krahl added the comment: Thanks for your review! Here comes a new version of the patch. I believe I addressed all review comments. Since I didn't get any feedback on my questions raised above, I resolved them as follows: 1. I dropped the EncodingError exception introduced by an

[issue1621] Do not assume signed integer overflow behavior

2016-08-02 Thread Christian Heimes
Changes by Christian Heimes : -- nosy: -christian.heimes ___ Python tracker ___ ___

[issue27666] "stack smashing detected" in PyCursesWindow_Box

2016-08-02 Thread SilentGhost
Changes by SilentGhost : -- components: +Extension Modules -Library (Lib) nosy: +twouters ___ Python tracker ___

[issue27667] subprocess32 unable to be installed via pip and python install

2016-08-02 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. The stdlib version of subprocess module has a little bit codebase now (there is no subprocess_cloexec_pipe() routine anymore, for example) so we can't do anything here. Could you please report this to

[issue27667] subprocess32 unable to be installed via pip and python install

2016-08-02 Thread Cambridge
Cambridge added the comment: If 3.2.7 don't support RHEL5? -- nosy: +gregory.p.smith ___ Python tracker ___

[issue27667] subprocess32 unable to be installed via pip and python install

2016-08-02 Thread Cambridge
New submission from Cambridge: OS:RHEL 5.11 PYTHON:2.7.11/12 When i use pip or python install to install this extension: pip install subprocess32-3.2.7.tar.gz The error messages: Processing ./subprocess32-3.2.7.tar.gz Installing collected packages: subprocess32 Running setup.py install for

[issue26988] Add AutoNumberedEnum to stdlib

2016-08-02 Thread Ethan Furman
Ethan Furman added the comment: The 80-column thing isn't fixed yet, but I redid the patch: - removed AutoNameEnum since there was some question of casing, etc - redid the methodology of auto-generating values: instead of adding it all to the prepared namespace or the metaclass, I now

[issue27655] [Patch] Don't require presence of POLLPRI

2016-08-02 Thread Ed Schouten
Ed Schouten added the comment: Believe it our not, dealing with the absence of those system calls is more contained than you'd think. What is pretty nice about Python is that (almost) all of the file system operations are performed through posixmodule.c. Most of the changes in that area are

[issue27655] [Patch] Don't require presence of POLLPRI

2016-08-02 Thread Benjamin Peterson
Benjamin Peterson added the comment: Are you planning on sending us patches to make Python compile without open(2)? Putting #ifdef around various constants is one thing but it seems like this could become quite invasive. -- ___ Python tracker

[issue27660] Replace size_t with Py_ssize_t as the type of local variable in list_resize

2016-08-02 Thread Xiang Zhang
Xiang Zhang added the comment: But if you use size_t, you are checking overflow against PY_SIZE_MAX, not PY_SSIZE_T_MAX. -- ___ Python tracker ___

[issue27655] [Patch] Don't require presence of POLLPRI

2016-08-02 Thread Ed Schouten
Ed Schouten added the comment: That's a very good question. One of the goals of CloudABI's C library is to leave out definitions for things that are known not to work in the environment. For example, our doesn't contain open(), as with our security model (Capsicum), there is nothing

[issue27660] Replace size_t with Py_ssize_t as the type of local variable in list_resize

2016-08-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Unsigned type can be used for more efficient checking on integer overflow. new_allocated = (newsize >> 3) + (newsize < 9 ? 3 : 6); new_allocated += (size_t)newsize; if (new_allocated < (size_t)newsize) { PyErr_NoMemory(); return

[issue27660] Replace size_t with Py_ssize_t as the type of local variable in list_resize

2016-08-02 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- nosy: +mark.dickinson ___ Python tracker ___