[issue27950] Superfluous messages when running make

2016-09-03 Thread Martin Panter
Changes by Martin Panter : -- title: Superflous messages when running make -> Superfluous messages when running make ___ Python tracker

[issue27950] Superflous messages when running make

2016-09-03 Thread Martin Panter
Martin Panter added the comment: I think putting @ in front would be safe. Nobody has complained that “# . . .” didn’t work. I expect changing them to “@# . . .” would be no worse. I think the Posix page was only talking about comment lines that _don’t_ begin with a tab. At least in Gnu and

[issue27950] Superflous messages when running make

2016-09-03 Thread Xiang Zhang
Xiang Zhang added the comment: Ooh, sorry. This "Another way that might work is adding @ to silence the comment before the comments" should also fall in "However it seems that other Make implementations might take your comments in the middle of a list of commands as a sign to end the list of

[issue27950] Superflous messages when running make

2016-09-03 Thread Xiang Zhang
Xiang Zhang added the comment: > However it seems that other Make implementations might take your comments in > the middle of a list of commands as a sign to end the list of commands. If this is true then it seems we have to move the comments before the rules. Another way that might work is

[issue27859] argparse - subparsers does not retain namespace

2016-09-03 Thread paul j3
paul j3 added the comment: This call used to be namespace, arg_strings = parser.parse_known_args(arg_strings, namespace) But in 2014 (2.7.9) http://bugs.python.org/issue9351 was implemented As noted in the title and comment in the code, the idea was to give more power to the defaults set

[issue27951] the reply's additional "Re:" is ok

2016-09-03 Thread Seif Elsallamy
Changes by Seif Elsallamy : -- nosy: saifmega priority: normal severity: normal status: open title: the reply's additional "Re:" is ok ___ Python tracker

[issue9351] argparse set_defaults on subcommands should override top level set_defaults

2016-09-03 Thread paul j3
paul j3 added the comment: Another example where the old way would have worked better http://bugs.python.org/issue27859 -- ___ Python tracker ___

[issue16764] Make zlib accept keyword-arguments

2016-09-03 Thread Martin Panter
Changes by Martin Panter : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue26439] ctypes.util.find_library fails when ldconfig/glibc not available (e.g., AIX)

2016-09-03 Thread Martin Panter
Martin Panter added the comment: Regarding the regular expressions, I (or someone else unfamiliar with AIX) may be able to adjust them if you can explain what you are trying to achieve. Take the first one I commented on

[issue27927] argparse: default propagation of formatter_class from ArgumentParser() to SubParsers

2016-09-03 Thread paul j3
paul j3 added the comment: http://bugs.python.org/issue21633 also deals with the formatter of subparsers. I note there that few of parameters of the main parser propagate to the subparsers. The current design gives the programmer maximum control, at the expense of a bit of typing. If I

[issue27918] Running test suites without gui but still having windows flash

2016-09-03 Thread Martin Panter
Martin Panter added the comment: Xiang’s second patch looks okay to me. The flashes occasionally annoy me with X windows if I am doing something else and have the Python tests running in the background. I understand deferring the _is_gui_available() call will fix the main problem, and the

[issue27364] Deprecate invalid unicode escape sequences

2016-09-03 Thread Martin Panter
Martin Panter added the comment: Left some comments for invalid_stdlib_escapes_2.patch -- ___ Python tracker ___

[issue27179] subprocess uses wrong encoding on Windows

2016-09-03 Thread Steve Dower
Steve Dower added the comment: I'll take a look during the week. I like parts of the patch but not all of it, but while we're inevitably discussing my PEPs it's sure to come up. -- assignee: -> steve.dower ___ Python tracker

[issue27950] Superflous messages when running make

2016-09-03 Thread Martin Panter
Martin Panter added the comment: I never noticed this because unless I am debugging a build problem I use “make -s”, which hides all the commands lines, and lets you see compiler warnings etc much easier. Very briefly testing with Gnu Make and BSD Make, your patch doesn’t seem to do anything

[issue27921] f-strings: do not allow backslashes

2016-09-03 Thread Martin Panter
Martin Panter added the comment: I haven’t looked, but my guess at why test_unparse could fail would be trying to generate code for an f-string with control characters in. Maybe it is taking stuff like f'''{x} {y} ''' and generating f'{x}\n{y}\n' -- nosy: +martin.panter

[issue27179] subprocess uses wrong encoding on Windows

2016-09-03 Thread Dāvis
Dāvis added the comment: That is a great PIP, but it will take a lot of time to be implemented and it doesn't really solve this issue. This is different issue than filename/path encoding. Here we need to decode binary output from other applications and that for a lot of applications will be

[issue27078] Make f'' strings faster than .format: BUILD_STRING opcode?

2016-09-03 Thread Eric V. Smith
Eric V. Smith added the comment: Of course. Never mind. LGTM. -- ___ Python tracker ___ ___ Python-bugs-list

[issue27078] Make f'' strings faster than .format: BUILD_STRING opcode?

2016-09-03 Thread Antti Haapala
Antti Haapala added the comment: I tried to post a comment on rietveld, but 500 infernal error... PyUnicode_New(0, 0) will return unicode_empty. If unicode_empty is NULL, then it will also initialize it. It would be cleanest if unicode_empty was statically created. NULL cannot be used as the

[issue27179] subprocess uses wrong encoding on Windows

2016-09-03 Thread STINNER Victor
STINNER Victor added the comment: You should take a look at the recent PEP 529 "Change Windows filesystem encoding to UTF-8": https://www.python.org/dev/peps/pep-0529/ -- ___ Python tracker

[issue26040] Improve coverage and rigour of test.test_math

2016-09-03 Thread Mark Dickinson
Mark Dickinson added the comment: Buildbots seem happy (or at least, no more unhappy than before). Closing. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue27179] subprocess uses wrong encoding on Windows

2016-09-03 Thread Dāvis
Dāvis added the comment: ping? Could someone review my patch? -- ___ Python tracker ___ ___ Python-bugs-list

[issue27078] Make f'' strings faster than .format: BUILD_STRING opcode?

2016-09-03 Thread Eric V. Smith
Eric V. Smith added the comment: Left a review comment. I'd like to see this in before 3.6 beta 1. -- ___ Python tracker ___

[issue26040] Improve coverage and rigour of test.test_math

2016-09-03 Thread Mark Dickinson
Mark Dickinson added the comment: iss26040_v4.patch applied. I'm watching the buildbots; if everything looks good there, I'll close the issue. -- ___ Python tracker

[issue26040] Improve coverage and rigour of test.test_math

2016-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset e3dbe8b7279a by Mark Dickinson in branch 'default': Issue #26040: Improve test_math and test_cmath coverage and rigour. Thanks Jeff Allen. https://hg.python.org/cpython/rev/e3dbe8b7279a -- ___ Python

[issue27731] Opt-out of MAX_PATH on Windows 10

2016-09-03 Thread Brett Cannon
Brett Cannon added the comment: SGTM -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27935] logging level FATAL missing in _nameToLevel

2016-09-03 Thread Ondřej Medek
Ondřej Medek added the comment: Just a comment to the https://hg.python.org/cpython/rev/85f9f8bf2ec8 It's functionality is right. It's just a little bit weird, that two derived levels in _nameToLevel: 'FATAL' maps to FATAL, i.e. itself, while 'WARN' maps to the WARNING, i.e. to the main level

[issue27950] Superflous messages when running make

2016-09-03 Thread Xiang Zhang
Changes by Xiang Zhang : -- keywords: +patch Added file: http://bugs.python.org/file44355/issue27950.patch ___ Python tracker ___

[issue23591] enum: Add Flags and IntFlags

2016-09-03 Thread Ethan Furman
Ethan Furman added the comment: > 1) IntFlags is not simply the meet of int and Flags (like IntEnum is the > meet of int and Enum, > https://docs.python.org/3.5/library/enum.html#others)? > It seems a very different class. No, I think it is. The differences between Enum and IntEnum are

[issue27950] Superflous messages when running make

2016-09-03 Thread Xiang Zhang
New submission from Xiang Zhang: Every time running make I can get such messages: # Substitution happens here, as the completely-expanded BINDIR # is not available in configure sed -e "s,@EXENAME@,/usr/local/bin/python3.6m," < ./Misc/python-config.in >python-config.py # Replace makefile

[issue25405] User install of 3.5 removes py.exe from C:\Windows

2016-09-03 Thread Steve Dower
Steve Dower added the comment: I believe this issue is fixed (as of 3.5.1), and I don't specifically know what I'd do to make it more fixed, so I'm closing this. Changing the configuration of the launcher is a separate discussion. -- resolution: -> out of date stage: -> resolved

[issue26513] platform.win32_ver() broken in 2.7.11

2016-09-03 Thread Steve Dower
Steve Dower added the comment: I'll try and get to this during the week. I believe it's a fairly simple fix, though it will mean that platform.py diverges between 2.7 and 3.5+. -- resolution: fixed -> stage: resolved -> needs patch status: closed -> open

[issue27731] Opt-out of MAX_PATH on Windows 10

2016-09-03 Thread Steve Dower
Steve Dower added the comment: More info at https://blogs.msdn.microsoft.com/jeremykuhne/2016/07/30/net-4-6-2-and-long-paths-on-windows-10/ -- ___ Python tracker

[issue27731] Opt-out of MAX_PATH on Windows 10

2016-09-03 Thread Steve Dower
Steve Dower added the comment: Just discovered that this actually requires enabling the group policy for long paths - specifically setting HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem@LongPathsEnabled to 1. Apparently the manifest is also required, but in my testing the

[issue23591] enum: Add Flags and IntFlags

2016-09-03 Thread Vedran Čačić
Vedran Čačić added the comment: Hmm... so if I read you right: 1) IntFlags is not simply the meet of int and Flags (like IntEnum is the meet of int and Enum, https://docs.python.org/3.5/library/enum.html#others)? It seems a very different class. 2) (more important) If I give names to 1, 3,

[issue27934] json float encoding incorrect for dbus.Double

2016-09-03 Thread Mark Dickinson
Changes by Mark Dickinson : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___

[issue27934] json float encoding incorrect for dbus.Double

2016-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 86d66a627b77 by Mark Dickinson in branch '2.7': Issue #27934: Use float.__repr__ instead of plain repr when JSON-encoding an instance of a float subclass. Thanks Eddie James. https://hg.python.org/cpython/rev/86d66a627b77 -- nosy:

[issue27921] f-strings: do not allow backslashes

2016-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset fd4e4fa75260 by Eric V. Smith in branch 'default': Issue 27921: Remove backslash from another f-string. I'll revert this change before beta 2. I also need to look in to why test_tools/test_unparse fails with the files that are now being skipped.

[issue27934] json float encoding incorrect for dbus.Double

2016-09-03 Thread Mark Dickinson
Changes by Mark Dickinson : -- assignee: -> mark.dickinson ___ Python tracker ___ ___

[issue11734] Add half-float (16-bit) support to struct module

2016-09-03 Thread Mark Dickinson
Changes by Mark Dickinson : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue11734] Add half-float (16-bit) support to struct module

2016-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 519bde9db8e0 by Mark Dickinson in branch 'default': Issue #11734: Add support for IEEE 754 half-precision floats to the struct module. Original patch by Eli Stevens. https://hg.python.org/cpython/rev/519bde9db8e0 -- nosy: +python-dev

[issue19489] move quick search box above TOC

2016-09-03 Thread Berker Peksag
Berker Peksag added the comment: > I also found a regression in search.html. Please ignore this. It doesn't have anything to do with your patch. -- ___ Python tracker

[issue27935] logging level FATAL missing in _nameToLevel

2016-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 85f9f8bf2ec8 by Vinay Sajip in branch 'default': Closes #27935: returned numeric value for 'FATAL' logging level. https://hg.python.org/cpython/rev/85f9f8bf2ec8 -- nosy: +python-dev resolution: -> fixed stage: -> resolved status: open ->

[issue27930] logging's QueueListener drops log messages

2016-09-03 Thread Vinay Sajip
Vinay Sajip added the comment: Removed 3.3 and 3.4 as they are not in scope for non-security issues. -- versions: -Python 3.3, Python 3.4 ___ Python tracker

[issue25653] ctypes+callbacks+fork+selinux = crash

2016-09-03 Thread Armin Rigo
Armin Rigo added the comment: For completeness: * the crasher I attached gets a bus error even before calling ffi_closure_free(). At that point, only ffi_closure_alloc() has been called---in both parent and child. * stricly speaking, cffi is not fixed: it has the same problem when using

[issue27935] logging level FATAL missing in _nameToLevel

2016-09-03 Thread Vinay Sajip
Vinay Sajip added the comment: As this is an (admittedly small) change in behaviour, I'll apply in 3.6. -- versions: +Python 3.6 -Python 3.5 ___ Python tracker

[issue27937] logging.getLevelName microoptimization

2016-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0986401d0733 by Vinay Sajip in branch 'default': Fixes #27937: optimise code used in all logging calls. https://hg.python.org/cpython/rev/0986401d0733 New changeset e4b6faf22e8d by Vinay Sajip in branch '3.5': Fixes #27937: optimise code used in

[issue27921] f-strings: do not allow backslashes

2016-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 80eb6eb57537 by Eric V. Smith in branch 'default': Issue 27921: Remove backslash from another f-string. I'll revert this change before beta 2. https://hg.python.org/cpython/rev/80eb6eb57537 -- ___

[issue27949] Fix description in bytes literal doc

2016-09-03 Thread Eric V. Smith
Eric V. Smith added the comment: No problem! Thanks for caring enough to open an issue and submit a patch, even if we don't use it. -- stage: -> resolved ___ Python tracker

[issue27949] Fix description in bytes literal doc

2016-09-03 Thread Xiang Zhang
Xiang Zhang added the comment: Ooh, sorry. It seems I misunderstand the meaning of the sentence. I understand the value as the output of repr, I mean b'\x01'. It means how it's created. Thanks for your reply and sorry for the noise. I close this then. -- resolution: -> not a bug

[issue27949] Fix description in bytes literal doc

2016-09-03 Thread Eric V. Smith
Eric V. Smith added the comment: While they probably should be entered with escapes, there's no actual technical requirement for that. >From the command line, I can enter a control-A with control-V control-A (this >might be different depending on your environment, or if you use an editor).

[issue27949] Fix description in bytes literal doc

2016-09-03 Thread Xiang Zhang
New submission from Xiang Zhang: This sentence "bytes with a numeric value of 128 or greater must be expressed with escapes" is wrong and not complete. The value needs to be escaped is >= 127 and < 32. -- assignee: docs@python components: Documentation files:

[issue27921] f-strings: do not allow backslashes

2016-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 899ee1e68a8d by Eric V. Smith in branch 'default': Issue 27921: Remove backslash from another f-string. https://hg.python.org/cpython/rev/899ee1e68a8d -- ___ Python tracker

[issue27921] f-strings: do not allow backslashes

2016-09-03 Thread Eric V. Smith
Eric V. Smith added the comment: See issue 27948 for adding backslashes back in to the string parts of an f-string. -- ___ Python tracker ___

[issue27948] f-strings: allow backslashes only in the string parts, not in the expression parts

2016-09-03 Thread Eric V. Smith
New submission from Eric V. Smith: See issue 27921. Currently (and for 3.6 beta 1), backslashes are not allowed anywhere in f-strings. This needs to be changed to allow them in the string parts, but not in the expression parts. Also, require that the start and end of an expression be literal

[issue27921] f-strings: do not allow backslashes

2016-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset d7ce127b5c0f by Eric V. Smith in branch 'default': Closes issue 27921: Disallow backslashes anywhere in f-strings. This is a temporary restriction. In 3.6 beta 2, the plan is to again allow backslashes in the string parts of f-strings, but

[issue19489] move quick search box above TOC

2016-09-03 Thread Berker Peksag
Berker Peksag added the comment: > Do you mean in addition to the "Quick search" text that is already on the > page or do you want to remove that? The latter. All of the popular browsers (Chrome, Firefox, Edge and even Safari) already support the placeholder attribute so I think we can safely

[issue27923] PEP 467 -- Minor API improvements for binary sequences

2016-09-03 Thread Martin Panter
Martin Panter added the comment: Sorry Elias for not explaining my commands. xclip was just my way of pasting the patch URL from the clipboard (that I copied from Firefox). It is not clear if we are actually making a DeprecationWarning, or going down the road of changing all the stdlib. But

[issue25653] ctypes+callbacks+fork+selinux = crash

2016-09-03 Thread Christian Heimes
Christian Heimes added the comment: Thanks Armin, I didn't know that your reported the bug in bugs.python.org until today. Last year Armin and I spent a good amount of time to analyse the situation. Armin was able to come up with a different callback implementation for cffi that that does

[issue25653] ctypes+callbacks+fork+selinux = crash

2016-09-03 Thread Christian Heimes
Changes by Christian Heimes : -- nosy: +christian.heimes ___ Python tracker ___ ___

[issue27936] Inconsistent round behavior between float and int

2016-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset c3c4d8e4ca1a by Raymond Hettinger in branch '3.5': Issue 27936: Fix inconsistent round() behavior between float and int https://hg.python.org/cpython/rev/c3c4d8e4ca1a -- nosy: +python-dev ___ Python

[issue27936] Inconsistent round behavior between float and int

2016-09-03 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: -> rhettinger resolution: -> fixed status: open -> closed versions: +Python 3.6 ___ Python tracker

[issue25653] ctypes+callbacks+fork+selinux = crash

2016-09-03 Thread Armin Rigo
Changes by Armin Rigo : -- versions: +Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5, Python 3.6 ___ Python tracker

[issue25653] ctypes+callbacks+fork+selinux = crash

2016-09-03 Thread Armin Rigo
Armin Rigo added the comment: Attached trivial example. This gives for me a bus error when run with selinux (actually tested by changing the "return 0;" to "return 1;" in selinux_enabled_check() file Modules/_ctypes/libffi/src/closures.c). If you comment out any of the two do_stuff() calls,