[issue28480] Compile error on Modules/socketmodule.c

Roundup Robot added the comment: New changeset 9316b4ebf3fa by Martin Panter in branch '3.6': Issue #28480: Avoid label at end of compound statement --without-threads https://hg.python.org/cpython/rev/9316b4ebf3fa New changeset 7cb86d404866 by Martin Panter in branch '3.6': Issue #28480: Adjust

[issue28481] Weird string comparison bug

Eryk Sun added the comment: Interning of strings is an implementation detail for the efficient storage of variable and attribute names. A string with ':' in it cannot be a variable or attribute name and thus is not interned. But you don't need to know which strings are interned or why they're

[issue28482] test_typing fails if asyncio unavailable

New submission from Martin Panter: If you compile with “configure --without-threads”, various tests are already skipped because they rely on multithreading. However test_typing does not seem to handle this. It tries to import “asyncio”, which seems to depend on multithreading. I presume it is

[issue28447] socket.getpeername() failure on broken TCP/IP connection

Georgey added the comment: The socket close accident is not caused by queue or calling handle_sock_error at all, it happened right after select error After changing the Exception handling of main Thread: except Exception as err:

[issue28481] Weird string comparison bug

New submission from MinJae Kwon: I found bug i think about string comparison > var1 = 'aa' > var1 is 'aa' # This is True But if the string literal has special chacter (e.g., colon), the comparison results in False > var2 = ':bb' > var2 is ':bb' # This is False Check it please. --

[issue28480] Compile error on Modules/socketmodule.c

Roundup Robot added the comment: New changeset 17629dee23ca by Martin Panter in branch '2.7': Issue #28480: Avoid label at end of compound statement --without-threads https://hg.python.org/cpython/rev/17629dee23ca -- nosy: +python-dev ___ Python

[issue28474] WinError(): Python int too large to convert to C long

Kelvin You added the comment: Here is the full list of windows error code: https://msdn.microsoft.com/en-us/library/cc231196.aspx You can see a lot of error codes is above 0x8000. -- ___ Python tracker

[issue26240] Docstring of the subprocess module should be cleaned up

Martin Panter added the comment: . I left some comments on the code review. Also, I’m not sure about the links to the online documentation. We don’t do this for other modules as far as I know. The pydoc module and help() commands already add their own links, which can be configured via

[issue28474] WinError(): Python int too large to convert to C long

Kelvin You added the comment: I report this issue because the function WlanScan(https://msdn.microsoft.com/zh-cn/library/windows/desktop/ms706783(v=vs.85).aspx) returns a error code 0x80342002 when the WLAN is disabled on Windows 10. ctypes.WinError() raise an exception of 'Python int too

[issue28474] WinError(): Python int too large to convert to C long

Josh Rosenberg added the comment: You can't use I as a format code safely; it silently ignores/wraps overflow on the conversion, where i raises on overflow. The unsigned converters are basically useless for resilient code in 99% of cases. I *think* I remember some private utility functions

[issue28447] socket.getpeername() failure on broken TCP/IP connection

Georgey added the comment: I have changed the code to report any error that occurs in receiving message, and it reports: [WinError10054] An existing connection was forcibly closed by the remote host Well, this error is the one we need to handle, right? A server need to deal with abrupt

[issue28480] Compile error on Modules/socketmodule.c

Masayuki Yamamoto added the comment: Oh, that's enough to work, Martin. I confirmed too. -- ___ Python tracker ___

[issue28480] Compile error on Modules/socketmodule.c

Martin Panter added the comment: Thanks for the report and patch. I think an empty statement might be better than the dummy assignment. Let me know if the following would work and I will commit it: done: +; /* necessary for --without-threads flag */ Py_END_ALLOW_THREADS

[issue28447] socket.getpeername() failure on broken TCP/IP connection

Martin Panter added the comment: When I run your program on Linux (natively, and I also tried Wine), the worst behaviour I get is a busy loop as soon as a client shuts down the connection and recv() returns an empty string. I would have to force an exception in the top level code to trigger

[issue28480] Compile error on Modules/socketmodule.c

New submission from Masayuki Yamamoto: _socket module has failed to compile with --without-threads flag since 554fb699af8c, because Py_END_ALLOW_THREADS macro exists behind the done label ( Modules/socketmodule.c:666 ). If --without-threads flag goes on, Py_END_ALLOW_THREADS macro replaces to

[issue28444] Missing extensions modules when cross compiling python 3.5.2 for arm on Linux

Martin Panter added the comment: Your second patch looks better, given my limited understanding of the scripts involved. :) I left one more suggestion though. -- ___ Python tracker

[issue28479] Missing indentation in using/windows.rst

STINNER Victor added the comment: Thanks for your contribution Julien. -- nosy: +haypo ___ Python tracker ___

[issue28479] Missing indentation in using/windows.rst

Roundup Robot added the comment: New changeset 39ac5093bdbb by Victor Stinner in branch '3.6': Close #28479: Fix reST syntax in windows.rst https://hg.python.org/cpython/rev/39ac5093bdbb -- nosy: +python-dev resolution: -> fixed stage: -> resolved status: open -> closed

[issue28479] Missing indentation in using/windows.rst

New submission from Julien: Hi, In https://docs.python.org/3.7/using/windows.html, right before https://docs.python.org/3.7/using/windows.html#additional-modules, the "Changed in version 3.6:" content lacks an indentation. It look like it's nothing, but it breaks the PDF generation, by

[issue22431] Change format of test runner output

Changes by Jon Dufresne : -- nosy: +jdufresne ___ Python tracker ___ ___

[issue20361] -W command line options and PYTHONWARNINGS environmental variable should not override -b / -bb command line options

Changes by Jon Dufresne : -- nosy: +jdufresne ___ Python tracker ___ ___

[issue1520879] make install change: Allow $DESTDIR to be relative

Douglas Greiman added the comment: Duplicate of http://bugs.python.org/issue11411 -- ___ Python tracker ___

[issue1520879] make install change: Allow $DESTDIR to be relative

Changes by Douglas Greiman : -- status: open -> closed ___ Python tracker ___ ___

[issue28478] Built-in module 'Time' does not enable functions if -Wno-error specified in the build environment

toast12 added the comment: Excuse my typo. I meant -Werror and not -Wno-error -- ___ Python tracker ___ ___

[issue28478] Built-in module 'Time' does not enable functions if -Wno-error specified in the build environment

New submission from toast12: Our build environment uses -Wno-error. However, this causes problems enabling all the functions in built-in module 'time': configure:11130: checking for strftime - - cc1: warnings being treated as errors conftest.c:236: error: conflicting types for built-in

[issue28475] Misleading error on random.sample when k < 0

Changes by Francisco Couzo : Added file: http://bugs.python.org/file45144/random_sample2.patch ___ Python tracker ___

[issue28475] Misleading error on random.sample when k < 0

Raymond Hettinger added the comment: I would rather revise the existing message to say that it cannot be negative or larger that population. -- ___ Python tracker

[issue26685] Raise errors from socket.close()

Yury Selivanov added the comment: >> Would you mind to open an issue specific for asyncio? > I'll open an issue on GH today to discuss with you/Guido/asyncio devs. Guido, Victor, please take a look: https://github.com/python/asyncio/pull/449 -- ___

[issue28444] Missing extensions modules when cross compiling python 3.5.2 for arm on Linux

Xavier de Gaye added the comment: Thanks for reviewing the patch Martin. > Why do you remove the code that loops over Modules/Setup? Maybe is it > redundant with the other code for removing the already-built-in modules? Yes because this is redundant, maybe not the case when this was written

[issue28477] Add optional user argument to pathlib.Path.home()

Serhiy Storchaka added the comment: pathlib.Path.home() don't support the user argument for reasons. The main problem is that os.path.expanduser() for other users is faked on Windows. It uses guessing, and perhaps it returns correct result in most cases. But in non-standard situations, if

[issue28477] Add optional user argument to pathlib.Path.home()

New submission from Josh Rosenberg: os.path.expanduser supports both '~' and '~username` constructs to get home directories. It seems reasonable for pathlib.Path.home to default to getting the current user's home directory, but support passing an argument to get the home directory for another

[issue19795] Formatting of True/False/None in docs

Serhiy Storchaka added the comment: Thanks Zachary. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue19795] Formatting of True/False/None in docs

Roundup Robot added the comment: New changeset c445746d0846 by Serhiy Storchaka in branch '3.5': Issue #19795: Fixed formatting a table. https://hg.python.org/cpython/rev/c445746d0846 New changeset 3b554c9ea1c4 by Serhiy Storchaka in branch '3.6': Issue #19795: Fixed formatting a table.

[issue26685] Raise errors from socket.close()

Yury Selivanov added the comment: > Ah, you became reasonable :-D Come on... :) > Would you mind to open an issue specific for asyncio? I'll open an issue on GH today to discuss with you/Guido/asyncio devs. -- ___ Python tracker

[issue26685] Raise errors from socket.close()

STINNER Victor added the comment: "After thinking about this problem for a while, I arrived to the conclusion that we need to fix asyncio." Ah, you became reasonable :-D "Essentially, when a user passes a socket object to the event loop API like 'create_server', they give up the control of

[issue26685] Raise errors from socket.close()

Yury Selivanov added the comment: After thinking about this problem for a while, I arrived to the conclusion that we need to fix asyncio. Essentially, when a user passes a socket object to the event loop API like 'create_server', they give up the control of the socket to the loop. The loop

[issue19795] Formatting of True/False/None in docs

Zachary Ware added the comment: There's also an issue with a table in Doc/library/logging.rst, see http://buildbot.python.org/all/builders/Docs%203.x/builds/2675/steps/docbuild/logs/stdio I'm not sure why that doesn't cause the build to fail, though, it's marked as an error. -- nosy:

[issue19795] Formatting of True/False/None in docs

Serhiy Storchaka added the comment: Thank you for noticing this Victor. -- ___ Python tracker ___ ___

[issue19795] Formatting of True/False/None in docs

Roundup Robot added the comment: New changeset e4aa34a7ca53 by Serhiy Storchaka in branch '3.5': Issue #19795: Improved more markups of True/False. https://hg.python.org/cpython/rev/e4aa34a7ca53 New changeset dd7e48e3e5b0 by Serhiy Storchaka in branch '2.7': Issue #19795: Improved more markups

[issue19795] Formatting of True/False/None in docs

STINNER Victor added the comment: Thanks, "build #1563 of Docs 3.5 is complete: Success [build successful]": the bot is happy again ;-) -- ___ Python tracker

[issue19795] Formatting of True/False/None in docs

Fred L. Drake, Jr. added the comment: Without the star would be right. ReST does not support nested markup, and in this case, I don't think it would make sense anyway. -- nosy: +fdrake ___ Python tracker

[issue19795] Formatting of True/False/None in docs

Roundup Robot added the comment: New changeset 9ef78351d2e9 by Serhiy Storchaka in branch '3.5': Issue #19795: Fixed markup errors. https://hg.python.org/cpython/rev/9ef78351d2e9 New changeset 6c8a26e60728 by Serhiy Storchaka in branch '3.6': Issue #19795: Fixed markup errors.

[issue26568] Add a new warnings.showwarnmsg() function taking a warnings.WarningMessage object

Sebastian Berg added the comment: To make warning testing saner, in numpy we added basically my own version of catch_warnings on steroids, which needed/will need changing because of this. Unless I missed it somewhere, this change should maybe put into the release notes to warn make it a bit

[issue19795] Formatting of True/False/None in docs

STINNER Victor added the comment: The "Docs" bot doesn't like your change: http://buildbot.python.org/all/builders/Docs%203.x/builds/2673/steps/suspicious/logs/stdio WARNING: [whatsnew/3.1:549] "`" found in "``False``" WARNING: [whatsnew/3.4:163] "`" found in "to ``None`" WARNING:

[issue28240] Enhance the timeit module: display average +- std dev instead of minimum

Roundup Robot added the comment: New changeset 4e4d4e9183f5 by Victor Stinner in branch 'default': Issue #28240: Fix formatting of the warning. https://hg.python.org/cpython/rev/4e4d4e9183f5 -- ___ Python tracker

[issue19795] Formatting of True/False/None in docs

Roundup Robot added the comment: New changeset cef2373f31bb by Serhiy Storchaka in branch '2.7': Issue #19795: Mark up None as literal text. https://hg.python.org/cpython/rev/cef2373f31bb New changeset a8d5b433bb36 by Serhiy Storchaka in branch '3.5': Issue #19795: Mark up None as literal text.

[issue28473] mailbox.MH crashes on certain Claws Mail .mh_sequences files

R. David Murray added the comment: I meant 'nmh'. Also, if the problem is that mailbox blows up on an .mh_sequences file with bad records and doesn't provide any way to access the valid records (like nmh mostly manages to do), then that is something that could be fixed, and we can reopen the

[issue28447] socket.getpeername() failure on broken TCP/IP connection

Georgey added the comment: so when do you think the error socket closes? -- ___ Python tracker ___ ___

[issue28447] socket.getpeername() failure on broken TCP/IP connection

Martin Panter added the comment: I haven’t tried running your program, but I don’t see anything stopping multiple references to the same socket appearing in the “mailbox” queue. Once the first reference has been processed, the socket will be closed, so subsequent getpeername() calls will be

[issue26944] test_posix: Android 'id -G' is entirely wrong or missing the effective gid

Changes by Xavier de Gaye : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue26944] test_posix: Android 'id -G' is entirely wrong or missing the effective gid

Roundup Robot added the comment: New changeset fb3e65aff225 by Xavier de Gaye in branch '3.6': Issue #26944: Fix test_posix for Android where 'id -G' is entirely wrong https://hg.python.org/cpython/rev/fb3e65aff225 New changeset 465c09937e85 by Xavier de Gaye in branch 'default': Issue #26944:

[issue28447] socket.getpeername() failure on broken TCP/IP connection

Georgey added the comment: As your request, I simplify the server here: -- import socket import select, time import queue, threading ISOTIMEFORMAT = '%Y-%m-%d %X' BUFSIZ = 2048 TIMEOUT = 10 ADDR = ('', 15625) SEG = "◎◎" SEG_ =

[issue23188] Provide a C helper function to chain raised (but not yet caught) exceptions

Serhiy Storchaka added the comment: This helper is convenient in many cases, but it is very limited. It raises an exception with single string argument. It doesn't work in cases when the exception doesn't take arguments (PyErr_SetNone) or takes multiple or non-string arguments

[issue28476] Remove redundant definition of factorial on test_random

STINNER Victor added the comment: Thanks for your contribution Francisco. test_random still pass. I pushed your safe and well contained patch. It don't see any good reason why test_random had its own pure (and slow) Python implementation of factorial(), it's probably because test_random.py

[issue28476] Remove redundant definition of factorial on test_random

New submission from Roundup Robot: New changeset c6588a7443a4 by Victor Stinner in branch 'default': Close #28476: Reuse math.factorial() in test_random https://hg.python.org/cpython/rev/c6588a7443a4 -- nosy: +python-dev resolution: -> fixed stage: -> resolved status: open -> closed

[issue26944] test_posix: Android 'id -G' is entirely wrong or missing the effective gid

Changes by Xavier de Gaye : -- title: android: test_posix fails -> test_posix: Android 'id -G' is entirely wrong or missing the effective gid ___ Python tracker

[issue26944] android: test_posix fails

Changes by Xavier de Gaye : -- dependencies: -add the 'is_android' attribute to test.support ___ Python tracker ___

[issue28476] Remove redundant definition of factorial on test_random

Changes by Francisco Couzo : -- components: Tests files: test_random.patch keywords: patch nosy: franciscouzo priority: normal severity: normal status: open title: Remove redundant definition of factorial on test_random Added file:

[issue25731] Assigning and deleting __new__ attr on the class does not allow to create instances of this class

Changes by Serhiy Storchaka : -- resolution: fixed -> stage: resolved -> versions: +Python 3.7 -Python 3.4 ___ Python tracker

[issue28474] WinError(): Python int too large to convert to C long

Changes by Serhiy Storchaka : -- components: +Windows nosy: +amaury.forgeotdarc, belopolsky, meador.inge, paul.moore, steve.dower, tim.golden, zach.ware type: crash -> behavior versions: +Python 3.7 -Python 3.3, Python 3.4

[issue28475] Misleading error on random.sample when k < 0

Changes by Serhiy Storchaka : -- assignee: docs@python -> rhettinger components: -Tests nosy: +mark.dickinson, rhettinger stage: -> patch review type: -> behavior versions: +Python 2.7, Python 3.5, Python 3.6, Python 3.7

[issue28475] Misleading error on random.sample when k < 0

New submission from Francisco Couzo: Improved a bit the error message when k < 0, and also added a comment about it on the documentation and an additional test case. -- assignee: docs@python components: Documentation, Library (Lib), Tests files: random_sample.patch keywords: patch

[issue28474] WinError(): Python int too large to convert to C long

New submission from Kelvin You: // callproc.c static PyObject *format_error(PyObject *self, PyObject *args) { PyObject *result; wchar_t *lpMsgBuf; DWORD code = 0; if (!PyArg_ParseTuple(args, "|i:FormatError", )) ^ Here the format string should

[issue25731] Assigning and deleting __new__ attr on the class does not allow to create instances of this class

Bohuslav "Slavek" Kabrda added the comment: Hi all, it seems to me that this change has been reverted not only in 2.7, but also in 3.5 (changeset: 101549:c8df1877d1bc). Benjamin, was this intentional? If so, perhaps this issue should be reopened and not marked as resolved. Thanks a lot!

[issue28472] SystemTap usage examples in docs are incorrect

Roundup Robot added the comment: New changeset 5c21df505684 by Benjamin Peterson in branch '3.6': always use double quotes for SystemTap string literals (closes #28472) https://hg.python.org/cpython/rev/5c21df505684 New changeset dc10bd89473b by Benjamin Peterson in branch 'default': merge 3.6