[issue28353] os.fwalk() unhandled exception when error occurs accessing symbolic link target

Xiang Zhang added the comment: Serhiy, after your commits, test_os requires root privileges or it'll fail. This is not the case before. [cpython]$ ./python -m test test_os Run tests sequentially 0:00:00 [1/1] test_os test test_os crashed -- Traceback (most recent call last): File

[issue28544] Implement asyncio.Task in C

Yury Selivanov added the comment: > - and `tasks.py` imports `futures.py` to have `isfuture`. And tasks.py also imports coroutines.py (which was importing futures.py), making the cycle even worse. Anyways, I don't see a problem in moving a function or two that everybody uses into a separate

[issue28544] Implement asyncio.Task in C

Yury Selivanov added the comment: > Why isfuture() is moved, and asyncio.coroutine uses > base_futures.isfuture() instead of futures.isfuture()? Import cycles: - `_asyncio` module is now being imported from `futures.py` - and `_asyncio` is now imported from `tasks.py`; - and `tasks.py`

[issue28544] Implement asyncio.Task in C

INADA Naoki added the comment: Why isfuture() is moved, and asyncio.coroutine uses base_futures.isfuture() instead of futures.isfuture()? -- ___ Python tracker

[issue28544] Implement asyncio.Task in C

Yury Selivanov added the comment: Uploading a new patch: sorted imports; added a unittest that exceptions in loop.call_soon aren't breaking Task.__init__. -- Added file: http://bugs.python.org/file45248/ctask3.patch ___ Python tracker

[issue28088] Document Transport.set_protocol and get_protocol

INADA Naoki added the comment: LGTM -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28088] Document Transport.set_protocol and get_protocol

Mariatta Wijaya added the comment: I added a note like this. .. note:: Switching protocol should only be done when both protocols are documented to support the switch. Would this work? Would appreciate any feedback of how to properly document this behavior. Thanks. -- Added

[issue28531] Improve utf7 encoder memory usage

Xiang Zhang added the comment: Actually the patch is not going to speed up the encoder but just make the memory allocation strategy better, make the memory upper bound tighter. The speedup is just a good side effect. > It is rather in the line of idna and punycode than UTF-8 and UTF-32.

[issue28541] Improve test coverage for json library - loading bytes

Eric Appelt added the comment: Thanks for the feedback. I agree that the comment is incorrect for several iterations of the loop that really don't need to be tested at all for '5'. I read the previous issue 17909 more carefully along with RFC 4627, 7159, and EMCA 404 to properly understand

[issue28522] can't make IDLEX work with python._pth and python-3.6.0b2

Steve Dower added the comment: Fixed and added a test. (Yes I know that it's not the most efficient algorithm for joining the strings together, but I consider correctness to be more important here.) -- stage: needs patch -> commit review type: -> crash versions: +Python 3.7

[issue28522] can't make IDLEX work with python._pth and python-3.6.0b2

Roundup Robot added the comment: New changeset eea669163131 by Steve Dower in branch '3.6': Issue #28522: Fixes mishandled buffer reallocation in getpathp.c https://hg.python.org/cpython/rev/eea669163131 New changeset 72e64fc8746b by Steve Dower in branch 'default': Issue #28522: Fixes

[issue28544] Implement asyncio.Task in C

Yury Selivanov added the comment: Guido, Ned, thanks! Andrew already glanced through the code, let's see what Inada-san says. I'm uploading an updated patch addressing Andrew's review. -- Added file: http://bugs.python.org/file45245/ctask2.patch

[issue28544] Implement asyncio.Task in C

Ned Deily added the comment: I also trust Yury to do the right thing. -- ___ Python tracker ___ ___

[issue28544] Implement asyncio.Task in C

Guido van Rossum added the comment: I don't want to be the decider here. I don't have time to review the code. I trust you all to do the right thing. -- ___ Python tracker

[issue22949] fnmatch.translate doesn't add ^ at the beginning

Roundup Robot added the comment: New changeset a1aef5f84142 by Serhiy Storchaka in branch '3.5': Issue #22949: Documented that fnmatch.translate() is for use with re.match(). https://hg.python.org/cpython/rev/a1aef5f84142 New changeset 8a564ab1d208 by Serhiy Storchaka in branch '2.7': Issue

[issue22949] fnmatch.translate doesn't add ^ at the beginning

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue22493] Deprecate the use of flags not at the start of regular expression

Roundup Robot added the comment: New changeset c04a56b3a4f2 by Serhiy Storchaka in branch '3.6': Issue #22493: Updated an example for fnmatch.translate(). https://hg.python.org/cpython/rev/c04a56b3a4f2 New changeset ded9a3c3bbb6 by Serhiy Storchaka in branch 'default': Issue #22493: Updated an

[issue28212] Closing server in asyncio is not efficient

Andrew Svetlov added the comment: >From my perspective the problem is: many asyncio calls schedules a delayed >activity internally. E.g. `task.cancel()` doesn't cancels immediately but requires at least one extra loop iteration. The same is true for `transport.close()` -- it doesn't close

[issue28544] Implement asyncio.Task in C

Andrew Svetlov added the comment: Very impressive. I've left a couple comments in rietveld though. -- ___ Python tracker ___

[issue28522] can't make IDLEX work with python._pth and python-3.6.0b2

Steve Dower added the comment: It's a genuine bug in path processing, specifically how we handle buffer resizing. I'll make a fix. -- assignee: -> steve.dower stage: -> needs patch ___ Python tracker

[issue28496] Mark up constants 0, 1, -1 in C API docs

Roundup Robot added the comment: New changeset e90fe2209276 by Serhiy Storchaka in branch '2.7': Issue #28496: Mark up constants 0, 1 and -1 that denote return values or https://hg.python.org/cpython/rev/e90fe2209276 New changeset 04065efd7747 by Serhiy Storchaka in branch '3.5': Issue #28496:

[issue28545] socket.bind to AF_PACKET should use passed interface name

Martin Turon added the comment: Just for clarity, the high level bug is that when binding to an interface using AF_PACKET, transmissions work, but receive does not: sock = socket.socket(socket.AF_PACKET, socket.SOCK_RAW, ETH_P_IEEE802154) sock.bind(("monitor0", ETH_P_IEEE802154))

[issue28496] Mark up constants 0, 1, -1 in C API docs

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue28544] Implement asyncio.Task in C

Ned Deily added the comment: If it's OK with Guido, it's OK with me for 360b3. (That's Monday.) -- ___ Python tracker ___

[issue28528] Pdb.checkline()

Changes by Xavier de Gaye : -- nosy: +xdegaye ___ Python tracker ___ ___ Python-bugs-list

[issue28426] PyUnicode_AsDecodedObject can only return unicode now

Serhiy Storchaka added the comment: Thanks Xiang. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue28545] socket.bind to AF_PACKET should use passed interface name

New submission from Martin Turon: When binding to AF_PACKET linux kernel sockets, the interface name is not passed in when given -- it is always "". This causes problems, for example, receiving packets to a "monitor0" interface doesn't work. diff -r a6548e230ed6 Modules/socketmodule.c ---

[issue28426] PyUnicode_AsDecodedObject can only return unicode now

Roundup Robot added the comment: New changeset 15a494886c5a by Serhiy Storchaka in branch '3.6': Issue #28426: Deprecated undocumented functions PyUnicode_AsEncodedObject(), https://hg.python.org/cpython/rev/15a494886c5a New changeset 50c28727d91c by Serhiy Storchaka in branch 'default': Issue

[issue28531] Improve utf7 encoder memory usage

Serhiy Storchaka added the comment: The performance of the UTF-7 codec is not important. Unlikely to other UTF-* encodings this is not standard Unicode encoding. It is used in minority of applications and unlikely is a bottleneck. It is rather in the line of idna and punycode than UTF-8 and

[issue28540] math.degrees(sys.float_info.max) should throw an OverflowError exception

Mark Dickinson added the comment: Actually, here's a patch. -- keywords: +patch Added file: http://bugs.python.org/file45244/math-degrees-overflow.diff ___ Python tracker

[issue28544] Implement asyncio.Task in C

Yury Selivanov added the comment: > Yury, would you like to merge this before 3.6b3? Yes! > I'll look this as soon as possible. Thanks a lot! -- ___ Python tracker

[issue28544] Implement asyncio.Task in C

INADA Naoki added the comment: Wow! Great Job! Yury, would you like to merge this before 3.6b3? I'll look this as soon as possible. (nit fix) Some modules doesn't sort imports in lexicography. -- ___ Python tracker

[issue28522] can't make IDLEX work with python._pth and python-3.6.0b2

Big Stone added the comment: maybe click on the "WinPython Command Prompt.exe" and do "pip uninstall IDLEX" as a first step. so you should see IDLE working -- ___ Python tracker

[issue28522] can't make IDLEX work with python._pth and python-3.6.0b2

Big Stone added the comment: hi Steve, You can grab it there https://sourceforge.net/projects/winpython/files/WinPython_3.6/3.6.0.0/betas/WinPython-64bit-3.6.0.0Zerorc2.exe/download MD5 | SHA-1| SHA-256

[issue28531] Improve utf7 encoder memory usage

Xiang Zhang added the comment: v2 uses _PyBytesWriter so we can use on stack buffer for short string. -- Added file: http://bugs.python.org/file45243/utf7_encoder_v2.patch ___ Python tracker

[issue28544] Implement asyncio.Task in C

Yury Selivanov added the comment: Also, with this patch uvloop becomes ~3-5% faster too. -- ___ Python tracker ___

[issue28544] Implement asyncio.Task in C

Changes by Elvis Pranskevichus : -- nosy: +Elvis.Pranskevichus ___ Python tracker ___ ___

[issue28526] Use PyUnicode_AsEncodedString instead of PyUnicode_AsEncodedObject

Serhiy Storchaka added the comment: Thank you for your review Josh. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 2.7 ___ Python tracker

[issue28526] Use PyUnicode_AsEncodedString instead of PyUnicode_AsEncodedObject

Roundup Robot added the comment: New changeset bea48e72cae5 by Serhiy Storchaka in branch '3.5': Issue #28526: Use PyUnicode_AsEncodedString() instead of https://hg.python.org/cpython/rev/bea48e72cae5 New changeset fe9f361f3751 by Serhiy Storchaka in branch '3.6': Issue #28526: Use

[issue28544] Implement asyncio.Task in C

New submission from Yury Selivanov: The attached patch implements asyncio.Task in C. Besides that, it also implements Argument Clinic for C Future. Performance improvement on a simple echo server implementation using asyncio.streams: Python Future & Task | C Future & Py Task | C

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Then I don't have any objections. But I also couldn't test the change — I only use Firefox (and sometimes Chrome). -- ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Serhiy Storchaka added the comment: Currently Netscape is just an alias to Mozilla. Since SeaMonkey is synchronized with Firefox, I suppose it dropped the support of the -remote option at the same time. Debian rebranded Firefox and SeaMonkey at 2006, therefore IceWeasel and IceApe always

[issue28541] Improve test coverage for json library - loading bytes

Serhiy Storchaka added the comment: The patch in issue17909 was written to implement encoding detecting described in RFC 4627 [1]. And the test uses RFC 4627 conforming data. A single codepoint "5" is not valid in RFC 4627, but is valid in RFC 7159 [2]. The comment in your patch is not

[issue28401] Don't support the PEP384 stable ABI in pydebug builds

Stefano Rivera added the comment: I wouldn't say it's *entirely* Debian-specific. It just bites anyone who actually needs these tags to differentiate between built extensions. (Mostly Debian) Yes, changing the tag is a more complete solution. It just seemed that that option was decided

[issue28401] Don't support the PEP384 stable ABI in pydebug builds

Matthias Klose added the comment: I'm not sure that you really want this, because it would make it impossible to build an extension for the stable ABI for a debug build. The problem is Debian specific, because we install the extension modules for normal and debug builds in the same location.

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: I'd rather rename the new class to something like Firefox. So there will be 3 classes — Netscape, Mozilla and Firefox. Firefox only for firefox executable. -- ___ Python tracker

[issue28542] document cross compilation

Changes by Xavier de Gaye : -- components: +Cross-Build, Documentation nosy: +Alex.Willmer ___ Python tracker ___

[issue28522] can't make IDLEX work with python._pth and python-3.6.0b2

Steve Dower added the comment: I suspect there's a .pth file in site-packages that is importing something to trigger the failure. Without a crash dump (or debug build) it's going to be difficult to find it, but it is certainly an unwrapped invalid parameter termination. To save me some time,

[issue28543] Incomplete fast path codecs aliases in codecs doc

New submission from Xiang Zhang: The fast path codec aliases in codecs doc is complete especially after 99818330b4c0. -- assignee: docs@python components: Documentation files: codecs_doc.patch keywords: patch messages: 279538 nosy: docs@python, haypo, xiang.zhang priority: normal

[issue28541] Improve test coverage for json library - loading bytes

Eric Appelt added the comment: I looked back and something is clearly wrong with my coverage reporting setup, sorry :( When I move the test introduced in issue 17909, 'test_bytes_decode' from the module Lib/test/test_json/test_unicode.py to Lib/test/test_json/test_decode.py that particular

[issue28540] math.degrees(sys.float_info.max) should throw an OverflowError exception

Mark Dickinson added the comment: Francisco: would you be interested in writing a patch? -- ___ Python tracker ___

[issue28540] math.degrees(sys.float_info.max) should throw an OverflowError exception

Mark Dickinson added the comment: I agree in principle. On one hand, it's difficult to care too much, since `math.degrees` is going to be all-but-useless for inputs larger than `1e20` or so anyway (the actual angle represented is getting lost in floating-point noise by that point). OTOH,

[issue28509] dict.update allocates too much

Changes by INADA Naoki : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue28509] dict.update allocates too much

Roundup Robot added the comment: New changeset 8c2615decd2e by INADA Naoki in branch '3.6': Issue #28509: dict.update() no longer allocate unnecessary large memory https://hg.python.org/cpython/rev/8c2615decd2e New changeset deb3e5857d8c by INADA Naoki in branch 'default': Issue #28509:

[issue28444] Missing extensions modules when cross compiling python 3.5.2 for arm on Linux

Xavier de Gaye added the comment: New patch taking into account Martin last review and some updated comments. >> Why do you remove the code that loops over Modules/Setup? Maybe is it >> redundant with the other code for removing the already-built-in modules? > Yes because this is redundant,

[issue28542] document cross compilation

New submission from Xavier de Gaye: Patch adding a section to the README. -- assignee: xdegaye files: readme.patch keywords: patch messages: 279532 nosy: xdegaye priority: normal severity: normal stage: patch review status: open title: document cross compilation type: enhancement

[issue28541] Improve test coverage for json library - loading bytes

Serhiy Storchaka added the comment: Isn't the test added in issue17909 enough? -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue27275] KeyError thrown by optimised collections.OrderedDict.popitem()

Serhiy Storchaka added the comment: In issue28014 __getitem__() is idempotent. Multiple calls of __getitem__() return the same result and keep the OrderedDict in the same state. > I'd be perfectly happy with making popitem implemented in terms of pop on > subclasses when pop is overridden (if

[issue23262] webbrowser module broken with Firefox 36+

Serhiy Storchaka added the comment: The problem is that this class is used for Netscape and old Mozilla browsers. What if rename old Mozilla class to Netscape and use it for old browsers? -- Added file: http://bugs.python.org/file45237/webbrowser.py-3.5-2.patch

[issue23262] webbrowser module broken with Firefox 36+

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file45236/webbrowser.py-3.5.patch ___ Python tracker ___

[issue28509] dict.update allocates too much

Serhiy Storchaka added the comment: 28509-smaller-update2.patch LGTM. Your idea in msg279480 looks worth, but needs benchmarking different corner cases to check that it doesn't cause to a regression. I think we will have enough time for this at 3.7 developing stage. -- assignee: ->

[issue28522] can't make IDLEX work with python._pth and python-3.6.0b2

Eryk Sun added the comment: You may have uncovered a bug in Python that's causing the invalid parameter handler to be invoked. It would help if you uploaded the zipped dump file for the crashed process. The status code you're getting (i.e. STATUS_STACK_BUFFER_OVERRUN, 0xC409) is used by

[issue10656] "Out of tree" build fails on AIX

Michael Haubenwallner added the comment: Modules/python.exp is generated at build-time, thus does not belong to $(srcdir). -- ___ Python tracker ___