[issue28591] imghdr doesn't recognize some jpeg formats

[Xiang Zhang]

Xiang Zhang added the comment:

There is also #27121 reporting similar problem.

--
nosy: +xiang.zhang
versions:  -Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28580] Optimize iterating split table values

[Xiang Zhang]

Changes by Xiang Zhang :


Added file: http://bugs.python.org/file45330/iterate_splittable_v3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28592] Installation freezes on C Runtime Install

[Steve Dower]

Steve Dower added the comment:

This looks like a corrupted download to me - the update was aborted because 
none of the other packages were "found", which should be impossible since they 
are embedded in that executable. It may also be an antivirus program 
interfering though, as I'd expect a corrupt installer to fail earlier than this.

We definitely need to keep the update in there. If there's a superseding update 
already installed then we won't install it (or for the web installer even 
download it), and it may still be necessary for offline installs. As I said, 
it's not the issue here.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28591] imghdr doesn't recognize some jpeg formats

[Kovid Goyal]

Kovid Goyal added the comment:

FYI, the uptodate version of imghdr I maintain is here:
https://github.com/kovidgoyal/calibre/blob/master/src/calibre/utils/imghdr.py

It uses memoryview for performance and can also also read image sizes from file 
headers for jpeg, png, gif and jpeg2000. Note that is is only tested on python 
2.7

I'm afraid I dont have the time to shepherd it through your review process, but 
feel free to take code from it if you want to. It is licensed GPLv3 but I am 
willing to re-license to another license if needed, as I am the sole 
contributor.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26980] The path argument of asyncio.BaseEventLoop.create_unix_connection is not documented

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Hi, I updated the documentation explaining the path argument.

Let me know if this works. Thanks :)

--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file45329/issue26980.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19042] Idle: add option to autosave 'Untitled' edit window

[perilbrain]

perilbrain added the comment:

I have signed the CA. Meantime a came across one more problem in function 
tabnanny(encoding issue) so I am attaching the new version of ScriptBinding.py.

Summary:-

def tabnanny(self, source, encoding = None):
# XXX: tabnanny should work on binary files as well
#print(encoding)
f = io.StringIO(source.decode(encoding) if encoding else source)

def source_from_file(self, filename):
with open(filename, 'rb') as f:
source = f.read()
encoding = tokenize.detect_encoding(f.readline)[0]

return source, encoding

def _run_module_event(self, event):
...
if not filename:
self.no_save = True
source = self.source_from_editor()
filename = self.editwin.top.wm_title()
else:
source, encoding = self.source_from_file(filename)
self.no_save = False
code = self.checksyntax(source, filename)
if not code:
return 'break'
if not self.tabnanny(source, encoding):
return 'break'


--
Added file: http://bugs.python.org/file45328/ScriptBinding.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28593] Inconsistent itertools' predicate behaviour

[Francisco Couzo]

New submission from Francisco Couzo:

As per Terry's recommendation 
https://mail.python.org/pipermail/python-dev/2016-November/146791.html

Currently some functions in itertools (dropwhile and takewhile), don't accept 
None as a predicate, but filterfalse and groupby do.

I'd like your input, and I'm interested in writing a patch.

--
messages: 279960
nosy: franciscouzo, rhettinger
priority: normal
severity: normal
status: open
title: Inconsistent itertools' predicate behaviour
type: enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23693] timeit accuracy could be better

[STINNER Victor]

STINNER Victor added the comment:

I wrote a whole new project "perf" to fix root issues of this issue. It 
includes a timeit command. I suggest you to use "perf timeit" rather than 
"timeit" because perf is more reliable:
http://perf.readthedocs.io/en/latest/cli.html#timeit

--
resolution:  -> third party
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28580] Optimize iterating split table values

[INADA Naoki]

INADA Naoki added the comment:

(Off topic note)

For readability, I prefer this style:

  PyDictKeyEntry *entries = DK_ENTRIES(mp->ma_keys);
  while (i < n && entries[i].me_value == NULL)
  i++;

But because sizeof(PyDictKeyEntry) is not 2^n, entries[i].me_value, i++
may be slower than entry_ptr->me_value, i++, entry_ptr++.

So we should prefer i++, entry_ptr++ style in case of iterating dict entries.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28441] Change sys.executable to include executable suffix

[Masayuki Yamamoto]

Masayuki Yamamoto added the comment:

I have missed a case of empty progpath. I updated the patch to avoid calling 
add_exe_suffix() at that case.

--
Added file: http://bugs.python.org/file45327/sys-executable-suffix-2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28592] Installation freezes on C Runtime Install

[Eryk Sun]

Changes by Eryk Sun :


--
components: +Installation -Build

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28592] Installation freezes on C Runtime Install

[Eryk Sun]

Eryk Sun added the comment:

Supported versions of Windows Vista and later should have the CRT update [1] 
installed via Windows Update. (3.5.2 is bundled with the older KB2999226 update 
[2].) A Windows 7 system that I checked had this automatically installed last 
March. But maybe for some reason it's not getting pushed to all systems. Try 
manually installing the KB3118401 update for x64-based Windows 7.

Steve, do you think it's a good idea to continue bundling the CRT update with 
the 3.6 installer? When 3.5 was released last year the Universal CRT was new 
and IIRC not conveniently available as a recommended update in Windows Update, 
but that's no longer the case AFAIK. 

[1]: https://support.microsoft.com/en-us/kb/3118401
[2]: https://support.microsoft.com/en-us/kb/2999226

--
nosy: +eryksun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28592] Installation freezes on C Runtime Install

[Ex Tracheese]

Ex Tracheese added the comment:

Nevermind *again*, turns out the install wasn't successful despite appearances. 
When I try to actually run python it complains that there's no C Runtime dll.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28592] Installation freezes on C Runtime Install

[Ex Tracheese]

Ex Tracheese added the comment:

Nevermind, I found the problem. Windows Update shortcut got deleted from Start 
Menu. Thank god there was a stack overflow question.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28592] Installation freezes on C Runtime Install

[Ex Tracheese]

New submission from Ex Tracheese:

When trying to install Python 3.5.2 on my Windows 7 computer after getting a 
new SSD, the installer freezes on the C Runtime portion and never progresses 
past it. I have attached the log file which is full of some errors that don't 
really mean anything to me.

--
components: Build, Windows
files: Python 3.5.2 (32-bit)_20161102192326.log
messages: 279953
nosy: Ex Tracheese, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Installation freezes on C Runtime Install
type: crash
versions: Python 3.5
Added file: http://bugs.python.org/file45326/Python 3.5.2 
(32-bit)_20161102192326.log

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28591] imghdr doesn't recognize some jpeg formats

[R. David Murray]

R. David Murray added the comment:

There seem to be unrelated changes in your patches, and we'll want tests as 
well before committing.  See also issue 16512 and the issues linked from it.  
(I haven't reviewed to see if there is any overlap.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20847] asyncio docs should call out that network logging is a no-no

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


Removed file: http://bugs.python.org/file45182/issue20847.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28088] Document Transport.set_protocol and get_protocol

[Guido van Rossum]

Guido van Rossum added the comment:

LGTM too. Can someone add this to the asyncio docs (starting at the 3.5 branch 
please)?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28591] imghdr doesn't recognize some jpeg formats

[Raul]

Raul added the comment:

Working imghdr lib for python 3.X

--
Added file: http://bugs.python.org/file45325/imghdr_py3.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28591] imghdr doesn't recognize some jpeg formats

[Raul]

Raul added the comment:

Working imghdr lib for python 2.7.X

--
Added file: http://bugs.python.org/file45324/imghdr_py27.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28591] imghdr doesn't recognize some jpeg formats

[Raul]

Raul added the comment:

patch for python 3.X

--
Added file: http://bugs.python.org/file45323/imghdr35.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28591] imghdr doesn't recognize some jpeg formats

[Raul]

Changes by Raul :


Removed file: http://bugs.python.org/file45322/imghdr35.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28228] imghdr does not support pathlib

[Raul]

Changes by Raul :


Removed file: http://bugs.python.org/file45320/imghdr27.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28591] imghdr doesn't recognize some jpeg formats

[Raul]

Raul added the comment:

patch for python 3.X

--
Added file: http://bugs.python.org/file45322/imghdr35.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28591] imghdr doesn't recognize some jpeg formats

[Raul]

Raul added the comment:

patch for python 2.7

--
keywords: +patch
Added file: http://bugs.python.org/file45321/imghdr27.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28228] imghdr does not support pathlib

[Raul]

Raul added the comment:

patch for python 2.7

--
nosy: +4simple-org
Added file: http://bugs.python.org/file45320/imghdr27.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28499] Logging module documentation needs a rework.

[Pierre Bousquie]

Pierre Bousquie added the comment:

Thank you Vinay for your feedback.
RTD seems a very good start to me.

Florian thanks for joining :). I'm not leaving you alone on this!
I don't mind closing the "bug" request. It was mainly for Stéphane Wirtel
:)... but it's still "committing" :)

2016-11-02 13:47 GMT+01:00 Florian Strzelecki :

>
> Florian Strzelecki added the comment:
>
> A project published on RTD looks like a very good idea. I'll give it a try!
>
> Thanks for your feedback. I think we don't have the same opinion on how to
> organize parts and details, so it's on me to show something worth our times.
>
> > you seem to find the Django documentation problematic
>
> Yes, yet I found it to be one of the best out there too. I can enjoy
> something and still be critical about it. Even if I'm critical of the
> current logging documentation, there are plenty of good things here to
> keep, and if we want to compare, it's still far better than most
> documentation out there.
>
> --
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19948] POSIX semantics of PATH search in execvpe is not respected

[Alex Samuel]

Alex Samuel added the comment:

Here's a real-world case where this can cause unexpected results:  A shell 
script has a typo in the shebang ("#/!bin/bash") but the execute bit set.  It 
still runs via the C library's execvp() and also via bash (which uses execve() 
but reimplements the behavior) but not with Python's os.execvp().

Would there be interest in a patch that fixes this?

--
nosy: +Alex Samuel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28542] document cross compilation

[Xavier de Gaye]

Xavier de Gaye added the comment:

About 2.7, this is a list of the issues I am aware of, that may have to be 
fixed also in 2.7 (and 3.5 for some of them): issues #26884 #27434 #28444 and 
#22724. Issue #28589 was entered today and is a duplicate of the previous one.

> FWIW, DESTDIR, --prefix, etc are not specific to cross compilation or Android.

I must be seeing everything through my little Android hammer these days :)
This new patch removes the last paragraph.

--
Added file: http://bugs.python.org/file45319/readme_5.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28591] imghdr doesn't recognize some jpeg formats

[Raul]

Raul added the comment:

Other valid jpeg image not detected.

--
Added file: http://bugs.python.org/file45318/2.jpg

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28591] imghdr doesn't recognize some jpeg formats

[Raul]

New submission from Raul:

Some valid JPEG images are not detected by the imghdr lib.

--
components: Library (Lib)
files: 1.jpg
messages: 279940
nosy: 4simple-org, Claudiu.Popa, ezio.melotti, haypo, intgr, jcea, joril, 
kovid, mvignali, r.david.murray
priority: normal
severity: normal
status: open
title: imghdr doesn't recognize some jpeg formats
type: enhancement
versions: Python 2.7, Python 3.3, Python 3.4, Python 3.5, Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45317/1.jpg

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28589] get error when compile .py file during install stage if cross compile

[Xavier de Gaye]

Xavier de Gaye added the comment:

msg269617 details how this problem can also be reproduced on 3.6 by 
cross-building for Android before the issue 27917 that added platform triplets 
for Android had been fixed.

Since the changes in issue 23968 have not be retrofited to 3.5, the same 
problem must also exist on 3.5.  Closing this issue as a duplicate of issue 
22724.

--
resolution:  -> duplicate
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28580] Optimize iterating split table values

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I believe the patch doesn't makes iterating split table slower and likely makes 
it a little faster. The patch adds one additional check, but it removes other 
checks. Thus this still is an optimization.

But the last patch has an undefined behavior.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28580] Optimize iterating split table values

[INADA Naoki]

INADA Naoki added the comment:

LGTM again for iterate_splittable_v2.patch.

How about issue title (and commit message) to
"Cleanup iterating split table"?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

SilentGhost suggested to pass required=True to add_mutually_exclusive_group(). 
This makes the last "else" not needed.

Proposed patch implements this suggestion.

--
assignee:  -> serhiy.storchaka
Added file: http://bugs.python.org/file45316/zipfile-cli-required.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28580] Optimize iterating split table values

[INADA Naoki]

INADA Naoki added the comment:

> Xiang Zhang added the comment:
>
> Yes, that's the point. I thought to expose an API in testcapimodule for test, 
> but actually I am not willing to do that since I don't believe this patch 
> could bring any visible performance change.
>

I agree with you.
I feel this patch is cleanup rather than optimization.

* Removing redundant loop which always break at first
* Adding very useful assertion to find potential bugs

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28580] Optimize iterating split table values

[Xiang Zhang]

Xiang Zhang added the comment:

Yes, that's the point. I thought to expose an API in testcapimodule for test, 
but actually I am not willing to do that since I don't believe this patch could 
bring any visible performance change.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28580] Optimize iterating split table values

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

There is not easy to benchmark PyDict_Next. dict.__repr__ does much hard work 
(calling repr() for keys and values, formatting strings). Using 
_testcapi.test_dict_iteration perhaps is the easiest way to measure the 
performance of pure PyDict_Next, but it includes creating and deallocating of 
dicts.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21590] Systemtap and DTrace support

[Charalampos Stratakis]

Charalampos Stratakis added the comment:

Fedora so far has been using the systemtap patch downstream from dmalcolm [0].

So for 3.6 by removing the systemtap patch (it cannot be applied anymore 
cleanly) and by enabling the --with-dtrace configure flag I get this error [1]:

make: *** [Makefile:884: Include/pydtrace_probes.h] Error 1


If however I touch the pydtrace_probes.h file I get various undefined 
references [2] and also:

make: *** [Makefile:724: Programs/_freeze_importlib] Error 1


[0] 
http://pkgs.fedoraproject.org/cgit/rpms/python3.git/tree/00055-systemtap.patch
[1] https://kojipkgs.fedoraproject.org//work/tasks/9656/16279656/build.log
[2] https://kojipkgs.fedoraproject.org//work/tasks/9670/16279670/build.log

--
nosy: +cstratak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28580] Optimize iterating split table values

[Xiang Zhang]

Xiang Zhang added the comment:

python -> unpatched, python3 -> patched

iterkeys:

(split)

./python3 -m perf timeit --compare-to /home/angwer/cpython/python -s 'from 
argparse import Namespace; ns = Namespace(); [setattr(ns, str(i), str(i)) for i 
in range(1)]' 'list(iter(ns.__dict__))'
python: . 112 us +- 1 us
python3: . 109 us +- 1 us

Median +- std dev: [python] 112 us +- 1 us -> [python3] 109 us +- 1 us: 1.03x 
faster

(combined)

./python3 -m perf timeit --compare-to /home/angwer/cpython/python -s 'd = {x:x 
for x in range(1)}' 'list(iter(d))'python: . 84.3 us +- 
2.4 us
python3: . 86.0 us +- 3.5 us

Median +- std dev: [python] 84.3 us +- 2.4 us -> [python3] 86.0 us +- 3.5 us: 
1.02x slower

pydict_next:

(split)

./python3 -m perf timeit --compare-to /home/angwer/cpython/python -s 'from 
argparse import Namespace; ns = Namespace(); [setattr(ns, str(i), str(i)) for i 
in range(1)]' 'repr(ns.__dict__)'
python: . 1.85 ms +- 0.01 ms
python3: . 1.85 ms +- 0.11 ms

Median +- std dev: [python] 1.85 ms +- 0.01 ms -> [python3] 1.85 ms +- 0.11 ms: 
1.00x faster

(combined)

./python3 -m perf timeit --compare-to /home/angwer/cpython/python -s 'd = {x:x 
for x in range(1)}' 'repr(d)'
python: . 1.99 ms +- 0.01 ms
python3: . 1.87 ms +- 0.01 ms

Median +- std dev: [python] 1.99 ms +- 0.01 ms -> [python3] 1.87 ms +- 0.01 ms: 
1.06x faster

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28580] Optimize iterating split table values

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Could you please check how this change affects the performance?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28590] fstring's '{' from escape sequences does not start an expression

[Eric V. Smith]

Eric V. Smith added the comment:

I'm currently working on an update to PEP-498 to address this. I hope to have 
it completed after a sprint this weekend.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28580] Optimize iterating split table values

[Xiang Zhang]

Xiang Zhang added the comment:

Update the patch to use more obvious comparison way. This uses INADA's 
suggestion and make the code more like other places.

I think the performance issue is better to be discussed in #28397. It doesn't 
have a significant impact on this patch. Hope we can move forward and not block 
on it.

--
nosy: +haypo
Added file: http://bugs.python.org/file45315/iterate_splittable_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28590] fstring's '{' from escape sequences does not start an expression

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> docs@python
components: +Documentation -Interpreter Core
nosy: +docs@python

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28582] Invalid backslash syntax errors are not always accurate as to the location on the line where the error occurs

[Eric V. Smith]

Changes by Eric V. Smith :


--
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28590] fstring's '{' from escape sequences does not start an expression

[SilentGhost]

Changes by SilentGhost :


--
nosy: +eric.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28590] fstring's '{' from escape sequences does not start an expression

[尤立宇]

New submission from 尤立宇:

PEP 498 says: (https://www.python.org/dev/peps/pep-0498/#escape-sequences)

Scanning an f-string for expressions happens after escape sequences are 
decoded. Because hex(ord('{')) == 0x7b , the f-string f'\u007b4*10}' is decoded 
to f'{4*10}' , which evaluates as the integer 40:

>>> f'\u007b4*10}'
'40'

However, in python3.6.0b3, the '{' from '\u007b4' does not start an expression, 
making the remaining '}' invalid:

>>> f'\u007b4*10}'
  File "", line 1
SyntaxError: f-string: single '}' is not allowed

There's even a test case for it: (Lib/test/test_fstring.py:383)

def test_no_escapes_for_braces(self):
# \x7b is '{'.  Make sure it doesn't start an expression.
self.assertEqual(f'\x7b2}}', '{2}')
self.assertEqual(f'\x7b2', '{2')
self.assertEqual(f'\u007b2', '{2')
self.assertEqual(f'\N{LEFT CURLY BRACKET}2\N{RIGHT CURLY BRACKET}', 
'{2}')

--
components: Interpreter Core
messages: 279927
nosy: 尤立宇
priority: normal
severity: normal
status: open
title: fstring's '{' from escape sequences does not start an expression
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28589] get error when compile .py file during install stage if cross compile

[STINNER Victor]

Changes by STINNER Victor :


--
nosy: +doko, xdegaye

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28589] get error when compile .py file during install stage if cross compile

[DiazSoho]

New submission from DiazSoho:

when I try to do cross compile Python-2.7.12, it gets error when trying 
install. because the command is using compile host python to compile .py file 
with *.so files, but the *.so are built by cross platform toolchain already, 
then it will say "cannot open shared object file: No such file or directory"
the log is below:

PYTHONPATH=/home/real_users/avs_py/Python/py_install/usr/local/lib/python2.7   \
_PYTHON_PROJECT_BASE=/home/real_users/avs_py/Python/Python-2.7.12 
_PYTHON_HOST_PLATFORM=linux2-mips 
PYTHONPATH=/home/real_users/avs_py/Python/Python-2.7.12/build/lib.linux2-mips-2.7:/home/real_users/avs_py/Python/Python-2.7.12/Lib:/home/real_users/avs_py/Python/Python-2.7.12/Lib/plat-linux2
 python2.7 -Wi -tt 
/home/real_users/avs_py/Python/py_install/usr/local/lib/python2.7/compileall.py 
\
-d /home/real_users/avs_py/Python/py_install/usr/local/lib/python2.7 -f 
\
-x 'bad_coding|badsyntax|site-packages|lib2to3/tests/data' \
/home/real_users/avs_py/Python/py_install/usr/local/lib/python2.7
Traceback (most recent call last):
  File 
"/home/real_users/avs_py/Python/py_install/usr/local/lib/python2.7/compileall.py",
 line 16, in 
import struct
  File 
"/home/real_users/avs_py/Python/py_install/usr/local/lib/python2.7/struct.py", 
line 1, in 
from _struct import *
ImportError: 
/home/real_users/avs_py/Python/Python-2.7.12/build/lib.linux2-mips-2.7/_struct.so:
 cannot open shared object file: No such file or directory
make[5]: *** [libinstall] Error 1

--
components: Cross-Build
messages: 279926
nosy: Alex.Willmer, DiazSoho
priority: normal
severity: normal
status: open
title: get error when compile .py file during install stage if cross compile
type: compile error
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28587] list.index documentation missing start and stop arguments

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Hmm, I did not mean to replace the documentation example like that.
Here's another update.

--
Added file: http://bugs.python.org/file45314/issue28587.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28587] list.index documentation missing start and stop arguments

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee: docs@python -> rhettinger
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28587] list.index documentation missing start and stop arguments

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Attached is the patch to update the documentation.

Please review. Thanks :)

--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file45313/issue28587.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28575] Error 0x80070643 While installing in Win 10 32 Bit

[Steve Dower]

Changes by Steve Dower :


--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28499] Logging module documentation needs a rework.

[Florian Strzelecki]

Florian Strzelecki added the comment:

A project published on RTD looks like a very good idea. I'll give it a try!

Thanks for your feedback. I think we don't have the same opinion on how to 
organize parts and details, so it's on me to show something worth our times.

> you seem to find the Django documentation problematic

Yes, yet I found it to be one of the best out there too. I can enjoy something 
and still be critical about it. Even if I'm critical of the current logging 
documentation, there are plenty of good things here to keep, and if we want to 
compare, it's still far better than most documentation out there.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28588] Memory leak in OpenSSL thread state

[Christian Heimes]

New submission from Christian Heimes:

Quote from https://github.com/curl/curl/issues/964

---
I wrote to Matt Caswell from openssl.org about this memleah, and he answered:
OpenSSL maintains a separate error queue for each thread. On each queue there 
can be
multiple errors. ERR_get_state() does not add any errors to the queue it
merely returns the ERR_STATE (i.e. the queue) for the current thread.
If the current thread has no queue then ERR_get_state() will create one.

ERR_clear_error() removes all the errors that are on the current
thread's queue. It does not deallocate the current thread's queue.

ERR_remove_thread_state() deallocates the specified thread's queue.

The mem leaks you are seeing are almost certainly because the queues for
your app's threads have not been deallocated.
---

The memory leak only affects OpenSSL 1.0.2 and older. OpenSSL 1.1.0 takes care 
of threading, locking and thread local resources itself.

--
assignee: christian.heimes
components: Extension Modules, SSL
messages: 279922
nosy: christian.heimes
priority: normal
severity: normal
stage: test needed
status: open
title: Memory leak in OpenSSL thread state
type: resource usage
versions: Python 2.7, Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19042] Idle: add option to autosave 'Untitled' edit window

[Terry J. Reedy]

Terry J. Reedy added the comment:

Looks promising.  The second half of a patch would be to fill in the missing 
lines.

Before I review, please sign a CA.  The online form at 
https://www.python.org/psf/contrib/contrib-form/ takes about 5 minutes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28414] SSL match_hostname fails for internationalized domain names

[Christian Heimes]

Christian Heimes added the comment:

It's a big, complicated mess. I can't implement IDN support correctly because 
Python lacks UTS#46 and IDNA2008 support. I just found out that IDNA 2008 is 
not enough because it does not provide a case mapping. Lack of case mapping 
broke my fix for curl CVE-2016-8625.

At the moment IDN support is broken in a sane way: it just doesn't work and 
fails.

A partial fix will introduce security issues. 
http://unicode.org/reports/tr46/#Processing lists "www.sparkasse-gießen.de" as 
a critical example. It's the domain of a German savings and loan bank.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28580] Optimize iterating split table values

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

LGTM.

--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28513] Document zipfile CLI

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Applied both Martin's suggestion. Thank you all!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28513] Document zipfile CLI

[Roundup Robot]

Roundup Robot added the comment:

New changeset feb6e8678512 by Serhiy Storchaka in branch '2.7':
Issue #28513: Documented command-line interface of zipfile.
https://hg.python.org/cpython/rev/feb6e8678512

New changeset b51bf32defb1 by Serhiy Storchaka in branch '3.5':
Issue #28513: Documented command-line interface of zipfile.
https://hg.python.org/cpython/rev/b51bf32defb1

New changeset 843538a4094b by Serhiy Storchaka in branch '3.6':
Issue #28513: Documented command-line interface of zipfile.
https://hg.python.org/cpython/rev/843538a4094b

New changeset 0c8ffa562f3a by Serhiy Storchaka in branch 'default':
Issue #28513: Documented command-line interface of zipfile.
https://hg.python.org/cpython/rev/0c8ffa562f3a

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28580] Optimize iterating split table values

[Xiang Zhang]

Xiang Zhang added the comment:

Here is the new patch to apply the optimization to more places.

--
Added file: http://bugs.python.org/file45312/iterate_splittable.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28583] PyDict_SetDefault doesn't combine split table when needed

[INADA Naoki]

Changes by INADA Naoki :


--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28583] PyDict_SetDefault doesn't combine split table when needed

[Roundup Robot]

Roundup Robot added the comment:

New changeset 4e9c7704f373 by INADA Naoki in branch '3.6':
Issue #28583: PyDict_SetDefault didn't combine split table when needed.
https://hg.python.org/cpython/rev/4e9c7704f373

New changeset a6a79053aec4 by INADA Naoki in branch 'default':
Issue #28583: PyDict_SetDefault didn't combine split table when needed.
https://hg.python.org/cpython/rev/a6a79053aec4

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28513] Document zipfile CLI

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee: docs@python -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28583] PyDict_SetDefault doesn't combine split table when needed

[INADA Naoki]

INADA Naoki added the comment:

I'll commit.

--
assignee:  -> inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28587] list.index documentation missing start and stop arguments

[ChrisRands]

New submission from ChrisRands:

In Python 3 and 2 docs 
https://docs.python.org/3.5/tutorial/datastructures.html, list.index only 
mentions the first argument:


list.index(x)

Return the index in the list of the first item whose value is x. It is an 
error if there is no such item.

However, in reality list.index can take further arguments:

index(...)
L.index(value, [start, [stop]]) -> integer -- return first index of value.
Raises ValueError if the value is not present.

--
assignee: docs@python
components: Documentation
messages: 279913
nosy: ChrisRands, docs@python
priority: normal
severity: normal
status: open
title: list.index documentation missing start and stop arguments

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28580] Optimize iterating split table values

[Xiang Zhang]

Xiang Zhang added the comment:

> Xiang, would you update patch?

Working on it.

--
title: Optimize _PyDict_Next for split table -> Optimize iterating split table 
values

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28583] PyDict_SetDefault doesn't combine split table when needed

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Besides the patch is a little hard to understanding due to changes that are not 
directly related to the issue, it LGTM.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28580] Optimize _PyDict_Next for split table

[INADA Naoki]

INADA Naoki added the comment:

LGTM, too.

> Similar changes can be applied to other iteration code. dictiter_iternextkey, 
> dict_keys, etc.

I agree. Xiang, would you update patch?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28580] Optimize _PyDict_Next for split table

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I think this is too late for 3.6.

--
type: behavior -> enhancement
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28580] Optimize _PyDict_Next for split table

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I agree that this unlikely could cause visible effect, but this patch 
simplifies the code. LGTM.

Similar changes can be applied to other iteration code. dictiter_iternextkey, 
dict_keys, etc.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25996] Add support of file descriptor in os.scandir()

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka
dependencies: +Convert os.scandir to Argument Clinic

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28586] Convert os.scandir to Argument Clinic

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

Proposed patch converts os.scandir and DirEntry methods to Argument Clinic.

--
components: Argument Clinic, Extension Modules
files: clinic-scandir.patch
keywords: patch
messages: 279907
nosy: larry, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Convert os.scandir to Argument Clinic
type: enhancement
versions: Python 3.7
Added file: http://bugs.python.org/file45311/clinic-scandir.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28585] Restore docstring of os._isdir

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

When converted to Argument Clinic in 3.5 the docstring of os._isdir() was lost. 
Proposed patch restores it.

--
components: Argument Clinic, Extension Modules, Windows
files: os-_isdir-docstring.patch
keywords: patch
messages: 279905
nosy: larry, paul.moore, serhiy.storchaka, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
stage: patch review
status: open
title: Restore docstring of os._isdir
type: behavior
versions: Python 3.5, Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45310/os-_isdir-docstring.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28199] Compact dict resizing is doing too much work

[INADA Naoki]

INADA Naoki added the comment:

Thanks, Xiang.

Shard-key dict is very hard to maintain...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17305] IDNA2008 encoding missing

[Christian Heimes]

Christian Heimes added the comment:

I reported the issue for curl, CVE-2016-8625 
https://curl.haxx.se/docs/adv_20161102K.html

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19042] Idle: add option to autosave 'Untitled' edit window

[perilbrain]

perilbrain added the comment:

"To run without saving" was the first idea I got, but it was difficult to 
pursue in first phase. After your hints I think I have achieved what you have 
described.

I have done a few fixes(luckily in a single file ScriptBinding.py) which are 
giving satisfactory result.

I am attaching the original, modified and the diff version of files named 
ScriptBindingOriginal.py, ScriptBinding.py and ScriptBinding.diff respectively. 

Here is what I am getting with the new code
Traceback (most recent call last):
  File "*Untitled*", line 3, in 
  File "*Untitled*", line 2, in f
ZeroDivisionError: division by zero

This is the summary of the patch (idle-python3.4)

+import io


#== One member in class for reducing annoyance 
self.no_save = False

#== New definition for function tabnanny==
-def tabnanny(self, filename):
+def tabnanny(self, source):
+f = io.StringIO(source)# , os.linesep  *Maybe*
-with tokenize.open(filename) as f:

#== Added 2 functions =
def source_from_file(self, filename):
with open(filename, 'rb') as f:
source = f.read()
if b'\r' in source:
source = source.replace(b'\r\n', b'\n')
source = source.replace(b'\r', b'\n')
if source and source[-1] != ord(b'\n'):
source = source + b'\n'
return source

def source_from_editor(self):
self.editwin.io.fixlastline()
source = self.editwin.text.get("1.0", "end-1c")
return source

#== New definition for function checksyntax==
-def checksyntax(self, filename):
+def checksyntax(self, source, filename):

#== Changes in function run_module_event (Main) ==
def _run_module_event(self, event):
filename = self.getfilename()
filename = self.getfilename()
if not filename:
self.no_save = True
source = self.source_from_editor()
filename = self.editwin.top.wm_title()
else:
source = self.source_from_file(filename)
self.no_save = False
code = self.checksyntax(source, filename)
if not code:
return 'break'
if not self.tabnanny(source):
return 'break'
interp = self.shell.interp
if PyShell.use_subprocess:
interp.restart_subprocess(with_cwd=False)
if not self.no_save:
   
interp.runcode(code)
return 'break'

#== Finally suppressing the annoyance ==
if autosave and filename:
self.editwin.io.save(None)
elif self.no_save:
filename = None
else:
confirm = self.ask_save_dialog()

Please have a review and let me know if it can solve this issue.

--
nosy: +perilbrain
Added file: http://bugs.python.org/file45309/ScriptBinding.diff.zip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28583] PyDict_SetDefault doesn't combine split table when needed

[INADA Naoki]

Changes by INADA Naoki :


--
nosy: +ned.deily
priority: normal -> release blocker
stage:  -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28583] PyDict_SetDefault doesn't combine split table when needed

[INADA Naoki]

INADA Naoki added the comment:

LGTM

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28575] Error 0x80070643 While installing in Win 10 32 Bit

[Nixon]

Nixon added the comment:

Hi Steve,

 Thanks for the fast reply.
  Issue has been solved. That yesterday I was trying to install
but couldn't tried different troubleshoots like restarting,clearing temp
files, changing permission etc. But same error so I raised a issue. Now
while installing it get installed without any error.
 Anyway thanks ya.

On 1 November 2016 at 18:42, Steve Dower  wrote:

>
> Steve Dower added the comment:
>
> If you look in your TEMP directory there should be a few more log files
> alongside the one you attached. Could you post those too? You can put them
> in a zip file to make it easier if you like.
>
> --
>
> ___
> Python tracker 
> 
> ___
>

-- 

With Regards,
Nixon Varghese,

*"*Ability is of little account without opportunity.*."*

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28583] PyDict_SetDefault doesn't combine split table when needed

[Xiang Zhang]

Xiang Zhang added the comment:

Here is a patch.

--
keywords: +patch
Added file: http://bugs.python.org/file45308/PyDict_SetDefault.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com