[issue22651] Open file in a+ mode reads from end of file in Python 3.4

Changes by STINNER Victor : -- Removed message: http://bugs.python.org/msg286294 ___ Python tracker ___

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

Roundup Robot added the comment: New changeset 3275d4b584a2 by Benjamin Peterson in branch '3.6': remove comment about updating the parser module; we do not need to do that anymore (#26526) https://hg.python.org/cpython/rev/3275d4b584a2 -- ___

[issue22651] Open file in a+ mode reads from end of file in Python 3.4

Caitlin added the comment: Yeah, the workaround seemed to work for me when trying to open file on http://buywebsitetrafficreviews.org/, but this should be fixed somehow anyway. -- nosy: +caitlinwalker37 ___ Python tracker

[issue29121] sqlite3 Controlling Transactions documentation not updated

Ma Lin added the comment: After read some issues, there are two major concerns: 1, backward compatibility. 2, implicit commit is bad, tolerates bug-prone codes. However they are not contradictory if we print a warning when doing an implicit commit. Some messages like this: Warning: sqlite3

[issue29356] TypeError by typing for Ellipsis

Ádám Szieberth added the comment: Well, now I believe the way I suggested would conflict with other uses of Ellipsis in type hints. -- resolution: -> not a bug status: open -> closed ___ Python tracker

[issue29259] Add tp_fastcall to PyTypeObject: support FASTCALL calling convention for all callable objects

STINNER Victor added the comment: Oh, I had a local change not commited yet, so tp_fastcall-6.patch didn't get the [review] button. I just pushed the commit and then posted again the exact same patch. -- Added file: http://bugs.python.org/file46419/tp_fastcall-6.patch

[issue29358] Add tp_fastnew and tp_fastinit to PyTypeObject, 15-20% faster object instanciation

Roundup Robot added the comment: New changeset 8feb6a5ce4c6 by Victor Stinner in branch 'default': Issue #29358: Add postcondition checks on types https://hg.python.org/cpython/rev/8feb6a5ce4c6 -- nosy: +python-dev ___ Python tracker

[issue29259] Add tp_fastcall to PyTypeObject: support FASTCALL calling convention for all callable objects

Changes by STINNER Victor : Removed file: http://bugs.python.org/file46418/tp_fastcall-6.patch ___ Python tracker ___

[issue29259] Add tp_fastcall to PyTypeObject: support FASTCALL calling convention for all callable objects

STINNER Victor added the comment: Patch version 6: type inheritance and all wrappers should now be handled correctly. Changes: * Add fastwrapper to wrapperbase structure * Add d_use_fastwrapper to PyWrapperDescrObject structure * wrapper_call() uses fast call * Protect access to tp_fastcall

[issue29369] Use Py_IDENTIFIER in Python-ast.c

INADA Naoki added the comment: Thanks, Serhiy. You're right. -- status: open -> closed ___ Python tracker ___

[issue29270] super call in ctypes sub-class fails in 3.6

Serhiy Storchaka added the comment: See also similar issue with scrapy: https://github.com/scrapy-plugins/scrapy-djangoitem/issues/18. -- ___ Python tracker

[issue29375] httplib: wrong Host header when connecting to IPv6 link-local address

Martin Panter added the comment: More closely related: Issue 23448, about the same thing with urllib, which adds the Host value itself. Any solution should be shared between both modules. -- nosy: +martin.panter ___ Python tracker

[issue29376] threading._DummyThread.__repr__ raises AssertionError

New submission from Tom Myers: _DummyThread objects have _is_stopped = False, but _tstate_lock = None. This causes an AssertionError in is_alive and __repr__ . File ".../cp34/lib/python3.4/threading.py", line 814, in __repr__ self.is_alive() # easy way to get ._is_stopped set when

[issue29374] Doc bug: signal.sigwait and signal.sigtimedwait do not work outside the Main thread

Martin Panter added the comment: This works for me on Linux: >>> signal.pthread_sigmask(signal.SIG_BLOCK, {signal.SIGUSR1}) set() >>> import threading >>> t = threading.Thread(target=sigwait) >>> t.start() Send me a signal, my PID is 24197 >>> os.kill(os.getpid(), signal.SIGUSR1) Got the

[issue10544] yield expression inside generator expression does nothing

Glyph Lefkowitz added the comment: OK, cool. So, long term, there will be a way to do this (suspend within a generator expression). Thanks for the pointer. -- ___ Python tracker

[issue10544] yield expression inside generator expression does nothing

Glyph Lefkowitz added the comment: (As far as awaiting on int, yes, I know how await works, I was focusing on the syntax.) -- ___ Python tracker ___

[issue23448] urllib2 needs to remove scope from IPv6 address when creating Host header

Changes by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___

[issue10544] yield expression inside generator expression does nothing

Ivan Levkivskyi added the comment: Python 3.5 does not support this, you should use Python 3.6 (plus await x will fail when you will run the coroutine, since you cannot await on int). -- ___ Python tracker

[issue27500] ProactorEventLoop cannot open connection to ::1

Changes by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___

[issue25667] Supply dual-stack (IPv4/IPv6) socket bind routine

Changes by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___

[issue24209] Allow IPv6 bind in http.server

Changes by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___

[issue29375] httplib: wrong Host header when connecting to IPv6 link-local address

Changes by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___

[issue10544] yield expression inside generator expression does nothing

Glyph Lefkowitz added the comment: >>> async def foo(): ... bar = [await x for x in range(10)] File "", line 2 SyntaxError: 'await' expressions in comprehensions are not supported -- ___ Python tracker

[issue29370] "./configure --enable-optimizations && make install" does not install files in ${BINDIR} and ${LIBDIR}

Changes by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___

[issue29375] httplib: wrong Host header when connecting to IPv6 link-local address

Changes by Martin Panter : -- components: +Library (Lib) stage: -> needs patch versions: +Python 3.6, Python 3.7 ___ Python tracker

[issue29236] 'an ASCII string of one or more PEM-encoded certificates' needs to be unicode

Changes by Michael Kleehammer : -- nosy: +mkleehammer ___ Python tracker ___ ___

[issue29366] os.listdir has inconsistent behavior when run on a non-directory

Eryk Sun added the comment: Python appends "\*.*" to the path, so in the case in which the leaf element is a file, FindFirstFile naturally fails with ERROR_PATH_NOT_FOUND. Python 3.5+ could maybe switch to calling CreateFile to open a handle and GetFileInformationByHandleEx to get the

[issue29366] os.listdir has inconsistent behavior when run on a non-directory

Serhiy Storchaka added the comment: Blame Windows for this behavior. os.listdir() is just a wrapper around few system calls. It is expected that functions in the os module can raise different exceptions on different platforms. -- nosy: +serhiy.storchaka

[issue29028] Use-After-Free in PyString_FromStringAndSize() of stringobject.c

Serhiy Storchaka added the comment: Proposed patch fixes the issue. But it is hard to write a reliable patch. -- Added file: http://bugs.python.org/file46417/buffer-use-after-free-3.patch ___ Python tracker

[issue29375] httplib: wrong Host header when connecting to IPv6 link-local address

New submission from Jonathan Guthrie: This is related to issue 5111. An IPv6 link-local address must include a scope specifier as part of the address passed to the HTTPConnection or HTTPSConnection constructor, that scope specifier is not being stripped from the address passed in the HTTP 1.1

[issue29366] os.listdir has inconsistent behavior when run on a non-directory

raylu added the comment: os.listdir should always return NotADirectoryError when run on a regular file. Users shouldn't have to special-case win32/FileNotFoundError. -- ___ Python tracker

[issue10544] yield expression inside generator expression does nothing

Ivan Levkivskyi added the comment: > Is the fact that 'await' produces a syntax error in this context the same bug > or a new one? What kind of SyntaxError? await outside an async function is prohibited, bare await is also prohibited. -- ___

[issue10544] yield expression inside generator expression does nothing

Glyph Lefkowitz added the comment: Is the fact that 'await' produces a syntax error in this context the same bug or a new one? -- nosy: +glyph ___ Python tracker

[issue29372] RotatingFileHandler rotates empty logfile if it emits a large string

Vinay Sajip added the comment: I don't see the point - your proposed solution only works if the log file is completely empty at rollover time, but if the file contains a few bytes from an earlier "short" log message, it might seem just as wasteful of a backup slot as if it had zero bytes. I

[issue29358] Add tp_fastnew and tp_fastinit to PyTypeObject, 15-20% faster object instanciation

STINNER Victor added the comment: I implemented more optimizations: * type_call() uses FASTCALL * object_new() and object_init() use FASTCALL * _asyncio.Future new & init use FASTCALL As a result, create an _asyncio.Future is now 1.45x faster: haypo@smithers$ ./python -m perf timeit -s

[issue29373] subprocess.Popen os.close(p2cread) in _execute_child can cause garbage collection of self.stdout to close a reused file descriptor

Zac Medico added the comment: Actually, os.close(p2cread) closes a different file descriptor than c2pread, so my analysis is not correct. I don't know the precise cause of the EBADF error that I have observed. I suppose it could be some other code closing a file descriptor that belongs to a

[issue29374] Doc bug: signal.sigwait and signal.sigtimedwait do not work outside the Main thread

New submission from Petr MOTEJLEK: Hi, The documentation for signal.signal() clearly states that it is only supposed to be called on MainThread However, it does not say so for the signal.sigwait() and neither signal.sigtimedwait() I think this is an error on the documentation side of things

[issue29373] subprocess.Popen os.close(p2cread) in _execute_child can cause garbage collection of self.stdout to close a reused file descriptor

New submission from Zac Medico: In Popen _execute_child method, os.close(p2cread) closes a file descriptor which is referenced by self.stdout with closefd=True, created by this code: self.stdout = io.open(c2pread, 'rb', bufsize) When self.stdout is finally garbage collected, it can close a

[issue29369] Use Py_IDENTIFIER in Python-ast.c

Serhiy Storchaka added the comment: I think additional checks are not needed. PyObject_CallFunction() allows passing NULLs. -- ___ Python tracker ___

[issue13285] signal module ignores external signal changes

Thomas Kluyver added the comment: I pitched both the opaque handle and the context manager to python-ideas, but didn't get any responses, positive or negative. -- ___ Python tracker

[issue26439] ctypes.util.find_library fails when ldconfig/glibc not available (e.g., AIX)

Changes by Michael Haubenwallner : -- nosy: +haubi ___ Python tracker ___

[issue29372] RotatingFileHandler rotates empty logfile if it emits a large string

New submission from Lee Griffiths: If you write a really big string to an empty file, and that string is > maxBytes, then `RotatingFileHandler` (or even `BaseRotatingHandler`) will roll that empty file into the backup queue. I think it should instead use that empty file for the mega-string.

[issue13285] signal module ignores external signal changes

Jeroen Demeyer added the comment: Let me add that this "low-level opaque object" would be rather easy to implement on POSIX systems (I have no clue about other systems such as Windows). I could implement it, but it would be good to have some pre-approval from Python devs that it's a good idea

[issue29369] Use Py_IDENTIFIER in Python-ast.c

STINNER Victor added the comment: "We use Flask. Flask is based on Werkzeug. Werkzeug imports inspect. inspect imports ast. ast imports _ast." Oh, this was unexpected to me :-) -- ___ Python tracker

[issue29369] Use Py_IDENTIFIER in Python-ast.c

INADA Naoki added the comment: > You should check if _PyUnicode_FromId() returns NULL if it was the first call > and the UTF-8 decode failed to allocate memory. thanks. new patch will fix it. > You might initialize all these identifiers (and check for errors) in > init_types() to avoid

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

A. Skrobov added the comment: Oh btw, the comment in the beginning of Grammar/Grammar > # Note: Changing the grammar specified in this file will most likely > #require corresponding changes in the parser module > #(../Modules/parsermodule.c). is no longer true: after this

[issue29369] Use Py_IDENTIFIER in Python-ast.c

STINNER Victor added the comment: > The three identifiers are used in type. Dozen (100+) types using them. I tried once to put *all* (most common) _Py_IDENTIFIER() in a single file and share them, but I abandoned my attempt: http://bugs.python.org/issue19515#msg202385 Antoine Pitrou: "Well,

[issue29369] Use Py_IDENTIFIER in Python-ast.c

STINNER Victor added the comment: +result = PyObject_CallFunction((PyObject*)_Type, "s(O){}", +type, base, +_PyUnicode_FromId(__fields), fnames, +_PyUnicode_FromId(___module__), +_PyUnicode_FromId(__ast));

[issue29366] os.listdir has inconsistent behavior when run on a non-directory

R. David Murray added the comment: Could you please clarify what bug you are reporting? -- nosy: +r.david.murray ___ Python tracker ___

[issue29371] Typo in doctest documentation

Marco Buttu added the comment: What about this? "Symbolic names for the flags are supplied as module constants, which can be OR'ed together (flagA | flagB | ...) and passed to various functions." -- ___ Python tracker

[issue29371] Typo in doctest documentation

Marco Buttu added the comment: I think you got the meaning. I have never read it before :/ If you think the meaning is clear enough for everyone, I close the issue. -- ___ Python tracker

[issue29371] Typo in doctest documentation

Jim Fasarakis-Hilliard added the comment: >From what I understand, "or'ed" here stands for combining the options using >`|` >(https://docs.python.org/3/reference/expressions.html#binary-bitwise-operations). You can see an example of that in the source for `doctest.py`

[issue29371] Typo in doctest documentation

New submission from Marco Buttu: >From the doctest documentation [1]: "Symbolic names for the flags are supplied as module constants, which can be or'ed together and passed to various functions." Is there a typo in "...which can be or'ed together..."? Maybe "collected together"? [1]

[issue29369] Use Py_IDENTIFIER in Python-ast.c

Changes by INADA Naoki : -- resolution: -> fixed ___ Python tracker ___ ___

[issue29369] Use Py_IDENTIFIER in Python-ast.c

Roundup Robot added the comment: New changeset a507882736b2 by INADA Naoki in branch 'default': Issue #29369: Use Py_IDENTIFIER in Python-ast.c https://hg.python.org/cpython/rev/a507882736b2 -- nosy: +python-dev ___ Python tracker

[issue29333] ConfigParser calls Interpolation.before_read after reading

Changes by Gereon Kaiping : -- components: +Library (Lib) type: -> behavior versions: +Python 3.5, Python 3.6 ___ Python tracker

[issue29369] Use Py_IDENTIFIER in Python-ast.c

INADA Naoki added the comment: > AST objects are supposed to be temporary. Interning strings used in the AST > processor would make these strings immortal and so increase the memory usage, > no? > What is the purpose of the patch? Speedup or reduce the memory usage? The three identifiers are

[issue29369] Use Py_IDENTIFIER in Python-ast.c

Serhiy Storchaka added the comment: LGTM. _Py_IDENTIFIER is private API, but is not new in Python-ast.c. I expect insignificant speedup and reduce the memory usage from the patch. -- nosy: +serhiy.storchaka ___ Python tracker

[issue29368] Optimize unpickling list-like objects: use extend() instead of append()

Serhiy Storchaka added the comment: See issue17720 for a feedback from Alexandre. -- ___ Python tracker ___

[issue29369] Use Py_IDENTIFIER in Python-ast.c

STINNER Victor added the comment: > While I'm looking Python's memory usage, I found some dicts which key is not > interned "_fields", "_ast" and "__modules__". AST objects are supposed to be temporary. Interning strings used in the AST processor would make these strings immortal and so

[issue29368] Optimize unpickling list-like objects

STINNER Victor added the comment: > Every object that return listitems from the __reduce__() method must support > the extend() method according to the specification. Hum ok. I don't know well the pickle module, but according to your quote, yeah, the patch is valid.

[issue29368] Optimize unpickling list-like objects: use extend() instead of append()

Changes by STINNER Victor : -- title: Optimize unpickling list-like objects -> Optimize unpickling list-like objects: use extend() instead of append() ___ Python tracker

[issue29369] Use Py_IDENTIFIER in Python-ast.c

Changes by INADA Naoki : Removed file: http://bugs.python.org/file46414/ast-identifier2.patch ___ Python tracker ___

[issue29369] Use Py_IDENTIFIER in Python-ast.c

Changes by INADA Naoki : Added file: http://bugs.python.org/file46415/ast-identifier3.patch ___ Python tracker ___

[issue29369] Use Py_IDENTIFIER in Python-ast.c

Changes by INADA Naoki : Added file: http://bugs.python.org/file46414/ast-identifier2.patch ___ Python tracker ___

[issue29370] "./configure --enable-optimizations && make install" does not install files in ${BINDIR} and ${LIBDIR}

New submission from Дилян Палаузов: With Python 3.5.3 "./configure --enable-shared && make install DESTDIR=/tmp/ZZ1" does install files in /tmp/ZZ1/usr/local/bin/ and /tmp/ZZ1/usr/local/bin/ . "./configure --enable-optimizations --enable-shared && make install DESTDIR=/tmp/ZZ2" does not

[issue29369] Use Py_IDENTIFIER in Python-ast.c

STINNER Victor added the comment: Python/Python-ast.c started with: /* File automatically generated by Parser/asdl_c.py. */ Please fix the generator, not the generated file ;-) -- nosy: +haypo ___ Python tracker

[issue29336] merge tuples in module

INADA Naoki added the comment: As I said on ML, now I think embedding some co_* tuples into code object is better way to reduce number of tuples and memory usage. So I close this issue for now. Thanks for review and comments. -- resolution: -> postponed status: open -> pending

[issue29369] Use Py_IDENTIFIER in Python-ast.c

New submission from INADA Naoki: While I'm looking Python's memory usage, I found some dicts which key is not interned "_fields", "_ast" and "__modules__". -- components: Interpreter Core files: ast-identifier.patch keywords: patch messages: 286244 nosy: inada.naoki priority: normal

[issue29368] Optimize unpickling list-like objects

Serhiy Storchaka added the comment: collections.Sequence has no relation to the pickle protocol. Every object that return listitems from the __reduce__() method must support the extend() method according to the specification. -- ___ Python tracker

[issue29368] Optimize unpickling list-like objects

STINNER Victor added the comment: What is the cost of adding an extra isinstance(d, collections.Sequence) check? It would be closer the current design ("white list" of types), safer and avoid bad surprises. But Python has a long tradition of duck typing, so maybe isinstance() can be seen as

[issue27867] various issues due to misuse of PySlice_GetIndicesEx

Roundup Robot added the comment: New changeset d5590f357d74 by Serhiy Storchaka in branch '2.7': Issue #27867: Replaced function PySlice_GetIndicesEx() with a macro. https://hg.python.org/cpython/rev/d5590f357d74 New changeset 96f5327f7253 by Serhiy Storchaka in branch '3.5': Issue #27867:

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

Julian Berman added the comment: The change note belongs outside the seealso. I think also that wasn't exactly what Martin had in mind, I think he meant a `.. versionchanged` directive -- and given that this was originally a warning, personally I'd leave the warning but reword it, it's still

[issue29136] Add OP_NO_TLSv1_3

Cory Benfield added the comment: For those who want to keep track, the relevant OpenSSL ticket for configuring TLSv1.3 cipher suites is https://github.com/openssl/openssl/issues/2276. -- nosy: +Lukasa ___ Python tracker

[issue29083] Readd PyArg_VaParse to the stable API

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue29368] Optimize unpickling list-like objects

New submission from Serhiy Storchaka: According to PEP 307 the extend method can be used for appending list items to the object. listitemsOptional, and new in this PEP. If this is not None, it should be an iterator (not a sequence!) yielding successive

[issue17720] pickle.py's load_appends should call append() on objects other than lists

Serhiy Storchaka added the comment: Thanks. Opened issue29368 for this. -- status: open -> closed ___ Python tracker ___

[issue26149] Suggest PyCharm Community as an editor for Unix platforms

Senthil Kumaran added the comment: Thank you, Mariatta. -- nosy: +orsenthil resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue26149] Suggest PyCharm Community as an editor for Unix platforms

Roundup Robot added the comment: New changeset 25fc68e22eee by Senthil Kumaran in branch '3.6': issue26149 - Point to Wiki for Editors and Python IDEs on Unix. https://hg.python.org/cpython/rev/25fc68e22eee New changeset 0fd4a3d8e32a by Senthil Kumaran in branch 'default': [merge 3.6] -

[issue26149] Suggest PyCharm Community as an editor for Unix platforms

Roundup Robot added the comment: New changeset b43e270648a3 by Senthil Kumaran in branch '2.7': issue26149 - Point to Wiki for Editors and Python IDEs on Unix. https://hg.python.org/cpython/rev/b43e270648a3 -- nosy: +python-dev ___ Python tracker

[issue29367] python-gdb: display wrapper_call()

New submission from STINNER Victor: python-gdb.py handles various Python calls, but not descriptors. Attached patch adds code to display calls to wrapperobject objects. The patch adds the first "" line of the traceback: --- (gdb) py-bt Traceback (most recent call first): File

[issue29310] Document typing.NamedTuple default argument syntax

Ivan Levkivskyi added the comment: Thank you for the patch! I added few comments. -- stage: -> patch review ___ Python tracker ___