[issue30642] Fix leaks in idlelib

2017-06-12 Thread Louie Lu
Changes by Louie Lu : -- pull_requests: +2197 ___ Python tracker ___ ___ Python-bugs-list

[issue6519] Reorder 'with' statement for files in Python Tutorial

2017-06-12 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset 81c05ccc10d044584dff3a69ee531094ed76ee2c by Mariatta in branch '3.6': bpo-6519: Improve Python Input Output Tutorial (GH-2143) (GH-2145) https://github.com/python/cpython/commit/81c05ccc10d044584dff3a69ee531094ed76ee2c --

[issue6519] Reorder 'with' statement for files in Python Tutorial

2017-06-12 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Thanks everyone! I merged the PR and backported to 3.6 and 3.5. There are a bunch of conflicts when trying to backport to 2.7, so I decided not to bother. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions:

[issue6519] Reorder 'with' statement for files in Python Tutorial

2017-06-12 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset 5a86154a931083e6a9f9bdf9cc8b3bc33abb673d by Mariatta in branch '3.5': bpo-6519: Improve Python Input Output Tutorial (GH-2143) (GH-2146) https://github.com/python/cpython/commit/5a86154a931083e6a9f9bdf9cc8b3bc33abb673d --

[issue6519] Reorder 'with' statement for files in Python Tutorial

2017-06-12 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : -- pull_requests: +2195 ___ Python tracker ___ ___

[issue6519] Reorder 'with' statement for files in Python Tutorial

2017-06-12 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : -- pull_requests: +2196 ___ Python tracker ___ ___

[issue6519] Reorder 'with' statement for files in Python Tutorial

2017-06-12 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset bd4e9e0ca96dabf33605d9b1fd1e0562ece8ae18 by Mariatta (Andrew Kuchling) in branch 'master': bpo-6519: Improve Python Input Output Tutorial (GH-2143) https://github.com/python/cpython/commit/bd4e9e0ca96dabf33605d9b1fd1e0562ece8ae18 --

[issue30642] Fix leaks in idlelib

2017-06-12 Thread Terry J. Reedy
New submission from Terry J. Reedy: When Louie Lu posted a link to https://blog.louie.lu/2017/06/12/diagnosing-and-fixing-reference-leaks-in-cpython/ on core-mentorship list, I tested idlelib. python -m test -ugui test_idle # SUCCESS, no extraneous output python -m test -R: test_idle #

[issue30604] co_extra_freefuncs is stored thread locally and can lead to crashes

2017-06-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Avoid using double underscores in C code. C compiler uses names with double underscores for its own needs, and this can lead to conflicts. -- ___ Python tracker

[issue30604] co_extra_freefuncs is stored thread locally and can lead to crashes

2017-06-12 Thread Dino Viehland
Changes by Dino Viehland : -- pull_requests: +2194 ___ Python tracker ___ ___

[issue30628] why venv install old pip?

2017-06-12 Thread Emily Morehouse
Emily Morehouse added the comment: You're certainly right. venv uses ensurepip to install pip when creating a virtual environment and does not access the internet/upgrade any packages. ensurepip was specifically designed to use the bundled version of setuptools. The bundled version of

[issue30571] Add integer formatting code for fixed-width signed arithmetic (2's complement)

2017-06-12 Thread Lisa Roach
Lisa Roach added the comment: I can't see the drawback of being able to format two's complement easily, isn't it more common to represent negative binary numbers in two's complement form? I find the - sign a little odd myself. I agree with the idea of using "!" with the precision to represent

[issue30628] why venv install old pip?

2017-06-12 Thread Emily Morehouse
Changes by Emily Morehouse : -- nosy: +emilyemorehouse ___ Python tracker ___ ___

[issue30038] Race condition in how trip_signal writes to wakeup fd

2017-06-12 Thread Ned Deily
Ned Deily added the comment: Misc/NEWS entries for 3.6 and master for these changes? -- ___ Python tracker ___

[issue29591] Various security vulnerabilities in bundled expat (CVE-2016-0718 and CVE-2016-4472)

2017-06-12 Thread Ned Deily
Changes by Ned Deily : -- nosy: +matrixise ___ Python tracker ___ ___ Python-bugs-list

[issue29591] Various security vulnerabilities in bundled expat (CVE-2016-0718 and CVE-2016-4472)

2017-06-12 Thread Ned Deily
Ned Deily added the comment: Note that a duplicate of this issue was opened as Issue30610 and @matrixise was working on a PR there to update the embedded expat to 2.2.0. Since there are CVE's and a demo crash supplied in Issue30610, it seems to me we need to fix this for 3.6.2rc1 so I'm

[issue26656] Documentation for re.compile is a bit outdated

2017-06-12 Thread Emily Morehouse
Emily Morehouse added the comment: YAHO (yet another humble opinion), I support improving the current re.compile documentation by adding a link to the regular expression object documentation. Great way to point a user to the complete list of methods and attributes while keeping match() and

[issue30610] Python's libexpat vulnerable to CVE-2016-0718

2017-06-12 Thread Ned Deily
Ned Deily added the comment: I am closing this issue as a duplicate of the existing Issue29591. We can retitle the PR to be associated with it. And I am making Issue29591 a release blocker for 3.6.2; regardless of what we decide to for 3.7, we're not going to drop the embedded copies of

[issue30633] Python 3.6.1 installation issues on OpenSuse 42.1: ModuleNotFoundError: No module named 'encodings'

2017-06-12 Thread Andreas Jung
Andreas Jung added the comment: --enable-optimizations is not the issue Seems to be somehow related to the locales. My env is: ALSA_CONFIG_PATH=/etc/alsa-pulse.conf AUDIODRIVER=pulseaudio AUTOJUMP_ERROR_PATH=/home/ajung/.local/share/autojump/errors.log COLORTERM=1

[issue29504] blake2: compile error with -march=bdver2

2017-06-12 Thread Ned Deily
Changes by Ned Deily : -- priority: release blocker -> high ___ Python tracker ___ ___

[issue30633] Python 3.6.1 installation issues on OpenSuse 42.1: ModuleNotFoundError: No module named 'encodings'

2017-06-12 Thread Andreas Jung
Andreas Jung added the comment: Just the standard ./configure --prefix=... --enable-optimizations dance -- nosy: +ajung ___ Python tracker ___

[issue23894] lib2to3 doesn't recognize rb'...' and f'...' in Python 3.6

2017-06-12 Thread Ned Deily
Ned Deily added the comment: Misc/NEWS entries for these changes? -- ___ Python tracker ___ ___

[issue30604] co_extra_freefuncs is stored thread locally and can lead to crashes

2017-06-12 Thread Ned Deily
Ned Deily added the comment: New changeset 2997fec01ee7300c6d5940e6c55e4ccf9f56f1b5 by Ned Deily (Dino Viehland) in branch '3.6': [3.6] bpo-30604: Move co_extra_freefuncs to interpreter state to avoid crashes in threads (#2015)

[issue30636] Add PYTHONCOERCECLOCALE to the help of the command line

2017-06-12 Thread Nick Coghlan
Nick Coghlan added the comment: Thanks once again! :) -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue30636] Add PYTHONCOERCECLOCALE to the help of the command line

2017-06-12 Thread Nick Coghlan
Nick Coghlan added the comment: New changeset 81f67b6f48820beed6e138077fd785020bbfd5d6 by Nick Coghlan (Stéphane Wirtel) in branch 'master': bpo-30636: Fix the indentation for the help (#2131) https://github.com/python/cpython/commit/81f67b6f48820beed6e138077fd785020bbfd5d6 --

[issue6519] Reorder 'with' statement for files in Python Tutorial

2017-06-12 Thread A.M. Kuchling
A.M. Kuchling added the comment: PR filed against master: https://github.com/python/cpython/pull/2143 -- pull_requests: +2193 ___ Python tracker ___

[issue30641] No way to specify "File name too long" error in except statement.

2017-06-12 Thread Steven D'Aprano
Steven D'Aprano added the comment: I don't understand what you actually are requesting here. Are you requesting a way to tell whether or not the filename is too long? You've already been told that the way to do that is to check errno, and you say that you already knew that. exc.errno ==

[issue29514] Add a test case that prevents magic number changes in minor releases

2017-06-12 Thread Nick Coghlan
Nick Coghlan added the comment: We don't use the alpha and beta phases for maintenance releases, so I think the checks are functionally equivalent. For example, the 3.6 branch currently reports itself as "3.6.1 final", will temporarily report itself as "3.6.2 release" during the rc period,

[issue30633] Python 3.6.1 installation issues on OpenSuse 42.1: ModuleNotFoundError: No module named 'encodings'

2017-06-12 Thread Brett Cannon
Brett Cannon added the comment: What commands did you use to launch this build? (E.g. I noticed you are trying to do a PGO build.) -- nosy: +brett.cannon ___ Python tracker

[issue30641] No way to specify "File name too long" error in except statement.

2017-06-12 Thread Max Staff
Max Staff added the comment: ...at least those are the only two ways that I can think of. -- ___ Python tracker ___

[issue30641] No way to specify "File name too long" error in except statement.

2017-06-12 Thread Max Staff
Max Staff added the comment: Yes I know about the errno. There would be two ways to resolve this: One way would be by introducing a new exception class which would be nice because it's almost impossible to reliably check the allowed filename length (except for trial and error) and I have

[issue30641] No way to specify "File name too long" error in except statement.

2017-06-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: On Unix, you can simply check the errno value: >>> fn = "x" * 999 >>> try: open(fn, "r") ... except OSError as e: exc = e ... >>> exc.errno 36 >>> exc.errno == errno.ENAMETOOLONG True I don't know about Windows. --

[issue6519] Reorder 'with' statement for files in Python Tutorial

2017-06-12 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: @akuchling Can you prepare a PR on GitHub? -- nosy: +Mariatta ___ Python tracker ___

[issue30050] Please provide a way to disable the warning printed if the signal module's wakeup fd overflows

2017-06-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: > It would be nice if there were a way to disable this; perhaps something like: > signal.set_wakeup_fd(fd, warn_on_full_buffer=False) That's a reasonable idea. Nathaniel, would you like to submit a PR for this? -- nosy: +pitrou

[issue28994] Misc fixes and cleanups in error handling C code

2017-06-12 Thread Terry J. Reedy
Terry J. Reedy added the comment: Since I fetch, merge, and build with a .bat file that has worked fine at least 10 times, with pushes in between, the glitch is a puzzle. Next time I will just revert, as I did, or reclone and rebuild the 3.6 worktree. --

[issue28994] Misc fixes and cleanups in error handling C code

2017-06-12 Thread Zachary Ware
Zachary Ware added the comment: Agreed, looks like something went wrong in your checkout, Terry. Just confirmed that a 3.6 build on a fresh checkout on Windows is fine. -- priority: release blocker -> normal ___ Python tracker

[issue28994] Misc fixes and cleanups in error handling C code

2017-06-12 Thread Steve Dower
Steve Dower added the comment: I just updated to the latest 3.6 commit and listobject.c doesn't even use clinic in this branch. Serhiy is probably right - this is a workspace issue. -- ___ Python tracker

[issue28994] Misc fixes and cleanups in error handling C code

2017-06-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Last time Objects/listobject.c was changed 2 months ago. This looks as an error in your workspace. Maybe something wrong happened when you switched from master to 3.6. -- ___ Python tracker

[issue30217] Missing entry for the tilde (~) operator in the Index

2017-06-12 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue30217] Missing entry for the tilde (~) operator in the Index

2017-06-12 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset 37e04153d5e331162608b33639ecd3c9a5ae2432 by Mariatta (Marco Buttu) in branch '3.5': bpo-30217: add the operators ~ and | to the index (GH-1502) (GH-2138) https://github.com/python/cpython/commit/37e04153d5e331162608b33639ecd3c9a5ae2432

[issue28994] Misc fixes and cleanups in error handling C code

2017-06-12 Thread Terry J. Reedy
Terry J. Reedy added the comment: 3.6 no longer compiles for me on Windows. A repeat of pcbuild\build.bat -d gives the same error report as below. My previous build was 25 hours ago. atexitmodule.c is the only C file in the 3.6 merge update, so the backport might be to blame. Git status

[issue30217] Missing entry for the tilde (~) operator in the Index

2017-06-12 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset bbb335891c2967bd13fbe2da775c0348260d95cb by Mariatta (Marco Buttu) in branch '2.7': bpo-30217: add the operators ~ and | to the index (GH-1502) (GH-2137) https://github.com/python/cpython/commit/bbb335891c2967bd13fbe2da775c0348260d95cb

[issue30217] Missing entry for the tilde (~) operator in the Index

2017-06-12 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset f59cac4b6458e5c47e24a39ba46fb178c3766577 by Mariatta (Marco Buttu) in branch '3.6': bpo-30217: add the operators ~ and | to the index (GH-1502) (GH-2136) https://github.com/python/cpython/commit/f59cac4b6458e5c47e24a39ba46fb178c3766577

[issue30593] sqlite3 executescript does not respect isolation_level?

2017-06-12 Thread Noah Levitt
Changes by Noah Levitt : Added file: http://bugs.python.org/file46943/issue30593-test.diff ___ Python tracker ___

[issue30593] sqlite3 executescript does not respect isolation_level?

2017-06-12 Thread Noah Levitt
Noah Levitt added the comment: And here's a fix. Unfortunately I think the change could break people's scripts. If they have isolation_level set (not None) and use executescript(), they will have to issue an explicit call to connection.commit(). executescript() could do the commit itself

[issue30641] No way to specify "File name too long" error in except statement.

2017-06-12 Thread R. David Murray
R. David Murray added the comment: There appears to be an errno for file name too long, so I presume you are making a feature request for a new exception class. I believe Antoine tried to strike a balance between the utility of the sub-exceptions and their number, so you'll have to make an

[issue30593] sqlite3 executescript does not respect isolation_level?

2017-06-12 Thread Noah Levitt
Noah Levitt added the comment: Here's a test case -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue9566] Compilation warnings under x64 Windows

2017-06-12 Thread Steve Dower
Changes by Steve Dower : -- pull_requests: -2171 ___ Python tracker ___ ___

[issue30630] Missing MSI files

2017-06-12 Thread Steve Dower
Steve Dower added the comment: Try installing https://go.microsoft.com/fwlink/?LinkId=746572 separately. This should add the required files, and because it's the "official" installer will provide more details about the underlying error (if any). You may also need to reboot your machine. This

[issue30639] inspect.getfile(obj) calls object repr on failure

2017-06-12 Thread Thomas Kluyver
Thomas Kluyver added the comment: OK, I've updated the PR to do that. -- ___ Python tracker ___ ___

[issue30641] No way to specify "File name too long" error in except statement.

2017-06-12 Thread Max Staff
New submission from Max Staff: There are different ways to catch exceptions of the type "OSError": By using "except OSError as e:" and then checking the errno or by using "except FileNotFoundError e:" or "except FileExistsError e:" or whatever error one wants to catch. There's no such way for

[issue30639] inspect.getfile(obj) calls object repr on failure

2017-06-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The address of the object is not informative. The possibility of getting a source file is determined by the type of the object. -- ___ Python tracker

[issue30639] inspect.getfile(obj) calls object repr on failure

2017-06-12 Thread Thomas Kluyver
Thomas Kluyver added the comment: Sure, I can do that if you want. The other thing I thought of was using object.__repr__, so the repr always shows like . -- ___ Python tracker

[issue30639] inspect.getfile(obj) calls object repr on failure

2017-06-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think in that case it is enough to report just type name. -- nosy: +serhiy.storchaka type: behavior -> enhancement versions: +Python 3.7 ___ Python tracker

[issue30639] inspect.getfile(obj) calls object repr on failure

2017-06-12 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- keywords: +easy ___ Python tracker ___ ___

[issue30632] IDLE: add unittest to test_autocomplete

2017-06-12 Thread Terry J. Reedy
Terry J. Reedy added the comment: This issue, and in part the patch, appears to be a duplicate of #30348. What am I missing? An issue can have multiple PRs, and one can either replace another one that is closed or augment one that must be applied first. --

[issue30571] Add integer formatting code for fixed-width signed arithmetic (2's complement)

2017-06-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: The format code space is already crowded, and it isn't immediately obvious that '08B' will format the 2's complement representation of the number, as opposed to '08b' which prepends a sign bit. Not to mention that, as Raymond remarked, we cannot use the same

[issue30217] Missing entry for the tilde (~) operator in the Index

2017-06-12 Thread Marco Buttu
Changes by Marco Buttu : -- pull_requests: +2192 ___ Python tracker ___ ___

[issue30217] Missing entry for the tilde (~) operator in the Index

2017-06-12 Thread Marco Buttu
Changes by Marco Buttu : -- pull_requests: +2191 ___ Python tracker ___ ___

[issue30217] Missing entry for the tilde (~) operator in the Index

2017-06-12 Thread Marco Buttu
Changes by Marco Buttu : -- pull_requests: +2190 ___ Python tracker ___ ___

[issue22559] [2.7] Backport ssl.MemoryBIO to Python 2.7 - PEP 546

2017-06-12 Thread Christian Heimes
Christian Heimes added the comment: Sounds good to me! I'll take care of the other patch after you have committed your PR. -- ___ Python tracker ___

[issue30596] Add close() to multiprocessing.Process

2017-06-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: I've decided it's better to raise a ValueError if the child process hasn't stopped yet. After all, join() alone may have no effect: often you want to send the process a signal (a literal signal in UNIX terms, or a figurative signal such as write something on

[issue30177] pathlib.resolve(strict=False) only includes first child

2017-06-12 Thread Ned Deily
Ned Deily added the comment: New changeset a77a35d70ba8aed047e63d4d9f7d0554e98d4c4b by Ned Deily (Antoine Pietri) in branch 'master': bpo-30177: add NEWS entry (#2135) https://github.com/python/cpython/commit/a77a35d70ba8aed047e63d4d9f7d0554e98d4c4b --

[issue30177] pathlib.resolve(strict=False) only includes first child

2017-06-12 Thread Antoine Pietri
Changes by Antoine Pietri : -- pull_requests: +2189 ___ Python tracker ___ ___

[issue22559] [2.7] Backport ssl.MemoryBIO to Python 2.7 - PEP 546

2017-06-12 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: -pitrou ___ Python tracker ___ ___ Python-bugs-list

[issue30177] pathlib.resolve(strict=False) only includes first child

2017-06-12 Thread Ned Deily
Ned Deily added the comment: New changeset 8399a177de8bfa860a66e96665488c17199cb9d2 by Ned Deily (Antoine Pietri) in branch '3.6': [3.6] bpo-30177: add NEWS entry (#2134) https://github.com/python/cpython/commit/8399a177de8bfa860a66e96665488c17199cb9d2 --

[issue30177] pathlib.resolve(strict=False) only includes first child

2017-06-12 Thread Antoine Pietri
Changes by Antoine Pietri : -- pull_requests: +2188 ___ Python tracker ___ ___

[issue22559] [2.7] Backport ssl.MemoryBIO to Python 2.7 - PEP 546

2017-06-12 Thread STINNER Victor
Changes by STINNER Victor : -- title: [backport] ssl.MemoryBIO -> [2.7] Backport ssl.MemoryBIO to Python 2.7 - PEP 546 ___ Python tracker

[issue22559] [backport] ssl.MemoryBIO

2017-06-12 Thread STINNER Victor
STINNER Victor added the comment: Christian Heimes: "You have to include the changes from #29334, too." Right now, we are only allow to squash a patch serie into an unique patch. I would prefer to keep the fix of bpo-29334 as a separated commit, so merge it after MemoryBIO is merged. The

[issue22559] [backport] ssl.MemoryBIO

2017-06-12 Thread STINNER Victor
STINNER Victor added the comment: I converted issue22559.diff to a pull request. I only had one conflict! --- Lib/ssl.py +++ Lib/ssl.py @@ -727,11 +857,7 @@ class SSLSocket(socket): if not self._sslobj: raise ValueError("Read on closed or unwrapped SSL socket.")

[issue22559] [backport] ssl.MemoryBIO

2017-06-12 Thread Christian Heimes
Christian Heimes added the comment: You have to include the changes from #29334, too. -- ___ Python tracker ___

[issue29334] ssl.SSLObject method getpeercert() is buggy, do_handshake() is strange

2017-06-12 Thread Christian Heimes
Christian Heimes added the comment: Also needs backport to 2.7 for #22559 -- versions: +Python 2.7 ___ Python tracker ___

[issue22559] [backport] ssl.MemoryBIO

2017-06-12 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2187 ___ Python tracker ___ ___

[issue30639] inspect.getfile(obj) calls object repr on failure

2017-06-12 Thread Thomas Kluyver
Changes by Thomas Kluyver : -- pull_requests: +2186 ___ Python tracker ___ ___

[issue30639] inspect.getfile(obj) calls object repr on failure

2017-06-12 Thread Thomas Kluyver
Thomas Kluyver added the comment: Not exactly a bug, but I think that an improvement is possible. My plan is to delay computing the repr until the error is formatted, so that code which catches the TypeError can carry on safely. I think this is more relevant for inspect than for many other

[issue30638] Additional dependencies and rule for `make regen-all`

2017-06-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > I don't think that we want `make regen-all` to require internet access. Agree. I mentioned it only because these files also are generated. -- ___ Python tracker

[issue30640] NULL + 1 in _PyFunction_FastCallDict()

2017-06-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Yes, I mean the "k + 1" with k=NULL. Even if _PyEval_EvalCodeWithName() ignores that value, this still is an undefined behavior. For example the compiler can decide that since NULL+1 is not valid, then k never is NULL, and ignore the branch that sets k to

[issue30571] Add integer formatting code for fixed-width signed arithmetic (2's complement)

2017-06-12 Thread Stefan Krah
Stefan Krah added the comment: To expand on what Mark said: If the proposed format code implicitly gives these results ... >>> format(12 % 2**8, '08b') '1100' >>> format(-12 % 2**8, '08b') '0100' ..., would students not expect that these two operations have the same result? >>>

[issue30639] inspect.getfile(obj) calls object repr on failure

2017-06-12 Thread R. David Murray
R. David Murray added the comment: What is your proposed solution? This doesn't at the moment sound like a bug in Python to me. -- nosy: +r.david.murray ___ Python tracker

[issue29464] Specialize FASTCALL for functions with positional-only parameters

2017-06-12 Thread STINNER Victor
STINNER Victor added the comment: > Also with that, many implementors will not want to care about keyword > arguments and would thus appreciate it if they didn't have to. Forcing them > to test for keyword arguments and raising the correct error for it (with the > correct and consistent

[issue30617] IDLE: Add docstrings and unittests to outwin.py

2017-06-12 Thread Cheryl Sabella
Cheryl Sabella added the comment: Thanks! I've added more unittests. They are passing, but I'm getting a callback error that I don't understand. The same _utest flag that's on the textview dialog didn't seem to work and I was just blindly trying things without success. Also, the window is

[issue29464] Specialize FASTCALL for functions with positional-only parameters

2017-06-12 Thread Stefan Behnel
Stefan Behnel added the comment: I do not see this as a matter of performance but as a matter of usability. Basically, CPython could do just fine with just a single catch-all calling convention that packs all pos/kw arguments into C arguments and passes them over, leaving it entirely to the

[issue30640] NULL + 1 in _PyFunction_FastCallDict()

2017-06-12 Thread STINNER Victor
STINNER Victor added the comment: Can you please show me the line doing NULL+1? I don't see it. Or do you mean the "k + 1" with k=NULL? _PyEval_EvalCodeWithName() ignores kwnames and kwargs when kwcount is zero. So I don't think that the value of NULL+1 matters here :-) --

[issue30571] Add integer formatting code for fixed-width signed arithmetic (2's complement)

2017-06-12 Thread Mark Dickinson
Changes by Mark Dickinson : -- nosy: -mark.dickinson ___ Python tracker ___ ___

[issue30640] NULL + 1 in _PyFunction_FastCallDict()

2017-06-12 Thread STINNER Victor
Changes by STINNER Victor : -- title: NULL + 1 -> NULL + 1 in _PyFunction_FastCallDict() ___ Python tracker ___

[issue30638] Additional dependencies and rule for `make regen-all`

2017-06-12 Thread Zachary Ware
Zachary Ware added the comment: Agreed with all of the above, with the possible exception of 6; I don't think that we want `make regen-all` to require internet access. Please make sure that the PR for this includes removing the explicit `make clinic` from .travis.yml. -- nosy:

[issue30640] NULL + 1

2017-06-12 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: In _PyFunction_FastCallDict() if nk == 0, k is set to NULL. After that k + 1 is passed to _PyEval_EvalCodeWithName(). NULL + 1 is an undefined behavior. -- components: Interpreter Core messages: 295786 nosy: haypo, serhiy.storchaka priority: normal

[issue29464] Specialize FASTCALL for functions with positional-only parameters

2017-06-12 Thread STINNER Victor
STINNER Victor added the comment: Here are benchmark results. Sorry, but I'm not really convinced that this specialization is worth it. The change adds yet another calling convention where we already have METH_NOARG, METH_VARARGS, METH_O, METH_NOARG | METH_KEYWORDS, METH_FASTCALL... I'm ok

[issue30596] Add close() to multiprocessing.Process

2017-06-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: I want close() to be deterministic. So I guess we have two simple possibilities: 1) close() raises if the process is still alive 2) close() calls join() implicitly if the process is still alive -- ___ Python

[issue30596] Add close() to multiprocessing.Process

2017-06-12 Thread Jim Jewett
Jim Jewett added the comment: Could join be called in a background thread, or even asynchronously? That seems like mixing paradigms, but ... On Jun 12, 2017 3:15 AM, "Antoine Pitrou" wrote: > > Antoine Pitrou added the comment: > > That's a good question. close()

[issue30639] inspect.getfile(obj) calls object repr on failure

2017-06-12 Thread Thomas Kluyver
New submission from Thomas Kluyver: This came up in IPython & Jedi: several functions in inspect end up calling getfile(). If the object is something for which it can't find the source file, it throws an error, the message for which contains the object's repr. This is problematic for us

[issue30615] [EASY][2.7] test_recursive_repr() of test_xml_etree_c leaks references

2017-06-12 Thread Stéphane Wirtel
Changes by Stéphane Wirtel : -- stage: -> resolved status: open -> closed ___ Python tracker ___

[issue30638] Additional dependencies and rule for `make regen-all`

2017-06-12 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: `make regen-all` regenerates many generated files. But not all. 1. Argument Clinic files has their own make target, `make clinic`. Perhaps "clinic" should be a dependency for "regen-all". 2. Lib/token.py and Lib/symbols.py are generated from

[issue30615] [EASY][2.7] test_recursive_repr() of test_xml_etree_c leaks references

2017-06-12 Thread STINNER Victor
STINNER Victor added the comment: New changeset 41af942e57f9a450cf273ef6b72a21380c6ba8d1 by Victor Stinner (Stéphane Wirtel) in branch '2.7': bpo-30615: Fix the leak reference in Modules/_elementtree.c (#2129) https://github.com/python/cpython/commit/41af942e57f9a450cf273ef6b72a21380c6ba8d1

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-06-12 Thread Nick Coghlan
Changes by Nick Coghlan : -- pull_requests: +2184 ___ Python tracker ___ ___

[issue30589] With forkserver, Process.exitcode does not get signal number

2017-06-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: I've merged a fix for Python 3.7. Since the fix is a bit delicate, I don't want to risk regression by merging it into 3.6 and 3.5. Closing now. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.5,

[issue30589] With forkserver, Process.exitcode does not get signal number

2017-06-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: New changeset dfd5f34634f9c505945e9348b4b799544680a7cf by Antoine Pitrou in branch 'master': Fix bpo-30589: improve Process.exitcode with forkserver (#1989) https://github.com/python/cpython/commit/dfd5f34634f9c505945e9348b4b799544680a7cf --

[issue30636] Add PYTHONCOERCECLOCALE to the help of the command line

2017-06-12 Thread Stéphane Wirtel
Changes by Stéphane Wirtel : -- pull_requests: +2185 ___ Python tracker ___ ___

[issue30636] Add PYTHONCOERCECLOCALE to the help of the command line

2017-06-12 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: yep, I see that, I fix it asap -- ___ Python tracker ___ ___

[issue30636] Add PYTHONCOERCECLOCALE to the help of the command line

2017-06-12 Thread Nick Coghlan
Nick Coghlan added the comment: I just noticed that there's a line-wrapping problem in the patch as-merged. The output ends up being: PYTHONCOERCECLOCALE: if this variable is set to 0, it disables the locale coercion behavior It should either match the immediately preceding settings, which

  1   2   >