[issue31561] difflib pathological behavior with mixed line endings

Tim Peters added the comment: I'm not familiar with `icdiff` - it's not part of the Python distribution, right? If so, you should really talk to its author(s). If two files have different line endings, then no pair of lines between them can be equal, and the difference engine will struggle

[issue31564] NewType can subclass NewType

Mariatta Wijaya added the comment: Thanks Terji! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31564] NewType can subclass NewType

Mariatta Wijaya added the comment: New changeset 018e6b9f696311a65f47f33ea04b7baef3f3664f by Mariatta (Miss Islington (bot)) in branch '3.6': bpo-31564: Update typing documentation (GH-3696) (GH-3715) https://github.com/python/cpython/commit/018e6b9f696311a65f47f33ea04b7baef3f3664f

[issue25041] document AF_PACKET socket address format

Changes by Mariatta Wijaya : -- stage: patch review -> needs patch versions: +Python 3.7 -Python 3.4, Python 3.5 ___ Python tracker

[issue31564] NewType can subclass NewType

Changes by Roundup Robot : -- pull_requests: +3700 ___ Python tracker ___

[issue31564] NewType can subclass NewType

Mariatta Wijaya added the comment: New changeset 039b25d8fd21f8d5d9e3cb536402d952cf068dc1 by Mariatta (topper-123) in branch 'master': bpo-31564: Update typing documentation (GH-3696) https://github.com/python/cpython/commit/039b25d8fd21f8d5d9e3cb536402d952cf068dc1 -- nosy: +Mariatta

[issue20827] IDLE : Display function argument list in ClassBrowser

Terry J. Reedy added the comment: Miscellaneous comments: 1. ClassBrowser.main, changed in Heblikar's patch and referred to in the discussion, was the predecessor to the current browser._module_browser htest function. I have not looked at the patch in detail, but it would have to be revised

[issue25359] io.open() fails to open ascii file if LANG env not set

Serhiy Storchaka added the comment: New changeset 7e32cee1a68a489c4f2e916ac7003004b51887de by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': [3.6] bpo-25359: Add missed "goto error" after setting an exception. (GH-3712) (#3714)

[issue30152] Reduce the number of imports for argparse

Serhiy Storchaka added the comment: On my new laptop 100 runs are sped up from 2.357 sec to 2.094 sec (by 13%). Got rid of importing 6 modules: _struct, collections.abc, copy, struct, textwrap, warnings. Getting rid of importing errno leads to rewriting of os._execvpe() which looks less

[issue25359] io.open() fails to open ascii file if LANG env not set

Changes by Roundup Robot : -- pull_requests: +3699 ___ Python tracker ___

[issue25359] io.open() fails to open ascii file if LANG env not set

Serhiy Storchaka added the comment: New changeset d6238a76c655e0feb13478505220dc9049f1682f by Serhiy Storchaka in branch 'master': bpo-25359: Add missed "goto error" after setting an exception. (#3712) https://github.com/python/cpython/commit/d6238a76c655e0feb13478505220dc9049f1682f

[issue20827] IDLE : Display function argument list in ClassBrowser

Cheryl Sabella added the comment: Terry, I had an idea about this when I was working on the docstrings and the original patches. I've attached a diff for the first step of my suggested patch. I think you get the idea where I'm going with it, but I just call the same code that pyclbr uses

[issue31461] IDLE: Enhance module browser

Terry J. Reedy added the comment: Whoops, patching tree.py to not use icons is not trivial. See new comment on #25090. -- ___ Python tracker ___

[issue25090] IDLE: remove noisy icons from class (module) browser

Terry J. Reedy added the comment: I merged the nested functions and classes patch yesterday, so I really want to stop using file and folder icons for functions and classes. However, this is not as easy as I was hoping. By default, tree.TreeItem.GetIconName returns None. tree.TreeNode then

[issue30152] Reduce the number of imports for argparse

STINNER Victor added the comment: I reviewed your PR, see my questions. Would you mind to run a new benchmark again, please? -- ___ Python tracker ___

[issue31565] open() doesn't use locale.getpreferredencoding()

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue30152] Reduce the number of imports for argparse

Serhiy Storchaka added the comment: I have removed changes for which it was requested and addressed other comments. Can this PR be merged now? -- ___ Python tracker

[issue31355] Remove Travis CI macOS job: rely on buildbots

STINNER Victor added the comment: Yeah, I consider that the issue can now be closed. If someone really wants runnings checks on macOS, we should wait until Travis CI solves their issues, or find a different CI provider. https://blog.travis-ci.com/2017-09-22-macos-update --

[issue31461] IDLE: Enhance module browser

Cheryl Sabella added the comment: Sorry about that. You can do 31460 if you want. I haven't started it. -- ___ Python tracker ___

[issue31558] gc.freeze() - an API to mark objects as uncollectable

Changes by Raymond Hettinger : -- nosy: +davin, tim.peters ___ Python tracker ___

[issue31563] Change repr of dict_keys, dict_values, and dict_items to use curly braces

Serhiy Storchaka added the comment: I concur with Raymond. As for supporting the full set() API I thought about making unbound method set.union() and friends accepting arbitrary Set objects (or even arbitrary iterables), not just set objects, as a first argument. But I didn't investigate how

[issue31565] open() doesn't use locale.getpreferredencoding()

New submission from Serhiy Storchaka: It is documented that the default encoding for open() and io.TextIOWrapper() is locale.getpreferredencoding(). But actually the C implementation in Python 3 uses _bootlocale.getpreferredencoding(). Monkey-patching locale.getpreferredencoding doesn't

[issue25359] io.open() fails to open ascii file if LANG env not set

Serhiy Storchaka added the comment: There are few issues here. 1. Missed "goto error" after setting an exception in TextIOWrapper constructor. This leads to raising wrong and less informative exception (and maybe worse in Python 3, but this is harder to reproduce). 2. getpreferredencoding()

[issue31564] NewType can subclass NewType

Changes by Roundup Robot : -- keywords: +patch pull_requests: +3698 stage: -> patch review ___ Python tracker ___

[issue31461] IDLE: Enhance module browser

Terry J. Reedy added the comment: #25090 opened with a broad discussion of module broswer and code context, but I focused it on removing the folder and file icons misused for classes and functions in Module Browser. Above, I suggested possibly changing pathbrowser, but I have decided against

[issue31564] NewType can subclass NewType

New submission from Terji: It has become possible to create a ``NewType`` from an existing ``NewType``, see https://github.com/python/mypy/pull/3465 and https://github.com/python/peps/pull/271. This is a small update to the documentation as a concequence of the above change. --

[issue25359] io.open() fails to open ascii file if LANG env not set

Changes by Serhiy Storchaka : -- keywords: +patch pull_requests: +3697 stage: -> patch review ___ Python tracker ___

[issue31461] IDLE: Enhance module browser

Terry J. Reedy added the comment: I was sitting down to write a patch for #31459, when I discovered yours. If you want to write more module brower patches, such as for #31460 I will do something else. -- dependencies: +IDLE: remove noisy icons from class (module) browser

[issue31561] difflib pathological behavior with mixed line endings

Changes by Raymond Hettinger : -- nosy: +tim.peters ___ Python tracker ___ ___

[issue31563] Change repr of dict_keys, dict_values, and dict_items to use curly braces

Raymond Hettinger added the comment: Some of these were Guido's design decisions made over a decade ago. He explicitly choose not have the spelled-out method names (both here in the concrete class and in the corresponding abstract base classes). It usually isn't a good idea to second guess

[issue31460] IDLE: Revise ModuleBrowser API

Terry J. Reedy added the comment: I meant .py?, as in .py, .pyw, .pyo, not .p? -- nosy: +csabella ___ Python tracker ___

[issue31459] IDLE: Rename Class Browser as Module Browser

Changes by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31459] IDLE: Rename Class Browser as Module Browser

Terry J. Reedy added the comment: New changeset b650194652a591503f97c15f8f4c0b08c05058c5 by Terry Jan Reedy (Miss Islington (bot)) in branch '3.6': [3.6] bpo-31459: Rename IDLE's module browser from Class Browser to Module Browser. (GH-3704) (#3710)

[issue31459] IDLE: Rename Class Browser as Module Browser

Changes by Roundup Robot : -- pull_requests: +3696 ___ Python tracker ___

[issue1612262] IDLE: Include nested functions and classes in module browser

Changes by Terry J. Reedy : -- title: Class Browser doesn't show internal classes -> IDLE: Include nested functions and classes in module browser ___ Python tracker

[issue31459] IDLE: Rename Class Browser as Module Browser

Terry J. Reedy added the comment: New changeset cd99e79dc74c9d9dea83a5551d657c334b2cc6c9 by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-31459: Rename IDLE's module browser from Class Browser to Module Browser. (#3704)

[issue31563] Change repr of dict_keys, dict_values, and dict_items to use curly braces

New submission from Dan Snider: They behave like sets yet their repr looks like a list: dict_keys([0, 1, 3, 4]). It should be dict_keys({0, 1, 2, 3, 4}). Ditto for odict_keys/odict_values. Maybe this is a holdover from when the repr of sets was Set([0, 1, 2, ...])? The reason I bring this up

[issue12425] gettext breaks on empty plural-forms value

Serhiy Storchaka added the comment: Sorry, I don't see a value of issuing warning if the following line of the code is failed. Why not raise an exception instead? A warning can be issued in the case of lacking nplurals= which is not used in Python implementation. I think additional checks

[issue2504] Add gettext.pgettext() and variants support

Serhiy Storchaka added the comment: This looks like a nice feature. Éric, could you please create a PR on GitHub? I think that new l*gettext functions are not needed. They are rather useless in Python 3 (see issue29755). -- nosy: +serhiy.storchaka

[issue31559] IDLE: test_browser is failed when run twice

Changes by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31559] IDLE: test_browser is failed when run twice

Terry J. Reedy added the comment: New changeset 429b3b1188cfac654677e8aeed494bb6067c475f by Terry Jan Reedy (Miss Islington (bot)) in branch '3.6': [3.6] bpo-31559: Remove test order dependence in idle_test.test_browser. (GH-3708) (#3709)

[issue31562] snakebite.net is not available

Trent Nelson added the comment: H, I'll investigate when I get home tomorrow. Sent from my iPhone > On Sep 23, 2017, at 13:46, Serhiy Storchaka wrote: > > > New submission from Serhiy Storchaka: > > The testConnectTimeout in test_timeout is skipped since network

[issue20825] containment test for "ip_network in ip_network"

Cheryl Sabella added the comment: Hello Michel, Would you be able to convert your patch to a Github pull request? It seemed like there was interest in merging this at some point, so maybe a PR would get it moving towards that again. -- nosy: +csabella

[issue25041] document AF_PACKET socket address format

Cheryl Sabella added the comment: Hello Camilla, Would you like to create a Github pull request for your patch? -- nosy: +csabella ___ Python tracker

[issue31559] IDLE: test_browser is failed when run twice

Changes by Roundup Robot : -- pull_requests: +3695 stage: -> patch review ___ Python tracker ___

[issue31559] IDLE: test_browser is failed when run twice

Terry J. Reedy added the comment: New changeset 99167f85b7373c8082b30a74211f009627bdedfa by Terry Jan Reedy in branch 'master': bpo-31559: Remove test order dependence in idle_test.test_browser. (#3708) https://github.com/python/cpython/commit/99167f85b7373c8082b30a74211f009627bdedfa

[issue31559] IDLE: test_browser is failed when run twice

Terry J. Reedy added the comment: > I don't know why test_browser fails first time, On both buildbots, the initial rerun passes: Ran 371 tests in 12.265s OK (skipped=3) Gentoo Ran 371 tests in 12.047s OK (skipped=1) Windows8 -- stage: patch review ->

[issue31559] IDLE: test_browser is failed when run twice

Changes by Terry J. Reedy : -- keywords: +patch pull_requests: +3694 stage: -> patch review ___ Python tracker ___

[issue31559] IDLE: test_browser is failed when run twice

Terry J. Reedy added the comment: browser.transform_children, when called the first time on a dict of children nodes, rebinds the name attribute of Classes with bases*. Tests that called the real browser.transform_children the first time on a node mutate the global mock_pyclbr_tree. When the

[issue31562] snakebite.net is not available

New submission from Serhiy Storchaka: The testConnectTimeout in test_timeout is skipped since network resources it uses are not available. $ ./python -m test -vuall test_timeout ... testConnectTimeout (test.test_timeout.TCPTimeoutTestCase) ... skipped "Resource 'blackhole.snakebite.net' is

[issue31560] hashlib.blake2: error in example for signed cookies

Changes by Benjamin Peterson : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6 ___ Python tracker

[issue31560] hashlib.blake2: error in example for signed cookies

Benjamin Peterson added the comment: New changeset 5614487378863d14cdbe730b00d6803523abb7ac by Benjamin Peterson (Miss Islington (bot)) in branch '3.6': [3.6] Docs: correct hashlib.blake2 keyed hashing example (bpo-31560)

[issue31560] hashlib.blake2: error in example for signed cookies

Changes by Roundup Robot : -- keywords: +patch pull_requests: +3693 ___ Python tracker ___

[issue31560] hashlib.blake2: error in example for signed cookies

Benjamin Peterson added the comment: New changeset aecc08ac3a14a73aa353655bb65ff8d965e935a0 by Benjamin Peterson (Dmitry Chestnykh) in branch 'master': Docs: correct hashlib.blake2 keyed hashing example (bpo-31560)

[issue31560] hashlib.blake2: error in example for signed cookies

Changes by Mariatta Wijaya : -- stage: -> patch review ___ Python tracker ___

[issue31558] gc.freeze() - an API to mark objects as uncollectable

Benjamin Peterson added the comment: This is only useful if the parent process has a lot of memory that's never used by the child processes right? Otherwise, you would lose via refcounting COWs. -- nosy: +benjamin.peterson ___ Python tracker

[issue31561] difflib pathological behavior with mixed line endings

Mahmoud Al-Qudsi added the comment: Attaching file2 -- Added file: https://bugs.python.org/file47165/file2 ___ Python tracker ___

[issue31561] difflib pathological behavior with mixed line endings

New submission from Mahmoud Al-Qudsi: While using the icdiff command line interface to difflib, I ran into an interesting issue where difflib took 47 seconds to compare two simple text documents (a PHP source code file that had been refactored via phptidy). On subsequent analysis, it turned

[issue31159] Doc: Language switch can't switch on specific cases

Changes by Julien Palard : -- stage: -> resolved status: open -> closed ___ Python tracker ___

[issue31560] hashlib.blake2: error in example for signed cookies

New submission from Dmitry Chestnykh: The example for creating and verifying signed cookies with hashlib.blake2 doesn't work. Corrected in GitHub PR #3694. -- assignee: docs@python components: Documentation messages: 302787 nosy: dchest, docs@python priority: normal pull_requests: 3692

[issue31559] IDLE: test_browser is failed when run twice

New submission from Serhiy Storchaka: Buildbots failures: http://buildbot.python.org/all/builders/x86%20Gentoo%20Refleaks%203.x/builds/101/steps/test/logs/stdio http://buildbot.python.org/all/builders/AMD64%20Windows8.1%20Refleaks%203.x/builds/116/steps/test/logs/stdio I don't know why

[issue31558] gc.freeze() - an API to mark objects as uncollectable

Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list

[issue31553] Extend json.tool to handle jsonlines (with a flag)

Ezio Melotti added the comment: I agree with Raymond that this is a reasonable request. Even if jsonlines is not part of the JSON specification, the format is quite common, and practicality beats purity (espcially considering that we are just talking about json.tool). -- nosy: