[issue33397] IDLE help viewer: let users control font size

2018-04-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: PR6665 should get listed here as I changed the title to point here instead of #25198 -- ___ Python tracker

[issue25198] Idle: improve idle.html help viewer.

2018-04-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: The files uploaded 2015-09-24 and 27 were merged later the same day. The merge in between on 2015-09-25 was shorter and not uploaded separately. I opened #33396 as an index issue for the other items and any new ones. I open #33397 for

[issue33397] IDLE help viewer: let users control font size

2018-04-30 Thread Cheryl Sabella
Change by Cheryl Sabella : -- keywords: +patch pull_requests: +6364 ___ Python tracker ___

[issue33397] IDLE help viewer: let users control font size

2018-04-30 Thread Terry J. Reedy
Change by Terry J. Reedy : -- nosy: +csabella ___ Python tracker ___ ___ Python-bugs-list

[issue33396] IDLE: Improve and document help doc viewer

2018-04-30 Thread Terry J. Reedy
Change by Terry J. Reedy : -- dependencies: +IDLE help viewer: let users control font size ___ Python tracker ___

[issue33397] IDLE help viewer: let users control font size

2018-04-30 Thread Terry J. Reedy
New submission from Terry J. Reedy : Dependency of #33396. 1. Base the initial font sizes on the on the configured editor font size. Note that editor font size defaults to 10 while the current base size is 12. I did not find any explicit discussion of this in the original

[issue31908] trace module cli does not write cover files

2018-04-30 Thread miss-islington
miss-islington added the comment: New changeset a607f8b9982ac95bb59f8f61e0a50fc5ae29dc14 by Miss Islington (bot) in branch '3.6': bpo-31908: Fix output of cover files for trace module command-line tool. (GH-4205)

[issue28167] remove platform.linux_distribution()

2018-04-30 Thread Matthias Bussonnier
Change by Matthias Bussonnier : -- keywords: +patch pull_requests: +6363 stage: -> patch review ___ Python tracker ___

[issue31908] trace module cli does not write cover files

2018-04-30 Thread miss-islington
Change by miss-islington : -- pull_requests: +6362 ___ Python tracker ___

[issue28167] remove platform.linux_distribution()

2018-04-30 Thread Matthias Bussonnier
Matthias Bussonnier added the comment: In the docs it is marked as "going to be removed in 3.7", and emitting PendingDeprecationWarning. I supposed it should either be updated to change to 3.8 and switch PendingDeprecationWarning to DeprecationWarning, or be

[issue33396] IDLE: Improve and document help doc viewer

2018-04-30 Thread Terry J. Reedy
New submission from Terry J. Reedy : The IDLE help doc viewer displays help.html in a tk Text subclass. This index issue follows #25198, which fixed three immediate issues, and left the following for later. When tackled, the items below should be separate issues and PRs

[issue31908] trace module cli does not write cover files

2018-04-30 Thread miss-islington
miss-islington added the comment: New changeset e4eeb6eff12947a55df5eabee36e537cadefbbac by Miss Islington (bot) in branch '3.7': bpo-31908: Fix output of cover files for trace module command-line tool. (GH-4205)

[issue31908] trace module cli does not write cover files

2018-04-30 Thread miss-islington
Change by miss-islington : -- pull_requests: +6361 ___ Python tracker ___

[issue31908] trace module cli does not write cover files

2018-04-30 Thread miss-islington
Change by miss-islington : -- pull_requests: +6360 ___ Python tracker ___

[issue31908] trace module cli does not write cover files

2018-04-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 47ab15470d72367694d7758004067313ae022f0e by Serhiy Storchaka (Michael Selik) in branch 'master': bpo-31908: Fix output of cover files for trace module command-line tool. (GH-4205)

[issue33395] TypeError: unhashable type: 'instancemethod'

2018-04-30 Thread Siming Yuan
Siming Yuan added the comment: having a tough time trying to reproduce this issue in pure python. any clue as to how to create a __repr__ that's unhashable? class UnhashableRepr(dict): __repr__ = _testcapi.instancemethod(dict.__repr__) doesn't work because that turns

[issue33380] Update module attribute on namedtuple methods for introspection.

2018-04-30 Thread Allan Feldman
Allan Feldman added the comment: That explanation makes sense to me. Thanks for taking the time to look into this! -- resolution: -> works for me stage: -> resolved status: open -> closed ___ Python tracker

[issue33391] leak in set_symmetric_difference?

2018-04-30 Thread Raymond Hettinger
Change by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___

[issue33380] Update module attribute on namedtuple methods for introspection.

2018-04-30 Thread Raymond Hettinger
Raymond Hettinger added the comment: ISTM collections is the correct module reference because that is where the code is actually defined. A debugging tool should look there instead of in the calling code. This is the way other tools work in Python as well:

[issue32414] PyCapsule_Import fails when name is in the form 'package.module.capsule'

2018-04-30 Thread Brett Cannon
Change by Brett Cannon : -- nosy: +petr.viktorin ___ Python tracker ___ ___

[issue25198] Idle: improve idle.html help viewer.

2018-04-30 Thread Cheryl Sabella
Cheryl Sabella added the comment: I've created PR6665 for the first bullet item. * Font size should initially reflect user's size choice. Possibly change with control-mousewheel. -- nosy: +csabella stage: patch review -> needs patch

[issue25198] Idle: improve idle.html help viewer.

2018-04-30 Thread Cheryl Sabella
Change by Cheryl Sabella : -- pull_requests: +6359 stage: needs patch -> patch review ___ Python tracker ___

[issue33395] TypeError: unhashable type: 'instancemethod'

2018-04-30 Thread R. David Murray
R. David Murray added the comment: The non-hashable case should be handled by a default function, I would think. It should be fairly straightforward to come up with a reproducer that does not involve cython, which I think would be the first step. -- nosy:

[issue33006] docstring of filter function is incorrect

2018-04-30 Thread Pierre Thibault
Pierre Thibault added the comment: I guess it does since it gives false information. 2018-04-30 18:05 GMT-04:00 Anthony Flury : > > Anthony Flury added the comment: > > Strictly speaking the official

[issue33234] Improve list() pre-sizing for inputs with known lengths

2018-04-30 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: @serhiy.storchaka @rhettinger @vstinner Should we better make the pre-allocation if the length of the iterable is known (so we call PyObject_Length and not PyObject_LengthHint)? This will keep the logic simpler (so not shrinking

[issue33006] docstring of filter function is incorrect

2018-04-30 Thread Anthony Flury
Anthony Flury added the comment: Strictly speaking the official Python2 reference document isn't a great example - for instance: ' If function is None, the identity function is assumed, that is, all elements of iterable that are false are removed.' Implies

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2018-04-30 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset fb7e7992beec7f76cc2db77ab6ce1e86446bfccf by Łukasz Langa (Victor Stinner) in branch 'master': bpo-30465: Fix C downcast warning on Windows in ast.c (#6593)

[issue21822] KeyboardInterrupt during Thread.join hangs that Thread

2018-04-30 Thread Paul Goins
Paul Goins added the comment: Ahh, thanks for the explanation. I didn't think about that. Let's *not* do that then. :) I'll see if I can squeeze in some time to play with the alternatives. -- ___ Python tracker

[issue21822] KeyboardInterrupt during Thread.join hangs that Thread

2018-04-30 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I'm guessing this is because of the perceived performance impact? The problem is polling is pretty detrimental to power saving on modern CPUs. There might also be a performance impact that makes things worse :-) More generally, we really

[issue21822] KeyboardInterrupt during Thread.join hangs that Thread

2018-04-30 Thread Paul Goins
Paul Goins added the comment: > I think adding polling to such a widely-used primitive is out of question. I'm guessing this is because of the perceived performance impact? (That's the main thought I have against polling in this case.) Or is it something else? I can

[issue21822] KeyboardInterrupt during Thread.join hangs that Thread

2018-04-30 Thread Antoine Pitrou
Antoine Pitrou added the comment: > One way to possibly make this work (although perhaps not as clean as may be > desired) would be to add polling logic into the thread_nt.h version of > PyThread_acquire_lock_timed. I think adding polling to such a widely-used primitive is

[issue21822] KeyboardInterrupt during Thread.join hangs that Thread

2018-04-30 Thread Paul Goins
Paul Goins added the comment: Focusing on the Windows case specifically... One way to possibly make this work (although perhaps not as clean as may be desired) would be to add polling logic into the thread_nt.h version of PyThread_acquire_lock_timed. That would have

[issue32797] Tracebacks from Cython modules no longer work

2018-04-30 Thread Paul Moore
Paul Moore added the comment: >> IMO, debating whether a None return means there's absolutely no chance of >> there being source is silly - the best the loader can say is that it can't >> provide source. > > I don't think it is silly: if "None" means that the loader cannot

[issue33395] TypeError: unhashable type: 'instancemethod'

2018-04-30 Thread Siming Yuan
New submission from Siming Yuan : in Python 3.5 it the pprint.PrettyPrinter mechanism got an overhaul, relying on PrettyPrinter._dispatch dict-lookup based on obj.__repr__ type. This breaks any Cythonized 3rd party libraries that used to be pretty-printable in Python3.4.

[issue33352] [EASY] Windows: test_regrtest fails on installed Python

2018-04-30 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> fixed ___ Python tracker ___ ___

[issue33352] [EASY] Windows: test_regrtest fails on installed Python

2018-04-30 Thread STINNER Victor
STINNER Victor added the comment: I'm not sure that Python 3.6. In case of doubt, I prefer to skip it. The bug has been fixed in Python 3.7 and master. Thanks Andrés Delfino for your nice contribution! -- stage: patch review -> resolved status: open -> closed

[issue33352] [EASY] Windows: test_regrtest fails on installed Python

2018-04-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset 8075868f19967f291f123f17962a453b38dec8d2 by Victor Stinner (Miss Islington (bot)) in branch '3.7': bpo-33352: Skip test_regrtest test if rt.bat does not exist (GH-6654) (#6656)

[issue33254] Have importlib.resources.contents() return an interable instead of an iterator

2018-04-30 Thread Brett Cannon
Change by Brett Cannon : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33254] Have importlib.resources.contents() return an interable instead of an iterator

2018-04-30 Thread miss-islington
miss-islington added the comment: New changeset 2e5fa38c5aaf7630c55ce6dfb8f79df6b3b86076 by Miss Islington (bot) in branch '3.7': bpo-33254: do not return an empty list when asking for the contents of a namespace package (GH-6467)

[issue33370] Addition of mypy cache to gitignore

2018-04-30 Thread Brett Cannon
Change by Brett Cannon : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33375] warnings: get filename from frame.f_code.co_filename

2018-04-30 Thread Brett Cannon
Change by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___

[issue32797] Tracebacks from Cython modules no longer work

2018-04-30 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: > IMO, debating whether a None return means there's absolutely no chance of > there being source is silly - the best the loader can say is that it can't > provide source. I don't think it is silly: if "None" means that the loader cannot

[issue33254] Have importlib.resources.contents() return an interable instead of an iterator

2018-04-30 Thread miss-islington
Change by miss-islington : -- pull_requests: +6358 ___ Python tracker ___

[issue33254] Have importlib.resources.contents() return an interable instead of an iterator

2018-04-30 Thread Brett Cannon
Brett Cannon added the comment: New changeset 3ab9365dca8438f89b2060cd3eebe00606133dc4 by Brett Cannon in branch 'master': bpo-33254: do not return an empty list when asking for the contents of a namespace package (GH-6467)

[issue33393] update config.guess and config.sub

2018-04-30 Thread miss-islington
Change by miss-islington : -- pull_requests: +6357 ___ Python tracker ___

[issue33393] update config.guess and config.sub

2018-04-30 Thread Matthias Klose
Matthias Klose added the comment: New changeset 7e3545c70cdecd86ffa8fcbffd79b4f78560679f by Matthias Klose in branch 'master': bpo-33393: Update config.guess and config.sub files (#6658) https://github.com/python/cpython/commit/7e3545c70cdecd86ffa8fcbffd79b4f78560679f

[issue33377] add new triplets for mips r6 and riscv variants

2018-04-30 Thread miss-islington
Change by miss-islington : -- pull_requests: +6356 ___ Python tracker ___

[issue32797] Tracebacks from Cython modules no longer work

2018-04-30 Thread Paul Moore
Paul Moore added the comment: As I noted on python-ideas, continuing to search along sys.path if the loader returns None seems to match what the linecache docs say. If the issue had been phrased as "the implementation of linecache doesn't follow the docs" then I'd say

[issue33394] the build of the shared modules is quiet/non-visible when GNU make gets passed macros

2018-04-30 Thread Matthias Klose
Change by Matthias Klose : -- pull_requests: +6355 stage: -> patch review ___ Python tracker ___

[issue33394] the build of the shared modules is quiet/non-visible when GNU make gets passed macros

2018-04-30 Thread Matthias Klose
New submission from Matthias Klose : the build of the shared modules is quiet/non-visible when GNU make gets passed macros. This is was introduced by the change to support BSD make. GNU make adds all make macros passed on the command line to MAKEFLAGS. If one of these macros

[issue33393] update config.guess and config.sub

2018-04-30 Thread Matthias Klose
Change by Matthias Klose : -- keywords: +patch pull_requests: +6354 stage: -> patch review ___ Python tracker ___

[issue33377] add new triplets for mips r6 and riscv variants

2018-04-30 Thread Matthias Klose
Matthias Klose added the comment: New changeset ddbe976964933cb943c6383a776e800cc7e0f47d by Matthias Klose in branch 'master': bpo-33377: add triplets for mips-r6 and riscv (#6655) https://github.com/python/cpython/commit/ddbe976964933cb943c6383a776e800cc7e0f47d --

[issue33393] update config.guess and config.sub

2018-04-30 Thread Matthias Klose
New submission from Matthias Klose : update config.guess and config.sub from http://git.savannah.gnu.org/ -- assignee: doko components: Build messages: 315954 nosy: doko priority: normal severity: normal status: open title: update config.guess and config.sub versions:

[issue32769] Add 'annotations' to the glossary

2018-04-30 Thread Andrés Delfino
Andrés Delfino added the comment: I just made a PR to start working on the right wording. -- nosy: +adelfino ___ Python tracker ___

[issue32769] Add 'annotations' to the glossary

2018-04-30 Thread Andrés Delfino
Change by Andrés Delfino : -- keywords: +patch pull_requests: +6353 stage: needs patch -> patch review ___ Python tracker ___

[issue33352] [EASY] Windows: test_regrtest fails on installed Python

2018-04-30 Thread miss-islington
Change by miss-islington : -- pull_requests: +6352 ___ Python tracker ___

[issue33352] [EASY] Windows: test_regrtest fails on installed Python

2018-04-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset c3b7a6dfb9c7e69093c9fe78ab587e14743e5152 by Victor Stinner (Andrés Delfino) in branch 'master': bpo-33352: Skip test_regrtest test if rt.bat does not exist (GH-6654)

[issue33377] add new triplets for mips r6 and riscv variants

2018-04-30 Thread Matthias Klose
Change by Matthias Klose : -- pull_requests: +6351 stage: -> patch review ___ Python tracker ___

[issue33352] [EASY] Windows: test_regrtest fails on installed Python

2018-04-30 Thread Andrés Delfino
Change by Andrés Delfino : -- keywords: +patch pull_requests: +6350 stage: needs patch -> patch review ___ Python tracker ___

[issue32797] Tracebacks from Cython modules no longer work

2018-04-30 Thread Jeroen Demeyer
Change by Jeroen Demeyer : -- keywords: +patch pull_requests: +6349 stage: -> patch review ___ Python tracker ___

[issue31802] 'import posixpath' fails if 'os.path' has not be imported already.

2018-04-30 Thread Mark Shannon
Change by Mark Shannon : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33391] leak in set_symmetric_difference?

2018-04-30 Thread STINNER Victor
STINNER Victor added the comment: I don't think that an unit test is needed, and I failed to write such test :-) -- nosy: +vstinner ___ Python tracker

[issue33392] pathlib .glob('*/') returns files as well as directories

2018-04-30 Thread robbuckley
robbuckley added the comment: this is workaroundable via constructions like: list(x for x in p.glob('*/') if x.is_dir()) but I think there's value in behaving like glob.glob(), and keystroke avoidance for what must be a fairly common use case --

[issue33392] pathlib .glob('*/') returns files as well as directories

2018-04-30 Thread robbuckley
New submission from robbuckley : Path.cwd().glob('/*') seems to yield all files and folders in cwd, the same as .glob('*'). I believe that glob('*/') should yield only directories, and glob('*') all files and directories. this behaviour isnt documented one way or the

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-04-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 6405feecda6a5d5dd7a4240eb3054a2676ed29b1 by Serhiy Storchaka in branch 'master': bpo-33012: Fix invalid function casts for long_long. (GH-6652)

[issue33391] leak in set_symmetric_difference?

2018-04-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Good catch! Do you mind to create a pull request on GitHub? -- nosy: +rhettinger, serhiy.storchaka type: -> behavior ___ Python tracker

[issue27645] Supporting native backup facility of SQLite

2018-04-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset ca405017d5e776a2e3d9291236e62d2e09489dd2 by Victor Stinner in branch 'master': bpo-27645, sqlite: Fix integer overflow on sleep (#6594) https://github.com/python/cpython/commit/ca405017d5e776a2e3d9291236e62d2e09489dd2

[issue33391] leak in set_symmetric_difference?

2018-04-30 Thread lekma
New submission from lekma : shouldn't otherset be decrefed before returning on error in set_symmetric_difference? if not, what am I missing? -- components: Interpreter Core files: setobject.c.diff keywords: patch messages: 315945 nosy: lekma priority: normal

[issue32414] PyCapsule_Import fails when name is in the form 'package.module.capsule'

2018-04-30 Thread lekma
lekma added the comment: thinking out loud here: maybe both behavior can be exposed, i.e. a PyCapsule_Import that would expect a valid import statement and a Py_GetCapsule that would behave more like getattr? -- ___ Python

[issue33385] setdefault() with a single argument doesn't work for dbm.gnu and dmb.dumb objects

2018-04-30 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- title: setdefault() with a single argument doesn't work for dbm.gdbm and dmb.ndbm objects -> setdefault() with a single argument doesn't work for dbm.gnu and dmb.dumb objects ___ Python

[issue33385] setdefault() with a single argument doesn't work for dbm.gdbm and dmb.ndbm objects

2018-04-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Actually dbm.ndbm already implements option 1. Only dbm.gnu and dbm.dumb have non-working with a single argument setdefault(). -- ___ Python tracker

[issue33352] [EASY] Windows: test_regrtest fails on installed Python

2018-04-30 Thread STINNER Victor
STINNER Victor added the comment: The fix is simple, skip the test if the script doesn't exist at: def test_pcbuild_rt(self): # PCbuild\rt.bat script = os.path.join(ROOT_DIR, r'PCbuild\rt.bat') -- keywords: +easy title: Windows: test_regrtest

[issue33234] Improve list() pre-sizing for inputs with known lengths

2018-04-30 Thread STINNER Victor
STINNER Victor added the comment: Should we shrink the list of the length hint was way too big? For example, if the length hint was 100 but the final list of only 10. Should we shrink in that case? I'm asking because it seems like Pablo's PR doesn't shrink the list in

[issue33234] Improve list() pre-sizing for inputs with known lengths

2018-04-30 Thread STINNER Victor
STINNER Victor added the comment: See also http://bugs.python.org/issue26814#msg264003 and bpo-26828. -- nosy: +vstinner ___ Python tracker

[issue33256] module is not displayed by cgitb.html

2018-04-30 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 2.7, Python 3.6, Python 3.7, Python 3.8 ___ Python tracker

[issue33256] module is not displayed by cgitb.html

2018-04-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 07ad02f62cc336772e12e3fd837579952b03ca57 by Serhiy Storchaka in branch '2.7': [2.7] bpo-33256: Replace angle brackets around python object repr to display it in html (GH-6442). (GH-6650)

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-04-30 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +6348 ___ Python tracker ___ ___

[issue33217] x in enum.Flag member is True when x is not a Flag

2018-04-30 Thread Rahul Jha
Change by Rahul Jha : -- pull_requests: +6347 stage: needs patch -> patch review ___ Python tracker ___

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-04-30 Thread Siddhesh Poyarekar
Siddhesh Poyarekar added the comment: Yeah, there are multiple such uses that need wrappers to actually fix for gcc8, which will be released this week. I think I'll have more time for some more patches in this vein this weekend. --

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-04-30 Thread STINNER Victor
STINNER Victor added the comment: The commit 55edd0c185ad2d895b5d73e47d67049bc156b654 introduced a new warning: gcc -pthread -c -Wno-unused-result -Wsign-compare -g -Og -Wall -Wstrict-prototypes -O0 -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter

[issue21474] Idle: updata fixwordbreaks() for unicode identifiers

2018-04-30 Thread miss-islington
miss-islington added the comment: New changeset 3d11630ff401cfcdf094cf039cb575332ecaea20 by Miss Islington (bot) in branch '3.6': bpo-21474: Update IDLE word/identifier definition from ascii to unicode. (GH-6643)

[issue21474] Idle: updata fixwordbreaks() for unicode identifiers

2018-04-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: Thank you for the help. My immediate goal for IDLE is to fix unicode problems, to the extent allowed by tk, before 3.7.0. -- keywords: -patch nosy: -miss-islington resolution: -> fixed stage: patch review -> resolved status: open

[issue33390] matmul @ operator precedence

2018-04-30 Thread Mark Dickinson
Mark Dickinson added the comment: Gah! Forgot that my post would reset this issue to open. I'm going to close here, since this would be a sufficiently big and unlikely change that it's not going to happen without a python-ideas/python-dev discussion. --

[issue33390] matmul @ operator precedence

2018-04-30 Thread Mark Dickinson
Mark Dickinson added the comment: [Steven] > please take the idea to the numpy and/or Python-Ideas mailing lists for > further discussion: But please do read through the previous discussions before starting a new one! See the links in PEP 465, and particularly

[issue33256] module is not displayed by cgitb.html

2018-04-30 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +6346 ___ Python tracker ___ ___

[issue21474] Idle: updata fixwordbreaks() for unicode identifiers

2018-04-30 Thread miss-islington
miss-islington added the comment: New changeset 887b5f8fc622267e1fd48862ea9d0dfd4a0abdc6 by Miss Islington (bot) in branch '3.7': bpo-21474: Update IDLE word/identifier definition from ascii to unicode. (GH-6643)

[issue33385] setdefault() with a single argument doesn't work for dbm.gdbm and dmb.ndbm objects

2018-04-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Raymond. I hesitated to make a choose. Ned, is it good to add a deprecation warning in setdefault() methods of the dbm classes when they called with a single argument in 3.7? Their current behavior (no-op or error) is

[issue21474] Idle: updata fixwordbreaks() for unicode identifiers

2018-04-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Do we still need this line in fixwordbreaks? Yes. Loading word.tcl sets tcl_wordchars and tcl_nonwordchars. We should ensure that word.tcl is loaded and these variables are set before we change them. --

[issue21474] Idle: updata fixwordbreaks() for unicode identifiers

2018-04-30 Thread miss-islington
Change by miss-islington : -- pull_requests: +6345 ___ Python tracker ___

[issue21474] Idle: updata fixwordbreaks() for unicode identifiers

2018-04-30 Thread miss-islington
Change by miss-islington : -- keywords: +patch pull_requests: +6344 stage: commit review -> patch review ___ Python tracker

[issue21474] Idle: updata fixwordbreaks() for unicode identifiers

2018-04-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 5ff3a161c8a6b525c5e5b3e36e9c43f5a95bda60 by Terry Jan Reedy in branch 'master': bpo-21474: Update IDLE word/identifier definition from ascii to unicode. (GH-6643)

[issue21474] Idle: updata fixwordbreaks() for unicode identifiers

2018-04-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: Now-closed duplicate #33386 reported that μ, 0x3bc, is not selected as part of identifiers when double clicking. This prompted some research. The 'Windows' style imitates the behavior of Command Prompt, which I presume is a carryover from

[issue33380] Update module attribute on namedtuple methods for introspection.

2018-04-30 Thread pmpp
pmpp added the comment: I see that as a good fix, obviously Point definition belongs to __main__ in the sample, like would any other subclass defined there eg if "some" class is defined in awe.py module : >>> import awe >>> class my(awe.some):pass ... >>> my.__module__

[issue33380] Update module attribute on namedtuple methods for introspection.

2018-04-30 Thread Raymond Hettinger
Raymond Hettinger added the comment: Am not sure I can see any value in pushing the __module__ attribute down into the methods and think it is reasonable for them to report their origin as being in the collections module. --

[issue33385] setdefault() with a single argument doesn't work for dbm.gdbm and dmb.ndbm objects

2018-04-30 Thread Raymond Hettinger
Raymond Hettinger added the comment: Option 2 seems perfectly reasonable here as a way of preventing bugs (working, correct code wouldn't be using the existing default of None). Option 1 is problematic because of the variance from Mutable Mapping, because