[issue33453] from __future__ import annotations breaks dataclasses ClassVar and InitVar handling

2018-05-11 Thread Eric V. Smith
Eric V. Smith added the comment: At this stage in the release cycle, if you really feel strongly about this, you should take it up with Guido directly. -- assignee: -> eric.smith ___ Python tracker

[issue33257] Race conditions in Tkinter with non-threaded Tcl

2018-05-11 Thread Ivan Pozdeev
Ivan Pozdeev added the comment: The 1st PR is ready. I'll continue working on the 2nd one in this ticket, too, if there are no objections. -- ___ Python tracker

[issue33453] from __future__ import annotations breaks dataclasses ClassVar and InitVar handling

2018-05-11 Thread Eric V. Smith
Change by Eric V. Smith : -- keywords: +patch, patch pull_requests: +6455, 6456 stage: -> patch review ___ Python tracker ___

[issue33453] from __future__ import annotations breaks dataclasses ClassVar and InitVar handling

2018-05-11 Thread Eric V. Smith
Change by Eric V. Smith : -- keywords: +patch pull_requests: +6456 stage: -> patch review ___ Python tracker ___

[issue33453] from __future__ import annotations breaks dataclasses ClassVar and InitVar handling

2018-05-11 Thread INADA Naoki
INADA Naoki added the comment: > > I think we've learned lesson that we shouldn't use typing in modules other than typing... > This is a blanket statement that as hurtful as it is factually incorrect. Let me address the latter. > 1. Dataclasses are entirely dependent

[issue33468] Add try-finally contextlib.contextmanager example

2018-05-11 Thread Nick Coghlan
New submission from Nick Coghlan : The current example for contextlib.contextmanager doesn't use try/finally, which sets folks up for writing resource management context managers that don't clean up after exceptions properly. There's an example with try/finally down in the

[issue33015] Fix function cast warning in thread_pthread.h

2018-05-11 Thread Steve Dower
Steve Dower added the comment: In this case, we know the behaviour is okay and the warning is wrong. We should suppress the warning around the offending line, rather than adding significant code that may introduce genuine bugs. --

[issue33464] AIX and "specialized downloads" links

2018-05-11 Thread Michael Felt
Michael Felt added the comment: P.s. i apologize for probably posting in the incorrect “issues” area. Having followed guido’s link i see an area that is new for me. If it is better that i “restart” the discussion there, just ask. -- nosy: +aixto...@gmail.com

[issue33459] Define "tuple display" in the docs

2018-05-11 Thread R. David Murray
R. David Murray added the comment: Hmm. OK, I didn't think that's how we'd defined those terms, but then I don't actually work with the parser much myself :) However, generator expressions are clearly called out as a separate thing. All of the other display types get

[issue33453] from __future__ import annotations breaks dataclasses ClassVar and InitVar handling

2018-05-11 Thread Rick Teachey
Rick Teachey added the comment: Lending my voice to the suggestion of limiting the class attribute check to `typing.ClassVar` and `ClassVar`. It can always be expanded later if it is needed. -- ___ Python tracker

[issue33453] from __future__ import annotations breaks dataclasses ClassVar and InitVar handling

2018-05-11 Thread Łukasz Langa
Łukasz Langa added the comment: > I think we've learned lesson that we shouldn't use typing in modules other > than typing... This is a blanket statement that as hurtful as it is factually incorrect. Let me address the latter. 1. Dataclasses are entirely dependent on

[issue33459] Define "tuple display" in the docs

2018-05-11 Thread Andrés Delfino
Andrés Delfino added the comment: The documentation says a display may or may not have a comprehension :/ [1, 2, 3] is a list display too. [x for x in range(3)] is a display that has a comprehension. Acoording to the doc. --

[issue33459] Define "tuple display" in the docs

2018-05-11 Thread R. David Murray
R. David Murray added the comment: That's a generator expression, just like [x for x in ramge(3)] is a list comprehension, not a list display. And yes, in a number of circumstances parenthesis are required to delimit the tuple display and disambiguate the syntax.

[issue33467] Python 3.7: profile-opt build errors because a test seems to hang

2018-05-11 Thread Rahul Ravindran
New submission from Rahul Ravindran : make run_profile_task runs the tests and does not seem to have any mechanism to exclude tests that I could find based on looking at the Makefile. Previously, on Python 3.6, this test test_poplib was

[issue33459] Define "tuple display" in the docs

2018-05-11 Thread Andrés Delfino
Andrés Delfino added the comment: Ignore the previous comment. The thing is that "tuple displays" like: nums = (n for n in range(10)) Yield a generator expression instead of a tuple. Also, unparenthesized "tuple displays" like 1, 2, 3 can't be used in expressions,

[issue33459] Define "tuple display" in the docs

2018-05-11 Thread Andrés Delfino
Andrés Delfino added the comment: The thing is that "tuple displays" like: nums = (n for n in range(10)) Yield a generator expression instead of a tuple. Also, unparenthesized "tuple displays" like 1, 2, 3 can't be used in expressions, AFAIK: >>> if 3 == 1, 2, 3:

[issue33466] Distutils does not support the compilation of Objective-C++ (“.mm”) files

2018-05-11 Thread Alexander Böhn
Change by Alexander Böhn : -- keywords: +patch pull_requests: +6453 stage: -> patch review ___ Python tracker ___

[issue33466] Distutils does not support the compilation of Objective-C++ (“.mm”) files

2018-05-11 Thread Alexander Böhn
New submission from Alexander Böhn : Attempting to compile an Objective-C++ source file suffixed “.mm” results in an error complaining about the file extension being unrecognized. -- components: Distutils messages: 316405 nosy: dstufft, eric.araujo, fish2000

[issue33346] Syntax error with async generator inside dictionary comprehension

2018-05-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There are several related PEPs: PEP 492 -- Coroutines with async and await syntax PEP 525 -- Asynchronous Generators PEP 530 -- Asynchronous Comprehensions I haven't found anything explicit about this case. PEP 492 says that

[issue33465] test_from_import_missing_attr_has_name_and_so_path fails when select is a builtin instead of an extension

2018-05-11 Thread Barry A. Warsaw
Change by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list

[issue33465] test_from_import_missing_attr_has_name_and_so_path fails when select is a builtin instead of an extension

2018-05-11 Thread Matthias Klose
New submission from Matthias Klose : == ERROR: test_from_import_missing_attr_has_name_and_so_path (test.test_import.ImportTests) -- Traceback

[issue33464] AIX and "specialized downloads" links

2018-05-11 Thread Michael Felt
Michael Felt added the comment: FYI: as my primary effort for AIX concerned ctypes.find_library() - and that is now in the Python3-3.7 branch - when I do a PR it will only be for "current" efforts, i.e., Python3-3.7 and later. As much as I feel it is important I'll

[issue25109] test_code_module tests fail when run from the installed location

2018-05-11 Thread Matthias Klose
Matthias Klose added the comment: this seems to be fixed in 3.6 (3.6.5) and 3.7 (beta4). -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue30850] [2.7] bsddb3: test01_basic_replication() of test_bsddb3 fails randomly on AMD64 Windows8.1 Refleaks 2.7

2018-05-11 Thread STINNER Victor
STINNER Victor added the comment: Oh no, I saw it again! http://buildbot.python.org/all/#/builders/51/builds/119/steps/3/logs/stdio running: test_bsddb3 (1569 sec) running: test_bsddb3 (1599 sec) 1:02:05 [403/403/1] test_bsddb3 crashed (...) 1 test failed: test_bsddb3

[issue33464] AIX and "specialized downloads" links

2018-05-11 Thread Guido van Rossum
Guido van Rossum added the comment: Given that we don't feel it is worth the effort to support AIX in the CPython source explicitly, I think it's right that we at least link to Michael's efforts in the "other downloads" page. I don't actually know if this should go to the

[issue33346] Syntax error with async generator inside dictionary comprehension

2018-05-11 Thread Guido van Rossum
Guido van Rossum added the comment: @Ivan: Please stop bringing up that we should drop the implicit scope for comprehensions. I know you feel this way, but it's not going to happen. @Serhiy: What does the PEP for async/await say? (Or is there a separate PEP for allowing

[issue33463] Can namedtuple._asdict return a regular dict instead of OrderedDict?

2018-05-11 Thread Raymond Hettinger
Raymond Hettinger added the comment: This would have to go through a deprecation cycle, but it would be a nice improvement (faster, cleaner, and consistent with data classes). -- assignee: rhettinger -> components: +Library (Lib)

[issue33453] from __future__ import annotations breaks dataclasses ClassVar and InitVar handling

2018-05-11 Thread INADA Naoki
INADA Naoki added the comment: > We can't break the API at this point in the release cycle. We hadn't release RC, and we hadn't documented dataclass module yet. How about making "dataclass" module as porvisional state? I think we've learned lesson that we shouldn't use

[issue33464] AIX and "specialized downloads" links

2018-05-11 Thread Michael Felt
New submission from Michael Felt : I struggled with how python was packaged by others. Key points being: many dependencies, no assurance you could uninstall the dependencies and/or python. A little over two years ago I started looking for 'root causes' of problems that

[issue33453] from __future__ import annotations breaks dataclasses ClassVar and InitVar handling

2018-05-11 Thread Eric V. Smith
Eric V. Smith added the comment: We can't break the API at this point in the release cycle. But I am open to what string prefixes we should allow. -- ___ Python tracker

[issue33461] json.loads(encoding=) does not emit deprecation warning.

2018-05-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I'm wondering if it can be removed at all. Maybe it was left in issue4136 due to oversight. -- nosy: +bob.ippolito, ezio.melotti, pitrou, rhettinger, serhiy.storchaka ___ Python

[issue33453] from __future__ import annotations breaks dataclasses ClassVar and InitVar handling

2018-05-11 Thread INADA Naoki
INADA Naoki added the comment: "t.ClassVar" looks ugly... How about dropping ClassVar support of dataclass module for 3.7? -- nosy: +inada.naoki ___ Python tracker

[issue33453] from __future__ import annotations breaks dataclasses ClassVar and InitVar handling

2018-05-11 Thread Eric V. Smith
Eric V. Smith added the comment: The more I think about this, the more I think Łukasz is correct that just checking for strings starting with "ClassVar", "typing.ClassVar", or "t.ClassVar" is the correct thing to do. This is the change he made in

[issue33346] Syntax error with async generator inside dictionary comprehension

2018-05-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think this can be fixed simpler. Currently a comprehension become asynchronous in two cases: 1. Explicitly, when it contains 'async for'. This is visible at AST level. 2. Implicitly, when any of inner expressions contains

[issue33346] Syntax error with async generator inside dictionary comprehension

2018-05-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +6452 stage: -> patch review ___ Python tracker ___

[issue33443] Typo in Python/import.c

2018-05-11 Thread Yuki Wakisaka
Change by Yuki Wakisaka : -- versions: -Python 3.8 ___ Python tracker ___ ___

[issue15443] datetime module has no support for nanoseconds

2018-05-11 Thread Mark Dickinson
Change by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___

[issue33455] test.test_posix.TestPosixSpawn::test_specify_environment fails with custom LD_LIBRARY_PATH

2018-05-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33455] test.test_posix.TestPosixSpawn::test_specify_environment fails with custom LD_LIBRARY_PATH

2018-05-11 Thread miss-islington
miss-islington added the comment: New changeset 6e9456e4f6123b13750a10e6ae2eba83504d2f1a by Miss Islington (bot) in branch '3.7': bpo-33455: Pass os.environ in test_posix::test_specify_environment. (GH-6753)