[issue35078] Refactor code in calendar.py module

[శ్రీనివాస్ రెడ్డి తాటిపర్తి]

Change by Srinivas  Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) 
:


--
title: Allow customization of css class name of a month in  calendar module -> 
Refactor code in calendar.py module

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34995] functools.cached_property does not maintain the wrapped method's __isabstractmethod__

[Sergey Fedoseev]

Change by Sergey Fedoseev :


--
nosy: +sir-sigurd

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35074] source install [3.7.1] on debian jessie

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

Sure, I am closing it with duplicate as resolution adding the related ticket 
issue34112 as superseder. Thanks for the report!

--
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> 3.7.0 build error with --enable-optimizations

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35074] source install [3.7.1] on debian jessie

[Leo Li]

Leo Li  added the comment:

Sure! Yes, Pls close it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33710] Deprecate gettext.lgettext()

[Braden Groom]

Braden Groom  added the comment:

Ah. Thank you

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31544] gettext.Catalog title is not flagged as a class

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2504] Add gettext.pgettext() and variants support

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

l*gettext() functions have been just deprecated in issue33710. Please update 
the PR and remove new l*gettext() functions.

--
versions: +Python 3.8 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10536] Enhancements to gettext docs

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Éric, do you mind to create a PR? But please avoid unnecessary formatting 
changes like adding a second space between sequences. While I prefer such 
style, these changes doesn't affect the result output and distract attention 
from significant changes.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35080] The tests for the `dis` module can be too rigid when changing opcodes

[Maxime Belanger]

Maxime Belanger  added the comment:

Ah, quite right; apologies for the not-so-useful PR!

--
resolution:  -> wont fix
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35074] source install [3.7.1] on debian jessie

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

Thanks, I guess then it's the same as issue34112 with --enable-optimizations 
being incompatible with older compiler toolchains like GCC 4 in this case. Feel 
free to close this if it resolves the issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33710] Deprecate gettext.lgettext()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

See PEP 4.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35080] The tests for the `dis` module can be too rigid when changing opcodes

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Actually this change decreases flexibility of tests. Expected output is 
generated. See the comment above it. When you change the bytecode, you need 
just uncomment these lines, run tests, copy the output, and comment out them 
back. The output contains numerical values of opcodes.

It is rarely they are changed without changing the meaning of opcodes. It is 
more common to add new opcodes and replace old opcodes with other opcodes with 
different semantic. This leads to changing opcode arguments and offsets, adding 
and removing lines.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35074] source install [3.7.1] on debian jessie

[Leo Li]

Leo Li  added the comment:

I've tested 2 way to solve this:
1. disable --enable-optimizations option. the software can be compile and 
install successful.
2. upgrade gcc version to 8.2.0. 

docker ➜  bin gcc --version
gcc (Debian 8.2.0-8) 8.2.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33710] Deprecate gettext.lgettext()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset fec35c99aa749bb90cb29349bed6b3393907c4c1 by Serhiy Storchaka in 
branch 'master':
bpo-33710: Deprecate l*gettext() and related functions in the gettext module. 
(GH-10139)
https://github.com/python/cpython/commit/fec35c99aa749bb90cb29349bed6b3393907c4c1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33710] Deprecate gettext.lgettext()

[Braden Groom]

Braden Groom  added the comment:

Thanks! I'll check out the linked PR. I've seen a few deprecation issues that I 
couldn't pick up just because I wasn't clear on the deprecation process. Is 
this documented anywhere in the development guides? I wasn't able to find it if 
it exists. Is there any interest in adding a section for this?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

[Terry J. Reedy]

Change by Terry J. Reedy :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34160] ElementTree not preserving attribute order

[Raymond Hettinger]

Raymond Hettinger  added the comment:

Diego, it would be premature to write an implementation until we've agreed on 
an API.  

I object to the Serhiy's proposal, and if no one agrees to my proposal to 
preserve the user's specific actions, then it  would be better to do nothing at 
all, leaving the current API (deterministic, but with no particular order being 
guaranteed).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34160] ElementTree not preserving attribute order

[Raymond Hettinger]

Raymond Hettinger  added the comment:

Though it is compatible with earlier versions, I don't see any reason to keep 
sorting at all, especially as a default.  The reasonable default is that 
whatever order the user specifies is what the tool does.

The backwards compatible argument is specious.  The ordering was never 
guaranteed.  The only reason that we had sorting was to make the XML generation 
deterministic, and that is something we would still have.

I vote against the permanent API expansion with an unhelpful default.  The 
sorting is no longer necessary or desirable.  Appropriately, we never 
guaranteed it, leaving us the implementation flexibility to make exactly this 
change.

AFAICT, no XML user has ever expressed an interest in having attributes appear 
in alphabetical order -- for that matter, I can't recall any HTML user having 
expressed this preference (instead, they prefer to put class and id tags ahead 
of other tags for example).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34160] ElementTree not preserving attribute order

[Diego Rojas]

Diego Rojas  added the comment:

I'm working on this issue, but I have some questions:

1. If dump() function is only for debugging purpose, and since from dump() is 
where we will pass the sort_attrs keyword in False in order to conserve the 
order, I don't see how from dump() we can handle the order of the keyword 
arguments. The sorted occurs in line 926 
(https://github.com/python/cpython/blob/master/Lib/xml/etree/ElementTree.py#L926)
 and 
982(https://github.com/python/cpython/blob/master/Lib/xml/etree/ElementTree.py#L982)
 when xml or html are serialized. Or could we pass the sort_attrs to the 
functions _serialize_html/_serialize_xml and there handle this?

2. Just a comment, maybe sort_attrs is not ambiguous? For a user would be clear 
that sort_attrs will order the arguments in lexical order or maybe he/she could 
be confused and take it as that will respect the order of the keywords passed?

--
nosy: +dfrojas

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

[miss-islington]

miss-islington  added the comment:


New changeset e389de8e3e897fa5ba4f71b0f711355fb7158049 by Miss Islington (bot) 
in branch '2.7':
bpo-35079: Revise difflib.SequenceManager.get_matching_blocks doc (GH-10144)
https://github.com/python/cpython/commit/e389de8e3e897fa5ba4f71b0f711355fb7158049


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

[miss-islington]

miss-islington  added the comment:


New changeset 5282125650a70811f0d64ab231e2a6c8ac20c96b by Miss Islington (bot) 
in branch '3.6':
bpo-35079: Revise difflib.SequenceManager.get_matching_blocks doc (GH-10144)
https://github.com/python/cpython/commit/5282125650a70811f0d64ab231e2a6c8ac20c96b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

[miss-islington]

miss-islington  added the comment:


New changeset cb920c1442bf3b0899fee51915b4bf6614f2c1d7 by Miss Islington (bot) 
in branch '3.7':
bpo-35079: Revise difflib.SequenceManager.get_matching_blocks doc (GH-10144)
https://github.com/python/cpython/commit/cb920c1442bf3b0899fee51915b4bf6614f2c1d7


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

[miss-islington]

Change by miss-islington :


--
pull_requests: +9474

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset d9bff4e81b8ca36fe6c4e90c0b9cf02bc020e713 by Terry Jan Reedy in 
branch 'master':
 bpo-35079: Revise difflib.SequenceManager.get_matching_blocks doc (GH-10144)
https://github.com/python/cpython/commit/d9bff4e81b8ca36fe6c4e90c0b9cf02bc020e713


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

[miss-islington]

Change by miss-islington :


--
pull_requests: +9473

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

[miss-islington]

Change by miss-islington :


--
pull_requests: +9472
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Tim, I share your concern about bloating docs, but think this one word 
worthwhile.  I suspect that people are conditioned to accept 'non-overlapping' 
because that is ofter (usually?) the default for linear searches and regex 
matching.

--
stage: patch review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

[Terry J. Reedy]

Change by Terry J. Reedy :


--
keywords: +patch
pull_requests: +9471
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35070] test_posix fails on macOS 10.14 Mojave

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

issue33223 also reports failure of test_posix under 10.13.4 and seems to be 
related.

--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35070] test_posix fails on macOS 10.14 Mojave

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

Wonderful

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35070] test_posix fails on macOS 10.14 Mojave

[STINNER Victor]

STINNER Victor  added the comment:

It seems like people have fun with getgroups() on macOS:

* bpo-7900
* bpo-16661
* bpo-17557
* bpo-29562

Maybe we should simply skip test_getgroups() and test_getgrouplist() on macOS 
with a comment listing all these BPO issues.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Rename Include/internals/ to Include/pycore/

[STINNER Victor]

STINNER Victor  added the comment:

See also bpo-35059 which converts C macros to static inline functions.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35070] test_posix fails on macOS 10.14 Mojave

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

Yep, stepping through Python with lldb, that's what's happening.  I know one of 
my coworkers has been able to reproduce it.  I'll chime in next once I upgrade 
my personal machine and can try it there, since I know it isn't on AD.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35059] Convert Py_INCREF() and PyObject_INIT() to inlined functions

[STINNER Victor]

STINNER Victor  added the comment:

See also bpo-35081: "Rename Include/internals/ to Include/pycore/" which is 
linked to this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Rename Include/internals/ to Include/pycore/

[STINNER Victor]

STINNER Victor  added the comment:

I decided to work on this issue while trying to convert the 
_PyObject_GC_TRACK() macro into a "static inline" function. Currently, the 
macro uses _PyGC_generation0 which is defined earlier by "extern PyGC_Head 
*_PyGC_generation0;".

Problem: _PyGC_generation0 no longer exists... Include/internal/mem.h now 
defines: "#define _PyGC_generation0 _PyRuntime.gc.generation0".

Include/internal/mem.h includes Include/objimpl.h, but Include/objimpl.h 
requires Include/internal/mem.h. The include order matters here, many header 
files are inter-dependent, and have two header files with the same name in 
Include/ and Include/internal/ causes issues depending where the #include is 
done...

My PR renames mem.h to pycore_objimpl.h and include pycore_objimpl.h at "the 
right place" in objimpl.h. Since objimpl.h controls where pycore_objimpl.h is 
imported, it's simpler to handle inter-dependencies simpler.

Some inter-dependencies issues are hidden by the fact the C macros don't really 
require functions, macros and variables in the right order. They "just work". 
But converting C macros to proper "static inline" functions expose many issues.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Rename Include/internals/ to Include/pycore/

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch
pull_requests: +9470
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Rename Include/internals/ to Include/pycore/

[STINNER Victor]

New submission from STINNER Victor :

Currently, #include "pymem.h" may include Include/pymem.h or 
Include/internal/pymem.h depending where is the C file (.c) and if 
Include/internal/ is in the header search path or not.

I propose to:

* Rename Include/internal/ to Include/pycore/
* In this subdirectory, rename xxx.h to pycore_xxx.h to avoid any risk of 
confusion
* Automatically include pycore_xxx.h in xxx.h if Py_BUILD_CORE is defined: this 
should avoid the need of explicit #include "internal/xxx.h" in C files

For example, Include/internal/pystate.h becomes Include/pycore/pycore_pystate.h.

Attached PR implements this idea.

I chose to rename "internal" subdirectory to "pycore" to prepare the addition 
of other subdirectories. See:

* https://pythoncapi.readthedocs.io/split_include.html
* https://pythoncapi.readthedocs.io/

Next steps:

* Move all code surrounded by #ifdef Py_BUILD_CORE from Include/*.h into 
Include/pycore/*.h: see the second commit of my PR for an example
* Move core surrounded by #ifndef Py_LIMITED_API from Include/*.h into 
Include/limited/ (example of filename: Include/limited/limited_object.h)


This change should be backward compatible since Include/internal/ must not be 
used outside CPython core. If someone does that, well, be ready for breakage 
:-) It's not supported.

--
components: Interpreter Core
messages: 328619
nosy: vstinner
priority: normal
severity: normal
status: open
title: Rename Include/internals/ to Include/pycore/
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35070] test_posix fails on macOS 10.14 Mojave

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

I really have no idea what's going on.  I've looked at posixmodule.c and tried 
to reproduce as best I can in a standalone C program.

In both cases getgroups(0, NULL) returns 15.  In the standalone version, when I 
then call getgroups(15, grouplist), I again get 15 returned and grouplist is 
properly filled.  But in posixmodule.c case, I get 1 back group that second 
call.

I honestly can't see any difference or why this could be happening.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35070] test_posix fails on macOS 10.14 Mojave

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

gcc -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv 
-O3 -Wall -v   -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter 
-Wno-missing-field-initializers -Wstrict-prototypes 
-Werror=implicit-function-declaration   -I. -I./Include -DPy_BUILD_CORE -c 
./Modules/posixmodule.c -o Modules/posixmodule.o
Apple LLVM version 10.0.0 (clang-1000.11.45.2)
Target: x86_64-apple-darwin18.0.0
Thread model: posix
InstalledDir: 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
 
"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang"
 -cc1 -triple x86_64-apple-macosx10.14.0 -Wdeprecated-objc-isa-usage 
-Werror=deprecated-objc-isa-usage -emit-obj -disable-free 
-disable-llvm-verifier -discard-value-names -main-file-name posixmodule.c 
-mrelocation-model pic -pic-level 2 -mthread-model posix -mdisable-fp-elim 
-fno-strict-return -masm-verbose -munwind-tables -target-cpu penryn 
-dwarf-column-info -debug-info-kind=standalone -dwarf-version=4 
-debugger-tuning=lldb -target-linker-version 409.12 -v -coverage-notes-file 
/Users/bwarsaw/projects/python/cpython/Modules/posixmodule.gcno -resource-dir 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/10.0.0
 -D NDEBUG -I . -I ./Include -D Py_BUILD_CORE -O3 -Wno-unused-result 
-Wsign-compare -Wunreachable-code -Wall -Wextra -Wno-unused-result 
-Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes 
-Werror=implicit-function-declar
 ation -std=c99 -fdebug-compilation-dir /Users/bwarsaw/projects/python/cpython 
-ferror-limit 19 -fmessage-length 131 -fwrapv -stack-protector 1 -fblocks 
-fencode-extended-block-signature -fobjc-runtime=macosx-10.14.0 
-fmax-type-align=16 -fdiagnostics-show-option -vectorize-loops -vectorize-slp 
-o Modules/posixmodule.o -x c ./Modules/posixmodule.c
clang -cc1 version 10.0.0 (clang-1000.11.45.2) default target 
x86_64-apple-darwin18.0.0
#include "..." search starts here:
#include <...> search starts here:
 .
 ./Include
 /usr/local/include
 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/10.0.0/include
 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include
 /usr/include
 /System/Library/Frameworks (framework directory)
 /Library/Frameworks (framework directory)
End of search list.
./Modules/posixmodule.c:1254:9: warning: code will never be executed 
[-Wunreachable-code]
PyErr_SetFromErrno(PyExc_OSError);
^~
1 warning generated.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35070] test_posix fails on macOS 10.14 Mojave

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

% gcc -v gg.c
Apple LLVM version 10.0.0 (clang-1000.11.45.2)
Target: x86_64-apple-darwin18.0.0
Thread model: posix
InstalledDir: 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
 
"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang"
 -cc1 -triple x86_64-apple-macosx10.14.0 -Wdeprecated-objc-isa-usage 
-Werror=deprecated-objc-isa-usage -emit-obj -mrelax-all -disable-free 
-disable-llvm-verifier -discard-value-names -main-file-name gg.c 
-mrelocation-model pic -pic-level 2 -mthread-model posix -mdisable-fp-elim 
-fno-strict-return -masm-verbose -munwind-tables -target-cpu penryn 
-dwarf-column-info -debugger-tuning=lldb -target-linker-version 409.12 -v 
-resource-dir 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/10.0.0
 -fdebug-compilation-dir /Users/bwarsaw/projects/python -ferror-limit 19 
-fmessage-length 131 -stack-protector 1 -fblocks 
-fencode-extended-block-signature -fobjc-runtime=macosx-10.14.0 
-fmax-type-align=16 -fdiagnostics-show-option -o 
/var/folders/06/yd7czfp11bx1vx4p5dl10v4w000slb/T/gg-a38469.o -x c gg.c
clang -cc1 version 10.0.0 (clang-1000.11.45.2) default target 
x86_64-apple-darwin18.0.0
#include "..." search starts here:
#include <...> search starts here:
 /usr/local/include
 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/10.0.0/include
 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include
 /usr/include
 /System/Library/Frameworks (framework directory)
 /Library/Frameworks (framework directory)
End of search list.
 
"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld"
 -demangle -lto_library 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/libLTO.dylib
 -no_deduplicate -dynamic -arch x86_64 -macosx_version_min 10.14.0 -o a.out 
/var/folders/06/yd7czfp11bx1vx4p5dl10v4w000slb/T/gg-a38469.o -lSystem 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/10.0.0/lib/darwin/libclang_rt.osx.a

% otool -L a.out 
a.out:
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current 
version 1252.200.5)

So I guess it's interesting that it's searching /usr/local/include, which has 
some Homebrew headers in it:

% ls /usr/local/include
ImageMagick-7@  gdcache.h@  libltdl@
pg_config_manual.h@ sqlda-native.h@
adns.h@ gdfontg.h@  libpng16@   
pg_config_os.h@ sqlda.h@
aspell.h@   gdfontl.h@  libpq@  
pgtypes.h@  tiff.h@
assuan.h@   gdfontmb.h@ libpq-events.h@ 
pgtypes_date.h@ tiffconf.h@
ecpg_config.h@  gdfonts.h@  libpq-fe.h@ 
pgtypes_error.h@tiffio.h@
ecpg_informix.h@gdfontt.h@  libssh2.h@  
pgtypes_interval.h@ tiffio.hxx@
ecpgerrno.h@gdfx.h@ libssh2_publickey.h@
pgtypes_numeric.h@  tiffvers.h@
ecpglib.h@  gdpp.h@ libssh2_sftp.h@ 
pgtypes_timestamp.h@unicase.h@
ecpgtype.h@ gmp.h@  libtasn1.h@ png.h@  
uniconv.h@
entities.h@ gmpxx.h@libusb-1.0@ 
pngconf.h@  unictype.h@
evdns.h@gnutls@ ltdl.h@ 
pnglibconf.h@   unigbrk.h@
event.h@gpg-error.h@lzma@   popt.h@ 
unilbrk.h@
event2@ gpgrt.h@lzma.h@ 
postgres_ext.h@ uniname.h@
evhttp.h@   graphviz@   mysql@  pspell@ 
uninorm.h@
evrpc.h@idn2.h@ nettle@ 
python3.6m/ unistdio.h@
evutil.h@   informix@   newt.h@ 
python3.7m/ unistr.h@
fontconfig@ internal@   npth.h@ 
python3.8m/ unistring@
freetype2@  jconfig.h@  nspr@   
readtags.h@ unitypes.h@
gcrypt.h@   jerror.h@   openjpeg-2.3@   server@ 
uniwbrk.h@
gd.h@   jmorecfg.h@ p11-kit-1@  
slang.h@uniwidth.h@
gd_color_map.h@ jpeglib.h@  pcre2.h@
slcurses.h@ webp@
gd_errors.h@ksba.h@ pcre2posix.h@   
sql3types.h@
gd_io.h@lcms2.h@pg_config.h@sqlca.h@
gdbm.h@ lcms2_plugin.h@ pg_config_ext.h@
sqlda-compat.h@

All those 

[issue35080] The tests for the `dis` module can be too rigid when changing opcodes

[Maxime Belanger]

Change by Maxime Belanger :


--
components: +Library (Lib), Tests

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35080] The tests for the `dis` module can be too rigid when changing opcodes

[Max Bélanger]

Change by Max Bélanger :


--
keywords: +patch
pull_requests: +9469
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35080] The tests for the `dis` module can be too rigid when changing opcodes

[Maxime Belanger]

New submission from Maxime Belanger :

For various reasons, one may want to change the `Lib/opcode.py` module. In 
doing so, this has caused us to frequently rewrite `test_dis.py`. It would be 
great if those tests used `dis.opmap` rather than hard-coded/magic numbers, as 
this would allow easier changes.

--
messages: 328615
nosy: Maxime Belanger
priority: normal
severity: normal
status: open
title: The tests for the `dis` module can be too rigid when changing opcodes
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35042] Use the role :pep: for the PEP \d+

[Brett Cannon]

Brett Cannon  added the comment:


New changeset 12e696b4f071ffe0d585b7f0d0d8020fd328bfdd by Brett Cannon 
(Stéphane Wirtel) in branch 'master':
bpo-35042: Use the :pep: role where a PEP is specified (#10036)
https://github.com/python/cpython/commit/12e696b4f071ffe0d585b7f0d0d8020fd328bfdd


--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35052] Coverity scan: copy/paste error in Lib/xml/dom/minidom.py

[Tal Einat]

Tal Einat  added the comment:

Shivank, indeed it seems you're now in the right direction.

A bit of clarification:
* The test shouldn't test _clone_node() directly, since that is an internal 
function.  Rather, the test code should be as near as possible to what a user 
of the minidom module would reasonably write.
* Since this bug appears in two places, you'll likely need different tests for 
each of them.  You should likely start with just one, and once you've 
successfully written a test for it and fixed it, move on to the other.  (In the 
end, make each test+fix a separate commit in the PR.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35052] Coverity scan: copy/paste error in Lib/xml/dom/minidom.py

[Shivank Gautam]

Shivank Gautam  added the comment:

I See, I need to find out for what test case `_clone_node()` will show 
unexpected behaviour, which will verify that it is a bug and we also need a 
test code to in test_minidom.py just to verify the behaviour.
am I going in right direction Tai?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35052] Coverity scan: copy/paste error in Lib/xml/dom/minidom.py

[Tal Einat]

Tal Einat  added the comment:

Shivank, I recommend taking a look at some of the existing tests for this 
module, found in Lib/test/test_minidom.py.  See how they are built and how 
various functionality is tested.  This should give you a good idea of what a 
test for this bug would look like.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35052] Coverity scan: copy/paste error in Lib/xml/dom/minidom.py

[Tal Einat]

Tal Einat  added the comment:

Looking at the code in Lib/xml/dom/minidom.py, this exact typo is also found in 
DocumentType.cloneNode().  That should be tested and fixed too.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35070] test_posix fails on macOS 10.14 Mojave

[Ned Deily]

Ned Deily  added the comment:

Er, and perhaps the compile and link calls from when Python builds 
posixmodule.c ?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35052] Coverity scan: copy/paste error in Lib/xml/dom/minidom.py

[Tal Einat]

Tal Einat  added the comment:

Shivank, there is currently technically no "error to solve", since we have no 
test that causes this erroneous behavior and catches it. We've only found what 
appears to be a bug by looking at the code, but we need to *verify* that it is 
indeed a bug. Also, this means that we have a piece of code that our test suite 
is missing; this is the real reason I insist that this needs a test.

You should trace what uses the affected code and which scenarios could lead to 
this bug causing unexpected behavior.

In this case, the code is in `_clone_node()`, which helpfully has the following 
comment in its doc-string: "Called by Node.cloneNode and Document.importNode". 
Work up from there, understand what this could affect, and think of a scenario 
where this code wouldn't work as expected.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35070] test_posix fails on macOS 10.14 Mojave

[Ned Deily]

Ned Deily  added the comment:

Yeah. Can you check the header file paths that are being used in your compiler 
invocation, e.g something like:  cc -v -c ...
And, while you are at it, the library search path of the test executable:  
otool -L ./...
And anything suspicious in /usr/local/include or /usr/local/lib ?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29341] Missing accepting path-like object in docstrings of os module functions

[Guido van Rossum]

Change by Guido van Rossum :


--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

[Tim Peters]

Tim Peters  added the comment:

I don't object to spelling it out more, and your (Terry's) suggestions are 
fine.  On the other hand, this module has been around for a lng time now, 
and this is the first instance I've seen of someone surprised that it doesn't 
produce overlapping matches - it's obvious from "The same idea is then applied 
recursively to the pieces of the sequences to the left and to the right of the 
matching subsequence" that a matching subsequence is wholly eliminated from 
further consideration.

At some point of ever-more tedious elaboration, the docs risk missing the 
forest for the trees.  I don't think _these_ docs are quite there yet - 
although the docs for `find_longest_match()` are.  Speaking of which, that 
method _could_ be used to find overlapping matches, one at a time, by passing 
appropriate slice indices.

Which can be horridly inefficient; e.g., find all overlapping matches between

'A' * 100

and

'A' * 150

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35042] Use the role :pep: for the PEP \d+

[Éric Araujo]

Éric Araujo  added the comment:

Docutils itself parses `RFC ` and `PEP nnn` to replace with links.

In some parts of the docs with many references, some devs (I think Raymond 
Hettinger for example) use tricks like `PEP\ nnn` to avoid getting twenty links 
in a row.

So I don’t see what the replacement of `PEP nnn` with `:pep:`nnn`` adds.

--
nosy: +eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35077] Make TypeError message less ambiguous

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Aside from the effort of making a change correct and consistent across our 
code, error message changes often breaks user code and tests that depend on the 
current wording.  So there must be sufficient benefit to overcome the cost.  
(The user breakage cost is why we nearly always wait for the next version to 
make such changes.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35070] test_posix fails on macOS 10.14 Mojave

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

Yes, I've rebooted :)   I've modified your C program a little and here's the 
code and output.

#include 
#include 
#include 

int main()
{
gid_t grouplist[32];
int n;
int gidsetsize;

for (gidsetsize = 0; gidsetsize < 22; ++gidsetsize) {
n = getgroups(gidsetsize, grouplist);
printf("calling grouplist with gidsetsize = %i, returns %i: ", 
gidsetsize, n);
for (int j = 0; j < n; j++) {
printf("%i ", grouplist[j]);
}
printf("\n");
}
exit(0);
}

calling grouplist with gidsetsize = 0, returns 15: -483891656 32766 -483891672 
32766 -483891728 32766 427353334 1 -483891696 32766 0 0 0 0 -483891672 
calling grouplist with gidsetsize = 1, returns -1: 
calling grouplist with gidsetsize = 2, returns -1: 
calling grouplist with gidsetsize = 3, returns -1: 
calling grouplist with gidsetsize = 4, returns -1: 
calling grouplist with gidsetsize = 5, returns -1: 
calling grouplist with gidsetsize = 6, returns -1: 
calling grouplist with gidsetsize = 7, returns -1: 
calling grouplist with gidsetsize = 8, returns -1: 
calling grouplist with gidsetsize = 9, returns -1: 
calling grouplist with gidsetsize = 10, returns -1: 
calling grouplist with gidsetsize = 11, returns -1: 
calling grouplist with gidsetsize = 12, returns -1: 
calling grouplist with gidsetsize = 13, returns -1: 
calling grouplist with gidsetsize = 14, returns -1: 
calling grouplist with gidsetsize = 15, returns 15: 101 503 701 501 12 62 80 
502 33 98 100 204 250 395 398 
calling grouplist with gidsetsize = 16, returns 15: 101 503 701 501 12 62 80 
502 33 98 100 204 250 395 398 
calling grouplist with gidsetsize = 17, returns 15: 101 503 701 501 12 62 80 
502 33 98 100 204 250 395 398 
calling grouplist with gidsetsize = 18, returns 15: 101 503 701 501 12 62 80 
502 33 98 100 204 250 395 398 
calling grouplist with gidsetsize = 19, returns 15: 101 503 701 501 12 62 80 
502 33 98 100 204 250 395 398 
calling grouplist with gidsetsize = 20, returns 15: 101 503 701 501 12 62 80 
502 33 98 100 204 250 395 398 
calling grouplist with gidsetsize = 21, returns 15: 101 503 701 501 12 62 80 
502 33 98 100 204 250 395 398 

% id -G
101 503 701 501 12 62 80 502 33 98 100 204 250 395 398

I've also made a small change to test_posix.py:

diff --git a/Lib/test/test_posix.py b/Lib/test/test_posix.py
index 86c04b9f32..5074b45fc0 100644
--- a/Lib/test/test_posix.py
+++ b/Lib/test/test_posix.py
@@ -1047,8 +1047,9 @@ class PosixTester(unittest.TestCase):
 # groups, ignoring order, duplicates, and the effective gid.
 # #10822/#26944 - It is implementation defined whether
 # posix.getgroups() includes the effective gid.
-symdiff = idg_groups.symmetric_difference(posix.getgroups())
-self.assertTrue(not symdiff or symdiff == {posix.getegid()})
+groups = posix.getgroups()
+symdiff = idg_groups.symmetric_difference(groups)
+self.assertTrue(not symdiff or symdiff == {posix.getegid()}, 
(idg_groups, groups, symdiff))
 
 # tests for the posix *at functions follow
 
But when I run ./python.exe -m test test.test_posix here's what I get:

Run tests sequentially
0:00:00 load avg: 1.62 [1/1] test.test_posix
test test.test_posix failed -- Traceback (most recent call last):
  File "/Users/bwarsaw/projects/python/cpython/Lib/test/test_posix.py", line 
1052, in test_getgroups
self.assertTrue(not symdiff or symdiff == {posix.getegid()}, (idg_groups, 
groups, symdiff))
AssertionError: False is not true : ({33, 98, 100, 101, 395, 12, 204, 398, 80, 
501, 502, 503, 250, 701, 62}, [101], {33, 98, 100, 395, 12, 204, 398, 80, 501, 
502, 503, 250, 701, 62})

So it seems like getgroups(2) is doing the right thing, but not Python.  Weird.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

[Terry J. Reedy]

Terry J. Reedy  added the comment:

We can assume that "substring 'CA'" was meant to be "substring 'AC'", but as 
explained, missing 'AC' is not a bug.  (Tim wrote the module.)

I read the doc, and 'non-overlapping' is implied in the SequenceMatcher entry 
at the top of the file.

"The idea is to find the longest contiguous matching subsequence that contains 
no “junk” elements; ... The same idea is then applied recursively to the pieces 
of the sequences to the left and to the right of the matching subsequence."

However, a user of SequenceMatcher could easily miss that, and its implication, 
as Springem did.  For clarity, I think we should add 'non-overlapping to the 
first line of the .get_matching_blocks entry, which is in the middle of the 
page. "Return list of triples describing non-overlapping matching subsequences."

I also think "i+n != i' or j+n != j'" should be changed to "i+n < i' or j+n < 
j'" as '>' would mean overlapping.  So != must mean <.

I will prepare a doc PR later.

--
assignee:  -> terry.reedy
components: +Documentation
stage:  -> needs patch
versions: +Python 3.8 -Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35035] Documentation for email.utils is named email.util.rst

[R. David Murray]

R. David Murray  added the comment:

Sure, this is fine with me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35030] Python 2.7 OrderedDict creates circular references

[tzickel]

tzickel  added the comment:

Sorry ignore it. Closed the PR as well.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35030] Python 2.7 OrderedDict creates circular references

[tzickel]

tzickel  added the comment:

Is this commit interesting ? It has less lines, more simple and makes no cycles 
to collect, and it seems in my limited benchmark faster than the current 
implementation. 

https://github.com/tzickel/cpython/commit/7e8b70b67cd1b817182be4dd2285bd136e6b156d

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35077] Make TypeError message less ambiguous

[coyot linden]

coyot linden  added the comment:

The problem I have with "So only the 'index of string' interpretation makes 
sense." is that by the time a developer has that understanding, they won't get 
this error. So it's fine and logical to say from the behind-the-scenes view 
that only sequences talk about indices, but that's not helpful to the confused 
developer who gets this message. The point of error messages should be to 
clearly indicate the problem and solution, not rely on the developer having a 
global understanding of error messages.

So, rather than defend the current practice, I ask if there are arguments 
against "X of Y". Is there some context in which that is confusing?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35077] Make TypeError message less ambiguous

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I checked a bit.  All the 'index' entries in the index are about sequences.  
However, https://docs.python.org/3/reference/datamodel.html has this abstract 
(non-Python) description:

"Mappings
These represent finite sets of objects indexed by arbitrary index sets. The 
subscript notation a[k] selects the item indexed by k from the mapping a; ...
Dictionaries
These represent finite sets of objects indexed by nearly arbitrary 
values."

I personally would prefer 'keyed' or 'subscripted' and 'key'to prevent 
confusion.  The entry then switches to the usual Python term 'key'.

"The only types of values not acceptable as keys  ... a key’s hash value ... 
used for keys ..."

https://docs.python.org/3/library/stdtypes.html#mapping-types-dict uses 'index' 
once as a verb, otherwise uses 'key'.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35077] Make TypeError message less ambiguous

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I have a mixed opinion of this.  On the one hand, 'string index', taken out of 
context, *is* ambiguous.  (In the context of the TypeError message, it took me 
a minute to see the string-index interpretation.)  On the other hand, dicts do 
not have indices.  They have keys.  So only the 'index of string' 
interpretation makes sense.

Is there anything in the docs that suggests that a mapping subscript can be 
called an 'index' in addition to 'key'?

It would be nicer if this TypeError message also included 'not x', but there 
may be an issue that the type x info is lost.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

[Tim Peters]

Tim Peters  added the comment:

Sorry, I find this too hard to follow.  At the end:

> ['TA', 'CA'] # Missing the substring 'CA'

the comment claims it's missing 'CA', while the output plainly shows it's _not_ 
missing 'CA'.

If your complaint is that's missing 'AC', yes, it is.  It's not intended to 
find _overlapping_ matches at all (read the docs).  The longest matching blocks 
in

TAGACCA
ATACA

are in fact TA, CA, and AC, but after the leftmost-longest TA is matched first, 
AC no longer exists _to_ match in the second string.  Only CA does.

--
nosy: +tim.peters

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35066] Inconsistency between dangling '%' handling in time.strftime() and datetime.strftime()

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

Thanks for the details. The C implementation should be same as Python 
implementation which in this case differs as per your analysis if I am 
understanding it right and IIRC there is a PEP (PEP 399 I think) to enforce 
that C and Python implementation should behave the same.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

[Springem Springsbee]

New submission from Springem Springsbee :

Hello, I'm using difflib's SequenceMatcher to locate common substrings. It 
seems like the matcher is missing a common substrings. I'm guessing this is a 
rather low-level issue in difflib. The autojunk parameter has no effect for 
obvious reasons. Alternate pairwise comparisons between the following 3 strings 
omit the 2-character match 'AC'

GATTACA
TAGACCA
ATACA

The following Github gist captures the issue, which I'll repeat here for 
redundancy 
https://gist.github.com/MatthewRalston/b0ab6ac1dbe322cb12063310ccdbb786

>import difflib
>string1 = "TAGACCA"
>string2 = "ATACA"
>s = difflib.SequenceMatcher(None, string1, string2)
>blox = s.get_matching_blocks()
>print(blox)
[Match(a=0, b=1, size=2), Match(a=5, b=3, size=2), Match(a=7, b=5, size=0)] # 
Missing Match(a=3, b=2, size=2)
>print([string1[x.a:x.a+x.size] for x in blox if x.size > 1])
['TA', 'CA'] # Missing the substring 'CA'

--
components: Library (Lib)
messages: 328593
nosy: Springem Springsbee, terry.reedy
priority: normal
severity: normal
status: open
title: difflib.SequenceMatcher.get_matching_blocks omits common strings
type: behavior
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35045] test_min_max_version (test.test_ssl.ContextTests) fails on Fedora 29+ and openssl 1.1.1

[Terry J. Reedy]

Change by Terry J. Reedy :


--
nosy: +jean-michel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35045] test_min_max_version (test.test_ssl.ContextTests) fails on Fedora 29+ and openssl 1.1.1

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I closed #35076 as a duplicate of this.  The distribution was not specified.  
The version is 3.7.1 plus additional patches.  A build log is attached.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35076] FAIL: test_min_max_version (test.test_ssl.ContextTests) with libressl-2.8.2

[Terry J. Reedy]

Change by Terry J. Reedy :


--
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> test_min_max_version (test.test_ssl.ContextTests) fails on 
Fedora 29+ and openssl 1.1.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35066] Inconsistency between dangling '%' handling in time.strftime() and datetime.strftime()

[Michael Saah]

Michael Saah  added the comment:

Appologies, will do.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35066] Inconsistency between dangling '%' handling in time.strftime() and datetime.strftime()

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Michael Saah, when you reply by email, *please* delete the quoted post you are 
replying to (except possibly for a relevant line or two.).  The quotation 
duplicates what is already on the web page and makes it harder to scroll 
through posts on the web page.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33710] Deprecate gettext.lgettext()

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

The deprecation notice is added to the docs and deprecation warnings are raised 
during usage of the functions. As per the PR some of them are deprecated with 
3.8 (master) and will be removed by 3.10. But this depends on the discussion 
over the deprecation cycle. There were cases in the past where issues were 
raised in bpo for undeprecation (issue27172) after being deprecated for several 
versions. There are also cases where the functions that had to be removed were 
postponed for removal to a later version instead of the one initially shown in 
warnings.

# Python 3.7 no warnings

$ python3.7
Python 3.7.1rc2 (v3.7.1rc2:6c06ef7dc3, Oct 13 2018, 05:10:29)
[Clang 6.0 (clang-600.0.57)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from gettext import NullTranslations
>>> NullTranslations().lgettext("test")
b'test'

# PR branch

(pr_10139) ./python.exe
Python 3.8.0a0 (heads/master:4e3a53bcee, Oct 26 2018, 23:44:23)
[Clang 7.0.2 (clang-700.1.81)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from gettext import NullTranslations
>>> NullTranslations().lgettext("test")
:1: DeprecationWarning: lgettext() is deprecated, use gettext() instead
b'test'


Hope it helps

--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34160] ElementTree not preserving attribute order

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

This is an easy issue and I left it for beginning contributors. The PR should 
include the following changes:

* Add an optional sort_attrs parameter (True by default) in the write() method.

* Make the dump() function passing sort_attrs=False to write().

* Add tests for write() (with sort_attrs=False and sort_attrs=True) and dump() 
and/or modify existing tests.

* Document change (in the module docs, in What's New, news entry).

--
keywords: +easy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35077] Make TypeError message less ambiguous

[coyot linden]

coyot linden  added the comment:

You're welcome. I filed against 3.5 because that's what I have in our env at 
the moment and I couldn't test and thus assert the issue in later versions. 

Happy to see the problem addressed more generally.

The abstraction of the problem is the ambiguity in English between nouns used 
as adjectives and their groupings: (noun phrase) versus (noun as 
adjective)(noun). Using "X of Y" rather than (XY) or (X)(Y) resolves the 
ambiguity.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35024] Incorrect logging in importlib when '.pyc' file creation fails

[miss-islington]

miss-islington  added the comment:


New changeset 9e14e49f13ef1a726f31efe6689285463332db6e by Miss Islington (bot) 
(Quentin Agren) in branch 'master':
bpo-35024: Remove redundant and possibly incorrect verbose message after 
writing '.pyc' (GH-9998)
https://github.com/python/cpython/commit/9e14e49f13ef1a726f31efe6689285463332db6e


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35035] Documentation for email.utils is named email.util.rst

[Terry J. Reedy]

Change by Terry J. Reedy :


--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33710] Deprecate gettext.lgettext()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Sometime we starts with deprecating just in the documentation, if it is hard to 
add deprecation in the code or adding it will break a lot of working code. But 
this is not the case. lgettext() was inherently broken in Python 3.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33710] Deprecate gettext.lgettext()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

It includes three parts:

* Add the code that emits a DeprecationWarning when corresponding functions and 
arguments are used. It is important to specify the correct stacklevel argument.

* Add tests and/or modify existing test for catching or silencing a 
DeprecationWarning.

* Document this change: in the module documentation, in the What's New 
document, and add a news entry.

PR 10139 implements all this.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18114] Update PyImport_ImportFrozenModuleObject() to set __package__

[Brett Cannon]

Brett Cannon  added the comment:

I'm not sure if it's still relevant. :) Feel free to look at the code and come 
back here with a recommendation as to whether this is still necessary or not.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33710] Deprecate gettext.lgettext()

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +9468
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35070] test_posix fails on macOS 10.14 Mojave

[Ned Deily]

Ned Deily  added the comment:

Also, I'm assuming you've tried rebooting your system?  :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35078] Allow customization of css class name of a month in calendar module

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35070] test_posix fails on macOS 10.14 Mojave

[Ned Deily]

Ned Deily  added the comment:

It very well could have something to do with Active Directory support.  Here's 
a little getgroups test I used a while back for a previous getgroups issue.  
You should see something similar in the output depending on the number of 
groups in your id.  If it fails, we can eliminate Python from the equation.


#include 
#include 
#include 

int main(){
gid_t grouplist[32];
int n;
int gidsetsize;

for(gidsetsize = 0; gidsetsize < 22; ++gidsetsize)
{
n = getgroups(gidsetsize, grouplist);
printf("calling grouplist with gidsetsize = %i, returns %i\n", 
gidsetsize, n);
}
exit(0);
}


calling grouplist with gidsetsize = 0, returns 14
calling grouplist with gidsetsize = 1, returns -1
calling grouplist with gidsetsize = 2, returns -1
calling grouplist with gidsetsize = 3, returns -1
calling grouplist with gidsetsize = 4, returns -1
calling grouplist with gidsetsize = 5, returns -1
calling grouplist with gidsetsize = 6, returns -1
calling grouplist with gidsetsize = 7, returns -1
calling grouplist with gidsetsize = 8, returns -1
calling grouplist with gidsetsize = 9, returns -1
calling grouplist with gidsetsize = 10, returns -1
calling grouplist with gidsetsize = 11, returns -1
calling grouplist with gidsetsize = 12, returns -1
calling grouplist with gidsetsize = 13, returns -1
calling grouplist with gidsetsize = 14, returns 14
calling grouplist with gidsetsize = 15, returns 14
calling grouplist with gidsetsize = 16, returns 14
calling grouplist with gidsetsize = 17, returns 14
calling grouplist with gidsetsize = 18, returns 14
calling grouplist with gidsetsize = 19, returns 14
calling grouplist with gidsetsize = 20, returns 14
calling grouplist with gidsetsize = 21, returns 14

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35077] Make TypeError message less ambiguous

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

Thanks for the report. Error message changes are generally done on master and 
not back ported. I am removing 3.5 which is security fixes only mode and adding 
3.8 . There are other errors of similar format but indicate the wrong type in 
the error message like list indices.

$ ./python.exe
Python 3.8.0a0 (heads/bpo31177-dirty:19986202a8, Oct 26 2018, 22:19:23)
[Clang 7.0.2 (clang-700.1.81)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> [1]['1']
Traceback (most recent call last):
  File "", line 1, in 
TypeError: list indices must be integers or slices, not str

I think we should also assert the error message in test_slice 
(Lib/test/string_tests.py) if there is a change.

Thanks Serhiy, I was about to add Raymond too who might have thoughts on the 
wording :)

--
nosy: +xtreak
versions: +Python 3.8 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35070] test_posix fails on macOS 10.14 Mojave

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

We're wondering if it could be a weird interaction with Active Directory.  This 
is my work laptop, so it's all integrated with LDAP and whatnot.  I don't have 
Mojave on my personal laptop yet (maybe this weekend).  I'm guessing that 
whatever corporate integration is going on is messing with getgroups(2).  Brett 
said he vaguely remembers something similar, but I don't remember seeing this 
problem on High Sierra on the same laptop.  I'm beta testing Mojave internally, 
so maybe this is just a weirdism I should report to our IT.

--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35059] Convert Py_INCREF() and PyObject_INIT() to inlined functions

[miss-islington]

miss-islington  added the comment:


New changeset 7eac88afd2e39d05a0ed3bc8c0787a2e755a6072 by Miss Islington (bot) 
in branch '3.6':
bpo-35059, libmpdec: Add missing EXTINLINE in mpdecimal.h (GH-10128)
https://github.com/python/cpython/commit/7eac88afd2e39d05a0ed3bc8c0787a2e755a6072


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35078] Allow customization of css class name of a month in calendar module

[శ్రీనివాస్ రెడ్డి తాటిపర్తి]

Change by Srinivas  Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) 
:


--
keywords: +patch
pull_requests: +9467
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35059] Convert Py_INCREF() and PyObject_INIT() to inlined functions

[miss-islington]

miss-islington  added the comment:


New changeset 95cfb818eaffba41333d4bc93253f4e0c6237ca8 by Miss Islington (bot) 
in branch '3.7':
bpo-35059, libmpdec: Add missing EXTINLINE in mpdecimal.h (GH-10128)
https://github.com/python/cpython/commit/95cfb818eaffba41333d4bc93253f4e0c6237ca8


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35078] Allow customization of css class name of a month in calendar module

[శ్రీనివాస్ రెడ్డి తాటిపర్తి]

Change by Srinivas  Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) 
:


--
components: Library (Lib)
nosy: thatiparthy
priority: normal
severity: normal
status: open
title: Allow customization of css class name of a month in  calendar module
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9263] Try to print repr() when an C-level assert fails (in the garbage collector, beyond?)

[Dave Malcolm]

Dave Malcolm  added the comment:

Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9263] Try to print repr() when an C-level assert fails (in the garbage collector, beyond?)

[STINNER Victor]

STINNER Victor  added the comment:

I pushed the change and even more, so I consider that the issue can now be 
closed... 8 years later! Thank you very much Dave Malcolm for this nice idea, 
and for its implementation. Thanks Bohuslav "Slavek" Kabrda for the rebase in 
2013, and thanks to my colleagues who rebased the patch frequently since 2013 
in the Fedora package!

Maybe some people (like me?) want to use _PyObject_ASSERT() in more places, but 
I consider that we don't need to leave this issue open just for that.


I took the 00170-gc-assertions.patch rebased on Python 3.7.1 by my colleagues 
for the Fedora package, and I rebased it on master. I modified more functions 
in object.c and typeobject.c to use _PyObject_ASSERT(). I tried to not replace 
all assert(), but only when it's revelant.

I added code to detect if the object memory has been freed to avoid derefering 
0xdbdbdbdbdbdbdbdb pointers which is very likely to cause a segmantation fault. 
It should reduce the risk of crash when dumping the faulty object.


Dave Malcolm:
> - Only tested on gcc-4.4.3 so far; the __STRING(expr) and __PRETTY_FUNCTION__ 
> look non-portable.

I used Py_STRINGIFY() and __func__ in the final patch. __func__ is part of the 
C99 standard which is now required since Python 3.6: see PEP 7.


Dave Malcolm:
> - no test case; I thought about using ctypes to extract PyObject_IncRef from 
> the implementation, but this is likely to lead to brittle test cases.  
> Alternatively, is xxmodule to be used for this kind of thing?

I reworked the unit test to not use ctypes, but write the crashing code in C 
instead.


Antoine Pitrou:
> How about turning these asserts into Py_FatalError()s and then enabling 
> Victor's faulthandler extension?

Done.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34576] [EASY doc] http.server, SimpleHTTPServer: warn users on security

[Senthil Kumaran]

Senthil Kumaran  added the comment:

This is resolved. Thank you, all.

--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34576] [EASY doc] http.server, SimpleHTTPServer: warn users on security

[Senthil Kumaran]

Senthil Kumaran  added the comment:


New changeset 8be1c043a6d10d375f7a73c681cb2d7ec2f2d361 by Senthil Kumaran in 
branch '3.6':
[3.6] - bpo-34576 : Backport eeab510 3.6 (GH-10113)
https://github.com/python/cpython/commit/8be1c043a6d10d375f7a73c681cb2d7ec2f2d361


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34576] [EASY doc] http.server, SimpleHTTPServer: warn users on security

[Senthil Kumaran]

Senthil Kumaran  added the comment:


New changeset bb1876acd815a05744cea4a7d4098231ef499e52 by Senthil Kumaran in 
branch '3.7':
[3.7]  bpo-34576 : Backport eeab510 (#10114)
https://github.com/python/cpython/commit/bb1876acd815a05744cea4a7d4098231ef499e52


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35059] Convert Py_INCREF() and PyObject_INIT() to inlined functions

[miss-islington]

Change by miss-islington :


--
pull_requests: +9466

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35059] Convert Py_INCREF() and PyObject_INIT() to inlined functions

[miss-islington]

Change by miss-islington :


--
pull_requests: +9465

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35077] Make TypeError message less ambiguous

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32173] linecache.py add lazycache to __all__ and use dict.clear to clear the cache

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Since all proposed PRs just change formatting, I suggest to close this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35059] Convert Py_INCREF() and PyObject_INIT() to inlined functions

[STINNER Victor]

STINNER Victor  added the comment:

> Too bad: this change broke the compilation on AMD64 Windows7 SP1 3.x, AMD64 
> Windows8 3.x and AMD64 Windows10 3.x: (...)

I checked buildbots: my PR 10128 fixed all Windows buildbots, good.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com