[issue33052] Sporadic segmentation fault in test_datetime

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

Related discussion with same segfault in Travis CI : issue33701

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[miss-islington]

miss-islington  added the comment:


New changeset 60cf26528b931215160a53fd61836dbe4f036009 by Miss Islington (bot) 
in branch '3.6':
bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. (GH-10503)
https://github.com/python/cpython/commit/60cf26528b931215160a53fd61836dbe4f036009


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[miss-islington]

miss-islington  added the comment:


New changeset f6602f92664b782125a1ec5009706f9300fe7e80 by Miss Islington (bot) 
in branch '3.7':
bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. (GH-10503)
https://github.com/python/cpython/commit/f6602f92664b782125a1ec5009706f9300fe7e80


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[miss-islington]

Change by miss-islington :


--
pull_requests: +9765

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Gregory P. Smith]

Gregory P. Smith  added the comment:


New changeset 3015fb8ce4d25603434b9b44bb7effb98a481532 by Gregory P. Smith in 
branch 'master':
bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. (GH-10503)
https://github.com/python/cpython/commit/3015fb8ce4d25603434b9b44bb7effb98a481532


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[miss-islington]

Change by miss-islington :


--
pull_requests: +9764

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Gregory P. Smith]

Gregory P. Smith  added the comment:

> Can we prefix MEMORY_SANITIZER with _Py_?

Yes, I wondered if I should do that.  not that I expect anyone would ever 
define it to mean anything else, but that seems like the right thing to do.  
https://github.com/python/cpython/pull/10503

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35224] PEP 572: Assignment Expressions

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Gregory P. Smith]

Change by Gregory P. Smith :


--
pull_requests: +9763

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Gregory P. Smith]

Gregory P. Smith  added the comment:

yeah, i've been surprised how far i was able to get from an oss CPython tree 
and pre-built clang 7 binary installation.  If you have headers installed for 
common libraries like libssl-dev and libreadline-dev you can't produce an 
interpreter that'll work as those both lead to quick crashes.  also, in my 
experience optimized builds tend to be more problematic (too early to say if 
what i'm seeing are actual problems).

also, make sure llvm-symbolize (no suffixes) is in your path for it to 
auto-symbolize the traces showing you where in the code it pointed out issues.  
when it points within shared libraries instead of the Python source tree - 
that's a hint that the library probably may need msan compilation.

I'm plodding through things to see if I can get a _useful_ buildbot setup (i 
don't care of some extension modules can't be covered for now) out of all of 
this.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[miss-islington]

Change by miss-islington :


--
pull_requests: +9762

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[miss-islington]

Change by miss-islington :


--
pull_requests: +9761

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Thanks @alex! I will try again after linking against ASAN-compiled version of 
my libraries.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Alex Gaynor]

Alex Gaynor  added the comment:

All libraries that are linked against, including libc, need to be compiled with 
MSAN. MSAN is not for the faint of heart.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

I cannot initialize the interpreter after compiling with 
--with-memory-sanitizer:

❯ CC=clang ./configure  --with-memory-sanitizer && make -j
❯ ./python
Python 3.8.0a0 (heads/master:1584a00815, Nov 13 2018, 03:29:18)
[Clang 7.0.0 (tags/RELEASE_700/final)] on linux
Type "help", "copyright", "credits" or "license" for more information.
==10989==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x5592f18005c3  (/home/pablogsal/cpython/python+0x9a55c3)
#1 0x5592f175c176  (/home/pablogsal/cpython/python+0x901176)
#2 0x5592f17592da  (/home/pablogsal/cpython/python+0x8fe2da)
#3 0x5592f1750f82  (/home/pablogsal/cpython/python+0x8f5f82)
#4 0x5592f174a336  (/home/pablogsal/cpython/python+0x8ef336)
#5 0x5592f174c906  (/home/pablogsal/cpython/python+0x8f1906)
#6 0x5592f14ae214  (/home/pablogsal/cpython/python+0x653214)
#7 0x5592f14a6915  (/home/pablogsal/cpython/python+0x64b915)
#8 0x5592f14a293c  (/home/pablogsal/cpython/python+0x64793c)
#9 0x5592f0f5ad88  (/home/pablogsal/cpython/python+0xffd88)
#10 0x5592f0f5ce73  (/home/pablogsal/cpython/python+0x101e73)
#11 0x5592f0f4d908  (/home/pablogsal/cpython/python+0xf2908)
#12 0x7fd1a7381222  (/usr/lib/libc.so.6+0x24222)
#13 0x5592f0ed3cdd  (/home/pablogsal/cpython/python+0x78cdd)

  Uninitialized value was created by a heap allocation
#0 0x5592f0f02a0d  (/home/pablogsal/cpython/python+0xa7a0d)
#1 0x7fd1a73cd790  (/usr/lib/libc.so.6+0x70790)

SUMMARY: MemorySanitizer: use-of-uninitialized-value 
(/home/pablogsal/github/cpython/python+0x9a55c3)
Exiting

❯ clang --version
clang version 7.0.0 (tags/RELEASE_700/final)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

❯ /lib/libc.so.6
GNU C Library (GNU libc) stable release version 2.28.
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
Compiled by GNU CC version 8.2.1 20180831.
libc ABIs: UNIQUE IFUNC ABSOLUTE
For bug reporting instructions, please see:
.

I am missing something or is this expected (as there are more PRs to come)?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33944] Deprecate and remove pth files

[Ivan Pozdeev]

Ivan Pozdeev  added the comment:

> I’m a little concerned about this approach because it means random third 
> party modules can affect the global environment for your application, without 
> knowing it.  Since the hook installation happens at import time, and just 
> depending on a library that has such a .pth file will install it, the end 
> application will not have control over its global state.
But "affecting the global environment for your application" is exactly 
what is intended here. You want multiple packages to all load their code 
into the same namespaces (aka module objects), thus of course 
potentially affecting/overriding each other's functionality. That's what 
you get when you have plugins -- a badly-written/incompatible plugin can 
and will break your app.

It doesn't have to "just depend on a library that has such a .pth file", 
it's up to the import hook's implementation. I just gave as example the 
simplest solution that requires zero effort on the main package 
maintainer's part.

E.g. you can only allow adding a new submodule by default, or require 
the "parent" package to "allow" insertions into itself, or move 
registration into the parent's configuration file (so the user needs to 
enable the plugin manually), or provide some more granular code 
injection techniques like e.g. event handler lists that certain plugins' 
functions will be added into. All that matters here is that the hook is 
going to automagically assemble the resulting namespaces from parts upon 
import.

Finally, Python applications don't have full control over their global 
state anyway. Any module can monkey-patch or override any other module 
via a variety of means. So, this risk is not something new or unexpected.

--
nosy: +__Vano

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35221] Enhance venv activate commands readability

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31541] Mock called_with does not ensure self/cls argument is used

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Will

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31541] Mock called_with does not ensure self/cls argument is used

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
Removed message: https://bugs.python.org/msg329801

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31541] Mock called_with does not ensure self/cls argument is used

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

I agree with Karthikeyan: This is is the expected behaviour. The moment you use 
a mock, any implementation details are lost unless you use wraps or similar to 
also transfer the call to the/a real object.

--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35215] Replacing CPython memory allocation

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

> The point of this 'issue' is to ask the community to suggest how i can go 
> about finding where the problem is. As I said, there is a lot of code :)

Sadly, this tracker is to track bugs related to CPython. Modifying the 
interpreter to change the memory allocation scheme (replacing the code in 
obmalloc.c) is not supported, so I have to close this issue :(

You can try to ask the question on some of the mailing lists (like python-dev) 
to see is someone can help you with this. I would advice to also provide some 
minimal reproducer/example code, as is very difficult to recommend anything 
without knowing what exactly are you modifying.

If you think there is something wrong/we can improve around this area, please, 
feel free to reopen this issue or open a new one :)

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Benjamin Peterson]

Benjamin Peterson  added the comment:

Can we prefix MEMORY_SANITIZER with _Py_?

--
nosy: +benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Gregory P. Smith]

Change by Gregory P. Smith :


--
pull_requests: +9760

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35225] test_faulthandler fails under ubsan

[Benjamin Peterson]

New submission from Benjamin Peterson :

The UBsan buildbot is failing test_faulthandler. We should either spread some 
__attribute__((no_sanitize_undefined)) around or make the tests skip.

==
FAIL: test_enable_fd (test.test_faulthandler.FaultHandlerTests)
--
Traceback (most recent call last):
  File 
"/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Lib/test/test_faulthandler.py",
 line 274, in test_enable_fd
self.check_fatal_error("""
  File 
"/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Lib/test/test_faulthandler.py",
 line 115, in check_fatal_error
self.check_error(code, line_number, fatal_error, **kw)
  File 
"/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Lib/test/test_faulthandler.py",
 line 108, in check_error
output, exitcode = self.get_output(code, filename=filename, fd=fd)
  File 
"/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Lib/test/test_faulthandler.py",
 line 73, in get_output
self.assertEqual(output, '')
AssertionError: 'UndefinedBehaviorSanitizer:DEADLYSIGNAL\n[2619 chars]TING' != 
''
Diff is 2693 characters long. Set self.maxDiff to None to see it.
==
FAIL: test_enable_file (test.test_faulthandler.FaultHandlerTests)
--
Traceback (most recent call last):
  File 
"/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Lib/test/test_faulthandler.py",
 line 258, in test_enable_file
self.check_fatal_error("""
  File 
"/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Lib/test/test_faulthandler.py",
 line 115, in check_fatal_error
self.check_error(code, line_number, fatal_error, **kw)
  File 
"/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Lib/test/test_faulthandler.py",
 line 108, in check_error
output, exitcode = self.get_output(code, filename=filename, fd=fd)
  File 
"/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Lib/test/test_faulthandler.py",
 line 68, in get_output
self.assertEqual(output, '')
AssertionError: 'UndefinedBehaviorSanitizer:DEADLYSIGNAL\n[2619 chars]TING' != 
''
Diff is 2693 characters long. Set self.maxDiff to None to see it.
==
FAIL: test_sigfpe (test.test_faulthandler.FaultHandlerTests)
--
Traceback (most recent call last):
  File 
"/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Lib/test/test_faulthandler.py",
 line 176, in test_sigfpe
self.check_fatal_error("""
  File 
"/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Lib/test/test_faulthandler.py",
 line 115, in check_fatal_error
self.check_error(code, line_number, fatal_error, **kw)
  File 
"/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Lib/test/test_faulthandler.py",
 line 110, in check_error
self.assertRegex(output, regex)
AssertionError: Regex didn't match: '^Fatal Python error: Floating point 
exception\n\nCurrent thread 0x[0-9a-f]+ \\(most recent call first\\):\n  File 
"", line 3 in ' not found in 'Modules/faulthandler.c:1059:11: 
runtime error: division by zero\nFatal Python error: Floating point 
exception\n\nCurrent thread 0x7f14c5e81740 (most recent call first):\n  
File "", line 3 in 
\nUndefinedBehaviorSanitizer:DEADLYSIGNAL\n==5027==ERROR: 
UndefinedBehaviorSanitizer: FPE on unknown address 0x006d13a3 (pc 
0x7f14c5355f9f bp 0x02f485a0 sp 0x02f698e8 T5027)\n#0 
0x7f14c5355f9e in gsignal (/lib/x86_64-linux-gnu/libpthread.so.0+0x10f9e)\n
#1 0x7f14c53560bf  (/lib/x86_64-linux-gnu/libpthread.so.0+0x110bf)\n#2 
0x829906 in faulthandler_sigfpe 
/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/./Modules/faulthandler.c:1059:11\n
#3 0x4707c3 in _PyMethodDef_RawFastCallKeywords 
/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Objects/call
 .c\n#4 0x46e5d1 in _PyCFunction_FastCallKeywords 
/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Objects/call.c:730:14\n 
   #5 0x656805 in call_function 
/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Python/ceval.c:4570:9\n 
   #6 0x64b0d6 in _PyEval_EvalFrameDefault 
/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Python/ceval.c:3164:23\n
#7 0x6596be in _PyEval_EvalCodeWithName 
/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Python/ceval.c:3946:14\n
#8 0x6384ee in PyEval_EvalCodeEx 
/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Python/ceval.c:3975:12\n
#9 0x6384ee in PyEval_EvalCode 
/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Python/ceval.c:508\n
#10 0x6e816e in run_mod 
/var/lib/buildbot/clang-ubsan/3.x.gps-clang-ubsan/build/Python/pythonrun.c:1030:9\n
#11 0x6e816e in PyRun_StringFlags 

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Alex Gaynor]

Change by Alex Gaynor :


--
nosy: +alex

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35219] macOS 10.14 Mojave crashes in multiprocessing

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

Nope, actually double fork doesn't work.  It's misleading because in my 
testing, the first invocation of the process causes the core dump, but 
subsequent runs do not.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35219] macOS 10.14 Mojave crashes in multiprocessing

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

I'm still testing this solution, but it looks like if you set the environment 
variable, and then double fork, the granchild won't crash.  Roughly:

os.putenv('OBJC_DISABLE_INITIALIZE_FORK_SAFETY', 'YES')
pid = os.fork()
if pid == 0:
subpid = os.fork()
if subpid == 0:
# I'm in a safe grandchild

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[Windson Yang]

Windson Yang  added the comment:

I will work on it today :D

--
nosy: +Windson Yang

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35195] Pandas read_csv() is 3.5X Slower on Python 3.7.1 vs Python 3.6.7 & 3.5.2 On Windows 10

[Christoph Gohlke]

Christoph Gohlke  added the comment:

> test_isdigit.c: Can you try to call locale.setlocale(locale.LC_CTYPE, "") 
> before running your benchmark on Python 3.7.0?

Yes, that slows down Python 3.7.0a3 to the 3.7.0a4 level.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35195] Pandas read_csv() is 3.5X Slower on Python 3.7.1 vs Python 3.6.7 & 3.5.2 On Windows 10

[STINNER Victor]

STINNER Victor  added the comment:

> This issue may be related to bpo-34485.

I'm thinking to:

New changeset 177d921c8c03d30daa32994362023f777624b10d by Victor Stinner in 
branch 'master':
bpo-34485, Windows: LC_CTYPE set to user preference (GH-8988)
https://github.com/python/cpython/commit/177d921c8c03d30daa32994362023f777624b10d

Oh, I only made this change in the future Python 3.8 (master branch). So this 
change may be unrelated.

Note: Right now, my Windows VM is broken, so I cannot investigate this 
performance issue which seems to be specific to the msvcrt (libc of Microsoft 
VisualStudio).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35195] Pandas read_csv() is 3.5X Slower on Python 3.7.1 vs Python 3.6.7 & 3.5.2 On Windows 10

[STINNER Victor]

STINNER Victor  added the comment:

test_isdigit.c: Can you try to call locale.setlocale(locale.LC_CTYPE, "") 
before running your benchmark on Python 3.7.0?

This issue may be related to bpo-34485.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35195] Pandas read_csv() is 3.5X Slower on Python 3.7.1 vs Python 3.6.7 & 3.5.2 On Windows 10

[Christoph Gohlke]

Christoph Gohlke  added the comment:

I attached a minimal C extension module that can be used to demonstrate the 
performance degradation from Python 3.7.0a3 to 3.7.0a4.

Build the extension with `py setup.py build_ext --inplace`, then run the 
following code on Python 3.7.0a3 to 3.7.0a4:

```
import time
from test_isdigit import test_isdigit

start_time = time.time()
test_isdigit()
print(time.time() - start_time)
```

On my Windows 10 Pro WS system, the timings are:

Python 3.7.0a3: ~0.0156
Python 3.7.0a4: ~0.3281


I would expect that other locale aware functions in the UCRT are also affected 
but I have not tested that.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35195] Pandas read_csv() is 3.5X Slower on Python 3.7.1 vs Python 3.6.7 & 3.5.2 On Windows 10

[STINNER Victor]

STINNER Victor  added the comment:

> digits = ''.join([str(i) for i in range(10)]*1000)
> %timeit digits.isdigit() # --> 2X+ slower on python 3.7.1

This code calls:

* (Python) str.isdigit()
* unicode_isdigit_impl()
* _PyUnicode_IsDigit()
* _PyUnicode_ToDigit() which uses Python internal Unicode database

This code doesn't depend on locales at all. It's pure Unicode.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29564] ResourceWarning: suggest to enable tracemalloc in the message

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 2c07c493d2eb45101312e3eb3a77f94d0c9cad1f by Victor Stinner in 
branch 'master':
bpo-29564: warnings suggests to enable tracemalloc (GH-10486)
https://github.com/python/cpython/commit/2c07c493d2eb45101312e3eb3a77f94d0c9cad1f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35195] Pandas read_csv() is 3.5X Slower on Python 3.7.1 vs Python 3.6.7 & 3.5.2 On Windows 10

[Dragoljub]

Dragoljub  added the comment:

Here is a simple pure python example:

digits = ''.join([str(i) for i in range(10)]*1000)
%timeit digits.isdigit() # --> 2X+ slower on python 3.7.1

Basically in Pandas C-code parser we call the isdigit() function for each 
number that is to be parsed. so 12345.6789 calls isdigt() 9 times to determine 
if this is a digit character that can be converted to a float. The problem is 
in the latest version of Python with locale updates isdigit() takes a locale 
argument that seems to be passed over and over slowing down this check. Is it 
possible that we disable any local passing from Python down to lower-level C 
code, or simply set the default locale to 'C' to keep it from thrashing?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35195] Pandas read_csv() is 3.5X Slower on Python 3.7.1 vs Python 3.6.7 & 3.5.2 On Windows 10

[Christoph Gohlke]

Change by Christoph Gohlke :


Added file: https://bugs.python.org/file47929/setup.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35195] Pandas read_csv() is 3.5X Slower on Python 3.7.1 vs Python 3.6.7 & 3.5.2 On Windows 10

[Christoph Gohlke]

Change by Christoph Gohlke :


Added file: https://bugs.python.org/file47928/test_isdigit.c

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35224] PEP 572: Assignment Expressions

[Eric V. Smith]

Change by Eric V. Smith :


--
nosy: +eric.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35195] Pandas read_csv() is 3.5X Slower on Python 3.7.1 vs Python 3.6.7 & 3.5.2 On Windows 10

[Christoph Gohlke]

Christoph Gohlke  added the comment:

> Can someone please try to write an example which only uses the stdlib?

The simplest is to compare performance of the 
`windll.LoadLibrary('API-MS-WIN-CRT-STRING-L1-1-0.DLL')` function on Python 
3.7.0a3 and 3.7.0a4, but that will mostly measure Python/ctypes overhead. I 
will post a minimal C extension instead.


> What are these extensions? Where do them come from?

The `isdigit` function is from the UCRT. The `parsers` Cython/C extension is 
part of the pandas wheel on PyPI. The context for this issue is at 
https://github.com/pandas-dev/pandas/issues/23516


> I don't understand which "locale changes" you are talking about. You can 
> change the locale using locale.setlocale().

The `UCRT.isdigit` function, when run on Python >=3.7.0a4, calls the 
`_isdigit_l` function, which calls `_LocaleUpdate::_LocaleUpdate` (see the VS 
profiler output).

--
nosy: +cgohlke

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

[miss-islington]

miss-islington  added the comment:


New changeset 3f9fe53c98978955fea4e36456c784694e6458a8 by Miss Islington (bot) 
in branch '3.7':
bpo-35031: Fix test_start_tls_server_1 on FreeBSD buildbots (GH-10011)
https://github.com/python/cpython/commit/3f9fe53c98978955fea4e36456c784694e6458a8


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35219] macOS 10.14 Mojave crashes in multiprocessing

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

Based on my testing, the environment variable has to be set before the parent 
process starts.  Neither os.environ nor os.putenv seem to do the trick.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35224] PEP 572: Assignment Expressions

[Emily Morehouse]

Change by Emily Morehouse :


--
keywords: +patch
pull_requests: +9758
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35224] PEP 572: Assignment Expressions

[Emily Morehouse]

Change by Emily Morehouse :


--
keywords: +patch, patch
pull_requests: +9758, 9759
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35223] Pathlib incorrectly merges strings.

[Roffild]

Roffild  added the comment:

It is necessary to assemble a single path from several lines depending on the 
OS.

It is logical to expect behavior in Java.
https://docs.oracle.com/javase/8/docs/api/java/nio/file/Paths.html
Converts a path string, or a sequence of strings that when joined form a path 
string, to a Path. If more does not specify any elements then the value of the 
first parameter is the path string to convert. If more specifies one or more 
elements then each non-empty string, including first, is considered to be a 
sequence of name elements (see Path) and is joined to form a path string. The 
details as to how the Strings are joined is provider specific but typically 
they will be joined using the name-separator as the separator. For example, if 
the name separator is "/" and getPath("/foo","bar","gus") is invoked, then the 
path string "/foo/bar/gus" is converted to a Path. A Path representing an empty 
path is returned if first is the empty string and more does not contain any 
non-empty strings.

My temporary fix is something like this:
print("\\".join(["C:/123\\345", "\\", "folder///filename.bin"]).replace("/", 
"\\").replace("", "\\").replace("", "\\"))

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

[miss-islington]

Change by miss-islington :


--
pull_requests: +9757

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35222] email.utils.formataddr is not exactly the reverse of email.utils.parseaddr

[skreft]

skreft  added the comment:

@r.david.murray where do you see that those functions are only defined for 
ascii? There's nothing in the online docs stating that and furthermore 
`formataddr` has supported non-ascii names since version 3.3. RFC 2822 is 
however mentioned in the docstrings.

The fact that `formataddr` is not really the inverse warrants at least a note 
or clarification in the docs.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32492] C Fast path for namedtuple's property/itemgetter pair

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests:  -9755

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32492] C Fast path for namedtuple's property/itemgetter pair

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests:  -9756

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32492] C Fast path for namedtuple's property/itemgetter pair

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +9754, 9755

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32492] C Fast path for namedtuple's property/itemgetter pair

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +9754, 9755, 9756

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32492] C Fast path for namedtuple's property/itemgetter pair

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +9754

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35224] PEP 572: Assignment Expressions

[Emily Morehouse]

New submission from Emily Morehouse :

This issue will serve to track development and PRs for the implementation of 
PEP 572: Assignment Expressions.

--
assignee: emilyemorehouse
components: Interpreter Core
messages: 329781
nosy: emilyemorehouse, gvanrossum, tim.peters
priority: normal
severity: normal
status: open
title: PEP 572: Assignment Expressions
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35219] macOS 10.14 Mojave crashes in multiprocessing

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

I've done a fair bit of testing and it seems rather inconsistent as to whether 
either of these work when added right before an explicit call to `os.fork()`:

os.environ['OBJC_DISABLE_INITIALIZE_FORK_SAFETY'] = 'YES'

ctyles.cdll.LoadLibrary('/System/Library/Frameworks/Foundation.framework/Foundation')

Neither of these seems to reliably prevent the __NSPlaceholderDate warning, nor 
prevent the core dumps.  The best I've been able to do is to prevent them by 
setting the environment variable *before* the parent process starts (i.e. 
outside of the Python code of the process).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35223] Pathlib incorrectly merges strings.

[Eric V. Smith]

Eric V. Smith  added the comment:

As far as which path components are returned, I think this is working as 
designed. The documentation for os.path.join says:

"""
If a component is an absolute path, all previous components are thrown away and 
joining continues from the absolute path component.

On Windows, the drive letter is not reset when an absolute path component 
(e.g., r'\foo') is encountered.
"""

pathlib's documentation for creating PurePath objects says:

"""
When several absolute paths are given, the last is taken as an anchor 
(mimicking os.path.join()’s behaviour)
"""

--
nosy: +eric.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35215] Replacing CPython memory allocation

[paul]

paul  added the comment:

Hi guys, 

First, thanks for the prompt replies. 

@matrixise: If there is i can't find it, but i am happy to accept it as a 
possibility. Equally, maybe there is an assumption about memory in the cpython 
implementation somewhere that goes against my memory allocator -> this is 
obviously not cpythons fault. The point of this 'issue' is to ask the community 
to suggest how i can go about finding where the problem is. As i said, there is 
a lot of code :)

@pablogsal: Yeah. I had a look in there. In cpython, i have made all 
allocations from obmalloc use my memory allocation functions, including the 
arenas. 

Perhaps a starting point would be if anyone has ideas about how to go about 
debugging this??

best, 

Paul

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Gregory P. Smith]

Gregory P. Smith  added the comment:


New changeset 3b5b1c0931cd32253bbf2f3bd74e90ff821e026e by Gregory P. Smith in 
branch '3.6':
[3.6] bpo-35214: Initial clang MemorySanitizer support (GH-10479) (GH-10493)
https://github.com/python/cpython/commit/3b5b1c0931cd32253bbf2f3bd74e90ff821e026e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35223] Pathlib incorrectly merges strings.

[Roffild]

New submission from Roffild :

Code:
import os
print(os.path.join("C:/123\\345", "\\", "folder///filename.bin"))
import pathlib
print(pathlib.PureWindowsPath("C:/123\\345", "\\", "folder///filename.bin"))

Result:
C:\folder///filename.bin
C:\folder\filename.bin

Expected result for Windows:
C:\123\345\folder\filename.bin

The number of slashes should be controlled by the library. Replacing / on \ 
should also depend on the OS.

--
components: IO, Library (Lib), Windows
messages: 329776
nosy: Roffild, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Pathlib incorrectly merges strings.
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35222] email.utils.formataddr is not exactly the reverse of email.utils.parseaddr

[R. David Murray]

R. David Murray  added the comment:

Thanks for the report, but parseaddr and formataddr are defined *only* for 
ASCII.  In the port to python3, parseaddr sort-of-maybe-sometimes does the 
naively expected thing with non-ascii, but that's just an accident.  We could 
have added a check for non-ascii to parseaddr during the python3 port, but we 
didn't think of it, and it is too late now since adding it would break 
otherwise working code even though that code is technically broken.

So, for the defined API of parseaddr/formataddr, there is no bug here.

As for handling non-ascii in email per your link:

>>> from email.message import EmailMessage
>>> from email.policy import default
>>> m = EmailMessage(policy=default.clone(utf8=True))
>>> m['From'] = 'skreft+ñandú@sudoai.com
>>> bytes(m)
b'From: skreft+\xc3\xb1and\xc3\x...@sudoai.com\n\n'

(NB: in testing the above I discovered there is actually a recent bug in the 
serialization when utf8 is *False*: it does RFC2047 encoding of the username, 
which it should not do...instead it should raise an error.  Feel free to open a 
bug report for that...)

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[Gregory P. Smith]

Gregory P. Smith  added the comment:

it still seems relevant, having better docs is always good.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[Lysandros Nikolaou]

Lysandros Nikolaou  added the comment:

It's been more than 3 years, since this was opened, but I will ask 
nevertheless. Should a PR maybe made for this issue?

--
nosy: +lys.nikolaou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35222] email.utils.formataddr is not exactly the reverse of email.utils.parseaddr

[Rémi Lapeyre]

Rémi Lapeyre  added the comment:

This is indeed an issue with formataddr, it expects the input to be ascii 
encoded as RFC 2822 requires.

Email is much more complicated though and has been internationalized, a summary 
of this work is available at 
https://en.wikipedia.org/wiki/Email_address#Internationalization.

I think the check in formataddr is not desirable anymore and should be remove.

I'm not sure wether the resulting value should be encoded using email.header or 
not.

--
nosy: +remi.lapeyre

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10486] http.server doesn't set all CGI environment variables

[Rémi Lapeyre]

Rémi Lapeyre  added the comment:

AUTH_TYPE, CONTENT_LENGTH, CONTENT_TYPE, REMOTE_USER are present

REMOTE_IDENT is not but I'm not sure it's worth adding.

I can send a PR to add REMOTE_HOST and remove the condition for QUERY_STRING.

Otherwise, I don't think the other environment variables should be added, they 
are implementation dependant and not defined in RFC 3875.

Should we close this issue?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22393] multiprocessing.Pool shouldn't hang forever if a worker process dies unexpectedly

[Oscar Esteban]

Oscar Esteban  added the comment:

I tried to reuse as much as I could from the patch, but it didn't solve the 
issue at first.

I have changed the responsibility of identifying and prescribing a solution 
when a worker got killed. In the proposed patch, the thread handling results 
(i.e. tasks queued by one worker as done) was responsible. In the PR, the 
responsibility is reassigned to the thread handling workers (since, basically, 
one or more workers suddenly die).

The patch defined a new BROKEN state that was assigned to the results handler 
thread. I transferred this behavior to the worker handler thread. But, I'm 
guessing that the BROKEN state should be assigned to the Pool object instead, 
to be fully semantic. Although that would require passing the reference to the 
object around and complicate unnecessarily the implementation. Happy to 
reconsider though.

I added three tests, one that was present with the patch, a variation of it 
adding some wait before killing the worker, and the one that Francis Bolduc 
posted here (https://bugs.python.org/issue22393#msg294968).

Please let me know whether any conversation about this bug should take place in 
GitHub, with the PR instead of here.

Thanks a lot for the guidance, Antoine.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35221] Enhance venv activate commands readability

[Lisa Roach]

Lisa Roach  added the comment:

Using plain angle brackets is common placeholder notation, and I think changing 
it to something different might be confusing to those who are familiar with the 
pattern. I have also seen plenty of people copying and pasting the wrong things 
because of this notation, but I agree with Steven that it is a part of the 
learning process that we all go through.

Perhaps just adding the line ' must be replaced by the path of the 
directory containing the virtual environment' would suffice to clarify?

--
nosy: +lisroach

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35221] Enhance venv activate commands readability

[Steven D'Aprano]

Steven D'Aprano  added the comment:

https://docs.python.org/3/library/venv.html

> my students are often confused by it, sometimes they copy the angle brackets, 
> sometime even the prompt.

Learning to recognise placeholders and the prompt is an essential part of 
learning to code, and a stage that everyone has to go through. Replacing plain 
text markup with styled formatting doesn't change that, but it does make it 
harder for the blind or visually impaired who are using screen-readers, or 
those who prefer to use a plain text interface with no support for bold/italic.

How do your enhancements look in w3m, links or linx? The current design renders 
nicely in plain text on links. (I haven't checked the other two.)


> I ran a few tests.

What sort of tests? Usability tests? What results did you get?


> Someone on #python-fr proposed 
> https://framapic.org/XnBQZcJVRlZw/F05D7I8nSKd0.png

Link doesn't work for me. I get a blank page.

--
nosy: +steven.daprano

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35222] email.utils.formataddr is not exactly the reverse of email.utils.parseaddr

[skreft]

New submission from skreft :

The docs 
(https://docs.python.org/3/library/email.util.html#email.utils.formataddr) say 
that formataddr is the inverse of parseaddr, however non-ascii email addresses 
are treated differently in both methods.

parseaddr will return non-ascci addresses, whereas formataddr will raise a 
UnicodeError.

Below is an example:

In [1]: import email.utils as u

In [2]: u.parseaddr('skreft+ñandú@sudoai.com')
Out[2]: ('', 'skreft+ñandú@sudoai.com')

In [3]: u.formataddr(u.parseaddr('skreft+ñandú@sudoai.com'))
---
UnicodeEncodeErrorTraceback (most recent call last)
 in ()
> 1 u.formataddr(u.parseaddr('skreft+ñandú@sudoai.com'))

/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/email/utils.py 
in formataddr(pair, charset)
 89 name, address = pair
 90 # The address MUST (per RFC) be ascii, so raise a UnicodeError if 
it isn't.
---> 91 address.encode('ascii')
 92 if name:
 93 try:

UnicodeEncodeError: 'ascii' codec can't encode character '\xf1' in position 7: 
ordinal not in range(128)

--
components: email
messages: 329765
nosy: barry, r.david.murray, skreft
priority: normal
severity: normal
status: open
title: email.utils.formataddr is not exactly the reverse of 
email.utils.parseaddr
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33944] Deprecate and remove pth files

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

On Nov 10, 2018, at 04:50, Ivan Pozdeev  wrote:

> In its .pth file, each such package will import the hook's module (which will 
> cause the hook to be installed on the first import) and "register" its 
> namespaces and/or dependencies with it. The hook will then calculate the 
> required load order and enforce it upon import of any of the registered 
> namespaces.

I’m a little concerned about this approach because it means random third party 
modules can affect the global environment for your application, without knowing 
it.  Since the hook installation happens at import time, and just depending on 
a library that has such a .pth file will install it, the end application will 
not have control over its global state.  It’s not possible to know whether this 
is a serious problem, but in the past, global state changes are problematic 
when applications do not have control over it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23930] http.cookies.SimpleCookie doesn't parse comma-only separated cookies correctly

[Rémi Lapeyre]

Change by Rémi Lapeyre :


--
keywords: +patch
pull_requests: +9752
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10486] http.server doesn't set all CGI environment variables

[Rémi Lapeyre]

Rémi Lapeyre  added the comment:

The reference given in 
https://github.com/python/cpython/blob/b36b0a3765bcacb4dcdbf12060e9e99711855da8/Lib/http/server.py#L1074
 is not accessible anymore.

I think we should replace it by https://tools.ietf.org/html/rfc3875#section-4.1

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35221] Enhance venv activate commands readability

[Julien Palard]

Julien Palard  added the comment:

Forgot to mention, the bold and italics one were done using unicode 
mathematical characters, they are not properly rendered in PDFs so we can't use 
them as is: https://mdk.fr/pdf.png

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35221] Enhance venv activate commands readability

[Julien Palard]

New submission from Julien Palard :

I'd like to enhance the readability of the "venv activation commands" in 
library/venv.html, my students are often confused by it, sometimes they copy 
the angle brackets, sometime even the prompt.

I don't think we can fix everything, but maybe enhance a bit, I ran a few tests.

Before modification: 
https://screenshotscdn.firefoxusercontent.com/images/77cf6612-1934-4a3b-9376-87a012a76bc3.png

First try with a :file:, not better: 
https://screenshotscdn.firefoxusercontent.com/images/db4e1191-a740-4828-b53a-ccc4a8d33dae.png

Second try, simply double backquotes:
https://screenshotscdn.firefoxusercontent.com/images/d6be92a1-e4af-40f5-9281-d9c09d8a0908.png

Third try using bold but it hurt the eyes:
https://screenshotscdn.firefoxusercontent.com/images/6fb1026f-064b-41dd-822b-3b258e37a85e.png

4th try using simply capslock, maybe better:
https://screenshotscdn.firefoxusercontent.com/images/9e9c3f7b-639c-4f26-abcc-20948e15a65d.png

5th try using capslock and italics, I like it:
https://screenshotscdn.firefoxusercontent.com/images/b5ae5582-1706-4ea9-a702-910daf2c69bc.png

Someone on #python-fr proposed 
https://framapic.org/XnBQZcJVRlZw/F05D7I8nSKd0.png (rendered from markdown in 
github). I like it but it would require a specific role to render bold-italic 
in code block.

--
assignee: mdk
components: Documentation
messages: 329762
nosy: mdk
priority: normal
severity: normal
status: open
title: Enhance venv activate commands readability

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Gregory P. Smith]

Change by Gregory P. Smith :


--
pull_requests: +9751

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35216] misleading error message from shutil.copy()

[Julien Palard]

Julien Palard  added the comment:

Using `cp` on Debian Buster I'm having a better error message:

$ touch foo
$ cp foo bar/
cp: failed to access 'bar/': Not a directory

>From copy.c (from Debian coreutils):

/* Improve quality of diagnostic when a nonexistent dst_name
   ends in a slash and open fails with errno == EISDIR.  */
if (dest_desc < 0 && dest_errno == EISDIR
&& *dst_name && dst_name[strlen (dst_name) - 1] == '/')
  dest_errno = ENOTDIR;

--
nosy: +mdk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35219] macOS 10.14 Mojave crashes in multiprocessing

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

I'm not sure whether it's a duplicate or not, since in my case it doesn't hang, 
but instead core dumps.  It's seems like the reasoning given in the Ruby bug is 
relevant to Python too, so maybe we should adopt the same workaround.  For our 
internal projects, I'm probably just going to set the environment variable for 
now.

I'd love to know what Ned and Ronald thing, thus cc'ing them.

--
nosy: +ned.deily, ronaldoussoren

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Gregory P. Smith]

Gregory P. Smith  added the comment:


New changeset 5f4d05d83fde05fed0b6554d0beee4f1c1f1d8f1 by Gregory P. Smith in 
branch '3.7':
[3.7] bpo-35214: Initial clang MemorySanitizer support (GH-10479) (GH-10492)
https://github.com/python/cpython/commit/5f4d05d83fde05fed0b6554d0beee4f1c1f1d8f1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33725] High Sierra hang when using multi-processing

[Barry A. Warsaw]

Change by Barry A. Warsaw :


--
nosy: +barry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35219] macOS 10.14 Mojave crashes in multiprocessing

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

This can a duplicate of https://bugs.python.org/issue33725

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35219] macOS 10.14 Mojave crashes in multiprocessing

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Apparently, GitLab have a more permanent solution around this by enabling the 
Objective-C runtime before any forking happens: 

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16649/diffs

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35215] Replacing CPython memory allocation

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Hi @paul,

have you already checked 
https://docs.python.org/3/c-api/memory.html#customize-memory-allocators ?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35215] Replacing CPython memory allocation

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
Removed message: https://bugs.python.org/msg329755

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35215] Replacing CPython memory allocation

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Hi @paul,

have you already checked 
https://docs.python.org/3/c-api/memory.html#customize-memory-allocators?

--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35219] macOS 10.14 Mojave crashes in multiprocessing

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

On Nov 12, 2018, at 13:34, Pablo Galindo Salgado  wrote:

> Apparently setting the env variable OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES 
> should fix some fork-related changes. Have you tried already doing this? Does 
> it change the behaviour of the errors in any way?

Yes, sorry I got distracted before I could add a comment about this.  I have 
indeed tested this and it does prevent the core files.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35207] Disallow expressions like (a) = 42

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
resolution:  -> not a bug
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35219] macOS 10.14 Mojave crashes in multiprocessing

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Apparently setting the env variable OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES 
should fix some fork-related changes. Have you tried already doing this? Does 
it change the behaviour of the errors in any way?

--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35219] macOS 10.14 Mojave crashes in multiprocessing

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

That should of course be 10.14 Mojave.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35219] macOS 10.14 Mojave crashes in multiprocessing

[Barry A. Warsaw]

Change by Barry A. Warsaw :


--
title: macOS 10.14 High Sierra crashes in multiprocessing -> macOS 10.14 Mojave 
crashes in multiprocessing

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35218] decompressing and then re-compressing zipfiles with Python 3 zipfile loses flag_bits

[keeely]

Change by keeely :


--
title: Impossible to round-trip decompress -> compress zipfiles with Python 3 
due to losing flag_bits -> decompressing and then re-compressing zipfiles with 
Python 3 zipfile loses flag_bits

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35220] delete "how do I emulate os.kill" section in Windows FAQ

[Mathieu Dupuy]

New submission from Mathieu Dupuy :

That section is a tip on how to kill process on Windows for Python prior to 2.7 
and 3.2.
3.1 end of support was April 2012 and 2.6 was October 2013, so that hasn't been 
needed for supported versions of Python for more than 5 years. Beside not being 
needed anymore for a long time, when I read it with the eyes of a Python 
profane, it makes Python looks bad, like a language from the pasts with warts 
you need to circumvent.
Let's delete that.

--
assignee: docs@python
components: Documentation
messages: 329751
nosy: deronnax, docs@python
priority: normal
pull_requests: 9750
severity: normal
status: open
title: delete "how do I emulate os.kill" section in Windows FAQ
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Gregory P. Smith]

Change by Gregory P. Smith :


--
pull_requests: +9749

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Gregory P. Smith]

Gregory P. Smith  added the comment:


New changeset 1584a0081500d35dc93ff88e5836df35faf3e3e2 by Gregory P. Smith in 
branch 'master':
bpo-35214: Initial clang MemorySanitizer support (GH-10479)
https://github.com/python/cpython/commit/1584a0081500d35dc93ff88e5836df35faf3e3e2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22543] -W option cannot use non-standard categories

[Dmitry Shachnev]

Change by Dmitry Shachnev :


--
nosy: +mitya57

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35213] IDLE: use 'macOS' where appropriate.

[Terry J. Reedy]

Terry J. Reedy  added the comment:

The 4th line above should include 'macOS'.

10.14 to current 10.16: macOS (2016)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35213] IDLE: use 'macOS' where appropriate.

[Terry J. Reedy]

Terry J. Reedy  added the comment:

The history of names for 10.X, from the reference above (which also has 
nicknames, like 'Mavericks' and 'Mohave', which I believe we do not use).

10.0 to 10.7: Mac OS X (space or spaces sometime left out, as in macosx)
10.8 to 10.13: OS X (2012, ditto)
10.14 to (current) 10.16 (2016)

AFAIK, the current Mac installers support either 10.6+ or 10.9+.  The macosx 
references to 'Mac OS X 10.6' and 'OS X 10.7 and 10.8' are properly not changed.

'OS X' in pyshell.py is removed in PR 10464.

The most recent item in NEWS.txt using 'OS X' is for #27310, June 2016, by Ned, 
who used 'OS X'.  So no changes to NEWS.txt or NEWS2.txt.

** Ned **
Should 'OS X Aqua Tk' be changed to 'macOS Aqua Tk' or 'macOS (OS X) Aqua Tk'?  
In other words, is 'OS X' here a replaceable noun adjective or an integral part 
of a proper name?  The PR did the 2nd replacement in config.py, since the 
comment is about the 'IDLE Classic OSX' keyset, but I deferred the change in 
mainmenu.py.

Same issue with 'OS X Cocoa Tk 8.5' in editor.py.

Editor.py also has "Some OS X systems have only one mouse button".  It seems to 
me that 'Mac' would be a better replacement that 'macOS' as the mouse is part 
of the hardware system, not the OS software.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35219] macOS 10.14 High Sierra crashes in multiprocessing

[Barry A. Warsaw]

New submission from Barry A. Warsaw :

As we're beginning to roll out macOS 10.14 High Sierra, we're seeing an 
increase in core files inside /cores.  This can consume a ton of disk space if 
you have coredumps enabled.  I don't have a short reproducer yet, but we 
believe this is related to changes in macOS behavior around fork().  Here are 
some clues:

https://github.com/ansible/ansible/issues/32499#issuecomment-341578864

https://stackoverflow.com/questions/50168647/multiprocessing-causes-python-to-crash-and-gives-an-error-may-have-been-in-progr/52230415#52230415

http://sealiesoftware.com/blog/archive/2017/6/5/Objective-C_and_fork_in_macOS_1013.html

--
messages: 329747
nosy: barry
priority: normal
severity: normal
status: open
title: macOS 10.14 High Sierra crashes in multiprocessing
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30064] BaseSelectorEventLoop.sock_{recv, sendall}() don't remove their callbacks when canceled

[Andrew Svetlov]

Change by Andrew Svetlov :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30064] BaseSelectorEventLoop.sock_{recv, sendall}() don't remove their callbacks when canceled

[Andrew Svetlov]

Andrew Svetlov  added the comment:


New changeset 74387926072abf338a4c1cec1bf0501fc65bbee5 by Andrew Svetlov in 
branch 'master':
bpo-30064: Refactor sock_* asyncio API (#10419)
https://github.com/python/cpython/commit/74387926072abf338a4c1cec1bf0501fc65bbee5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35195] Pandas read_csv() is 3.5X Slower on Python 3.7.1 vs Python 3.6.7 & 3.5.2 On Windows 10

[STINNER Victor]

STINNER Victor  added the comment:

Can someone please try to write an example which only uses the stdlib?

> The culprit is the isdigit function called in the parsers extension module.

What are these extensions? Where do them come from?

> Any way you can help test out a config setting to avoid the locale changes on 
> Python 3.7.0a4+?

(I fixed 2.7 => 3.7)

I don't understand which "locale changes" you are talking about. You can change 
the locale using locale.setlocale().

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29564] ResourceWarning: suggest to enable tracemalloc in the message

[STINNER Victor]

STINNER Victor  added the comment:

Example:
---
import warnings
import tracemalloc

#tracemalloc.start(5)

# always log ResourceWarning messages
warnings.simplefilter("always", ResourceWarning)
def func():
f = open(__file__)
# emit ResourceWarning
f = None
func()
---

Output with Python 3.7:
---
$ python3 script.py
script.py:11: ResourceWarning: unclosed file <_io.TextIOWrapper 
name='script.py' mode='r' encoding='UTF-8'>
  f = None
---

Output with my attached PR 10486:
---
$ python3 script.py
script.py:11: ResourceWarning: unclosed file <_io.TextIOWrapper 
name='script.py' mode='r' encoding='UTF-8'>
  f = None
ResourceWarning: Enable tracemalloc to get the object allocation traceback
---

Finally, if tracemalloc is enabled:
---
$ ./python -X tracemalloc=5 script.py 
script.py:11: ResourceWarning: unclosed file <_io.TextIOWrapper 
name='script.py' mode='r' encoding='UTF-8'>
  f = None
Object allocated at (most recent call last):
  File "script.py", lineno 12
func()
  File "script.py", lineno 9
f = open(__file__)
---

--
resolution: not a bug -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29564] ResourceWarning: suggest to enable tracemalloc in the message

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch
pull_requests: +9748
stage: test needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com