[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

2019-03-04 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Hi Victor, For the backport, should I add support.TEST_HTTP_URL? -- ___ Python tracker ___ ___

[issue36188] Remove vestiges of Python 2 unbound methods from Python 3

2019-03-04 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset b727239575894b060db37792e86aab818c00817a by Benjamin Peterson (Martijn Pieters) in branch 'master': closes bpo-36188: Clean up 'unbound' method left-overs. (GH-12169)

[issue35678] subprocess.check_output(): OSError: [WinError 87]

2019-03-04 Thread Geoff Alexander
Geoff Alexander added the comment: Here's the trace back I get from Python 3.7.2: Traceback (most recent call last): File "migration.py", line 169, in migrate() File "migration.py", line 80, in migrate rtc.acceptchangesintoworkspace(rtc.getchangeentriestoaccept(changeentries,

[issue35678] subprocess.check_output(): OSError: [WinError 87]

2019-03-04 Thread Geoff Alexander
Geoff Alexander added the comment: I've recently hit this problem (or one that has the same symptoms): ``` Traceback (most recent call last): File "migration.py", line 169, in migrate() File "migration.py", line 80, in migrate

[issue36142] Add a new _PyPreConfig step to Python initialization to setup memory allocator and encodings

2019-03-04 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12171 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36142] Add a new _PyPreConfig step to Python initialization to setup memory allocator and encodings

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: New changeset 6dcb54228e7520abd058897440c26e323f62afcd by Victor Stinner in branch 'master': bpo-36142: Add _PyPreConfig_ReadFromArgv() (GH-12173) https://github.com/python/cpython/commit/6dcb54228e7520abd058897440c26e323f62afcd --

[issue36183] test_gdb failed on AMD64 FreeBSD CURRENT Shared 3.7 and 3.x

2019-03-04 Thread Kubilay Kocak
Kubilay Kocak added the comment: I've just removed gdb from the buildbot at Pablo's (email) request. I can reinstall it on request at any time to resolve the test_gdb failures tracked in this issue. -- ___ Python tracker

[issue36183] test_gdb failed on AMD64 FreeBSD CURRENT Shared 3.7 and 3.x

2019-03-04 Thread Kubilay Kocak
Kubilay Kocak added the comment: Pablo asked for gdb to be installed to debug the crash in bug issue 36114 and I let him know in my email reply that when I had installed gdb in the past for an unrelated debug need, that test_gdb failed, which at the time I didn't have the time/cycles to

[issue36142] Add a new _PyPreConfig step to Python initialization to setup memory allocator and encodings

2019-03-04 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12170 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36142] Add a new _PyPreConfig step to Python initialization to setup memory allocator and encodings

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: New changeset cad1f747da47849ab5d8b0b881f7a0b94564d290 by Victor Stinner in branch 'master': bpo-36142: Add _PyPreConfig structure (GH-12172) https://github.com/python/cpython/commit/cad1f747da47849ab5d8b0b881f7a0b94564d290 --

[issue36085] Enable better DLL resolution

2019-03-04 Thread Eryk Sun
Eryk Sun added the comment: > Alternatively, I'm totally happy to make a three month exception to > PEP 11 and just drop Win7 completely for 3.8. But I think that needs > to be made official as early as possible Windows 7 is still used on about 40% of Windows desktops, and will likely

[issue33608] [subinterpreters] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2019-03-04 Thread Eric Snow
Eric Snow added the comment: That's okay, Victor. Thanks for jumping on this. I'll take a look when I get a chance. -- ___ Python tracker ___

[issue36142] Add a new _PyPreConfig step to Python initialization to setup memory allocator and encodings

2019-03-04 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12169 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

2019-03-04 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: sure, I will do the backport tomorrow. thanks for the notif -- ___ Python tracker ___ ___

[issue36183] test_gdb failed on AMD64 FreeBSD CURRENT Shared 3.7 and 3.x

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: > I think the solution here is uninstalling gdb from the buildbot. I have > emailed Kubilay to see if he can revert the gdb installation to check if this > is what is causing the problems. Well, test_gdb should work on FreeBSD :-) If you and koobs prefer to

[issue36191] pubkeys.txt contains bogus keys

2019-03-04 Thread Thomas Jollans
New submission from Thomas Jollans : The file https://www.python.org/static/files/pubkeys.txt contains some bogus GPG keys with 32-bit key IDs identical to actual release manager key IDs. (see below) I imagine these slipped in by accident and may have been created by someone trying to make a

[issue36183] test_gdb failed on AMD64 FreeBSD CURRENT Shared 3.7 and 3.x

2019-03-04 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I think the solution here is uninstalling gdb from the buildbot. I have emailed Kubilay to see if he can revert the gdb installation to check if this is what is causing the problems. -- ___ Python tracker

[issue36183] test_gdb failed on AMD64 FreeBSD CURRENT Shared 3.7 and 3.x

2019-03-04 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Koobs recently installed gdb on the buildbot to debug some of the recent race conditions. This is very likely to have caused some problems with the test suite. -- ___ Python tracker

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: Stéphane: Python 2.7 is also affected by the issue. Would you be interested in backport the fix to Lib/test/test_urllibnet.py? (in master, it's Lib/test/test_urllib2net.py). https://buildbot.python.org/all/#/builders/68/builds/238 Re-running failed tests

[issue36172] csv module internal consistency

2019-03-04 Thread Shane
Shane added the comment: Thank you both for having a look. I just find that these sort of gotchas rather annoying (nonsensical mental burden of having to memorize behavior that does not behave like most other features for "hysterical raisins"). I think making the documentation more visible

[issue36190] file object method .tell() sometimes returns large number when position is right before a line break

2019-03-04 Thread Tim Peters
Tim Peters added the comment: Stuff like that happens in any language supporting a tell() function for a file opened in text mode on Windows, inherited from the platform C's ftell() implementation: https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/ftell-ftelli64?view=vs-2017

[issue33346] Syntax error with async generator inside dictionary comprehension

2019-03-04 Thread Nathaniel Smith
Nathaniel Smith added the comment: There are some tricky subtleties here around the distinction between list/dict/set comprehensions and generator expressions. For list/dict/set comprehensions, they're evaluated eagerly, so an async comprehension can only occur in async context. For

[issue36190] file object method .tell() sometimes returns large number when position is right before a line break

2019-03-04 Thread Zachary Ware
Zachary Ware added the comment: Your attached file doesn't seem to be a valid zip file. Also, note that the result of `tell` on a file opened in text mode is documented [1] as being an opaque integer; there is no guarantee that the result of `tell` has any relation to the number of

[issue21879] str.format() gives poor diagnostic on placeholder mismatch

2019-03-04 Thread Manuel Cerón
Change by Manuel Cerón : -- nosy: -ceronman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36190] file object method .tell() sometimes returns large number when position is right before a line break

2019-03-04 Thread Erik Wennstrom
New submission from Erik Wennstrom : Sometimes, when the position on a text file object is right before a line break, the file object method .tell() returns a bizarre large number (18446744073709551621) instead of the correct position. The incorrect behavior occurs consistently for certain

[issue35998] test_asyncio: test_start_tls_server_1() TimeoutError on Fedora 29

2019-03-04 Thread Open Close
Open Close added the comment: uploading stderr-op368.txt. (basically the same as Stéphane and Karthikeyan.) -- Added file: https://bugs.python.org/file48185/stderr-op368.txt ___ Python tracker

[issue33346] Syntax error with async generator inside dictionary comprehension

2019-03-04 Thread Guido van Rossum
Guido van Rossum added the comment: Hm, I think that if Yury still thinks this is a good idea you two should just do this. No need to write a PEP or wait for the Steering Committee. Unless there's a downside? Does it break real existing code? -- nosy: +gvanrossum

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

2019-03-04 Thread Martijn Pieters
Change by Martijn Pieters : -- pull_requests: +12168 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

2019-03-04 Thread Martijn Pieters
Change by Martijn Pieters : -- pull_requests: -12166 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36149] use of uninitialised memory in cPickle.

2019-03-04 Thread Thomas Wouters
Change by Thomas Wouters : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue36189] DOC: Correct word in tutorial introduction

2019-03-04 Thread Cheryl Sabella
New submission from Cheryl Sabella : In the tutorial introduction, under section 3.1.3 for Lists, 'sequence type' should be 'sequence types'. > Like strings (and all other built-in sequence ---> type <---) Assigning to @Mariatta for the sprints. -- assignee: Mariatta components:

[issue36149] use of uninitialised memory in cPickle.

2019-03-04 Thread Thomas Wouters
Thomas Wouters added the comment: New changeset d9bf7f4198871132714cfe7d702baaa02206e9f1 by T. Wouters in branch '2.7': [2.7] bpo-36149 Fix potential use of uninitialized memory in cPickle (#12105) https://github.com/python/cpython/commit/d9bf7f4198871132714cfe7d702baaa02206e9f1 --

[issue36172] csv module internal consistency

2019-03-04 Thread Josh Rosenberg
Josh Rosenberg added the comment: Unless someone disagrees soon, I'm going to close this as documented behavior/not a bug. AFAICT, the only "fixes" available for this are: 1. Changing the default dialect from 'excel' to something else. Problem: Breaks correct code dependent on the excel

[issue36188] Remove vestiges of Python 2 unbound methods from Python 3

2019-03-04 Thread Martijn Pieters
Change by Martijn Pieters : -- keywords: +patch pull_requests: +12167 stage: -> patch review ___ Python tracker ___ ___

[issue36188] Remove vestiges of Python 2 unbound methods from Python 3

2019-03-04 Thread Martijn Pieters
New submission from Martijn Pieters : The implementation of method_hash, method_call and method_descr_get all still contain assumptions that __self__ can be set to None, a holdover from Python 2 where methods could be *unbound*. These vestiges can safely be removed, because method_new() and

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

2019-03-04 Thread Martijn Pieters
Change by Martijn Pieters : -- pull_requests: +12166 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36187] Get rid of NamedStore

2019-03-04 Thread Josh Rosenberg
Change by Josh Rosenberg : -- nosy: +josh.r ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36158] Regex search behaves differently in list comprehension

2019-03-04 Thread Josh Rosenberg
Josh Rosenberg added the comment: Sounds like at least one such entity's trigger attribute doesn't match the regex. In the spelled out loop, you'd still get the exception on a failed match, but you'd store the results for however many entities matched before then (so catching the exception

[issue29205] col_offset for AsyncFunctionDef AST nodes is wrong

2019-03-04 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue36179] _hashopenssl has reference leaks in OOM case

2019-03-04 Thread miss-islington
miss-islington added the comment: New changeset 84b5ac9ba6fd71ba9d0ef98e2a166a35189b263f by Miss Islington (bot) (Christian Heimes) in branch '2.7': [2.7] bpo-36179: Fix ref leaks in _hashopenssl (GH-12158) (GH-12166)

[issue36085] Enable better DLL resolution

2019-03-04 Thread Steve Dower
Steve Dower added the comment: Adding Łukasz for his RM opinion on Win7 support for 3.8. According to PEP 11, we've already dropped support for Win7 without Service Pack 1. Win7 SP1 would be dropped ~2-3 months after 3.8 releases, which means we still have to support it for all of 3.8. My

[issue29167] Race condition in enum.py:_decompose()

2019-03-04 Thread Martin
Martin added the comment: Our production system hit this issue using Python 3.6.7 once a few days ago, so presumably the race is still possible with the applied patch, just less likely? ``` RuntimeError: dictionary changed size during iteration at _decompose (/usr/lib/python3.6/enum.py:858)

[issue36179] _hashopenssl has reference leaks in OOM case

2019-03-04 Thread miss-islington
miss-islington added the comment: New changeset a59d33a1b08bd3dc9dc2584d4360ca81b0f1ad49 by Miss Islington (bot) in branch '3.7': bpo-36179: Fix ref leaks in _hashopenssl (GH-12158) https://github.com/python/cpython/commit/a59d33a1b08bd3dc9dc2584d4360ca81b0f1ad49 --

[issue36187] Get rid of NamedStore

2019-03-04 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +12165 stage: -> patch review ___ Python tracker ___ ___

[issue36187] Get rid of NamedStore

2019-03-04 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : The proposed PR refactors the code for assignment expression and removes the NamedStore value of the expr_context_ty enum added in issue35224. This value is undistinguished from Store except two places in Python/ast.c and Python/symtable.c, but in that

[issue36179] _hashopenssl has reference leaks in OOM case

2019-03-04 Thread Christian Heimes
Change by Christian Heimes : -- pull_requests: +12164 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36179] _hashopenssl has reference leaks in OOM case

2019-03-04 Thread Christian Heimes
Change by Christian Heimes : -- pull_requests: +12163 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31861] add aiter() and anext() functions to operator module

2019-03-04 Thread Giampaolo Rodola'
Change by Giampaolo Rodola' : -- nosy: -giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31861] add aiter() and anext() functions to operator module

2019-03-04 Thread Joshua Bronson
Joshua Bronson added the comment: If the deciders prefer to have these in the operator module for 3.8 (as Yury and Jelle requested above), my PR from a few months ago which implements this (https://github.com/python/cpython/pull/8895) can still be merged with no conflicts. I don't think any

[issue36183] test_gdb failed on AMD64 FreeBSD CURRENT Shared 3.7 and 3.x

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: Same errors on AMD64 FreeBSD CURRENT Shared 3.7: https://buildbot.python.org/all/#/builders/173/builds/333 -- title: test_gdb failed on AMD64 FreeBSD CURRENT Shared 3.x -> test_gdb failed on AMD64 FreeBSD CURRENT Shared 3.7 and 3.x

[issue36179] _hashopenssl has reference leaks in OOM case

2019-03-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +12162 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36179] _hashopenssl has reference leaks in OOM case

2019-03-04 Thread miss-islington
miss-islington added the comment: New changeset b7bc283ab6a23ee98784400ebffe7fe410232a2e by Miss Islington (bot) (Christian Heimes) in branch 'master': bpo-36179: Fix ref leaks in _hashopenssl (GH-12158) https://github.com/python/cpython/commit/b7bc283ab6a23ee98784400ebffe7fe410232a2e

[issue36186] [2.7] Coverity scan: Modules/linuxaudiodev.c , fd handle is not closed.

2019-03-04 Thread Charalampos Stratakis
Change by Charalampos Stratakis : -- keywords: +patch pull_requests: +12161 stage: -> patch review ___ Python tracker ___ ___

[issue13096] ctypes: segfault with large POINTER type names

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: New changeset 710dcfd2f4bee034894a39026388f9c21ea976f1 by Victor Stinner (stratakis) in branch '2.7': [2.7] bpo-13096: Fix memory leak in ctypes POINTER handling of large values (GH-12100)

[issue36186] [2.7] Coverity scan: Modules/linuxaudiodev.c , fd handle is not closed.

2019-03-04 Thread Charalampos Stratakis
New submission from Charalampos Stratakis : There are two places [0][1] in the code where NULL is returned but the fd handle is not closed. [0] https://github.com/python/cpython/blob/2.7/Modules/linuxaudiodev.c#L129 [1] https://github.com/python/cpython/blob/2.7/Modules/linuxaudiodev.c#L133

[issue36183] test_gdb failed on AMD64 FreeBSD CURRENT Shared 3.x

2019-03-04 Thread STINNER Victor
Change by STINNER Victor : -- title: test_gdb failed on AMD64 FreeBSD CURRENT Shared 3.x failed -> test_gdb failed on AMD64 FreeBSD CURRENT Shared 3.x ___ Python tracker ___

[issue35198] Build issue while compiling cpp files in AIX

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: Thanks Kevin Adler. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue36185] [EASY DOC] typo: Doc/c-api/objbuffer.rst: There is a typo in "corresponding"

2019-03-04 Thread Rémi Lapeyre
Rémi Lapeyre added the comment: Shouldn't this be kept for the documentation sprint? -- nosy: +cheryl.sabella, remi.lapeyre ___ Python tracker ___

[issue35198] Build issue while compiling cpp files in AIX

2019-03-04 Thread miss-islington
miss-islington added the comment: New changeset 06e9953d5e3f0144ec8247b61541e7be85d55b50 by Miss Islington (bot) in branch '3.7': bpo-35198 Fix C++ extension compilation on AIX (GH-10437) https://github.com/python/cpython/commit/06e9953d5e3f0144ec8247b61541e7be85d55b50 -- nosy:

[issue36183] test_gdb failed on AMD64 FreeBSD CURRENT Shared 3.x failed

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: On my FreeBSD 12.0 VM, "py-bt" works as expected. It might be a recent change in FreeBSD CURRENT kernel? -- ___ Python tracker ___

[issue36183] test_gdb failed on AMD64 FreeBSD CURRENT Shared 3.x failed

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: I tested gdb on the buildbot and I got permission errors, at least under my user "haypo": warning: Could not trace the inferior process. Error: warning: ptrace: Operation not permitted Logs: CURRENT-amd64% gdb -args ./python Lib/test/gdb_sample.py GNU

[issue35998] test_asyncio: test_start_tls_server_1() TimeoutError on Fedora 29

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: Interesting code in test_ssl.py: except (ConnectionResetError, BrokenPipeError) as e: # We treat ConnectionResetError as though it were an # SSLError - OpenSSL on Ubuntu abruptly closes the #

[issue20906] Issues in Unicode HOWTO

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: I see a change, so I guess that this old issue can now be fixed. Anything, the issue didn't get much activity last years. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python

[issue35198] Build issue while compiling cpp files in AIX

2019-03-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +12160 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35198] Build issue while compiling cpp files in AIX

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: New changeset 800d5cd75025876d79ab05980925a05d8e36b63d by Victor Stinner (Kevin Adler) in branch 'master': bpo-35198 Fix C++ extension compilation on AIX (GH-10437) https://github.com/python/cpython/commit/800d5cd75025876d79ab05980925a05d8e36b63d

[issue36185] [EASY DOC] typo: Doc/c-api/objbuffer.rst: There is a typo in "corresponding"

2019-03-04 Thread STINNER Victor
New submission from STINNER Victor : Issue reported at: https://github.com/python/cpython/pull/9/files/650ed79e9dcd6f12b2cd0adcc9d6e3fd1ea929d0#diff-dec96ce8ae89cc364fa198f94357a1ab > There is a typo in "corresponding" Does someone want to write a PR? -- assignee: docs@python

[issue36183] test_gdb failed on AMD64 FreeBSD CURRENT Shared 3.x failed

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: > https://buildbot.python.org/all/#/builders/168/builds/676 Extract of pythoninfo: gdb_version: GNU gdb (GDB) 8.2.1 [GDB v8.2.1 for FreeBSD] sys.thread_info: sys.thread_info(name='pthread', lock='semaphore', version=None) I'm unable to reproduce the issue

[issue36184] [EASY] test_gdb.test_threads() is specific to _POSIX_THREADS, fail on FreeBSD

2019-03-04 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +easy title: test_gdb.test_threads() is specific to _POSIX_THREADS, fail on FreeBSD -> [EASY] test_gdb.test_threads() is specific to _POSIX_THREADS, fail on FreeBSD ___ Python tracker

[issue36184] test_gdb.test_threads() is specific to _POSIX_THREADS, fail on FreeBSD

2019-03-04 Thread STINNER Victor
New submission from STINNER Victor : On my FreeBSD VM, _POSIX_THREADS is not defined: sys.thread_info: sys.thread_info(name='pthread', lock='semaphore', version=None) test_gdb fails with: Verify that "py-bt" indicates threads that are waiting for the GIL ... FAIL

[issue36183] test_gdb failed on AMD64 FreeBSD CURRENT Shared 3.x failed

2019-03-04 Thread STINNER Victor
New submission from STINNER Victor : test_gdb failed on AMD64 FreeBSD CURRENT Shared 3.x failed. Can it be related to my revert, commit 4d61e6e3b802399be62a521d6fa785698cb670b5? https://buildbot.python.org/all/#/builders/168/builds/676 FAIL: test_corrupt_tp_flags

[issue36158] Regex search behaves differently in list comprehension

2019-03-04 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- status: open -> pending ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36181] Add mode parameter to PurePath.write_text to allow for 'a' mode

2019-03-04 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue35859] Capture behavior depends on the order of an alternation

2019-03-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your great work Ma Lin! But it will take a time to make a review of it. Could you please create and run some microbenchmarks to measure possible performance penalty of additional MARH_PUSHes? I am especially interesting in worst cases. If

[issue33608] [subinterpreters] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: For curious people, Pablo Galindo spent a few hours to investigate https://bugs.python.org/issue36114 and I spent a few more hours to finish the analysis. The bug indirectly crashed my laptop :-) https://twitter.com/VictorStinner/status/1102528982036201478

[issue36182] Path.write_text() docs do not include the case that a file exists

2019-03-04 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- keywords: +patch pull_requests: +12159 stage: -> patch review ___ Python tracker ___ ___

[issue33608] [subinterpreters] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: New changeset 4d61e6e3b802399be62a521d6fa785698cb670b5 by Victor Stinner in branch 'master': Revert: bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). (GH-11617) (GH-12159)

[issue33608] [subinterpreters] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: Hi Eric, I'm sorry but I had to revert your recent work. It introduced regressions in at least in test_io and test_multiprocessing_spawn on Windows and FreeBSD. I simply don't have the bandwidth to investigate this regression yet, whereas we really need the

[issue36097] Use only public C-API in _xxsubinterpreters module.

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: New changeset 4d61e6e3b802399be62a521d6fa785698cb670b5 by Victor Stinner in branch 'master': Revert: bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). (GH-11617) (GH-12159)

[issue23689] Memory leak in Modules/sre_lib.h

2019-03-04 Thread Ma Lin
Ma Lin added the comment: PR11926 (closed) tried to allocate SRE_REPEAT on state's stack. It's feasible, but messes up the code in sre_lib.h, and reduces performance a little (roughly 6% slower), so I gave up this solution. PR12160 uses a memory pool, this solution doesn't mess up the code.

[issue23689] Memory leak in Modules/sre_lib.h

2019-03-04 Thread Ma Lin
Change by Ma Lin : -- pull_requests: +12158 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36182] Path.write_text() docs do not include the case that a file exists

2019-03-04 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I'll submit a PR shortly. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue36177] test_io: test_daemon_threads_shutdown_stdout_deadlock() fails on x86 Windows7 3.x

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: It seems like this issue is a regression caused by bpo-33608. -- ___ Python tracker ___ ___

[issue33608] [subinterpreters] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: > The commit ef4ac967e2f3a9a18330cc6abe14adb4bc3d0465 introduced a regression > in > test.test_multiprocessing_spawn.WithThreadsTestManagerRestart.test_rapid_restart: > bpo-36114. There is a very similar bug on Windows: bpo-36116. I'm now also quite

[issue36177] test_io: test_daemon_threads_shutdown_stdout_deadlock() fails on x86 Windows7 3.x

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: It seems like the test started to fail in this build (at Feb 25): https://buildbot.python.org/all/#/builders/58/builds/1977 -- ___ Python tracker

[issue36182] Path.write_text() docs do not include the case that a file exists

2019-03-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I was searching along similar lines since this was present as part of the original commit : https://hg.python.org/cpython/rev/a4da150fbfd4 . I guess it makes sense to restore the text. -- nosy: +xtreak

[issue36144] Dictionary addition.

2019-03-04 Thread Stefan Behnel
Stefan Behnel added the comment: > should we also implement +/+= for sets? The question is: what would that do? The same as '|=' ? That would be rather confusing, I think. "|" (meaning: "or") seems a very natural operation for sets, in the same way that "|" operates on bits in integers.

[issue36182] Path.write_text() docs do not include the case that a file exists

2019-03-04 Thread Inada Naoki
Inada Naoki added the comment: It may be removed accidentally by this commit. https://github.com/python/cpython/commit/8477ed60486a22f79f257ee49f0bc18d0e73f216#diff-56cd2f82cd518e7baf1edab64771f619 -- nosy: +inada.naoki ___ Python tracker

[issue34484] Unicode HOWTO incorrectly refers to Private Use Area for surrogateescape

2019-03-04 Thread miss-islington
miss-islington added the comment: New changeset 84fa6b9e5932af981cb299c0c5ac80b9cc37c3fa by Miss Islington (bot) in branch '3.7': bpo-20906: Various revisions to the Unicode howto (GH-8394) https://github.com/python/cpython/commit/84fa6b9e5932af981cb299c0c5ac80b9cc37c3fa -- nosy:

[issue20906] Issues in Unicode HOWTO

2019-03-04 Thread miss-islington
miss-islington added the comment: New changeset 84fa6b9e5932af981cb299c0c5ac80b9cc37c3fa by Miss Islington (bot) in branch '3.7': bpo-20906: Various revisions to the Unicode howto (GH-8394) https://github.com/python/cpython/commit/84fa6b9e5932af981cb299c0c5ac80b9cc37c3fa -- nosy:

[issue36181] Add mode parameter to PurePath.write_text to allow for 'a' mode

2019-03-04 Thread Vinay Rao
Vinay Rao added the comment: Oh, and write_bytes would have to go thorough the same modification to make them consistent. -- ___ Python tracker ___

[issue36181] Add mode parameter to PurePath.write_text to allow for 'a' mode

2019-03-04 Thread Vinay Rao
Vinay Rao added the comment: Upon reading the issue threads linked by @xtreak, I have changed my mind and think this is a bad idea. 1) It adds more to maintain without offering much benefit (the use case of the shortcut is probably quite rare) 2) The argument 'mode' only accepting two

[issue36182] Path.write_text() docs do not include the case that a file exists

2019-03-04 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: For reference, https://docs.python.org/3/library/pathlib.html#pathlib.Path.write_bytes. -- ___ Python tracker ___

[issue36182] Path.write_text() docs do not include the case that a file exists

2019-03-04 Thread Lysandros Nikolaou
New submission from Lysandros Nikolaou : Hi, in the pathlib.Path.write_bytes() documentation it is clearly stated that "An existing file of the same name is overwritten." Wouldn't it make sense to include something similar to the pathlib.Path.write_text() docs. I had to quickly test it

[issue36181] Add mode parameter to PurePath.write_text to allow for 'a' mode

2019-03-04 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Not that it makes a big difference, but write_text is a method of the Path class, not PurePath. -- nosy: +lys.nikolaou ___ Python tracker

[issue33608] [subinterpreters] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2019-03-04 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12157 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36181] Add mode parameter to PurePath.write_text to allow for 'a' mode

2019-03-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: append_text helper was proposed as part of issue35095 and adding a parameter append was also discussed as part of the original API issue20218 . Adding @pitrou to decide upon the API. -- nosy: +pitrou, xtreak

[issue36181] Add mode parameter to PurePath.write_text to allow for 'a' mode

2019-03-04 Thread Vinay Rao
New submission from Vinay Rao : - Default should be 'w' for compatibility. - There should be a check that makes sure mode is either 'w' or 'a', or else raise ValueError. -- components: Library (Lib) messages: 337097 nosy: vinayluzrao priority: normal severity: normal status: open

[issue36179] _hashopenssl has reference leaks in OOM case

2019-03-04 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +cstratak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33608] [subinterpreters] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: The commit ef4ac967e2f3a9a18330cc6abe14adb4bc3d0465 introduced a regression in test.test_multiprocessing_spawn.WithThreadsTestManagerRestart.test_rapid_restart: bpo-36114. Would it be possible to revert it until the bug is properly understood and fixed?

[issue36114] test_multiprocessing_spawn dumps core in AMD64 FreeBSD CURRENT Shared 3.x

2019-03-04 Thread STINNER Victor
STINNER Victor added the comment: Ok, I confirm that the commit ef4ac967e2f3a9a18330cc6abe14adb4bc3d0465 introduced a regression in test.test_multiprocessing_spawn.WithThreadsTestManagerRestart.test_rapid_restart. -- ___ Python tracker

  1   2   >