[issue24116] --with-pydebug has no effect when the final python binary is compiled

2019-04-10 Thread Inada Naoki
Inada Naoki added the comment: gcc is not compiler, but linker when `-o python`. So LDFLAGS is used instead of CFLAGS. I don't think we can document and maintain all configure & make behavior. I'm +1 on close this. -- nosy: +inada.naoki ___ Python

[issue33722] Document builtins in mock_open

2019-04-10 Thread Jay Crotts
Jay Crotts added the comment: No worries, I think all of your points make sense, especially number one after looking at the patch again. I looked at the docs again, and there is even an example of another built in being patched. Thanks for taking the time to review it. I'm okay with

[issue36598] mock side_effect should be checked for iterable not callable

2019-04-10 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak versions: +Python 3.8 -Python 2.7 ___ Python tracker ___ ___ Python-bugs-list

[issue36595] IDLE: Add search to Squeezed Output text viewer.

2019-04-10 Thread Terry J. Reedy
Change by Terry J. Reedy : -- versions: +Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33722] Document builtins in mock_open

2019-04-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: After looking at the context of the patch and thinking more about whether the patch is a good idea, I am reversing what I said before and think that this issue and the new patch (sorry) should be closed. 1. The new example duplicates the current example.

[issue22377] %Z in strptime doesn't match EST and others

2019-04-10 Thread Ram Rachum
Change by Ram Rachum : -- nosy: -cool-RR ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36598] mock side_effect should be checked for iterable not callable

2019-04-10 Thread Gregory Ronin
New submission from Gregory Ronin : In mock.py, in method: def _mock_call(_mock_self, *args, **kwargs): There is a following piece of code: if not _callable(effect): result = next(effect) if _is_exception(result): raise result if result is DEFAULT:

[issue33722] Document builtins in mock_open

2019-04-10 Thread Jay Crotts
Change by Jay Crotts : -- pull_requests: +12700 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33722] Document builtins in mock_open

2019-04-10 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: The example looks like a good addition to me since mocking builtins.open is not documented for this use case. Please start a new PR. -- nosy: +xtreak ___ Python tracker

[issue36597] Travis CI: doctest failure

2019-04-10 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +mdk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36595] IDLE: Add search to Squeezed Output text viewer.

2019-04-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: I agree. The Squeezed Output Viewer is an instance of idlelib.textview.ViewWindow. The latter is for read-only text and is also used for the text displays invoked from About IDLE. I have already thought about making the text searchable. Seaching does

[issue36597] Travis CI: doctest failure

2019-04-10 Thread STINNER Victor
New submission from STINNER Victor : On my https://github.com/python/cpython/pull/12770 the doctest job of Travis CI failed with: https://travis-ci.org/python/cpython/jobs/518572326 mkdir -p build Building NEWS from Misc/NEWS.d with blurb PATH=./venv/bin:$PATH sphinx-build -b doctest -d

[issue33722] Document builtins in mock_open

2019-04-10 Thread Jay Crotts
Jay Crotts added the comment: Yeah the PR had been stale for a while, and I re-based my fork without closing the PR, so when I pushed it to the fork it updated the PR reviewer list. Silly mistake by me, I should have made sure the diff wasn't huge before pushing it. I know review time is

[issue33722] Document builtins in mock_open

2019-04-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: My *guess* is that you created the branch for PR 7491 when your local master branch was months out of date. Or you branched off of the 3.7 branch. Whatever, your patch proposed to revert recent changes to master, touching about 1000 files. When you

[issue36389] Add gc.enable_object_debugger(): detect corrupted Python objects in the GC

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: bpo-33803 bug can be reintroduced using the following patch: diff --git a/Python/hamt.c b/Python/hamt.c index 67af04c437..67da8ec22c 100644 --- a/Python/hamt.c +++ b/Python/hamt.c @@ -2478,8 +2478,10 @@ hamt_alloc(void) if (o == NULL) { return

[issue36596] tarfile module considers anything starting with 512 bytes of zero bytes to be a valid tar file

2019-04-10 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +lars.gustaebel, serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing

[issue36389] Add gc.enable_object_debugger(): detect corrupted Python objects in the GC

2019-04-10 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12699 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36596] tarfile module considers anything starting with 512 bytes of zero bytes to be a valid tar file

2019-04-10 Thread Chris Siebenmann
New submission from Chris Siebenmann : The easiest reproduction of this is: import tarfile tarfile.open("/dev/zero", "r:") (If you use plain "r" you get a hang in attempted lzma decoding.) I believe this is probably due to a missing 'elif self.offset == 0:' in the 'except

[issue36592] is behave different for integers in 3.6 and 3.7

2019-04-10 Thread Shane
Shane added the comment: Well, then I guess that explains it! Still, like I said, I tend to shy away from features that require such a deep understanding of the implementation in order to avoid "gotchas". "is" does have its uses, but for me they very very rarely come up. --

[issue36592] is behave different for integers in 3.6 and 3.7

2019-04-10 Thread Geraldo Xexeo
Geraldo Xexeo added the comment: "So 2**8 is a magic number, for whatever reason." Actually, this is true. Accordingly to https://rushter.com/blog/python-integer-implementation/ "Optimization of commonly-used integers Small integer objects in a range of -5 to 256 are always pre-allocated

[issue22377] %Z in strptime doesn't match EST and others

2019-04-10 Thread Alex LordThorsen
Alex LordThorsen added the comment: It's been a while since I've committed a patch. Do I still upload a diff file here or should I open a PR for the doc changes on github? -- ___ Python tracker

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

2019-04-10 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue36389] Add gc.enable_object_debugger(): detect corrupted Python objects in the GC

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: Do you think that a gc.is_object_debugger_enabled() function would be needed? The tracemalloc module has 3 functions: * start(), stop() * is_tracing() The faulthandler module has 3 functions: * enable() / disable() * is_enabled() --

[issue36389] Add gc.enable_object_debugger(): detect corrupted Python objects in the GC

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: I modified my PR to reuse tp_traverse. Inada-san: would you mind to review my change? -- ___ Python tracker ___

[issue36593] Trace function interferes with MagicMock isinstance?

2019-04-10 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: On an initial guess this is the change that went through and using object.__delattr__(self, name) instead of super().__delattr__(name) restores the old behavior and there are no test case failures. But I still have to check the change and how it's

[issue36594] Undefined behavior due to incorrect usage of %p in format strings

2019-04-10 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue36593] Trace function interferes with MagicMock isinstance?

2019-04-10 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: There are very few changes to mock.py on bisecting with the example in the report is d358a8cda75446a8e0b5d99149f709395d5eae19 the problem? I am surprised by the reason this commit leads to change in behavior with set trace. ➜ cpython git:(master)

[issue36594] Undefined behavior due to incorrect usage of %p in format strings

2019-04-10 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch pull_requests: +12698 stage: -> patch review ___ Python tracker ___ ___

[issue36594] Undefined behavior due to incorrect usage of %p in format strings

2019-04-10 Thread Zackery Spytz
New submission from Zackery Spytz : The attached PR fixes incorrect usages of %p in format strings. -- ___ Python tracker ___ ___

[issue36595] Text Search in Squeezed Output Viewer

2019-04-10 Thread Shane
New submission from Shane : Would it be possible to enhance IDLE's new Squeezed Output Viewer (which I LOVE, btw), with a text search feature? If I'm in a module's help documentation, I'm usually looking for something, and I often end up copying the text into notepad and searching for it

[issue36594] Undefined behavior due to incorrect usage of %p in format strings

2019-04-10 Thread Zackery Spytz
Change by Zackery Spytz : -- components: Extension Modules, Interpreter Core nosy: ZackerySpytz priority: normal severity: normal status: open title: Undefined behavior due to incorrect usage of %p in format strings versions: Python 2.7, Python 3.7, Python 3.8

[issue36593] Trace function interferes with MagicMock isinstance?

2019-04-10 Thread Ned Batchelder
Change by Ned Batchelder : -- keywords: +3.7regression ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36593] Trace function interferes with MagicMock isinstance?

2019-04-10 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36593] Trace function interferes with MagicMock isinstance?

2019-04-10 Thread Ned Batchelder
Ned Batchelder added the comment: This also affects Python 3.8.0a3 -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue36592] is behave different for integers in 3.6 and 3.7

2019-04-10 Thread Shane
Shane added the comment: This is the sort of thing that makes me avoid "is" in favor of "==" for most applications. Understanding when two objects point to the same memory requires a deeper understanding of the underlying code than I usually want to delve into. Anyway, I find it

[issue36593] Trace function interferes with MagicMock isinstance?

2019-04-10 Thread Ned Batchelder
New submission from Ned Batchelder : In Python 3.7.3, having a trace function in effect while mock is imported causes isinstance to be wrong for MagicMocks. I know, this sounds unlikely... $ cat traced_sscce.py # sscce.py import sys def trace(frame, event, arg): return trace if

[issue36592] is behave different for integers in 3.6 and 3.7

2019-04-10 Thread Eric V. Smith
Eric V. Smith added the comment: Python makes no guarantee as to whether an identity test on integers would return True or False. You should not depend on the behavior in any particular version. -- nosy: +eric.smith resolution: -> not a bug stage: -> resolved status: open ->

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

2019-04-10 Thread miss-islington
miss-islington added the comment: New changeset d9b25a2627ff6f4e10d46b4de4fff941b63497c7 by Miss Islington (bot) in branch '3.7': bpo-36235: Fix distutils test_customize_compiler() on macOS (GH-12764) https://github.com/python/cpython/commit/d9b25a2627ff6f4e10d46b4de4fff941b63497c7

[issue36592] is behave different for integers in 3.6 and 3.7

2019-04-10 Thread Geraldo Xexeo
New submission from Geraldo Xexeo : # When you run the program: a,b=300,300 print(a is b) #you get different results in 3.6 (True) and 3.7 (False) -- components: Interpreter Core files: testisbehavior.py messages: 339900 nosy: Geraldo.Xexeo priority: normal severity: normal status:

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

2019-04-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +12697 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: New changeset a9bd8925c7fa50dd3cfab125b824ec192133ef49 by Victor Stinner in branch 'master': bpo-36235: Fix distutils test_customize_compiler() on macOS (GH-12764) https://github.com/python/cpython/commit/a9bd8925c7fa50dd3cfab125b824ec192133ef49 --

[issue31904] Python should support VxWorks RTOS

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: Please stop adding more pull requests, I cannot review too many at the same time. I would prefer to have a limit of 4 open PRs. I don't propose to close existing ones. Just stop to add more :-) -- ___ Python

[issue1583] Patch for signal.set_wakeup_fd

2019-04-10 Thread Adam Olsen
Adam Olsen added the comment: signalmodule.c has a hack to limit it to the main thread. Otherwise there's all sorts of platform-specific behaviour. -- ___ Python tracker ___

[issue18564] Integer overflow in socketmodule

2019-04-10 Thread Cheryl Sabella
Cheryl Sabella added the comment: Michele Orrù, Would you be interested in making a GitHub pull request for your patch? Thanks! -- nosy: +cheryl.sabella ___ Python tracker

[issue36588] change sys.platform() to just "aix" for AIX

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: > However, I am less familiar with (where) the appropriate documentation is. A > pointer to the documentation is appreciated. It would be nice to add a note to: * https://docs.python.org/dev/whatsnew/3.8.html#changes-in-the-python-api *

[issue19770] NNTP.post broken

2019-04-10 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30458] [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699)

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: > Will this break something in the world other than our own test_xmlrpc test? > Probably. Do they have a right to complain about it? Not one we need listen > to. I understand. But. Can we consider that for old Python versions like Python 2.7 and 3.5?

[issue36591] Should be a typing.UserNamedTuple

2019-04-10 Thread Terry Davis
New submission from Terry Davis : There should be a builtin alias for `Type[NamedTuple]` so that library authors user-supplied `NamedTuple`s can properly type-check their code. Here's a code sample that causes an issue in my IDE (PyCharm) from typing import

[issue1222585] C++ compilation support for distutils

2019-04-10 Thread STINNER Victor
Change by STINNER Victor : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1583] Patch for signal.set_wakeup_fd

2019-04-10 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: > signal-safe is different from thread-safe I know, but I think that other threads can receive signals too. So in that case, it needs to be signal-safe as well as thread-safe. -- ___ Python tracker

[issue24116] --with-pydebug has no effect when the final python binary is compiled

2019-04-10 Thread Cheryl Sabella
Cheryl Sabella added the comment: If this is a documentation issue on the build, then I think this issue should be moved to the devguide repo on GitHub. I'm not sure if it's still unclear though, so maybe this could just be closed? -- nosy: +cheryl.sabella

[issue36590] Add Bluetooth RFCOMM Support for Windows

2019-04-10 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch pull_requests: +12695 stage: -> patch review ___ Python tracker ___ ___

[issue36549] str.capitalize should titlecase the first character not uppercase

2019-04-10 Thread Kingsley McDonald
Kingsley McDonald added the comment: Thanks for clarifying all of that! I now have the patch and tests working locally. However, I'm not too sure what documentation needs to be changed for str.title. Should it specify that only the first letter of digraphs are capitalised, rather than the

[issue36555] PEP484 @overload vs. str/bytes

2019-04-10 Thread Guido van Rossum
Guido van Rossum added the comment: > Mypy already takes first overload for ambiguous arguments. This is true, but it requires that the return types match (covariantly, IIUC) for the overlapping types. So you can have @overload def foo(x: int) -> int: ... @overload def foo(x: float) ->

[issue36590] Add Bluetooth RFCOMM Support for Windows

2019-04-10 Thread Greg Bowser
New submission from Greg Bowser : socketmodule supports Bluetooth RFCOMM sockets for Linux. Given that winsock supports this under windows, it is possible to add windows support as well. -- components: IO, Windows messages: 339888 nosy: Greg Bowser, paul.moore, steve.dower,

[issue36559] "import random" should import hashlib on demand (nor load OpenSSL)

2019-04-10 Thread Raymond Hettinger
Raymond Hettinger added the comment: New changeset d914596a671c4b0f13641359cf43aa0d6fc05070 by Raymond Hettinger (Christian Heimes) in branch 'master': bpo-36559: random module: optimize sha512 import (GH-12742)

[issue36559] "import random" should import hashlib on demand (nor load OpenSSL)

2019-04-10 Thread Raymond Hettinger
Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue30274] Make importlib.abc.ExtensionFileLoader.__init__() documentation match code

2019-04-10 Thread Brett Cannon
Brett Cannon added the comment: I realized another solution to this is to make the argument positional-only, then the name simply doesn't matter. Probably unnecessary breakage, though. -- versions: +Python 3.8 ___ Python tracker

[issue30458] [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699)

2019-04-10 Thread Gregory P. Smith
Gregory P. Smith added the comment: > *Maybe* we need to provide a way to allow to pass junk characters in an URL? > (disable URL validation) We should not do this in our http protocol stack code. Anyone who _wants_ that is already intentionally violating the http protocol which defeats

[issue26389] Expand traceback module API to accept just an exception as an argument

2019-04-10 Thread Brett Cannon
Brett Cannon added the comment: Boy, having a postional-only parameter in that first position would have been handy when we created this API (as Matthias pointed out). :) The 'exec' keyword-only parameter is obviously the safest option here. Making the first parameter positional-only and

[issue36586] multiprocessing.Queue.close doesn't behave as documented

2019-04-10 Thread Brett Cannon
Change by Brett Cannon : -- components: +Library (Lib) nosy: +davin, pitrou ___ Python tracker ___ ___ Python-bugs-list mailing

[issue36501] Remove POSIX.1e ACLs in tests that rely on default permissions behavior

2019-04-10 Thread Ivan Pozdeev
Ivan Pozdeev added the comment: Given the downsides, I think the proposed solution as it's now is too hacky to be a net improvement. "Skip mode_t checks" looks like the only way to go (since I've no idea how to "create temporary dirs" transparently for arbitrary test logic). But skipping

[issue36589] Incorrect error handling in curses.update_lines_cols()

2019-04-10 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch pull_requests: +12694 stage: -> patch review ___ Python tracker ___ ___

[issue36533] logging regression with threading + fork are mixed in 3.7.1rc2 (deadlock potential)

2019-04-10 Thread Gregory P. Smith
Gregory P. Smith added the comment: The problem i am fixing is merely making Python's logging library not the source of this deadlock because it was not the source in the past. I am solving a regression in CPython behavior between 3.7.0 and 3.7.1 that led to a logging.Handler lock related

[issue36589] Incorrect error handling in curses.update_lines_cols()

2019-04-10 Thread Zackery Spytz
New submission from Zackery Spytz : update_lines_cols() returns 0 if an error occurs, but the generated AC code checks for a return value of -1. -- components: Extension Modules messages: 339881 nosy: ZackerySpytz priority: normal severity: normal status: open title: Incorrect error

[issue36587] race in logging code when fork()

2019-04-10 Thread Gregory P. Smith
Gregory P. Smith added the comment: yeah i saw that bug buried in there, this weakset goes away with my proposed PR. -- ___ Python tracker ___

[issue36587] race in logging code when fork()

2019-04-10 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19770] NNTP.post broken

2019-04-10 Thread R. David Murray
R. David Murray added the comment: I do, and sure. I won't be able to review it, though :( -- ___ Python tracker ___ ___

[issue36549] str.capitalize should titlecase the first character not uppercase

2019-04-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This issue is easy if you know C. * Find the implementation of str.capitalize in unicodeobject.c and make it using the title case. See on the implementation of str.title for example. * Find tests for str.capitalize and aďd new cases. Finding the proper

[issue24011] Add error checks to PyInit_signal()

2019-04-10 Thread Joannah Nanjekye
Change by Joannah Nanjekye : -- pull_requests: +12693 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue34144] venv activate.bat reset codepage fails on windows 10

2019-04-10 Thread miss-islington
miss-islington added the comment: New changeset 6955d44b41058e3bcc59ff41860bd4cc8948c441 by Miss Islington (bot) (Lorenz Mende) in branch 'master': bpo-34144: Fix of venv acvtivate.bat for win 10 (GH-8321) https://github.com/python/cpython/commit/6955d44b41058e3bcc59ff41860bd4cc8948c441

[issue36475] PyEval_AcquireLock() and PyEval_AcquireThread() do not handle runtime finalization properly.

2019-04-10 Thread Joannah Nanjekye
Joannah Nanjekye added the comment: @eric do we need any tests for this? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue36346] Prepare for removing the legacy Unicode C API

2019-04-10 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36579] test_venv: test_with_pip() hangs on PPC64 AIX 3.x

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: "I am looking into this - but as it seems to have gone away again - is there a simple way to get that code back, and/or see what the diff is, before/badrun/after?" Maybe it's just a flacky test. It's hard to guess. You can get the Git revision of a build by

[issue19770] NNTP.post broken

2019-04-10 Thread Cheryl Sabella
Cheryl Sabella added the comment: Hi David, You wrote: > It might be worth adding a post_message method, analogous to the send_message > method I added to smtplib. Do you still think this would be worthwhile to add? If so, do you think this would be a good task for someone to work on at

[issue1583] Patch for signal.set_wakeup_fd

2019-04-10 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36579] test_venv: test_with_pip() hangs on PPC64 AIX 3.x

2019-04-10 Thread Michael Felt
Michael Felt added the comment: On 09/04/2019 18:51, STINNER Victor wrote: > New submission from STINNER Victor : > > https://buildbot.python.org/all/#/builders/10/builds/2389 > > 0:45:36 [412/420/1] test_venv crashed (Exit code 1) > Timeout (0:15:00)! > Thread 0x0001 (most recent call

[issue36588] change sys.platform() to just "aix" for AIX

2019-04-10 Thread Michael Felt
Michael Felt added the comment: On 10/04/2019 17:05, STINNER Victor wrote: > STINNER Victor added the comment: > > I like the idea. Would you like to propose a patch? I suggest to only make > such change in Python 3.8 and properly document it. > > -- > nosy: +vstinner > >

[issue1583] Patch for signal.set_wakeup_fd

2019-04-10 Thread Adam Olsen
Adam Olsen added the comment: signal-safe is different from thread-safe (despite conceptual similarities), but regardless it's been a long time since I last delved into this so I'm quite rusty. I could be doing it all wrong. -- ___ Python

[issue36588] change sys.platform() to just "aix" for AIX

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: I like the idea. Would you like to propose a patch? I suggest to only make such change in Python 3.8 and properly document it. -- nosy: +vstinner ___ Python tracker

[issue36588] change sys.platform() to just "aix" for AIX

2019-04-10 Thread Michael Felt
New submission from Michael Felt : This is something that probably shouts - boring - but back in 2012 it was a hot topic for linux2 and linux3. Maybe - as far back as 1996 (when AIX4 was new) "aix3" and "aix4" made sense. Whether that is true, or not - is pointless these days - for Python3.

[issue19476] Add a dedicated specification for module "reloading" to the language reference

2019-04-10 Thread Eric Snow
Eric Snow added the comment: Thanks for checking in, Cheryl! Clearly no one picked up this banner. :) Furthermore, I'm not aware of any reload-related complaints coming from the community. I know of only a couple major use cases for reload(): refresh parts of a running app during

[issue36587] race in logging code when fork()

2019-04-10 Thread SilentGhost
Change by SilentGhost : -- nosy: +gregory.p.smith, vinay.sajip type: crash -> behavior ___ Python tracker ___ ___ Python-bugs-list

[issue19476] Add a dedicated specification for module "reloading" to the language reference

2019-04-10 Thread Cheryl Sabella
Cheryl Sabella added the comment: Hi Eric, Is this still a concern since PEP 451 has been implemented for over 5 years now? Thanks! -- nosy: +cheryl.sabella -BreamoreBoy ___ Python tracker

[issue36587] race in logging code when fork()

2019-04-10 Thread cagney
New submission from cagney : Buried in issue36533; it should probably be turned into a test case. Exception ignored in: Traceback (most recent call last): File "/home/python/v3.7.3/lib/python3.7/logging/__init__.py", line 269, in _after_at_fork_weak_calls _at_fork_weak_calls('release')

[issue30612] Unusual Windows registry path syntax

2019-04-10 Thread Cheryl Sabella
Cheryl Sabella added the comment: @chrullrich, were you still interested in creating a PR for this? Thanks! -- nosy: +cheryl.sabella versions: +Python 3.8 -Python 3.6 ___ Python tracker

[issue36533] logging regression with threading + fork are mixed in 3.7.1rc2 (deadlock potential)

2019-04-10 Thread cagney
cagney added the comment: BTW, non-visible change might be to use a global readers-writer lock where fork() is the writer. https://en.wikipedia.org/wiki/Readers%E2%80%93writer_lock -- ___ Python tracker

[issue24011] Add error checks to PyInit_signal()

2019-04-10 Thread Cheryl Sabella
Change by Cheryl Sabella : -- stage: patch review -> needs patch versions: +Python 3.7, Python 3.8 -Python 3.4, Python 3.5 ___ Python tracker ___

[issue36533] logging regression with threading + fork are mixed in 3.7.1rc2 (deadlock potential)

2019-04-10 Thread cagney
cagney added the comment: > nope. the contrived emit() pseudocode from msg339650 never defined b in the > first place. that code, if massaged into python syntax would raise an > UnboundLocalError no matter who executed it. a fork() from another thread > would not change that. There is

[issue21318] sdist fails with symbolic links do non-existing files

2019-04-10 Thread Cheryl Sabella
Cheryl Sabella added the comment: This was fixed under issue 12885. -- nosy: +cheryl.sabella resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> distutils.filelist.findall() fails on broken symlink in Py2.x ___

[issue30458] [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699)

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: Since this issue has a long history and previously attempts to fix it failed, it seems like the Internet is a black or white world, more like a scale of gray... *Maybe* we need to provide a way to allow to pass junk characters in an URL? (disable URL

[issue36346] Prepare for removing the legacy Unicode C API

2019-04-10 Thread Inada Naoki
Inada Naoki added the comment: I think these ABI incompatible options are used many people. But it is helpful to find extensions which using legacy APIs before Python 3.10 is released. I had found ujson and MarkupSafe used legacy APIs. I fixed MarkupSafe. I don't care ujson because it is

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: Good, my change fixed x86-64 High Sierra 2.7 buildbot: https://buildbot.python.org/all/#/builders/140/builds/216 I wrote PR 12764 to forward-port the fix to the master branch. -- ___ Python tracker

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

2019-04-10 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12692 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36549] str.capitalize should titlecase the first character not uppercase

2019-04-10 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36533] logging regression with threading + fork are mixed in 3.7.1rc2 (deadlock potential)

2019-04-10 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34698] urllib.request.Request.set_proxy doesn't (necessarily) replace type

2019-04-10 Thread Cheryl Sabella
Change by Cheryl Sabella : -- nosy: +orsenthil versions: +Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue30458] [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699)

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: > According to the following message, urllib3 is also vulnerable to HTTP Header > Injection: (...) And the issue has been reported to urllib3: https://github.com/urllib3/urllib3/issues/1553 Copy of the first message: """ At

[issue30458] [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699)

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: bpo-36276 has been marked as a duplicate of this issue. According to the following message, urllib3 is also vulnerable to HTTP Header Injection: https://bugs.python.org/issue36276#msg337837 Copy of Alvin Chang's msg337837: """ I am also seeing the same

[issue31226] shutil.rmtree fails when target has an internal directory junction (Windows)

2019-04-10 Thread Vidar Fauske
Vidar Fauske added the comment: I think the submitted PR could need a pair of eyes now. I've sorted the merge conflicts, and addressed the previous review points by eryksun. -- ___ Python tracker

  1   2   >