[issue37752] Redundant Py_CHARMASK called in normalizestring(codecs.c)

[Jordon.X]

Jordon.X <9651...@qq.com> added the comment:

Thanks Ma,I also think all these redundant Py_CHARMASK should be deleted.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37748] IDLE: Re-order run menu

[Raymond Hettinger]

Raymond Hettinger  added the comment:

+1 for the proposed reverse ordering:

Run Module
Run... Customized
Check Module
Python Shell

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37752] Redundant Py_CHARMASK called in normalizestring(codecs.c)

[Ma Lin]

Ma Lin  added the comment:

Or remove Py_CHARMASK in Py_ISxxx/Py_TOLOWER/Py_TOUPPER macros?
Sometimes `c` is already a unsinged char, Py_CHARMASK is not necessary in these 
cases.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37752] Redundant Py_CHARMASK called in normalizestring(codecs.c)

[Ma Lin]

Ma Lin  added the comment:

Search "Py_CHARMASK" in Python source code, there are more than a dozen 
Py_CHARMASK can be deleted:

https://github.com/python/cpython/blob/e42b705188271da108de42b55d9344642170aa2b/Python/mystrtoul.c#L102

https://github.com/python/cpython/blob/e42b705188271da108de42b55d9344642170aa2b/Python/dynload_aix.c#L143

https://github.com/python/cpython/blob/530f506ac91338b55cf2be71b1cdf50cb077512f/Modules/unicodedata.c#L963

...

--
nosy: +Ma Lin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37752] Redundant Py_CHARMASK called in normalizestring(codecs.c)

[Jordon.X]

Jordon.X <9651...@qq.com> added the comment:

Thanks Hai, for your careful check. There is a misoperation in PR 15093. Now I 
closed PR 15093. And resubmit code as PR 15095.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37706] IDLE test_sidebar test_(click/drag)_selection fail on macOS 8.6

[Ned Deily]

Ned Deily  added the comment:

I can reproduce this at will on all of the real and virtual macOS systems I've 
tried (10.12 through 10.14) even building with ActiveTcl 8.5.18.  Tal, make 
sure the appropriate tests cases are actually running.  If you don't have a 
proper Gui installation of your Python, many of the GUI-related test cases in 
test_idle are silently skipped unless you add -v or something:

/usr/local/bin/python3.8 -m test -v -uall test_idle

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37748] IDLE: Re-order run menu

[Tal Einat]

Tal Einat  added the comment:

Ah, my bad, I mixed up "Check Module" with the proposed external checkers 
feature.

Anyways, I'm +1 on this reordering, but have no opinion on the specifics.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37748] IDLE: Re-order run menu

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Run Module and Run Customized both run Check Module first.  All three involve 
the code in the particular editor.  Restarting Shell is not editor specific, so 
I see *it* as the oddball.

The proposed Run Checker #21880, would involve the editor code, might or might 
not Check Module first, but would not run in or involve Shell at all.  It might 
be a good candidate for the last position.  If it were added, I think my first 
option, Run Module ... Python Shell would be better.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37681] warning: ‘no_sanitize_thread’

[hai shi]

Change by hai shi :


--
keywords: +patch
pull_requests: +14843
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15096

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37681] warning: ‘no_sanitize_thread’

[hai shi]

hai shi  added the comment:

I checked no_sanitize_thread in some gcc manual of different version. And looks 
the no_sanitize_thread from gcc 5.1.0 [3](not 4.8)

[1] 
https://gcc.gnu.org/onlinedocs/gcc-4.9.3/gcc/Function-Attributes.html#Function-Attributes
[2] 
https://gcc.gnu.org/onlinedocs/gcc-4.9.4/gcc/Function-Attributes.html#Function-Attributes
[3] 
https://gcc.gnu.org/onlinedocs/gcc-5.1.0/gcc/Function-Attributes.html#Function-Attributes
[4] 
https://gcc.gnu.org/onlinedocs/gcc-5.2.0/gcc/Function-Attributes.html#Function-Attributes

Alexey have some descr of TSAN in https://bugs.python.org/issue35204(Looks `GCC 
introduced TSan together with ASan in 4.8` is wrong)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15266] Perform the same checks as PyPI for Description field

[Giovanni Cappellotto]

Giovanni Cappellotto  added the comment:

Hi Victor,

This is the 3rd issue in a row I found in the "Easy issues" list where you 
added a comment saying

> I remove the "Easy" label

Why are can I still find these issues in the "Easy issues" list?

Do you mean that you already removed the "Easy" label or that you plan to 
remove it?

--
nosy: +potomak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37753] 2to3 not handing "<="

[Eric V. Smith]

Eric V. Smith  added the comment:

2to3 is not designed to turn every valid python2 program into a valid python3 
program. You'll have to provide a way to compare GameClock objects. I suggest 
you look at http://python3porting.com. You should read the whole site, it's a 
great resource. Specifically in this case, see 
http://python3porting.com/problems.html#unorderable-types-cmp-and-cmp

--
nosy: +eric.smith
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed
type: compile error -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21705] cgi.py: Multipart with more than one file is misparsed

[Rhodri James]

Change by Rhodri James :


--
nosy: +Rhodri James, ethan.furman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37752] Redundant Py_CHARMASK called in normalizestring(codecs.c)

[Jordon.X]

Change by Jordon.X <9651...@qq.com>:


--
pull_requests: +14842
pull_request: https://github.com/python/cpython/pull/15095

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9968] Let cgi.FieldStorage have named uploaded file

[Rhodri James]

Change by Rhodri James :


--
nosy: +Rhodri James, ethan.furman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10879] cgi memory usage

[Rhodri James]

Change by Rhodri James :


--
nosy: +Rhodri James, ethan.furman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20523] global .pdbrc on windows 7 not reachable out of the box

[Steve Dower]

Change by Steve Dower :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1047397] cgitb failures

[Rhodri James]

Change by Rhodri James :


--
pull_requests: +14841
pull_request: https://github.com/python/cpython/pull/15094

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37433] syntax error in multiline f-string produces ~40k spaces output

[Anthony Sottile]

Anthony Sottile  added the comment:

seems unrelated and does the same on older versions of python:

```
$ python3.5 t.py
  File "t.py", line 4

^
SyntaxError: EOF while scanning triple-quoted string literal
```

I'd suggest a new issue or finding the dupe

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37753] 2to3 not handing "<="

[Xinmeng Xia]

New submission from Xinmeng Xia :

After conversion of 2to3 , run simple-example.py and the following error will 
happen.
Traceback (most recent call last):
  File "/home/xxm/Desktop/instrument/datasetpy3/nflgame/simple_example.py", 
line 15, in 
plays = nflgame.combine_plays(games)
  File "/home/xxm/Desktop/instrument/datasetpy3/nflgame/nflgame/__init__.py", 
line 396, in combine_plays
chain = itertools.chain(*[g.drives.plays() for g in games])
  File "/home/xxm/Desktop/instrument/datasetpy3/nflgame/nflgame/__init__.py", 
line 396, in 
chain = itertools.chain(*[g.drives.plays() for g in games])
  File "/home/xxm/Desktop/instrument/datasetpy3/nflgame/nflgame/game.py", line 
407, in __getattr__
self.__drives = _json_drives(self, self.home, self.data['drives'])
  File "/home/xxm/Desktop/instrument/datasetpy3/nflgame/nflgame/game.py", line 
675, in _json_drives
d = Drive(game, i, home_team, data[str(drive_num)])
  File "/home/xxm/Desktop/instrument/datasetpy3/nflgame/nflgame/game.py", line 
516, in __init__
if self.time_end <= self.time_start \
TypeError: '<=' not supported between instances of 'GameClock' and 'GameClock'

--
components: 2to3 (2.x to 3.x conversion tool)
files: simple_example.py
messages: 348961
nosy: xxm
priority: normal
severity: normal
status: open
title: 2to3 not  handing "<="
type: compile error
versions: Python 3.7
Added file: https://bugs.python.org/file48528/simple_example.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37752] Redundant Py_CHARMASK called in normalizestring(codecs.c)

[hai shi]

hai shi  added the comment:

Looks the PR is confused. Make sure: one PR on one dev branch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

[Sascha Silbe]

Change by Sascha Silbe :


--
nosy: +sascha_silbe

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37752] Redundant Py_CHARMASK called in normalizestring(codecs.c)

[Jordon.X]

Change by Jordon.X <9651...@qq.com>:


--
keywords: +patch, patch
pull_requests: +14839, 14840
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/15093

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37752] Redundant Py_CHARMASK called in normalizestring(codecs.c)

[Jordon.X]

Change by Jordon.X <9651...@qq.com>:


--
keywords: +patch
pull_requests: +14839
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/15093

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.

[Jordon.X]

Jordon.X <9651...@qq.com> added the comment:

The design and code of the following four places need to be consistent,

No.1 https://github.com/python/peps/blob/master/pep-0100.txt#L292
No.2 https://github.com/python/cpython/blob/master/Python/codecs.c#L113
No.3 https://github.com/python/cpython/blob/master/Python/codecs.c#L53  
No.4 https://github.com/python/cpython/blob/master/Python/codecs.c#74

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37748] IDLE: Re-order run menu

[Tal Einat]

Tal Einat  added the comment:

Perhaps we should use a separator to differentiate between things that run in 
the shell and those that don't, e.g. as following:

Run Module
Run... Customized
Python Shell
-
Check Module

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37752] Redundant Py_CHARMASK called in normalizestring(codecs.c)

[hai shi]

hai shi  added the comment:

Good catch ;), try to fix it, thanks.

--
nosy: +shihai1991

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.

[hai shi]

hai shi  added the comment:

Hm, there is a bit misleading between 
desc(https://github.com/python/cpython/blob/master/Python/codecs.c#L53) and the 
code (https://github.com/python/cpython/blob/master/Python/codecs.c#L74).

--
nosy: +shihai1991

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.

[Jordon.X]

Change by Jordon.X <9651...@qq.com>:


--
keywords: +patch
pull_requests: +14838
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/15092

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37752] Redundant Py_CHARMASK called in normalizestring(codecs.c)

[Jordon.X]

New submission from Jordon.X <9651...@qq.com>:

In normalizestring(),
ch = Py_TOLOWER(Py_CHARMASK(ch));
Where Py_TOLOWER is defined as following,
#define Py_TOLOWER(c) (_Py_ctype_tolower[Py_CHARMASK(c)])

Redundant Py_CHARMASK called here.

--
components: Unicode
messages: 348955
nosy: ezio.melotti, qigangxu, vstinner
priority: normal
severity: normal
status: open
title: Redundant Py_CHARMASK called in normalizestring(codecs.c)
type: performance
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.

[Jordon.X]

Jordon.X <9651...@qq.com> added the comment:

and I will try to fix it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.

[Jordon.X]

New submission from Jordon.X <9651...@qq.com>:

In codecs.c,  when _PyCodec_Lookup() call normalizestring(), both spaces and 
hyphens should be convered to underscores. Not convert spaces to hyphens.

see:https://github.com/python/peps/blob/master/pep-0100.txt, Codecs 
(Coder/Decoders) Lookup

--
components: Unicode
messages: 348953
nosy: ezio.melotti, qigangxu, vstinner
priority: normal
severity: normal
status: open
title: In codecs,  function 'normalizestring' should convert both spaces and 
hyphens to underscores.
type: behavior
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19692] Rename Py_SAFE_DOWNCAST

[STINNER Victor]

STINNER Victor  added the comment:

I dislike this macro. A cast is either safe or unsafe. If it is safe, (type)var 
would be better. If it is unsafe, well, it would be better to add a runtime 
check. No? (I mean better error reporting than abort() pnly in debug mode.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19692] Rename Py_SAFE_DOWNCAST

[Stefan Krah]

Stefan Krah  added the comment:

Why would one not abort() in release mode? If the cast is inexact, the results 
will usually be so wrong that even on a web server a hard exit is preferable.

I don't think the check costs much time with branch prediction.

--
nosy: +skrah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36273] test_thread leaks a core dump on PPC64 AIX 3.x

[Michael Felt]

Michael Felt  added the comment:

correction - issue18049 was related to test_threading. cannot say for sure that 
"this" is resolved by 18049. apologies for noise.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36273] test_thread leaks a core dump on PPC64 AIX 3.x

[Michael Felt]

Michael Felt  added the comment:

resolved via issue18049

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37750] PyBuffer_FromContiguous not documented

[hai shi]

Change by hai shi :


--
keywords: +patch
pull_requests: +14837
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/15091

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37750] PyBuffer_FromContiguous not documented

[hai shi]

New submission from hai shi :

as the title said.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37750] PyBuffer_FromContiguous not documented

[hai shi]

Change by hai shi :


--
assignee: docs@python
components: Documentation
nosy: docs@python, shihai1991
priority: normal
severity: normal
status: open
title: PyBuffer_FromContiguous not documented

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36502] str.isspace() for U+00A0 and U+202F differs from document

[Greg Price]

Greg Price  added the comment:

The actual behavior turns out to match that comment. See attached PR, which 
adds a test confirming that and also corrects the documentation.

(A related issue is #18236 -- we should probably adjust the definition to match 
the one Unicode now provides. But meanwhile we'll want to correct the docs.)

--
nosy: +Greg Price

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36502] str.isspace() for U+00A0 and U+202F differs from document

[Greg Price]

Change by Greg Price :


--
keywords: +patch
pull_requests: +14836
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/15019

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19692] Rename Py_SAFE_DOWNCAST

[hai shi]

hai shi  added the comment:

Rename Py_SAFE_DOWNCAST in PR_15090.

In the C API: Py_TRASHCAN_SAFE_BEGIN and Py_TRASHCAN_SAFE_END should be removed 
or keep it due to compatibility?

In the stdlib: Looks that it's not changed is ok.

--
nosy: +shihai1991

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19692] Rename Py_SAFE_DOWNCAST

[hai shi]

Change by hai shi :


--
keywords: +patch
pull_requests: +14835
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/15090

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18049] Re-enable threading test on macOS

[Ronald Oussoren]

Change by Ronald Oussoren :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18049] Re-enable threading test on macOS

[miss-islington]

Change by miss-islington :


--
pull_requests: +14834
pull_request: https://github.com/python/cpython/pull/15089

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18049] Re-enable threading test on macOS

[Ronald Oussoren]

Ronald Oussoren  added the comment:


New changeset 9670ce76b83bde950020f8d89c4d27168aaaf912 by Ronald Oussoren 
(Michael Felt) in branch 'master':
bpo-18049: Define THREAD_STACK_SIZE for AIX to pass default recursion limit 
test (GH-15081)
https://github.com/python/cpython/commit/9670ce76b83bde950020f8d89c4d27168aaaf912


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34697] ctypes: Crash if manually-created CField instance is used

[hai shi]

hai shi  added the comment:

ping

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com