[issue39816] More descriptive error message than "too many values to unpack"

2020-03-16 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch nosy: +ZackerySpytz nosy_count: 4.0 -> 5.0 pull_requests: +18387 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19036 ___ Python tracker

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

2020-03-16 Thread Ned Deily
Ned Deily added the comment: There is nothing more for you to do for this on the Mac side right now, thanks. I’m not sure what the Status of changes for Windows build are. Perhaps that should be a separate issue as the two aren’t really related. --

[issue39985] str.format and string.Formatter subscript behaviors diverge

2020-03-16 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39984] Move some ceval fields from _PyRuntime.ceval to PyInterpreterState.ceval

2020-03-16 Thread Paulo Henrique Silva
Change by Paulo Henrique Silva : -- nosy: +phsilva ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue5944] test_os failure on OS X, probably related to PEP 383

2020-03-16 Thread Matthias Braun
Matthias Braun added the comment: I believe my suggested pull request in https://bugs.python.org/issue39986 may solve this issue as a side effect because we no longer list the root directory but a temporary directory with controlled filenames. -- nosy: +Matthias Braun

[issue38454] test_listdir is failing on ubuntu with WSL

2020-03-16 Thread Matthias Braun
Matthias Braun added the comment: I believe my suggested pull request in https://bugs.python.org/issue39986 may solve this issue as a side effect because we no longer list the root directory but a temporary directory with controlled filenames. -- nosy: +Matthias Braun

[issue39986] test_os / test_listdir failed as root-directory changed during test

2020-03-16 Thread Matthias Braun
Change by Matthias Braun : -- keywords: +patch pull_requests: +18386 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19035 ___ Python tracker ___

[issue39511] [subinterpreters] Per-interpreter singletons (None, True, False, etc.)

2020-03-16 Thread Larry Hastings
Larry Hastings added the comment: > We should do that for each singletons: > > * None (Py_None) > * True (Py_True) > * False (Py_False) > * Ellipsis (Py_Ellipsis) Aren't there a couple more lurking in the interpreter? E.g. empty tuple, empty frozenset. > That is exactly why I didn't

[issue39986] test_os / test_listdir failed as root-directory changed during test

2020-03-16 Thread Matthias Braun
New submission from Matthias Braun : The test_listdir test from Lib/test/test_os.py is using os.listdir() twice in the root directory with and without parameters and compares the results. I just had the test fail for me, because an unrelated process happened to create a file in the root

[issue39974] A race condition with GIL releasing exists in stringlib_bytes_join

2020-03-16 Thread Inada Naoki
Change by Inada Naoki : -- stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue39985] str.format and string.Formatter subscript behaviors diverge

2020-03-16 Thread Maxwell Bernstein
New submission from Maxwell Bernstein : As I understand it, str.format and string.Formatter are supposed to behave the same, with string.Formatter being a pluggable variant. While poking at string.Formatter, I noticed that they do not behave the same when formatting a nameless subscript: ```

[issue39982] FreeBSD: SCTP tests of test_socket fails on AMD64 FreeBSD Shared 3.x

2020-03-16 Thread Kubilay Kocak
Kubilay Kocak added the comment: Saw the following commit which *may* be related: "Log: sendfile() does currently not support SCTP sockets. Therefore, fail the call. " https://svnweb.freebsd.org/changeset/base/358965 I'm updating FreeBSD base on the BB worker to include that commit and

[issue39954] test_subprocess: test_specific_shell() fails on AMD64 FreeBSD Shared 3.x

2020-03-16 Thread Kubilay Kocak
Kubilay Kocak added the comment: The current test runs a try/finally without any exception handling, so even minimal exception handling will cover a large swatch of potential issues. CalledProcessError [1] returned by check_call() or check_output() appears to be handy [1]

[issue1635741] Py_Finalize() doesn't clear all Python objects at exit

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset 2037502613471a0a0a0262085cc50adb378ebbad by Hai Shi in branch 'master': bpo-1635741: Port _ctypes_test extension to multiphase initialization (PEP 489) (GH-19012)

[issue38644] Pass explicitly tstate to function calls

2020-03-16 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18385 pull_request: https://github.com/python/cpython/pull/19034 ___ Python tracker ___

[issue31857] Make the behavior of USE_STACKCHECK deterministic

2020-03-16 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18384 pull_request: https://github.com/python/cpython/pull/19034 ___ Python tracker ___

[issue39984] Move some ceval fields from _PyRuntime.ceval to PyInterpreterState.ceval

2020-03-16 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +18383 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19034 ___ Python tracker ___

[issue39984] Move some ceval fields from _PyRuntime.ceval to PyInterpreterState.ceval

2020-03-16 Thread STINNER Victor
New submission from STINNER Victor : The _PyRuntime.ceval structure should be made "per-interpreter". I don't want to make the GIL per-interpreter: that's out of the scope of this issue. So I propose to only move a few fields to make more ceval fields "per interpreter". --

[issue39576] Surprising MemoryError in `decimal` with MAX_PREC

2020-03-16 Thread Stefan Krah
Change by Stefan Krah : -- assignee: -> skrah keywords: -3.7regression, patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue39576] Surprising MemoryError in `decimal` with MAX_PREC

2020-03-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > I mean, it's not okay to complain about a regression and then mention xlc about 10 mails later. How is this related? Or is not ok to report a behaviour change in a stable release even if the platform is "best-effort"? A regression by definition is

[issue32521] NIS module fails to build due to the removal of interfaces related to Sun RPC from glibc.

2020-03-16 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: Closing the issue as python2 is not receiving any more fixes and our downstream workaround is enough for it. Python3 is fine as well. -- status: open -> closed ___ Python tracker

[issue39576] Surprising MemoryError in `decimal` with MAX_PREC

2020-03-16 Thread Stefan Krah
Change by Stefan Krah : -- assignee: -> skrah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39576] Surprising MemoryError in `decimal` with MAX_PREC

2020-03-16 Thread Stefan Krah
Stefan Krah added the comment: BTW, if you are compiling with xlc and there"s no xlc buildbot, perhaps a company-that-shall-not-be-named should provide one. I mean, it's not okay to complain about a regression and then mention xlc about 10 mails later. --

[issue39576] Surprising MemoryError in `decimal` with MAX_PREC

2020-03-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Btw, this is AIX 7.1.0.0 with xlc in case that is relevant. -- ___ Python tracker ___ ___

[issue39576] Surprising MemoryError in `decimal` with MAX_PREC

2020-03-16 Thread Stefan Krah
Stefan Krah added the comment: These flags worked for xlc when snakebite was still up: ./configure CC=xlc_r AR="ar -X64" CFLAGS="-q64 -qmaxmem=7" LDFLAGS="-q64" -qmaxmem was always finicky, I remember segfaults too (AIX problem, not libmpdec problem). --

[issue39576] Surprising MemoryError in `decimal` with MAX_PREC

2020-03-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > If you are fortunate enough to have access to an AIX system, I guess you have to find out why POWER6 AIX 3.8 and PPC64 AIX 3.8 apparently work on https://buildbot.python.org/ but your 3.7 does not. I am working on trying to debug where the problem

[issue39576] Surprising MemoryError in `decimal` with MAX_PREC

2020-03-16 Thread Stefan Krah
Stefan Krah added the comment: Hi Michael, in case you have built 3.7.7 on AIX, have you observed any problems with test_decimal? -- nosy: +Michael.Felt ___ Python tracker

[issue39576] Surprising MemoryError in `decimal` with MAX_PREC

2020-03-16 Thread Stefan Krah
Stefan Krah added the comment: > Well, I just did and I can confirm that reverting the 3.7 backport fixes the > problem. If you are fortunate enough to have access to an AIX system, I guess you have to find out why POWER6 AIX 3.8 and PPC64 AIX 3.8 apparently work on

[issue39576] Surprising MemoryError in `decimal` with MAX_PREC

2020-03-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Thanks for the lecture. This is an esoteric case between bugfix and feature that only occurs with very large context precisions. Nobody is lecturing anyone. I am just asking why this was backported. > If Bloomberg isn't happy with _decimal, they can

[issue39576] Surprising MemoryError in `decimal` with MAX_PREC

2020-03-16 Thread Stefan Krah
Stefan Krah added the comment: > This code has introduced a regression in AIX in Python 3.7.7 Also this is a rather bold statement since probably no one has ever run _decimal on AIX with MAX_PREC. -- ___ Python tracker

[issue39982] FreeBSD: SCTP tests of test_socket fails on AMD64 FreeBSD Shared 3.x

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: Same issue on AMD64 FreeBSD Shared 3.8: https://buildbot.python.org/all/#builders/18/builds/162 It looks more like a recent FreeBSD upgrade than a Python regression. 3.8 fail, build 162: os.uname: posix.uname_result(sysname='FreeBSD',

[issue39932] test_multiprocessing_fork leaked [0, 2, 0] file descriptors on aarch64 RHEL8 Refleaks 3.7 buildbot

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: Bug seen on Pytho 3.7 branch, on Fedora Stable, RHEL7 and RHEL8, on different architectures. aarch64 RHEL7 Refleaks 3.7: https://buildbot.python.org/all/#builders/598/builds/22 PPC64LE RHEL7 Refleaks 3.7:

[issue39983] test.regrtest: test marked as failed (env changed), but no warning: test_multiprocessing_forkserver

2020-03-16 Thread STINNER Victor
New submission from STINNER Victor : Tests run with --fail-env-changed. test_multiprocessing_forkserver failed with "env changed", but no warning was logged to explain why :-( PPC64LE RHEL7 3.8: https://buildbot.python.org/all/#/builders/401/builds/69 ./python ./Tools/scripts/run_tests.py

[issue39576] Surprising MemoryError in `decimal` with MAX_PREC

2020-03-16 Thread Stefan Krah
Stefan Krah added the comment: > This looks like a "new feature/improvement". Why was this code backported to > a stable version? Thanks for the lecture. This is an esoteric case between bugfix and feature that only occurs with very large context precisions. If Bloomberg isn't happy with

[issue39982] FreeBSD: SCTP tests of test_socket fails on AMD64 FreeBSD Shared 3.x

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: It worked 10 days ago: https://buildbot.python.org/all/#/builders/152/builds/382 -- ___ Python tracker ___

[issue39982] FreeBSD: SCTP tests of test_socket fails on AMD64 FreeBSD Shared 3.x

2020-03-16 Thread STINNER Victor
New submission from STINNER Victor : AMD64 FreeBSD Shared 3.x: https://buildbot.python.org/all/#/builders/152/builds/409 == ERROR: testSendmsg (test.test_socket.SendmsgSCTPStreamTest)

[issue39576] Surprising MemoryError in `decimal` with MAX_PREC

2020-03-16 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +ned.deily ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39576] Surprising MemoryError in `decimal` with MAX_PREC

2020-03-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This looks like a "new feature/improvement". Why was this code backported to a stable version? -- ___ Python tracker ___

[issue39576] Surprising MemoryError in `decimal` with MAX_PREC

2020-03-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This code has introduced a regression in AIX in Python 3.7.7 as the new "test_maxcontext_exact_arith" test hangs indefinitely or just segfaults. -- keywords: +3.7regression nosy: +pablogsal resolution: fixed -> status: closed -> open

[issue36017] test_grp

2020-03-16 Thread Matthias Braun
Change by Matthias Braun : -- keywords: +patch nosy: +Matthias Braun nosy_count: 1.0 -> 2.0 pull_requests: +18382 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19033 ___ Python tracker

[issue10572] Move test sub-packages to Lib/test

2020-03-16 Thread Ned Deily
Ned Deily added the comment: > some vendors like to leave out the tests and not having them all under 'test' > prevents that from working cleanly Yeah, but presumably all the major distributors have long ago figured out how to do this (it's not *that* hard) and, by moving the tests now,

[issue10572] Move test sub-packages to Lib/test

2020-03-16 Thread Zachary Ware
Zachary Ware added the comment: I'm personally still in favor of the change. This wouldn't be the first big movement of files in our repo and likely not the last, and I don't think git/GitHub's support (or lack thereof) for file moves is a good enough reason to not organize things better.

[issue26067] test_shutil fails when gid name is missing

2020-03-16 Thread Matthias Braun
Matthias Braun added the comment: I have the same issue on my work macbook which has some form of network login configured. The primary group id of my user account there cannot be found in the group database and cannot be resolved to a name. I'm not sure why that is but I am pretty sure

[issue10572] Move test sub-packages to Lib/test

2020-03-16 Thread Éric Araujo
Éric Araujo added the comment: Yes, I recommend against this change. Sorry for the time already spent :( (I only named Mercurial because python-dev used it before, so I was comparing the behaviour of the two tools) -- ___ Python tracker

[issue26067] test_shutil fails when gid name is missing

2020-03-16 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch nosy: +python-dev nosy_count: 3.0 -> 4.0 pull_requests: +18381 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/19032 ___ Python tracker

[issue39981] Default values for AST Nodes

2020-03-16 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- keywords: +patch pull_requests: +18380 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19031 ___ Python tracker ___

[issue39981] Default values for AST Nodes

2020-03-16 Thread Batuhan Taskaya
New submission from Batuhan Taskaya : For omitting some defaults, @serhiy.storchaka already added support to initialize some ast nodes with some default values (optional fields). An example; >>> ast.Constant().kind is None True This isn't exactly a default value, but some kind of class

[issue39980] importlib.resources.path() may return incorrect path when using custom loader

2020-03-16 Thread Krzysztof Rusek
Krzysztof Rusek added the comment: Maybe importlib.resources.path() should skip checking file existence when ResourceReader.resource_path() raises FileNotFoundError? Current logic: @contextmanager def path(package: Package, resource: Resource) -> Iterator[Path]: resource =

[issue35370] Add _PyEval_SetTrace(tstate, func, arg) function

2020-03-16 Thread Fabio Zadrozny
Fabio Zadrozny added the comment: >> I.e.: something as adding a thread_id to sys.settrace -- >> sys.settrace(trace_func, thread_id=None). > What is the use case for this feature? The use case is having the user attach the debugger (either programmatically or by doing an attach to process)

[issue39980] importlib.resources.path() may return incorrect path when using custom loader

2020-03-16 Thread Krzysztof Rusek
New submission from Krzysztof Rusek : importlib.resources.path() function may return a path to a file with different contents than expected. This may happen when using a custom loader implementation that uses fake filenames (like ''). I'm attaching a reproduction test (resources.py).

[issue39959] (Possible) bug on multiprocessing.shared_memory

2020-03-16 Thread Jeff Fischer
Jeff Fischer added the comment: I've run into the same problem. It appears that the SharedMemory class is assuming that all clients of a segment are child processes from a single parent, and that they inherit the same resource_tracker. If you run separate, unrelated processes, you get a

[issue39656] shebanged scripts can escape from `venv` depending on how it was created

2020-03-16 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch pull_requests: +18379 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19030 ___ Python tracker ___

[issue35370] Add _PyEval_SetTrace(tstate, func, arg) function

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: > I.e.: something as adding a thread_id to sys.settrace -- > sys.settrace(trace_func, thread_id=None). What is the use case for this feature? It seems quite complicated to implement the thread_id for sys.settrace(trace_func, thread_id=None). Currently,

[issue37860] Add deploy preview for docs

2020-03-16 Thread Brett Cannon
Change by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39968] port extension modules' macros of `get_module_state()` to inline function.

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: > This macOS job should be enhanced? setup.py skips optional dependencies like readline on purpose. readline is built again onx86-64 macOS 3.x buildbot worker and test_readline passed. I close the issue. Thanks for the quick fix. -- resolution:

[issue39824] Multi-phase extension module (PEP 489): don't call m_traverse, m_clear nor m_free before the module state is allocated

2020-03-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I think Cython makes use of PEP-489 so unless I am missing something all generated extensions use PEP-489 structures. -- ___ Python tracker

[issue39968] port extension modules' macros of `get_module_state()` to inline function.

2020-03-16 Thread hai shi
hai shi added the comment: > Oh, macOS job was marked as success on PR 19017 :-( yeah, it's weird. This macOS job should be enhanced? -- ___ Python tracker ___

[issue35312] lib2to3.pgen2.parse.ParseError is not roundtrip pickleable

2020-03-16 Thread Anthony Sottile
Change by Anthony Sottile : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39971] Error on documentation - Quick fix.

2020-03-16 Thread Diogo Flores
Diogo Flores added the comment: Agreed, Eric. Nevertheless, I think that this example might raise unnecessary confusion to someone new to Python, and hence the reason why I decided to open the issue. Anyhow, I trust your judgement and please feel free to leave things as is and close this

[issue36478] backport of pickle fixes to Python 3.5.7 uses C99 for loops

2020-03-16 Thread Anthony Sottile
Change by Anthony Sottile : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37695] Incorrect error message for `unget_wch(bytes_object)`

2020-03-16 Thread Anthony Sottile
Change by Anthony Sottile : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue25024] Allow passing "delete=False" to TemporaryDirectory

2020-03-16 Thread Anthony Sottile
Anthony Sottile added the comment: I would certainly like to see this, it would eliminate my last few hand rolled temporary directory contexts Mauro would you be interested in re-posting this patch as a PR to github? (or allowing someone else to carry your patch forward?) -- nosy:

[issue35370] Add _PyEval_SetTrace(tstate, func, arg) function

2020-03-16 Thread Fabio Zadrozny
Fabio Zadrozny added the comment: >> As a note, the original request was for a Python-level tracing function (so >> that in the future other Python implementations also provide that function) >> -- does this need a PEP? > What do you mean by a Python-level tracing function? I mean that

[issue39968] port extension modules' macros of `get_module_state()` to inline function.

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: > Compile is failure after PR 19017 is merged on macOS. Oh, macOS job was marked as success on PR 19017 :-( https://github.com/python/cpython/runs/509226542 But I confirm that I can read there: """ Failed to build these modules: _tkinter

[issue35370] Add _PyEval_SetTrace(tstate, func, arg) function

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset 046255c40fc0d9c5a4c528eb5955792fa08df66f by Victor Stinner in branch '3.8': bpo-35370: PyEval_SetTrace() logs unraisable error (GH-18977) (GH-19029) https://github.com/python/cpython/commit/046255c40fc0d9c5a4c528eb5955792fa08df66f --

[issue35370] Add _PyEval_SetTrace(tstate, func, arg) function

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: > As a note, the original request was for a Python-level tracing function (so > that in the future other Python implementations also provide that function) > -- does this need a PEP? What do you mean by a Python-level tracing function? --

[issue37207] Use PEP 590 vectorcall to speed up calls to range(), list() and dict()

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset 6ff79f65820031b219622faea8425edaec9a43f3 by Dong-hee Na in branch 'master': bpo-37207: Use PEP 590 vectorcall to speed up set() constructor (GH-19019) https://github.com/python/cpython/commit/6ff79f65820031b219622faea8425edaec9a43f3

[issue39968] port extension modules' macros of `get_module_state()` to inline function.

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset 5f104d56fa10f88098338b3f1ea74bcbe6924ca9 by Hai Shi in branch 'master': bpo-39968: Fix a typo error in get_readline_state() (GH-19028) https://github.com/python/cpython/commit/5f104d56fa10f88098338b3f1ea74bcbe6924ca9 --

[issue39974] A race condition with GIL releasing exists in stringlib_bytes_join

2020-03-16 Thread tzickel
tzickel added the comment: My mistake... -- resolution: -> not a bug ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35370] Add _PyEval_SetTrace(tstate, func, arg) function

2020-03-16 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18378 pull_request: https://github.com/python/cpython/pull/19029 ___ Python tracker ___

[issue35370] Add _PyEval_SetTrace(tstate, func, arg) function

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset f6a58507820c67e8d0fb07875cd1b1d9f5e510a8 by Victor Stinner in branch 'master': bpo-35370: PyEval_SetTrace() logs unraisable error (GH-18977) https://github.com/python/cpython/commit/f6a58507820c67e8d0fb07875cd1b1d9f5e510a8 --

[issue39977] Python aborts trying to load libcrypto.dylib

2020-03-16 Thread Ned Deily
Ned Deily added the comment: The crash report gives the reason for the crash: Application Specific Information: /usr/lib/libcrypto.dylib abort() called Invalid dylib load. Clients should not load the unversioned libcrypto dylib as it does not have a stable ABI. This means something you are

[issue36078] argparse: positional with type=int, default=SUPPRESS raise ValueError

2020-03-16 Thread paul j3
paul j3 added the comment: You are right, this part of the same issue. _get_value() tests '==SUPPRESS==' both for type and choices. -- ___ Python tracker ___

[issue39979] Cannot tune scrypt with large enough parameters

2020-03-16 Thread Gle
New submission from Gle : I can use scrypt KDF with the cryptography module https://cryptography.io/en/latest/hazmat/primitives/key-derivation-functions/#cryptography.hazmat.primitives.kdf.scrypt.Scrypt with large parameters (n=2**20, r=16, p=1) On the other hand, using scrypt KDF from hashlib

[issue39968] port extension modules' macros of `get_module_state()` to inline function.

2020-03-16 Thread hai shi
hai shi added the comment: > See also: https://github.com/python/cpython/runs/509226542#step:4:305 Oh, thanks, Dong-hee Na. I create a PR for this typo error. -- ___ Python tracker

[issue39968] port extension modules' macros of `get_module_state()` to inline function.

2020-03-16 Thread hai shi
Change by hai shi : -- pull_requests: +18377 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/19028 ___ Python tracker ___

[issue39968] port extension modules' macros of `get_module_state()` to inline function.

2020-03-16 Thread Dong-hee Na
Dong-hee Na added the comment: I reopen this issue for the above problem -- resolution: fixed -> status: closed -> open ___ Python tracker ___

[issue39978] Vectorcall implementation should conform to PEP 590.

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: > The change has a negative impact on performance How did you notice the slowdown? I ran benchmarks in https://github.com/python/cpython/pull/17052 and I didn't notice any performance overhead. -- ___ Python

[issue1635741] Py_Finalize() doesn't clear all Python objects at exit

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset 356c878fbf2a97aa3ab7951fd7456d219ff0b466 by Dong-hee Na in branch 'master': bpo-1635741: Port _statistics module to multiphase initialization (GH-19015) https://github.com/python/cpython/commit/356c878fbf2a97aa3ab7951fd7456d219ff0b466

[issue36078] argparse: positional with type=int, default=SUPPRESS raise ValueError

2020-03-16 Thread Tomáš Jeziorský
Tomáš Jeziorský added the comment: I found what appears to be a very similar issue so instead of creating a new issue I will place it here as a comment. The following code: == import argparse parser = argparse.ArgumentParser() parser.add_argument('letter', choices=['a', 'b', 'c'],

[issue39968] port extension modules' macros of `get_module_state()` to inline function.

2020-03-16 Thread Dong-hee Na
Dong-hee Na added the comment: See also: https://github.com/python/cpython/runs/509226542#step:4:305 -- ___ Python tracker ___ ___

[issue39968] port extension modules' macros of `get_module_state()` to inline function.

2020-03-16 Thread Dong-hee Na
Dong-hee Na added the comment: > cpython/Modules/readline.c:90:20: error: unknown type name 'PyModule' get_readline_state(PyModule *module) Compile is failure after PR 19017 is merged on macOS. -- nosy: +corona10 ___ Python tracker

[issue39978] Vectorcall implementation should conform to PEP 590.

2020-03-16 Thread Jeremy Kloth
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36287] Make ast.dump() not output optional default fields

2020-03-16 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: Actually I have a better solution for this (which I hope to share really soon if it works.) I think we can do default value initialization for both Nones (with your patch) and lists, it requires a bit of extra work but I think I can do it. --

[issue39978] Vectorcall implementation should conform to PEP 590.

2020-03-16 Thread Mark Shannon
New submission from Mark Shannon : The implementation of `PyObject_Vectorcall` adds unnecessary overhead to PEP 590, which undermines its purpose. The implementation was changed in https://github.com/python/cpython/pull/17052, which I objected to at the time. The change has a negative impact

[issue37207] Use PEP 590 vectorcall to speed up calls to range(), list() and dict()

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset 87ec86c425a5cd3ad41b831b54c0ce1a0c363f4b by Dong-hee Na in branch 'master': bpo-37207: Add _PyArg_NoKwnames() helper function (GH-18980) https://github.com/python/cpython/commit/87ec86c425a5cd3ad41b831b54c0ce1a0c363f4b --

[issue39970] Combined behavior of datetime.datetime.timestamp() and datetime.datetime.utcnow() on non-UTC timezoned machines

2020-03-16 Thread Paul Ganssle
Paul Ganssle added the comment: @Yi Luan I think you may misunderstand what the `.timestamp()` function does - it returns an epoch time, which is the amount of time (in seconds) elapsed since the Unix epoch: https://en.wikipedia.org/wiki/Unix_time The number is not different depending on

[issue37207] Use PEP 590 vectorcall to speed up calls to range(), list() and dict()

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset c98f87fc330eb40fbcff627dfc50958785a44f35 by Dong-hee Na in branch 'master': bpo-37207: Use _PyArg_CheckPositional() for tuple vectorcall (GH-18986) https://github.com/python/cpython/commit/c98f87fc330eb40fbcff627dfc50958785a44f35 --

[issue39968] port extension modules' macros of `get_module_state()` to inline function.

2020-03-16 Thread hai shi
hai shi added the comment: Wow, thanks, victor. those msgs is very helpful to me. -- ___ Python tracker ___ ___ Python-bugs-list

[issue39968] port extension modules' macros of `get_module_state()` to inline function.

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: Oh, I forgot a cool advantage that I discovered late: debuggers and profilers understand inlined code and are able to get the name of the static inline function, whereas it's not possible to do that with macros. If I recall correctly, it works even if the

[issue39954] test_subprocess: test_specific_shell() fails on AMD64 FreeBSD Shared 3.x

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: Do you suggest to skip the test if returncode has a specific value? -- ___ Python tracker ___

[issue38856] asyncio ProactorEventLoop: wait_closed() can raise ConnectionResetError

2020-03-16 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39892] Enable DeprecationWarnings by default when not explicit in unittest.main()

2020-03-16 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39824] Multi-phase extension module (PEP 489): don't call m_traverse, m_clear nor m_free before the module state is allocated

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: I updated PR 18738 to document the incompatible change in What's New In Python 3.9. Sadly, I expect that almost no third-party extension module implement the PEP 489 yet. So I expect that little or no third-party code is impacted in pratice. > the module

[issue39968] port extension modules' macros of `get_module_state()` to inline function.

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: Note: Hai Shi is working hard on converting modules to multiphase module initialization (PEP 489) which helps to cleanup the Python state at exit, and subinterpreters will likely benefit of that. This issue is related to this work. --

[issue39968] port extension modules' macros of `get_module_state()` to inline function.

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: There are multiple good reasons to replace macros with static inline functions: * Parameter types and return value are well defined * Less error-prone: avoid completely https://gcc.gnu.org/onlinedocs/gcc-9.3.0/cpp/Macro-Pitfalls.html#Macro-Pitfalls *

[issue39968] port extension modules' macros of `get_module_state()` to inline function.

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset f707d94af68a15afc27c1a9da5835f9456259fea by Hai Shi in branch 'master': bpo-39968: Convert extension modules' macros of get_module_state() to inline functions (GH-19017)

[issue39974] A race condition with GIL releasing exists in stringlib_bytes_join

2020-03-16 Thread Ma Lin
Ma Lin added the comment: I also planned to review this commit at some moment, I feel a bit unsteady about it. If an optimization needs to be fine-tuned, and may introduces some pitfalls for future code maintenance, IMHO it is best to avoid doing this kind of optimization. --

[issue39939] Add str methods to remove prefixes or suffixes

2020-03-16 Thread STINNER Victor
STINNER Victor added the comment: The proposed change will affect many builtin types: bytes, bytearray, str, but also other types like collections.UserString. Would it make sense to summarize what has been said in the python-ideas thread into a PEP? It may good to specify things like:

[issue10572] Move test sub-packages to Lib/test

2020-03-16 Thread Ido Michael
Ido Michael added the comment: Hey Eric, I'm not sure what you mean, you don't recommend the change in general? Or you just don't recommend Git for this and saying I should use Mercurial instead? -- ___ Python tracker

  1   2   >