[issue13336] packaging.command.Command.copy_file doesn't implement preserve_mode and preserve_times

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: Thanks for the report. Have you found the bug with a real setup.cfg or hook, or were you just reading the code? I’m not sure how hard to fix this will be. The copy_file method delegates to shutil.copyfile, but this does not have the arguments we need

[issue13282] the table of contents in epub file is too long

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: Thanks for the report. I do not know if this something that we can fix in the CPython repository by editing some template or config file or if it requires a patch to Sphinx first. Georg? -- nosy: +eric.araujo, georg.brandl

[issue13281] Make robotparser.RobotFileParser ignore blank lines

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: First, I’d like to remind that the robots spec is not an official Internet spec backed up by an official body. It’s also not as important as (say) HTTP parsing. For this bug, IMO the guiding principle should be Postel’s Law. What harm is there in being more

[issue13249] argparse.ArgumentParser() lists arguments in the wrong order

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: Thanks, I’ve made some comments on Rietveld. > Added a recommendation to only use keywords, which seems sane given > the number of arguments. I looked for that but couldn’t find it. -- nosy: +eric.araujo ___

[issue12103] Document how to use open with os.O_CLOEXEC

2011-11-12 Thread Éric Araujo
Changes by Éric Araujo : -- keywords: +easy nosy: +eric.araujo title: Documentation of open() does not claim 'e' support in mode string -> Document how to use open with os.O_CLOEXEC versions: +Python 3.3 -Python 2.7 ___ Python t

[issue13264] Monkeypatching using metaclass

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: It seems to me this is not a bug. Closing? -- nosy: +eric.araujo ___ Python tracker <http://bugs.python.org/issue13264> ___ ___

[issue13286] PEP 3151 breaks backward compatibility: it should be documented

2011-11-12 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker <http://bugs.python.org/issue13286> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12344] Add **kwargs to reinitialize_command

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: I’ve spent some time on this. First, I decided that the former name (reinitialize_command) of the method was better. The get_* name could create the impression that the returned object was independent from the internal caches (command_obj, have_run), but it

[issue12344] Add **kwargs to reinitialize_command

2011-11-12 Thread Éric Araujo
Changes by Éric Araujo : Added file: http://bugs.python.org/file23659/fix-reinitialize-command.diff ___ Python tracker <http://bugs.python.org/issue12344> ___ ___ Pytho

[issue12344] Add **kwargs to reinitialize_command

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: BTW, here’s the changeset to rename get_reinit_etc. -- Added file: http://bugs.python.org/file23660/rename-grc.diff ___ Python tracker <http://bugs.python.org/issue12

[issue12119] distutils and python -B

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: A 1999 comment in build_py from Greg Ward agrees with me: # XXX hey! we can't control whether we optimize or not; that's up # to the invocation of the current Python interpreter (at least # according to the py_compile docs). That sucks.

[issue13193] test_packaging and test_distutils failures

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: > This problem was not trivial to find, because it appears that test execution > order may not be > entirely deterministic: I couldn't see any other reason why the flag would > have different values > on different machines. On my machine, it

[issue13204] sys.flags.__new__ crashes

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: You are right. Even if it’s an undocumented internal type, there is no reason not to fix it. There are plenty of similar crash fixes committed in the repo. -- ___ Python tracker <http://bugs.python.org/issue13

[issue13294] http.server: HEAD request should not return a body

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: > Right now the HEAD returns something :) Ah, so this is a bug. > I still need to propose a patch. A patch to add a test (for 2.7 or 3.2, see devguide) would be a great first step. -- title: http.server - HEAD request when no resource is d

[issue13180] pysetup silently ignores invalid entries in setup.cfg

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: I want to explore ideas about a schema/type system, so I’m removing the easy keyword. -- keywords: -easy ___ Python tracker <http://bugs.python.org/issue13

[issue13387] add exact_type argument to assertIsInstance

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: I find that assertIs(type(x), someclass) is very clear, whereas an assertIsInstance that would not behave like isinstance depending on one argument would be non-obvious to me. -- nosy: +eric.araujo ___ Python tracker

[issue1011113] Make “install” find the build_base directory

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: I’ve found a distutils commit that shows that this option was removed on purpose, because people might except that using “install -b foo” would affect the build command, but it does not. I don’t think it’s a problem. For people who run build and install in

[issue13193] test_packaging and test_distutils failures

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: > That's "should", not "must". I read that “should” as a polite “must”. > Also, I thought people did undocumented things with distutils, and we > had to support these undocumented uses? People rely on undocumented features and s

[issue9831] test_distutils should honor PYTHONDONTWRITEBYTECODE

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: I now think the change I did was wrong. See #12119. -- ___ Python tracker <http://bugs.python.org/issue9831> ___ ___ Python-bug

[issue12246] Support installation when running from an uninstalled Python

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: Paul Moore reported that a Python built in its checkout on Windows has no problem installing, so I’d like to revisit this. The patch was also incomplete: The install module was changed, but people could still call “pysetup run install_dist”, and that command

[issue13170] distutils2 test failures

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: All three issues fixed, thanks! I can’t push today but I will as soon as possible, probably Monday. I will open another report for the change I reverted in config; it was done on purpose by another developer to fix a bug with distutils2’s own setup script, so

[issue12659] Add tests for packaging.tests.support

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: I ported the patch to distutils2, but it fails because of some unittest internal problem. Help welcome. -- Added file: http://bugs.python.org/file23664/test_support.py ___ Python tracker <http://bugs.python.

[issue13387] add exact_type argument to assertIsInstance

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: >I would say that this one is clear too: > aelf.assertTrue(isinstance(obj, cls)) > except that the failure message is not very friendly: > AssertionError: False is not true Yeah, you have to give something as third argument to ease debugging.

[issue1677872] Efficient reverse line iterator

2011-11-12 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker <http://bugs.python.org/issue1677872> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13385] Add an explicit re.NOFLAGS flag value to the re module

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: I had too the need to find out the value to pass when there are no flags, so a mention of 0 in the doc would have been enough for me. -0 on a new constant. -- ___ Python tracker <http://bugs.python.org/issue13

[issue13198] Remove duplicate definition of write_record_file

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: Here’s the patch produced by Mike and I so far. -- keywords: +patch Added file: http://bugs.python.org/file23666/remove-duplicate-write_record_file.diff ___ Python tracker <http://bugs.python.org/issue13

[issue13239] Remove <> operator from Grammar/Grammar

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: +1 for a comment too. I’d even make it shorter: # don't look at <>, it's not a real operator (see PEP 401) -- ___ Python tracker <http://bugs.py

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

2011-11-12 Thread Éric Araujo
Éric Araujo added the comment: > since the issue only applies when sdist --format gztar, I mention that here. bztar will probably have the same issue. > Also, issue8396 suggests encoding using sys.getfilesystemencoding(). Good one! -- title: python setup.py sdist crashes if vers

[issue13239] Remove <> operator from Grammar/Grammar

2011-11-14 Thread Éric Araujo
Éric Araujo added the comment: +# <> isn't actually a valid comparison operator in Python. It's here for the +# sake of a __future__ import described in PEP 401 If we wanted to be exact, the operator isn’t here for a __future__ import but for a feature enabled by a __future_

[issue13264] Monkeypatching using metaclass

2011-11-14 Thread Éric Araujo
Éric Araujo added the comment: Artem, if you have further information to make us reconsider this issue, please add a new message. -- resolution: -> invalid stage: -> committed/rejected status: open -> closed ___ Python track

[issue13386] Document documentation conventions for optional args

2011-11-14 Thread Éric Araujo
Éric Araujo added the comment: > Do we need an introductory page aimed to the readers that explains > the conventions used in the doc? Explaining notational conventions at the start of a technical reference sounds like a best practice

[issue5819] Add PYTHONPREFIXES environment variable

2011-11-14 Thread Éric Araujo
Éric Araujo added the comment: See also #1298835 and PEP 405. -- ___ Python tracker <http://bugs.python.org/issue5819> ___ ___ Python-bugs-list mailing list Unsub

[issue1298835] Add a vendor-packages directory for system-supplied modules

2011-11-14 Thread Éric Araujo
Éric Araujo added the comment: > not all OSes have vendors I realized that because French is my native language, I interpret “vendor” as “seller” (the meaning of “vendeur”), but I think that in English it just means “distributor” and has no relation with selling. vendor-packages is argua

[issue13402] Document absoluteness of sys.executable

2011-11-14 Thread Éric Araujo
New submission from Éric Araujo : I wanted to know if sys.executable was always an absolute path but the doc does not talk about that. (My use case is that I’d like to reload a process and I wonder if I can call os.execve or if I need to use os.execvpe.) -- assignee: docs@python

[issue13388] document hg commit hooks in the devguide

2011-11-14 Thread Éric Araujo
Éric Araujo added the comment: +1 to most of the patch, except one piece of wording: “commit message hooks”. This does not occur in the Mercurial documentation or help, and is misleading (commits happen on your maching, the hooks run on the server). I’d just use “hooks” or “Mercurial hooks

[issue13249] argparse.ArgumentParser() lists arguments in the wrong order

2011-11-14 Thread Éric Araujo
Éric Araujo added the comment: I would not use a note directive. Notes and warnings distract and sometimes scare readers. For a simple coding recommendation like this, I think a regular paragraph would suffice. To make sure it’s not lost after pages of options description, maybe it could

[issue13408] Rename packaging.resources back to datafiles

2011-11-15 Thread Éric Araujo
New submission from Éric Araujo : The code dealing with the new resources subsystem used to be called datafiles (module distutils2.datafiles, file dist-info/DATAFILES, etc.). I believe it is a better name and we should use it again: - it would make clear that it’s an evolution of distutils

[issue6501] Fatal error on startup with invalid PYTHONIOENCODING

2011-11-15 Thread Éric Araujo
Éric Araujo added the comment: > Currently different environment variables are treated differently. For > example, > mistakes in PYTHONHOME and PYTHONIOENCODING cause fatal error while an error > in > PYTHONSTARTUP is reported but does not terminate python: If PYTHONSTAR

[issue13386] Document documentation conventions for optional args

2011-11-15 Thread Éric Araujo
Éric Araujo added the comment: >>> C functions that have optional arguments but don't accept keyword arguments >>> are a bit unusual, >>> and IIUC in most of the cases that's an implementation detail that could be >>> removed. >> So would i

[issue13386] Document documentation conventions for optional args

2011-11-15 Thread Éric Araujo
Éric Araujo added the comment: >> I think we should fix C functions to accept kwargs for the sake of Python >> programmers > And also for compatibility for other implementations like PyPy. Good point. > I'm still not sure that is a good idea to do a mass conversion

[issue12344] Add **kwargs to reinitialize_command

2011-11-15 Thread Éric Araujo
Éric Araujo added the comment: I’ve noticed that setuptools’ Command class also allows keyword arguments in its constructor. I’m not sure if it would be useful, but I’ve not looked in depth at the packaging codebase to see if there is code that could use that

[issue12659] Add tests for packaging.tests.support

2011-11-15 Thread Éric Araujo
Éric Araujo added the comment: > I've added runTest to Tester It turns out this was the only change needed. Tarek’s repo on bitbucket is not up-to-date, I should have given you the hg.python.org link. (You can edit .hg/hgrc in your repo and run “hg pull -u” to get missing changesets

[issue13398] _cursesmodule does not build, doesn't find Python.h on Solaris

2011-11-15 Thread Éric Araujo
Éric Araujo added the comment: This module also fails to build on my Debian. I had the libcursesw headers installed and one day it was not enough; installing libcurses headers fixes it. I don’t know if it’s the same problem or something related to Debian multiarch. -- nosy

[issue13238] Add shell command helpers to subprocess module

2011-11-15 Thread Éric Araujo
Changes by Éric Araujo : Added file: http://bugs.python.org/file23694/b267e72c8c10.diff ___ Python tracker <http://bugs.python.org/issue13238> ___ ___ Python-bugs-list m

[issue13238] Add shell command helpers to subprocess module

2011-11-15 Thread Éric Araujo
Éric Araujo added the comment: >def __init__(self, command, *, **callkwds): Is the '*' marker needed? >self.callkwds = callkwds These aren’t used in the module-level functions. What is the use case? If you forgive me for the nitpick, the docstrings have to

[issue10772] Several actions for argparse arguments missing from docs

2011-11-15 Thread Éric Araujo
Éric Araujo added the comment: Ezio made further comments, follow the “review” link. -- ___ Python tracker <http://bugs.python.org/issue10772> ___ ___ Python-bug

[issue11805] package_data only allows one glob per-package

2011-11-15 Thread Éric Araujo
Éric Araujo added the comment: > Looking at sysconfig.cfg makes it all pretty clear, though it was hard to > find this > information a while ago. Yeah, you had to be here when the resources code was committed, or to stumble on it while reading the source code. It’s one of the big

[issue13424] Add examples for open’s new opener argument

2011-11-18 Thread Éric Araujo
New submission from Éric Araujo : The new opener argument to open and TextIOWrapper closed two bugs on this tracker: using O_CLOEXEC and replacing the unofficial 'c' mode (O_CREATE). I think it’d be nice to have these as examples (maybe not in the docs of TextIOWrapper which are al

[issue12760] Add create mode to open()

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: See #13424 for a doc request about this. -- nosy: +eric.araujo ___ Python tracker <http://bugs.python.org/issue12760> ___ ___ Pytho

[issue13424] Add examples for open’s new opener argument

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: s/TextIOWrapper/FileIO/ -- ___ Python tracker <http://bugs.python.org/issue13424> ___ ___ Python-bugs-list mailing list Unsub

[issue12797] io.FileIO and io.open should support openat

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: See #13424 for a doc request about this. -- ___ Python tracker <http://bugs.python.org/issue12797> ___ ___ Python-bugs-list mailin

[issue12780] Clean up tests for pyc/pyo in __file__

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: > Seems reasonable to me. When did/does unicodedata ever have a __file__ > attribute? No idea. Maybe it has to do with static vs. dynamic linking? Or alternate VMs? -- ___ Python tracker <http://bugs.p

[issue2979] use_builtin_types in xmlrpc.server

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: Looks good. -- ___ Python tracker <http://bugs.python.org/issue2979> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13294] http.server: HEAD request should not return a body

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: Hi Michele, long time no see :) > Well, actually SimpleHTTPRequesthandler extends BaseHTTPHandler with basic > do_GET and > do_HEAD methods. > Unittests for http.server shows that this behavior is intended, since: [snip] Not sure what this test

[issue13426] Typos in pickle docs

2011-11-18 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo title: The Python Standard Library >> 11. Data Persistence -> Typos in pickle docs ___ Python tracker <http://bugs.python.or

[issue13125] test_all_project_files() expected failure

2011-11-18 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker <http://bugs.python.org/issue13125> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10772] Several actions for argparse arguments missing from docs

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: Looks good to me. -- ___ Python tracker <http://bugs.python.org/issue10772> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue4508] distutils compiler not handling spaces in path to output/src files

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: > Ok, I found a similar problem with MMTK. I don’t know what that is. > I am currently altering my distutils package to add a function called > nt_quote_dir > that adds quotes to paths with spaces and then applies it to each path if the > plat

[issue13420] newer() function in dep_util.py discard changes in the same second

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: Hi David. Thanks for reporting the issue. I have to warn you that there is a high bar for distutils changes; due to the mass of code out there that relies on undocumented internal behavior or works around old bugs, a feature freeze is in effect and we try to

[issue13426] Typos in pickle docs

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: >> Regarding the output, I don't think is necessary to add it. > I left it in because of a discussion in core-mentorship, where they > mentioned that it would be beneficial to have it in. Well, people can have diverging opinions. Terry’s was

[issue12779] Update packaging documentation

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: I worked on this a bit more and the current boring diff has more than 1000 deleted lines and more than 1000 added lines. After thinking about it, maybe I should not make a mega-patch with markup/boring changes first but rather fix markup as part of more

[issue13420] newer() function in dep_util.py discard changes in the same second

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: > I've a project, in the setup.py file, I've a function called update_prefix, > that updates the > 'path_project' variable with prefix arguments from setup.py > If you runs setup.py with --prefix=/usr, then the file in > &#

[issue4442] document immutable type subclassing via __new__

2011-11-18 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker <http://bugs.python.org/issue4442> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue4395] Document auto __ne__ generation; provide a use case for non-trivial __ne__

2011-11-18 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker <http://bugs.python.org/issue4395> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13388] document hg commit hooks in the devguide

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: > The commit details (including its changeset, branch and commit message) In Mercurial terminology, a changeset *is* a commit (or if you really want to make a distinction, a commit is the action that creates a changeset). I think you meant “diff”. Moreo

[issue13343] Lambda keyword-only argument not updating co_freevars

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: > It's made my day. I get to boast at school now! You could do more of that if you got a patch committed! See http://docs.python.org/devguide and http://mail.python.org/mailman/listinfo/core-mentorship for more info if you’re interested. ---

[issue13292] missing versionadded for bytearray

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: Thanks for cleaning up the reports. I’m not a numbers person :) -- ___ Python tracker <http://bugs.python.org/issue13292> ___ ___

[issue13430] Add a curry function to the functools module

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: To go back to your original message: > I think it would be very usefull to add a curry function to the functools > module. For what use cases? > Curried functions could be used as follow. >>> adder(2, 3, 4) >>> adder(2, 3)(4) >>

[issue13387] suggest assertIs(type(obj), cls) for exact type checking

2011-11-18 Thread Éric Araujo
Éric Araujo added the comment: + To check for a specific type (without including superclasses) use + :func:`assertIs(type(obj), cls) `. Don’t you mean “without accepting subclasses”, not superclasses? -- ___ Python tracker <http://bugs.python.

[issue13404] Add support for system.methodSignature() to XMLRPC Server

2011-11-18 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker <http://bugs.python.org/issue13404> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13397] Option for XMLRPC clients to automatically transform Fault exceptions into standard exceptions

2011-11-18 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker <http://bugs.python.org/issue13397> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue3430] httplib.HTTPResponse documentations inconsistent

2011-11-20 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker <http://bugs.python.org/issue3430> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12707] Deprecate addinfourl getters

2011-11-20 Thread Éric Araujo
Éric Araujo added the comment: > I thought about having another class, but I couldn't come up with a > decent name for it (ResponseWithCloseHook?). If it’s used together with the base Response class (I don’t have the details in memory anymore), you could try ClosingMixin or Fi

[issue13434] time.xmlrpc.com dead

2011-11-20 Thread Éric Araujo
Éric Araujo added the comment: #6533: Make test_xmlrpc_net functional in the absence of time.xmlrpc.com #6027: test_xmlrpc_net fails when the ISP returns "302 Found" -- nosy: +eric.araujo ___ Python tracker <http://bugs.python.o

[issue13433] String format documentation contains error regarding %g

2011-11-20 Thread Éric Araujo
Éric Araujo added the comment: I agree with Mark. The Documenting Python docs were recently updated by Raymond Hettinger to recommend not abusing notes and warnings, and the doc maintainer Georg Brandl approved it: d5d91b14b238 (#12047). -- nosy: +eric.araujo

[issue13435] Copybutton does not hide tracebacks

2011-11-20 Thread Éric Araujo
Éric Araujo added the comment: Another way to fix this would be to use Sphinx 1.0 for Python 2.7, but I don’t know what’s the status of that, given the amount of changes needed. -- nosy: +eric.araujo, sandro.tosi ___ Python tracker <h

[issue12890] cgitb displays tags when executed in text mode

2011-11-20 Thread Éric Araujo
Éric Araujo added the comment: Thanks for the updated patch. I made a review, you should have received an email. When you make a new patch, it would be most helpful if you could make one patch with code and tests changes, and then we’ll remove the old versions. -- nosy

[issue13437] Provide links to the source code for every module in the documentation

2011-11-20 Thread Éric Araujo
Éric Araujo added the comment: Hi Julian, thanks for your interest in improving Python and welcome! It is Raymond who initially added these links, and I helped porting them between versions. The criterion can be read in the commit message: “Provide links to Python source in a handful of

[issue10318] "make altinstall" installs many files with incorrect shebangs

2011-11-20 Thread Éric Araujo
Éric Araujo added the comment: The patches I’ve discussed and committed were actually peripheral. The original bug reported here is that shebangs shouldn’t use “/usr/bin/env python” with an altinstall installation, as in that case you’re not creating a python (or python3) binary but a

[issue13387] suggest assertIs(type(obj), cls) for exact type checking

2011-11-20 Thread Éric Araujo
Éric Araujo added the comment: No, I’m not talking about a rephrasing, but on a full change of meaning. I don’t understand your use of “superclasses” at all; isinstance(x, T) checks if x is an instance of T or any subclass, am I wrong

[issue11045] shutil._make_tarball misses a guard against loggger=None

2011-11-20 Thread Éric Araujo
Éric Araujo added the comment: This was fixed in 615a29295d5f. -- resolution: accepted -> fixed stage: needs patch -> committed/rejected status: open -> closed title: shutil._make_tarball -> shutil._make_tarball misses a guard against

[issue6983] Add specific get_platform() for freebsd

2011-11-20 Thread Éric Araujo
Éric Araujo added the comment: > This is still a bothersome issue, but we've taken to patching every version > of python > downstream before deploying them. All for a simple three line patch. Sorry about the unsatisfactory situation. Could we start anew and define exactly wh

[issue12703] Improve error reporting for packaging.util.resolve_name

2011-11-20 Thread Éric Araujo
Éric Araujo added the comment: I’ve found a way to make sure error messages always bubble up *and* clean up the ugly code in resolve_name, but it’s a rather drastic one. The idea is to restrict the function to work only with names defined at the module level, not arbitrarily nested names

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

2011-11-20 Thread Éric Araujo
Éric Araujo added the comment: Advice from Ezio Melotti: > I would keep the flags even if you don't need them > someone in the present or in the future might need them, and having them > doesn't harm -- ___ Python tracker <

[issue13387] suggest assertIs(type(obj), cls) for exact type checking

2011-11-21 Thread Éric Araujo
Éric Araujo added the comment: Your latest proposal is better. I would prefer mentioning subclasses, but don’t feel strongly about it. One markup nit: I’d use ``code`` instead of (ab)using :func:; the doc for assertIs is just a few paragraphs above, it won’t be hard to find

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

2011-11-21 Thread Éric Araujo
Éric Araujo added the comment: Did the second idea as suggested by Ezio. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue13402] Document absoluteness of sys.executable

2011-11-21 Thread Éric Araujo
Éric Araujo added the comment: Patch looks good, but are you 100% sure that sys.executable is always absolute? (On all OSes, under multiprocessing, etc?) -- ___ Python tracker <http://bugs.python.org/issue13

[issue12890] cgitb displays tags when executed in text mode

2011-11-21 Thread Éric Araujo
Changes by Éric Araujo : Removed file: http://bugs.python.org/file23091/head-cgitb-display.patch ___ Python tracker <http://bugs.python.org/issue12890> ___ ___ Python-bug

[issue12890] cgitb displays tags when executed in text mode

2011-11-21 Thread Éric Araujo
Changes by Éric Araujo : Removed file: http://bugs.python.org/file23731/head-cgitb-display-tests.patch ___ Python tracker <http://bugs.python.org/issue12890> ___ ___ Pytho

[issue13317] building with 2to3 generates wrong import paths because build_ext is run after build_py

2011-11-21 Thread Éric Araujo
Éric Araujo added the comment: Ah, thanks for clarifying, I didn’t understand what you meant with local/global but now I see it’s about absolute imports and explicit relative imports. (I don’t remember ever reading that terminology before looking at fix_import.) I’m adding the “easy

[issue13316] build_py_2to3 does not convert when there was an error in the last run

2011-11-21 Thread Éric Araujo
Éric Araujo added the comment: > It does stop with an error message. But when I reinvoke the command, > converting is > skipped (because the file is already copied). Then that’s the bug: In case of error, the file in the build dir should be removed. By the way, I think this was not

[issue12618] py_compile cannot create files in current directory

2011-11-21 Thread Éric Araujo
Éric Araujo added the comment: Thanks for the patch Meador, I hadn’t realized we had no tests for py_compile (it is however used in test_import and test_compileall). I think it would be nice to commit the tests first (except for the one that’s the object of this bug report) in order to have

[issue9321] CGIHTTPServer cleanup htbin

2011-11-21 Thread Éric Araujo
Éric Araujo added the comment: Google does find matches for “CGI /htbin”. Given that CGI is an obsolete technology anyway, I don’t see value in removing that, and propose that we reject this request. -- nosy: +eric.araujo versions: +Python 3.3 -Python 3.2

[issue12890] cgitb displays tags when executed in text mode

2011-11-21 Thread Éric Araujo
Changes by Éric Araujo : Removed file: http://bugs.python.org/file23737/head-cgitb-display.patch ___ Python tracker <http://bugs.python.org/issue12890> ___ ___ Python-bug

[issue12890] cgitb displays tags when executed in text mode

2011-11-21 Thread Éric Araujo
Éric Araujo added the comment: Latest patch is good to go. -- versions: +Python 2.7, Python 3.2 ___ Python tracker <http://bugs.python.org/issue12890> ___ ___

[issue13447] Add tests for Tools/scripts/reindent.py

2011-11-21 Thread Éric Araujo
New submission from Éric Araujo : When people find bugs in reindent.py (#12930 is a recent one), we have to try to reproduce the bug manually, apply a fix and test manually again. The alternative is to only read the code and trust that it works. I find both of these positions unsatisfactory

[issue12930] reindent.py inserts spaces in multiline literals

2011-11-21 Thread Éric Araujo
Éric Araujo added the comment: Thanks, I’ll make time to review the change this week. -- dependencies: +Add tests for Tools/scripts/reindent.py ___ Python tracker <http://bugs.python.org/issue12

[issue10318] "make altinstall" installs many files with incorrect shebangs

2011-11-22 Thread Éric Araujo
Éric Araujo added the comment: Patch to PEP 8 attached. -- Added file: http://bugs.python.org/file23755/pep8-shebangs.diff ___ Python tracker <http://bugs.python.org/issue10

[issue12424] distutils2: extension section uses bad environment marker separator

2011-11-22 Thread Éric Araujo
Éric Araujo added the comment: Does your latest patch address my second review? -- ___ Python tracker <http://bugs.python.org/issue12424> ___ ___ Python-bug

[issue13440] Explain the "status quo wins a stalemate" principle in the devguide

2011-11-22 Thread Éric Araujo
Éric Araujo added the comment: +1 -- nosy: +eric.araujo ___ Python tracker <http://bugs.python.org/issue13440> ___ ___ Python-bugs-list mailing list Unsubscribe:

<    1   2   3   4   5   6   7   8   9   10   >