[issue42548] debugger stops at breakpoint of `pass` that is not actually reached

2022-02-07 Thread Andy S


Andy S  added the comment:

Then maybe those RMs (for 3.9 and 3.10) should decide on their own? That should 
mean the bug should be reopened for them to get assigned to.

--

___
Python tracker 
<https://bugs.python.org/issue42548>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42548] debugger stops at breakpoint of `pass` that is not actually reached

2022-02-07 Thread Andy S


Andy S  added the comment:

Can reproduce this on 3.9. Is the fact 3.9 is in `bugfix` status enough to 
backport any fixing changes from 3.11 (if that's true and the bug was fixed)?

--

___
Python tracker 
<https://bugs.python.org/issue42548>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43858] Provide method to get list of logging level names

2021-05-30 Thread Andy Lowry


Andy Lowry  added the comment:

@andrei.avk Yes, that sounds just fine. Many thanks.

--

___
Python tracker 
<https://bugs.python.org/issue43858>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44070] Regression with relative paths in sys.path in python 3.8.10

2021-05-07 Thread Andy Fiddaman


Andy Fiddaman  added the comment:

I've just found this while investigating a regression with my project following 
update to 3.9.5. It took me some time to discover that the new test failures 
were due to __file__ now being fully qualified when it wasn't before.

As far as I can tell so far it is just breaking the tests, not the software 
(https://github.com/omniosorg/pkg5) but this doesn't feel like a change that 
should be made in a minor release.

--
nosy: +omnios

___
Python tracker 
<https://bugs.python.org/issue44070>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43912] http.client.BadStatusLine raised and response contains request

2021-04-22 Thread Andy Maier


Andy Maier  added the comment:

I should have added that my local system is macOS, and that "up to 3.9" means I 
only tried up to 3.9.

--

___
Python tracker 
<https://bugs.python.org/issue43912>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43912] http.client.BadStatusLine raised and response contains request

2021-04-22 Thread Andy Maier


New submission from Andy Maier :

Hello, we have a nasty occurrence of BadStatusLine that shows the status line 
of the request(!!) in one of our projects. That exception is raised when 
checking a response and should check the response, not the request. 

Further debugging revealed that not only the status line is from the request, 
but also the headers and the body of the response are from the request when 
this error happens.

Example exception when using http.client to send the requests:

http.client.BadStatusLine: POST http://localhost:5 HTTP/1.1

I have created a standalone script that can be used to reproduce the behavior. 
The script can use http.client or the requests package for sending the 
requests. The server is a threaded HTTP server.

The script needs to be run multiple times to reproduce the error. On my local 
system, the error showed up pretty reliably within the first 50 repetitions of 
the script.

The header comment of the script explains the details.

If http.client is chosen to be used, the script is purely based on standard 
Python library functions. The error shows up on all CPython versions I tried, 
up to 3.9.

--
components: Library (Lib)
files: badstatusline.py
messages: 391601
nosy: andymaier
priority: normal
severity: normal
status: open
title: http.client.BadStatusLine raised and response contains request
type: behavior
versions: Python 3.9
Added file: https://bugs.python.org/file49971/badstatusline.py

___
Python tracker 
<https://bugs.python.org/issue43912>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43858] Provide method to get list of logging level names

2021-04-15 Thread Andy Lowry


New submission from Andy Lowry :

It would be useful to have something like a `getLevelNames` method to return 
the current list of level names, ordered by priority.

This currently appears to be available only by accessing a private member, like 
`_levelToName` or `_nameToLevel`.

This functionality is useful, for example, in populating a `choices` list for 
an `argparse` option to allow a user to select a logging level when launching a 
program from a command line.

--
components: Library (Lib)
messages: 391145
nosy: andylowry
priority: normal
severity: normal
status: open
title: Provide method to get list of logging level names
versions: Python 3.8

___
Python tracker 
<https://bugs.python.org/issue43858>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43828] MappingProxyType accepts string

2021-04-13 Thread Andy Maier


Andy Maier  added the comment:

I accept that the issue was closed, but wanted to document some things:

1. The dict class manages very well to detect that a string is invalid input:

>>> d = dict('abc')
Traceback (most recent call last):
  File "", line 1, in 
ValueError: dictionary update sequence element #0 has length 1; 2 is required

2. When initialized with strings, it looses some of its dictionary methods, but 
does a quite reasonable job in pointing that out in the error message:

>>> mp = MappingProxyType('abc')
>>> mp.items()
Traceback (most recent call last):
  File "", line 1, in 
AttributeError: 'str' object has no attribute 'items'

--

___
Python tracker 
<https://bugs.python.org/issue43828>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43829] MappingProxyType cannot hash a hashable underlying mapping

2021-04-13 Thread Andy Maier


New submission from Andy Maier :

Objects of MappingProxyType do expose a __hash__() method, but if the 
underlying mapping is hashable, it still does not support hashing it.

Example:

Content of mp_hash.py:

--
#!/usr/bin/env python

from nocasedict import NocaseDict, HashableMixin
from types import MappingProxyType

class HashableDict(HashableMixin, NocaseDict):
"""A hashable dictionary"""
pass

hd = HashableDict({'a': 1, 'b': 2})
print("hash(hd): {}".format(hash(hd)))

mp = MappingProxyType(hd)
print("hash(mp): {}".format(hash(mp)))
---

Running the mp_hash.py script:

hash(hd): 3709951335832776636
Traceback (most recent call last):
  File 
"/Users/maiera/Projects/Python/cpython/issues/mappingproxy/./mp_hash.py", line 
14, in 
print("hash(mp): {}".format(hash(mp)))
TypeError: unhashable type: 'mappingproxy'

There are use cases where a function wants to return an immutable view on an 
internal dictionary, and the caller of the function should be able to use the 
returned object like a dictionary, except that it is read-only.

Note there is https://bugs.python.org/issue31209 on the inability to pickle 
MappingProxyType objects which was closed without adding the capability. That 
would fall under the same argument.

--
components: Library (Lib)
messages: 390936
nosy: andymaier
priority: normal
severity: normal
status: open
title: MappingProxyType cannot hash a hashable underlying mapping
type: behavior
versions: Python 3.9

___
Python tracker 
<https://bugs.python.org/issue43829>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43828] MappingProxyType accepts string

2021-04-13 Thread Andy Maier


Change by Andy Maier :


--
type:  -> behavior

___
Python tracker 
<https://bugs.python.org/issue43828>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43828] MappingProxyType accepts string

2021-04-13 Thread Andy Maier


New submission from Andy Maier :

MappingProxyType objects can currently be initialized from a string object. 
Given is purpose, I think this is a bug and should result in TypeError being 
raised.

Example code (on CPython 3.9.1):

>>> from types import MappingProxyType
>>> mp = MappingProxyType('abc')
>>> list(mp)
['a', 'b', 'c']
>>> mp.items()
Traceback (most recent call last):
  File "", line 1, in 
AttributeError: 'str' object has no attribute 'items'

Other invalid input types are properly checked:

>>> mp = MappingProxyType(42)
Traceback (most recent call last):
  File "", line 1, in 
TypeError: mappingproxy() argument must be a mapping, not int

>>> mp = MappingProxyType(['a'])
Traceback (most recent call last):
  File "", line 1, in 
TypeError: mappingproxy() argument must be a mapping, not list

>>> mp = MappingProxyType(('a',))
Traceback (most recent call last):
  File "", line 1, in 
TypeError: mappingproxy() argument must be a mapping, not tuple

--
components: Library (Lib)
messages: 390935
nosy: andymaier
priority: normal
severity: normal
status: open
title: MappingProxyType accepts string
versions: Python 3.9

___
Python tracker 
<https://bugs.python.org/issue43828>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42776] The string find method shows the problem

2020-12-28 Thread ye andy

ye andy  added the comment:

When I say True here, I'm not talking about querying, I'm talking about
syntax, as far as I know, document is supposed to support keyword
arguments, but it doesn't

Steven D'Aprano  于2020年12月29日周二 上午11:36写道:

>
> Steven D'Aprano  added the comment:
>
> # True
> data.find('a', 0)
>
> That will return 0, not True.
>
>
> # False
> data.find('a', start=0)
>
>
> And that will raise TypeError, not return False.
>
>
> What exactly are you reporting here? I have read your bug report, and
> looked at the screen shot, and I have no idea what problem you think you
> have found or what you want to change about the documentation.
>
> --
> nosy: +steven.daprano
>
> ___
> Python tracker 
> <https://bugs.python.org/issue42776>
> ___
>

--
nosy: +andy.ye.jx

___
Python tracker 
<https://bugs.python.org/issue42776>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42776] The string find method shows the problem

2020-12-28 Thread andy ye

New submission from andy ye :

data = 'abcddd'
# True
data.find('a', 0)

# False
data.find('a', start=0)


# document
class str(obj):

def find(self, sub, start=None, end=None): # real signature unknown; 
restored from __doc__
"""
S.find(sub[, start[, end]]) -> int

Return the lowest index in S where substring sub is found,
such that sub is contained within S[start:end].  Optional
arguments start and end are interpreted as in slice notation.

Return -1 on failure.
"""
return 0

--
assignee: docs@python
components: Documentation
files: 截屏2020-12-29 上午10.57.53.png
messages: 383949
nosy: andyye, docs@python
priority: normal
severity: normal
status: open
title: The string find method shows the problem
versions: Python 3.6
Added file: https://bugs.python.org/file49704/截屏2020-12-29 上午10.57.53.png

___
Python tracker 
<https://bugs.python.org/issue42776>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42550] re库匹配问题

2020-12-02 Thread ye andy


Change by ye andy :


--
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue42550>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42550] re库匹配问题

2020-12-02 Thread ye andy


ye andy  added the comment:

Okay, I just thought it was weird

--

___
Python tracker 
<https://bugs.python.org/issue42550>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42550] re库匹配问题

2020-12-02 Thread ye andy


ye andy  added the comment:

My regulus requires the beginning of 0x, the end of 0-9A-fa-f, my ending \n, he 
also shows success, my expected result is failure, I wrote the problem?

--

___
Python tracker 
<https://bugs.python.org/issue42550>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42550] re库匹配问题

2020-12-02 Thread ye andy


ye andy  added the comment:

My regex requires ending with 0-9a-fa-f, and I now end with a line break, which 
in theory should not work. Why did it work?

--
nosy:  -Dennis Sweeney

___
Python tracker 
<https://bugs.python.org/issue42550>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42550] re库匹配问题

2020-12-02 Thread ye andy


ye andy  added the comment:

What I mean by that is that the regex That I wrote should match successfully is 
a 42-bit string, but it is also successful when we add more newlines

--

___
Python tracker 
<https://bugs.python.org/issue42550>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42550] re库匹配问题

2020-12-02 Thread ye andy

New submission from ye andy :

import re
a = """0xd26935a5ee4cd542e8a3a7e74fb7a99855975b59\n"""

eth_re = re.compile(r'^0x[0-9a-fA-F]{40}$')

print(eth_re.match(a))
print(len(a)) # 长度43

--
components: Library (Lib)
messages: 382367
nosy: andy.ye.jx
priority: normal
severity: normal
status: open
title: re库匹配问题
type: security
versions: Python 3.6

___
Python tracker 
<https://bugs.python.org/issue42550>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42548] debugger stops at breakpoint of `pass` that is not actually reached

2020-12-02 Thread Andy S


New submission from Andy S :

The python (3.6) doc states 
(https://docs.python.org/3/reference/simple_stmts.html#the-pass-statement):

pass is a null operation...

So since this is still an operation one could expect that it can be used as an 
op to breakpoint on while debugging some scripts.

Nevertheless:

$ pdb3.7 ./debug_bug.py 
> /...play/debug_bug.py(1)()
-> a = None
(Pdb) list
  1  -> a = None
  2  
  3  
  4 def fun():
  5 b = False
  6 if a is None:
  7 b = True
  8 pass
  9 else:
 10 pass
 11  
(Pdb) 
 12  
 13 fun()
 14 pass
[EOF]
(Pdb) b 10
Breakpoint 1 at /...play/debug_bug.py:10
(Pdb) run
Restarting ./debug_bug.py with arguments:
./debug_bug.py
> /...play/debug_bug.py(1)()
-> a = None
(Pdb) continue
> /...play/debug_bug.py(10)fun()
-> pass
(Pdb) bt
  /usr/lib/python3.7/bdb.py(585)run()
-> exec(cmd, globals, locals)
  (1)()
  /...play/debug_bug.py(13)()
-> fun()
> /...play/debug_bug.py(10)fun()
-> pass
(Pdb) p b
True
(Pdb)

--
components: Interpreter Core, Library (Lib)
files: debug_bug.py
messages: 382351
nosy: gatekeeper.mail
priority: normal
severity: normal
status: open
title: debugger stops at breakpoint of `pass` that is not actually reached
type: behavior
versions: Python 3.7
Added file: https://bugs.python.org/file49649/debug_bug.py

___
Python tracker 
<https://bugs.python.org/issue42548>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39573] [C API] Make PyObject an opaque structure in the limited C API

2020-12-01 Thread Andy Lester


Change by Andy Lester :


--
nosy:  -petdance

___
Python tracker 
<https://bugs.python.org/issue39573>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41100] Support macOS 11 and Apple Silicon Macs

2020-11-28 Thread Andy Dirnberger


Change by Andy Dirnberger :


--
nosy: +dirn

___
Python tracker 
<https://bugs.python.org/issue41100>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42359] tutorial: list is a class

2020-11-14 Thread Andy Harrington


New submission from Andy Harrington :

Documentation in Tutorial section 9.3.3 seems to be stuck in Python 2:

"In Python, the term method is not unique to class instances: other object 
types can have methods as well. For example, list objects have methods called 
append, insert, remove, sort, and so on."

In Python 3 built-in types are derived from Object, so list is now a class, 
right?

--
assignee: docs@python
components: Documentation
messages: 380997
nosy: andyharrington, docs@python
priority: normal
severity: normal
status: open
title: tutorial:  list is a class
versions: Python 3.9

___
Python tracker 
<https://bugs.python.org/issue42359>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42173] Drop Solaris support

2020-11-02 Thread Andy Fiddaman


Andy Fiddaman  added the comment:

Jakub's results looks very familiar to me, having been working on python 3.9 on 
illumos.

For OmniOS, we currently skip these tests via --ignorefile:

# wchar_t related failures
*.test_re.ReTests.test_locale_compiled
*.test_re.ReTests.test_locale_caching
# illumos does not support multiple SCM_RIGHTS messages in a packet
*FDPassSeparate*
# These tests fail on illumos and the first consumes a significant
# amount of memory. Investigation required.
test.test_socket.SendfileUsingSendfileTest.testCount
test.test_socket.SendfileUsingSendfileTest.testWithTimeout
test.test_socket.SendfileUsingSendfileTest.testOffset
#
test.test_asyncio.test_sendfile.*
test.test_asyncio.test_subprocess.SubprocessMultiLoopWatcherTests.*


We are also carrying some local patches for the following. Several come from 
Solaris.

- Stop python detecting and using epoll() on illumos

- scheduling priorities can be < 0
https://github.com/citrus-it/omnios-build/blob/python39/build/python39/patches/mod-posix-sched_priority.patch

- differences in sendfile behaviour (improves the situation but is not complete)
https://github.com/citrus-it/omnios-build/blob/python39/build/python39/patches/mod-posix-sendfile.patch

- Enable sendfile for shutil.copy (mismatch between library and testsuite in 
terms of whether sendfile() is enabled on illumos)
https://github.com/citrus-it/omnios-build/blob/python39/build/python39/patches/mod-shutil-sendfile.patch

- Fixes for building the socket module (_XOPEN_SOURCE=600)
https://github.com/citrus-it/omnios-build/blob/python39/build/python39/patches/mod-socket-xpg6.patch

- Emulate clock_gettime(CLOCK_THREAD_CPUTIME_ID)
https://github.com/citrus-it/omnios-build/blob/python39/build/python39/patches/mod-time-threadtime.patch

- PTY patch
https://github.com/citrus-it/omnios-build/blob/python39/build/python39/patches/pty.patch

and a few others, not all of which are suitable for upstream.
https://github.com/citrus-it/omnios-build/tree/python39/build/python39/patches


With all of this in place, the headline test stats for OmniOS Python 3.9 are:

401 tests OK.

24 tests skipped:
test_dbm_gnu test_epoll test_gdb test_idle test_kqueue test_msilib
test_ossaudiodev test_smtpnet test_socketserver test_startfile
test_tcl test_timeout test_tix test_tk test_ttk_guionly
test_ttk_textonly test_turtle test_urllib2net test_urllibnet
test_winconsoleio test_winreg test_winsound test_xmlrpc_net
test_zipfile64

Tests result: SUCCESS

and, additionally, the dtrace tests succeed (we test them separately as they 
require elevated privileges).

--

___
Python tracker 
<https://bugs.python.org/issue42173>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42173] Drop Solaris support

2020-10-29 Thread Andy Fiddaman


Andy Fiddaman  added the comment:

Re: Downloads

OmniOS makes modules like 'six' available through its own IPS packaging system 
(which is written in Python) so installations won't show up pypi stats.

six is a core module on the platform so it is installed on 1000s of OmniOS 
machines (and then large numbers of SmartOS, OpenIndiana and tribblix ones too 
- all using the SunOS tag). The numbers aren't going to be in the same league 
as other platforms but the downloads stats definitely don't represent the 
illumos installation base and dependency on Python.

--

___
Python tracker 
<https://bugs.python.org/issue42173>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42173] Drop Solaris support

2020-10-29 Thread Andy Fiddaman


Andy Fiddaman  added the comment:

We at OmniOS (an illumos distribution) are in the process of upgrading to 
Python 3.9 and working on getting tests clean. We're in pretty good shape with 
a few local patches and only having to skip a few tests at the moment, and most 
of those patches should be suitable for integrating generally.

Some of the tests just need adjusting to be aware of the different platform 
(e.g. illumos does not support multiple SCM_RIGHTS messages in a single 
packet), some still need investigating to find the root cause, but the list is 
small.

--
nosy: +omnios

___
Python tracker 
<https://bugs.python.org/issue42173>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41639] Unpickling derived class of list does not call __init__()

2020-09-07 Thread Andy Maier


Andy Maier  added the comment:

And just to be complete: That did not require implementing __reduce__().

--

___
Python tracker 
<https://bugs.python.org/issue41639>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41639] Unpickling derived class of list does not call __init__()

2020-09-07 Thread Andy Maier


Andy Maier  added the comment:

Thanks for the clarification.

Just for the record:

I have implemented __setstate__() such that it completely restores the state 
from just the inherited list state. That makes it independent of whether 
__init__() or __new__() is called:

def __getstate__(self):
state = self.__dict__.copy()
del state['_lc_list']
return state

def __setstate__(self, state):
self.__dict__.update(state)
self._lc_list = _lc_list(self)

This issue can be closed.

--

___
Python tracker 
<https://bugs.python.org/issue41639>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41698] io.[Text]IOBase.seek doesn't take keyword parameter - revisited

2020-09-02 Thread Andy Maier


Andy Maier  added the comment:

Thanks for referencing the PR that reintroduced the old way of documenting it.

>From my perspective, the proposal is fine. There are already some cases where 
>it is documented like that, e.g. str.removeprefix(prefix, /).

--

___
Python tracker 
<https://bugs.python.org/issue41698>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41698] io.[Text]IOBase.seek doesn't take keyword parameter - revisited

2020-09-02 Thread Andy Maier


New submission from Andy Maier :

I stumbled across the problem reported in https://bugs.python.org/issue25030 on 
Python 3.8:

>>> with open('x.txt', 'a') as fp:
...   fp.seek(0, whence=os.SEEK_END)
... 
Traceback (most recent call last):
  File "", line 2, in 
TypeError: seek() takes no keyword arguments

Which I coded with a keyword argument because the documentation says so:

   seek(offset, whence=SEEK_SET)

See https://docs.python.org/3.8/library/io.html#io.IOBase.seek

The fix for issue issue25030 changed the documentation to:

   seek(offset[, whence])

and supposedly was integrated into 2.7, 3.4, and the default branch back then.

It seems the fix got lost?

--
assignee: docs@python
components: Documentation
messages: 376272
nosy: andymaier, docs@python
priority: normal
severity: normal
status: open
title: io.[Text]IOBase.seek doesn't take keyword parameter - revisited
versions: Python 3.8

___
Python tracker 
<https://bugs.python.org/issue41698>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41661] os.path.relpath does not document ValueError on Windows with different drives

2020-08-29 Thread Andy Maier


New submission from Andy Maier :

I found that os.path.relpath() on Windows raises ValueError when the path and 
the start path are on different drives. This is to be expected, as there is no 
single root on Windows.

On Python 3.7, the behavior is:

>>> os.path.relpath('c:/abc', 'a:/')
Traceback (most recent call last):
  File "", line 1, in 
  File "...\Python\Python37\lib\ntpath.py", line 564, in relpath
path_drive, start_drive))
ValueError: path is on mount 'c:', start on mount 'a:'

The issue is that this ValueError and the reasons for it are not mentioned at 
all in the documentation for os.path.relpath(). Other os.path functions do 
document specific behaviors for different drives on Windows, for example 
os.path.commonpath(), so there is a precedence for documenting this. Also, it 
should be normal to document the possible exceptions that can be raised.

I did read https://bugs.python.org/issue7195 from 2009 where the original issue 
discussed also lead to a request to update the documentation of 
os.path.relpath() to show the ValueError for this case, but that angle of the 
issue ended up being ignored back then, unfortunately.

My suggestion is to add something like the following sentence the documentation:

"On Windows, ValueError is raised when path and start are on different drives."

--
assignee: docs@python
components: Documentation
messages: 376057
nosy: andymaier, docs@python
priority: normal
severity: normal
status: open
title: os.path.relpath does not document ValueError on Windows with different 
drives
versions: Python 3.7

___
Python tracker 
<https://bugs.python.org/issue41661>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue41639] Unpickling derived class of list does not call __init__()

2020-08-26 Thread Andy Maier


New submission from Andy Maier :

Unpickling an object of a user class that derives from list seems to miss 
calling the user class's __init__() method:

Consider this script, which defines a derived class of the built-in list for 
the purpose of creating a case insensitive list. The real example has all 
methods of list implemented, but this subset example also shows the issue:

-
import pickle

def _lc_list(lst):
result = list()
for value in lst:
result.append(value.lower())
return result

class NocaseList(list):

#def __new__(cls, iterable=()):
#self = super(NocaseList, cls).__new__(cls, iterable)
#print("Debug: __new__()  for self={}".format(id(self)))
#return self

def __init__(self, iterable=()):
print("Debug: __init__() for self={}".format(id(self)))
super(NocaseList, self).__init__(iterable)
self.lc_list = _lc_list(self)

def append(self, value):
super(NocaseList, self).append(value)
self.lc_list.append(value.lower())

def extend(self, iterable):
super(NocaseList, self).extend(iterable)
for value in iterable:
self.lc_list.append(value.lower())

ncl = NocaseList(['A', 'b'])
pkl = pickle.dumps(ncl)
nclx = pickle.loads(pkl)
-

$ python ./pickle_extend.py 
Debug: __init__() for self=4498704880
Traceback (most recent call last):
  File "./pickle_extend.py", line 32, in 
nclx = pickle.loads(pkl)
  File "./pickle_extend.py", line 28, in extend
self.lc_list.append(value.lower())
AttributeError: 'NocaseList' object has no attribute 'lc_list'

Uncommenting the __new__() method in the script shows that __new__() is called 
but not __init__():

$ python ./pickle_extend.py 
Debug: __new__()  for self=4359683024
Debug: __init__() for self=4359683024
Debug: __new__()  for self=4360134304
Traceback (most recent call last):
  File "./pickle_extend.py", line 32, in 
nclx = pickle.loads(pkl)
  File "./pickle_extend.py", line 28, in extend
self.lc_list.append(value.lower())
AttributeError: 'NocaseList' object has no attribute 'lc_list'

--
messages: 375909
nosy: andymaier
priority: normal
severity: normal
status: open
title: Unpickling derived class of list does not call __init__()
versions: Python 3.8

___
Python tracker 
<https://bugs.python.org/issue41639>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40170] [C API] Make PyTypeObject structure an opaque structure in the public C API

2020-07-08 Thread Andy Lester


Change by Andy Lester :


--
nosy:  -petdance

___
Python tracker 
<https://bugs.python.org/issue40170>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40902] Speed up PEG parser by using operator precedence for binary operators

2020-06-07 Thread Andy Lester


Change by Andy Lester :


--
nosy: +petdance

___
Python tracker 
<https://bugs.python.org/issue40902>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40770] RFE: Run linkchecker on documentation on the CI

2020-05-28 Thread Andy Lester


Andy Lester  added the comment:

Some high-level questions to consider:

* Is it run only when a build of the docs is started?  Or should it be done 
regularly (daily/weekly?) to keep an eye on links so that it's not a surprise 
when build time comes along?

* Does a broken link stop the build, or is it just advisory?

* Who sees the results?  Are they emailed to someone?  A mailing list?  Posted 
somewhere publicly?

* Is someone assigned responsibility for acting on the failures?

* What counts as a failure?  Is a 301 redirect OK?  It seems that a 301 might 
be OK to pass, but someone should know about it to update to the new URL.

I am not familiar with the current documentation build process, so forgive me 
if these are already answered somehow.  I'm not looking for answers myself, but 
providing suggestions.

--

___
Python tracker 
<https://bugs.python.org/issue40770>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40770] RFE: Run linkchecker on documentation on the CI

2020-05-25 Thread Andy Lester


Change by Andy Lester :


--
nosy: +petdance

___
Python tracker 
<https://bugs.python.org/issue40770>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40344] Programming FAQ about "What is the most efficient way to concatenate many strings together?" -- Improving the example

2020-05-24 Thread Andy Lester


Andy Lester  added the comment:

I'd also like to suggest that the question not be "most efficient" but 
"fastest".  I don't think it should treat "efficient" and "fast" as synonyms. 
"Efficient" can mean things other than execution speed, such as memory usage, 
or programmer time.  Are there space/time considerations besides execution 
time?  What if the user has a huge list and wants to use as little new 
allocated RAM as possible?

I understand that it's immediately after the "How do I speed up my program?" 
question, and I think it's worth considering making the question more explicit 
what kind of efficiency we're talking about.

--

___
Python tracker 
<https://bugs.python.org/issue40344>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40455] GCC 10 compiler warnings

2020-05-04 Thread Andy Lester


Andy Lester  added the comment:

For anyone following along, note that the PR above is different than the 
original suggestion.  The PR correctly sets x_size, not leaving it zero.

--

___
Python tracker 
<https://bugs.python.org/issue40455>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40455] GCC 10 compiler warnings

2020-04-30 Thread Andy Lester


Andy Lester  added the comment:

Did you add any options to the ./configure call for cpython?  What were they?

--

___
Python tracker 
<https://bugs.python.org/issue40455>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40455] GCC 10 compiler warnings

2020-04-30 Thread Andy Lester


Change by Andy Lester :


--
nosy: +petdance

___
Python tracker 
<https://bugs.python.org/issue40455>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40344] Programming FAQ about "What is the most efficient way to concatenate many strings together?" -- Improving the example

2020-04-20 Thread Andy Lester


Change by Andy Lester :


--
nosy: +petdance

___
Python tracker 
<https://bugs.python.org/issue40344>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40314] python code order of magnitude faster than equivalent CPython code for simple import statement

2020-04-17 Thread Andy Lester


Change by Andy Lester :


--
nosy: +petdance

___
Python tracker 
<https://bugs.python.org/issue40314>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues in C internals

2020-04-16 Thread Andy Lester


Andy Lester  added the comment:

I'm assuming that you're getting this sre_lib.h error when compiling 
Modules/_sre.c.

--

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues in C internals

2020-04-14 Thread Andy Lester


Andy Lester  added the comment:

I remember coming across a similar error from GCC about casting from a const 
double pointer to a single pointer void and it said (I believe) something about 
having to have each cast having to be valid.  I think it was implying something 
like that if you have 

const void **p

you have to cast that as

(void *)(const void *)p

I will see if I can find that message and/or I can find out more about this 
cast problem in the Windows compiler.

--

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40245] Add description meta tags to docs.python.org

2020-04-10 Thread Andy Lester


Change by Andy Lester :


--
nosy: +petdance

___
Python tracker 
<https://bugs.python.org/issue40245>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues in C internals

2020-04-08 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18800
pull_request: https://github.com/python/cpython/pull/19445

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues in C internals

2020-04-06 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18766
pull_request: https://github.com/python/cpython/pull/19405

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40170] [C API] Make PyTypeObject structure an opaque structure in the public C API

2020-04-03 Thread Andy Lester


Change by Andy Lester :


--
nosy: +petdance

___
Python tracker 
<https://bugs.python.org/issue40170>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues in C internals

2020-04-02 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18692
pull_request: https://github.com/python/cpython/pull/19327

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues in C internals

2020-03-28 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18573
pull_request: https://github.com/python/cpython/pull/19210

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues in C internals

2020-03-28 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18572
pull_request: https://github.com/python/cpython/pull/19209

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues in C internals

2020-03-27 Thread Andy Lester


Andy Lester  added the comment:

Casting tail to (void *)tail was the correct thing to do.  The problem is that 
casting to void* casts away the constness of tail.  The even more correct thing 
to do is what my patch does, which is cast it to (const void *)tail.

There is no functional difference between sending a const void * and a void * 
to fprintf.  However, it's one more bit of noise for -Wcast-qual to gripe 
about.  My hope is to clear up the noise to find the real problems.

For example, if you had this very bad code:

const char *msg = "literal";
strcpy(msg, "another string");

then the compiler would complain you're passing a non-const char * to the first 
arg of strcpy that wants a const char *.  That's a good thing.

However, you could naively change that to:

strcpy((char *)msg, "another string");

and that would compile just fine, but the code would still be a big problem. It 
would require -Wcast-qual to warn you that you're casting away the constness of 
a pointer.

...

For pymemallocator_eq, changing the arguments to const doesn't quiet any 
warnings in this case with this one function.  However, it's good to make them 
const because the arguments are not getting modified.  They're getting passed 
to memcmp(), which properly takes const void *.

--

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39908] Remove unused args from init_set_builtins_open and _Py_FatalError_PrintExc in Python/pylifecycle.c

2020-03-26 Thread Andy Lester


Change by Andy Lester :


--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue39908>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues in C internals

2020-03-26 Thread Andy Lester


Andy Lester  added the comment:

It doesn't quiet any compiler warnings given the default compiler warnings that 
./configure sets.  

However, it does quiet the -Wcast-qual compiler warning that could be a helpful 
addition some time in the future. I think it would be great, for example, if it 
were made impossible to send a pointer that points at a string literal into a 
function that would modify its contents.

Consting pointers also helps static analyzers like splint by letting it know 
the intent of the API.  It makes it possible for the analyzer to detect 
uninitialized buffers, for example.

All of the 20 or so patches that I've submitted, like BPO 39770 that you 
merged, have come about from my cranking up the warning options on both GCC and 
clang and sifting through the warnings.  My hope is that by making more things 
const, we can detect existing bugs and prevent new ones.

You say "I'm not sure that it's worth it to modify exiting code."  Is your 
concern the amount of work it would take to find the problems?  If so, it's not 
that much work when you let the compiler find the problems, which I've done.  
I've already spent the time digging and validating.

--

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues in C internals

2020-03-26 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18545
pull_request: https://github.com/python/cpython/pull/19186

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues in C internals

2020-03-26 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18544
pull_request: https://github.com/python/cpython/pull/19185

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues in C internals

2020-03-25 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18530
pull_request: https://github.com/python/cpython/pull/19170

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues in C internals

2020-03-24 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18513
pull_request: https://github.com/python/cpython/pull/19152

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues in C internals

2020-03-12 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18322
pull_request: https://github.com/python/cpython/pull/18973

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues in C internals

2020-03-11 Thread Andy Lester


Change by Andy Lester :


--
keywords: +patch
pull_requests: +18301
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18950

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39922] Remove unused args in Python/compile.c

2020-03-11 Thread Andy Lester


Change by Andy Lester :


--
pull_requests:  -18300

___
Python tracker 
<https://bugs.python.org/issue39922>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39922] Remove unused args in Python/compile.c

2020-03-11 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18300
pull_request: https://github.com/python/cpython/pull/18949

___
Python tracker 
<https://bugs.python.org/issue39922>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues in C internals

2020-03-11 Thread Andy Lester


Change by Andy Lester :


--
title: Meta: Clean up various issues -> Meta: Clean up various issues in C 
internals

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39943] Meta: Clean up various issues

2020-03-11 Thread Andy Lester


New submission from Andy Lester :

This is a meta-ticket for a number of small PRs that clean up some internals.

Issues will include:

* Removing unnecessary casts
* consting pointers that can be made const
* Removing unused function arguments
* etc

--
components: Interpreter Core
messages: 363993
nosy: petdance
priority: normal
severity: normal
status: open
title: Meta: Clean up various issues

___
Python tracker 
<https://bugs.python.org/issue39943>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39922] Remove unused args in Python/compile.c

2020-03-10 Thread Andy Lester


Andy Lester  added the comment:

Sorry about the noise.  I will do that.  Yes, I have a bunch more to submit.

--

___
Python tracker 
<https://bugs.python.org/issue39922>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39922] Remove unused args in Python/compile.c

2020-03-09 Thread Andy Lester


Change by Andy Lester :


--
keywords: +patch
pull_requests: +18250
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18893

___
Python tracker 
<https://bugs.python.org/issue39922>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39896] Const args and remove unused args in Python/compile.c

2020-03-09 Thread Andy Lester


Andy Lester  added the comment:

Replaced by https://bugs.python.org/issue39922

--
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue39896>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39922] Remove unused args in Python/compile.c

2020-03-09 Thread Andy Lester


New submission from Andy Lester :

These functions have unnecessary args that can be removed:

* binop
* compiler_add_o
* compiler_next_instr
* inplace_binop

--
components: Interpreter Core
messages: 363799
nosy: petdance
priority: normal
severity: normal
status: open
title: Remove unused args in Python/compile.c

___
Python tracker 
<https://bugs.python.org/issue39922>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39908] Remove unused args from init_set_builtins_open and _Py_FatalError_PrintExc in Python/pylifecycle.c

2020-03-08 Thread Andy Lester


Change by Andy Lester :


--
keywords: +patch
pull_requests: +18225
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18867

___
Python tracker 
<https://bugs.python.org/issue39908>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39908] Remove unused args from init_set_builtins_open and _Py_FatalError_PrintExc in Python/pylifecycle.c

2020-03-08 Thread Andy Lester


New submission from Andy Lester :

init_set_builtins_open(PyThreadState *tstate) -> unused arg

_Py_FatalError_PrintExc(int fd) -> unused arg

--
components: Interpreter Core
messages: 363690
nosy: petdance
priority: normal
severity: normal
status: open
title: Remove unused args from init_set_builtins_open and 
_Py_FatalError_PrintExc in Python/pylifecycle.c

___
Python tracker 
<https://bugs.python.org/issue39908>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39898] Remove unused arg from append_formattedvalue in Python/ast_unparse.c

2020-03-07 Thread Andy Lester


Change by Andy Lester :


--
keywords: +patch
pull_requests: +18197
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18840

___
Python tracker 
<https://bugs.python.org/issue39898>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39898] Remove unused arg from append_formattedvalue in Python/ast_unparse.c

2020-03-07 Thread Andy Lester


New submission from Andy Lester :

append_formattedvalue() has an unused bool is_format_spec.

--
components: Interpreter Core
messages: 363634
nosy: petdance
priority: normal
severity: normal
status: open
title: Remove unused arg from append_formattedvalue in Python/ast_unparse.c

___
Python tracker 
<https://bugs.python.org/issue39898>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39896] Const args and remove unused args in Python/compile.c

2020-03-07 Thread Andy Lester


Change by Andy Lester :


--
keywords: +patch
pull_requests: +18194
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18837

___
Python tracker 
<https://bugs.python.org/issue39896>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39896] Const args and remove unused args in Python/compile.c

2020-03-07 Thread Andy Lester


New submission from Andy Lester :

Remove unused args from:
* binop
* compiler_next_instr
* inplace_binop

Const arguments for:
* assemble_jump_offsets
* blocksize
* check_caller
* check_compare
* check_index
* check_is_arg
* check_subscripter
* compiler_error
* compiler_new_block
* compiler_pop_fblock
* compiler_push_fblock
* compiler_warn
* compute_code_flags
* dfs
* find_ann
* get_ref_type
* merge_const_tuple
* stackdepth

--
components: Interpreter Core
messages: 363632
nosy: petdance
priority: normal
severity: normal
status: open
title: Const args and remove unused args in Python/compile.c

___
Python tracker 
<https://bugs.python.org/issue39896>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39886] Remove unused arg in config_get_stdio_errors in Python/initconfig.c

2020-03-06 Thread Andy Lester


Change by Andy Lester :


--
keywords: +patch
pull_requests: +18182
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18823

___
Python tracker 
<https://bugs.python.org/issue39886>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39886] Remove unused arg in config_get_stdio_errors in Python/initconfig.c

2020-03-06 Thread Andy Lester


New submission from Andy Lester :

config_get_stdio_errors(const PyConfig *config) does not use its arg.  Delete 
it.

--
components: Interpreter Core
messages: 363582
nosy: petdance
priority: normal
severity: normal
status: open
title: Remove unused arg in config_get_stdio_errors in Python/initconfig.c

___
Python tracker 
<https://bugs.python.org/issue39886>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39878] Remove unused args in Python/formatter_unicode.c

2020-03-06 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18181
pull_request: https://github.com/python/cpython/pull/18822

___
Python tracker 
<https://bugs.python.org/issue39878>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39127] _Py_HashPointer's void * argument should be const

2020-03-06 Thread Andy Lester


Andy Lester  added the comment:

Is there more to do here or can it be closed?

--

___
Python tracker 
<https://bugs.python.org/issue39127>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39878] Remove unused args in Python/formatter_unicode.c

2020-03-06 Thread Andy Lester


Change by Andy Lester :


--
keywords: +patch
pull_requests: +18168
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18810

___
Python tracker 
<https://bugs.python.org/issue39878>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39878] Remove unused args in Python/formatter_unicode.c

2020-03-06 Thread Andy Lester


New submission from Andy Lester :

The following functions have unused args:

calc_number_widths -> PyObject *number

fill_number -> Py_ssize_t d_end

--
components: Interpreter Core
messages: 363525
nosy: petdance
priority: normal
severity: normal
status: open
title: Remove unused args in Python/formatter_unicode.c

___
Python tracker 
<https://bugs.python.org/issue39878>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39573] Make PyObject an opaque structure in the limited C API

2020-03-06 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18167
pull_request: https://github.com/python/cpython/pull/18809

___
Python tracker 
<https://bugs.python.org/issue39573>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39872] Remove unused args from two functions in Python/symtable.c

2020-03-05 Thread Andy Lester


Change by Andy Lester :


--
keywords: +patch
pull_requests: +18156
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18800

___
Python tracker 
<https://bugs.python.org/issue39872>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39872] Remove unused args from two functions in Python/symtable.c

2020-03-05 Thread Andy Lester


Andy Lester  added the comment:

Two functions. It's only two functions.

--
title: Remove unused args from four functions in Python/symtable.c -> Remove 
unused args from two functions in Python/symtable.c

___
Python tracker 
<https://bugs.python.org/issue39872>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39872] Remove unused args from four functions in Python/symtable.c

2020-03-05 Thread Andy Lester


New submission from Andy Lester :

These four functions have unused arguments that can be removed:

symtable_exit_block -> void *ast

symtable_visit_annotations -> stmt_ty s

symtable_exit_block -> void *ast

symtable_visit_annotations -> stmt_ty s

PR is forthcoming.

--
components: Interpreter Core
messages: 363486
nosy: petdance
priority: normal
severity: normal
status: open
title: Remove unused args from four functions in Python/symtable.c

___
Python tracker 
<https://bugs.python.org/issue39872>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39573] Make PyObject an opaque structure in the limited C API

2020-03-05 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18155
pull_request: https://github.com/python/cpython/pull/18799

___
Python tracker 
<https://bugs.python.org/issue39573>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39573] Make PyObject an opaque structure in the limited C API

2020-03-05 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18154
pull_request: https://github.com/python/cpython/pull/18798

___
Python tracker 
<https://bugs.python.org/issue39573>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39870] sys_displayhook_unencodable takes an unnecessary PyThreadState * argument

2020-03-05 Thread Andy Lester


Change by Andy Lester :


--
keywords: +patch
pull_requests: +18152
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18796

___
Python tracker 
<https://bugs.python.org/issue39870>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39870] sys_displayhook_unencodable takes an unnecessary PyThreadState * argument

2020-03-05 Thread Andy Lester


Change by Andy Lester :


--
components: +Interpreter Core

___
Python tracker 
<https://bugs.python.org/issue39870>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39870] sys_displayhook_unencodable takes an unnecessary PyThreadState * argument

2020-03-05 Thread Andy Lester


New submission from Andy Lester :

sys_displayhook_unencodable in Python/sysmodule.c doesn't need its first 
argument.  Remove it.

--
messages: 363475
nosy: petdance
priority: normal
severity: normal
status: open
title: sys_displayhook_unencodable takes an unnecessary PyThreadState * argument

___
Python tracker 
<https://bugs.python.org/issue39870>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39859] set_herror should not throw away constness of hstrerror

2020-03-04 Thread Andy Lester


Change by Andy Lester :


--
keywords: +patch
pull_requests: +18147
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18790

___
Python tracker 
<https://bugs.python.org/issue39859>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39859] set_herror should not throw away constness of hstrerror

2020-03-04 Thread Andy Lester


New submission from Andy Lester :

set_herror builds a string by calling hstrerror but downcasts its return value 
to char *.  It should be const char *.

--
components: Interpreter Core
messages: 363418
nosy: petdance
priority: normal
severity: normal
status: open
title: set_herror should not throw away constness of hstrerror

___
Python tracker 
<https://bugs.python.org/issue39859>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39573] Make PyObject an opaque structure in the limited C API

2020-03-04 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18146
pull_request: https://github.com/python/cpython/pull/18789

___
Python tracker 
<https://bugs.python.org/issue39573>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39803] _PyLong_FormatAdvancedWriter has an unnecessary str

2020-02-29 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18068
pull_request: https://github.com/python/cpython/pull/18709

___
Python tracker 
<https://bugs.python.org/issue39803>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39803] _PyLong_FormatAdvancedWriter has an unnecessary str

2020-02-29 Thread Andy Lester


Change by Andy Lester :


--
pull_requests:  -18067

___
Python tracker 
<https://bugs.python.org/issue39803>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39803] _PyLong_FormatAdvancedWriter has an unnecessary str

2020-02-29 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18067
pull_request: https://github.com/python/cpython/pull/18708

___
Python tracker 
<https://bugs.python.org/issue39803>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39803] _PyLong_FormatAdvancedWriter has an unnecessary str

2020-02-29 Thread Andy Lester


Change by Andy Lester :


--
pull_requests:  -18066

___
Python tracker 
<https://bugs.python.org/issue39803>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39803] _PyLong_FormatAdvancedWriter has an unnecessary str

2020-02-29 Thread Andy Lester


Change by Andy Lester :


--
keywords: +patch
pull_requests: +18066
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18707

___
Python tracker 
<https://bugs.python.org/issue39803>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39803] _PyLong_FormatAdvancedWriter has an unnecessary str

2020-02-29 Thread Andy Lester


New submission from Andy Lester :

_PyLong_FormatAdvancedWriter has a PyObject *str that is never used.  Remove it.

--
components: Interpreter Core
messages: 363006
nosy: petdance
priority: normal
severity: normal
status: open
title: _PyLong_FormatAdvancedWriter has an unnecessary str

___
Python tracker 
<https://bugs.python.org/issue39803>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39770] Remove unnecessary size calculation in array_modexec in Modules/arraymodule.c

2020-02-26 Thread Andy Lester


Change by Andy Lester :


--
pull_requests:  -18035

___
Python tracker 
<https://bugs.python.org/issue39770>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39770] Remove unnecessary size calculation in array_modexec in Modules/arraymodule.c

2020-02-26 Thread Andy Lester


Change by Andy Lester :


--
pull_requests: +18035
pull_request: https://github.com/python/cpython/pull/18673

___
Python tracker 
<https://bugs.python.org/issue39770>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   3   4   >