[issue39943] Meta: Clean up various issues in C internals

Andy Lester added the comment: It doesn't quiet any compiler warnings given the default compiler warnings that ./configure sets. However, it does quiet the -Wcast-qual compiler warning that could be a helpful addition some time in the future. I think it would be great, for example

[issue39943] Meta: Clean up various issues in C internals

Andy Lester added the comment: Casting tail to (void *)tail was the correct thing to do. The problem is that casting to void* casts away the constness of tail. The even more correct thing to do is what my patch does, which is cast it to (const void *)tail. There is no functional

[issue39943] Meta: Clean up various issues in C internals

Change by Andy Lester : -- pull_requests: +18692 pull_request: https://github.com/python/cpython/pull/19327 ___ Python tracker <https://bugs.python.org/issue39

[issue40170] [C API] Make PyTypeObject structure an opaque structure in the public C API

Change by Andy Lester : -- nosy: +petdance ___ Python tracker <https://bugs.python.org/issue40170> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39943] Meta: Clean up various issues in C internals

Change by Andy Lester : -- pull_requests: +18572 pull_request: https://github.com/python/cpython/pull/19209 ___ Python tracker <https://bugs.python.org/issue39

[issue39943] Meta: Clean up various issues in C internals

Change by Andy Lester : -- pull_requests: +18573 pull_request: https://github.com/python/cpython/pull/19210 ___ Python tracker <https://bugs.python.org/issue39

[issue39943] Meta: Clean up various issues in C internals

Change by Andy Lester : -- pull_requests: +18513 pull_request: https://github.com/python/cpython/pull/19152 ___ Python tracker <https://bugs.python.org/issue39

[issue40455] GCC 10 compiler warnings

Andy Lester added the comment: Did you add any options to the ./configure call for cpython? What were they? -- ___ Python tracker <https://bugs.python.org/issue40

[issue40455] GCC 10 compiler warnings

Change by Andy Lester : -- nosy: +petdance ___ Python tracker <https://bugs.python.org/issue40455> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40455] GCC 10 compiler warnings

Andy Lester added the comment: For anyone following along, note that the PR above is different than the original suggestion. The PR correctly sets x_size, not leaving it zero. -- ___ Python tracker <https://bugs.python.org/issue40

[issue39943] Meta: Clean up various issues in C internals

Andy Lester added the comment: I remember coming across a similar error from GCC about casting from a const double pointer to a single pointer void and it said (I believe) something about having to have each cast having to be valid. I think it was implying something like that if you have

[issue39896] Const args and remove unused args in Python/compile.c

Change by Andy Lester : -- keywords: +patch pull_requests: +18194 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18837 ___ Python tracker <https://bugs.python.org/issu

[issue39896] Const args and remove unused args in Python/compile.c

New submission from Andy Lester : Remove unused args from: * binop * compiler_next_instr * inplace_binop Const arguments for: * assemble_jump_offsets * blocksize * check_caller * check_compare * check_index * check_is_arg * check_subscripter * compiler_error * compiler_new_block

[issue39898] Remove unused arg from append_formattedvalue in Python/ast_unparse.c

Change by Andy Lester : -- keywords: +patch pull_requests: +18197 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18840 ___ Python tracker <https://bugs.python.org/issu

[issue39898] Remove unused arg from append_formattedvalue in Python/ast_unparse.c

New submission from Andy Lester : append_formattedvalue() has an unused bool is_format_spec. -- components: Interpreter Core messages: 363634 nosy: petdance priority: normal severity: normal status: open title: Remove unused arg from append_formattedvalue in Python/ast_unparse.c

[issue40770] RFE: Run linkchecker on documentation on the CI

Change by Andy Lester : -- nosy: +petdance ___ Python tracker <https://bugs.python.org/issue40770> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40344] Programming FAQ about "What is the most efficient way to concatenate many strings together?" -- Improving the example

Andy Lester added the comment: I'd also like to suggest that the question not be "most efficient" but "fastest". I don't think it should treat "efficient" and "fast" as synonyms. "Efficient" can mean things other than executio

[issue40770] RFE: Run linkchecker on documentation on the CI

Andy Lester added the comment: Some high-level questions to consider: * Is it run only when a build of the docs is started? Or should it be done regularly (daily/weekly?) to keep an eye on links so that it's not a surprise when build time comes along? * Does a broken link stop the build

[issue40170] [C API] Make PyTypeObject structure an opaque structure in the public C API

Change by Andy Lester : -- nosy: -petdance ___ Python tracker <https://bugs.python.org/issue40170> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40902] Speed up PEG parser by using operator precedence for binary operators

Change by Andy Lester : -- nosy: +petdance ___ Python tracker <https://bugs.python.org/issue40902> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39573] [C API] Make PyObject an opaque structure in the limited C API

Change by Andy Lester : -- nosy: -petdance ___ Python tracker <https://bugs.python.org/issue39573> ___ ___ Python-bugs-list mailing list Unsubscribe:

<    1   2