Berker Peksag <berker.pek...@gmail.com> added the comment:
issue21720_python3.diff hasn't been applied. I'll convert my
issue21720_python3.diff patch to a pull request. I like the format of Nick's
"".join() example in msg278794. Here's my proposal for Python 3:
f"I
Berker Peksag <berker.pek...@gmail.com> added the comment:
Thank you, Christoph. I wasn't aware of Tools/demo/redemo.py and I must say it
was fun to play with while reviewing PR 2311.
--
components: +Demos and Tools -Regular Expressions
resolution: -> fixed
stage: pat
Berker Peksag <berker.pek...@gmail.com> added the comment:
New changeset a5f9d24c171c7e3a3715161fd16b747c7dcaf76f by Berker Peksag (Miss
Islington (bot)) in branch '3.6':
bpo-30722: Make redemo work with Python 3.6+ (GH-2311)
https://github.com/python/cpython/
Berker Peksag <berker.pek...@gmail.com> added the comment:
New changeset 62adc55aff0b78447568f73bd1abc610d2784bf8 by Berker Peksag
(Christoph Sarnowski) in branch 'master':
bpo-30722: Make redemo work with Python 3.6+ (GH-2311)
https://github.com/python/cpython/
Change by Berker Peksag <berker.pek...@gmail.com>:
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Deadlocks in `concurrent.futures.ProcessPoolExecutor`
___
Python tracker <rep...@bu
Berker Peksag <berker.pek...@gmail.com> added the comment:
Thank you for the report, Robert and thank you for the patches, Aniket.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Pyth
Berker Peksag <berker.pek...@gmail.com> added the comment:
New changeset 50cef52372381a9e2f3d760497d8db76254cffef by Berker Peksag
(vyas45) in branch '2.7':
[2.7] bpo-31754: Fix type of 'itemsize' in PyBuffer_FillContiguousStrides
(GH-3993)
https://github.com/python/cpython/
Change by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +berker.peksag
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31786>
___
Change by Berker Peksag <berker.pek...@gmail.com>:
--
versions: -Python 2.7
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Change by Berker Peksag <berker.pek...@gmail.com>:
--
keywords: +easy
stage: -> needs patch
type: -> behavior
versions: -Python 3.4, Python 3.5, Python 3.8
___
Python tracker <rep...@bugs.python.org>
<https://bugs.
Change by Berker Peksag <berker.pek...@gmail.com>:
--
stage: patch review -> backport needed
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Berker Peksag <berker.pek...@gmail.com> added the comment:
New changeset e881302b70ab36bafcf37e3917be118bbec97763 by Berker Peksag (Miss
Islington (bot)) in branch '3.6':
[3.6] bpo-31754: Fix type of 'itemsize' in PyBuffer_FillContiguousStrides
(GH-3993)
https://github.com/python/c
Change by Berker Peksag <berker.pek...@gmail.com>:
--
type: -> behavior
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31754>
___
_
Berker Peksag <berker.pek...@gmail.com> added the comment:
New changeset 1b9e76ed3a055a53ca67397e928e1b408461900b by Berker Peksag
(vyas45) in branch 'master':
bpo-31754: Fix type of 'itemsize' in PyBuffer_FillContiguousStrides (GH-3993)
https://github.com/python/cpython/
Berker Peksag <berker.pek...@gmail.com> added the comment:
Modules/main.c and Python.man is same in 3.6 branch. We could backport the
change in Doc/library/sys.rst from 7f580970836b0f6bc9c5db868d95bea81a3e1558 but
I didn't do it yet since it needs be manually back
Berker Peksag <berker.pek...@gmail.com> added the comment:
Thank you for reviews, Serhiy and Victor.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<
Berker Peksag <berker.pek...@gmail.com> added the comment:
New changeset 7f580970836b0f6bc9c5db868d95bea81a3e1558 by Berker Peksag in
branch 'master':
bpo-28647: Update -u documentation after bpo-30404 (GH-3961)
https://github.com/python/cpython/commit/7f580970836b0f6bc9c5db868d95bea81a
Berker Peksag <berker.pek...@gmail.com> added the comment:
New changeset 7f580970836b0f6bc9c5db868d95bea81a3e1558 by Berker Peksag in
branch 'master':
bpo-28647: Update -u documentation after bpo-30404 (GH-3961)
https://github.com/python/cpython/commit/7f580970836b0f6bc9c5db868d95bea81a
Change by Berker Peksag <berker.pek...@gmail.com>:
--
superseder: -> IDLE: Add test_autocomplete unittest
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Berker Peksag <berker.pek...@gmail.com> added the comment:
> That said, staticmethod as a non-decorator has an important use case for
> function injection in tests (using self.func in TestCase classes that work
> with
> a C module and an equivalent Python version). Maybe this
Berker Peksag <berker.pek...@gmail.com> added the comment:
Use of classmethod and staticmethod decorators as functions is still a valid
use case. I think the old signatures should be kept. It should be possible to
document both uses in same place:
.. function:: classmethod(fu
Berker Peksag <berker.pek...@gmail.com> added the comment:
> -u doesn't affect stdin buffering, whatever that would mean.
I think we need to document behavior of stdin somewhere, because current the
sys.stdin documentation states:
> When interactive, standard streams are l
Berker Peksag <berker.pek...@gmail.com> added the comment:
I think it's better to be explicit and mention 'stdin' in this case. Plus,
"stdin is always buffered" is quite short so potential of creating noise is
quite minimal IMO.
(FYI, I asked this question on GitHub:
ht
Berker Peksag <berker.pek...@gmail.com> added the comment:
Good catch, I thought it was already fixed in master after bpo-30404. I've
opened PR 3961.
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Change by Berker Peksag <berker.pek...@gmail.com>:
--
pull_requests: +3938
stage: resolved -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Change by Berker Peksag <berker.pek...@gmail.com>:
--
pull_requests: +3939
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue30404>
___
Change by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +vinay.sajip
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue30767>
___
Change by Berker Peksag <berker.pek...@gmail.com>:
--
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<https://bugs.
Berker Peksag <berker.pek...@gmail.com> added the comment:
Thank you for the patch, Gareth.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<
Berker Peksag <berker.pek...@gmail.com> added the comment:
New changeset 5f908005ce16b06d5af7b413264009c4b062f33c by Berker Peksag in
branch '3.6':
bpo-28647: Update -u documentation (GH-3954)
https://github.com/python/cpython/commit/5f908005ce16b06d5af7b413264009c4b0
Berker Peksag <berker.pek...@gmail.com> added the comment:
This issue can be closed now. Thank you, everyone!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> enhancement
___
P
Berker Peksag <berker.pek...@gmail.com> added the comment:
New changeset 764969a4b9ed7c6d2adbc04269f9b4fa392a1eed by Berker Peksag (Miss
Islington (bot)) in branch '3.6':
[3.6] bpo-28157: Improvements for the time module documentation (GH-928)
https://github.com/python/cpython/
Berker Peksag <berker.pek...@gmail.com> added the comment:
Pull request for issue 30404 has been merged so we only need the documentation
patch for the 3.6 branch (unfortunately 3.5 is now in security-fix-only mode)
I've opened PR 3954.
--
versions: -Python 3.5, Pyth
Change by Berker Peksag <berker.pek...@gmail.com>:
--
pull_requests: +3929
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue28647>
___
Berker Peksag <berker.pek...@gmail.com> added the comment:
New changeset 703ff381ffa946c23e7e25b0ae93a636a2607a40 by Berker Peksag (Cheryl
Sabella) in branch 'master':
bpo-28157: Improvements for the time module documentation (GH-928)
https://github.com/python/cpython/
Berker Peksag <berker.pek...@gmail.com> added the comment:
Thank you for the report. Fixed in
https://github.com/python/peps/commit/070dc7e037e5f66e4e17b661641503815a8bbe05
(By the way, you can report issues like this at
https://github.com/python/peps/issues or send a PR di
Berker Peksag <berker.pek...@gmail.com> added the comment:
Thanks for the report. Your analysis is correct and this is a duplicate of
issue 31325. I'll take care of the PR 3259.
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
supersede
Berker Peksag added the comment:
We already use sqlite3_prepare_v2 if it's available:
https://github.com/python/cpython/blob/master/Modules/_sqlite/util.h#L43
Do you want to use sqlite3_prepare_v2() unconditionally and drop support for
older SQLite versions?
--
nosy: +berker.peksag
Berker Peksag added the comment:
Thank you for the report. This is a duplicate of issue 31395. See
https://bugs.python.org/issue31395#msg301978 and
https://github.com/python/psf-salt/issues/118 for details.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
Berker Peksag added the comment:
Thank you for your detailed response, Aivar. I agree that adding 'and Ellipsis'
would make the tokenize documentation clearer. Would you like to send a pull
request?
--
keywords: +easy
type: -> enhancem
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +ned.deily
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31395>
___
Berker Peksag added the comment:
Please don't reopen an issue if it was closed by a core developer.
It's not clear to me what exactly do you want to change in the implementation
or documentation.
A sequence of three periods has a special meaning as an ellipsis literal.
is literally
Berker Peksag added the comment:
If you look at
https://docs.python.org/3/reference/lexical_analysis.html#delimiters '.'
(period) is listed as delimiter and there is the following sentence to answer
your question:
A sequence of three periods has a special meaning as an ellipsis literal
Berker Peksag added the comment:
Thank you for the report, but this behavior is already documented at
https://docs.python.org/3/library/tokenize.html
To simplify token stream handling, all Operators and Delimiters
tokens are returned using the generic token.OP token type. The
exact
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.5, Python 3.6, Python 3.7
___
Python tracker <rep...@bugs.python.org>
&l
Berker Peksag added the comment:
Thank you for the report. I think we can add a simplified version of the
OperationalError documentation in PEP 249:
Exception raised for errors that are related to the database's
operation and not necessarily under the control of the programmer,
e.g
Berker Peksag added the comment:
Good catch and thank you for turning the bug report in the HN thread to a pull
request! I agree with all of Raymond's comments.
I have two more comments:
* Please follow our commit style at
https://devguide.python.org/committing/#commit-messages
* We need
Berker Peksag added the comment:
Two things:
1. I've just closed PR 2618 as the scope of this issue is broader than my PR.
2. Could you also add version information of sqlite3?
--
nosy: +berker.peksag
stage: -> patch review
___
Python tracker &
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
pull_requests: +3116
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30871>
___
Berker Peksag added the comment:
For those who want to triage this issue, the test case can be found at
https://github.com/drallensmith/neat-python/blob/e4aeb39eccefbd73babfb61bb13fd23feef2a102/tests/test_distributed.py#L234
--
nosy: +berker.peksag, davin, pitrou
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +belopolsky
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30516>
___
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> webbrowser.get(command_line) does not support Windows-style
path separators
type: -> behavior
_
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
components: +Tests
stage: -> backport needed
versions: +Python 3.6
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Berker Peksag added the comment:
New changeset 26248ef58dcf49619930ffa2e050ffa687a88601 by Berker Peksag (Eli
Boyarski) in branch 'master':
bpo-30456: Clarify example for duplicates in second argument of isinstance
(GH-1699)
https://github.com/python/cpython/commit
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
stage: -> backport needed
type: -> behavior
versions: +Python 3.5, Python 3.6, Python 3.7
___
Python tracker <rep...@bugs.python.org>
<http://bugs.
Berker Peksag added the comment:
cx_Oracle is not part of the Python standard library and according to
https://community.oracle.com/thread/4048639 the solution is to install it from
Solaris' package repository.
--
nosy: +berker.peksag
resolution: -> third party
stage: -> re
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
stage: needs patch -> patch review
type: -> enhancement
versions: +Python 3.7
___
Python tracker <rep...@bugs.python.org>
<http://bugs.
Berker Peksag added the comment:
Thank you for the PR, Aaron!
--
resolution: -> fixed
stage: backport needed -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Berker Peksag added the comment:
New changeset e78dc0aaf03cd98373910150c2d35418cf938254 by Berker Peksag in
branch '3.5':
[3.5] bpo-29403: Fix mock's broken autospec behavior on method-bound builtin
functions (GH-3)
https://github.com/python/cpython/commit
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
pull_requests: +2860
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29403>
___
Berker Peksag added the comment:
New changeset 64b9a15886840df422c5203fad25c9801b4cf61e by Berker Peksag in
branch '3.6':
[3.6] bpo-29403: Fix mock's broken autospec behavior on method-bound builtin
functions (GH-3)
https://github.com/python/cpython/commit
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
pull_requests: +2858
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29403>
___
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
stage: patch review -> backport needed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Berker Peksag added the comment:
Thanks, Ammar!
--
resolution: -> fixed
stage: backport needed -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Berker Peksag added the comment:
New changeset ae4dca7701ca77a37aa8c956450ff8e21fe6883e by Berker Peksag (Ammar
Askar) in branch '3.6':
[3.6] bpo-30883: Use pythontest.net instead of debian.org in test_urllib2net
(GH-2755)
https://github.com/python/cpython/commit
Berker Peksag added the comment:
New changeset aca493b7a337338fa20395fbc2d1895cb8093826 by Berker Peksag (Ammar
Askar) in branch '3.5':
[3.5] bpo-30883: Use pythontest.net instead of debian.org in test_urllib2net
(GH-2755)
https://github.com/python/cpython/commit
Berker Peksag added the comment:
New changeset 856cbcc12f2e4cca93af5dc7ed6bcea4dd942f10 by Berker Peksag (Aaron
Gallagher) in branch 'master':
bpo-29403: Fix mock's broken autospec behavior on method-bound builtin
functions (GH-3)
https://github.com/python/cpython/commit
Berker Peksag added the comment:
I don't think most of the changes improve readability of json.tool. Everyone
has their own preferences and it's usually not enough to justify code churn.
Also, we don't need to add comments when the code itself is pretty descriptive:
# Output JSON
Berker Peksag added the comment:
New changeset a739000db55ef55e69a53ca6966ea8657cac4354 by Berker Peksag (Ammar
Askar) in branch '2.7':
[2.7] bpo-30883: Use pythontest.net instead of debian.org in test_urllib2net
(GH-2755)
https://github.com/python/cpython/commit
Berker Peksag added the comment:
I merged Ammar's PR in d81bea6520892e0428aec61c73e0631a69db11bb, but it looks
like I missed that the PR title and commit message was different and the latter
didn't contain bpo-30883.
--
stage: needs patch -> backport needed
versions: +Python
Berker Peksag added the comment:
python-redmine is not part of the Python standard library.
https://github.com/maxtepkeev/python-redmine/issues is a better place to ask
usage questions like this, thank you!
--
nosy: +berker.peksag
resolution: -> third party
stage: -> resolved
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +berker.peksag
stage: -> needs patch
type: -> behavior
versions: +Python 3.7
___
Python tracker <rep...@bugs.python.org>
<http://bugs.
Berker Peksag added the comment:
Ok, I think we can finally close this one :) Thank you, everyone!
--
resolution: -> fixed
stage: backport needed -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http
Berker Peksag added the comment:
New changeset bfa4fe4f39dd8b5ce1a0b649cedd36857859081a by Berker Peksag (Nir
Soffer) in branch '2.7':
[2.7] bpo-29854: Fix segfault in call_readline() (GH-728)
https://github.com/python/cpython/commit/bfa4fe4f39dd8b5ce1a0b649cedd36857859081a
Berker Peksag added the comment:
New changeset 68c3724651776f4ae90ed24d70cef6fd45bc7db5 by Berker Peksag (Nir
Soffer) in branch '3.5':
[3.5] bpo-29854: Fix segfault in call_readline() (GH-728)
https://github.com/python/cpython/commit/68c3724651776f4ae90ed24d70cef6fd45bc7db5
Berker Peksag added the comment:
New changeset 04f77d4677e7508b6ec8de9d0331fdabbcd11d30 by Berker Peksag (Nir
Soffer) in branch '3.6':
[3.6] bpo-29854: Fix segfault in call_readline() (GH-728)
https://github.com/python/cpython/commit/04f77d4677e7508b6ec8de9d0331fdabbcd11d30
Berker Peksag added the comment:
New changeset aa6a4d6ed881f79c51fb91dd928ed9496737b420 by Berker Peksag (Nir
Soffer) in branch 'master':
bpo-29854: Skip history-size test on older readline (GH-2621)
https://github.com/python/cpython/commit/aa6a4d6ed881f79c51fb91dd928ed9496737b420
Berker Peksag added the comment:
According to https://cnswww.cns.cwru.edu/php/chet/readline/CHANGES, the
history-size setting was added in readline 6.0:
e. A new user-settable variable, `history-size', allows setting the maximum
number of entries in the history list.
The only
Berker Peksag added the comment:
> So we have version 0x502 without libedit emulation succeeding on
> FreeBSD 9.x, and failing on 10.x.
test_history_size() fails on FreeBSD 9.x too:
==
FAIL: test_histor
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
pull_requests: +2684
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29854>
___
Berker Peksag added the comment:
I've opened PR 2618 to print readline version and implementation in regrtest's
display_header() method.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Berker Peksag added the comment:
> Similar failure on x86 Tiger 3.x.
This one is interesting. I thought we don't have OS X buildbots with readline
installed.
I would prefer skipping the test based on readline version installed.
Side note: I think we should print readline, sqlite3
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
stage: patch review -> backport needed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Berker Peksag added the comment:
New changeset fae8f4a9cb88a68eb14750cbb8ddf8740fd67b8b by Berker Peksag (Nir
Soffer) in branch 'master':
bpo-29854: Fix segfault in call_readline() (GH-728)
https://github.com/python/cpython/commit/fae8f4a9cb88a68eb14750cbb8ddf8740fd67b8b
--
nosy
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Berker Peksag added the comment:
Yes, they are. I like the idea of generating C files from Lib/token.py. Let's
see what David thinks about issue 30455.
--
nosy: +berker.peksag
___
Python tracker <rep...@bugs.python.org>
<http://bugs.p
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Berker Peksag added the comment:
Thank you for the report, Sarge. This is already reported to python.org issue
tracker at https://github.com/python/pythondotorg/issues/1079
Closing this as 'third party'.
--
nosy: +berker.peksag
resolution: -> third party
stage: -> resolved
Berker Peksag added the comment:
You don't need a GitHub account for contributing to CPython, but the pull
request workflow is the preferred way. You can still attach your patches to
this issue.
--
nosy: +berker.peksag
___
Python tracker <
Berker Peksag added the comment:
I personally never need this feature before so I will add Michael and Robert to
nosy list to take their opinions.
--
nosy: +berker.peksag, michael.foord, rbcollins
stage: -> patch review
___
Python tracker &
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
Removed message: http://bugs.python.org/msg295480
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
Removed message: http://bugs.python.org/msg295479
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: -Love
resolution: -> not a bug
stage: -> resolved
status: open -> closed
title: The reply's additional 'Re' is ok -> Spam
___
Python tracker <rep...@b
Berker Peksag added the comment:
Please don't close it yet. I agree with Serhiy's comments in msg293394, but I
couldn't find time to address his comments yet (plus we still need to backport
the documentation update to 3.5 and 3.6 branches
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
pull_requests: +1881
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30404>
___
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
pull_requests: -1794
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
pull_requests: +1749
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue28647>
___
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
pull_requests: +1721
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30376>
___
Berker Peksag added the comment:
New changeset 0d267041c40a3ab655676b885c0ba35ed9685848 by Berker Peksag in
branch '3.6':
bpo-29898: Fix incorrect env variable name (GH-1576)
https://github.com/python/cpython/commit/0d267041c40a3ab655676b885c0ba35ed9685848
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
resolution: -> fixed
stage: backport needed -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
801 - 900 of 3698 matches
Mail list logo
