Chris Jerdonek added the comment:
This is what my search for ",] " gave me (though the OP's print and random.seed
do not show up in this list):
library/curses.rst
380:.. function:: newwin([nlines, ncols,] begin_y, begin_x)
659:.. method:: window.addch([y, x,] ch[, attr]
Chris Jerdonek added the comment:
> It would be fine with me to use a double signature for these.
Just an FYI that more than two signatures would be needed for cases like this:
766:.. method:: window.chgat([y, x, ] [num,] attr)
--
___
Pyt
Chris Jerdonek added the comment:
> What's this even supposed to mean?
I started wondering the same thing after I posted. :)
I guess my point/question is: are there any cases where more than two
signatures would be needed to account for all of the possi
Chris Jerdonek added the comment:
The following commit from today is related to this issue: 815b88454e3e
"Remove trailing whitespace in order to silence warnings on HP-UX."
--
nosy: +cjerdonek
___
Python tracker
<http://bugs.python.
Chris Jerdonek added the comment:
> (The double signature might be easier to understand, but the original issue
> should probably be fixed in Sphinx, even if we decide to stop using this kind
> of signature.)
I filed an issue for this in the Sphinx tracker here:
https://bitb
Chris Jerdonek added the comment:
I will prepare a patch (multiple signatures, for the Python fix).
--
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
Something to be aware of that may or may not affect the patch I'm preparing:
One reason that Sphinx seems able to render some of the more complicated
function signatures is that it has logic to bail and print the parameter list
verbatim from the reST
Chris Jerdonek added the comment:
Here are a couple functions that may need a fix different from multiple
signatures:
print([object, ...], *, sep=' ', end='\n', file=sys.stdout, flush=False)
http://docs.python.org/dev/library/functions.html#print
class argparse.Argumen
Chris Jerdonek added the comment:
FWIW, I submitted a patch for the Sphinx issue I created:
https://bitbucket.org/birkenfeld/sphinx/issue/1001
Ironically, that patch was probably easier than this patch will be.
--
___
Python tracker
<h
New submission from Chris Jerdonek:
It seems like a couple error messages in the curses module need correcting:
PyErr_SetString(PyExc_TypeError, "insch requires 1 or 4 arguments");
http://hg.python.org/cpython/file/8ff2f4634ed8/Modules/_cursesmodule.c#l1322
PyErr_SetString(PyExc
Chris Jerdonek added the comment:
Attaching a proposed patch for the default branch. Also, here are several
comments and questions.
> I think/hope that all the APIs we have in the stdlib are sane enough to have
> no more than 2-3 signatures
I found this one in the curses module wit
Chris Jerdonek added the comment:
I just completed a patch to improve the documentation of these signatures
(along with many others) in issue 15831. The correction here is consistent
with my findings and revised documentation there.
As for the code, they are straightforward switch statements
Chris Jerdonek added the comment:
The situation is the same in 2.7 (and probably 3.2).
--
versions: +Python 2.7, Python 3.2
___
Python tracker
<http://bugs.python.org/issue15
New submission from Chris Jerdonek:
As of: changeset: 78843:8ff2f4634ed8
date:Sun Sep 02 16:37:09 2012 -0400
I am getting this failure:
$ ./python.exe -m test -v -u curses test_curses
== CPython 3.3.0rc1+ (default:8ff2f4634ed8, Sep 2 2012, 16:02:43) [GCC 4.2.1
Compatible Apple Clang
Changes by Chris Jerdonek :
--
title: curses test_curses test_unget_wch -> curses test_curses.test_unget_wch
crash
___
Python tracker
<http://bugs.python.org/issu
Chris Jerdonek added the comment:
Attaching a patch with tests and fix for the default branch.
--
keywords: +patch
Added file: http://bugs.python.org/file27105/issue-15831-1.patch
___
Python tracker
<http://bugs.python.org/issue15
Changes by Chris Jerdonek :
--
keywords: +needs review
stage: test needed -> patch review
___
Python tracker
<http://bugs.python.org/issue15852>
___
___
Python-
Chris Jerdonek added the comment:
Uploading correct file.
--
Added file: http://bugs.python.org/file27106/issue-15852-1.patch
___
Python tracker
<http://bugs.python.org/issue15
Changes by Chris Jerdonek :
Removed file: http://bugs.python.org/file27105/issue-15831-1.patch
___
Python tracker
<http://bugs.python.org/issue15852>
___
___
Python-bug
Chris Jerdonek added the comment:
Okay, thanks, Ned. Out of curiosity, why is the stack trace here different
from the one posted on that issue?
--
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
I added some comments on the latest patch on the review tool.
--
___
Python tracker
<http://bugs.python.org/issue15557>
___
___
Chris Jerdonek added the comment:
Thanks, David. I wasn't sure if you had seen the comments. They're mostly
stylistic, though, so it's not too big of a deal.
--
___
Python tracker
<http://bugs.pyt
Chris Jerdonek added the comment:
Fair enough. :) I may keep a couple of those changes in mind if I ever have a
chance to visit this module myself in the future.
--
___
Python tracker
<http://bugs.python.org/issue15
Changes by Chris Jerdonek :
--
nosy: +cjerdonek
___
Python tracker
<http://bugs.python.org/issue8911>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
> If you look at importlib.regrtest you will notice it has to muck with
> sys.argv in order to get certain tests skipped.
This is reminiscent of issue 15132 which I filed, but for
unittest.TestProgram() rather than regrtest.main().
> 6. Switch regrt
Chris Jerdonek added the comment:
Thanks, Andrew. Regarding your comment, it was a deliberate choice not to do
the additional check because I wanted each test to check only one thing. But I
am okay with adding the additional check.
Regarding the patch, should all of the methods now do
Chris Jerdonek added the comment:
Thanks a lot for the very thorough review, David. I should be able to update
the patch and respond to a couple of your points later today or tomorrow at the
latest.
--
___
Python tracker
<http://bugs.python.
Chris Jerdonek added the comment:
For future reference, here is the beginning of the e-mail thread on python-dev:
http://mail.python.org/pipermail/python-dev/2012-September/121584.html
We also need to know whether the Tru64 trick needs to be used in 2.7, since
this documentation issue also
Chris Jerdonek added the comment:
Andrew, I seem to be getting a test failure for test_executable_with_cwd() with
your updated patch (the child process is outputting an absolute path rather
than '').
I will update the patch to fix. There are also some stylistic changes I would
li
Chris Jerdonek added the comment:
Here is an updated patch. The changes I made are:
(1) Update code comments in _call_popen_and_assert().
(2) Fix test failure.
(3) Rename _call_popen_and_assert() to _assert_cwd() since it is a simpler
name and the old name did not reflect that the method
Chris Jerdonek added the comment:
Updating the patch again to tweak the original documentation change.
I was concerned that the previous language could be construed to mean that
Popen will look in *two* places for the executable (both relative to the
current directory and relative to the cwd
Chris Jerdonek added the comment:
Thanks for responding to all of those questions, Ezio. I will update the patch
based on your responses. (Likely most of it will remain the same.)
> Note that if possible, it's better to avoid using the [] and put the default
> values. Howeve
Chris Jerdonek added the comment:
Updating the doc portion of the patch one more time.
--
Added file: http://bugs.python.org/file27118/issue-15533-7-default.patch
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
Attaching an updated patch after doing another pass at the code and in light of
Ezio's comments.
Let me know if and when you'd like me to prepare separate patches for 2.7 and
3.2.
--
Added file: http://bugs.python.org/file27120/issue-158
New submission from Chris Jerdonek:
This issue is to make sure that the bare * in the function signatures of pure
Python functions is properly reflected in the documentation.
This will bring the signatures in the documentation closer to the signatures
that we have in the Python code -- a goal
Chris Jerdonek added the comment:
> We are moving toward using the same signatures that we have in the Python
> code The single * is not so common (yet),
I created issue 15865 to add the single * to the documentation where
appro
Chris Jerdonek added the comment:
I responded to David's comments on the review tool. Later today I will update
the patch in response to his comments (accommodating all of his suggestions)
along with a couple other changes.
--
___
Python tr
Chris Jerdonek added the comment:
Attaching an updated patch as promised in my previous comment.
Note that I removed two edge test cases pertaining to leading whitespace. I
would rather discuss those cases as part of a different issue to avoid making
this thread even longer (and it is off
Chris Jerdonek added the comment:
This slipped under my radar. After starting work on this again, I realize that
it would make sense to complete issue 15476 first. The reason is that it would
improve the process of referencing "code object" in the generator docs (Terry's
s
Chris Jerdonek added the comment:
I am starting work on this in the next couple days.
--
___
Python tracker
<http://bugs.python.org/issue15476>
___
___
Python-bug
Chris Jerdonek added the comment:
That's fine by me. I guess what's more important to me is that "code object"
have a central, linkable definition *somewhere* (and not necessarily that this
somewhere be a glossary entry). That way references to code object in the
Chris Jerdonek added the comment:
Here is a proposed patch that attempts to minimize the chance of test breakage
for Tru64. The patch follows Martin's recommendation on python-dev of being
cautious by following existing code.
--
Added file: http://bugs.python.org/file27123/
Chris Jerdonek added the comment:
> So is the root problem that Sphinx does not handle keyword-only arguments?
I don't think so. Sphinx renders the * just fine. It's just that in some of
the reST files, the * was left out.
--
___
P
Chris Jerdonek added the comment:
Actually, it looks like configparser is the *only* file with missing single
*'s. :) However, I did find a few other typos in the process of checking those
signatures in the other files.
Patch attached.
--
keywords: +patch
Added file:
Changes by Chris Jerdonek :
--
keywords: +needs review
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue15865>
___
___
Python-
Changes by Chris Jerdonek :
--
nosy: +cjerdonek
___
Python tracker
<http://bugs.python.org/issue15867>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
Can you also provide a test?
--
nosy: +cjerdonek
___
Python tracker
<http://bugs.python.org/issue15872>
___
___
Python-bug
Changes by Chris Jerdonek :
--
title: It's hard to decypher how to build off of the provided objects from the
importlib docs -> make importlib documentation easier to use
___
Python tracker
<http://bugs.python.org
Chris Jerdonek added the comment:
Thanks, Terry. If anyone is curious, it looks like the verbose keyword
argument was added to the docs (and to threading.py) in revision f71acc4b2341,
and then subsequently removed (but not from the docs) in revision 8ec51b2e57c2.
> (The fact that we foun
Chris Jerdonek added the comment:
Here is an updated patch that incorporates Terry's suggestion.
--
Added file: http://bugs.python.org/file27145/issue-15865-2.patch
___
Python tracker
<http://bugs.python.org/is
Chris Jerdonek added the comment:
+# NB: we hold on to references to functions in the arglist due to the
This is a nit, but I think adding "NB:", "Note:", etc. to the beginning of a
comment is redundant because by being a comment it is already implicit that
Chris Jerdonek added the comment:
Attached is a patch that adds to regrtest the ability to run doctests in both
library modules and documentation files (specifically, in the non-test modules
in Lib/ and in the *.rst files in Doc/).
The syntax to run all doctests is--
python -m test
Chris Jerdonek added the comment:
I prepared the patch against 3.3 (default), so I wouldn't have expected it to
work against 3.2 without further changes. The behavior in 3.3 after merging is
also surprising given that it worked in 3.2 (and for me with direct
application).
I will look
Chris Jerdonek added the comment:
I tried applying the latest patch (patch #6) to 3.2, merging to default, and
then running all tests in default, and the tests seem to all pass for me (in
both default and 3.2). Also, the "diff" for the change in default after that
process s
Chris Jerdonek added the comment:
Here is where the typo was introduced:
http://hg.python.org/cpython/rev/c890cbad4748#l1.69
--
nosy: +cjerdonek
title: Doc: same word iteration -> os.stat() docs repeat "specifying a file
descriptor&
New submission from Chris Jerdonek:
The ipaddress HOWTO seems to have some errors in its interactive doctest
examples. Below are the errors after running the doctests for it using the
regrtest patch posted to issue 15629. (This is the first doc file for which I
have used the modified script
New submission from Chris Jerdonek:
The --start option to regrtest raises an AttributeError in many scenarios. For
example, these both raise an error:
$ ./python.exe -m test --start test_random
$ ./python.exe -m test --start test_random test_binascii test_random
Traceback (most recent call
Chris Jerdonek added the comment:
This issue also affects 3.2 (but not 2.7; there is no --start option in 2.7).
--
versions: +Python 3.2
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
While we are here, the corresponding Python file also has a couple errors in
one of its doctest examples.
File "Lib/ipaddress.py", line 209, in ipaddress.summarize_address_range
Failed example:
summarize_address_range(IPv4Address('192.0.2
Chris Jerdonek added the comment:
And also the main doc file Lib/ipaddress.rst (along with some formatting
issues, and after adding needed imports):
File "Doc/library/ipaddress.rst", line 115, in ipaddress.rst
Failed example:
ipaddress.IPv4Address(3221225985)
Expected:
I
Chris Jerdonek added the comment:
What workflow/command are you using to apply and then merge the patch? I
didn't need to run "hg add" at any point to go from 3.2 to default, and run the
tests, etc.
--
___
Python tracker
<http
Chris Jerdonek added the comment:
I will prepare a patch for these three files.
--
___
Python tracker
<http://bugs.python.org/issue15888>
___
___
Python-bug
Chris Jerdonek added the comment:
I was reminded of this issue by the following e-mail today:
http://mail.python.org/pipermail/python-dev/2012-September/121639.html
I updated the script I attached earlier to ensure that it can also be run
against the names in 2.7 (attaching now as script #3
Chris Jerdonek added the comment:
I discovered this today as well while reading the doctest documentation.
One thing that I never noticed before (and that doesn't seem to be reflected in
the comments above) is that many of the code snippet rectangles in the doctest
documentation have a
Chris Jerdonek added the comment:
Attaching patch.
The doctests for these three files now all pass (using a newer version of the
patch I uploaded to issue 15629).
--
keywords: +patch
Added file: http://bugs.python.org/file27161/issue-15888-1.patch
Chris Jerdonek added the comment:
I am attaching an updated version of the patch for feedback.
The latest version of the patch I developed and used in the real-world example
of fixing both the module and documentation file doctests for the ipaddress
module (and its HOWTO) in issue 15888.
The
New submission from Chris Jerdonek:
This issue is to fix Doc/howto/unicode.rst so that its doctests pass when using
the doctest module.
Patch forthcoming.
--
assignee: docs@python
components: Documentation
keywords: easy
messages: 170167
nosy: cjerdonek, docs@python
priority: normal
Chris Jerdonek added the comment:
Attaching patch for the default branch.
--
keywords: +patch
stage: -> patch review
Added file: http://bugs.python.org/file27163/issue-15899-1.patch
___
Python tracker
<http://bugs.python.org/issu
Chris Jerdonek added the comment:
Thanks a lot, David.
--
___
Python tracker
<http://bugs.python.org/issue14649>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Chris Jerdonek:
doctest currently has 8 "data" files used for testing that are spread across
Lib/test (in addition to the main test files test_doctest.py and
test_doctest2.py):
doctest_aliases.py
sample_doctest.py
sample_doctest_no_doc
Changes by Chris Jerdonek :
--
versions: +Python 2.7, Python 3.2
___
Python tracker
<http://bugs.python.org/issue15899>
___
___
Python-bugs-list mailing list
Unsub
New submission from Chris Jerdonek:
Currently, calling doctest.DocTestSuite() raises a ValueError if the module
passed to it has no docstrings. This was the subject of issue 14649.
This issue is to discuss and possibly change DocTestSuite's behavior not to
raise an exception in
Chris Jerdonek added the comment:
> You should also see if there are more doctest-safe or more doctest-unsafe
> tests, and mark the ones in the smallest group.
Running the doctests for all .rst files in the Doc/ directory using the latest
patch gave me the following:
299 tests [fil
Chris Jerdonek added the comment:
> Integrating this with regrtest requires some work, for example you would have
> to count successes/failures, add skips for certain tests and resources to
> control what tests should be run (there's currently a turtle going around on
> my
Chris Jerdonek added the comment:
> Sphinx does have a way to mark doctest snippets as "run this", "don't run
> this". I believe that requires using 'make doctest' as the runner,
The doctest module supports this natively (i.e. without the need for Sph
Chris Jerdonek added the comment:
> The reason is that Sphinx has extra facilities that allow docttests to work
> without having to have "boilerplate" code in places where doing so would
> disrupt the narrative flow.
Yes, this seems to be true. Sphinx has a "testset
Chris Jerdonek added the comment:
Thanks, Senthil!
--
___
Python tracker
<http://bugs.python.org/issue15899>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
Adding Eli to this because he did some work on the HOWTO for this module in
issue 14814.
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue15
New submission from Chris Jerdonek:
On hg.python.org, it seems like the entries on the "log" page don't
always link to the corresponding revision, for example some of the rows in--
http://hg.python.org/cpython/shortlog/1d9e89f6abec
This seems to happen whenever the revision des
Chris Jerdonek added the comment:
Andrew, do you think my changes to the patch are adequate given the response on
python-dev to your question?
--
___
Python tracker
<http://bugs.python.org/issue15
New submission from Chris Jerdonek:
This issue is to make the doctests in howto/regex.rst pass using vanilla
doctest. After this issue, 10 out of the 17 HOWTO's will pass with vanilla
doctest.
Patch attached.
--
assignee: docs@python
components: Documentation
files: issue-do
Chris Jerdonek added the comment:
As an aside, I noticed a doctest affected by this in the urllib HOWTO:
>>> url_values = urllib.parse.urlencode(data)
>>> print(url_values)
name=Somebody+Here&language=Python&location=Northampton
http://docs.python.org/dev/howto/urll
New submission from Chris Jerdonek:
This issue is to make the doctests in howto/urllib2.rst pass using vanilla
doctest.
Patch attached.
--
assignee: docs@python
components: Documentation
files: issue-doctest-howto-urllib-1.patch
keywords: easy, patch
messages: 170305
nosy: cjerdonek
Changes by Chris Jerdonek :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue15922>
___
___
Python-bugs-list mailing list
Unsubscri
Chris Jerdonek added the comment:
I'm not sure of all the implications of this, but it seems like this is a
relevant piece of information from the docs:
"type= can take any callable that takes a single string argument and returns
the converted value:"
(from http://docs.python.
Chris Jerdonek added the comment:
Along the lines of my previous comment, I notice that the following str type
check was removed in the patch for issue 12776:
-if isinstance(action.default, str):
-default = self._get_value(action, default
Chris Jerdonek added the comment:
Here is a type of test case that I think should be considered for addition (to
confirm that the code doesn't double-convert strings in at least one case).
Maybe there is already a test case like this:
class MyString(str): pass
def convert(s):
r
Chris Jerdonek added the comment:
[From python-dev:
http://mail.python.org/pipermail/python-dev/2012-September/121683.html ]
> I've tried the various suggestions out, and I think from a practical point of
view, a fix for the regression in the 2.7, 3.2 and 3.3 branches should be to
a
Chris Jerdonek added the comment:
> Do we need a new test for conversion of string defaults?
I think we should also update the documentation of the "default" keyword
argument (and/or the "type" argument) to remove any ambiguity and make the
behavior more clear.
Maybe
Chris Jerdonek added the comment:
> Do you want to prepare the patch, Chris?
Sure, I should be able to get to this today or tomorrow.
--
___
Python tracker
<http://bugs.python.org/issu
Chris Jerdonek added the comment:
Thanks for committing the change. However--
+def test_no_double_type_conversion_of_default(self):
+def extend(str_to_convert):
+return str_to_convert + '*'
+
+parser = argparse.ArgumentParser()
+parser.ad
Chris Jerdonek added the comment:
Oh, never mind. The initial default value has one star to begin with.
--
___
Python tracker
<http://bugs.python.org/issue15
New submission from Chris Jerdonek:
This issue is to clarify in the documentation the argparse behavior for which
tests were added in issue 15906.
The behavior involves when the type callable should be applied to default
arguments. See, for example, the following comment for what roughly
Chris Jerdonek added the comment:
> I think that will just leave the doc updates for Chris once my patch lands in
> all three branches.
I created an issue for this here:
http://bugs.python.org/issue15935
--
___
Python tracker
Changes by Chris Jerdonek :
--
nosy: +cjerdonek
___
Python tracker
<http://bugs.python.org/issue10224>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
Attaching patch.
--
keywords: +patch
Added file: http://bugs.python.org/file27182/issue-15935-1.patch
___
Python tracker
<http://bugs.python.org/issue15
Chris Jerdonek added the comment:
Just an FYI that Ezio asked Georg about this issue on IRC yesterday or the day
before, and Georg said +1.
--
___
Python tracker
<http://bugs.python.org/issue15
Changes by Chris Jerdonek :
--
components: +Library (Lib) -None
title: cvs.reader does not support escaped newline when quoting=cvs.QUOTE_NONE
-> csv.reader() does not support escaped newline when quoting=csv.QUOTE_NONE
___
Python tracker
&l
Chris Jerdonek added the comment:
Thanks for the report. However, for this issue, you should e-mail
webmas...@python.org instead, as this page describes:
http://www.python.org/about/website/
The part of the Python web site affected by this issue is maintained separately
from the parts of
Changes by Chris Jerdonek :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue15924>
___
___
Python-bugs-list mailing list
Unsubscri
701 - 800 of 1575 matches
Mail list logo
