Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16309
___
___
Python-bugs-list
Chris Rebert added the comment:
No, the thought merely did not occur to me. I don't recall having seen such
forward-looking notes in Python's documentation before.
Should the pipes.quote() mention be axed from the 3.x patch?
--
___
Python tracker
Chris Rebert added the comment:
file.readlines() (and perhaps dare I say even file.readline()) should not even
be mentioned in the tutorial, IMO. It is difficult to imagine a use case where
just iterating over the file object isn't superior. I cannot remember the last
time that I have used
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16131
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3173
___
___
Python-bugs-list
Chris Rebert added the comment:
I'm going to bikeshed and again suggest that %I and %p be included for handling
12-hour clock times.
Also, the patch seems to only be for strftime(), and not strptime().
--
___
Python tracker rep...@bugs.python.org
Chris Rebert added the comment:
This is now hardcore nitpicking, but I'm conflicted as to whether %p should be
grouped with the other locale-related codes or with %I (since it's hard to
imagine using %I or %p in a singleton capacity).
In any case, props to Mike for putting an actual patch
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16048
___
___
Python-bugs-list
Chris Rebert added the comment:
Any reactions? The patch is pretty straightforward...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14570
Changes by Chris Rebert pyb...@rebertia.com:
Added file: http://bugs.python.org/file27196/subprocess.rst-2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14616
Chris Rebert added the comment:
Updated patches to mention pipes.quote().
--
Added file: http://bugs.python.org/file27197/subprocess.rst-3.3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14616
Chris Rebert added the comment:
Ping. Any further comments?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15789
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15873
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
Added file: http://bugs.python.org/file27090/json.rst.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14570
Chris Rebert added the comment:
Attached updated patches.
--
Added file: http://bugs.python.org/file27091/json_init.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14570
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15798
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15806
___
___
Python-bugs-list
Chris Rebert added the comment:
Revised patch in response to comments.
--
Added file: http://bugs.python.org/file27029/subprocess.rst.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15789
Chris Rebert added the comment:
So you can. Neat trick.
Patch changed accordingly.
--
Added file: http://bugs.python.org/file27011/link_communicate_warning.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15788
Chris Rebert added the comment:
Let's try that again.
--
Added file: http://bugs.python.org/file27012/link_communicate_warning.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15788
Changes by Chris Rebert pyb...@rebertia.com:
Removed file: http://bugs.python.org/file27011/link_communicate_warning.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15788
New submission from Chris Rebert:
To further dissuade people from using subprocess.Popen's shell=True option
unnecessarily, this patch points out that some common shell features are also
available directly in Python via certain modules functions.
--
assignee: docs@python
components
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15767
___
___
Python-bugs-list
Chris Rebert added the comment:
Erm, the patch seems to have some ANSI terminal coloring escape code junk (e.g.
[0;31m) in it...
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14570
Chris Rebert added the comment:
It's been over a year and the patch is trivial. Any chance of it getting
applied soon?
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11964
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15533
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7186
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9650
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14783
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14870
___
___
Python-bugs-list
Chris Rebert added the comment:
+1 on including am/pm-related codes. Blame us backwards, non-metric Americans.
Sounds GTM otherwise.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9650
Changes by Chris Rebert pyb...@rebertia.com:
--
keywords: +patch
Added file: http://bugs.python.org/file27008/issue14880.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14880
Chris Rebert added the comment:
Updated patch. I concur that anyone creating a type whose name has whitespace
in it is just asking for trouble.
--
Added file: http://bugs.python.org/file27009/reprlib.rst.patch
___
Python tracker rep
Chris Rebert added the comment:
Revised patch yet again to instead speak of non-object, non-array values and
JSON null, boolean, number, or string values.
Re: Petri, the patch already mentions the specific parameters one can use to
get stricter behavior, albeit not in that particular short
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13212
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15136
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14965
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15731
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12370
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15436
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15360
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15451
___
___
Python-bugs-list
Chris Rebert pyb...@rebertia.com added the comment:
Pinging on this, since it's been just short of a month since Éric's last call
comment.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14674
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1100942
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
Removed file: http://bugs.python.org/file25594/json.rst.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14674
Chris Rebert pyb...@rebertia.com added the comment:
Any further comments now that the matter of encodings is covered more
thoroughly?
--
Added file: http://bugs.python.org/file25999/json.rst.patch
___
Python tracker rep...@bugs.python.org
http
Changes by Chris Rebert pyb...@rebertia.com:
Removed file: http://bugs.python.org/file25606/json.rst.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14674
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9679
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4442
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15039
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14966
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12779
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14886
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14880
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14617
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1191964
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1260171
___
___
Python-bugs-list
Chris Rebert pyb...@rebertia.com added the comment:
Eh, just needs clarification along the lines of:
Exceptions raised in the child ++Python++ process
A ValueError will be raised if Popen is called with invalid arguments
++whose validity is not dependent upon the state
Chris Rebert pyb...@rebertia.com added the comment:
The term invalid arguments in A ValueError will be raised if Popen is called
with invalid arguments. is still vague. One could well argue that a
nonexistent executable or bad command is invalid. Anything resulting in an
OSError can
Chris Rebert pyb...@rebertia.com added the comment:
Hopefully final revision. Thanks for the quick response Éric!
Changes:
- Cover `ensure_ascii` parameter per latest review comment
- Add enhanced Character Encodings section for 2.x backport
-- Cover `encoding` parameter restrictions
-- Cover
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14872
___
___
Python-bugs-list
Chris Rebert pyb...@rebertia.com added the comment:
So, does the refactored patch need any further revising, or is it good to go?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14674
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14845
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
Removed file: http://bugs.python.org/file25592/json.rst.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14674
Changes by Chris Rebert pyb...@rebertia.com:
Added file: http://bugs.python.org/file25606/json.rst.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14674
Changes by Chris Rebert pyb...@rebertia.com:
Removed file: http://bugs.python.org/file25591/json.rst.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14674
Chris Rebert pyb...@rebertia.com added the comment:
Patch. Though I ponder whether the expression in question might be equivalent
to simply:
type(obj).__name__.replace('_', ' ')
--
keywords: +patch
nosy: +cvrebert
Added file: http://bugs.python.org/file25607/reprlib.rst.patch
Chris Rebert pyb...@rebertia.com added the comment:
New revision per Éric's Rietveld feedback.
Sidenote: Is there any way to get notified of these reviews? I only saw it
because I happened to click the review link on a lark.
--
Added file: http://bugs.python.org/file25594
Chris Rebert pyb...@rebertia.com added the comment:
The import jsons were left for uniformity with the other code samples in the
module's docs.
Also, here's what the pedantically-strict recipes might look like:
def _reject_inf_nan(string):
if string in {'-Infinity', 'Infinity', 'NaN
Chris Rebert pyb...@rebertia.com added the comment:
Further copyediting.
--
Added file: http://bugs.python.org/file25595/json.rst.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14674
Chris Rebert pyb...@rebertia.com added the comment:
Reflect broader scope
--
title: Add link to RFC 4627 from json documentation - Link to explain
deviations from RFC 4627 in json module docs
___
Python tracker rep...@bugs.python.org
http
Chris Rebert pyb...@rebertia.com added the comment:
for key, value in pairs:
if key in pairs:
if key in obj:?
Yes, obviously. :-) It wrote those very late at night.
@Ezio: These were per Éric's feedback but would be for a separate bug/patch
Chris Rebert pyb...@rebertia.com added the comment:
Notification of any future Rietveld comments would be appreciated.
--
Added file: http://bugs.python.org/file25603/json.rst.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Chris Rebert pyb...@rebertia.com added the comment:
Draft docs patch. More cross-referencing. Analysis of deviations from RFC based
on previous docs the RFC.
Don't know if there are relevant, more precise implementation limitations that
need to be mentioned.
If backported to 2.x, will need
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14805
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14757
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
Added file: http://bugs.python.org/file25592/json.rst.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14674
Chris Rebert pyb...@rebertia.com added the comment:
Right, I can see how the 3rd paragraph has become tangential given the refined
scope of the entry.
What do people think about a separate entry:
annotation
Can refer to either a `function annotation` or some uses of
`decorator`s
Changes by Chris Rebert pyb...@rebertia.com:
Added file: http://bugs.python.org/file25568/function_annotation_v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14187
Chris Rebert pyb...@rebertia.com added the comment:
Patch to mention shlex.quote() in the `subprocess` module's Frequently Used
Arguments Warning box. Could perhaps be a separate Note, but that could be
clutter-y.
--
keywords: +patch
Added file: http://bugs.python.org/file25570
Chris Rebert pyb...@rebertia.com added the comment:
Re: Nick's comments:
Besides `close_fds`, what other Popen parameters currently have suboptimal
defaults?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7839
Chris Rebert pyb...@rebertia.com added the comment:
Here's an actual patch.
--
keywords: +patch
Added file: http://bugs.python.org/file25544/func_annotation.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14187
Chris Rebert pyb...@rebertia.com added the comment:
Any reactions to the strawman wording for the entry?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14187
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10427
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13968
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9530
___
___
Python-bugs-list
Chris Rebert pyb...@rebertia.com added the comment:
Here's a quick stab at 2/3rds of an implementation, and some docs.
--
Added file: http://bugs.python.org/file25310/shutil_open.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Chris Rebert pyb...@rebertia.com added the comment:
# or os.name == 'mac' ???
Nope, that refers to retro Mac OS 9 (and probably lower). Mac OS X is 'posix'
for os.name purposes.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Chris Rebert pyb...@rebertia.com added the comment:
`operation` seems questionable. IMO, the verbs seem stronger / more important
than mere optional suggestions (particularly open vs. edit for files with
read-only viewers), and only Windows supports them (so anyone requiring that
feature
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14616
___
___
Python-bugs-list
Chris Rebert pyb...@rebertia.com added the comment:
No, it isn't. Changing the `IOError(errno.ENOENT, ...`s to
`FileNotFoundError(...`s would half fix it.
The other half, the `OSError(errno.ENOSYS)`s, has a FIXME for what's the right
error to raise in that case (no application associated
Chris Rebert pyb...@rebertia.com added the comment:
ENOSYS was the closest approximation I could find. Thoughts? Custom
error class? Different errno? Something else?
Why not ValueError?
Because the value they provided was perfectly valid (the file/directory *did*
exist), so the caller's
Chris Rebert pyb...@rebertia.com added the comment:
Hobs, why is exit code 4 of xdg-open (which the manpage describes as the
extremely generic The action failed.) interpreted as FileNotFoundError in
your new version?
--
___
Python tracker rep
Chris Rebert pyb...@rebertia.com added the comment:
Also:
The FileNotFoundErrors quote the path twice:
Python 2.7.1 (r271:86832, Jul 31 2011, 19:30:53)
path = /foo/bar
print Path '%s' may not exist % repr(path)
Path ''/foo/bar'' may not exist
The ValueError error message
Chris Rebert pyb...@rebertia.com added the comment:
The xdg-open source code
(http://cgit.freedesktop.org/xdg/xdg-utils/tree/scripts/xdg-open ) shows that
exit code 4 is used whenever an invocation of another opener script (e.g.
kde-open, gnome-open) fails for any reason besides said script
Chris Rebert pyb...@rebertia.com added the comment:
The semantics of associated application change considerably from
operating system to operating system. As an example,
``os.startfile(a.py)`` will usually run `a.py` in the Python
interpreter, while ``xdg-open a.py`` it will usually open
Changes by Chris Rebert pyb...@rebertia.com:
Added file: http://bugs.python.org/file25332/shutil_open.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3177
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14544
___
___
Python-bugs-list
New submission from Chris Rebert pyb...@rebertia.com:
The final line under 17.1.4.2. Replacing shell pipeline
(http://docs.python.org/dev/library/subprocess.html#replacing-shell-pipeline )
isn't formatted as code (e.g. monospaced); it should be.
--
assignee: docs@python
components
Chris Rebert pyb...@rebertia.com added the comment:
(2) Target file doesn't exist
(4) No application is associated with the file type in question
I think that instead of mapping error codes to custom exceptions, which is
fragile and not trivial to maintain, we should just catch stderr
101 - 200 of 287 matches
Mail list logo
