Changes by Christian Heimes:
--
assignee: - tiran
nosy: +tiran
priority: - urgent
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1557
__
___
Python-bugs-list mailing
New submission from Christian Heimes:
In VS 2008 the x64 platform doesn't define the _WIN64 macro. The _WIN64
macro defines the MS_WIN64 macro which sets several other macros and
changes some variables in pyconfig.h.
Question: Should we enforce MS_WIN64 for the x64 platform although
_WIN64
Christian Heimes added the comment:
Fixed in r59370 (trunk)
I'm going to merge the changes into py3k soon.
--
resolution: - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1557
Christian Heimes added the comment:
I've backported the fix to 2.5 and trunk. They suffered from the same
problem.
--
nosy: +tiran
resolution: - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1553
Christian Heimes added the comment:
Sorry guys, it was false alarm.
From r59375:
The macros _WIN32, _WIN64 and _M_X64 are defined by the compiler. The VS
2008 IDE doesn't know about (some) of the macros and can display wrong
information. In my case a section #ifdef _WIN64 was grayed out
Christian Heimes added the comment:
Fixed in r59349
Good work Amaury! :)
--
resolution: - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1539
Changes by Christian Heimes:
--
nosy: +tiran
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1561
__
___
Python-bugs-list mailing list
Unsubscribe
Christian Heimes added the comment:
I can reproduce the problem when I run the ssl tests with -unetwork.
I've used PYTHONDUMREFS and combinerefs.py to find the leaking objects.
I'm seeing lots of
0x9fd3e4c [1] SSLSocket
0x9fd2928 [1] ssl.SSLContext ssl.SSLContext object at 0x9fd2928
0x9fd5b74
Christian Heimes added the comment:
I may have found the error. The PySSL_Type doesn't support GC but it
should in order to clean up self-Socket.
I've started to fix it but I don't have time to work on the problem 'til
tonight. The patch causes a seg fault. I may have overlooked
Christian Heimes added the comment:
I found the problem! I've to use PyObject_GC_New instead of PyObject_New
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1469
__
___
Python
Changes by Christian Heimes:
Removed file: http://bugs.python.org/file8884/ssl_gc.patch
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1469
__
___
Python-bugs-list mailing list
Christian Heimes added the comment:
New patch
The new patch doesn't cause a seg fault but it doesn't help. It
*increases* the number of reference leaks.
test_ssl leaked [1610, 1610] references, sum=3220
Added file: http://bugs.python.org/file8885/ssl_gc.patch
Changes by Christian Heimes:
Removed file: http://bugs.python.org/file8885/ssl_gc.patch
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1469
__
___
Python-bugs-list mailing list
Christian Heimes added the comment:
The new patch works and fixes the ref leak. I had to move the call
self._real_close() from __del__ to PySSL_dealloc(). I don't know if you
are going to like it. :]
Added file: http://bugs.python.org/file8886/ssl_gc.patch
Christian Heimes added the comment:
Guido van Rossum wrote:
I will look at this in an hour or so, after I bring Orlijn to school
and drive to work.
I found two problems with the _real_close() call in PySSL_dealloc. I'm
digging into it now.
o = PyObject_CallMethod((PyObject*)self-Socket
Christian Heimes added the comment:
Guido van Rossum wrote:
I just reverted it. I put a bit of debugging in the call to
_real_close(), and even with Christian's corrections it fails miserably.
I prefer leaking.
I agree! I've not enough time to work on the patch. A working patch
requires some
Changes by Christian Heimes:
--
keywords: +py3k
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1563
__
___
Python-bugs-list mailing list
Christian Heimes added the comment:
Can you create a patch that replaces Decimal with self.__class__ and the
string Decimal with %s ... % self.__class__.__name__?
Thanks :)
--
assignee: - facundobatista
nosy: +facundobatista, tiran
priority: - normal
type: - behavior
versions
Changes by Christian Heimes:
--
assignee: - tiran
components: +IDLE, Interpreter Core
type: - behavior
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1567
New submission from Christian Heimes:
The patch adds a new API method _PyImport_ImportModuleNoLock(const char
*name). It works mostly like PyImport_ImportModule except it does not
block. It tries to fetch the module from sys.modules first and falls
back to PyImport_ImportModule UNLESS the import
New submission from Christian Heimes:
The socket object is defined in socketmodule.h as
typedef struct {
PyObject_HEAD
SOCKET_T sock_fd; /* Socket file descriptor */
int sock_family;/* Address family, e.g., AF_INET */
int sock_type
Changes by Christian Heimes:
--
keywords: +patch, py3k
nosy: +tiran
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1568
__
___
Python-bugs-list
Christian Heimes added the comment:
uhm ... yeah, you are right.
I saw PyObject* and didn't though about the rest.
--
resolution: - invalid
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1566
New submission from Christian Heimes:
The 3.0a2 installer requires the user to install the VS CRT library
manually. 3.0a3 and 2.6a1 should automate the installation of vsredist
somehow.
--
components: Installation, Windows
keywords: py3k
messages: 58278
nosy: jorend, loewis, tiran
Christian Heimes added the comment:
Good idea! I've created a GHOP task and waiting for approval. I'll
shepherd the task.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1570
Christian Heimes added the comment:
I disabled test_404 in test_xmlrpc.py r59423
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1572
__
___
Python-bugs-list mailing list
New submission from Christian Heimes:
Reminder for me and myself
--
assignee: tiran
components: Interpreter Core
messages: 58279
nosy: tiran
priority: high
severity: normal
status: open
title: Backport sys.maxsize to Python 2.6
versions: Python 2.6
Changes by Christian Heimes:
--
assignee: - georg.brandl
keywords: +py3k
nosy: +georg.brandl
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1571
New submission from Christian Heimes:
Exception happened during processing of request from ('127.0.0.1', 55017)
Traceback (most recent call last):
File /home/heimes/dev/python/py3k/Lib/SocketServer.py, line 222, in
handle_request
self.process_request(request, client_address)
File /home
Christian Heimes added the comment:
Fixed in r59432
I've altered the assert(). It now checks if either kwonlyargs and
kwdefault or both not NULL or the next node is a DOUBLESTAR.
--
nosy: +tiran
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org
Changes by Christian Heimes:
--
resolution: - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1573
__
___
Python-bugs-list mailing list
Christian Heimes added the comment:
Why do you want to forbid
def f(*, **kw)
? It's useful and it also works in release builds of Python 3.0a2. It
only breaks in debug builds because the assert() gets triggered.
__
Tracker [EMAIL PROTECTED]
http
Christian Heimes added the comment:
Ah, you and Amaury are right! But I don't like Amaury's error message:
SyntaxError: no name for vararg
It doesn't explain what's wrong. How about
SyntaxError: keyword only arguments require at least one keyword
Christian Heimes added the comment:
Kirk McDonald has an even better error message for us:
SyntaxError: Cannot specify keyword only arguments without named arguments
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1573
Christian Heimes added the comment:
Here is another error message from Thomas Wouters 'named arguments must
follow bare *'
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1573
Christian Heimes added the comment:
I've created a patch that adds optimization for PyUnicode while keeping
the existing optimization for PyString. The patch moves the optimization
trick for PyObject_Hash() into a macro and adds an optimized
_PyUnicode_Eq() to unicodeobject.c
Changes by Christian Heimes:
--
resolution: - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1572
__
___
Python-bugs-list mailing list
Changes by Christian Heimes:
--
assignee: - ping
keywords: +patch
nosy: +ping
priority: - normal
versions: +Python 3.0
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1550
Christian Heimes added the comment:
No, I've fixed the three failing or blocking tests in r59429 and r59434.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1572
__
___
Python
Changes by Christian Heimes:
Removed file: http://bugs.python.org/file8896/py3k_optimize_set_unicode.patch
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1564
__
___
Python
Christian Heimes added the comment:
I'm fine with your patch. Can you commit it please?
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1573
__
___
Python-bugs-list mailing list
New submission from Christian Heimes:
I've written a rough draft for a post import hook as discussed on the
python 3000 mailing list. The implementation is far from perfect. It
requires more unit tests, a code review and reference count checks.
--
assignee: tiran
components: Interpreter
Christian Heimes added the comment:
Updates:
* Moved dictobject.c:unicode_eq() to unicodeobject.c:_PyUnicode_Eq()
* Added another optimization step to _PyUnicode_Eq(). The hash is
required later anyway and comparing two hashes is much faster than
memcmp-ing the unicode objects
Changes by Christian Heimes:
Removed file: http://bugs.python.org/file8899/py3k_optimize_set_unicode.patch
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1564
__
___
Python
Changes by Christian Heimes:
Added file: http://bugs.python.org/file8905/py3k_optimize_set_unicode3.patch
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1564
__
___
Python-bugs
Christian Heimes added the comment:
I've moved the result = PyImport_NotifyPostImport(result); inside the
protected block. It's now protected by the import lock. I've also added
the lock protection to the register function.
The notify method is now exposed through the imp module, too.
I've
Changes by Christian Heimes:
Removed file: http://bugs.python.org/file8900/py3k_post_import_hook.patch
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1576
__
___
Python-bugs
Christian Heimes added the comment:
The latest patch does *NOT* add new macros, functions or other stuff. I
simply replaced PyString_* with PyUnicode_* in setobject.c where
appropriate.
The only function I had to factor out is unicode_eq(). It's now in a new
file stringlib/eq.h which
Christian Heimes added the comment:
I've added wide char API variants of the get and put commands to msvcrt
in the trunk. I'm going to fix the problem with the new functions.
--
assignee: - tiran
keywords: +py3k
nosy: +tiran
priority: - normal
Christian Heimes added the comment:
I'm mentoring a task for GHOP which is going to fix the problem.
--
assignee: - tiran
priority: - normal
versions: +Python 3.0
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1322
Christian Heimes added the comment:
I've done as you said and committed the changes in r59449.
Next time I won't try to add optimizations without consulting you in the
first place. :] Thanks for your advice.
--
resolution: - fixed
status: open - closed
Christian Heimes added the comment:
Fixed in r59451
--
resolution: - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1578
__
___
Python-bugs
Christian Heimes added the comment:
The new patch fixes some ref leaks, corner cases and adds some new unit
tests. All unit tests are passing but I'm leaking lots of references in
the register function.
Added file: http://bugs.python.org/file8909/py3k_post_import_hook3.patch
Changes by Christian Heimes:
Removed file: http://bugs.python.org/file8906/py3k_post_import_hook2.patch
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1576
__
___
Python-bugs
Christian Heimes added the comment:
Applied in r59457
I had to add checks for _M_X64 and _M_IA64 to doubledigits.c. The rest
was fine on Windows.
--
resolution: - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1580
Changes by Christian Heimes:
--
type: - behavior
versions: +Python 2.6, Python 3.0
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1754489
_
___
Python-bugs-list
Christian Heimes added the comment:
UPDATES:
* no ref leaks
* PyModule_IsLazy(mod) checks mod.__lazy_import__ attribute (we can
argue about a nice name later)
* Added imp.is_lazy(mod_or_name)
Added file: http://bugs.python.org/file8914/py3k_post_import_hook4.patch
Christian Heimes added the comment:
Guido van Rossum wrote:
Guido van Rossum added the comment:
I wonder if Christian Heimes was correct that the ssl object needs GC
support? This was part of his patch (which I checked in and then
reverted because the other part of it didn't work
Christian Heimes added the comment:
I've disabled the new repr() in trunk and py3k until somebody has sorted
out the build problems. I've removed doubledigits.c from Makefile.in and
disabled the code with #ifdef Py_BROKEN_REPR in floatobject.c.
--
assignee: tiran -
keywords: +py3k
Changes by Christian Heimes:
--
versions: +Python 2.6
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1580
__
___
Python-bugs-list mailing list
Unsubscribe:
http
Christian Heimes added the comment:
I've written a small C program for auto config that checks the
endianness of IEEE doubles. Neil has promised to add something to
configure.in when I come up with a small C program. It *should* do the
right thing on a BE platform but I can't test it.
Tim, does
Christian Heimes added the comment:
Fixed in r59456
--
keywords: +py3k
nosy: +tiran
resolution: - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1585
Christian Heimes added the comment:
The problem is already fixed in svn. Can you download a svn checkout and
verify it that the code is working?
41848 skip.montanaro if (platform == 'darwin' and
--
nosy: +tiran
priority: - normal
resolution: - out of date
status: open
Christian Heimes added the comment:
It's really a shame. It was a nice idea ...
Could we at least use the new formating for str(float) and the display
of floats? In Python 2.6 floats are not displayed with repr(). They seem
to use yet another hook.
repr(11./5)
'2.2'
11./5
2.2002
Changes by Christian Heimes:
--
assignee: - loewis
nosy: +loewis
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1754489
_
___
Python-bugs-list mailing list
New submission from Christian Heimes:
The patch implements the instancemethod wrapper as discussed on the py3k
mailing list. The patch is roughly based on Marcin Kowalczyk patch but
it contains more fancy slots like repr, call etc. The rest is mostly
based on PyMethod_Type
Changes by Christian Heimes:
--
keywords: +py3k
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1586
__
___
Python-bugs-list mailing list
Christian Heimes added the comment:
Noam Raphael wrote:
* nan is an object of type float, which behaves like None, that is:
nan == nan is true, but nan nan and nan 3 will raise an
exception.
No, that's not correct. The standard defines that nan is always unequal
to nan.
False
float(inf
Christian Heimes added the comment:
I propose that we add three singletons to the float implementation:
PyFloat_NaN
PyFloat_Inf
PyFloat_NegInf
The singletons are returned from PyFloat_FromString() for nan, inf
and -inf. The other PyFloat_ method must return the singletons, too.
It's easy
Christian Heimes added the comment:
Guido van Rossum wrote:
(1a) Perhaps it's better to only do this for Python 3.0, which has a
smaller set of platforms to support.
+1
Does Python depend on a working, valid and non-broken IEEE 754 floating
point arithmetic? Could we state the Python's float
Christian Heimes added the comment:
Guido van Rossum wrote:
No, traditionally Python has just used whatever C's double provides.
There are some places that benefit from IEEE 754, but few that require
it (dunno about optional extension modules).
I asked Thomas Wouter about IEEE 754:
I
Christian Heimes added the comment:
The wrapper is useful for C code which used PyMethod_New(func, NULL,
type) in 2.5. W/o a wrapper people may have to rewrite and redesign
their code base.
For example see http://bugs.python.org/issue1505 and r59215. I had to
rewrite a good bunch of code just
Christian Heimes added the comment:
Applied in r59469
The PyInstanceMethod_Type is not exposed to Python programs.
--
resolution: - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1587
Christian Heimes added the comment:
Yes, 2.5 and 2.6 are affected, too. The scripts are install by setup.py
in sharedinstall.
--
nosy: +tiran
priority: - normal
versions: +Python 2.5, Python 2.6
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org
Christian Heimes added the comment:
Applied in r59470
Thanks for noticing the issue :)
--
keywords: +patch, py3k
nosy: +tiran
priority: - normal
resolution: - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1593
Christian Heimes added the comment:
Updates:
* Some minor cleanups
* First draft of lazy modules implemented in C. It works but it needs
some cleanup and more error checking.
--
keywords: +patch
title: First draft of a post import hook - [Patch] Working post import hook
and lazy
New submission from Christian Heimes:
A while ago I've experimented with the pyvm module and a semi
auto-generated types list. The patch adds a script that reads
Include/*.h and adds all available PyTypeObjects to Modules/_typesmodule.c.
The patch or script may be useful in the future
Christian Heimes added the comment:
We are aware of several Windows related bugs with IDLE. I assume they
are related to our Tcl/Tk build.
--
nosy: +tiran
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1601
New submission from Christian Heimes:
The subprocess docs need a warning that code like
p = subprocess.Popen(..., stdout=STDOUT)
p.wait()
p.stdout.read()
can block indefinitely if the program fills the stdout buffer. It needs
an example how to do it right but I don't know the best way to solve
Christian Heimes added the comment:
Guido van Rossum wrote:
But what about static type objects that nevertheless may be exposed to
Python (e.g. dict_keyview?).
I took care of the views a few weeks ago when I added all views and
iterators to the header files.
['PyCObject',
'bool
Christian Heimes added the comment:
Guido van Rossum wrote:
Why not simply reverse the wait() and read() calls?
I don't think it is sufficient if the user uses more than one pipe. The
subprocess.communicate() and _communicate() methods are using threads
(Windows) or select (Unix) when multiple
New submission from Christian Heimes:
I've tested Tcl 8.5b3, Tk 8.5b3 and Tix 8.4.2 on Windows. IDLE
complained at multiple places that it could not add a Tcl_Obj to a
string (index + ...) or convert it to a float int(float(index)).
Therefor I added an __add__ and __float__ number slot to the C
New submission from Christian Heimes:
Makefile has a feature called VPATH that is often used for cross
platform compilation or the creation of a different flavor.
Example:
$ cd py3k
$ mkdir debug
$ cd debug
$ ../configure --with-pydebug
$ make
...
gcc -pthread -c -fno-strict-aliasing -g -Wall
Christian Heimes added the comment:
You are right! :) A make clean in the root of my local workspace solved
the problem but revealed another problem:
$ make
running build
running build_ext
building '_struct' extension
gcc -pthread -fPIC -fno-strict-aliasing -g -Wall -Wstrict-prototypes -I.
-I
Christian Heimes added the comment:
Guido van Rossum wrote:
Do you need more help at this point?
No, I'm fine. I've a working solution for the problem. :)
Christian
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1613
Christian Heimes added the comment:
Fixed in r59482
I've updated the README and changed distutils slightly. Distutils was
using Modules/Setup.dist to detect an uninstalled Python. However
Setup.dist is only available in the srcdir and not in the VPATH dir.
I've changed it to Setup.local
Christian Heimes added the comment:
Guido van Rossum wrote:
That is done precisely to *avoid* blocking. I believe the only reason
your example blocks is because you wait before reading -- you should
do it the other way around, do all I/O first and *then* wait for the
process to exit.
I
Christian Heimes added the comment:
It hangs on my Linux box, too. I've not yet tried on Windows.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1469
__
___
Python-bugs-list
Christian Heimes added the comment:
What's wrong with the locale module?
--
nosy: +tiran
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1618
__
___
Python-bugs-list
Christian Heimes added the comment:
Please contact Brett Cannon. He organized the stdlib cleanup.
--
assignee: - brett.cannon
nosy: +brett.cannon, tiran
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1333
Christian Heimes added the comment:
My gcc 4.1 doesn't have the -Wstrict-overflow option.
gcc-Version 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2)
--
nosy: +tiran
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1621
Christian Heimes added the comment:
Fixed in r59488
--
resolution: - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1620
__
___
Python-bugs
Christian Heimes added the comment:
Should we use -ansi (C90 aka C89 standard) option, too? Python core
compiles fine with -ansi but together with -Werror it breaks several
extensions:
_bsddb_codecs_iso2022 _ctypes
_socket _ssl linuxaudiodev
Christian Heimes added the comment:
Socket and SSL are using bluetooth.h which defines some functionas as
inline. Inline isn't part of C89. Linuxaudiodev depends on the 'linux'
macro which is not defined in C89.
The Python core can be compiled with -ansi but the extension modules
require -std
Changes by Christian Heimes:
--
assignee: - facundobatista
keywords: +patch, py3k
nosy: +facundobatista
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1623
Christian Heimes added the comment:
I think it would be easier to merge from trunk to py3k before the change
and skip the revision in the next merge. The rename can be done with a
simple find | xargs sed -i. A merge might be more painful.
--
nosy: +tiran
Christian Heimes added the comment:
Thanks for the bug report
I fixed the problem in r59518
--
keywords: +py3k
nosy: +tiran
resolution: - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1630
Christian Heimes added the comment:
It's not going to be easy and there is also no point to implement the
feature. The subprocess module requires either a real file or a PIPE. A
real file is needed because the subprocess module uses some low level
operation system functions for speed efficiency
Christian Heimes added the comment:
Plans is exaggerated. I was merely testing Tcl 8.5. The Python 3.0a2
release has some major problems with Tcl. The Win32 version doesn't work
well and I wasn't able to create a 64bit version. Do you have a Windows
box to test IDLE on Windows? You can use
Christian Heimes added the comment:
We are aware of multiple Windows related problems. We are planing to
rewrite parts of the Windows specific API to use the widechar variants.
Maybe that will help.
--
keywords: +py3k
nosy: +tiran
priority: - low
401 - 500 of 6455 matches
Mail list logo