Claudiu Popa added the comment:
I'm adding another example here, where the lineno reporting is wrong:
from ast import parse
n = parse('''
def test():
return f"{a}"
''')
f = n.body[0].body[0].value.values[0]
n = f.value
print(&
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue12516>
___
___
Python-bug
Claudiu Popa added the comment:
imghdr got a test file in 94813eab5a58. Your patch also needs documentation
updates. Besides that, +1 from me. Maybe it would be okay to add a deprecation
warning for the second argument?
--
___
Python tracker
<h
Claudiu Popa added the comment:
Issue issue16512 has a patch which will recognize this format of JPEG, as well
as others.
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue21
Claudiu Popa added the comment:
Antoine, how does my latest patch look?
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue19776>
___
_
Changes by Claudiu Popa :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue15795>
___
___
Python-bugs-list mailing list
Unsubscrib
Claudiu Popa added the comment:
Hi. Would you like to provide a patch?
--
keywords: +easy
nosy: +Claudiu.Popa
stage: -> needs patch
type: -> enhancement
versions: +Python 3.5 -Python 3.4
___
Python tracker
<http://bugs.python.org/i
Changes by Claudiu Popa :
--
dependencies: +Expose RegUnloadKey in winreg
___
Python tracker
<http://bugs.python.org/issue8579>
___
___
Python-bugs-list mailin
Claudiu Popa added the comment:
Attached a new version of the patch which cleanups properly after tests.
--
Added file: http://bugs.python.org/file35618/issue21518_2.patch
___
Python tracker
<http://bugs.python.org/issue21
Claudiu Popa added the comment:
Hi. This was already fixed in c2f1bb56760d. I'm sorry that this patch didn't
make it through.
--
nosy: +Claudiu.Popa
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Claudiu Popa added the comment:
This was fixed in the latest versions.
>>> b = bytearray(b'457')
>>> b[:1] = 4
Traceback (most recent call last):
File "", line 1, in
TypeError: can assign only bytes, buffers, or iterables of ints in range(0, 25
Claudiu Popa added the comment:
This seems to be a reasonable fix. Michael, could you have a look at this
patch, please?
--
nosy: +Claudiu.Popa
versions: +Python 3.5 -Python 3.2, Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.
Claudiu Popa added the comment:
Looks good to me. But aren't the last two lines skipped if an error is raised
by the first line from the with block?
+with self.assertRaises(FileNotFoundError):
+shutil.chown('invalid-file', user=uid, dir_fd=dirfd)
+
Claudiu Popa added the comment:
I believe that returning a TypeError instead of a ValueError is better in this
situation. Technically, passing 'a' as maxlen makes that value inappropiate,
thus the use of TypeError. It will also be backward compatible. Also, your
patch needs te
Changes by Claudiu Popa :
--
stage: needs patch -> patch review
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/issue19898>
___
___
Python-
Claudiu Popa added the comment:
Hi. You have some trailing whitespaces in the test file (run make patchcheck or
python ../Tools/scripts/patchcheck.py). Except that, looks good to me.
--
nosy: +Claudiu.Popa
stage: -> patch review
versions: +Python 3.5 -Python
Claudiu Popa added the comment:
Hi, I left a couple of comments on rietveld.
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue20069>
___
___
New submission from Claudiu Popa:
There's no 'o' in test_pydoc.TestDescriptions.test_builtin, but 'name'.
--
components: Tests
files: test_pydoc_nameerror.patch
keywords: patch
messages: 220618
nosy: Claudiu.Popa
priority: normal
severity: normal
status: open
New submission from Claudiu Popa:
Hi. Here's a patch which uses `self.fail` in test_descr instead of `raise
TestFailed`.
--
components: Tests
files: test_descr_nameerror.patch
keywords: patch
messages: 220619
nosy: Claudiu.Popa
priority: normal
severity: normal
status: open
title
New submission from Claudiu Popa:
Using make_zip_pkg from script_helper with compiled=True will lead to the
following failure:
Traceback (most recent call last):
File "D:\Projects\cpython\lib\test\test_cmd_line_script.py", line 305, in
test_module_in_subpackage_in_zipfile
New submission from Claudiu Popa:
There's a bug in test_enum.TestStdLib.test_pydoc, print_diffs is undefined and
using assertEqual seems to be clearer.
--
components: Tests
files: test_enum.patch
keywords: patch
messages: 220669
nosy: Claudiu.Popa, ethan.furman
priority: n
Changes by Claudiu Popa :
--
stage: test needed -> patch review
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/issue19714>
___
___
Python-
Claudiu Popa added the comment:
Attached a new version of the patch. The previous one called find_spec twice in
the same test.
--
Added file: http://bugs.python.org/file35651/issue19714_2.patch
___
Python tracker
<http://bugs.python.org/issue19
New submission from Claudiu Popa:
Hi. This patch fixes a NameError found in xml.dom.minidom. Here's an example
for reproducing it:
from xml.dom import minidom
dom = minidom.parseString("1")
pi = dom.createProcessingInstruction('xml-stylesheet',
Claudiu Popa added the comment:
My pleasure. I run Pylint from time to time over stdlib in order to find false
positives for Pylint and in the process I stumble across these type of bugs.
--
___
Python tracker
<http://bugs.python.org/issue21
New submission from Claudiu Popa:
Hi. Currently, distutils.command.upload has this code:
try:
result = urlopen(request)
status = result.getcode()
reason = result.msg
except OSError as e:
self.announce(str(e), log.ERROR)
return
except HTTPError as e:
status = e.code
Changes by Claudiu Popa :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue19628>
___
___
Python-bugs-list mailing list
Unsubscrib
Claudiu Popa added the comment:
Attached the new version of the patch with fixes according to Antoine's review.
--
Added file: http://bugs.python.org/file35666/issue19776_1.patch
___
Python tracker
<http://bugs.python.org/is
Changes by Claudiu Popa :
--
title: Use self.assertEqual in test_pydoc -> Use assertEqual in test_pydoc
___
Python tracker
<http://bugs.python.org/issu
New submission from Claudiu Popa:
Hello. Here's a patch which uses self.assertEqual in various places across
test_pydoc, instead of the current idiom:
if result != expected_text:
print_diffs(expected_text, result)
self.fail("outputs are not equal, see diff above")
--
Changes by Claudiu Popa :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue15582>
___
___
Python-bugs-list mailing list
Un
Changes by Claudiu Popa :
--
stage: test needed -> patch review
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue7769>
___
_
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue7769>
___
___
Python-bugs-list mailing list
Unsubscribe:
Claudiu Popa added the comment:
resource module is available only on Unix.
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue21790>
___
___
New submission from Claudiu Popa:
Hello. I noticed the following behaviour while working with xmlrpc proxy
methods.
>>> import inspect, xmlrpc.client
>>> proxy = xmlrpc.client.ServerProxy('http://localhost:8000')
>>> proxy.mul
>>> inspect.sig
Claudiu Popa added the comment:
os.chown is not available on Windows. But maybe pwd can't be built on any Unix
system, so not using import_module is okay.
"=> I can not because assertRaisesRegex can not be used with "with" statement."
Not true (see
https
Claudiu Popa added the comment:
Here's an updated patch with a small exr test file.
--
Added file: http://bugs.python.org/file35692/issue20295.patch
___
Python tracker
<http://bugs.python.org/is
Claudiu Popa added the comment:
I think you can skip the entire test class if os.chown is not available. Also,
maybe you can move the obtaining of groups and users in setUpClass?
Also, in
+with self.assertRaises(PermissionError) as cx:
+os.chown(support.TESTFN, uid_1, gid
Changes by Claudiu Popa :
--
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue20069>
___
___
Python-bugs-list mailing list
Unsub
Claudiu Popa added the comment:
How about using this?
diff -r 1e74350dd056 Lib/doctest.py
--- a/Lib/doctest.pyTue Jun 17 22:27:46 2014 -0500
+++ b/Lib/doctest.pyFri Jun 20 11:08:00 2014 +0300
@@ -984,7 +984,8 @@
for valname, val in obj.__dict__.items
Claudiu Popa added the comment:
Through a checker program. I ran pylint from time to time to detect crashes and
other stuff and I stumble across these bugs.
--
___
Python tracker
<http://bugs.python.org/issue21
Claudiu Popa added the comment:
Your patch looks good to me.
--
___
Python tracker
<http://bugs.python.org/issue21801>
___
___
Python-bugs-list mailing list
Unsub
Claudiu Popa added the comment:
Hello. Here's a patch based on c4f92b597074, which adds something similar to
multiprocessing.pool.
The output after the patch is:
concurrent.futures.process.RemoteTraceback:
"""
Traceback (most recent call last):
File "D:\Projec
Changes by Claudiu Popa :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue21527>
___
___
Python-bugs-list mailing list
Unsubscrib
Claudiu Popa added the comment:
The problem is that the repr of the underlying db is not very helpful either,
as seen for the dbm backend.
>>> import dbm
>>> dbm.open("test", "c")
>>> f=_
>>> f[b"2"] = b"a"
>>
New submission from Claudiu Popa:
There's a problem with ctypes.test.test_values on Windows.
First, the test is wrong because it uses the following:
if __debug__:
self.assertEqual(opt, 0)
elif ValuesTestCase.__doc__ is not None:
self.assertEqual(opt, 1)
ValuesTestCase doesn
Changes by Claudiu Popa :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue21829>
___
___
Python-bugs-list mailing list
Unsubscribe:
Claudiu Popa added the comment:
Fair point, Serhiy. But I see the shelve more similar to a persistent,
dictionary-like object, than to a file. The fact that it uses some database
behind is just an implementation detail.
--
___
Python tracker
<h
Claudiu Popa added the comment:
Alright, I agree with you now. You can close the issue if you want.
--
___
Python tracker
<http://bugs.python.org/issue21
Claudiu Popa added the comment:
It would be nice if this could be committed. It's cumbersome to always have to
deactivate the AV solution when running the tests on Windows, in order to avoid
a failure of test_httpservers.
--
___
Python tr
Claudiu Popa added the comment:
Mark, why not contributing a patch? Seems pretty straight forward to write it.
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue12
Claudiu Popa added the comment:
Why the need of "as _" in the with statement? I don't understand it. Otherwise,
looks good to me.
--
___
Python tracker
<http://bugs.pyt
Claudiu Popa added the comment:
There's a small typo in your patch, strign instead of string. Otherwise, looks
good to me.
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org
Claudiu Popa added the comment:
This seems commit ready.
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue20295>
___
_
Claudiu Popa added the comment:
It seems commit ready.
--
nosy: +Claudiu.Popa
stage: patch review -> commit review
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/issu
Changes by Claudiu Popa :
--
stage: -> commit review
title: Inconsitent behaviour between BytesParser.parse and Parser.parse ->
Inconsistent behaviour between BytesParser.parse and Parser.parse
___
Python tracker
<http://bugs.python.org/i
Changes by Claudiu Popa :
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue20295>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Claudiu Popa :
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue17442>
___
___
Python-bugs-list mailing list
Unsubscribe:
Claudiu Popa added the comment:
I would go on the deprecation route with this and removing it in 3.6, just like
the formatter module.
--
___
Python tracker
<http://bugs.python.org/issue19
Claudiu Popa added the comment:
Looks good to me.
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue20069>
___
___
Python-
Changes by Claudiu Popa :
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue19628>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Claudiu Popa :
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue21151>
___
___
Python-bugs-list mai
Claudiu Popa added the comment:
Łukasz, do you have some time to take a look at this patch?
--
type: -> behavior
versions: +Python 3.5
Added file: http://bugs.python.org/file35791/issue19546_1.patch
___
Python tracker
<http://bugs.pyth
Claudiu Popa added the comment:
I got a failure on FreeBSD:
[1/1] test_shutil
test test_shutil failed -- Traceback (most recent call last):
File "/tank/libs/cpython/Lib/test/test_shutil.py", line 1258, in test_chown
shutil.chown(os.path.basename(filename), dir_fd=dirfd)
File &
Changes by Claudiu Popa :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue10312>
___
___
Claudiu Popa added the comment:
It's still in Python 2, though.
--
nosy: +Claudiu.Popa
resolution: out of date ->
stage: resolved ->
status: closed -> open
versions: -Python 3.1, Python 3.2
___
Python tracker
<http://bugs.pyth
Changes by Claudiu Popa :
--
stage: needs patch -> patch review
versions: +Python 3.5 -Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issu
Claudiu Popa added the comment:
issue10513 has a patch that fixes this problem as well.
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue20
Claudiu Popa added the comment:
It seems that this was actual the case for Python 3.2 and 3.3, but fixed in
3.4. Unfortunately, it's too late now to add those fields back, since 3.2 and
3.3 receives only security updates. So I guess this issue can be closed.
--
resolution: ->
Claudiu Popa added the comment:
Terry is right, this patch doesn't completely work. But with this fix the
problem is solved:
diff -r 394e6bda5a70 Lib/test/test_httpservers.py
--- a/Lib/test/test_httpservers.py Sun Jun 29 15:56:21 2014 +0300
+++ b/Lib/test/test_httpservers.py Su
Claudiu Popa added the comment:
Although it is incorrect, because the test specifically tests case sensitivity.
--
___
Python tracker
<http://bugs.python.org/issue20
Claudiu Popa added the comment:
It works with 'custom'.
--
___
Python tracker
<http://bugs.python.org/issue20155>
___
___
Python-bugs-list mailing
Claudiu Popa added the comment:
Well, for instance, my use cases with InteractiveInterpreter are for debugging
or creating custom interpreters for various apps and in those cases the patch
helps, by giving better debugging clues through the exception cause. I agree
that this was overlooked
Claudiu Popa added the comment:
Also, solving this issue seems to be, partially, a prerequisite for issue14805.
--
___
Python tracker
<http://bugs.python.org/issue17
Claudiu Popa added the comment:
Hi, I left a couple of comments on Rietveld.
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue10342>
___
___
Claudiu Popa added the comment:
The same should be done for _pyio?
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue21861>
___
___
Python-bug
Changes by Claudiu Popa :
--
stage: needs patch -> commit review
versions: +Python 3.5 -Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/iss
Changes by Claudiu Popa :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue20069>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Claudiu Popa :
--
nosy: +steve.dower, zach.ware
priority: normal -> high
___
Python tracker
<http://bugs.python.org/issue21151>
___
___
Python-
Claudiu Popa added the comment:
Here's a test patch which uses inspect.unwrap. Unfortunately, I can't test with
numba, so I don't know if it works for that, but any decorated function which
uses `functools.update_wrapper` or `wraps` should be detected by doctest.
--
k
Claudiu Popa added the comment:
Any type of feedback will be appreciated.
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issu
Claudiu Popa added the comment:
Sure, that sounds good.
--
___
Python tracker
<http://bugs.python.org/issue21518>
___
___
Python-bugs-list mailing list
Unsub
Claudiu Popa added the comment:
Here's the patch with only the change for winreg.UnloadKey. I'll have the patch
with windows_helper soon.
--
Added file: http://bugs.python.org/file35907/winreg_unload_key.patch
___
Python trac
Claudiu Popa added the comment:
Hi, thanks for the report. Here's a patch which implements __setstate__ and
__getstate__ for Row objects.
--
keywords: +patch
nosy: +Claudiu.Popa, ghaering
stage: -> patch review
versions: +Python 3.5 -Python 3.3
Added file: http://bugs.py
Claudiu Popa added the comment:
Using your example, I can't make it to crash using the tip, nor with Python 3.4.
--
___
Python tracker
<http://bugs.python.org/is
Claudiu Popa added the comment:
Nevermind, I didn't see the len call.
--
___
Python tracker
<http://bugs.python.org/issue21975>
___
___
Python-bugs-list m
Claudiu Popa added the comment:
It doesn't crash anymore with your patch, but the pickle.load fails:
Traceback (most recent call last):
File "a.py", line 19, in
load = pickle.loads(dump)
TypeError: function takes exactly 2 arguments (0 given)
--
stag
Claudiu Popa added the comment:
Ups, I accidentally removed the patch review stage, sorry for that.
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issu
Claudiu Popa added the comment:
Since all the comments have been addressed, it would be nice if this gets
committed.
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issu
Claudiu Popa added the comment:
Serhiy, if there's no actual gain in changing this, should we close the issue?
--
___
Python tracker
<http://bugs.python.org/is
Claudiu Popa added the comment:
This new patch fixes some comments from Serhiy. Thanks for the review!
--
stage: commit review -> patch review
Added file: http://bugs.python.org/file35955/issue19776_2.patch
___
Python tracker
<http://bugs.pyth
Claudiu Popa added the comment:
Thanks, Serhiy, for the review. Here's the updated version.
--
Added file: http://bugs.python.org/file35956/issue18615.patch
___
Python tracker
<http://bugs.python.org/is
Claudiu Popa added the comment:
Here's a new version. It adds versionchanged directive for 'whathdr' and
'what'. Serhiy, I hope that now I got right the documentation of the return
type. I didn't understand at first what was wrong.
--
Added file: ht
Claudiu Popa added the comment:
It works in IDLE because it registers a custom pickling for code objects, in
idlelib.rpc:
copyreg.pickle(types.CodeType, pickle_code, unpickle_code)
where pickle_code / unpickle_code calls marshal.dumps/loads.
Although, I admit that this is weird. If
Claudiu Popa added the comment:
Maybe something like the attached patch. It doesn't have tests, though, I
didn't find any tests for the idlelib.rpc anyway.
--
keywords: +patch
Added file: http://bugs.python.org/file35968/idlelib.patch
Claudiu Popa added the comment:
Thanks, Serhiy.
--
Added file: http://bugs.python.org/file35969/issue21986.patch
___
Python tracker
<http://bugs.python.org/issue21
Claudiu Popa added the comment:
TypeError is raised only in Python 2, in Python 3 it's PicklingError.
--
___
Python tracker
<http://bugs.python.org/is
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue21992>
___
___
Python-bugs-list mailing list
Unsubscribe:
Claudiu Popa added the comment:
No, my home directory is actually /root. The attached patch should be clearer
now (I hope). Regarding your question, wouldn't checking for this duplicate
what os.path.expanduser already does? (Unless checking for the exact same
string before returni
Claudiu Popa added the comment:
This seems indeed like a weaker version of ThreadPoolExecutor. Here's how your
example looks with it, not very different and still easy to understand and
grasp:
from concurrent.futures import ThreadPoolExecutor
from urllib.request import urlretrieve
1 - 100 of 217 matches
Mail list logo
