[issue17457] Unittest discover fails with namespace packages and builtin modules

2013-07-09 Thread Claudiu.Popa
Claudiu.Popa added the comment: Hello. Can I do something to move this issue forward? -- ___ Python tracker <http://bugs.python.org/issue17457> ___ ___ Python-bug

[issue17818] aifc.Aifc_read/Aifc_write.getparams can return a namedtuple

2013-07-25 Thread Claudiu.Popa
Claudiu.Popa added the comment: Here's the new patch. Also, I noticed a test failing when running ./python -m test, pyclbr, complaining about _Aifc_params not present in some dict, but I don't really know how to fix it.. -- Added file: http://bugs.python.org/file31034/ai

[issue17818] aifc.Aifc_read/Aifc_write.getparams can return a namedtuple

2013-07-25 Thread Claudiu.Popa
Claudiu.Popa added the comment: Here's the new modifications. -- Added file: http://bugs.python.org/file31036/aifc_5.patch ___ Python tracker <http://bugs.python.org/is

[issue18615] sndhdr.whathdr could return a namedtuple

2013-08-01 Thread Claudiu.Popa
New submission from Claudiu.Popa: Both sndhdr.whathdr an sndhdr.what returns a tuple with various information, while it could return a namedtuple. I attached a patched for this, with tests as well. -- components: Library (Lib) files: sndhdr.patch keywords: patch messages: 194080 nosy

[issue8112] xmlrpc.server: ServerHTMLDoc.docroutine uses (since 3.0) deprecated function "inspect.getargspec()"

2013-08-09 Thread Claudiu.Popa
Claudiu.Popa added the comment: Here's a patch with tests attached. -- keywords: +patch nosy: +Claudiu.Popa versions: +Python 3.4 -Python 3.1 Added file: http://bugs.python.org/file31210/xmlrpc.patch ___ Python tracker <http://bugs.py

[issue17087] Improve the repr for regular expression match objects

2013-08-20 Thread Claudiu.Popa
Claudiu.Popa added the comment: Here's my patch attempt. The repr of a match object has the following format: (groups=\d+, span=(start, end), group0=the entire group or the first X characters, where X is represented by a new constant in sre_constants.h, SRE_MATCH_REPR

[issue14971] (unittest) loadTestsFromName does not work on method with a decorator

2013-08-20 Thread Claudiu.Popa
Claudiu.Popa added the comment: The patch for Python 2.7 is pretty similar with the one provided for Python 3. -- nosy: +Claudiu.Popa Added file: http://bugs.python.org/file31386/unittest_method_name_difference_27.patch ___ Python tracker <h

[issue17442] code.InteractiveInterpreter doesn't display the exception cause

2013-08-20 Thread Claudiu.Popa
Claudiu.Popa added the comment: Here's an updated patch for the stdlib, with adapted tests. -- keywords: +patch nosy: +Claudiu.Popa Added file: http://bugs.python.org/file31388/code.patch ___ Python tracker <http://bugs.python.org/is

[issue17916] Provide dis.Bytecode based equivalent of dis.distb

2013-08-21 Thread Claudiu.Popa
Claudiu.Popa added the comment: Here's a basic patch, using a classmethod. It doesn't support the full distb API (if the traceback is not given, try to retrieve the last one), because Bytecode.from_tb() looks pretty weird. -- keywords: +patch nosy: +Claudiu.Popa Added

[issue13397] Option for XMLRPC clients to automatically transform Fault exceptions into standard exceptions

2013-08-25 Thread Claudiu.Popa
Claudiu.Popa added the comment: Here's a basic patch. I have two issues with it: the flag name used for enabling the exceptions seems too verbose (use_python_exceptions, I'm opened to new suggestions) and I don't know if the fallback to Fault exception if the remote exception

[issue18901] sunau.getparams should return a namedtuple

2013-09-01 Thread Claudiu.Popa
New submission from Claudiu.Popa: This is similar to what was done for issue17818 and issue17487 and will gain for all the three audio libraries, aifc, wave and sunau a similar API. Patch and tests attached. -- components: Library (Lib) files: sunau.patch keywords: patch messages

[issue18919] Unify audio modules tests

2013-09-04 Thread Claudiu.Popa
Claudiu.Popa added the comment: I love this idea! I was thinking while working on sunau/aifc/wave patches that we can do more than this, unify the entire audio modules, getting rid of Aifc_write/read and Wave_write/read was in fact my first desire. One way that I thought about was to provide

[issue18615] sndhdr.whathdr could return a namedtuple

2013-09-04 Thread Claudiu.Popa
Changes by Claudiu.Popa : -- nosy: +serhiy.storchaka ___ Python tracker <http://bugs.python.org/issue18615> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18821] Add .lastitem attribute to takewhile instances

2013-09-07 Thread Claudiu.Popa
Claudiu.Popa added the comment: Hello. Here's a basic patch with tests which accomplishes your request. Currently, it defaults to None if no item failed, but probably it can be set only when something fails the predicate (and the user will check using hasattr(t,

[issue16104] Use multiprocessing in compileall script

2014-03-13 Thread Claudiu.Popa
Claudiu.Popa added the comment: Here's a new patch which addresses Éric's last comments. Antoine, I don't have at my disposal a system without multiprocessing support. How does it crash? -- Added file: http://bugs.python.org/file34400/iss

[issue16104] Use multiprocessing in compileall script

2014-03-13 Thread Claudiu.Popa
Claudiu.Popa added the comment: Here's a new version which catches ImportError for concurrent.futures and raises ValueError in `compile_dir` if `processes` was specified and concurrent.futures is unavailable. The only issue is that I don't know if this should be a ValueError o

[issue16104] Use multiprocessing in compileall script

2014-03-13 Thread Claudiu.Popa
Changes by Claudiu.Popa : Added file: http://bugs.python.org/file34404/issue16104_7.patch ___ Python tracker <http://bugs.python.org/issue16104> ___ ___ Python-bugs-list m

[issue17442] code.InteractiveInterpreter doesn't display the exception cause

2014-03-16 Thread Claudiu.Popa
Changes by Claudiu.Popa : Added file: http://bugs.python.org/file34443/issue17442_1.patch ___ Python tracker <http://bugs.python.org/issue17442> ___ ___ Python-bugs-list m

[issue15582] Enhance inspect.getdoc to follow inheritance chains

2014-03-16 Thread Claudiu.Popa
Changes by Claudiu.Popa : Added file: http://bugs.python.org/file34445/issue15582.patch ___ Python tracker <http://bugs.python.org/issue15582> ___ ___ Python-bugs-list m

[issue19840] The is no way to tell shutil.move to ignore metadata

2014-03-16 Thread Claudiu.Popa
Changes by Claudiu.Popa : Added file: http://bugs.python.org/file34447/issue19840.patch ___ Python tracker <http://bugs.python.org/issue19840> ___ ___ Python-bugs-list m

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

2014-03-17 Thread Claudiu.Popa
Claudiu.Popa added the comment: Now that the 3.5 branch is the default, can this feature be committed? -- ___ Python tracker <http://bugs.python.org/issue20

[issue19385] dbm.dumb should be consistent when the database is closed

2014-03-17 Thread Claudiu.Popa
Claudiu.Popa added the comment: Can this patch be committed, now that 3.5 is active? -- ___ Python tracker <http://bugs.python.org/issue19385> ___ ___ Python-bug

[issue10203] sqlite3.Row doesn't support sequence protocol

2014-03-17 Thread Claudiu.Popa
Claudiu.Popa added the comment: What can be done to move this forward? -- ___ Python tracker <http://bugs.python.org/issue10203> ___ ___ Python-bugs-list mailin

[issue18615] sndhdr.whathdr could return a namedtuple

2014-03-17 Thread Claudiu.Popa
Changes by Claudiu.Popa : -- versions: +Python 3.5 -Python 3.4 ___ Python tracker <http://bugs.python.org/issue18615> ___ ___ Python-bugs-list mailing list Unsub

[issue20897] @abstractmethod does not enforce method signatures

2014-03-18 Thread Claudiu.Popa
Claudiu.Popa added the comment: Hello. In 3.3 you can instantiate META class, because it does not properly say that it wants abc.ABCMeta as a metaclass. For this, you have to write your class as such: class META(metaclass=abc.ABCMeta): @abc.abstractmethod def _junk(self

[issue20375] ElementTree: Document handling processing instructions

2014-03-19 Thread Claudiu.Popa
Claudiu.Popa added the comment: Hello. I left a couple of comments on Rietveld. -- nosy: +Claudiu.Popa ___ Python tracker <http://bugs.python.org/issue20

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-03-21 Thread Claudiu.Popa
Claudiu.Popa added the comment: Hello. Here's a patch for this issue. It tests only the conditions described by Eric. -- keywords: +patch nosy: +Claudiu.Popa Added file: http://bugs.python.org/file34549/issue19714.patch ___ Python tracker

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

2014-03-21 Thread Claudiu.Popa
Claudiu.Popa added the comment: My pleasure! -- ___ Python tracker <http://bugs.python.org/issue20627> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21010] asyncio doc typo

2014-03-21 Thread Claudiu.Popa
New submission from Claudiu.Popa: There is an invalid item "meth:`resume_reading`". -- assignee: docs@python components: Documentation files: asyncio_doc_fix.patch keywords: patch messages: 214381 nosy: Claudiu.Popa, docs@python priority: normal severity: normal status:

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-03-21 Thread Claudiu.Popa
Changes by Claudiu.Popa : Added file: http://bugs.python.org/file34553/issue19714.patch ___ Python tracker <http://bugs.python.org/issue19714> ___ ___ Python-bugs-list m

[issue16104] Use multiprocessing in compileall script

2014-03-22 Thread Claudiu.Popa
Claudiu.Popa added the comment: What can I do to move this forward? I believe all concerns have been addressed and it seems ready to me. -- ___ Python tracker <http://bugs.python.org/issue16

[issue19714] Add tests for importlib.machinery.WindowsRegistryFinder

2014-03-22 Thread Claudiu.Popa
Changes by Claudiu.Popa : Added file: http://bugs.python.org/file34570/issue19714.patch ___ Python tracker <http://bugs.python.org/issue19714> ___ ___ Python-bugs-list m

[issue21027] difflib new cli interface

2014-03-22 Thread Claudiu.Popa
New submission from Claudiu.Popa: Hello! The attached patch proposes a new command line interface to difflib module. Currently, `python -m difflib` does nothing useful, it runs the doc suite for the difflib module. Right now, there are a couple of modules in the standard lib, which provides

[issue21027] difflib new cli interface

2014-03-22 Thread Claudiu.Popa
Changes by Claudiu.Popa : Added file: http://bugs.python.org/file34572/difflib_cli.patch ___ Python tracker <http://bugs.python.org/issue21027> ___ ___ Python-bugs-list m

[issue21027] difflib new cli interface

2014-03-22 Thread Claudiu.Popa
Claudiu.Popa added the comment: Here's a new patch which addresses the comments of berker.peksag. Thank you for the review! -- Added file: http://bugs.python.org/file34573/issue21027.patch ___ Python tracker <http://bugs.python.org/is

[issue21090] File read silently stops after EIO I/O error

2014-03-29 Thread Claudiu.Popa
Changes by Claudiu.Popa : -- nosy: +Claudiu.Popa ___ Python tracker <http://bugs.python.org/issue21090> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19546] configparser leaks implementation detail

2014-04-01 Thread Claudiu.Popa
Claudiu.Popa added the comment: But the last traceback conveys enough information, the user can see immediately that the given section does not exist. My problem with the current behaviour is that the first error distracts the user, while the actual problem is the second traceback. But I have

[issue21159] configparser.InterpolationMissingOptionError is not very intuitive

2014-04-05 Thread Claudiu.Popa
New submission from Claudiu.Popa: The error message from the title is not very intuitive from a user point of view. For instance, in the following traceback, only the first one gives a meaning to this error, through the leaked KeyError, thus the user knows that home_dir1 is invalid and

[issue19546] configparser leaks implementation detail

2014-04-05 Thread Claudiu.Popa
Claudiu.Popa added the comment: I've created a new issue for the InterpolationMissingOptionError message, issue21159. This issue can be closed. -- resolution: -> 3rd party ___ Python tracker <http://bugs.python.org

[issue19546] configparser leaks implementation detail

2014-04-05 Thread Claudiu.Popa
Claudiu.Popa added the comment: Ups, sorry for the change of resolution. -- resolution: 3rd party -> ___ Python tracker <http://bugs.python.org/issu

[issue15582] Enhance inspect.getdoc to follow inheritance chains

2014-04-05 Thread Claudiu.Popa
Claudiu.Popa added the comment: Yury, Nick, how is my latest patch? -- Added file: http://bugs.python.org/file34733/issue15582_1.patch ___ Python tracker <http://bugs.python.org/issue15

[issue19628] maxlevels -1 on compileall for unlimited recursion

2014-04-10 Thread Claudiu.Popa
Claudiu.Popa added the comment: Ping. :) Can someone review this patch, please? -- ___ Python tracker <http://bugs.python.org/issue19628> ___ ___ Python-bug

[issue19628] maxlevels -1 on compileall for unlimited recursion

2014-04-11 Thread Claudiu.Popa
Claudiu.Popa added the comment: Added patch which addresses the comments of Berker Peksag. Thanks for the review! -- Added file: http://bugs.python.org/file34786/issue19628_1.patch ___ Python tracker <http://bugs.python.org/issue19

[issue19546] configparser leaks implementation detail

2014-04-14 Thread Claudiu.Popa
Claudiu.Popa added the comment: If there is anything left to do for this patch, please tell me. -- Added file: http://bugs.python.org/file34837/issue19546.patch ___ Python tracker <http://bugs.python.org/issue19

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

2014-04-15 Thread Claudiu.Popa
Claudiu.Popa added the comment: Hi. I added a couple of comments for your previous patch, the new one doesn't seem to have a review link. -- nosy: +Claudiu.Popa ___ Python tracker <http://bugs.python.org/is

[issue21027] difflib new cli interface

2014-04-15 Thread Claudiu.Popa
Claudiu.Popa added the comment: Raymond, any news on this? -- ___ Python tracker <http://bugs.python.org/issue21027> ___ ___ Python-bugs-list mailing list Unsub

[issue15795] Zipfile.extractall does not preserve file permissions

2014-04-15 Thread Claudiu.Popa
Claudiu.Popa added the comment: Hello. I added a couple of comments to your latest patch. -- nosy: +Claudiu.Popa ___ Python tracker <http://bugs.python.org/issue15

[issue21217] inspect.getsourcelines finds wrong lines when lambda used argument to decorator

2014-04-15 Thread Claudiu.Popa
Claudiu.Popa added the comment: "- We added tests of decorated classes. The source of decorated classes does not include the decorators, which is different than the usual behavior of decorated functions. What is the correct behavior here?" There is an open issue for

[issue19385] dbm.dumb should be consistent when the database is closed

2014-04-23 Thread Claudiu.Popa
Claudiu.Popa added the comment: gzip uses the same name, _check_closed, but your suggestion sounds good. I'll update the patch. -- ___ Python tracker <http://bugs.python.org/is

[issue17442] code.InteractiveInterpreter doesn't display the exception cause

2014-04-23 Thread Claudiu.Popa
Claudiu.Popa added the comment: Python's interactive interpreter doesn't show the offending code lines too. And given the fact that code.InteractiveInterpreter tries to be an emulation of the default interpreter, first the change should be addressed directly there, I think. But I

[issue19385] dbm.dumb should be consistent when the database is closed

2014-04-23 Thread Claudiu.Popa
Claudiu.Popa added the comment: On my machine I get the following results for the unclosed-database case. With patch: # ./python -S -m timeit -n 10 -s "import dbm.dumb as dbm; d=dbm.open('x.dat', 'c');len(d)" 10 loops, best of 3: 0.0638 usec per loop Wi

[issue16104] Compileall script: add option to use multiple cores

2014-04-23 Thread Claudiu.Popa
Claudiu.Popa added the comment: Added a new version of the patch which incorporates suggestions made by Jim. Thanks for the review! -- Added file: http://bugs.python.org/file35018/issue16104_8.patch ___ Python tracker <http://bugs.python.

[issue21344] save scores or ratios in difflib get_close_matches

2014-04-24 Thread Claudiu.Popa
Claudiu.Popa added the comment: It would be easier to review your patch if you'll upload it as a proper patch. Usually for these cases (modifying the return by passing a specific argument) it's best to provide a new function with this functionality, by having get_close_m

[issue21344] save scores or ratios in difflib get_close_matches

2014-04-24 Thread Claudiu.Popa
Claudiu.Popa added the comment: Ah, nevermind my first comment. -- ___ Python tracker <http://bugs.python.org/issue21344> ___ ___ Python-bugs-list mailin

[issue21344] save scores or ratios in difflib get_close_matches

2014-04-24 Thread Claudiu.Popa
Claudiu.Popa added the comment: Your patch needs tests and documentation update. For examples, you could look in test_difflib.py and see how get_close_matches is tested. -- ___ Python tracker <http://bugs.python.org/issue21

[issue9731] Add ABCMeta.has_methods and tests that use it

2014-04-24 Thread Claudiu.Popa
Claudiu.Popa added the comment: I have updated the previous patch, by documenting the new class method. -- versions: +Python 3.5 -Python 3.4 Added file: http://bugs.python.org/file35027/issue9731.patch ___ Python tracker <http://bugs.python.

[issue19950] Document that unittest.TestCase.__init__ is called once per test

2014-04-27 Thread Claudiu.Popa
Claudiu.Popa added the comment: In Python 3 docs there is a hint in the documentation for `loadTestsFromModule`: "This method searches module for classes derived from TestCase and creates an instance of the class for each test method defined for the class." The phrase with a fixtur

[issue20642] Enhance deepcopy-ing for tuples

2014-04-27 Thread Claudiu.Popa
Claudiu.Popa added the comment: Ping? The change is clear, has the same semantics and its a little bit faster. -- ___ Python tracker <http://bugs.python.org/issue20

[issue18039] dbm.open(..., flag="n") does not work and does not give a warning

2014-04-27 Thread Claudiu.Popa
Claudiu.Popa added the comment: Can anyone review this patch? -- ___ Python tracker <http://bugs.python.org/issue18039> ___ ___ Python-bugs-list mailing list Unsub

[issue18615] sndhdr.whathdr could return a namedtuple

2014-04-27 Thread Claudiu.Popa
Claudiu.Popa added the comment: Ping. :) -- ___ Python tracker <http://bugs.python.org/issue18615> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21362] concurrent.futures does not validate that max_workers is proper

2014-04-27 Thread Claudiu.Popa
New submission from Claudiu.Popa: Due to some bad math on my side, I passed max_workers=0 to concurrent.futures.ThreadPoolExecutor. This didn't fail properly, but hanged. The same behaviour occurs in ProcessPoolExecutor, but this time it fails internally with something like this: Exce

[issue21362] concurrent.futures does not validate that max_workers is proper

2014-04-27 Thread Claudiu.Popa
Claudiu.Popa added the comment: For instance, multiprocessing behaves like this: >>> multiprocessing.Pool(-1) Traceback (most recent call last): File "", line 1, in File "C:\Python34\lib\multiprocessing\context.py", line 118, in Pool context=self.get_conte

[issue16104] Compileall script: add option to use multiple cores

2014-04-27 Thread Claudiu.Popa
Claudiu.Popa added the comment: Added a new patch with improvements suggested by Jim. Thanks! I removed the handling of processes=1, because it can still be useful: having a background worker which processes the files received from _walk_dir. Also, it checks that compile_dir receives a

[issue16104] Compileall script: add option to use multiple cores

2014-04-27 Thread Claudiu.Popa
Claudiu.Popa added the comment: Add new patch with fixes proposed by Berker Peksag. Thanks for the review. Hopefully, this is the last iteration of this patch. -- Added file: http://bugs.python.org/file35055/issue16104_10.patch ___ Python tracker

[issue16104] Compileall script: add option to use multiple cores

2014-04-27 Thread Claudiu.Popa
Changes by Claudiu.Popa : Added file: http://bugs.python.org/file35056/issue16104_11.patch ___ Python tracker <http://bugs.python.org/issue16104> ___ ___ Python-bug

[issue21362] concurrent.futures does not validate that max_workers is proper

2014-04-27 Thread Claudiu.Popa
Claudiu.Popa added the comment: Attached patch with improvements suggested by Charles-François Natali. Thank you for the review. -- Added file: http://bugs.python.org/file35057/issue21362.patch ___ Python tracker <http://bugs.python.org/issue21

[issue21362] concurrent.futures does not validate that max_workers is proper

2014-04-27 Thread Claudiu.Popa
Changes by Claudiu.Popa : Added file: http://bugs.python.org/file35058/issue21362_1.patch ___ Python tracker <http://bugs.python.org/issue21362> ___ ___ Python-bugs-list m

[issue21367] multiprocessing.JoinableQueue requires new kwarg

2014-04-27 Thread Claudiu.Popa
Changes by Claudiu.Popa : -- nosy: +sbt ___ Python tracker <http://bugs.python.org/issue21367> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21378] ImportError: No module named 'concurrent.futures'

2014-04-28 Thread Claudiu.Popa
Claudiu.Popa added the comment: Do you have a module/file named concurrent.py in your PATH? -- nosy: +Claudiu.Popa ___ Python tracker <http://bugs.python.org/issue21

[issue16104] Compileall script: add option to use multiple cores

2014-04-30 Thread Claudiu.Popa
Claudiu.Popa added the comment: Updated patch according to the python-dev thread: - processes renamed to workers - `workers` defaults to 1 - When `workers` is equal to 0, then `os.cpu_count` will be used - When `workers` > 1, multiple processes will be used - When `workers` == 1, run norma

[issue21394] Lib/random.py: use more efficient code to convert bytes to integer

2014-04-30 Thread Claudiu.Popa
Claudiu.Popa added the comment: Do you mean int.from_bytes? It's already changed in Python 3.5: int.from_bytes(_urandom(32), 'big'). ------ nosy: +Claudiu.Popa ___ Python tracker <http://bugs.pyt

[issue21436] bring back importlib.load_source() et al.

2014-05-05 Thread Claudiu.Popa
Changes by Claudiu.Popa : -- nosy: +Claudiu.Popa ___ Python tracker <http://bugs.python.org/issue21436> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19776] Provide expanduser() on Path objects

2014-05-12 Thread Claudiu.Popa
Claudiu.Popa added the comment: Added a new version of the patch with improvements suggested by Berker Peksag. Thanks for the review! -- Added file: http://bugs.python.org/file35237/issue19776.patch ___ Python tracker <http://bugs.python.

[issue21493] Add test for ntpath.expanduser

2014-05-13 Thread Claudiu.Popa
New submission from Claudiu.Popa: Hello. This patch adds a test for ntpath.expanduser, which was missing. Also, it increases the test coverage for ntpath.py from 68% to 75%. -- components: Tests files: expanduser.patch keywords: patch messages: 218427 nosy: Claudiu.Popa priority

[issue18615] sndhdr.whathdr could return a namedtuple

2014-05-13 Thread Claudiu.Popa
Claudiu.Popa added the comment: But it improves the API. It's much nicer to actually access the values returned by sndhdr as f.type, f.sampling_rate, f.channels than f[0], f[1], f[2]. You do have a point though. Would it be more acceptable if we'll provide a new function which

[issue19385] dbm.dumb should be consistent when the database is closed

2014-05-13 Thread Claudiu.Popa
Claudiu.Popa added the comment: Right, my benchmark was indeed flawed. Here are the new results on my machine: Without the patch # ./python -S -m timeit -n 10 -s "import dbm.dumb as dbm; d=dbm.open('x.dat', 'c')" "len(d)" 10 loops, best o

[issue19385] dbm.dumb should be consistent when the database is closed

2014-05-13 Thread Claudiu.Popa
Claudiu.Popa added the comment: Here's a new patch which uses the EAFP approach for dunder methods (__len__, __contains__ etc) and the _verify_open method for the other methods (.keys, .iterkeys) etc. Now the results are similar with the benchmark without the patch. -- Added

[issue21027] difflib new cli interface

2014-05-14 Thread Claudiu.Popa
Changes by Claudiu.Popa : Added file: http://bugs.python.org/file35247/issue21027_1.patch ___ Python tracker <http://bugs.python.org/issue21027> ___ ___ Python-bugs-list m

[issue21027] difflib new cli interface

2014-05-16 Thread Claudiu.Popa
Claudiu.Popa added the comment: Attached the new version of the patch which removes the resource warnings. Raymond, I disagree on certain points. `difflib -m` does help the development, especially for platforms where there aren't many readily available alternatives (like Windows). I ga

[issue21518] Expose RegUnloadKey in winreg

2014-05-17 Thread Claudiu.Popa
New submission from Claudiu.Popa: Hello. While working on issue8579, I noticed that there is no way to detach a key from the registry, loaded with LoadKey function. The attached patch exposes RegUnLoadKeyW as winreg.UnloadKey. Also, this patch adds a new script in the test folder

[issue21518] Expose RegUnloadKey in winreg

2014-05-17 Thread Claudiu.Popa
Claudiu.Popa added the comment: It needs administrator elevation for running the test. I'll update the patch to skip the test if the user doesn't have elevation. -- ___ Python tracker <http://bugs.python.o

[issue21518] Expose RegUnloadKey in winreg

2014-05-18 Thread Claudiu.Popa
Claudiu.Popa added the comment: This version of the patch skips the test if the privileges can't be acquired. -- Added file: http://bugs.python.org/file35285/issue21518.patch ___ Python tracker <http://bugs.python.org/is

[issue21527] concurrent.futures.ThreadPoolExecutor does not use a default value

2014-05-18 Thread Claudiu.Popa
New submission from Claudiu.Popa: As the title says, ThreadPoolExecutor does not use a default value for max_workers parameter, as ProcessPoolExecutor does. When the user does not care about the number of workers and wants only for something to run in background, he has to write code like

[issue21518] Expose RegUnloadKey in winreg

2014-05-18 Thread Claudiu.Popa
Claudiu.Popa added the comment: Thanks. Here's the updated version. Also, I only tested it on Windows 8.1. I'll try to find another machine with an older OS for testing it. -- Added file: http://bugs.python.org/file35288/issue215

[issue21550] Add Python implementation of the tar utility

2014-05-21 Thread Claudiu.Popa
Claudiu.Popa added the comment: I don't think that adding it to Tools/script helps that much on Windows at least. See issue21027 for reference. Except this, +1 from me. -- nosy: +Claudiu.Popa ___ Python tracker <http://bugs.python.org/is

[issue21090] File read silently stops after EIO I/O error

2014-05-21 Thread Claudiu.Popa
Changes by Claudiu.Popa : -- nosy: -Claudiu.Popa ___ Python tracker <http://bugs.python.org/issue21090> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8579] Add missing tests for FlushKey, LoadKey, and SaveKey in winreg

2014-05-21 Thread Claudiu.Popa
Claudiu.Popa added the comment: I'm working on this issue and I have a minimal patch ready, but it depends on issue21518, which proposes adding UnloadKey to winreg, so that we can unload the keys mounted with LoadKey. Also, that issue adds a mechanism for privilege acquisition, which

[issue21560] gzip.write changes trailer ISIZE field before type checking - corrupted gz file after trying to write string

2014-05-23 Thread Claudiu.Popa
Claudiu.Popa added the comment: Moving `self.crc = zlib.crc32(data, self.crc) & 0x` before `self.size = self.size + len(data)` should be enough. Also, your patch needs a test. -- nosy: +Claudiu.Popa ___ Python tracker &

[issue21574] Port image types detections from PIL to the imghdr module

2014-05-25 Thread Claudiu.Popa
Claudiu.Popa added the comment: Sounds good, I'll create a patch. -- ___ Python tracker <http://bugs.python.org/issue21574> ___ ___ Python-bugs-list m

[issue10203] sqlite3.Row doesn't support sequence protocol

2014-05-25 Thread Claudiu.Popa
Claudiu.Popa added the comment: Thanks. Here's the updated patch. It supports negative indeces (my previous patch didn't do that). -- Added file: http://bugs.python.org/file35354/issue10203.patch ___ Python tracker <http://bu

[issue21493] Add test for ntpath.expanduser

2014-05-25 Thread Claudiu.Popa
Claudiu.Popa added the comment: Here's an updated patch. -- Added file: http://bugs.python.org/file35355/issue21493.patch ___ Python tracker <http://bugs.python.org/is

[issue10203] sqlite3.Row doesn't support sequence protocol

2014-05-26 Thread Claudiu.Popa
Claudiu.Popa added the comment: Thanks. Here's a fix. -- Added file: http://bugs.python.org/file35373/issue10203_1.patch ___ Python tracker <http://bugs.python.org/is

[issue10203] sqlite3.Row doesn't support sequence protocol

2014-05-27 Thread Claudiu.Popa
Claudiu.Popa added the comment: Thanks. Patch modified. -- Added file: http://bugs.python.org/file35376/issue10203_2.patch ___ Python tracker <http://bugs.python.org/issue10

[issue21589] Use better idiom in unittest example

2014-05-27 Thread Claudiu.Popa
New submission from Claudiu.Popa: Hello. This patch proposes using `assertIn` in the first unittest example, instead of `assertTrue(x in seq)`. This is clearer and recommending it first is better for beginners. -- assignee: docs@python components: Documentation files

[issue19385] dbm.dumb should be consistent when the database is closed

2014-05-28 Thread Claudiu.Popa
Claudiu.Popa added the comment: Looks good to me. -- ___ Python tracker <http://bugs.python.org/issue19385> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18039] dbm.open(..., flag="n") does not work and does not give a warning

2014-06-02 Thread Claudiu.Popa
Changes by Claudiu.Popa : -- nosy: +serhiy.storchaka ___ Python tracker <http://bugs.python.org/issue18039> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18039] dbm.open(..., flag="n") does not work and does not give a warning

2014-06-02 Thread Claudiu.Popa
Claudiu.Popa added the comment: Serhiy, could you please have a look at this patch? Given the fact that you committed my last dbm patch, I hope you have a couple of minutes to have a look at this one as well. -- ___ Python tracker <h

[issue19997] imghdr.what doesn't accept bytes paths

2014-06-02 Thread Claudiu.Popa
Claudiu.Popa added the comment: There are other modules with support for bytes filenames in their API: bz2 codecs gzip lzma pipes.Template tarfile tokenize fileinput filecmp sndhdr

[issue21636] test_logging fails on Windows for Unix tests

2014-06-02 Thread Claudiu.Popa
New submission from Claudiu.Popa: Hello! The attached patch fixes a crash for the logging tests on Windows. That's because the tests assume that socket.AF_UNIX exists. The actual traceback is: [1/1] test_logging test test_logging crashed -- Traceback (most recent call last): Fi

[issue21636] test_logging fails on Windows for Unix tests

2014-06-02 Thread Claudiu.Popa
Claudiu.Popa added the comment: No, because the tests will be skipped after the assignment of the address family. -- ___ Python tracker <http://bugs.python.org/issue21

  1   2   3   >