Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue25455>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
As I've mentioned elsewhere, I'll have to temporarily take myself off these
issues as I don't have the time to work on them (even review patches). I think
Raymond may have gotten his Stefans mixed up and meant Stefan Behnel, who's
also b
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue25455>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Serhiy, I'm truly sorry but for this and other issues you pinged -- I currently
have zero bandwidth to invest in this. Feel free to ask around on pydev if
there are other folks interested in reviewing patches and decisions w.r.t the
etree module. I'm
Eli Bendersky added the comment:
I'm not sure. This is why I'm proposing asking on python-dev
--
___
Python tracker
<http://bugs.python.org/issue19176>
___
__
Eli Bendersky added the comment:
I don't know how important this is to really warrant removal. Removal means
potentially breaking working code when trying to run it with Python 3.5, and my
impression was that the core devs are somewhat alergic to this, at least while
the transition to P
New submission from Eli Bendersky:
lib2to3 helpfully provides pygram.python_grammar_no_print_statement for parsing
Python 3 ('print' has the semantics of an identifier, not a keyword)
However, the same courtesy is not extended to 'exec', which also turns from a
statement
Changes by Eli Bendersky :
--
stage: -> needs patch
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue23894>
___
___
Python-bugs-list
New submission from Eli Bendersky:
lib2to3 tokenizes br'abc' as a single STRING token, but rb'abc' as two separate
tokens (NAME "rb" and STRING 'abc')
This is because pgen2/tokenize.py doesn't list rb'' as a viable prefix for a
stri
Changes by Eli Bendersky :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue23549>
___
___
Python-bugs-list
Eli Bendersky added the comment:
Raymond - gentle ping.
Do you see a reason not to check this in?
--
___
Python tracker
<http://bugs.python.org/issue23
Eli Bendersky added the comment:
Good catch.
Attaching a new version of the patch with the typo fixed.
--
Added file: http://bugs.python.org/file38280/issue23549.2.patch
___
Python tracker
<http://bugs.python.org/issue23
Eli Bendersky added the comment:
Proposed patch (generated vs. the 3.4 docs) is attached
--
keywords: +patch
Added file: http://bugs.python.org/file38277/issue23549.1.patch
___
Python tracker
<http://bugs.python.org/issue23
New submission from Eli Bendersky:
The heapq documentation has this paragraph after the doc of nsmallest:
The latter two functions perform best for smaller values of n. For larger
values, it is more efficient to use the sorted() function. Also, when n==1, it
is more efficient to use the
Eli Bendersky added the comment:
I don't have time, unfortunately. So other folks can pick this up.
I don't remember if I made any progress on this - will post whatever I have if
I find something.
--
___
Python tracker
<http://bu
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue21793>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Georg, each library writer is entitled to do whatever she wants. Naturally, we
can't prevent dumping contents of enums into the module namespaces, and yes,
backwards compatibility makes sense for some modules.
However, that's tangential to *encoura
Eli Bendersky added the comment:
I'm not sure why the current situation is annoying?
Python explicitly does not pollute the enclosing namespace with an Enum's
members. So when you:
import A
It's fairly natural that you have access to A.MyEnum and not its members, no?
Some mod
Eli Bendersky added the comment:
>> I could continue the discussion about databases, but it feels like a waste
>> of time to me. The main principle is: If something has an important property
>> (in this case an enum object's numerical value), it should be publicly
>
Eli Bendersky added the comment:
Ezio, could you see if your comments were addressed?
Steven, do you want to take another look, or is this OK to commit?
--
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
No worries, Daniel. You should have received an email when comments were posted
to the review, did you? If you you may want to check your settings in the bug
tracker.
I left a couple of additional comments on the documentation file, but other
than that this
Eli Bendersky added the comment:
Daniel, I left some comments in Rietveld. Also it doesn't seem that you
addressed the previously left comments when you fixed up the patch.
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
On Tue, Jun 24, 2014 at 3:18 PM, Ned Deily wrote:
>
> Ned Deily added the comment:
>
> It is described in the developer's guide. The current status is
> summarized here:
>
> https://docs.python.org/devguide/devcycle.html#summary
Eli Bendersky added the comment:
On Tue, Jun 24, 2014 at 2:29 PM, Ned Deily wrote:
>
> Ned Deily added the comment:
>
> The 3.3 branch is now only open for security fixes so this issue doesn't
> appear to warrant backporting there.
>
> --
>
These questio
Eli Bendersky added the comment:
[sorry, the first question mark shouldn't be - the patch indeed looks
reasonable to me]
Steven - how about launching a subprocess for stdin tests to avoid weird issues?
--
___
Python tracker
<http://bugs.py
Eli Bendersky added the comment:
The patch looks reasonable? Is the only remaining problem with crafting the
test?
--
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
Nosy-ing myself since I just ran into it. Annoying issue that precludes from
using argparse's builtin '-' recognition for reading binary data.
I'll try to carve some time later to look at the patches.
--
nosy: +eli.bendersky
v
Eli Bendersky added the comment:
Is it really worthwhile to complicate the API for the sake of providing a less
flexible solution for rare cases that saves a few keystrokes?
--
___
Python tracker
<http://bugs.python.org/issue21
Eli Bendersky added the comment:
Skip, PTAL at the devguide.
https://docs.python.org/devguide/setup.html#avoiding-re-creating-auto-generated-files
--
___
Python tracker
<http://bugs.python.org/issue21
Eli Bendersky added the comment:
This is also described in the Dev Guide:
https://docs.python.org/devguide/setup.html
--
___
Python tracker
<http://bugs.python.org/issue19
Eli Bendersky added the comment:
Stefan, you need to run `make touch` if you want to avoid rebuilding. See
#15964 for more details.
[all bots run `make touch` before building now]
--
___
Python tracker
<http://bugs.python.org/issue19
Changes by Eli Bendersky :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eli Bendersky added the comment:
> Note that this has been fixed in Py3 already (Py3.3, I guess). The only
> question is whether the behaviour will be changed in Py2.7.
>
I don't think this issue is acute enough to warrant fixes in 2.7; however,
a documentation patch wo
Eli Bendersky added the comment:
Updated patch attached:
1. Python 3.3+ supported (I suspect 3.2 will work too)
2. Incorporated Serhiy's suggestions (thanks for the review!)
--
Added file: http://bugs.python.org/file34742/new-asdl-parser.issue19655.2.
Eli Bendersky added the comment:
Nick, it shouldn't be hard to drop to 3.3, but I'm curious why would the 3.4
requirement break Fedora, or anything for that matter? Does Fedora regenerate
the C implementation of the AST for some reason on every build? AFAIU, building
Python from s
Eli Bendersky added the comment:
On Fri, Apr 4, 2014 at 6:10 AM, Serhiy Storchaka wrote:
>
> Serhiy Storchaka added the comment:
>
> Now make fails when system Python is older than 3.4.
>
>
This is why the .h & .c files are checked in - someone just building Python
doesn
Eli Bendersky added the comment:
On Thu, Apr 3, 2014 at 1:19 PM, Nikolaus Rath wrote:
>
> Nikolaus Rath added the comment:
>
> Thanks for the commit!
>
> My intention is to fix the behavior itself for 3.5 (see issue 9521), so I
> think adding testcases for the old behavior
Eli Bendersky added the comment:
Since there has mostly been support for this, I'll wait a couple more days and
commit it unless someones objects or asks for more time for review.
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
Thanks. Doc patch committed with some slight rewording.
Would you like to prepare a separate patch for the tests, default branch only
this time?
--
versions: -Python 3.4
___
Python tracker
<http://bugs.python.
Eli Bendersky added the comment:
> Do you have concrete suggestions? Make the tree iterable?
> > Add all element methods to the tree, implicitly forwarding to the root?
>
> Yes, that is the feature request. Add all the element methods to the
> elementtree object.
>
>
Eli Bendersky added the comment:
I left some comments in Rietveld.
There shouldn't be a problem getting these into 3.4 too - doc changes are
usually excempt from most restrictions.
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
Raymond, you are right that the APIs presented by Element and ElementTree are
somewhat different. As Stefan mentioned, they were really meant to represent
different things, but with time some "convenience" features crept in and made
the differenc
Eli Bendersky added the comment:
The patch appears to contain code (tests) along with the documentation. Is this
intended? This issue is not tagged properly if it is.
I'd suggest to split them to separate patches.
--
versions: +Python 3.5 -Python 2.7, Python 3.3, Pytho
Eli Bendersky added the comment:
Attaching patch that implements this. To make it easier, the patch only
replaces the ASDL parser - not touching anything else and leaving the output
intact.
With this patch applied, when the Makefile is rerun it regenerates the actual
AST code in:
Include
Eli Bendersky added the comment:
There were no serious objections bar the pre-release timing. Now that we're
safely in 3.5 territory, can I go ahead and create a patch?
Note that for purposes of review, the Github project linked in the original
message is more convenient,
Eli Bendersky added the comment:
Revised patch LGTM.
--
___
Python tracker
<http://bugs.python.org/issue14332>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Can you upload the new patch?
--
___
Python tracker
<http://bugs.python.org/issue20653>
___
___
Python-bugs-list mailin
Eli Bendersky added the comment:
> Many comments, Eli's and Serhey's code changes incorporated.
Looks better, thanks. I left some comments in Rietveld.
--
___
Python tracker
<http://bugs.pytho
Eli Bendersky added the comment:
The discussion in #20653 is ongoing but I have to say I don't feel confident
about this issue at all.
If anything, I'd prefer to explicitly mark "advanced pickling support" for
enums as provisional in 3.4 - this is a simple documentation fi
Eli Bendersky added the comment:
If you were enlightened about how to use the pickle protocols, please explains
this better in the code. Currently the code says:
# check for a supported pickle protocols, and if not present sabotage
+# pickling, since it won't work a
Eli Bendersky added the comment:
I left some comments in #20653
As for cherry-picking this into 3.4, I'm not sure. Ethan - what is the worst
scenario this patch enables to overcome? Someone getting locked in to by-value
pickling with certain enums i
Eli Bendersky added the comment:
Ethan, the patch you committed here seems obscure to me. Why __reduce_ex__ and
not __reduce__? Where are the accompanying documentation changes? Can you
clarify more how the full logic of pickling now works - preferably in comments
withing the code
Eli Bendersky added the comment:
Yep, the overriding of the type name was inadvertent. Nothing sacred about it,
so Ethan's SocketKind is just as good.
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
The source for the diagram is here:
https://docs.google.com/drawings/d/1F8do-1WL1sIGkZuiufcxcpZRtS0w4SwAowq-Uamrwt8/edit?usp=sharing
Anyone - feel free to copy that doc over and create a new diagram with smaller
whitespacing. Let me know if there are any
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue18986>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Thanks. I left some comments in the code review tool
--
___
Python tracker
<http://bugs.python.org/issue19687>
___
___
Python-bug
Changes by Eli Bendersky :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eli Bendersky added the comment:
Committed in 90b56ec318b6
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: +Python 3.2 -Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.or
Eli Bendersky added the comment:
If I don't see any further objections I'll go ahead and commit this by the end
of the week
--
___
Python tracker
<http://bugs.python.o
Eli Bendersky added the comment:
Thanks for the report & patches. Fixed in all active branches.
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.pytho
Eli Bendersky added the comment:
I don't see how these implementation details are relevant. The patch adds a
link to the existing abbreviations section, which mentions parse_args - so it's
clear that this behavior exists in both.
Yes, #14910 (to which I pointed in the original messa
Eli Bendersky added the comment:
>
> STINNER Victor added the comment:
>
> Which tool did you use to draw this schema? You may attach also the source
> if someone would like to modify it in the future.
>
Sorry, but there's no source. I drew it graphically. But since I did
Changes by Eli Bendersky :
Added file: http://bugs.python.org/file32871/pathlib-inheritance.png
___
Python tracker
<http://bugs.python.org/issue19799>
___
___
Python-bug
Eli Bendersky added the comment:
On Wed, Nov 27, 2013 at 6:21 AM, STINNER Victor wrote:
>
> STINNER Victor added the comment:
>
> Could you please attach the picture separatly?
>
>
Done
--
___
Python tracker
<http://bugs.
Eli Bendersky added the comment:
Here's a patch for 3.3; if it looks ok i'll merge it to default and also to 2.7
--
keywords: +patch
Added file: http://bugs.python.org/file32870/issue19814.doc33.patch
___
Python tracker
<http://bu
New submission from Eli Bendersky:
Prefix matching behavior can lead to bugs when combined with parse_known_args.
See this thread for more details:
https://mail.python.org/pipermail/python-dev/2013-November/130601.html
Issue #14910 deals with making it optional, but until 3.5 we'll have
Eli Bendersky added the comment:
Just in case it isn't:
https://dl.dropboxusercontent.com/u/15602400/images/pathlib-inheritance.png
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
Attaching a new patch. Hopefully the image will be viewable in the code review
tool
--
Added file: http://bugs.python.org/file32869/issue19799.2.patch
___
Python tracker
<http://bugs.python.org/issue19
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue14910>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
keywords: -easy
___
Python tracker
<http://bugs.python.org/issue19624>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
keywords: +patch
Added file: http://bugs.python.org/file32858/issue19799.initial.patch
___
Python tracker
<http://bugs.python.org/issue19
New submission from Eli Bendersky:
Following up from Issue #19673; The initial patch clarifies the use cases of
pure vs. concrete paths a bit and adds explicit signatures for the path class
constructors (moving the construction discussion under the parent class).
Also, IMHO an inheritance
Eli Bendersky added the comment:
Thanks for the clarifications, Antoine. I'll see if I can come up with a doc
patch that will try to emphasize these points. I'll probably just open a new,
doc-issue to stop overloading this one.
--
Eli Bendersky added the comment:
On Sun, Nov 24, 2013 at 2:58 PM, Larry Hastings wrote:
>
> Larry Hastings added the comment:
>
> The rule is, no new features. Bug and security fixes from now on.
>
> It isn't always clear whether or not something is a new "feat
Eli Bendersky added the comment:
Larry Hastings added the comment:
>
> Are the generated files *byte for byte* the same as produced by the
> existing parser generation process?
>
Correct. The generator runs during the build (in the Makefile), but only if
the files were out-of-da
Eli Bendersky added the comment:
>
>
> Antoine Pitrou added the comment:
>
> > Another question: What is the real purpose of pure paths? One thing I
> > see is using them to, say, manipulate Windows paths on a Posix machine
> > for some reason.
>
> Yes. Also
Eli Bendersky added the comment:
It's just a matter of looking for a familiar pattern while going over an
unfamiliar doc page, I guess. I'll give it a try and see if it helps.
Another question: What is the real purpose of pure paths? One thing I see is
using them to, say, manipula
Eli Bendersky added the comment:
Yes, I've seen that. What I mean is that there's no clear signature defined
with each argument explained, as the other stdlib documentation usually does.
Section 11.1.2.1 uses a more descriptive approach, while I was also expecting a
formal specifi
Eli Bendersky added the comment:
Antoine, am I missing something - I don't see documentation for the
construction of Path/PurePath?
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
Does anyone have comments on the code or can I prepare a patch for default?
Would it make sense to wait with this until the 3.4 branch is created or can I
just commit to default? Note that this change is not a new feature and is
essentially a no-op as far as
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue13633>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Larry, ease your worries: note that I only tagged this on version 3.5!
That said, this parser runs during the build and produces a .h file and .c file
- these partake in the build; I verified that the generated code is *identical*
to before, so there'
Eli Bendersky added the comment:
FWIW, asdl_c.py could use some "modernization", but I'll defer this to a later
cleanup in order to do things gradually.
The same can be said for the Makefile rules - they can be simpler and more
efficient (no need to invoke asdl_c / parse the
Changes by Eli Bendersky :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue19655>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Eli Bendersky:
It was mentioned in one of the recent python-dev threads that making the Python
code-base simpler to encourage involvement of contributors is a goal, so I
figured this may be relevant.
I've recently written a new parser for the ASDL specification lan
Eli Bendersky added the comment:
Thanks for the report, Martin. I'll take a look once I get some time
--
___
Python tracker
<http://bugs.python.org/is
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue16425>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Eli Bendersky :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue19452>
___
___
Python-bugs-list mailing list
Unsubscrib
Eli Bendersky added the comment:
Thanks for the report, Peter. This is indeed a documentation fix for Python
3.3; note that in 3.4 (default branch), the restriction was lifted and
iterparse now accepts any iterable sequence. The documentation also reflects
that (saying that 'events&
Eli Bendersky added the comment:
On Mon, Oct 28, 2013 at 6:00 AM, Martin Panter wrote:
>
> Martin Panter added the comment:
>
> The best way to work around it for me is just to ignore the warning. It
> doesn’t really worry me that much, I only noticed it while porting a
> p
Eli Bendersky added the comment:
Martin, do you see a way to work around the problem?
I'm not sure it's serious enough to warrant committing to the 2.7.x branch at
this point.
--
___
Python tracker
<http://bugs.python.o
Eli Bendersky added the comment:
This is superceded by:
http://bugs.python.org/issue18906
--
superseder: -> Create a way to always run tests in subprocesses within regrtest
___
Python tracker
<http://bugs.python.org/issu
Eli Bendersky added the comment:
Tim, any suggestions?
--
___
Python tracker
<http://bugs.python.org/issue14332>
___
___
Python-bugs-list mailing list
Unsub
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue9398>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue8957>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue9317>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eli Bendersky added the comment:
I think this issue can be closed, since Martin's touch step runs on the bots
successfully, and the ASDL dependencies in .hgtouch were fixed.
--
resolution: -> fixed
stage: -> committed/rejected
status: ope
Eli Bendersky added the comment:
+nick,guido,benjamin: in case you're interested in the discussion that takes
place in the most recent messages of this issue
--
nosy: +benjamin.peterson, gvanrossum, ncoghlan
___
Python tracker
1 - 100 of 1229 matches
Mail list logo