Erlend E. Aasland added the comment:
Here's the output when with test.support.verbose = True:
test_ssl: testing with 'OpenSSL 1.1.1k 25 Mar 2021' (1, 1, 1, 11, 15)
under Mac ('11.3.1', ('', '', ''), 'x86_64
Change by Erlend E. Aasland :
--
pull_requests: +25046
pull_request: https://github.com/python/cpython/pull/26452
___
Python tracker
<https://bugs.python.org/issue42
Erlend E. Aasland added the comment:
> It could be, but the same thing happens on Windows
Are you sure? All the reports are from macOS CI. Christian mentioned that it
could be similar to another ssl test failure that also happen on Windows, but
those tracebacks do not match the o
Erlend E. Aasland added the comment:
See also bpo-44229
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue43855>
___
___
Python-bug
Erlend E. Aasland added the comment:
See also bpo-43855.
--
___
Python tracker
<https://bugs.python.org/issue44229>
___
___
Python-bugs-list mailing list
Unsub
New submission from Erlend E. Aasland :
The code that used the connection argument was removed one year before pysqlite
was included in CPython, as far as I can see. It can safely be removed.
See also:
https://github.com/ghaering/pysqlite/commit/5a009ed6fb2e90b952438f5786f93cd1e8ac8722
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25126
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26535
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44304>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
Thanks Mike for the report and reproducer, and Pablo for the fix!
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25128
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26537
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
PR 26351 adds the Py_TPFLAGS_IMMUTABLETYPE type flag to all types converted to
heap type during 3.10 development.
--
___
Python tracker
<https://bugs.python.org/issue43
Erlend E. Aasland added the comment:
sqlit3.Cursor is prone to the same bug. Do you want me to create a new issue
for it, or can I reuse this issue number, Pablo? I'll see if I can create a
reproducer for that as well.
--
___
Python tracker
New submission from Erlend E. Aasland :
The db member of pysqlite_Statement is only "used" in the __init__ method.
Suggesting to remove this. A couple of lines less of code, a couple of bytes
less per statement object.
--
assignee: erlendaasland
components: Extension Module
New submission from Erlend E. Aasland :
The timeout and timeout_started members of pysqlite_Connection are never used.
Suggesting to remove them.
--
assignee: erlendaasland
components: Extension Modules
messages: 395219
nosy: erlendaasland
priority: low
severity: normal
status: open
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25154
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26565
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
The "sql" member is also unused. Removing this will make the tp_clear method
redundant, as there are no PyObjects to clear anymore.
--
title: [sqlite3] remove unused db member from pysqlite_Statement -> [sqlite3]
remove unused
Change by Erlend E. Aasland :
--
Removed message: https://bugs.python.org/msg395216
___
Python tracker
<https://bugs.python.org/issue44326>
___
___
Python-bug
New submission from Erlend E. Aasland :
The db member of pysqlite_Statement is only "used" in the statement create
method. Suggesting to remove this. A couple of lines less of code, a couple of
bytes less per statement object.
--
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25153
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26564
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
... to expand: so currently, if statement creation fails, we must deallocate
the PyObject.
--
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
Ah, I see I formulated myself a bit unclear:
Yes, we need to allocate/track every time. I just propose to do so as late as
possible, in order to avoid allocating a PyObject before we know if it is
possible to actually create the statement
New submission from Erlend E. Aasland :
Currently, pysqlite_statement_create() approx. looks like this:
1. some sanity checks (type, sql lenght, etc.)
2. allocate (PyObject_GC_New)
3. initialise members
4. determine if statement is a DML statement
5. create the statement (sqlite3_prepare_v2)
6
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25155
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26566
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25156
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26567
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
> I am not sure what you mean, in the happy path you still need to GC track and
> allocate.
Currently, we allocate the object, then try to create the statement using the
SQLite API. If we create the statement first, we can do the sanity
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44331>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue42514>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
pull_requests: +25108
pull_request: https://github.com/python/cpython/pull/26512
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
pull_requests: +25110
pull_request: https://github.com/python/cpython/pull/26515
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
pull_requests: +25112
pull_request: https://github.com/python/cpython/pull/26517
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
___
Python tracker
<https://bugs.python.org/issue44041>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.pyth
Erlend E. Aasland added the comment:
This change breaks existing behaviour (see test below). Also,
sqlite3_column_count() is implemented as a simple lookup in SQLite; it is never
an expensive function. Suggests to add the following test instead:
diff --git a/Lib/sqlite3/test/dbapi.py b/Lib
Erlend E. Aasland added the comment:
Global module state has been established by
f461a7fc3f8740b9e79e8874175115a3474e5930 (bpo-42862, GH-24203). We can safely
migrate static variables into that struct as a next step.
--
___
Python tracker
<ht
Change by Erlend E. Aasland :
--
pull_requests: +24985
pull_request: https://github.com/python/cpython/pull/26392
___
Python tracker
<https://bugs.python.org/issue43
Change by Erlend E. Aasland :
--
pull_requests: +24987
pull_request: https://github.com/python/cpython/pull/26394
___
Python tracker
<https://bugs.python.org/issue43
Erlend E. Aasland added the comment:
FYI, the pending release log of the upcoming SQLite 3.36.0 now mentions that
these API's are enabled by default:
https://sqlite.org/releaselog/3_36_0.html
--
___
Python tracker
<https://bugs.python.
Change by Erlend E. Aasland :
--
pull_requests: +24957
pull_request: https://github.com/python/cpython/pull/26368
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
nosy_count: 4.0 -> 5.0
pull_requests: +24961
pull_request: https://github.com/python/cpython/pull/26372
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
pull_requests: +24962
pull_request: https://github.com/python/cpython/pull/26373
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
pull_requests: +24963
pull_request: https://github.com/python/cpython/pull/26372
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
pull_requests: -24962
___
Python tracker
<https://bugs.python.org/issue42792>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend E. Aasland :
--
pull_requests: -24961
___
Python tracker
<https://bugs.python.org/issue42792>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend E. Aasland :
--
pull_requests: +24964
pull_request: https://github.com/python/cpython/pull/26373
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
pull_requests: +24965
pull_request: https://github.com/python/cpython/pull/26373
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
pull_requests: +24959
pull_request: https://github.com/python/cpython/pull/26370
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
pull_requests: +24954
pull_request: https://github.com/python/cpython/pull/26363
___
Python tracker
<https://bugs.python.org/issue42
Erlend E. Aasland added the comment:
Christian, I've got a PR ready for Modules/_ssl.c, but I won't submit it if
you'd rather do it yourself. I'll stay off the sha/md5 types unless you approve
:)
--
nosy: +christian.heimes
___
Python tracker
Change by Erlend E. Aasland :
--
pull_requests: +24960
pull_request: https://github.com/python/cpython/pull/26371
___
Python tracker
<https://bugs.python.org/issue42
Erlend E. Aasland added the comment:
Thanks! Hashlib PR comin' up.
--
___
Python tracker
<https://bugs.python.org/issue42972>
___
___
Python-bugs-list mailin
Erlend E. Aasland added the comment:
Berker, does this look ok to you?
--
title: [sqlite3] consider removing special rollback handling -> [sqlite3]
Remove special rollback handling
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44237>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
pull_requests: +24966
pull_request: https://github.com/python/cpython/pull/26374
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44206>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44207>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
FWIW:
1st shell:
$ ./python.exe -m test test_ssl -u all -m test_get_server_certificate -F
$ ps
[...]
1271 ttys0040:01.00 ./python.exe -m test test_ssl -u all -m
test_get_server_certificate -F
2nd shell:
$ sudo errinfo -p 1271
The syscall trace
Change by Erlend E. Aasland :
--
pull_requests: +25057
pull_request: https://github.com/python/cpython/pull/26462
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44263>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
resolution: -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder: -> Asyncio Event Documentation Links Incorrect
___
Python tracker
<https://bugs.python
Erlend E. Aasland added the comment:
Serhiy/Terry: Is further discussion needed? Can this be closed, or should the
proposed PR be applied (after resolving any issues)?
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue41
Erlend E. Aasland added the comment:
> Is anything left here?
Should the immutable flag also be applied to the heap types converted in and
before Python 3.9 before closing this issue?
--
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
... should perhaps also return True in that case, but it does not seem to have
any thing to say.
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Erlend E. Aasland :
--
pull_requests: +25466
pull_request: https://github.com/python/cpython/pull/26889
___
Python tracker
<https://bugs.python.org/issue43
Erlend E. Aasland added the comment:
Using this patch, I'm (so far) no longer able to reproduce these test failures:
diff --git a/Lib/test/test_ssl.py b/Lib/test/test_ssl.py
index cee97a8302..c9c1546467 100644
--- a/Lib/test/test_ssl.py
+++ b/Lib/test/test_ssl.py
@@ -2443,9 +2443,13 @@ def
Change by Erlend E. Aasland :
--
pull_requests: +25562
pull_request: https://github.com/python/cpython/pull/27001
___
Python tracker
<https://bugs.python.org/issue43
Erlend E. Aasland added the comment:
In inherit_slots() in Objects/typeobject.c, Py_TPFLAGS_HAVE_VECTORCALL
inheritance depends on if the base type is a heap type or not. This aligns with
PEP 590[1]:
Heap types never inherit the vectorcall protocol because that
would not be safe (heap
Erlend E. Aasland added the comment:
I'd be interested in hearing Ronald's opinion. (Added to nosy.)
--
nosy: +ronaldoussoren
___
Python tracker
<https://bugs.python.org/issue44
New submission from Erlend E. Aasland :
Builder: https://buildbot.python.org/all/#/builders/543
The buildbot has failed since 0982ded179f280176868c1c4eccf77bf70687816:
bpo-44032: Move pointer to code object from frame-object to frame specials
array. (GH-26771)
Test stdio log attached
Erlend E. Aasland added the comment:
Fatal Python error: Py_EndInterpreter: thread still has a frame
Python runtime state: initialized
Thread 0x7ff625ee4740 (most recent call first):
File "", line 4 in
make: *** [Makefile:1256: buildbottest] Aborted (core dumped)
progra
Erlend E. Aasland added the comment:
But here, it is write() that returns EPROTOTYPE. See msg394798.
--
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
I haven't observed this issue on the CI since GH-26893 through GH-26896 was
merged. Marking this as resolved. If anyone disagrees, feel free to reopen :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue42238>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
These types now lack the Py_TPFLAGS_IMMUTABLETYPE flag:
## Types converted in Python 3.9
- _abc._abc_data
- _json.Encoder
- _json.Scanner
- _random.Random
- _struct.Struct
- _struct.unpack_iterator
- ast.AST
- posix.DirEntry
- posix.ScandirIterator
Erlend E. Aasland added the comment:
FYI, this buildbot has been green after Victor's git clean adjustment in the
buildbot repo.
I've been trying to reproduce the test_still_running failure on the buildbot,
but have not been able to do so deterministically
Change by Erlend E. Aasland :
--
status: open -> pending
___
Python tracker
<https://bugs.python.org/issue44517>
___
___
Python-bugs-list mailing list
Un
Erlend E. Aasland added the comment:
The effect of PR 26026 is that InterfaceError is no longer raised for fetch
across rollback; instead it is up to SQLite how to handle this:
- for some cases, SQLITE_ABORT or SQLITE_ABORT_ROLLBACK may be returned, which
will result in an OperationalError
Erlend E. Aasland added the comment:
I've crafted a number of rollback tests, but it occurred to me that they are
simply just testing SQLite behaviour; not sqlite3 behaviour. I had to adjust
the tests according to which version of SQLite was used (for example 3.8.7.2
introduced new
Erlend E. Aasland added the comment:
I'm unable to reproduce this on 3.8 though 3.11a0. It's unclear to me if this
even was an issue. (I have no ancient Python versions to test with.)
Closing as out-of-date in a day or two, unless someone disagrees.
--
nosy: +erlendaasland
status
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue9924>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
Regarding the maximum length of an SQL string, quoting from
https://sqlite.org/limits.html:
"The current implementation will only support a string or BLOB length up to
2^31-1 or 2147483647. And some built-in functions such as hex() might fail well
b
Erlend E. Aasland added the comment:
Regarding the maximum length of an SQL string, quoting from
https://sqlite.org/limits.html:
"The current implementation will only support a string or BLOB length up to
2^31-1 or 2147483647. And some built-in functions such as hex() might fail well
b
Change by Erlend E. Aasland :
--
Removed message: https://bugs.python.org/msg393977
___
Python tracker
<https://bugs.python.org/issue44165>
___
___
Python-bug
Erlend E. Aasland added the comment:
SQLITE_TOOBIG is currently mapped to sqlite3.DataError. In order to keep the
current behaviour, DataError must be raised.
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +26339
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27884
___
Python tracker
<https://bugs.python.org/issu
New submission from Erlend E. Aasland :
Currently, we build the first result row in the _pysqlite_query_execute() loop
if sqlite3_step() returned SQLITE_ROW. When the user asks for a row (for
example, using sqlite3.Cursor.fetchone()), this pre-built row is returned, and
the next row
Erlend E. Aasland added the comment:
Historical note:
The current behaviour was introduced in pysqlite v2.0.2 (May 21 2005), in order
to be able to finalise statements and thus close cursors as soon as possible.
However, that effect was cancelled just after a couple of months
Erlend E. Aasland added the comment:
Ref. Serhiy's msg387858 in bpo-43350:
"Maybe the code could be rewritten in more explicit way and call
pysqlite_statement_reset() only when it is necessary [...]"
Currently, we try to reset statements in all "statement exit" ro
Change by Erlend E. Aasland :
--
Removed message: https://bugs.python.org/msg399931
___
Python tracker
<https://bugs.python.org/issue44958>
___
___
Python-bug
Erlend E. Aasland added the comment:
Neat! Thanks :)
--
___
Python tracker
<https://bugs.python.org/issue44972>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend E. Aasland :
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue45025>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
I'd like to propose further enhancements:
- use intermingled declarations in the affected functions; this will make GIL
acquisition stand more out, and it also improves readability and makes it
easier to trace refs
- take the naming step further: I'd
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +26383
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27934
___
Python tracker
<https://bugs.python.org/issu
New submission from Erlend E. Aasland :
Quoting msg400205 by Petr in bpo-42064:
I think the module could use a more comprehensive review for GIL handling,
rather than doing it piecewise in individual PRs. I recommend that any function
passed to SQLite (and only those) should
- be named
Erlend E. Aasland added the comment:
Petr:
> I think the module could use a more comprehensive review for GIL handling
> [...]
I agree. I created bpo-44991 for this.
--
___
Python tracker
<https://bugs.python.org/i
Erlend E. Aasland added the comment:
Thanks, Ronald, that's a nice improvement. I'll create a PR for it.
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Erlend E. Aasland :
--
resolution: fixed ->
status: closed -> open
___
Python tracker
<https://bugs.python.org/issue44997>
___
___
Python-bugs-
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +26427
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/27979
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
> The state doesn't have a refcount, but it is owned by a module object, so
> callback_context should own a reference to the module object.
Would it be sufficient to hold a reference to the connection object? The
connection holds a ref
Change by Erlend E. Aasland :
--
pull_requests: +26531
pull_request: https://github.com/python/cpython/pull/28088
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
Thanks, good catch! I'll add that after PR 27934 is merged.
--
___
Python tracker
<https://bugs.python.org/issue42
201 - 300 of 828 matches
Mail list logo