Francisco Martín Brugué franci...@email.de added the comment:
Hi all,
that is my first contribution. Please let me know if all it's OK.
Thanks in advance !
--
keywords: +patch
nosy: +francismb
Added file: http://bugs.python.org/file8/issue_12185.patch
New submission from Francisco Martín Brugué franci...@email.de:
Hi,
In the page http://docs.python.org/devguide/compiler.html the links in the
references [1]
(http://www.foretec.com/python/workshops/1998-11/proceedings/papers/montanaro/montanaro.html)
and in [Wang97]
(http
Francisco Martín Brugué franci...@email.de added the comment:
The reference for [1] could be changed to:
http://www.python.org/workshops/1998-11/proceedings/papers/montanaro/montanaro.html
--
___
Python tracker rep...@bugs.python.org
http
Francisco Martín Brugué franci...@email.de added the comment:
The reference to [Wang97] could be changed to:
http://www.cs.princeton.edu/research/techreps/TR-554-97
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13117
Francisco Martín Brugué franci...@email.de added the comment:
A patch with the links mentioned above.
--
keywords: +patch
Added file: http://bugs.python.org/file23329/issue13117.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Francisco Martín Brugué franci...@email.de added the comment:
The patch is updated. Let me know if I've understood your review.
Thanks !
--
Added file: http://bugs.python.org/file23370/issue12659_v3.patch
___
Python tracker rep...@bugs.python.org
Francisco Martín Brugué franci...@email.de added the comment:
Hi Éric,
Nice! and thanks for the info: I was just waiting to the check-in to
compare and try further with the tests. Now I can just commit another
patch by synching against the actual tip.
Cheers,
francis
Francisco Martín Brugué franci...@email.de added the comment:
Hi Eli,
I cannot find the file/Distro:
find / -name *'dist-info' 2 /dev/null
/home/ci/cpython/Lib/packaging/tests/fake_dists/grammar-1.0a4.dist-info
/home/ci/cpython/Lib/packaging/tests/fake_dists/towel_stuff-0.1.dist-info
/home
Francisco Martín Brugué franci...@email.de added the comment:
The changeset was:
$ hg tip
changeset: 73075:d4839fea4a5a
[...]
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13193
Francisco Martín Brugué franci...@email.de added the comment:
Where should be the distro?
You won't find it in the hg repository - it gets created by the test, and
then deleted afterwards.
Thanks for the info
The changeset was:
$ hg tip
changeset: 73075:d4839fea4a5a
[...]
That's
Francisco Martín Brugué franci...@email.de added the comment:
Hi Éric,
I've mutated test_support.py a bit and now passes in
https://bitbucket.org/tarek/distutils2 changeset:6c3d67ed3adb.
I've added runTest to Tester, used os.unlink also removed the test fake_dec
test as in support.py from
Francisco Martín Brugué added the comment:
Hi Joar,
just a detail: is there a reason for the asymmetric check for timedelta
isinstance (and raising NotImplemented)? And BTW. isn't a double check for the
__sub__ case (or have I missed something)?
+def __add__(self, other):
+Add
Changes by Francisco Martín Brugué franci...@email.de:
--
nosy: +francismb
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15392
___
___
Python-bugs
Francisco Martín Brugué added the comment:
Hi Terry,
just take/put away some ... (they're not in a special order nor preference,
just some that could 'see' in the browser).
--
keywords: +patch
nosy: +francismb
Added file: http://bugs.python.org/file29553/issue13802.patch
Francisco Martín Brugué added the comment:
In 2.7.3
u'{0:c}'.format(127)
u'\x7f'
u'{0:c}'.format(128)
Traceback (most recent call last):
File pyshell#6, line 1, in module
u'{0:c}'.format(128)
UnicodeDecodeError: 'ascii' codec can't decode byte 0x80 in position 0: ordinal
Francisco Martín Brugué added the comment:
Adding a test that triggers the issue, let me know if is enough.
--
keywords: +patch
Added file: http://bugs.python.org/file29554/issue7267.patch
___
Python tracker rep...@bugs.python.org
http
Francisco Martín Brugué franci...@email.de added the comment:
Hi Adam,
I couldn’t see that from the threat context, I'm new to this and just
wanted to learn the work flow and tools so I've just picked up an
easy issue to start with. Anyway your patch seems more complete
Francisco Martín Brugué franci...@email.de added the comment:
I've attached an alternative test case.
I'm not sure if there is a more robust way to test:
self.assert_('SyntaxError' in err.decode('ascii', 'ignore'))
Due the use of 'SyntaxtError' directly as string. I would prefer something like
Francisco Martín Brugué franci...@email.de added the comment:
Just attaching the review patch
--
Added file: http://bugs.python.org/file22443/issue10206v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10206
Francisco Martín Brugué franci...@email.de added the comment:
On 06/24/2011 06:07 PM, R. David Murray wrote:
self.assertRegex(err.decode('ascii', 'ignore'), 'SyntaxError')
I understand that's the standard way to check if a given failure
happened in the command line or there is also a helper
Francisco Martín Brugué franci...@email.de added the comment:
Adding a test that opens the 24b48k.aif file, gets some information and does
navigation on it. I'm aware that it doesn't triggers any extra failure against
the actual tip (5a1bb8d4afd7) but it does if r72100 is undone (with some
Francisco Martín Brugué franci...@email.de added the comment:
I've started with test for “fake_dec” and “TempdirManager”. Please let me know
if that in the line you want.
Thanks in advance
Francis
--
keywords: +patch
nosy: +francismb
Added file: http://bugs.python.org/file22895
Francisco Martín Brugué franci...@email.de added the comment:
I've updated the patch. From your review: the class 'Mixin' is still
there as the idea was to imitate the use of 'TempdirManager' as is
used in the rest of the tests and test what it's documentation says.
Just let me know your
Francisco Martín Brugué added the comment:
Just curiosity: how relate the magic numbers 10 and 2000 in
test_compiler_recursion_limit to recursion_depth and recursion_limit
Thanks!
--
nosy: +francismb
___
Python tracker rep...@bugs.python.org
Francisco Martín Brugué franci...@email.de added the comment:
I've just updated “test_support.py” and tested against 'default'
and 'distutils2' (after changing the imports).
Just let me know what has to be changed ...
BTW: in distutils2 I get (not because of this change
Changes by Francisco Martín Brugué franci...@email.de:
--
nosy: +francismb
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13953
___
___
Python-bugs
Francisco Martín Brugué franci...@email.de added the comment:
If so, could you provide a patch this time?
Done. The patch is against default.
what about against distutils2? Do you need also a patch for it?
--
Added file: http://bugs.python.org/file24458/issue12659_58bd6a58365d.patch
Francisco Martín Brugué franci...@email.de added the comment:
Hi
here's a patch preview: it has to be re factored further but I stopped here as
some tests failed: the out commented ones ... I've checked twice but I cannot
see any diff, could you check that? Or, has maybe the behavior (due
Francisco Martín Brugué franci...@email.de added the comment:
I've done some cleanups
--
Added file: http://bugs.python.org/file24471/issue13953_bf6f306ad5cf.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13953
New submission from Francisco Martín Brugué franci...@email.de:
Steps to reproduce:
after following the usage instructions from make_perf3.sh go to the the py3
benchmarks directory and run the lib/2to3 tests (python3.2 test.py). The result
are 3 failures and 17 errors. The equivalent procedure
Francisco Martín Brugué franci...@email.de added the comment:
Thank you for the review. Just some questions:
Isn't that what the previous code (doctest code) did?
I thought that the code should be ported as far backwards as possible
and that's why I used the plain assertEqual (I don't know
Francisco Martín Brugué franci...@email.de added the comment:
On 02/11/2012 05:59 AM, Éric Araujo wrote:
BTW: in distutils2 I get (not because of this change):
Actually I did fix that, but depending on your Python version the conditional
in the test may be wrong. What’s the Python version
Francisco Martín Brugué franci...@email.de added the comment:
Does a doc test test the output literally? (I've just always used
unittest)
Ok, thanks
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13953
Francisco Martín Brugué franci...@email.de added the comment:
Hi,
here's a patch with the changes proposed by Terry
Cheers,
francis
--
keywords: +patch
nosy: +francismb
Added file: http://bugs.python.org/file24512/issue13579_80a50b7ad88f.patch
Changes by Francisco Martín Brugué franci...@email.de:
--
nosy: +francismb
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs
Francisco Martín Brugué franci...@email.de added the comment:
I have updated the patch with the documentation changes proposed and also added
a news entry (does a new entry has to be added in some order?).
Thank for the review in advance.
--
Added file: http://bugs.python.org
Francisco Martín Brugué franci...@email.de added the comment:
Updated. The NEWS line is now at the top of the section.
As near as I can tell, the two change block beginning with
+In less formal terms,
[...]
are strictly re-wrapping and no text changes. Correct?
Yes. Just a pydev question here
Francisco Martín Brugué franci...@email.de added the comment:
I suspect mq will confuse make patchcheck (since it looks for
differences between the working copy and the hg branch tip, and there
are no such differences for an applied mq patch).
Does it makes sense to open a feature request
New submission from Francisco Martín Brugué franci...@email.de:
The devguide (http://docs.python.org/devguide/patch.html) recommends the use of
the mercurial “mq” feature to work with patches and that works IMHO very well.
It also states that before sending the patch a sanity check should
Francisco Martín Brugué franci...@email.de added the comment:
Well, it's done:
http://bugs.python.org/issue14053
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13579
Francisco Martín Brugué franci...@email.de added the comment:
Here is a patch that works for me. Please check and review it.
Thanks in advance!
Francis
--
keywords: +patch
Added file: http://bugs.python.org/file24566/issue14053_336a614f35a3.patch
Francisco Martín Brugué franci...@email.de added the comment:
Nice feedback !
One question :
An alternative approach that solves all three of these problems is to
check whether we have any patches applied (using hg qapplied), and if
this is the case, then add --rev qbase to the hg
Francisco Martín Brugué franci...@email.de added the comment:
The patch is updated. Notice about:
[...]Ideally, it
should distinguish between this and other errors by checking the
subprocess's stderr, so that if a different error occurs, we can still
print out the error message
Francisco Martín Brugué franci...@email.de added the comment:
+1
while working on #issue14053 I missed the test for the scripts (in this case
some kind of mocking is needed).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Francisco Martín Brugué franci...@email.de added the comment:
Updated.
Interesting: I saw that repetition but due “[…] Ideally, it
should distinguish between this and other errors by checking the
subprocess's stderr, so that if a different error occurs, we can still
print out the error message
Francisco Martín Brugué franci...@email.de added the comment:
Ok! I haven't added NEWS as I thing is easier for the person that applies the
patch to simply write the line directly there instead of merging. Is that ok?
let me know if something has to be improved.
Thanks again for your
Francisco Martín Brugué franci...@email.de added the comment:
My only concern is communication: how do we tell people working on a tool
that they should write a test in test_tools? I’m not sure they would read
Tools/README; maybe a note at the top of the Python files would work; a note
Francisco Martín Brugué franci...@email.de added the comment:
I have some questions about this:
1) In Lib/test/string_tests.py it says:
“Common tests shared by test_str, test_unicode, test_userstring and
test_string”
but
a) I cannot find test_str
b) string is imported and only some
Francisco Martín Brugué franci...@email.de added the comment:
Hi Éric,
some questions:
1)if test_tools is going to be the test for all the Tools (at least
until it grows to much), shoudn't be be module doc something like “””Tests for
scripts in Tools/**“””
2)is the SkipTest “reindent
Francisco Martín Brugué franci...@email.de added the comment:
Sorry, my fault: I meant Test for Tools instead of Tests for
reindent.py. (Im not talking about the skip message but the test
documentation or the first line 0,0...)
--
___
Python
Francisco Martín Brugué franci...@email.de added the comment:
Patch updated.
BTW, I didn't get any email due the review that Éric did (does one has to be
registered? I've done that now).
--
Added file: http://bugs.python.org/file24689/issue12659_434cd2fedf81.patch
Francisco Martín Brugué franci...@email.de added the comment:
Patch looks good, thanks! BTW are you running a coverage tool to see how
far along we are?
Yes, always. The classes tested in that patch are at 100%.
The overall coverage is:
Name Stmts Miss Cover
Francisco Martín Brugué franci...@email.de added the comment:
I've updated the patch with a test case for 'create_distribution' and one minor
rename.
I personally don't like too much the structure of 'LoggingCatcherTestCase' so
improvements are welcome.
Cheers,
francis
--
Added
New submission from Francisco Martín Brugué franci...@email.de:
I've added a test to Lib/packaging/tests/test_install.py to increase the line
test coverage of lib/packaging.install (and lib/packaging/pypi/wrapper
indirectly from 14% to 80%).
--
components: Tests
files
Changes by Francisco Martín Brugué franci...@email.de:
--
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14183
___
___
Python
Francisco Martín Brugué franci...@email.de added the comment:
Hi Éric,
- # Test that the isntalled raises an exception if the project does not
+ # Test that the installed raises an exception if the project does not
It took me many seconds to find the change :)
The editor told me
Francisco Martín Brugué franci...@email.de added the comment:
Nadeem:
- Don't use spaces around the '=' sign when used to indicate a
keyword argument or a default parameter value.
ok, code formating is not working as expected (at least for lambdas...)
Éric :
If you grep packaging tests
Francisco Martín Brugué franci...@email.de added the comment:
I've updated the patch. Let me know if something has to be changed.
--
Added file: http://bugs.python.org/file24727/issue14183_fbb9847b8f43.patch
___
Python tracker rep...@bugs.python.org
Francisco Martín Brugué franci...@email.de added the comment:
However, I have not actually applied and run test_string.py.
I've applied the issue13579_4720cc9e.patch to the changeset 0554183066b5
and applies without errors for me.
--
___
Python
Francisco Martín Brugué franci...@email.de added the comment:
Ok, I've updated the patch.
The NEWS entry could be:
Issue #13579: string.Formatter now understands the !a conversion specifier.
(not in the patch because AFAIN it makes the merge easier)
Let me know if that's in the line you want
Francisco Martín Brugué franci...@email.de added the comment:
The patch is updated. Please let me know.
And as Éric noticed the NEWS entry could be:
Issue #13579: string.Formatter now understands the a conversion specifier.
Thanks!
--
Added file: http://bugs.python.org/file25425
Francisco Martín Brugué franci...@email.de added the comment:
Just for the record:
Thanks to the old mq workflow in the devguide I've learned about them and I'm
now using it all the time to send and manage the patches.
The only thing is that one should first use the “qqueue” functionality
Francisco Martín Brugué added the comment:
What the status of this issue?:
the changeset http://hg.python.org/distutils2/rev/1e0ca4594a2a mentioned in
msg155480 seems to add tests (but it hasn't been add to the issue explicitly).
Can the issue be closed?
--
nosy: +francismb
Francisco Martín Brugué added the comment:
On Debian:
* Command line 2.7.3
~/Prog/mypy$ python2.7 tem2.py
tem2.py
~/Prog/mypy$ python2.7 -m tem2
/home/ci/Prog/mypy/tem2.py
* IDLE 2.7.3
print(__file__)
Traceback (most recent call last):
File pyshell#0, line 1, in module
print
Francisco Martín Brugué added the comment:
From Idle editor window (F5):
Traceback (most recent call last):
File /home/ci/Prog/mypy/tem2.py, line 1, in module
print(__file__)
NameError: name '__file__' is not defined
--
___
Python tracker
Francisco Martín Brugué added the comment:
Just info:
I still can reproduce that. (It's maybe just something wrong with my setup?)
--
Added file: http://bugs.python.org/file27183/testsResult.txt
___
Python tracker rep...@bugs.python.org
http
Francisco Martín Brugué added the comment:
The actual tip for me is:
ci@random:~/Prog/cpython/benchmarks/py2$ hg tip
changeset: 164:61768f86170c
tag: tip
user:Brett Cannon br...@python.org
date:Fri Aug 31 18:58:24 2012 -0400
summary: Allow for the specification
Francisco Martín Brugué added the comment:
The box is a debian (wheezy):
ci@random:~/Prog/cpython/benchmarks/py2$ uname -a
Linux random 3.2.0-3-amd64 #1 SMP Mon Jul 23 02:45:17 UTC 2012 x86_64 GNU/Linux
The source repository dir:
ci@random:~/Prog/cpython/benchmarks/py2$ dir
lib LICENSE.txt
Francisco Martín Brugué added the comment:
So the tests failed but the benchmarks finished without issue?
Yes. But the apparent diff is that I've used 2.6.8
If the benchmarks run without errors then I'm satisfied, else we figure
out what this fails ever
or we have a already translated copy
Francisco Martín Brugué added the comment:
I've to say that I also ran into that by following coverage numbers and as a
newbie is not so easy to see what Raymond told. IMHO that information could be
put as a comment.
Regards
francis
--
nosy: +francismb
Francisco Martín Brugué added the comment:
Actual tip:
changeset: 87276:2012e85638d9
date: Tue Nov 19 11:43:38 2013 -0800
It's a fresh clone, then:
make clean
./configure --with-pydebug
make -j4
./python -OO -m test -v test_email
== CPython 3.4.0a4+ (default:2012e85638d9, Nov 19 2013, 22:40:39
Francisco Martín Brugué added the comment:
small correction:
a fresh clone, then:
./configure --with-pydebug
make -j4
./python -OO -m test -v test_email
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19626
New submission from Francisco Martín Brugué:
I've just installed Cpython 2.7.6 32bit on Windows64, run the tests [1]
and some of them failed. Some of them seems related to audiodata not beeing
installed.
.\python.exe Lib\test\regrtest.py -v
== CPython 2.7.6 (default, Nov 10 2013, 19:24:18
Changes by Francisco Martín Brugué franci...@email.de:
Added file: http://bugs.python.org/file32942/failed_test_sunau.txt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19866
Changes by Francisco Martín Brugué franci...@email.de:
Added file: http://bugs.python.org/file32943/failed_test_wave.txt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19866
Francisco Martín Brugué added the comment:
On 12/03/2013 07:21 PM, Zachary Ware wrote:
Zachary Ware added the comment:
Francis, would you like to work on a patch for this? The change should go in
Tools/msi/msi.py, if I'm not mistaken
Francisco Martín Brugué added the comment:
If performance is the reason for the feature: My impression is that
the goal of the struct module is not necessarily top performance.
I'm not sure if it applies but on #19905 (message 205345 [1])
is said its a dependency for that issue
[1] http
Francisco Martín Brugué added the comment:
Just feedback on windows7. I tried the tests inside IDLE and done 'Run Module'
(F5) (deleting the directories between tests):
test_A:
import os, shutil
os.makedirs('foo')
os.makedirs('bar/boo')
shutil.move('foo/', 'bar/')
test_B:
import os, shutil
Francisco Martín Brugué added the comment:
First I've reviewed #msg205585 again (no patch applied). Notice that Traceback
was not accurate:
test_A:
os.makedirs('foo')
os.makedirs('bar/foo')
shutil.move('foo/', 'bar/')
Traceback (most recent call last):
File pyshell#15, line 1, in module
Francisco Martín Brugué added the comment:
A small question related to: zipfile_276_filename_mismatch_v3.patch
--- a/zipfile.pyWed Apr 30 11:44:38 2014
+++ b/zipfile.pyWed Apr 30 15:10:38 2014
@@ -970,10 +970,10 @@
if fheader[_FH_EXTRA_FIELD_LENGTH
Francisco Martín Brugué added the comment:
The formatter module was deprecated in Python 3.4 and is scheduled
for removal in Python 3.6. See [1] and [2].
---
[1] https://docs.python.org/3/library/formatter.html#module-formatter
[2] https://docs.python.org/3/whatsnew/3.4.html#deprecated
Francisco Martín Brugué added the comment:
Hi,
sorry if it's trivial but shouldn't we add a 'shifted_true' test
some were to make sure that this behavior change gets noticed next time?
def test_shifted_true(self):
self.assertEqual(True 0, 1)
self.assertEqual(True 1, 2
Francisco Martín Brugué added the comment:
I Victor you were so fast, I started with one patch also in bool (at least the
place was right). The problem is that I was getting some extrage (for me at
least). As far I hat:
def test_shifted_true(self):
with self.assertRaises
Francisco Martín Brugué added the comment:
What we want to test is that the return value is of type 'int', which is what
Victor's test checks.
Thank you for the explanations!
for 2.7.6 type(2 62) is type 'long' and type(2 61) is
type 'int' (I suppose it's analogous in a 32 bit machine
Francisco Martín Brugué added the comment:
Hi,
just a question:
the status of this issue is pending but it seems to be already
resolved/duplicated. Means that this issue can be closed?
Thansk in advance!
--
nosy: +francismb
status: pending - open
85 matches
Mail list logo
