Georg Brandl added the comment:
There are also several PyArg_ParseTuple-using functions that have the
same kind of name mismatch, but since the names don't really mean
anything on the Python side when they're positional-only, I don't feel
too bad about changing them to make them make
New submission from Georg Brandl:
In the presence of [ ] , clinic generates PyTuple_Size() calls.
Since argument tuples always are tuples, you can use the macro form
PyTuple_GET_SIZE() to speed it up.
--
assignee: larry
messages: 208007
nosy: georg.brandl, larry
priority: normal
New submission from Georg Brandl:
I had specified c_default=-1 (note missing quotes) somewhere, and it raises an
exception during the clinic --make run; there was no indication which file/line
this was on.
Suggested patch attached.
--
assignee: larry
files
Changes by Georg Brandl ge...@python.org:
Removed file: http://bugs.python.org/file33425/heapq_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20186
Changes by Georg Brandl ge...@python.org:
Removed file: http://bugs.python.org/file33419/mathmodule_part1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20186
Changes by Georg Brandl ge...@python.org:
Removed file: http://bugs.python.org/file33422/csv_module_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20186
Changes by Georg Brandl ge...@python.org:
Removed file: http://bugs.python.org/file33423/tracemalloc_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20186
Changes by Georg Brandl ge...@python.org:
Removed file: http://bugs.python.org/file33424/io_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20186
Changes by Georg Brandl ge...@python.org:
Removed file: http://bugs.python.org/file33426/lsprof_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20186
Georg Brandl added the comment:
OK, new patches coming in.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20186
___
___
Python-bugs-list mailing
Changes by Georg Brandl ge...@python.org:
Removed file: http://bugs.python.org/file33429/sys_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20182
Changes by Georg Brandl ge...@python.org:
Removed file: http://bugs.python.org/file33428/signal_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20182
Georg Brandl added the comment:
New patch.
In selectmodule.c I haven't touched devpoll and kqueue, which I can't compile
here.
_hashopenssl does weird things with macros, I'm waiting with that.
--
Added file: http://bugs.python.org/file33441/modules_issue20182.patch
Georg Brandl added the comment:
Actually I put all I have in one. Rietveld doesn't care.
The mathmodule still awaits some kind of solution for the macro atrocities.
Objects will be attacked next.
--
Added file: http://bugs.python.org/file33442/modules_issue20186.patch
Georg Brandl added the comment:
Looking at _csv.c, I see a few functions using PyArg_UnpackTuple. They should
be converted too, no?
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20186
Georg Brandl added the comment:
Attached part 1 of mathmodule (17 functions).
I'm looking forward to a suggestion for handling the rest (see FUNC1/1A/2
macros :)
--
keywords: +patch
Added file: http://bugs.python.org/file33419/mathmodule_part1.patch
Georg Brandl added the comment:
Wow. I never knew about PyArg_UnpackTuple. You're right, those
should be converted too. Hooray, more entry points to convert.
I'll write something up for the howto about UnpackTuple.
One thing to note is that (at least in math) many instances
Georg Brandl added the comment:
Closing for the hopefully final time. Anatoly, if you keep reopening this
ticket you have to expect removal of tracker privileges.
--
nosy: +georg.brandl
resolution: postponed - rejected
status: open - closed
Changes by Georg Brandl ge...@python.org:
--
nosy: -georg.brandl
versions: -Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19810
Georg Brandl added the comment:
``False`` is actually the preferred way, being shorter and easier to read (and
we don't need to link to the documentation for False).
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http
Georg Brandl added the comment:
When citing a link, it's customary to give at least a comment *why* you are
citing it.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19557
Georg Brandl added the comment:
For a true security fix, the default for check_hostname would have to be True.
However, that will create a lot of backward compatibility problems for
questionable gain.
I think Larry should make an exception for 3.4 and allow this new feature
Georg Brandl added the comment:
Hmm, sucks.
Benjamin, can you come up with a fix? I'll give it a few weeks to wait for
more potential regressions and then do a 3.3.4.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19729
Georg Brandl added the comment:
As Victor says, I'm not keen on those examples in the stdlib that do this, I'd
rather get rid of all of them.
And yes, doctests are only useful if they are written in the simplest possible
way. Otherwise unittest style tests should be preferred
Georg Brandl added the comment:
Thanks, should be fixed now.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19622
Georg Brandl added the comment:
I think so.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19691
___
___
Python-bugs-list
Georg Brandl added the comment:
LGTM.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19762
___
___
Python-bugs-list mailing
Georg Brandl added the comment:
Well, there's no bug here: it's what you get when you call a library the same
as a builtin :)
--
resolution: - wont fix
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Georg Brandl added the comment:
-1.
First, I don't think stdlib modules should be forced to use old conventions and
give up on new features just because of backports (the import changes are fine
obviously).
Second, it's putting unreasonable constraints on CPython developers to know
which
Georg Brandl added the comment:
That would be correct as a handwaving description, but it's wrong as a formal
spec. The or_expr already includes the possibility of a tuple; there is no
exec( token etc.
--
nosy: +georg.brandl
resolution: - works for me
status: open - closed
Georg Brandl added the comment:
Sounds good.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19508
___
___
Python-bugs-list
Georg Brandl added the comment:
Can be closed?
--
nosy: +georg.brandl, vinay.sajip
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19504
Georg Brandl added the comment:
You mean for PyRun_InteractiveOneObject()? Oh, it can be made private, but
what is the problem of adding yet another PyRun_Interactive*() function?
There are already a lot of them :-)
And this is a problem. Newly added function is not even documented
Georg Brandl added the comment:
Whatever we decide to do here, it **must** also be done for antigravity.py.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19499
Georg Brandl added the comment:
IMO the fact that importing happens only once is also a very important one, so
much the better this helps in learning it early.
The bad thing is that opening this.py to see what's happening will not really
enlighten the beginner
Georg Brandl added the comment:
I haven't looked at 3.2 buildbots since the last point release.
There will be only security releases in the future, still it'd be nice to be
able to test on different bots.
Antoine, can you fix this on the buildmaster or need I apply the patch in the
3.2
New submission from Georg Brandl:
From Mark Summerfield:,
The Quick search box is really useful, but it is annoying that its
position varies from page to page. On pages with long tables of
contents it is often out of sight.
Why not put it above the Table of Contents. That way
Georg Brandl added the comment:
Hi Nitin,
a // b is defined as the floor division operation, same as what math.floor(a
/ b) gives: the largest integer = a / b.
-7/2 is -3.5, the largest integer = -3.5 is -4.
--
nosy: +georg.brandl
resolution: - invalid
status: open - closed
Georg Brandl added the comment:
This specialized use case has no chance of being added to the very general dict
object.
But have a look at the collections.Counter class which does exactly what you
propose for positive values and the +/- operations.
--
nosy: +georg.brandl
Georg Brandl added the comment:
Is this backportable?
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19428
___
___
Python
Georg Brandl added the comment:
Should be done.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18964
___
___
Python-bugs
Georg Brandl added the comment:
#19227 must be solved before anything is backported to the security branches.
--
dependencies: +test_multiprocessing_xxx hangs under Gentoo buildbots
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Georg Brandl added the comment:
Also merged to default.
--
versions: -Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16041
Georg Brandl added the comment:
Also merged to default.
--
versions: -Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17997
Georg Brandl added the comment:
Also merged to default.
--
versions: -Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16040
Georg Brandl added the comment:
Also merged to default.
--
versions: -Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16039
Georg Brandl added the comment:
Also merged to default.
--
versions: -Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16037
Georg Brandl added the comment:
OK, I'm going to apply atfork_prepare.patch for 3.3.3rc1. If there is any
indication of a continuing problem, we'll revert the whole re-seeding code for
the final.
--
___
Python tracker rep...@bugs.python.org
http
Georg Brandl added the comment:
For some reason, this still fails on the OpenIndiana builder:
http://buildbot.python.org/all/builders/AMD64%20OpenIndiana%203.3/builds/1104/steps/test/logs/stdio
--
nosy: +georg.brandl
status: closed - open
___
Python
Georg Brandl added the comment:
Ahh, the newly committed test for merge needs the same guard as the other
'dict' calls! I'll fix that in the release clone for 3.3.3 final.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Georg Brandl added the comment:
Well, if the functions are part of the stable ABI (which it seems they are, as
they don't fall under some exclusion defined by PEP 384) they shouldn't be
removed if we take PEP 384 seriously.
--
nosy: +loewis
Georg Brandl added the comment:
Terry, thanks for your explanation; I was trying to find some time to write
something similar...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17294
Georg Brandl added the comment:
Hi Chris, your commit is a bit hard to review due to all the unrelated spacing
changes. I assume this is done automatically by your editor? It's probably
best to switch off that feature for CPython development
Georg Brandl added the comment:
While reviewing: is it intended that the filter is only called for directories
and not for individual files?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19274
Georg Brandl added the comment:
Yep (should there be a policy about this somewhere)?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15663
Georg Brandl added the comment:
I'm sorry if I stepped on your toes, but I didn't ignore your patch. If I've
failed to follow the right procedure, it is due to inexperience, not malice.
You yourself suggested it was only a temporary version just good enough to
get the module committed
Georg Brandl added the comment:
The rst file is missing from your patch.
I already posted a patch with statistics.rst five days ago. I have no idea why
you ignored it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18606
Georg Brandl added the comment:
Looks fine but -- as a new feature -- is 3.4 only, and needs docs and tests.
--
nosy: +georg.brandl
stage: - patch review
versions: +Python 3.4 -Python 2.7
___
Python tracker rep...@bugs.python.org
http
Georg Brandl added the comment:
Thanks for the suggestion; the parameters have already been added in Python
3.3, see http://docs.python.org/3/library/zlib.html#zlib.compressobj.
--
nosy: +georg.brandl
resolution: - out of date
status: open - closed
Georg Brandl added the comment:
Actually, compressobj() has always supported up to five arguments (named level,
method, wbits, memlevel, strategy); I'll document this for 2.7 for issue 19277.
The new thing in 3.3 are support for keyword arguments and the zdict parameter
Georg Brandl added the comment:
Tyler, thanks for the suggestion. However it doesn't really solve the issue:
the parameter order is the opposite of the current doc text (and your suggested
text).
--
nosy: +georg.brandl
___
Python tracker rep
Georg Brandl added the comment:
Ah yes, I somehow missed running perf.py itself with Python 3.
Should be fixed now; adapting the #19108 patch should be easy enough.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19079
Changes by Georg Brandl ge...@python.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19079
Georg Brandl added the comment:
Python-ast.c can't be changed; it is auto-generated. But the whole thing can
be handled in compile.c I think -- see attached patch. Test suite passes
(except for test_dis, which checks compilation result against a given list of
bytecodes).
--
nosy
Georg Brandl added the comment:
I'll make a complete patch with test suite additions (and fixing test_dis) if
this is deemed to be a correct approach.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11471
Changes by Georg Brandl ge...@python.org:
--
nosy: +bquinlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14407
___
___
Python-bugs-list mailing
Changes by Georg Brandl ge...@python.org:
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11646
___
___
Python-bugs-list
Georg Brandl added the comment:
Is this still the case with Python 2.7?
--
nosy: +georg.brandl
resolution: - out of date
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7979
Changes by Georg Brandl ge...@python.org:
--
assignee: - dmalcolm
nosy: +dmalcolm
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15817
Georg Brandl added the comment:
If you know you have an expression and would like the value, you should use the
eval mode.
In the case of single, you can adapt sys.displayhook to change where to print
(if at all) the values. Note that single sometimes prints multiple values
(try e.g. for i
Changes by Georg Brandl ge...@python.org:
--
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17095
___
___
Python-bugs-list
Changes by Georg Brandl ge...@python.org:
--
nosy: +eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16425
___
___
Python-bugs-list
Changes by Georg Brandl ge...@python.org:
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16845
___
___
Python-bugs-list
Georg Brandl added the comment:
The refs output is only active in debug mode, and only for debugging. It is
printed directly to stderr using C fprintf(), I don't think it's worth the
complication.
--
nosy: +georg.brandl
resolution: - wont fix
status: open - closed
Changes by Georg Brandl ge...@python.org:
--
nosy: +bethard
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15613
___
___
Python-bugs-list mailing
Changes by Georg Brandl ge...@python.org:
--
nosy: +sbt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15440
___
___
Python-bugs-list mailing list
Changes by Georg Brandl ge...@python.org:
--
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15371
___
___
Python-bugs-list
Georg Brandl added the comment:
Sounds good to me.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18300
___
___
Python-bugs
Changes by Georg Brandl ge...@python.org:
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18209
___
___
Python-bugs-list mailing
Changes by Georg Brandl ge...@python.org:
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18068
___
___
Python-bugs-list mailing
Changes by Georg Brandl ge...@python.org:
--
nosy: +barry, ned.deily
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18096
___
___
Python-bugs-list
Georg Brandl added the comment:
Only affects 3.2, so this won't be fixed anymore.
--
nosy: +georg.brandl
resolution: - out of date
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18254
Georg Brandl added the comment:
Last desperate ping for 3.4?
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2919
Georg Brandl added the comment:
See attached patch, it handles this like all other builtins that don't support
keyword arguments in their constructor.
--
keywords: +patch
nosy: +georg.brandl, pitrou
versions: +Python 2.7, Python 3.3
Added file: http://bugs.python.org/file32118
Georg Brandl added the comment:
aside The rXXX notation is reserved for SVN revision numbers, which are
unambiguous. The revision numbers in Mercurial are specific to each clone.
/aside
Other than that, LGTM.
--
nosy: +georg.brandl
___
Python
Changes by Georg Brandl ge...@python.org:
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19258
___
___
Python-bugs-list
Changes by Georg Brandl ge...@python.org:
--
nosy: +tim.peters
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19138
___
___
Python-bugs-list
Georg Brandl added the comment:
Agreed. This is not really a bugfix.
--
resolution: - wont fix
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18209
Georg Brandl added the comment:
Good point, that is pointless in __init__().
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17765
___
___
Python
Changes by Georg Brandl ge...@python.org:
Added file: http://bugs.python.org/file32119/no_weakref_kwargs_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17765
Georg Brandl added the comment:
Updated patch with test suite update.
--
Added file: http://bugs.python.org/file32120/if_else_nojump_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11471
Georg Brandl added the comment:
Issue #6624 wasn't an issue, it should have been closed-invalid :)
But you're right, a test case is needed, see new patch.
--
Added file: http://bugs.python.org/file32121/seterror_fix_2.patch
___
Python tracker rep
Georg Brandl added the comment:
Yep :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11471
___
___
Python-bugs-list mailing list
Unsubscribe
Georg Brandl added the comment:
Serhiy, you're welcome to set issues to pending, but please don't forget to
close them after a certain time...
--
status: pending - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1575020
Changes by Georg Brandl ge...@python.org:
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1575020
___
___
Python-bugs-list
Georg Brandl added the comment:
Thank you for all the effort you put into this!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18758
Georg Brandl added the comment:
Some new (I assume) ResourceWarnings from test_wave:
/home/gbr/devel/python/Lib/unittest/case.py:571: ResourceWarning: unclosed file
_io.BufferedWriter name='@test_1974_tmp'
testMethod()
/home/gbr/devel/python/Lib/chunk.py:61: ResourceWarning: unclosed file
Georg Brandl added the comment:
Shouldn't converttuple() in getargs.c set levels[1] = 0; after second
levels[0] = i+1;?
I think it is fine, since convertitem() or converttuple() called from
convertitem() will set their levels[0] (which is levels[1] in the original
context) to zero on error
Georg Brandl added the comment:
Closing this one as Fixed, then. Thanks everybody.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18521
Georg Brandl added the comment:
#8998 has been closed (among others due to legal concerns), so this need not be
kept open.
--
nosy: +georg.brandl
resolution: - wont fix
status: open - closed
___
Python tracker rep...@bugs.python.org
http
501 - 600 of 5083 matches
Mail list logo
