[issue31183] `Dis` module doesn't know how to disassemble async generator or coroutine objects

2017-08-11 Thread George Collins
Changes by George Collins <g...@syncosmic.io>: -- pull_requests: +3114 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue31183> ___ _

[issue31183] `Dis` module doesn't know how to disassemble async generator or coroutine objects

2017-08-12 Thread George Collins
George Collins added the comment: Hm--either/both? I encountered it as a bug ("dis works on my generator object and my async generator function, why does it break on my async generator object?") but strictly speaking it's a new feature (just as issue21947 was). To my mind, adding

[issue31183] `Dis` module doesn't know how to disassemble async generator or coroutine objects

2017-08-11 Thread George Collins
New submission from George Collins: Issue 21947 informed the `dis` module about the `gi_code` attribute, which stores code objects for generator objects. This allows inspection of generator objects, not just functions which return them. However, asynchronous generator objects use `ag_code

[issue31183] `Dis` module doesn't know how to disassemble async generator or coroutine objects

2017-08-12 Thread George Collins
George Collins added the comment: Makes sense. I'll update the PR in a bit, and if anyone is hitting this repeatedly and thinks it should be added to 3.6 they can advocate for a policy change in the maintaining-consistency-with-previous-new-features corner case. Thanks, all