[issue1182143] making builtin exceptions more informative
George Jenkins added the comment: Reviewer please :) (or, advice on how I can get this to proceed, thx) -- ___ Python tracker <http://bugs.python.org/issue1182143> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1182143] making builtin exceptions more informative
George Jenkins added the comment: Thanks for the response. In terms of python API changes - I exposed the 'name' attribute on UnboundLocalError and NameError exceptions. (This can be seen (& is verified) by the changes to test_exceptions.py exceptions test cases in the patch) In terms of the wider changes in the patch - I factored UnboundLocalError and NameError to have specific native implementations, rather than been based off SimpleExtendsException. And thus able to accept the name of the variable causing the exception. And I agree with your comment on the exact API never been agreed on. Since there are now native implementations of UnboundLocalError and NameError, I can happily change their implementation to expose whatever can be decided to be better (comments?!) Thanks, George -- ___ Python tracker <http://bugs.python.org/issue1182143> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1182143] making builtin exceptions more informative
George Jenkins added the comment: Bump on this one please -- ___ Python tracker <http://bugs.python.org/issue1182143> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1182143] making builtin exceptions more informative
George Jenkins added the comment: Hi, I attempted a solution for this a while back Attached is a (git diff based) patch for review Changes can also been seen at: https://bitbucket.org/bloomberg/cpython/pull-request/2/http-bugspythonorg-issue1182143-add-name/diff (but note the changes in Misc/NEWS and Tools/msi/msi.py are not related / somehow got pulled into my changes by mercurial) Please review/let me know of any other process required. Thanks! -- keywords: +patch nosy: +George Jenkins versions: +Python 3.5 -Python 3.2 Added file: http://bugs.python.org/file38551/Issue1182143_1.patch ___ Python tracker <http://bugs.python.org/issue1182143> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1182143] making builtin exceptions more informative
George Jenkins added the comment: Add patch generated via mercurial -- Added file: http://bugs.python.org/file38872/Issue1182143_1hg.patch ___ Python tracker <http://bugs.python.org/issue1182143> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1182143] making builtin exceptions more informative
George Jenkins added the comment: Heh, just noticed this issue passed its 10 year anniversary! If someone has time to review my patch, that would be much appreciated. Thanks! -- ___ Python tracker <http://bugs.python.org/issue1182143> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com