Gregory P. Smith added the comment:
fyi - while I still need to update it now that 3.2 final has been released, the
http://code.google.com/p/python-subprocess32/ project has a backport of the
_posixsubprocess stuff from python 3.2 for use on Python 2.x
Gregory P. Smith added the comment:
There is no OS API call to provide a *safe* way to get a list of all open file
descriptors as part of POSIX in general that can be called after the fork() and
before the exec(). It must be async signal safe. The closefrom() call
available in Solaris and
Gregory P. Smith added the comment:
According to http://www.unix.com/man-page/All/3c/closefrom/ closefrom() is not
async-signal-safe. :(
--
___
Python tracker
<http://bugs.python.org/issue11
Gregory P. Smith added the comment:
subprocess in 3.2 bug from the looks of it. not sure if 2.7 or 3.1 are
impacted at all, i'll remove them from the list after confirming.
--
assignee: -> gregory.p.smith
___
Python tracke
Gregory P. Smith added the comment:
Could you add me as a member or admin on the mrab-regex-hg project? I've got a
few things I want to fix in the code as I start looking into the state of this
module. gpsmith at gmail dot com is my google account.
There are some fixes in the ups
Gregory P. Smith added the comment:
Okay. Can you push your setup.py and README and such as well? Your pypi
release tarballs should match the hg repo and ideally include a mention of
what hg revision they are generated from. :)
-gps
On Mon, Mar 14, 2011 at 5:25 PM, Matthew Barnett wrote
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
keywords: +patch
nosy: +gregory.p.smith
Added file: http://bugs.python.org/file21215/_cursesmodule.c.diff
___
Python tracker
<http://bugs.python.org/iss
Changes by Gregory P. Smith :
--
assignee: gregory.p.smith ->
nosy: +loewis
___
Python tracker
<http://bugs.python.org/issue1006238>
___
___
Python-bugs-lis
Changes by Gregory P. Smith :
--
assignee: gregory.p.smith ->
nosy: +loewis
___
Python tracker
<http://bugs.python.org/issue3718>
___
___
Python-bugs-list mai
Gregory P. Smith added the comment:
a test would still be a good thing but this should be fixed regardless.
--
resolution: -> accepted
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Gregory P. Smith added the comment:
assertCountEqual has been released in 3.2 as the new name. close this?
--
___
Python tracker
<http://bugs.python.org/issue10
Changes by Gregory P. Smith :
--
resolution: -> fixed
status: open -> closed
versions: -Python 2.7, Python 3.1
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
I added some comments on the review for 10812_v5.patch. not sure why v6
doesn't have a review link. Overall, very nice after addressing the few
comments I had.
btw, can you sync this up with the hg tip (3.3) now while addressing the above?
I'
Gregory P. Smith added the comment:
ross's patch looks good to me.
Isn't the behavior just plain broken in 3.1 and 3.2? The docs say that the
default bufsize=0 is unbuffered in Popen but the implementation has that nasty
XXX to make it line buffered instead of unbuffered in
Gregory P. Smith added the comment:
to get that behavior, change the =1 default to =io.DEFAULT_BUFFER_SIZE in
ross's patch.
--
___
Python tracker
<http://bugs.python.org/is
Gregory P. Smith added the comment:
yeah i figured importing io from os at the top level might be a problem. it is
not important for the default to be that exact value, even something safely on
the small side like 512 will work. but we could just have the default be set
in the code by doing
Gregory P. Smith added the comment:
not yet, thanks for the reminder. if any other committers feel like jumping on
this and doing it before I get around to it, feel free.
--
___
Python tracker
<http://bugs.python.org/issue11
Gregory P. Smith added the comment:
heh yeah. while all hash functions do have internal state and someone
could conceivably want to store such a state (it basically amounts to
queued up partial block of input data if any and the current starting
IV) there are not consistent APIs to expose that
Gregory P. Smith added the comment:
Adding that check with an exception to selectmodule.c is a good idea.
i like your patch.
--
___
Python tracker
<http://bugs.python.org/issue11
Gregory P. Smith added the comment:
Those tests make sense to me.
--
Added file: http://bugs.python.org/file21875/unnamed
___
Python tracker
<http://bugs.python.org/issue6721>
___Those tests make sense
Gregory P. Smith added the comment:
I didn't initially like the idea of __exit__ blocking on another
process... but the zombie issue is real does make me think we should
reconsider this and have it wait().
It is a backwards incompatible change if anyone has started using the
Popen co
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue12044>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
did my commits in the reverse order (default before 3.2), oops. this is fixed.
this wasn't ever in 2.7 so no need for the documentation note. i'm not
worried about adding a note about 3.2.0 vs 3.2.1 beyond the mention in
Misc/NEWS as this
Gregory P. Smith added the comment:
That looks better. :)
btw, that eintr_retry utility probably deserves to be in a more
prominent place in the stdlib but I don't have a good suggestion as to
where at the moment. I believe similar code exists in many places in
the code base.
If it i
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
if you used the pipe approach you'd need to deal with the case of the write
blocking (or failing if nonblocking) when the pipe buffer is full. also you'd
need to block signals around a fork and reinitialize the pipe in the child
before reenabli
Gregory P. Smith added the comment:
if someone comes up with a situation where this is a real problem, feel free to
reopen it.
--
resolution: -> wont fix
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
We should ensure that the first differing character in the string is always
included in what is displayed as a diff. if we're going to shorten a string we
should elide something that matches.
--
nosy: +gregory.p.
Gregory P. Smith added the comment:
I added these with conditional compilation via autoconf for use on posix
systems. These methods are not IPv6 specific.
Anyone who wants to see them supported on windows will need to add whatever
conditional compilation magic is required to enable that on
Gregory P. Smith added the comment:
thanks i'll take a look at OS X here. obviously i did development and
testing on linux.
--
___
Python tracker
<http://bugs.python.org/issu
Gregory P. Smith added the comment:
unassigning, i don't have time to tackle netbsd issues right now.
--
assignee: gregory.p.smith ->
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
Misc/build.sh seems obsolete... its full of references to svn and we have had
buildbots for many years now.
The buildbots do not seem to be hitting this issue. Is there a real failure
you can point at somewhere? if so please reopen this with a pointer to
Gregory P. Smith added the comment:
unassigning, i don't have time for this one right now. doubtful anyone is
going to jump in for 3.2.1 given rc1 is being prepared right now. :)
General recommendation: don't use SimpleHTTPServer in production.
--
assignee: grego
Gregory P. Smith added the comment:
that patch looks good. though I do wish we had a function similar to
PyObject_AsStringEncodedFSDefault() so that the ParseTuple call wasn't needed
for this relatively common operation when interfacing with system library calls
that deal in C st
Changes by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue1597850>
___
___
Python-bugs-list mailing list
Unsub
Gregory P. Smith added the comment:
I've committed this feature just in time for 3.2beta1 (so it can't be said i'm
adding a feature after the beta ;). r87026
It still needs tests and documentation. It doesn't break any existing tests.
I'll take care
Gregory P. Smith added the comment:
r87027 has it for py3k / 3.2. needs backporting to the other branches.
--
nosy: +gregory.p.smith
versions: -Python 3.2
___
Python tracker
<http://bugs.python.org/issue10
Gregory P. Smith added the comment:
I have to agree that the name assertCountEqual does not work well for me as
something I can read and really comprehend what it is going to do without
searching for the docs or implementation to double check. (not that
assertItemsEqual did either). '
Gregory P. Smith added the comment:
fyi - since I didn't chime in earlier on this: I think you made the right
choice with what was decided in msg122413 and implemented in the renaming done
in r86910 and the work done in issue10242.
--
___
P
Gregory P. Smith added the comment:
Paul & Giovanni: yes I hadn't given the windows side of things any thought when
I made the change for beta1.
Milko: The DISREGARD_FDS approach is basically what I was intending to do.
Also, there really wasn't any objection to going ahead an
Gregory P. Smith added the comment:
The close_fds default has been fixed in r87206 to remove the DeprecationWarning
and remain False on Windows. It changes to True on POSIX.
--
___
Python tracker
<http://bugs.python.org/issue7
Gregory P. Smith added the comment:
Milko's subprocess-00/01/02 patch set have been committed with minor
modifications in r87207 & r87208. Thanks, especially for the test cases!
Is there anything else left that we know about for
Gregory P. Smith added the comment:
Bug fix, unittest and documentation added in r87229. Thanks!
--
resolution: -> accepted
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Gregory P. Smith added the comment:
I updated the documentation and changed the close_fds default on Windows to be
True when possible per Giovanni's suggestion in r87229. That keeps the API and
defaults as consistent as possible across all platforms.
--
resolution: ->
Gregory P. Smith added the comment:
P.S. Yes I will be backporting all of this to subprocess32.
--
___
Python tracker
<http://bugs.python.org/issue7213>
___
___
Gregory P. Smith added the comment:
r87233 fixes the OSError escaping from wait() issue when SIGCLD is set to be
ignored. (to appear in 3.2beta1; it is a candidate for backporting to 3.1 and
2.7)
--
___
Python tracker
<http://bugs.python.
Gregory P. Smith added the comment:
sorry, i meant 3.2beta2 above.
release27-maint: r87234 targeting 2.7.2
release31-maint: r87235 targeting 3.1.4
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.p
Gregory P. Smith added the comment:
rhettinger's fastcount.patch looks good to me. a couple style nits but they're
minor.
no space between if and (? yuck. short variable names like "it"? yuck.
but the code looks good otherwise. i'm all for it.
Gregory P. Smith added the comment:
Ripping HTTP "0.9" support _out_ flys directly in the face of "be lenient in
what you accept and strict in what you produce."
I do not mind removing support from http.server. But http.client needs to be
able to communicate with any r
Gregory P. Smith added the comment:
Given the 6961 issue I'm happy to change my position and say we nuke the 0.9
client support.
Anyone who _needs_ that can grab this old code or write trivial code for their
poor server's needs.
--
Gregory P. Smith added the comment:
In your back traces notice that the size= argument is clearly nonsensical.
Regardless, i can't reproduce this on any of my systems (I don't have a suse
system of any sort). If that is the only place you are seeing this I strongly
suspect
Gregory P. Smith added the comment:
unassigning, i don't had time to look at this one.
--
assignee: gregory.p.smith ->
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
As belopolsky said... *please* move this development into version control. Put
it up in an Hg repo on code.google.com. or put it on github. *anything* other
than repeatedly posting entire zip file source code drops to a bugtracker
Gregory P. Smith added the comment:
FWIW, the example pasted in the bug was the smallest one he could come up
with. in reality we were never calling .__del__() explicitly. We ran into
the problem due to a __del__ method triggering a __getattr__ call and the
__getattr__ ending up in infinite
Gregory P. Smith added the comment:
it happens on 3.2 (py3k head).
--
Added file: http://bugs.python.org/file20208/unnamed
___
Python tracker
<http://bugs.python.org/issue10794>
___it happens on 3.2 (py3
Gregory P. Smith added the comment:
The only thing that could cause this error is if the Modules/_posixsubprocess.c
subprocess_cloexec_pipe function fails either in the pipe2() call or if
HAVE_PIPE2 is not defined one of the fcntl() calls.
Can you look to see if HAVE_PIPE2 is defined?
I
Gregory P. Smith added the comment:
This bug has brought up a broader issue. the pipe2 syscall on Linux is very
new. It is perfectly reasonable to expect a Python binary will be compiled
against a C library that has a pipe2() function but run on a system with an
older (pre 2.6.27) linux
Gregory P. Smith added the comment:
This bug has brought up a broader issue. the pipe2 syscall on Linux is very
new. It is perfectly reasonable to expect a Python binary will be compiled
against a C library that has a pipe2() function but run on a system with an
older (pre 2.6.27) linux
Gregory P. Smith added the comment:
fixed r87651.
kaizhu if you still have the ability to run your colinux install with an old
2.6.26 kernel i'd appreciate it if you could explicitly test that the change
does the right thing.
--
resolution: -> fixed
status: open -
Gregory P. Smith added the comment:
I've added some code comments on http://bugs.python.org/review/7978/show
overall I think the patch is right, I pointed out one thing to clean up and I
think the unittest can be greatly simplified by using stubbed out mock
select.select() instead of
Gregory P. Smith added the comment:
fwiw a unified fork-and-exec API implemented in C is what I added in
Modules/_posixsubprocess.c to at least avoid this issue as much as possible
when using subprocess.
--
___
Python tracker
<h
Gregory P. Smith added the comment:
patch looks good. committed in r87710 for 3.2. needs back porting to 3.1 and
2.7 and optionally 2.6.
--
assignee: rnk -> gregory.p.smith
resolution: -> accepted
___
Python tracker
<http://bugs.p
Gregory P. Smith added the comment:
Doing this makes sense, i'm taking to closer look to see where it should be
done.
--
assignee: -> gregory.p.smith
___
Python tracker
<http://bugs.python.or
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue4188>
___
___
Python-
Changes by Gregory P. Smith :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue4188>
___
___
Python-bugs-list
Gregory P. Smith added the comment:
The code surrounding the p2c file descriptors in subprocess has changed a bit
recently since this issue was filed. someone still needs to come up with a way
to reproduce it.
--
assignee: gregory.p.smith
Gregory P. Smith added the comment:
r87726 for release31-maint
r87727 for release27-maint - this required a bit more fiddling as _block and
_started and _cond were __ private.
--
versions: -Python 3.1, Python 3.2
___
Python tracker
<h
Gregory P. Smith added the comment:
Attached is a patch for Python 2.6 release26_maint for reference incase someone
wants it. That branch is closed - security fixes only.
--
keywords: +patch
status: open -> closed
versions: -Python 2.7
Added file:
http://bugs.python.org/file20
Gregory P. Smith added the comment:
that race condition, if thats what this is, is likely not OS X specific. the
child process could complete or close its fds before we reach that code on any
OS. We either need to guard these io.open(p2c*...) lines against EBADF
OSError's or we s
Gregory P. Smith added the comment:
its still a problem, even the C path has to call close() a million times in
that case. thats a huge number of wasted syscalls. fixing this is blocking on
a good way to get the list of open fds.
I have seen other subprocess code do it using the race
Gregory P. Smith added the comment:
sorry, i saw the patches committed and thought that had fixed it. oops. still
more to be done.
--
___
Python tracker
<http://bugs.python.org/issue4
Gregory P. Smith added the comment:
Here's a patch that implements this behavior. It is too late in the 3.2
beta/rc cycle to get this into 3.2. Consider it for 3.3. I'd like a review.
--
keywords: +needs review, patch
Added file: http://bugs.python.org/file20251/issue1054
Gregory P. Smith added the comment:
Yes I'd do it in PyOS_AfterFork. Simpler patch based on gdb's attached.
This could also use a test but as it involves signals and race conditions,
making a deterministic test for this is difficult as it.
If we added testing hooks to the python i
Gregory P. Smith added the comment:
eek, thanks for noticing that!
r87740 fixes this in py3k. backporting to 3.1 and 2.7 now.
--
nosy: +barry
priority: normal -> release blocker
___
Python tracker
<http://bugs.python.org/iss
Gregory P. Smith added the comment:
r87741 3.1
r87742 2.7
--
resolution: accepted -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Gregory P. Smith added the comment:
Off the top of my head I don't _think_ so.. at least for posix. I'm not sure
about the implications of the if mswindows: code in there though.
--
___
Python tracker
<http://bugs.python.
Gregory P. Smith added the comment:
This is likely solved in py3k 3.2 with the C _posixsubprocess.c module. The
pipe creation and cloexec flag setting is all done atomically when possible,
and at least with the GIL held when not. close_fds also now defaults to True
Gregory P. Smith added the comment:
> IMO, if we give the illusion that the interpreter was actually killed,
> we should equate KeyboardInterrupt with SIGINT; any uncaught
> KeyboardInterrupt should consequently always lead to raising SIGINT.
Agreed. Plus that is easier to implement
Gregory P. Smith added the comment:
btw, I will be backporting all recent subprocess changes to
http://code.google.com/p/python-subprocess32/
there have been a lot of changes recently, i was waiting for that to settle
down before bring it up to current. 3.2rc1 sounds like a good time
Gregory P. Smith added the comment:
"""Generally there is no guarantee that a buffered object works "properly" when
the raw IO object raises some exception intermittently"""
I disagree. EINTR is a classic case of this and is something that buf
Gregory P. Smith added the comment:
IMNSHO it should but that would violate our release practices to do it this
late in the cycle. I expect the release manager to decline.
It isn't a critical issue, the end result is that people will hard code the
constants into their own code thems
Gregory P. Smith added the comment:
Rather than depending on the internal details of ForkingMixIn in your
BaseServer.serve_forever modification I'd prefer to see that simply call
self._cleanup()
Define a do-nothing _periodic_cleanup method in BaseServer. ForkingMixIn
should implemen
Gregory P. Smith added the comment:
documentation updated in r88352. thanks!
--
assignee: docs@python -> gregory.p.smith
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.o
Gregory P. Smith added the comment:
The need to call p1.stdout.close() has now been documented as part of
issue7678. Python 3.2's subprocess also has restore_signals=True as its
default behavior so SIGPIPE is restored by default.
I do not think it is appropriate to to ad
Gregory P. Smith added the comment:
Your patch makes sense to me. I'll commit it after the 3.2 release for 3.2.1.
The elease manager can feel free to commit it earlier if it is bothering an
important buildbot.
--
assignee: -> gregory
Gregory P. Smith added the comment:
I believe that is good. I'll commit it after the 3.2 release has been cut
(we're in release candidate release blocker only lockdown right now).
Looking at ForkingMixIn.collect_children() there appears to be another buglet:
it
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue11109>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
fwiw http://bugs.python.org/issue6643 recently fixed on issue where a mutex was
being closed instead of reinitialized after a fork. more are likely needed.
Are you suggesting to use pthread_atfork to call pthread_mutex_init on all
mutexes created by
Gregory P. Smith added the comment:
Yeah, I'm trying to figure out what I was thinking then or if I was just plain
wrong. :)
I was clearly wrong about a release being done in the child being the right
thing to do (issue6643 proved that, the state held by a lock is not usable to
an
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue11197>
___
___
Python-
Gregory P. Smith added the comment:
Agreed, fixing this is going to be too complex for 3.2.0, it'll be done for
3.2.1.
Reading over the http.server Simple and CGI HTTPRequestHandler code I see there
many problems with the way this code does things today.
General:
* I'
New submission from Gregory P. Smith <[EMAIL PROTECTED]>:
I disabled the Lib/bsddb/test/test_lock.py test03_set_timeout test as it
crashes the interpreter when compiled in debug mode with an UNREF test.
It appears to happen on all platforms according to the buildbots.
This is not a new p
Changes by Gregory P. Smith <[EMAIL PROTECTED]>:
--
assignee: -> jcea
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2858>
__
___
Python-b
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
I submitted a patch from Neal Norwitz after jcea reviewed it to trunk as
r63403.
I'll take care of backporting it to release25-maint.
--
assignee: jcea -> gregory.p.smith
versions
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
r63404 in release25-maint.
--
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
This is fixed in trunk now that jcea has done his merge.
If anyone wants it fixed in release25-maint it'll need a volunteer to
backport just the bugfix parts without the bsddb 4.6.x feature additions.
--
assignee: greg
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
does this still apply to the current test suite Jesus?
--
assignee: gregory.p.smith -> jcea
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.py
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
I believe this was finally cleaned up. There are still changes to be
made to the current test suite (blindly using a directory under /tmp and
not cleaning it up afterwards is bad) but the actual bug this refers to
was
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
This bug was created to track my FIXME in the code. Nobody else has
commented on it. I doubt its an issue worth fixing. It is a valid
FIXME but I'm marking it as low priority and leaving it unassigned just
to track the i
Gregory P. Smith <[EMAIL PROTECTED]> added the comment:
Jesus is the bsddb maintainer now.
--
assignee: gregory.p.smith -> jcea
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.py
201 - 300 of 3274 matches
Mail list logo
