[issue1471] ioctl request argument broken on 64-bit OpenBSD or OS X

2008-07-20 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: i believe this is fixed by the two changes mentioned above, i was waiting for fbvortex to confirm the fix on his 64-bit OpenBSD system. these changes need backporting to release25-maint. -- status: pending - open versions: -Python

[issue2960] bsddb/test/test_replication.py bus error, segfault, assertion error, pass

2008-07-21 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: using a python trunk optimized (non-debug) build and pybsddb r530: -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Berkeley DB 4.7.25: (May 15, 2008) bsddb.db.version(): (4, 7, 25) bsddb.db.__version__

[issue2620] Multiple buffer overflows in unicode processing

2008-07-21 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: Commited to trunk. r65182. This still needs backporting to release25-maint. (and release24-maint if anyone is maintaining that) -- keywords: +patch versions: +Python 3.0 -Python 2.6 ___ Python

[issue1857] subprocess.Popen.poll/__del__ API breakage

2008-08-03 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: Fixed in trunk r65459. release25-maint r65460. -- resolution: - accepted status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue1857

[issue3120] subprocess module truncates handles on AMD64

2008-08-03 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: fixed in release25-maint r65461. already merged into py3k from trunk. -- resolution: - fixed status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3120

[issue1471] ioctl request argument broken on 64-bit OpenBSD or OS X

2008-08-03 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: committed to release25-maint as r65466. if testing on 64bit openbsd or similar reveals that this is not fixed, please reopen the bug. -- status: open - closed ___ Python tracker [EMAIL PROTECTED

[issue1606] Doc: subprocess wait() may lead to dead lock

2008-08-03 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: See the documentation update in trunk r65469. It adds warnings about both common pipe related pitfalls discussed in this bug. -- resolution: accepted - fixed status: open - closed ___ Python

[issue3210] subprocess.Popen does not release process handles if process cannot be started

2008-08-03 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: I tried closing -all- of the handles listed here (the std ones used as input to _get_handles and the pipe read/write ones returned) on an OSError during CreateProcess but the problem still occurs for me using the test code in msg68787

[issue2113] Bad interaction between signal and subprocess

2008-08-03 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: fixed in release25-maint r65475. -- resolution: - fixed status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2113

[issue2277] MozillaCookieJar does not support Firefox3 cookie files

2008-08-03 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: Thanks. I've looked over your code. The logic looks good, however I'd like to propose a better design and that this not be included in 2.6. Instead of putting this functionality in the MozCookieJar class, it should be its own new

[issue3487] sre bytecode verifier

2008-08-03 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: +1 I'd like to see this make it in. -- nosy: +gregory.p.smith ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3487

[issue2464] urllib2 can't handle http://www.wikispaces.com

2008-08-16 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: looks good to me. ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2464 ___ ___ Python-bugs-list mailing list

[issue1397] mysteriously failing test_bsddb3 threading test in other threads

2008-08-16 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: agreed, that should be made to cause the test to fail. a failureException method that sets a flag that the main thread will detect and fail on when exiting should do the trick. side note: ...sadly that failure appears to be a test issue

[issue2464] urllib2 can't handle http://www.wikispaces.com

2008-08-17 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: i was pondering if it should go in urlparse instead. if it did, i think it should be part of urlparse.urlunparse to ensure that there is always a trailing slash after the host:port regardless of what the inputs are. anyways, agreed

[issue874900] threading module can deadlock after fork

2008-08-17 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: backported to release25-maint in r65789. -- resolution: - fixed status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue874900

[issue3309] missing lock release in BZ2File_iternext()

2008-08-17 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: backported to release25-maint in r65790 -- status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3309

[issue874900] threading module can deadlock after fork

2008-08-17 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: specifically, test_3_join_in_forked_from_thread hangs in py3k and is currently disabled. -- assignee: gregory.p.smith - ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue874900

[issue2464] urllib2 can't handle http://www.wikispaces.com

2008-08-17 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: That test case looks good to me for 2.6 and 3.0. Also add a note to the documentation with a versionchanged 2.6 about urlunparse always ensuring there is a / between the netloc and the rest of the url. I would not back port the more general

[issue2013] Long object free list optimization

2008-08-17 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: preventing this right now is that when i apply this to py3k today, it fails miserably in a debug build. first, my patch has an invalid assert(size 0) in it in _PyLong_New as 0 size is used when the value is 0. get rid of that line

[issue2013] Long object free list optimization

2008-08-17 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: attached is an updated patch that also works in debug mode. to do this i had to exclude all zero length (value = 0) PyLongObjects from the free list. i'm still not sure why, they all have the same underlying allocation size. simplifying

[issue2013] Long object free list optimization

2008-08-17 Thread Gregory P. Smith
Changes by Gregory P. Smith [EMAIL PROTECTED]: Added file: http://bugs.python.org/file11144/py3k_longfreelist2_gps04.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2013

[issue815646] thread unsafe file objects cause crash

2008-08-19 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: The fix can not be committed to Python 2.5 because it breaks compatibility by adding another field to the PyFileObject struct and adding two new C API functions. ___ Python tracker [EMAIL PROTECTED] http

[issue2629] _Py_ForgetReference crash when called from _PyUnicode_New on MemoryError

2008-08-19 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: Verified fixed. Python 2.6b2+ (trunk:65871, Aug 19 2008, 13:10:07) msg = 'A'*2000111222 [12389 refs] x = msg.decode('utf8') Traceback (most recent call last): File stdin, line 1, in module File /usr/local/google/home/gps/python/trunk

[issue3001] RLock's are SLOW

2008-08-20 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: I doubt subclassability of RLock matters but who knows, people do code things. Regardless, using a C version wrapped in a simple python container class that calls the underlying C implementation's methods should be sufficient to allow sub

[issue3618] possible deadlock in IO library (Lib/io.py)

2008-08-20 Thread Gregory P. Smith
Changes by Gregory P. Smith [EMAIL PROTECTED]: -- nosy: +gregory.p.smith ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3618 ___ ___ Python-bugs-list

[issue3618] possible deadlock in IO library (Lib/io.py)

2008-08-20 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: see the python-3000 thread I just started asking for opinions on this. I'd personally say this bug is a good reason to go ahead with #3001 for 3.0. ___ Python tracker [EMAIL PROTECTED] http

[issue874900] threading module can deadlock after fork

2008-08-23 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: it passes on release25-maint for me on linux. i don't see it hanging in any of the 2.5 buildbots. looks like your r66003 change was a decent fix for windows judging by the buildbot. (fwiw, that test you patched in 66003 should probably use

[issue3678] Ignored LDFLAGS during linking libpython$(VERSION).so

2008-08-27 Thread Gregory P. Smith
Changes by Gregory P. Smith [EMAIL PROTECTED]: -- assignee: - gregory.p.smith nosy: +gregory.p.smith priority: - normal ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3678

[issue3710] Reference leak in thread._local

2008-08-27 Thread Gregory P. Smith
Changes by Gregory P. Smith [EMAIL PROTECTED]: -- nosy: +gregory.p.smith ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3710 ___ ___ Python-bugs-list

[issue1868] threading.local doesn't free attrs when assigning thread exits

2008-08-27 Thread Gregory P. Smith
Changes by Gregory P. Smith [EMAIL PROTECTED]: -- keywords: +patch nosy: +gregory.p.smith ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue1868

[issue3678] Ignored LDFLAGS during linking libpython$(VERSION).so

2008-08-27 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: I think this ldflags-ldlast patch (added) is whats really needed. -- keywords: +easy, needs review Added file: http://bugs.python.org/file11280/ldflags-ldlast-gps01.diff ___ Python tracker [EMAIL

[issue3710] Reference leak in thread._local

2008-08-27 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: fyi - This bug and #1868 (http://bugs.python.org/issue1868) seem related. ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3710

[issue1868] threading.local doesn't free attrs when assigning thread exits

2008-08-27 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: see also #3710 ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue1868 ___ ___ Python-bugs-list mailing list

[issue1868] threading.local doesn't free attrs when assigning thread exits

2008-08-27 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: I like Amaury's patch, it gets rid of what seems like an existing gross hack of having localobject-dict exist at all. I believe it may also fix #3710 by getting rid of the unnecessary localobject-dict member. Could someone else please

[issue3708] os.urandom(1.1): infinite loop

2008-08-27 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: i'll fix this and add a unit test. -- assignee: - gregory.p.smith keywords: +easy nosy: +gregory.p.smith priority: - low ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3708

[issue3708] os.urandom(1.1): infinite loop

2008-08-28 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: better patch with tests attached, no explicit int conversion is done. i also wrapped the use of the fd returned by open with a try: finally: to avoid any chance of a leak and renamed the bytes variable to bs to match whats in py3k and avoid

[issue3704] cookielib doesn't handle URLs with / in parameters

2008-08-28 Thread Gregory P. Smith
Changes by Gregory P. Smith [EMAIL PROTECTED]: -- keywords: +patch Added file: http://bugs.python.org/file11282/cookielib.diff ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3704

[issue3704] cookielib doesn't handle URLs with / in parameters

2008-08-28 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: attached is a patch with the suggested fix along with a unit test. -- assignee: - gregory.p.smith keywords: +needs review nosy: +gregory.p.smith priority: - normal Added file: http://bugs.python.org/file11283/cookielib-querystring

[issue3647] urlparse - relative url parsing and joins to be RFC3986 compliance

2008-08-28 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: given where we are in the release process at the moment I doubt this can go into 2.6/3.0. Bring it up on python-dev if you have compelling reasons why it should. Otherwise, looks good for trunk 2.7/3.1 immediately after the releases

[issue3703] open() on directory raises IOError with unhelpful message

2008-08-28 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: looks good to me -- nosy: +gregory.p.smith ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3703

[issue3708] os.urandom(1.1): infinite loop

2008-08-28 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: if i did n = int(n) that would change the API to allow bytes/unicode to be passed in which is not something i want. i don't even like that it allows floats. by not doing the int conversion at all, a DeprecationWarning is raised

[issue3715] hashlib's docstring throws exception in pydoc

2008-08-31 Thread Gregory P. Smith
Changes by Gregory P. Smith [EMAIL PROTECTED]: -- assignee: - gregory.p.smith nosy: +gregory.p.smith priority: - normal ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3715

[issue3715] hashlib's docstring throws exception in pydoc

2008-08-31 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: fixed in trunk r66093, py3k r66094, release25-maint r66095 -- keywords: +easy resolution: - fixed status: open - closed versions: +Python 2.5, Python 2.6 ___ Python tracker [EMAIL PROTECTED] http

[issue3678] Ignored LDFLAGS during linking libpython$(VERSION).so

2008-09-01 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: committed to trunk r66141. leaving open until i verify that this makes it into py3k and for a backport to release25-maint. -- keywords: -needs review versions: -Python 2.6 ___ Python tracker

[issue3708] os.urandom(1.1): infinite loop

2008-09-01 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: committed to trunk r66142 -- status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3708

[issue1868] threading.local doesn't free attrs when assigning thread exits

2008-09-01 Thread Gregory P. Smith
Changes by Gregory P. Smith [EMAIL PROTECTED]: -- assignee: - gregory.p.smith ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue1868 ___ ___ Python-bugs

[issue1868] threading.local doesn't free attrs when assigning thread exits

2008-09-02 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: this is ready for more review at http://codereview.appspot.com/3641 Added file: http://bugs.python.org/file11341/threading_local4.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org

[issue3645] readline module Crashs on OpenBSD/amd64

2008-09-03 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: committed to trunk (2.6) in r66179. This should be back ported to release25-maint and automagically merged into py3k. can someone with OpenBSD confirm that this has indeed fixed the problem? if so i'll do the 25 backport and mark

[issue3645] readline module Crashs on OpenBSD/amd64

2008-09-03 Thread Gregory P. Smith
Changes by Gregory P. Smith [EMAIL PROTECTED]: -- keywords: -needs review ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3645 ___ ___ Python-bugs-list

[issue3492] Zlib compress/decompress functions returning bytearray

2008-09-03 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: this is a very simple patch and makes sense to me. marking it a release blocker and asking about it on the mailing list. if anyone disagrees with this one please speak up. in general IO input functions elsewhere return bytes(). zlib

[issue3492] Zlib compress/decompress functions returning bytearray

2008-09-04 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: Correct, zipimport required fixing in order for this to work. The newly attached zlib-and-zipimport-gps01 patch. review at http://codereview.appspot.com/4454 I haven't had a chance to look at the other modules Amaury mentioned

[issue1040026] os.times() is bogus

2008-09-05 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: I agree with Christian's most recent comment. However without BDFL intervention I think its too late in the 2.6/3.0 release cycle to rush this fix in. It can wait for 2.6.1/3.0.1. I won't have time to look at it for several days myself

[issue3783] dbm.sqlite proof of concept

2008-09-06 Thread Gregory P. Smith
Changes by Gregory P. Smith [EMAIL PROTECTED]: -- nosy: +gregory.p.smith ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3783 ___ ___ Python-bugs-list

[issue3790] in zlib decompressor objects, unused_data and unconsumed_tail must be immutable

2008-09-06 Thread Gregory P. Smith
Changes by Gregory P. Smith [EMAIL PROTECTED]: -- assignee: - gregory.p.smith nosy: +gregory.p.smith ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3790

[issue3492] Zlib compress/decompress functions returning bytearray

2008-09-06 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: fixed in r66266 along with #3790. leaving this open and assigned to me while i investigate the other uses of ByteArray in the Modules/ directory. IMHO, its fine if we fix any remaining bytearray uses up for rc2. -- resolution

[issue3790] in zlib decompressor objects, unused_data and unconsumed_tail must be immutable

2008-09-06 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: fixed in r66266 along with #3492. -- resolution: - fixed status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3790

[issue3492] Zlib compress/decompress functions returning bytearray

2008-09-06 Thread Gregory P. Smith
Changes by Gregory P. Smith [EMAIL PROTECTED]: -- priority: release blocker - deferred blocker ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3492

[issue3797] mmap, dbm and ossaudiodev return bytearray instead of bytes

2008-09-06 Thread Gregory P. Smith
New submission from Gregory P. Smith [EMAIL PROTECTED]: As noted in issue #3492 the following py3k modules still erroneously return bytearray objects instead of bytes objects from their read functions: mmap dbm ossaudiodev Attached is a trivial patch to fix those. -- assignee

[issue3797] mmap, dbm, ossaudiodev, marshal winreg return bytearray instead of bytes

2008-09-06 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: attached a patch for PC/winreg.c and Python/marshal.c. -- title: mmap, dbm and ossaudiodev return bytearray instead of bytes - mmap, dbm, ossaudiodev, marshal winreg return bytearray instead of bytes Added file: http

[issue3492] Zlib compress/decompress functions returning bytearray

2008-09-06 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: issue #3797 has been opened to track the other files mentioned. -- status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3492

[issue3797] mmap, dbm, ossaudiodev, marshal winreg return bytearray instead of bytes

2008-09-06 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: heh indeed it should be rv. i made the patch on a mac and hadn't run it on my linux host before opening the issue. fixed locally and given all of the reviews across all relevant platforms.. committing. py3k r66273. -- resolution

[issue1068268] subprocess is not EINTR-safe

2008-09-06 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: its too late in the release process for subprocess internals being EINTR safe to make it into 2.6 but it is reasonable for 2.6.1. -- priority: low - normal type: - behavior versions: +Python 2.5, Python 2.6

[issue3645] readline module Crashs on OpenBSD/amd64

2008-09-06 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: true, issue 1204 is more general. i'll leave this in but it can be removed once the better general fix is in with 1204. i won't backport this one. -- keywords: +64bit status: pending - closed versions: +Python 2.6

[issue1204] readline configuration for shared libs w/o curses dependencies

2008-09-06 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: when committing this one, the platform specific openbsd/amd64 fix I committed for this in issue 3645 should probably be verified as unneeded and undone. marking as release blocker as we should make sure this autoconf update goes in before

[issue874900] threading module can deadlock after fork

2008-09-06 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: forkthread2.patch looks good to me. to be consistent shouldn't we also apply that fix to 2.6? ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue874900

[issue1204] readline configuration for shared libs w/o curses dependencies

2008-09-06 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: I've attached an updated patch. Not much changed other than the better diff -u format, a couple grammar errors in comments and inclusion of the new autoconf generated configure script. It works fine for me on ubuntu hardy 32bit, CentOS 5.x

[issue3783] dbm.sqlite proof of concept

2008-09-06 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: sq_dict review: have sqlite quote/escape self._mtn before using it with a python %s substitution. or pass it into the sql query function as a positional ? parameter like you do for keys and values. (avoid sql injection) raise a TypeError

[issue3704] cookielib doesn't handle URLs with / in parameters

2008-09-06 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: yep it applies to all releases. anyways, it won't make 2.6/3.0 but it can be put into 2.5.3/2.6.1/3.0.1. -- versions: +Python 3.0 ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org

[issue874900] threading module can deadlock after fork

2008-09-06 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: I backported the last bit from r66275 to release25-maint in r66279. ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue874900

[issue3764] asyncore differences between 2.x and 3.x

2008-09-06 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: please undo this, this broke asyncore in trunk. handle_close_event doesn't exist in 2.6. -- nosy: +gregory.p.smith priority: - release blocker resolution: fixed - status: closed - open

[issue3764] asyncore differences between 2.x and 3.x

2008-09-06 Thread Gregory P. Smith
Changes by Gregory P. Smith [EMAIL PROTECTED]: -- keywords: +easy type: - behavior versions: +Python 2.6 -Python 3.0 ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3764

[issue1204] readline configuration for shared libs w/o curses dependencies

2008-09-06 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: fixed in trunk r66283 (followed by rerunning autoconf to generate a new configure script in r66284). -- keywords: -needs review versions: -Python 2.6 ___ Python tracker [EMAIL PROTECTED] http

[issue1204] readline configuration for shared libs w/o curses dependencies

2008-09-07 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: merged into py3k branch in r66285. backported to release25-maint in r66288 and r66289. -- resolution: - accepted status: open - closed versions: -Python 3.0 ___ Python tracker [EMAIL PROTECTED

[issue1204] readline configuration for shared libs w/o curses dependencies

2008-09-07 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: eek. not quite fixed then :) i'll retest and take care of it. -- resolution: accepted - status: closed - open ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue1204

[issue1204] readline configuration for shared libs w/o curses dependencies

2008-09-07 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: fixed in trunk r66295/r66296. merging and backporting now... -- versions: +Python 3.0 ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue1204

[issue1204] readline configuration for shared libs w/o curses dependencies

2008-09-07 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: merged to py3k r66297 + r66298 backported to release25-maint r66299 + r66300. -- resolution: - fixed status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue1204

[issue3805] sslobj.read py3k takes odd arguments

2008-09-08 Thread Gregory P. Smith
New submission from Gregory P. Smith [EMAIL PROTECTED]: Modules/_ssl.c in the py3k branch: PySSL_SSLread(): calls parsetuple expecting |Oi as arguments. However the logic below to interpret and use the arguments is very convoluted. it'd be better to reorder these as |iO to match the api

[issue3805] sslobj.read py3k takes odd arguments

2008-09-08 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: i only had a brief look when i was going through code looking for potentially incorrect uses of PyByteArray_*. I've got a patch that i believe cleans it up a little but its sitting on a machine i don't have remote access to at the moment

[issue1868] threading.local doesn't free attrs when assigning thread exits

2008-09-08 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: i won't have time to work on this for several days but i will happily review updated patches if anyone could contribute fixes for the __dict__ issues described in the most recent comments. feel free to steal the issue from me

[issue3805] sslobj.read py3k takes odd arguments

2008-09-09 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: yep, agreed. leave this for later. my bad for opening it with high priority in the first place. low is correct. :) i was just trying to write down comments on odd code that i came across before i forgot about

[issue3825] Major reworking of Python 2.5.2 re module

2008-09-09 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: This sounds really neat. but as Anotine said it'll be several weeks before any of us can give this serious attention. Definitely update to trunk and base your work off of that. quick comments: Your _sre.c diff appears to remove

[issue3825] Major reworking of Python 2.5.2 re module

2008-09-09 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: weird typo: s/f lea/formats/ ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3825 ___ ___ Python-bugs-list

[issue1868] threading.local doesn't free attrs when assigning thread exits

2008-09-10 Thread Gregory P. Smith
Gregory P. Smith [EMAIL PROTECTED] added the comment: Agreed, this is fine for a bugfix point release. I was initially concerned about the Modules/threadmodule.c struct localobject changing but that is private and used only by code within threadmodule.c so its not part of an API anything else

[issue1202] zlib.crc32() and adler32() return value

2009-06-26 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: fix for J. David's issue submitted to trunk r73565 and py3k r73566 just in time for the 3.1 release. release30-maint r73567 release26-maint r73568 -- status: open - closed versions: +Python 3.0, Python 3.1

[issue6380] Deadlock during the import in the fork()'ed child process if fork() happened while import_lock was held

2009-06-29 Thread Gregory P. Smith
Changes by Gregory P. Smith g...@krypto.org: -- nosy: +gregory.p.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6380 ___ ___ Python-bugs-list

[issue3392] subprocess fails in select when descriptors are large

2009-07-03 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Your patch looks pretty good. I cleaned up a few things in it and added a unittest (the existing test suite is run with both select and poll). Committed to trunk in r73825. I am leaving the issue open until this is ported and merged

[issue3392] subprocess fails in select when descriptors are large

2009-07-03 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Merged to py3k in r73833. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3392 ___ ___ Python

[issue1424152] urllib/urllib2: HTTPS over (Squid) Proxy fails

2009-07-25 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: *Rereads latest patch* I'm happy with this being backported as a bugfix to 3.1 and 2.6 so long as the set_tunnel method is hidden. Call it _set_tunnel() in the backport (and don't document its existence

[issue6567] Make inf be almost equal to inf

2009-07-25 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: good catch. thanks! -- nosy: +gregory.p.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6567

[issue5511] zipfile - add __exit__ attribute to make ZipFile object compatible with with_statement

2009-07-25 Thread Gregory P. Smith
Changes by Gregory P. Smith g...@krypto.org: -- assignee: - ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5511 ___ ___ Python-bugs

[issue2636] Regexp 2.7 (modifications to current re 2.2.2)

2009-07-27 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Agreed, a standalone release combined with a public announcement about its availability is a must if we want to get any sort of wide spread testing. It'd be great if we had a fully characterized set of tests for the behavior of the existing

[issue1115] Minor Change For Better cross compile

2009-07-31 Thread Gregory P. Smith
Changes by Gregory P. Smith g...@krypto.org: -- assignee: loewis - gregory.p.smith nosy: +gregory.p.smith priority: low - normal ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1115

[issue3718] environment variable MACHDEP and python build system

2009-07-31 Thread Gregory P. Smith
Changes by Gregory P. Smith g...@krypto.org: -- assignee: - gregory.p.smith nosy: +gregory.p.smith priority: - normal ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3718

[issue1006238] cross compile patch

2009-07-31 Thread Gregory P. Smith
Changes by Gregory P. Smith g...@krypto.org: -- assignee: - gregory.p.smith nosy: +gregory.p.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1006238

[issue1597850] Cross compiling patches for MINGW

2009-07-31 Thread Gregory P. Smith
Changes by Gregory P. Smith g...@krypto.org: -- nosy: +gregory.p.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1597850 ___ ___ Python-bugs

[issue5404] Cross-compiling Python

2009-07-31 Thread Gregory P. Smith
Changes by Gregory P. Smith g...@krypto.org: -- nosy: +gregory.p.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5404 ___ ___ Python-bugs-list

[issue1628205] socket.readline() interface doesn't handle EINTR properly

2009-08-06 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: nice test case rhettg. This is a correctness issue to prevent data loss on EINTR. I've attached a patch that builds on rhettg's but allows the EINTR signal to propagate upwards as desired by loweis and jorend for both read() and readline

[issue1628205] socket.readline() interface doesn't handle EINTR properly

2009-08-07 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: realistically, file objects (Objects/fileobject.c) never raise EINTR as they use the C library fread/fwrite/fclose underneath. Why should a socket based file object every be allowed to raise EINTR rather than handling it internally? IMHO

[issue2636] Regexp 2.7 (modifications to current re 2.2.2)

2009-08-10 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: for each of these discrepancies that you're finding, please consider submitting them as patches that add a unittest to the existing test suite. otherwise their behavior guarantees will be lost regardless of if the suite in this issue

[issue3392] subprocess fails in select when descriptors are large

2009-08-13 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: r73916 appears to fix this? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3392

<    1   2   3   4   5   6   7   8   9   10   >