Changes by Gregory P. Smith g...@krypto.org:
--
assignee: - gregory.p.smith
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12059
Gregory P. Smith g...@krypto.org added the comment:
if you used the pipe approach you'd need to deal with the case of the write
blocking (or failing if nonblocking) when the pipe buffer is full. also you'd
need to block signals around a fork and reinitialize the pipe in the child
before
Gregory P. Smith g...@krypto.org added the comment:
if someone comes up with a situation where this is a real problem, feel free to
reopen it.
--
resolution: - wont fix
status: open - closed
___
Python tracker rep...@bugs.python.org
http
Gregory P. Smith g...@krypto.org added the comment:
We should ensure that the first differing character in the string is always
included in what is displayed as a diff. if we're going to shorten a string we
should elide something that matches.
--
nosy: +gregory.p.smith
Gregory P. Smith g...@krypto.org added the comment:
I added these with conditional compilation via autoconf for use on posix
systems. These methods are not IPv6 specific.
Anyone who wants to see them supported on windows will need to add whatever
conditional compilation magic is required
Gregory P. Smith g...@krypto.org added the comment:
thanks i'll take a look at OS X here. obviously i did development and
testing on linux.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1746656
Gregory P. Smith g...@krypto.org added the comment:
unassigning, i don't have time to tackle netbsd issues right now.
--
assignee: gregory.p.smith -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9667
Gregory P. Smith g...@krypto.org added the comment:
Misc/build.sh seems obsolete... its full of references to svn and we have had
buildbots for many years now.
The buildbots do not seem to be hitting this issue. Is there a real failure
you can point at somewhere? if so please reopen
Gregory P. Smith g...@krypto.org added the comment:
unassigning, i don't have time for this one right now. doubtful anyone is
going to jump in for 3.2.1 given rc1 is being prepared right now. :)
General recommendation: don't use SimpleHTTPServer in production.
--
assignee
Gregory P. Smith g...@krypto.org added the comment:
that patch looks good. though I do wish we had a function similar to
PyObject_AsStringEncodedFSDefault() so that the ParseTuple call wasn't needed
for this relatively common operation when interfacing with system library calls
that deal
Changes by Gregory P. Smith g...@krypto.org:
--
nosy: -gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1597850
___
___
Python-bugs
Gregory P. Smith g...@krypto.org added the comment:
I just nuked the pure Python POSIX subprocess implementation in
70467:75ca834df824. No need for both implementations. _posixsubprocess is now
the only option.
--
___
Python tracker rep
Gregory P. Smith g...@krypto.org added the comment:
Include an appropriate Version Added annotation in the pipe2 documentation.
Otherwise the current patches look good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Gregory P. Smith g...@krypto.org added the comment:
I added comments in the code review.
this patch is looking good once the comments are addressed. thanks for your
contribution!
As for talk of support for recursion... thats what os.walk() is for. it
doesn't belong as part of any
Gregory P. Smith g...@krypto.org added the comment:
If the server failed to close a transaction the protocol stream is over
unless you mime relying on hope and luck. Poplib has a nasty set of server
implementation bugs to work around here.
Readline as defined today no longer suits its needs
Gregory P. Smith g...@krypto.org added the comment:
This looks like a bug in your daemon not in subprocess. Your daemon is
intentionally not closing its inherited stderr fd.
--
nosy: +gregory.p.smith
resolution: - invalid
status: open - closed
Gregory P. Smith g...@krypto.org added the comment:
+1 nice! A couple minor comments on the code review.
--
nosy: +gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13417
Gregory P. Smith g...@krypto.org added the comment:
Why make this decision ourselves at all? Copy what Mozilla and Chromium do
by default.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13636
Gregory P. Smith g...@krypto.org added the comment:
http://pypi.python.org/pypi/unittest2 says
There are several places in unittest2 (and unittest) that call str(...) on
exceptions to get the exception message. This can fail if the exception was
created with non-ascii unicode. This is rare
Gregory P. Smith g...@krypto.org added the comment:
We're on python 2.6, otherwise this would be a moot point. but you might want
to include something like that in a new unittest2 backport release.
--
___
Python tracker rep...@bugs.python.org
http
New submission from Gregory P. Smith g...@krypto.org:
gzip.GzipFile accepts a fileobj parameter with an open file object.
Unfortunately gzip requires a filename be embedded in the gzip file and the
gzip module code uses fileobj.name to get that.
This results in the fake fdopen name from
Gregory P. Smith g...@krypto.org added the comment:
A new lock type will NOT solve this. It is ALWAYS okay to clear all
thread/threading module locks after a fork.
They are and always have been process-local by definition so they are also by
definition 100% invalid to any child process
Gregory P. Smith g...@krypto.org added the comment:
Reopening. Comments added to the code review.
This issue is independent of the subprocess module issue in #8052. The
_posixsubprocess.c has its own fd closing loop.
http://hg.python.org/cpython/file/050c07b31192/Modules/_posixsubprocess.c
Gregory P. Smith g...@krypto.org added the comment:
attaching a patch that implements this safely.
--
keywords: +patch
Added file:
http://bugs.python.org/file24255/subprocess-close-open-fds-gps01.diff
___
Python tracker rep...@bugs.python.org
http
Gregory P. Smith g...@krypto.org added the comment:
attaching a better formatted one for review.
--
Added file:
http://bugs.python.org/file24256/subprocess-close-open-fds-gps02.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Gregory P. Smith g...@krypto.org added the comment:
Wasn't thought about. I have seen something similar to that done in another
c++ subprocess implementation since. If you have suggestions for a more useful
API, feel free to propose them in a new issue
Gregory P. Smith g...@krypto.org added the comment:
thanks that looks good.
As far as fixing this for 2.7 goes, i don't like the _sound_ of it because it
is gross... But i'm actually okay with having special case code in the gzip
module that rejects 'fdopen' as an actual filename and uses
Gregory P. Smith g...@krypto.org added the comment:
I like what you've done in #13704 better than what I see in random-8.patch so
far. see the code review comments i've left on both issues.
--
nosy: +gregory.p.smith
___
Python tracker rep
Gregory P. Smith g...@krypto.org added the comment:
Looks like you've got commit privs (yay) so i'm assigning this to you to take
care of that way for 2.7 as well.
I'd add a comment to the fdopen C code where the fdopen constant lives as
well as to the gzip.py module around the special case
Gregory P. Smith g...@krypto.org added the comment:
On Wed, Jan 18, 2012 at 1:10 PM, Guido van Rossum
rep...@bugs.python.org wrote:
On Wed, Jan 18, 2012 at 1:05 PM, Antoine Pitrou rep...@bugs.python.orgwrote:
I would hope 3.3 only gets randomized hashing. Collision counting is a
hack
Gregory P. Smith g...@krypto.org added the comment:
A dict can contain non-orderable keys, I don't know how an AVL tree can
fit into that.
good point!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13703
Gregory P. Smith g...@krypto.org added the comment:
On Sat, Jan 21, 2012 at 2:45 PM, Antoine Pitrou rep...@bugs.python.org wrote:
Antoine Pitrou pit...@free.fr added the comment:
You said above that it should be hardcoded; if so, how can it be changed
at run-time from an environment
Gregory P. Smith g...@krypto.org added the comment:
For FreeBSD, Python 3.2 and 3.3 now check to see if /dev/fd is valid. Be sure
and mount -t fdescfs none /dev/fd on FreeBSD if you want faster subprocess
launching. Run a FreeBSD buildbot? Please do it!
For Python 3.1 the fix for #13788
Gregory P. Smith g...@krypto.org added the comment:
On Mon, Jan 23, 2012 at 1:32 PM, Dave Malcolm rep...@bugs.python.org wrote:
Dave Malcolm dmalc...@redhat.com added the comment:
I'm attaching an attempt at backporting haypo's random-8.patch to 2.7
Changes relative to random-8.patch
Gregory P. Smith g...@krypto.org added the comment:
But using non-__builtin__.str objects (such as UserString) would expose the
user to an attack?
Not necessarily: only if they use these strings as dictionary keys, and only
if they do so in contexts where arbitrary user input is consumed
Changes by Gregory P. Smith g...@krypto.org:
--
nosy: +gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13903
___
___
Python-bugs
Gregory P. Smith g...@krypto.org added the comment:
What about PYTHONHASHSEED= - off, PYTHONHASHSEED=0 - random,
PYTHONHASHSEED=n - n ? I agree with Jim that it's better to have one
env. variable than two.
Rather than the empty string for off I suggest an explicit string
that makes it clear
Gregory P. Smith g...@krypto.org added the comment:
FYI - I strongly support this type of work to reduce memory use of the Python
interpreter! :)
Also, yes, constant changing should be separate from this change but are worth
occasionally re-measuring and justifying as common computer
New submission from Gregory P. Smith g...@krypto.org:
In order for lib2to3 to be integrated into parts of our workflow at work we
need it to be able to write converted code out to new directory and modify the
filename in the process. While doing that, it is very convenient if it can
also
Gregory P. Smith added the comment:
it's a potential bug. your patch looks good.
as for _handle_exitstatus referring to SubprocessError, that is fine. In that
situation it is trying to raise the exception and the only time that would ever
be a problem is when called by the gc during
New submission from Gregory P. Smith:
test_posix.test_getgrouplist is failing for me on my Linux (ubuntu precise)
based desktop at work.
It looks like posix.getgrouplist() is returning all of the larger GIDs. The
lowest one it is reporting for my user is 499 but the more distro specific
Gregory P. Smith added the comment:
would the values returned by getgrouplist always be a non empty subset of
getgroups? (regardless, I expect the id -G process output parsing can be
removed)
--
title: test_posix.test_getgrouplist fails on some systems - incorrectly
comparing
Gregory P. Smith added the comment:
Given where the crash is occurring and that faulthandler traceback it makes me
wonder if it was compiled with a set of openssl headers that don't make the
library it is using at runtime.
If you recompile the interpreter in debug mode (--with-pydebug on your
Gregory P. Smith added the comment:
Given this is more of a code coverage test than any need to test the
functionality of the OS library call, just asserting that it returns a
non-empty list is a decent test. :)
--
___
Python tracker rep
Gregory P. Smith added the comment:
doesn't the size of code setting up ParseTupleWithKeywords and checking the
values afterwards bother you? that's the same thing only much less consistent.
--
___
Python tracker rep...@bugs.python.org
http
Gregory P. Smith added the comment:
given the behavior you are seeing, I'm not inclined to trust your computer or
however it is configured. I do not believe this is a Python issue.
3.3 works fine on RHEL 6 so it should work fine on CentOS 6.
http://buildbot.python.org/all/builders/x86
Gregory P. Smith added the comment:
There's a bit of an impasse here on the PEP front. Guido said it wasn't
needed. Antoine brings up the point that CPython developers will have to live
with the result of this work so maybe something more easy to read and see in
one place like a PEP would
Gregory P. Smith added the comment:
PEPs are perceived as a hurdle. Regardless, clinic.txt would turn into one
pretty easily so just doing it may be easiest. :)
On Fri, Dec 14, 2012 at 12:11 PM, Antoine Pitrou rep...@bugs.python.orgwrote:
Antoine Pitrou added the comment:
I have
Changes by Gregory P. Smith g...@krypto.org:
--
nosy: +gregory.p.smith
priority: normal - critical
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16742
Gregory P. Smith added the comment:
If someone thinks this should go into 3.2 and 3.3 they're welcome to do it; no
objections from me. (The behavior was unintentional and thus a bug, but it is
still a minor behavior change)
--
nosy: +gregory.p.smith
Gregory P. Smith added the comment:
Having just looked added something to test_int as part of issue16772... There
appears to be an explicit test _for_ this strange behavior in there:
http://hg.python.org/cpython/file/60f7197f991f/Lib/test/test_int.py#l233
test_base_arg_with_no_x_arg
I have
Gregory P. Smith added the comment:
Thanks for the pointer to round(). PyNumber_AsSsize_t was just what the doctor
ordered.
PS Grump acknowledged and accepted. Its trunk and we're nowhere near a freeze
so I figured it'd be fine to iterate on it in trunk if needed
Gregory P. Smith added the comment:
I used it because Mark suggested it could have the same behavior as round() and
that is the more abstract API that round uses. Regardless, at this point I've
added tests and tested for the TypeError when a float is passed as well as
testing that the only
Changes by Gregory P. Smith g...@krypto.org:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16772
___
___
Python
Gregory P. Smith added the comment:
I think the forkserver approach is a good idea. It is what a lot of users will
choose.
forkserver won't work everywhere though so the fork+exec option is still
desirable to have available. Threads can be started by non-python code
(extension modules
Gregory P. Smith added the comment:
ah, i missed that update. cool! +1
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8713
___
___
Python-bugs
Changes by Gregory P. Smith g...@krypto.org:
--
assignee: - gregory.p.smith
nosy: +gregory.p.smith -gps
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16946
Changes by Gregory P. Smith g...@krypto.org:
--
nosy: -gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3718
___
___
Python-bugs
Gregory P. Smith added the comment:
the patch looks good, thanks! one minor comment in a test but i'll take care
of that as i submit.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6972
Changes by Gregory P. Smith g...@krypto.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6972
Gregory P. Smith added the comment:
it was easier to just take care of auditing the write calls as part of this
given the code change was directly related to it.
On Python 2.7 most of the write calls in the builtin file object
(Objects/fileobject.c) rather than the new io module use the libc
Changes by Gregory P. Smith g...@krypto.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12268
New submission from Gregory P. Smith:
Create a malicious .tar file with entries containing absolute or relative paths
and the tarfile module happily uses them as is without sanity checking.
filed in response to http://bugs.python.org/issue6972 which fixed the zipfile
module for this.
I'm
Gregory P. Smith added the comment:
yes, tarfile appears to have the same problem.
http://bugs.python.org/issue17102 filed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6972
Changes by Gregory P. Smith g...@krypto.org:
--
title: baseManager serve_client() not check EINTR when recv request -
multiprocessing BaseManager serve_client() does not check EINTR on recv
___
Python tracker rep...@bugs.python.org
http
Gregory P. Smith added the comment:
given issue 1044, this is not high priority. i still think it'd be useful.
--
priority: high - normal
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17102
Gregory P. Smith added the comment:
I believe this is all done after Serhiy's fixes.
--
assignee: gregory.p.smith - serhiy.storchaka
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6972
Gregory P. Smith added the comment:
done.
btw, it looks like benjamin.peterson did it for 2.7 yesterday morning but when
'hg graft' is used to apply a change from another branch the roundup
notification mentions the original commit's author, not the person who did the
push of the graft
Gregory P. Smith added the comment:
Suggested workaround: use io.BytesIO instead of cStringIO.
comments on the patch... in short: your patch is changing an ABI and isn't
suitable for a maintenance release.
I'm not sure how much we can usefully do to cStringIO in a maintenance release.
I'd
Gregory P. Smith added the comment:
Include/cStringIO.h is public and the name of the structure PycStringIO lacks
an _ which implies that it is public.
There appear to be a few references to it in external projects doing some
searching. A (very old) version of twisted/protocols/_c_urlarg.c
Gregory P. Smith added the comment:
Serhiy's patch looks good to me.
--
nosy: +gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6083
Changes by Gregory P. Smith g...@krypto.org:
--
nosy: -gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17121
___
___
Python-bugs
Gregory P. Smith added the comment:
reopening as documentation mixups remain to be fixed.
--
nosy: +benjamin.peterson, larry
priority: high - release blocker
resolution: fixed -
stage: patch review - needs patch
___
Python tracker rep
Changes by Gregory P. Smith g...@krypto.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6972
Gregory P. Smith added the comment:
this bug was likely introduced when i applied the telnetlib patches to use poll
to not hit the select fd limit. doh. nice catch!
--
nosy: +gregory.p.smith
___
Python tracker rep...@bugs.python.org
http
Gregory P. Smith added the comment:
re-yank it. that was unintentional. less sections == better.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17221
Gregory P. Smith added the comment:
os.fork() is a low level system call wrapper. Anyone using it needs to deal
with flushing whatever buffers their application has before forking among many
many other things. There is a reason it lives in the os module.
It is already a dangerous system
Gregory P. Smith added the comment:
An update to libffi is needed for all maintained versions of Python.
In 2.7, we're running into the stack being misaligned in 32-bit x86 code which
is something a libffi update fixes. It is a simple patch:
http://patchwork.ozlabs.org/patch/58128/
which
New submission from Gregory P. Smith:
The problem: without the stack being 16-byte aligned, code generated by modern
compilers like recent gcc/g++ or clang assumed that the stack is 16 byte
aligned and uses SSE instructions in some circumstances that require this.
Without this fix, any
Gregory P. Smith added the comment:
http://bugs.python.org/issue17245 filed to track the stack alignment issue.
The only reason i set this as release blocker is to let a release manager
decide which of these two issues to proceed with for 2.7.4 and 3.2.4 (and
3.3.1
Gregory P. Smith added the comment:
yeah that looks like stdin was closed or was /dev/null.
--
resolution: - invalid
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17291
Gregory P. Smith added the comment:
File /home/riley/pywikipedia/userinterfaces/terminal_interface_base.py, line
129, in input
text = getpass.getpass('')
you can't call getpass without stdin or a terminal and expect it to do
anything. your problem is in the pywikipedia code, not Python's
New submission from Gregory P. Smith:
bytearray has many methods that return a *new* bytearray object rather than
applying the transformation to modify the bytearray in place. Given that one
use of bytearray's is to avoid making extra copies... There should be in-place
variants
Gregory P. Smith added the comment:
Translate isn't a text operation. (That's the api I wanted). The others I
only lists for completeness because someone else would complain if I
hadn't. ;)
On Mar 1, 2013 12:57 PM, Terry J. Reedy rep...@bugs.python.org wrote:
Terry J. Reedy added the comment
Gregory P. Smith added the comment:
Yes! 2to3 features are allowed in stable releases.
On Mar 2, 2013 5:17 AM, Ezio Melotti rep...@bugs.python.org wrote:
Ezio Melotti added the comment:
Can this still go on 2.7/3.2/3.3?
--
___
Python tracker
Gregory P. Smith added the comment:
looks sane and cleaner than the silly x32 hack in there, i'll take care of it.
FYI - your patch forgot to add the unsigned char d_type; struct member before
name. fixed and applied.
When i wrote that code I was probably assuming that sticking
Gregory P. Smith added the comment:
The bytes (and bytearray?) version of this should generate memoryview's instead
of new bytes objects to avoid a copy.
While not required, It'd be useful if the implementation of this pre-scanned
the data internally so that the length of the generated
Gregory P. Smith added the comment:
Indeed, a bytearray version would require the talked about but not implemented
due to complexity (in pep3118) support for locking a buffer from other
mutations. best concentrate on bytes then.
Do we have a memoryview equivalent for PyUnicode? If not, we
Gregory P. Smith added the comment:
The important reasons for this are memory use and cache thrashing, not just
CPU time.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17301
Gregory P. Smith added the comment:
The gain will be more noticeable the faster the Python implementation it is
running under is. It is going to avoid logN relloc's in just about all
implementations. That CPython is relatively slow is not a justification to
avoid adding the feature.
I like
Changes by Gregory P. Smith g...@krypto.org:
--
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13229
Gregory P. Smith added the comment:
I'd like to take care of this at Python. At least for posix (someone else can
deal with the windows side if they want).
I just stumbled upon an extension module at work that someone wrote
specifically because os.listdir consumed way too much ram
Gregory P. Smith added the comment:
right he has a separate issue open tracking the walkdir stuff in
issue13229. I saw it first before finding this issue which is exactly what
I wanted. :)
--
___
Python tracker rep...@bugs.python.org
http
Gregory P. Smith added the comment:
It'd perhaps have been better if things like memoryview were never exposed to
the user at all as a distinct type and became an internal implementation detail
behind PyBytes and PyUnicode objects (they could hold a reference to something
else or collapse
Changes by Gregory P. Smith g...@krypto.org:
--
nosy: +gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3329
___
___
Python-bugs-list
Gregory P. Smith added the comment:
If this is done, it should probably be on by default on all --with-pydebug
buildbots. Otherwise I suspect nobody will _ever_ look at its output and we
should just remove the feature all together.
Being off in the main process on the build bots would still
Gregory P. Smith added the comment:
I'd personally say don't bother with this. Let people who _need_ this use
their own C extension modules to handle all secure data as we're not in a
position to make and test any guarantees about what happens to data anywhere
within a Python VM
Changes by Gregory P. Smith g...@krypto.org:
--
nosy: +gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3982
___
___
Python-bugs-list
Changes by Gregory P. Smith g...@krypto.org:
--
nosy: gregory.p.smith
priority: normal
severity: normal
status: open
title: imaplib.IMAP4_stream subprocess is opened unbuffered but ignores short
reads
___
Python tracker rep...@bugs.python.org
http
New submission from Gregory P. Smith:
imaplib.IMAP4_stream subprocess is opened unbuffered but ignores short reads
when reading the message body. Depending on timing, message body size and
kernel pipe buffer size and phase of the moon and whether you're debugging the
thing or not... It can
701 - 800 of 3243 matches
Mail list logo
