Hynek Schlawack h...@ox.cx added the comment:
Thanks for the feedback Antoine!
I updated the patch to latest default tip and added the requested tags to the
docs.
--
hgrepos: +97
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Changes by Hynek Schlawack h...@ox.cx:
Added file: http://bugs.python.org/file24062/8a9e14cda106.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12708
Changes by Hynek Schlawack h...@ox.cx:
Removed file: http://bugs.python.org/file22860/mp-starmap-w-docs.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12708
Hynek Schlawack h...@ox.cx added the comment:
You're right. I've updated the docs accordingly, thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12708
Changes by Hynek Schlawack h...@ox.cx:
Added file: http://bugs.python.org/file24063/c02fbcda56f3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12708
Changes by Hynek Schlawack h...@ox.cx:
Removed file: http://bugs.python.org/file24062/8a9e14cda106.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12708
Changes by Hynek Schlawack h...@ox.cx:
Added file: http://bugs.python.org/file24067/c92c4d936255.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12715
Hynek Schlawack h...@ox.cx added the comment:
I have updated the patch to latest default/tip and would appreciate a review.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12715
Changes by Hynek Schlawack h...@ox.cx:
Added file: http://bugs.python.org/file24069/4832bf7aa028.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12715
Hynek Schlawack h...@ox.cx added the comment:
Thanks to Antoine Charles-François for their reviews! I think I've
incorporated all desired changes.
Please let me know if I have missed something, meanwhile I'll tackle the docs.
--
___
Python tracker
Changes by Hynek Schlawack h...@ox.cx:
Added file: http://bugs.python.org/file24070/d9212bb67f64.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12715
Hynek Schlawack h...@ox.cx added the comment:
The patch contains also the necessary changes for the docs now.
Please let me know, if I can do anything else.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12715
Changes by Hynek Schlawack h...@ox.cx:
Added file: http://bugs.python.org/file24099/23e6204efe20.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12715
Hynek Schlawack h...@ox.cx added the comment:
Added another patch fixing the issues pointed out by Antoine and
Charles-François.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12715
Changes by Hynek Schlawack h...@ox.cx:
Added file: http://bugs.python.org/file24102/8330f2045f4d.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12715
Hynek Schlawack h...@ox.cx added the comment:
Added new patch with protection for the remaining UF_NODUMPs in the test case.
All raised issues should be fixed now. :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12715
Hynek Schlawack h...@ox.cx added the comment:
I took the liberty to fix the tests.
Basically I've adapted them to the new mock based cross file system approach
(that doesn't depend on luck anymore :)).
I also had to add one more `os.path.realpath` because on some OS (like OS X)
the tmp
Hynek Schlawack h...@ox.cx added the comment:
Oh sorry, I didn't look into the doc patch.
I unified both into one patch and added the versionchanged tag and also updated
the docstring of shutil.move.
--
Added file: http://bugs.python.org/file24149/shutil_move_symlinks.patch
Hynek Schlawack h...@ox.cx added the comment:
What's the current state here? Anyone working on a solution or are we waiting
how http://hg.python.org/features/pathlib/ will work out?
If the consensus is to add a generic walker method, wouldn't be appropriate to
open a new bug and add
Hynek Schlawack h...@ox.cx added the comment:
What's the current state here? Anyone working on a solution or are we
waiting how http://hg.python.org/features/pathlib/ will work out?
Well, I am not working on that one, so waiting for it to work out might
be optimistic :)
I don't know
New submission from Hynek Schlawack h...@ox.cx:
This is an offspring of #4489 (which is a security bug). The method is AFAIU
intended to be private.
As shown in the discussion of the mentioned #4489, there is a whole family of
attacks that exploit the time window between gathering path names
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13520
___
___
Python-bugs-list mailing list
Hynek Schlawack h...@ox.cx added the comment:
I took a deep dive into parts of CPython that were unknown to me :) and dug up
the following:
Methods like os.stat or even os.open convert the file name using et in
PyArg_ParseTuple[AndKeywords].
OTOH, open() and io.open() just hand through
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13849
___
___
Python-bugs-list mailing list
Hynek Schlawack h...@ox.cx added the comment:
JFTR, file()'s C equivalent is fileio_init and not io_open, I lost track of all
the opens. ;)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13848
Hynek Schlawack h...@ox.cx added the comment:
So I have good news and bad news. The good is: I fixed it for non-Win platforms
and the patch is truly beautiful:
Lib/test/test_builtin.py | 6 ++
Modules/_io/fileio.c | 25 -
2 files changed, 10 insertions
Hynek Schlawack h...@ox.cx added the comment:
I have fixed the refleak, added a _PyUnicode_HasNULChars and integrated it into
the Win32-unicode-if-branch. Couldn't test it due to lack of win32 – the
function itself is tested though.
--
Added file: http://bugs.python.org/file24355/open
Hynek Schlawack h...@ox.cx added the comment:
With Georg's kind help I added some improvements:
- I've been reluctant to waste heap for caching the nul string but he
convinced me that I was being ridiculous ;)
- For some reason there was a stray character inside, that should be fixed too
Hynek Schlawack added the comment:
“I wish I were wrangling inconsistent Windows buildbots.”
Nobody. Ever. *sigh*
It appears they are appeased now, so finally closing. Thanks for the patches
everyone!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open
New submission from Hynek Schlawack:
See issue16664.
--
assignee: docs@python
components: Documentation
keywords: easy
messages: 177584
nosy: Sebastian.Kreft, docs@python, hynek, pitrou
priority: normal
severity: normal
stage: needs patch
status: open
title: Clarify fnmatch glob docs
Hynek Schlawack added the comment:
Patch LGTM and will be applied, I have opened issue16695 for the related update
of the docs.
BTW how did you create the patch? The bugtracker/Rietveld didn't recognize it
for review and applying it took some effort too.
--
title: [PATCH] Test Glob
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
___
___
Python-bugs-list mailing list
Hynek Schlawack added the comment:
Thank you for your patch and welcome to CPython core development!
Presuming you want to submit more patches in future, please take the time to
sign a Python contributor agreement: http://www.python.org/psf/contrib/ .
You'll get a pretty star next to your
New submission from Hynek Schlawack:
Ah yeah I support this endeavor, I fixed a few instances in rmtree while
working on it. It’s just confusing.
JFTR, is there any rationale/reason to do it? Last time I checked it wasn’t
deprecated.
--
nosy: +hynek
Hynek Schlawack added the comment:
I think deprecation makes not big value.
We should continue aliases support and there are no place to raise warning.
What we can do — mention deprecation in the doc.
That’s what I meant. I saw it in shutil code, were confused, looked it up,
wondered why
Hynek Schlawack added the comment:
Serhiy, are you going to update your patches? I can implement the feedback of
our Q4 Community Service Award awardee too in case you’re busy.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Hynek Schlawack added the comment:
Thanks Serhiy!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16618
Hynek Schlawack added the comment:
I agree that standardize behavior here would be useful. But it sounds like a
candidate for 3.4. Unifying/changing it for existing releases appears rather
hairy to me?
--
assignee: docs@python -
type: - behavior
versions: +Python 3.4
Hynek Schlawack added the comment:
Any news? Wouldn’t Apple give us a license for our buildbots like MSFT does?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15594
Hynek Schlawack added the comment:
Turns out, Larry fixed these two while working on #14626.
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Hynek Schlawack added the comment:
I think we should resolve this one line change.
Jessica’s patch looks just fine, so I tend to apply it. However, I’d like to
document the current behavior in 2.7, 3.2, 3.3 and 3.4.
Am I missing anything?
--
nosy: +hynek
versions: +Python 2.7
Hynek Schlawack added the comment:
It would be great if someone could port this patch to Python 3.4 and verify its
effectiveness.
--
keywords: +easy -patch
stage: test needed - needs patch
versions: +Python 3.4 -Python 3.2, Python 3.3
___
Python
Hynek Schlawack added the comment:
The patch hasn’t incorporated Antoine’s comments AFAICT.
Also I don’t see this fit for back porting to bug fix releases. Correct me if
I’m wrong.
--
nosy: +hynek
stage: patch review - needs patch
versions: +Python 3.4 -Python 2.7, Python 3.2, Python
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15450
___
___
Python-bugs-list mailing list
New submission from Hynek Schlawack:
Glad to hear.
--
nosy: +hynek
resolution: - invalid
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16815
Hynek Schlawack added the comment:
bikeshed$(pwd)/bikeshed
--
stage: - patch review
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16591
Hynek Schlawack added the comment:
I’m fine with that. My focus was fixing the ticket metadata. :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16591
Hynek Schlawack added the comment:
I will review this first thing tomorrow.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6975
___
___
Python
Changes by Hynek Schlawack h...@ox.cx:
--
title: symlinks incorrectly resolved on Linux - symlinks incorrectly resolved
on POSIX platforms
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6975
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15881
___
___
Python-bugs-list mailing list
Hynek Schlawack added the comment:
I think since we ship cryptographic functions, we should take responsibility
and warn against the most common mistakes people do.
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Hynek Schlawack added the comment:
Could you add regression tests to your patch please?
--
assignee: - hynek
priority: high - normal
type: crash - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17076
Hynek Schlawack added the comment:
I would strongly prefer to back port certificate validation instead. Is there
anything *practical* that makes it hard/impossible?
If we want to keep features stable, we can add it privately so it’s only usable
by distutils. The susceptibility to (easy!) MITM
Changes by Hynek Schlawack h...@ox.cx:
--
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17076
___
___
Python-bugs-list
Hynek Schlawack added the comment:
The buildbots look happy, thank you for spotting the patch Thomas!
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17076
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17153
___
___
Python-bugs-list mailing list
Hynek Schlawack added the comment:
While I agree that it’s a problem, I’m a bit uneasy about changing that back to
2.7. I’m pretty sure this would break numerous programs.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Hynek Schlawack added the comment:
Yeah, I’m thinking about backup scripts etc.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17180
Hynek Schlawack added the comment:
SGTM. I’d like an explicit warning on the security implications in the docs
though.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17180
Hynek Schlawack added the comment:
Jyrki, roundup doesn’t seem to recognize you patch so we can’t review it in
Rietveld. Could you re-try, maybe using hg?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11063
Hynek Schlawack added the comment:
I feel like there should be a warning in Doc/library/xml.rst too.
Is there any actual reason why we don’t ship defusedxml with Python and add an
easy way to monkeypatch so there’s as little passive barriers as possible to
use XML “safely”?
I’m sorry I
New submission from Hynek Schlawack h...@ox.cx:
After I've seen a co-worker to unpack tuples while using
multiprocessing.Pool.map(), I realized that the module is missing a starmap()
method like itertools has.
I took it as a opportunity to contribute some code and implemented both
starmap
New submission from Hynek Schlawack h...@ox.cx:
While working on #12708 , I noticed that the error_callback argument of
multiprocessing.Pool.map_async() isn't documented (callback is).
--
assignee: docs@python
components: Documentation
messages: 141763
nosy: docs@python, hynek
priority
Hynek Schlawack h...@ox.cx added the comment:
In all my excitement, I somehow presumed that the docstring automagically lands
in the docs. Added doc entries to patch (I hope they aren't too crude, I'm not
a native speaker).
Same as first patch otherwise.
--
Added file: http
Hynek Schlawack h...@ox.cx added the comment:
Yeah, if my 3G hadn't failed on me, it would have been already here. :)
As a matter of fact, the argument is discussed in the body of the doc, it just
has been omitted in the method definition, so the patch is trivial.
--
keywords: +patch
Changes by Hynek Schlawack h...@ox.cx:
Removed file: http://bugs.python.org/file22859/mp-starmap.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12708
Hynek Schlawack h...@ox.cx added the comment:
Additionally copyfile() might be fixed to understand symlinks=True too.
Currently working on a patch for all 5 of them.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12715
New submission from Hynek Schlawack h...@ox.cx:
While working on #12715 I noticed that the tests of shutil aren't exactly
consistent concerning reading and writing files.
There were no less than two function to read files (one of them not being used
at all) and two methods to write them
Hynek Schlawack h...@ox.cx added the comment:
JFTR, my implementation is ready, but I can't/don't want to start writing
tests, as long as #12721 is open.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12715
Hynek Schlawack h...@ox.cx added the comment:
I tend to agree on public APIs, however in this case of a helper function the
use case with a join is really really common so this extra function comes in
very handy. I also kept it using lists, so it's more obvious than tuples.
JFTR it wasn't my
Hynek Schlawack h...@ox.cx added the comment:
No, that's just a helper function like the `mapstar` directly above. args[1] is
the iterable with tuples that get unpacked as arguments.
--
___
Python tracker rep...@bugs.python.org
http
Hynek Schlawack h...@ox.cx added the comment:
Eric, just to be clear: Are you making this list-tuple change or should I fix
the patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12721
Hynek Schlawack h...@ox.cx added the comment:
This is a sub-issue of #12715.
ATM the consent is to add just one symlinks parameter and use the l* functions
iff src _and_ dst are symlinks.
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
Hynek Schlawack h...@ox.cx added the comment:
I work on the superficially related #12715 (symlinks for shutil). As we try to
mimic the POSIX tools and `mv` indeed doesn't follow links, I agree with the
approach of this patch.
--
nosy: +hynek
Hynek Schlawack h...@ox.cx added the comment:
We have an edge case when the caller calls copymode with symlinks=True on an OS
that doesn't have lchmod (ie any other than FreeBSD).
Should it be a nop (as in copystat), use chmod or raise an Exception?
I Personally (and some people on #python
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4489
___
___
Python-bugs-list mailing list
Hynek Schlawack h...@ox.cx added the comment:
While writing my tests I realized, it would be really useful to make
write_file() return the path it wrote to. I need the concatenated filenames
most of the time, so I'm getting blocks of:
fn = os.path.join(x,y)
write_file(fn, 'contents')
I'd
New submission from Hynek Schlawack h...@ox.cx:
test_shutil contains a handy helper function called write_file(filename.
contents). If *filename* is a tuple, os.path.join() is used to concatenate it
to a path.
To be really useful, the resulting file name should be returned, so the user
can
Hynek Schlawack h...@ox.cx added the comment:
Done in Issue12824.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12721
___
___
Python-bugs-list
Hynek Schlawack h...@ox.cx added the comment:
ok. it would have saved some LOC for me, but it's nothing essential of course.
--
resolution: - rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12824
Hynek Schlawack h...@ox.cx added the comment:
What started as a 2 lines fix, grew to a patch of ~400 lines. :)
It's mostly tests though:
Lib/shutil.py | 102 +--
Lib/test/test_shutil.py | 220
Changes by Hynek Schlawack h...@ox.cx:
--
keywords: +patch
Added file: http://bugs.python.org/file23028/e126ceae5ba9.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12715
Hynek Schlawack h...@ox.cx added the comment:
Here's against 2.7 which proved to be a can of worms. I tried to be as
unobstructive as possible.
Please have a look at it, I'm sure I forgot some parenthesis somewhere.
--
Added file: http://bugs.python.org/file25576/doc-default-args-v2
Hynek Schlawack h...@ox.cx added the comment:
On it.
I wonder whether it causes trouble that we return an invalid time_struct down
the road?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14157
Hynek Schlawack h...@ox.cx added the comment:
I have added a restoration including a short explanation + a regression test.
--
Added file: http://bugs.python.org/file25580/strptime-restore-1900.diff
___
Python tracker rep...@bugs.python.org
http
Hynek Schlawack h...@ox.cx added the comment:
Small adjustments to the test as discussed in IRC.
--
assignee: - hynek
resolution: fixed -
stage: committed/rejected - patch review
type: enhancement - behavior
Added file: http://bugs.python.org/file25581/strptime-restore-1900-v2.diff
Hynek Schlawack h...@ox.cx added the comment:
I've cross-checked the patch against the RFC and it LGTM. Tests still pass as
expected.
--
nosy: +hynek
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14809
Hynek Schlawack h...@ox.cx added the comment:
Would you mind adding more information like the full traceback? By saying
compilation error, I presume you mean the compilation of the t33a.py file
into byte code (and not compilation of Python itself)?
I can't reproduce it neither
Hynek Schlawack h...@ox.cx added the comment:
You are right, file system encoding was platform dependent, not file encoding.
This space-after-parentheses trigger is odd; I'm adding the Windows guys to the
ticket. Please tell us also your exact version of Windows.
--
components
Hynek Schlawack h...@ox.cx added the comment:
EungYun,
After further research I've found two issue which you should fix before it can
be checked in:
- The multi-line strings are missing spaces at their line break (429 and 431).
- The error codes are documented at
http://hg.python.org
Hynek Schlawack h...@ox.cx added the comment:
I just realized it doesn't really make sense because if a file disappears for
real, we'll get another FileNotFoundException when checking whether it's a
symlink and the continue is never reached.
So behold v3. :)
This time, I have tested
Changes by Hynek Schlawack h...@ox.cx:
--
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14773
Hynek Schlawack h...@ox.cx added the comment:
Thank you for your contribution to Python, EungJun!
Just two small remarks:
- Please sign and submit the contributor form from
http://www.python.org/psf/contrib/ . You'll get a nice star next to your name
in return. :)
- I have fixed the flow
Changes by Hynek Schlawack h...@ox.cx:
--
resolution: - fixed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14773
___
___
Python-bugs-list
Hynek Schlawack h...@ox.cx added the comment:
I'm afraid I have to close this one as rejected. It works as documented and
it's unlikely we'll decide to change it back. I'm sorry.
--
resolution: - rejected
stage: needs patch - committed/rejected
status: open - closed
Hynek Schlawack h...@ox.cx added the comment:
Why is this one still open? I'm afraid the questions raised aren't fit to be
discussed in a ticket (weren't the outsourcing of of stdlib an item at the
language summit?).
I tend to close it as rejected (although I rather disagree) unless someone
Hynek Schlawack h...@ox.cx added the comment:
This one has been fixed together with #14662 in e12efebc3ba6.
Thank you everyone for your input!
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep
Hynek Schlawack h...@ox.cx added the comment:
Andrew, are you still with us?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14702
___
___
Python
Hynek Schlawack h...@ox.cx added the comment:
Brian, are you going to update that patch so we can close this? :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14772
Hynek Schlawack h...@ox.cx added the comment:
Jeff, are you still interested in updating your patch or would you prefer if
someone else tackled it?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7719
1 - 100 of 375 matches
Mail list logo
