[issue28969] lru_cache is not threadsafe

2017-01-09 Thread INADA Naoki
INADA Naoki added the comment: LGTM -- nosy: +inada.naoki ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue28969> ___ ___ Python-bugs-

[issue26382] List object memory allocator

2016-12-29 Thread INADA Naoki
INADA Naoki added the comment: OK. I didn't know PyMem and PyObject allocators are always same. No reason to change Python 3. How about Python 2? Off topic: I want to know which of PyMem and PyObject allocator is preferred when writing new code. -- versions: -Python 3.7

[issue29062] hashlib documentation link error

2016-12-30 Thread INADA Naoki
INADA Naoki added the comment: May I commit merge-hashlib-blake2.patch to 3.6 branch? -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-04 Thread INADA Naoki
INADA Naoki added the comment: I'm sorry. I must search old discussion about why we can't simply use utf-8 for fsencoding when C locale, instead of asking here. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-06 Thread INADA Naoki
INADA Naoki added the comment: >> stderr is used to log errors. Getting a new error when trying to log >> an error is kind of annoying. > > Hm, what bad surprise/error could appear that would not appear with > backslashescape? $ cat badfilename.py badfn = "こんにちは&quo

[issue29178] Adding bytes.frombuffer(byteslike) constructor

2017-01-06 Thread INADA Naoki
New submission from INADA Naoki: # Summary ## 1. Making bytes from slice of bytearray easy and efficient. bs = bytes(memoryview(bytelike)[start:end]) works fine on CPython, but it will cause issue on PyPy. Since memoryview is not closed explicitly, exception like "BufferError: Exi

[issue15216] Support setting the encoding on a text stream after creation

2017-01-10 Thread INADA Naoki
INADA Naoki added the comment: This patch doesn't change current behavior of "decode by chunk". It's difficult to support changing encoding via header, like Python's encoding cookie. >>> import io >>> buff = io.BytesIO("hello\nこんにちは".encode('utf-8')) &

[issue15216] Support setting the encoding on a text stream after creation

2017-01-10 Thread INADA Naoki
INADA Naoki added the comment: I had not read the patch carefully when updating. Now I'm reading pure Python part of the patch. For writing side, this patch is very simple. For reading side, this patch is very complex, because TextIOWrapper.tell() and .seek() is complex already. How about

[issue28158] Implement LOAD_GLOBAL opcode cache

2016-12-19 Thread INADA Naoki
INADA Naoki added the comment: > Actually, if you don't mind, I'd like to update the patch myself. I have a > few ideas how to restructure it and add support for LOAD_ATTR. Sounds interesting. I'll wait to touch this patch. There are enough time by Python 3.7 and enough other issues

[issue29019] dict.fromkeys overallocates when given a sparse dict

2016-12-19 Thread INADA Naoki
INADA Naoki added the comment: While the patch is trivial, I need LGTM from another comitter. -- stage: -> patch review Added file: http://bugs.python.org/file45974/fromkeys2.patch ___ Python tracker <rep...@bugs.python.org> <http://bug

[issue29019] dict.fromkeys overallocates when given a sparse dict

2016-12-19 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <rep...@bugs.python.org> <http://bu

[issue29019] dict.fromkeys overallocates when given a sparse dict

2016-12-19 Thread INADA Naoki
INADA Naoki added the comment: Since `seq` is checked by PyDict_CheckExact(seq) already, ((PyDictObject*)seq)->ma_used may be better. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.or

[issue28988] Switch dict and set structures to PyVarObject

2016-12-20 Thread INADA Naoki
INADA Naoki added the comment: LGTM -- nosy: +inada.naoki ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue28988> ___ ___ Python-bugs-

[issue28147] Unbounded memory growth resizing split-table dicts

2016-12-19 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: Added file: http://bugs.python.org/file45968/fix-28147-py35-2.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue28999] Use Py_RETURN_NONE and like

2016-12-20 Thread INADA Naoki
INADA Naoki added the comment: LGTM -- nosy: +inada.naoki ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue28999> ___ ___ Python-bugs-

[issue28158] Implement LOAD_GLOBAL opcode cache

2016-12-20 Thread INADA Naoki
INADA Naoki added the comment: memo: http://bugs.python.org/issue26219 may be relating to this. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue24165] Free list for single-digits ints

2016-12-20 Thread INADA Naoki
INADA Naoki added the comment: Performance version: 0.5.0 Python version: 3.7.0a0 (64-bit) revision 31df7d9863f3+ Report on Linux-4.8.0-30-generic-x86_64-with-debian-stretch-sid Slower (13): - nbody: 232 ms +- 3 ms -> 241 ms +- 6 ms: 1.04x slower - unpack_sequence: 118 ns +- 3 ns -> 121 n

[issue29049] Lazy GC tracking frame

2016-12-24 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <rep...@bugs.python.org> <http://bu

[issue29049] Lazy GC tracking frame

2016-12-24 Thread INADA Naoki
INADA Naoki added the comment: (Rietveld shows 500 error when replying.) > Minor style note: Use Py_REFCNT here to simplify? Fixed when committing. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.or

[issue26382] List object memory allocator

2016-12-28 Thread INADA Naoki
INADA Naoki added the comment: Update patch for Python 2.7 -- nosy: +inada.naoki versions: +Python 3.7 -Python 3.6 Added file: http://bugs.python.org/file46063/listobject_CPython2-2.patch ___ Python tracker <rep...@bugs.python.org>

[issue29059] Windows: Python not using ANSI compatible console

2016-12-24 Thread INADA Naoki
INADA Naoki added the comment: Is it a global state, or application specific state? In other words, if Python enables VT100, doesn't it remain after os._exit(1)? If it is global state of console, why Python should change it? Shouldn't user who want to use VT100 enable it before starting Python

[issue29049] Lazy GC tracking frame

2016-12-24 Thread INADA Naoki
INADA Naoki added the comment: > Please wrap private functions in #ifndef Py_LIMITED_API/#endif. No problem. Whole Include/frameobject.h is wrapped by Py_LIMITED_API. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.or

[issue29062] hashlib documentation link error

2016-12-24 Thread INADA Naoki
INADA Naoki added the comment: 1. remove `.. module:: hashlib` from Doc/library/hashlib-blake2.rst 2. merge Doc/library/hashlib-blake2.rst content into Doc/library/hashlib.rst Hmm, which is better? -- nosy: +inada.naoki ___ Python tracker <

[issue28293] Don't completely dump the regex cache when full

2016-12-24 Thread INADA Naoki
INADA Naoki added the comment: LGTM for re_cache_ordered_dict_popitem.patch -- nosy: +inada.naoki ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue29089] dictionary keys described incorrectly in tutorial

2016-12-27 Thread INADA Naoki
INADA Naoki added the comment: > If precision is the problem, could it be reworded to be more vague? "can be any immutable" seems vague enough to me. It doesn't say "cannot be any mutable type.". > Users are likely to assume documentation from any official s

[issue29089] dictionary keys described incorrectly in tutorial

2016-12-27 Thread INADA Naoki
INADA Naoki added the comment: > It's the tutorial. Probably better to just leave it alone. Precise > understanding can come later. I agree. Beginner should start using dict with builtin immutable type as key. hashable is too complex at this point. -- nosy: +inada

[issue26382] List object memory allocator

2016-12-28 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: Added file: http://bugs.python.org/file46066/listobject_CPython3-2.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue29062] hashlib documentation link error

2016-12-26 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <rep...@bugs.python.org> <http://bu

[issue29028] Use-After-Free in PyString_FromStringAndSize() of stringobject.c

2016-12-26 Thread INADA Naoki
INADA Naoki added the comment: LGTM -- nosy: +inada.naoki ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue29028> ___ ___ Python-bugs-

[issue29062] hashlib documentation link error

2016-12-27 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: Added file: http://bugs.python.org/file46051/merge-hashlib-blake2.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue29062] hashlib documentation link error

2016-12-26 Thread INADA Naoki
INADA Naoki added the comment: While section level of Module, Examples, and Credits is fixed, https://docs.python.org/3/library/crypto.html seems still weird. It looks like there are two `hashlib` modules. Now I think hashlib-blake2 should be merged into hashlib. -- resolution: fixed

[issue29062] hashlib documentation link error

2016-12-27 Thread INADA Naoki
INADA Naoki added the comment: > That is because hashlib-blake2.rst is explicitly added to the TOC list in > Doc/library/crypto.rst. Yes. All rst should be explicitly added by `toctree` or `include`. In this case, I feel there are no reason to use `include` directive instead of mergi

[issue29062] hashlib documentation link error

2016-12-27 Thread INADA Naoki
INADA Naoki added the comment: > INADA, 3.6 branch also suffers the problems here, I didn't see you patch it. Oh, I'm sorry. I'll update 3.6 branch in next time. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.or

[issue29049] Lazy GC tracking frame

2016-12-25 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: Added file: http://bugs.python.org/file46038/29049-fix-generator-refleak.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue28818] simplify lookdict functions

2016-12-27 Thread INADA Naoki
INADA Naoki added the comment: http://bugs.python.org/issue28427#msg284101 > Sidenote: all branches now have a different version of dict object each, > which makes maintenance really painful... Large difference between py36 and py37 is this patch. Can I backport this to py36 t

[issue29049] Lazy GC tracking frame

2016-12-22 Thread INADA Naoki
New submission from INADA Naoki: Don't _PyObject_GC_TRACK(frame) before using it. After evaluation is finished, do tracking only if refcnt is not one. result without --enable-optimization: $ ~/local/cpython/bin/pyperf compare_to default.json.gz patched.json.gz -G Slower (15

[issue26110] Speedup method calls 1.2x

2016-12-19 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: Added file: http://bugs.python.org/file45963/call-method-doc4.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue28383] __hash__ documentation recommends naive XOR to combine but this is suboptimal

2016-12-19 Thread INADA Naoki
INADA Naoki added the comment: LGTM -- nosy: +inada.naoki ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue28383> ___ ___ Python-bugs-

[issue28147] Unbounded memory growth resizing split-table dicts

2016-12-19 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <rep...@bugs.python.org> <http://bu

[issue28158] Implement LOAD_GLOBAL opcode cache

2016-12-19 Thread INADA Naoki
INADA Naoki added the comment: I'll update this patch and #10401 and then run benchmark suite when I have time. As far as I look quickly, #10401 uses namei as cache key and this patch uses opcode index as cache key, am I right? -- nosy: +inada.naoki priority: critical -> nor

[issue25617] Installing local installation of Python

2016-12-19 Thread INADA Naoki
INADA Naoki added the comment: I can't understand what's your problem. > The inherent behaviour of python installations (local or global) is such that > it expects to source system wide modules from the global python installation. What local installation means? What global installation

[issue24165] Free list for single-digits ints

2016-12-19 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: -- nosy: +inada.naoki versions: +Python 3.7 -Python 3.6 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue10614] ZipFile: add a filename_encoding argument

2016-12-26 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: Added file: http://bugs.python.org/file46043/10614-zipfile-encoding.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue10614] ZipFile: add a filename_encoding argument

2016-12-26 Thread INADA Naoki
INADA Naoki added the comment: Thanks. Patch posted in issue28080 looks better than mine. -- stage: patch review -> superseder: -> Allow reading member names with bogus encodings in zipfile ___ Python tracker <rep...@bugs.python.o

[issue26758] Unnecessary format string handling for no argument slot wrappers in typeobject.c

2016-12-26 Thread INADA Naoki
INADA Naoki added the comment: fixed via https://hg.python.org/cpython/rev/adcd9131b7c6 -- nosy: +inada.naoki resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <rep...@bugs.pytho

[issue29062] hashlib documentation link error

2016-12-26 Thread INADA Naoki
INADA Naoki added the comment: I like currentmodule directive. -- keywords: +patch Added file: http://bugs.python.org/file46040/29062-currentmodule.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue28080] Allow reading member names with bogus encodings in zipfile

2016-12-26 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: -- nosy: +inada.naoki ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue28080> ___ _

[issue26787] test_distutils fails when configured --with-lto

2016-12-26 Thread INADA Naoki
INADA Naoki added the comment: LGTM -- nosy: +inada.naoki ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue26787> ___ ___ Python-bugs-

[issue29049] Lazy GC tracking frame

2016-12-26 Thread INADA Naoki
INADA Naoki added the comment: > It seems to me, that the part with Py_DECREF should be pushed to older > branches. PyCoro_New() and PyGen_NewWithQualName() steals f reference, and DECREF when error. So Py_DECREF is not needed when (gen == NULL). My patch was

[issue27671] FAQ: len() is still function for good reason.

2016-12-26 Thread INADA Naoki
INADA Naoki added the comment: I can't write long English document. Can I quote Guido's mail instead? -- keywords: +patch Added file: http://bugs.python.org/file46041/faq-function-method.patch ___ Python tracker <rep...@bugs.python.org>

[issue10614] ZipFile: add a filename_encoding argument

2016-12-26 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: Removed file: http://bugs.python.org/file46042/10614-zipfile-encoding.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue29049] Lazy GC tracking frame

2016-12-26 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: -- status: open -> closed ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue29049> ___ _

[issue10614] ZipFile: add a filename_encoding argument

2016-12-26 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: -- components: +Library (Lib) -Extension Modules stage: -> patch review versions: +Python 3.6, Python 3.7 -Python 3.2, Python 3.3 Added file: http://bugs.python.org/file46042/10614-zipfile-encod

[issue26110] Speedup method calls 1.2x

2016-12-07 Thread INADA Naoki
INADA Naoki added the comment: $ ./python-default -m perf compare_to default.json callmethod4.json -G Slower (7): - pickle_dict: 66.0 us +- 4.6 us -> 77.0 us +- 5.9 us: 1.17x slower - json_loads: 63.7 us +- 0.7 us -> 68.4 us +- 1.4 us: 1.07x slower - unpack_sequence: 120 ns +- 2 ns -&g

[issue26110] Speedup method calls 1.2x

2016-12-07 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: Added file: http://bugs.python.org/file45788/callmethod4.json.gz ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue29049] Lazy GC tracking frame

2016-12-22 Thread INADA Naoki
INADA Naoki added the comment: --enable-optimizations: $ ~/local/cpython/bin/pyperf compare_to -G default.json patched.json Slower (12): - pickle_dict: 42.0 us +- 0.2 us -> 42.9 us +- 0.2 us: 1.02x slower (+2%) - regex_dna: 228 ms +- 1 ms -> 233 ms +- 2 ms: 1.02x slower (+2%) - unpickl

[issue29049] Lazy GC tracking frame

2016-12-22 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: Added file: http://bugs.python.org/file46000/default.json.gz ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue29278] Python 3.6 build fails with parallel make

2017-01-15 Thread INADA Naoki
INADA Naoki added the comment: Isn't it a OOM killer? How much memory your machine has? How about make -j4? (you can use number of cores instead of 4). -- nosy: +inada.naoki ___ Python tracker <rep...@bugs.python.org> <http://bugs.p

[issue26110] Speedup method calls 1.2x

2017-01-15 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: Added file: http://bugs.python.org/file46294/call-method-doc5.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue29859] Return code of pthread_* in thread_pthread.h is not used for perror

2017-03-21 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: -- pull_requests: +666 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue29859> ___

[issue28331] "CPython implementation detail:" removed when content translated

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 906118d8c68160ed4a3d15cec803d1ee57836517 by INADA Naoki in branch '3.6': bpo-28331: fix impl-detail label is removed when content is translated. (GH-769) https://github.com/python/cpython/commit/906118d8c68160ed4a3d15cec803d1ee57836517

[issue29643] --enable-optimizations compiler flag has no effect

2017-03-28 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: -- pull_requests: +768 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue29643> ___

[issue29643] --enable-optimizations compiler flag has no effect

2017-03-28 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: -- pull_requests: +770 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue29643> ___

[issue29643] --enable-optimizations compiler flag has no effect

2017-03-28 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: -- pull_requests: +771 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue29643> ___

[issue29643] --enable-optimizations compiler flag has no effect

2017-03-28 Thread INADA Naoki
INADA Naoki added the comment: New changeset 8cea5929f52801b0ce5928b46ef836e99a24321a by INADA Naoki (Alex Wang) in branch 'master': bpo-29643: Fix check for --enable-optimizations (GH-129) https://github.com/python/cpython/commit/8cea5929f52801b0ce5928b46ef836e99a24321a -- nosy

[issue29643] --enable-optimizations compiler flag has no effect

2017-03-28 Thread INADA Naoki
INADA Naoki added the comment: New changeset f01de61a8efea8319c65365898982f929d59a895 by INADA Naoki in branch '3.6': bpo-29643: Fix check for --enable-optimizations (GH-869) https://github.com/python/cpython/commit/f01de61a8efea8319c65365898982f929d59a895

[issue29643] --enable-optimizations compiler flag has no effect

2017-03-28 Thread INADA Naoki
INADA Naoki added the comment: New changeset e6a49531568561fe5aaf662259ecb7b4bc2426be by INADA Naoki in branch '3.5': bpo-29643: Fix check for --enable-optimizations (GH-871) https://github.com/python/cpython/commit/e6a49531568561fe5aaf662259ecb7b4bc2426be

[issue29643] --enable-optimizations compiler flag has no effect

2017-03-28 Thread INADA Naoki
INADA Naoki added the comment: New changeset 6a04ef7ceddae0930eba6cc57ba2ebfcef00abab by INADA Naoki in branch '2.7': bpo-29643: Fix check for --enable-optimizations (GH-873) https://github.com/python/cpython/commit/6a04ef7ceddae0930eba6cc57ba2ebfcef00abab

[issue29643] --enable-optimizations compiler flag has no effect

2017-03-28 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <rep...@bugs.python.org> <http://bu

[issue29859] Return code of pthread_* in thread_pthread.h is not used for perror

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset d7fa6b259e00fca04dbf816bfcf4115fdda14bb7 by INADA Naoki (Daniel Birnstiel) in branch 'master': bpo-29859: Fix error messages from return codes for pthread_* calls (GH-741) https://github.com/python/cpython/commit

[issue29859] Return code of pthread_* in thread_pthread.h is not used for perror

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset fe30339534c602af1123e1402e44a1463f91f2e5 by INADA Naoki in branch '3.6': bpo-29859: Fix error messages from return codes for pthread_* calls (GH-753) https://github.com/python/cpython/commit/fe30339534c602af1123e1402e44a1463f91f2e5

[issue29592] abs_paths() in site.py is slow

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 2e4e011795d26cab1a3843383d0539c12fea2458 by INADA Naoki in branch 'master': bpo-29592: site: skip abs_paths() when it's redundant (GH-167) https://github.com/python/cpython/commit/2e4e011795d26cab1a3843383d0539c12fea2458

[issue29676] C method is not profiled by lsprof

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 93fac8dd358cd0e85e7b59115db226ce685d3f6f by INADA Naoki in branch 'master': bpo-29676: fix lsprof can't profile C method call. (GH523) https://github.com/python/cpython/commit/93fac8dd358cd0e85e7b59115db226ce685d3f6f

[issue29719] "Date" of what's new is confusing

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 2225ddaa9e64c086b2b6997b0c9ac50921f7aa85 by INADA Naoki in branch 'master': bpo-29719: Remove Date and Release field in whatsnew/3.6 (GH-494) https://github.com/python/cpython/commit/2225ddaa9e64c086b2b6997b0c9ac50921f7aa85

[issue29637] ast.get_docstring(): AttributeError: 'NoneType' object has no attribute 'expandtabs'

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 41cea70aa38de50c1d714209aa2b7694d86a7e0c by INADA Naoki (Matthias Bussonnier) in branch 'master': bpo-29637: clean docstring only if not None (GH-267) https://github.com/python/cpython/commit/41cea70aa38de50c1d714209aa2b7694d86a7e0c

[issue29622] ast module doesn't support optional fields of Parser/Python.asdl

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 4c78c527d215c37472145152cb0e95f196cdddc9 by INADA Naoki in branch 'master': bpo-29622: Make AST constructor to accept less than enough number of positional arguments (GH-249) https://github.com/python/cpython/commit

[issue29463] Add `docstring` field to AST nodes

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 4c78c527d215c37472145152cb0e95f196cdddc9 by INADA Naoki in branch 'master': bpo-29622: Make AST constructor to accept less than enough number of positional arguments (GH-249) https://github.com/python/cpython/commit

[issue29438] use after free in key sharing dict

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 06a4fcb2458c5904968b5c8fe6b64940ba83a50d by INADA Naoki in branch '3.5': bpo-29438: Fixed use-after-free in key sharing dict (#40) https://github.com/python/cpython/commit/06a4fcb2458c5904968b5c8fe6b64940ba83a50d

[issue29438] use after free in key sharing dict

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 89ddffbe9dcb38b79f99563b0d4d594d1105a192 by INADA Naoki in branch '3.6': bpo-29438: fixed use-after-free in key sharing dict (#39) https://github.com/python/cpython/commit/89ddffbe9dcb38b79f99563b0d4d594d1105a192

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 5dc33eea538361f8a218255f83db2e9298dd8c53 by INADA Naoki in branch 'master': bpo-29110: add test for Aifc_write. (GH-293) https://github.com/python/cpython/commit/5dc33eea538361f8a218255f83db2e9298dd8c53

[issue29438] use after free in key sharing dict

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 2294f3aee14a6074b17c67ef936c607430bb3c7a by INADA Naoki in branch 'master': bpo-29438: fixed use-after-free in key sharing dict (#17) https://github.com/python/cpython/commit/2294f3aee14a6074b17c67ef936c607430bb3c7a

[issue29719] "Date" of what's new is confusing

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 4e1a065c20856a00d0fe88ce022b249170608058 by INADA Naoki in branch '3.6': bpo-29719: Remove Date and Release field in whatsnew/3.6 (GH-500) https://github.com/python/cpython/commit/4e1a065c20856a00d0fe88ce022b249170608058

[issue29548] Recommend PyObject_Call* APIs over PyEval_Call*() APIs

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset aa289a59ff6398110e1122877c073c9354ee53db by INADA Naoki in branch 'master': bpo-29548: Recommend PyObject_Call APIs over PyEval_Call APIs. (GH-75) https://github.com/python/cpython/commit/aa289a59ff6398110e1122877c073c9354ee53db

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 02eb4b0bd4a7d86cf5e40567aaa8710b00e079a4 by INADA Naoki in branch '2.7': bpo-29110: Fix file object leak in aifc.open (GH-356) https://github.com/python/cpython/commit/02eb4b0bd4a7d86cf5e40567aaa8710b00e079a4

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset c9131b61fa060a51ec181053cade9f0a7ee91e4f by INADA Naoki in branch '3.6': [3.6] bpo-29110: Fix file object leak in `aifc.open` (#310) https://github.com/python/cpython/commit/c9131b61fa060a51ec181053cade9f0a7ee91e4f

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset b7fb1e25c89a9eb85b95027f4167bc0977687c43 by INADA Naoki in branch '3.5': bpo-29110: Fix file object leak in `aifc.open` (GH-311) https://github.com/python/cpython/commit/b7fb1e25c89a9eb85b95027f4167bc0977687c43

[issue28331] "CPython implementation detail:" removed when content translated

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset c351ce6a2c923c5016e48ecbf7b1e4833031d154 by INADA Naoki in branch 'master': bpo-28331: fix impl-detail label is removed when content is translated. (GH-195) https://github.com/python/cpython/commit/c351ce6a2c923c5016e48ecbf7b1e4833031d154

[issue29684] Minor regression in PyEval_CallObjectWithKeywords()

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 023532e558bb0c5bf60195aebbafe63a0bebd85e by INADA Naoki in branch '3.6': bpo-29684: Fix minor regression of PyEval_CallObjectWithKeywords. (GH-378) https://github.com/python/cpython/commit/023532e558bb0c5bf60195aebbafe63a0bebd85e

[issue29684] Minor regression in PyEval_CallObjectWithKeywords()

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 3824cd8fd44f287ea2a76120a39ee76eb34bbf32 by INADA Naoki in branch 'master': bpo-29684: Fix regression of PyEval_CallObjectWithKeywords (GH-87) https://github.com/python/cpython/commit/3824cd8fd44f287ea2a76120a39ee76eb34bbf32

[issue29949] sizeof set after set_merge() is doubled from 3.5

2017-03-30 Thread INADA Naoki
New submission from INADA Naoki: (original thread is https://mail.python.org/pipermail/python-list/2017-March/720391.html) https://github.com/python/cpython/commit/4897300276d870f99459c82b937f0ac22450f0b6 this commit doubles sizeof set object created by set_merge(). It is used by constructor

[issue29952] "keys and values" is preferred to "keys and elements" for name of dict constituent

2017-03-31 Thread INADA Naoki
INADA Naoki added the comment: New changeset f3158121132a1519439bf4c7dbab07802d6d by INADA Naoki in branch '3.5': bpo-29952: Use usual terminology of dict (GH-923) https://github.com/python/cpython/commit/f3158121132a1519439bf4c7dbab07802d6d

[issue29949] sizeof set after set_merge() is doubled from 3.5

2017-03-31 Thread INADA Naoki
INADA Naoki added the comment: I agree. Before thinking about rebalance between size and speed, resolving regression is important. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue29949] sizeof set after set_merge() is doubled from 3.5

2017-03-31 Thread INADA Naoki
INADA Naoki added the comment: See set_update_internal(). https://github.com/python/cpython/blob/master/Objects/setobject.c#L969-L1016 This happens only when iterable is set or dict. >>> import sys >>> sys.getsizeof(set(range(10))) 736 >>> sys.getsizeo

[issue29949] sizeof set after set_merge() is doubled from 3.5

2017-03-31 Thread INADA Naoki
INADA Naoki added the comment: > frozenset(range(n)) is slightly larger in 3.7 than in 3.6. It is 4 times > larger for about 10% of sizes. This is intensional: https://github.com/python/cpython/commit/5cd87a8d61246b0a6233bfb8503d4718b693cef0 load factor is reduced from 66% to 60%

[issue29859] Return code of pthread_* in thread_pthread.h is not used for perror

2017-03-20 Thread INADA Naoki
INADA Naoki added the comment: I don't know your patch is worth enough or not. (I dislike fprintf(stderr, ...) at least). But my advice is stop mixing multithreading and fork (except fork+exec). It's almost impossible. While Python has GIL, some extension can release GIL and run any C code

[issue29863] Add a COMPACT constant to the json module

2017-03-21 Thread INADA Naoki
INADA Naoki added the comment: -0. COMPACT_SEPARATOR make more sense to me. Because `ensure_ascii=False` may make JSON more compact too. -- nosy: +inada.naoki ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue29859] Return code of pthread_* in thread_pthread.h is not used for perror

2017-03-21 Thread INADA Naoki
INADA Naoki added the comment: OK, perror() writes to stderr too. fair enough. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue29859] Return code of pthread_* in thread_pthread.h is not used for perror

2017-03-20 Thread INADA Naoki
INADA Naoki added the comment: Could you give us minimum sample Python code to reproduce the error? -- nosy: +inada.naoki ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue28331] "CPython implementation detail:" removed when content translated

2017-03-22 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: -- pull_requests: +676 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue28331> ___

[issue28331] "CPython implementation detail:" removed when content translated

2017-03-22 Thread INADA Naoki
Changes by INADA Naoki <songofaca...@gmail.com>: -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 2.7, Python 3.5 ___ Python tracker <rep...@bugs.python.org> <http://bu

<    3   4   5   6   7   8   9   10   11   12   >