[issue3568] list enumeration corrupt when remove()

2008-08-16 Thread Jacek
New submission from Jacek <[EMAIL PROTECTED]>: Hi I wrote my first program in python, and I found bug in it. I explain it in example (I do it under Windows XP): 1. At the begining create some directories: >mkdir .\test\ >mkdir .\test\.svn >mkdir .\test\cvs >mkdir .\test\p

[issue45715] round(2500, -3)

2021-11-04 Thread Jacek
New submission from Jacek : round(2500, -3) returns 2000 instead of 3000. I have checked it on 3.7.4 and 3.6.9. -- components: Library (Lib) messages: 405726 nosy: jacekblaz priority: normal severity: normal status: open title: round(2500, -3) type: behavior versions: Python 3.7

[issue12551] Provide data for TLS channel binding

2011-07-13 Thread Jacek Konieczny
New submission from Jacek Konieczny : Recently IETF encourages using of the SCRAM-SHA-1-PLUS SASL authentication mechanism (5802) in new protocols. That is a requirement e.g. of the current XMPP specification (RFC6120). Any compliant implementation needs to support the 'SCRAM-SHA-1

[issue12551] Provide data for TLS channel binding

2011-07-13 Thread Jacek Konieczny
Jacek Konieczny added the comment: > Do you happen to know which API? Not yet. > I see no reference to tls-unique or channel binding, in either the OpenSSL > website or the latest OpenSSL snapshot. Yes, I know it is not directly documented. > It would be nice if there was s

[issue12551] Provide data for TLS channel binding

2011-07-13 Thread Jacek Konieczny
Jacek Konieczny added the comment: I skim-read the TLS specification, looked at the OpenSSL API and it seems it should be easy to implement. I am getting to work right now… -- ___ Python tracker <http://bugs.python.org/issue12

[issue12551] Provide data for TLS channel binding

2011-07-13 Thread Jacek Konieczny
Jacek Konieczny added the comment: Here is a patch, ready for review. Seems to work, though I still need to check it with some other implementation. I have chosen not to expose another three OpenSSL functions (SSL_get_finished, SSL_get_peer_finished, SSL_session_reused), but provide API just

[issue12551] Provide data for TLS channel binding

2011-07-14 Thread Jacek Konieczny
Jacek Konieczny added the comment: Thanks for the quick review. Most of the problems are my oversights. I am not sure about that: > And I think get_channel_binding() should raise NotImplementedError in that > case. As the method is supposed to be extensible and 'tls-unique'

[issue12551] Provide data for TLS channel binding

2011-07-14 Thread Jacek Konieczny
Jacek Konieczny added the comment: This is patch updated according to your suggestions, including raising NotImplementedError when 'tls-unique' is not available and with the ssl.HAS_TLS_UNIQUE constant added. It also includes an important fix to the data retrieval logic (one cond

[issue12551] Provide data for TLS channel binding

2011-07-14 Thread Jacek Konieczny
Jacek Konieczny added the comment: This patch is functionally equivalent, but advertises 'tls-unique' support in a bit different way. HAS_TLS_UNIQUE is not exposed in the python 'ssl' module, instead a list 'CHANNEL_BINDING_TYPES' is provided (empty when

[issue12793] allow filters in os.walk

2011-08-20 Thread Jacek Pliszka
New submission from Jacek Pliszka : I suggest a small change in os.walk module. Instead of: def walk(top, topdown=True, onerror=None, followlinks=False): I would like to have: def walk(top, topdown=True, onerror=None, skipnames=lambda x : False, skipdirs=islink): Implementation might be as

[issue12793] allow filters in os.walk

2011-08-20 Thread Jacek Pliszka
Changes by Jacek Pliszka : -- versions: +Python 2.7 -Python 3.2 ___ Python tracker <http://bugs.python.org/issue12793> ___ ___ Python-bugs-list mailing list Unsub

[issue12793] allow filters in os.walk

2011-08-31 Thread Jacek Pliszka
Jacek Pliszka added the comment: Looks like the proper way to do it is described in the manual: http://docs.python.org/dev/library/os.html#os.walk for root, dirs, files in os.walk('python/Lib/email'): if 'CVS' in dirs: dirs.remove('CVS') # don't

[issue10757] zipfile.write, arcname should be bytestring

2010-12-22 Thread Jacek Jabłoński
New submission from Jacek Jabłoński : file = 'somefile.dat' filename = "ółśąśółąś.dat" zip = zipfile.ZipFile('archive.zip', 'w', zipfile.ZIP_DEFLATED) zip.write(file, filename) above produces very nasty filename in zip archive. **

[issue26794] curframe can be None in pdb.py

2020-08-22 Thread Jacek Pliszka
Jacek Pliszka added the comment: Haven't seen it since then. Stopped using 2.7 - using 3.6 in production and 3.7 in development now. I believe it can be closed. -- ___ Python tracker <https://bugs.python.org/is

[issue15936] Add link from os.urandom to random.SystemRandom

2012-09-12 Thread Jacek Bzdak
New submission from Jacek Bzdak: It would be great if one sentence was added to os.urandom description: "For easy to use interface to system randomness please see random.SystemRandom class". The reason for this change is that many references quote only os.urandom as a cryptog

[issue19217] Calling assertEquals for moderately long list takes too long

2013-10-10 Thread Jacek Bzdak
New submission from Jacek Bzdak: Call to assertEquals(list1, list2) does not finish (takes more than couple of minutes), for lists that containt 1 elements if all list elements are different. The same call in python2.6 finishes instanteneously. This occours even if error message is

[issue19217] Calling assertEquals for moderately long list takes too long

2013-10-10 Thread Jacek Bzdak
Jacek Bzdak added the comment: I have attached a simple test case. -- ___ Python tracker <http://bugs.python.org/issue19217> ___ ___ Python-bugs-list mailin

[issue19217] Calling assertEquals for moderately long list takes too long

2013-10-21 Thread Jacek Bzdak
Jacek Bzdak added the comment: The patch works for me, thanks Ezio! -- ___ Python tracker <http://bugs.python.org/issue19217> ___ ___ Python-bugs-list mailin

[issue20240] Whitespace ignored in relative imports: from.package import something is valid syntax

2014-01-13 Thread Jacek Szpot
New submission from Jacek Szpot: Just wanted to let you know that missing whitespace between "from" and a dot-prefixed name is not considered invalid: from.foo import bar .. does not raise an error. Perhaps it should? -- messages: 208022 nosy: maligree priority: norma

[issue27105] cgi.__all__ is incomplete

2016-06-07 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: Thank you, Martin. :) -- ___ Python tracker <http://bugs.python.org/issue27105> ___ ___ Python-bugs-list mailing list Unsub

[issue23883] __all__ lists are incomplete

2015-06-16 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: Hi! This is my first attempt at contributing so as always, feedback will be well appreciated. :) I meant to start small so I took a shot with csv module. In test, initial expected set contains QUOTE_* because they don't provide __module__ attribute,

[issue23883] __all__ lists are incomplete

2015-06-16 Thread Jacek Kołodziej
Changes by Jacek Kołodziej : Removed file: http://bugs.python.org/file39716/Issue23883_csv_all.patch ___ Python tracker <http://bugs.python.org/issue23883> ___ ___ Pytho

[issue23883] __all__ lists are incomplete

2015-06-16 Thread Jacek Kołodziej
Changes by Jacek Kołodziej : Added file: http://bugs.python.org/file39717/Issue23883_csv_all.patch ___ Python tracker <http://bugs.python.org/issue23883> ___ ___ Pytho

[issue23883] __all__ lists are incomplete

2015-06-17 Thread Jacek Kołodziej
Changes by Jacek Kołodziej : Added file: http://bugs.python.org/file39721/Issue23883_csv_all.v2.patch ___ Python tracker <http://bugs.python.org/issue23883> ___ ___ Pytho

[issue23883] __all__ lists are incomplete

2015-06-18 Thread Jacek Kołodziej
Changes by Jacek Kołodziej : Added file: http://bugs.python.org/file39733/Issue23883_support_check__all__.patch ___ Python tracker <http://bugs.python.org/issue23

[issue23883] __all__ lists are incomplete

2015-06-18 Thread Jacek Kołodziej
Changes by Jacek Kołodziej : Added file: http://bugs.python.org/file39734/Issue23883_test_gettext.patch ___ Python tracker <http://bugs.python.org/issue23883> ___ ___

[issue23883] __all__ lists are incomplete

2015-06-18 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: Thank you for feedback, Martin. I've amended the the patch. Next, I've prepared some initial test.support.check__all__ helper, based on generalization of all previous patches. Its name/params' descriptions may be a bit rough - amendments/sugge

[issue23883] __all__ lists are incomplete

2015-06-18 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: > ftplib and threading have more functions I've meant function and exceptions, of course. Sorry for the noise. -- ___ Python tracker <http://bugs.python.org

[issue23883] __all__ lists are incomplete

2015-06-21 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: I've added previously missing test and docs for test.support.check__all__ in Issue23883_support_check__all__.v2.patch . Awaiting review. :) -- Added file: http://bugs.python.org/file39760/Issue23883_support_check__all__.v2.

[issue23883] __all__ lists are incomplete

2015-06-24 Thread Jacek Kołodziej
Changes by Jacek Kołodziej : Added file: http://bugs.python.org/file39807/Issue23883_support_check__all__.v3.patch ___ Python tracker <http://bugs.python.org/issue23

[issue23883] __all__ lists are incomplete

2015-06-24 Thread Jacek Kołodziej
Changes by Jacek Kołodziej : Added file: http://bugs.python.org/file39808/Issue23883_test_gettext.v2.patch ___ Python tracker <http://bugs.python.org/issue23883> ___ ___

[issue23883] __all__ lists are incomplete

2015-06-24 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: > Nice work with the check__all__() function. Thank you! :) > I left some comments on Reitveld. Also, it currently ignores items satisfying > either of these checks: > > * isinstance(module_object, types.ModuleType) > * getattr(module_o

[issue23883] __all__ lists are incomplete

2015-07-05 Thread Jacek Kołodziej
Changes by Jacek Kołodziej : Added file: http://bugs.python.org/file39867/Issue23883_support_check__all__.v4.patch ___ Python tracker <http://bugs.python.org/issue23

[issue23883] __all__ lists are incomplete

2015-07-05 Thread Jacek Kołodziej
Changes by Jacek Kołodziej : Added file: http://bugs.python.org/file39868/Issue23883_test_gettext.v3.patch ___ Python tracker <http://bugs.python.org/issue23883> ___ ___

[issue23883] __all__ lists are incomplete

2015-07-05 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: > In any case it is too late for 3.5. Ok, next round of patches is based on default branch. > Jacek: If we used the ModuleType check, and somebody adds a module-level > constant (like logging.CRITICAL = 50), the test will automatically detect i

[issue23883] __all__ lists are incomplete

2015-07-21 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: I'm getting patches ready with amendments you've proposed. Two things, though (and two on Rietveld): > That raiseExecptions thing looks like a typo to me. The code should probably > be monkey patching the module variable, and restoring i

[issue24678] raiseExceptions typo fix in logging tests

2015-07-21 Thread Jacek Kołodziej
New submission from Jacek Kołodziej: The typo in test_logging was discovered while working on #23883: in two tests the addCleanup call reverts the raiseEx*ec*ptions value (instead of raiseExceptions) in logging module and apparently that didn't manifest itself in any way. Patch att

[issue24678] raiseExceptions typo fix in logging tests

2015-07-21 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: s/swapattr/swap_attr/g :) Done. -- Added file: http://bugs.python.org/file39968/test_logging_typo.v2.patch ___ Python tracker <http://bugs.python.org/issue24

[issue23883] __all__ lists are incomplete

2015-07-22 Thread Jacek Kołodziej
Changes by Jacek Kołodziej : Added file: http://bugs.python.org/file39976/Issue23883_support_check__all__.v5.patch ___ Python tracker <http://bugs.python.org/issue23

[issue23883] __all__ lists are incomplete

2015-07-22 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: > raiseExecptions typo: Might be best to get the typo fixed first (maybe open a > separate issue, since it should probably be fixed starting from the 3.4 > branch). Done in #24678 and commited in 83b45ea19d00 . > Regarding OpcodeInfo, it is pr

[issue23883] __all__ lists are incomplete

2015-09-19 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: Does anyone have strong preference towards one of the propositions above? TestCase subclass looks reasonable IMHO, but I'd not add that to the scope of this issue (I'd be happy to implement it later, though). Any s

[issue23883] __all__ lists are incomplete

2015-11-11 Thread Jacek Kołodziej
Changes by Jacek Kołodziej : Added file: http://bugs.python.org/file41012/Issue23883_all.v6.patch ___ Python tracker <http://bugs.python.org/issue23883> ___ ___ Python-bug

[issue23883] __all__ lists are incomplete

2015-11-11 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: Serhiy, thank you for the review. I've made proposed changes (along with rebasing Issue23883_all patch; Issue23883_test_gettext.v3.patch still applies cleanly). -- Added file: http://bugs.python.org/file41013/Issue23883_support_check__all__.v6.

[issue23883] __all__ lists are incomplete

2015-11-14 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: Martin, yay! :) And thank you for the documentation correction. Milap, Joel, Mauro, are you still interested in working on patches for calendar/tarfile/fileinput patches? I intend to finish them up if that's not the

[issue23883] __all__ lists are incomplete

2015-11-21 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: Week and no response, I'm posting updated patches for calendar and tarfile. -- Added file: http://bugs.python.org/file41118/Issue23883_tarfile_all.v2.patch ___ Python tracker <http://bugs.python.org/is

[issue23883] __all__ lists are incomplete

2015-11-21 Thread Jacek Kołodziej
Changes by Jacek Kołodziej : Added file: http://bugs.python.org/file41117/Issue23883_calendar_all.v2.patch ___ Python tracker <http://bugs.python.org/issue23883> ___ ___

[issue25975] Weird multiplication

2015-12-29 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: LCK: it's a trait of float point arithmetic in computing: https://docs.python.org/3.5/tutorial/floatingpoint.html . It's not a bug. -- nosy: +Unit03 ___ Python tracker <http://bugs.python.o

[issue26794] curframe can be None in pdb.py

2016-04-18 Thread Jacek Pliszka
New submission from Jacek Pliszka: In /usr/lib64/python2.7/pdb.py in Pdb.default there is line: globals = self.curframe.f_globals curframe can be None so the line should be replaced by: globals = getattr(self.curframe, "f_globals", None) if hasattr(self, 'curframe') els

[issue27105] cgi.__all__ is incomplete

2016-05-24 Thread Jacek Kołodziej
New submission from Jacek Kołodziej: That's a child issue of #23883, created to propose a patch fixing cgi module's __all__ list. -- components: Library (Lib) files: cgi_all.patch keywords: patch messages: 266265 nosy: Unit03 priority: normal severity: normal status: open

[issue27106] configparser.__all__ is incomplete

2016-05-24 Thread Jacek Kołodziej
New submission from Jacek Kołodziej: That's a child issue of #23883, created to propose a patch fixing configparser module's __all__ list. -- components: Library (Lib) files: configparser_all.patch keywords: patch messages: 266266 nosy: Unit03 priority: normal severity: nor

[issue27107] mailbox.__all__ list is incomplete

2016-05-24 Thread Jacek Kołodziej
New submission from Jacek Kołodziej: That's a child issue of #23883, created to propose a patch fixing mailbox module's __all__ list. -- components: Library (Lib) files: mailbox_all.patch keywords: patch messages: 266267 nosy: Unit03 priority: normal severity: normal status:

[issue27108] mimetypes.__all__ list is incomplete

2016-05-24 Thread Jacek Kołodziej
New submission from Jacek Kołodziej: That's a child issue of #23883, created to propose a patch fixing mimetypes module's __all__ list. -- components: Library (Lib) files: mimetypes_all.patch keywords: patch messages: 266268 nosy: Unit03 priority: normal severity: normal st

[issue27109] plistlib.__all__ list is incomplete

2016-05-24 Thread Jacek Kołodziej
New submission from Jacek Kołodziej: That's a child issue of #23883, created to propose a patch fixing plistlib module's __all__ list. -- components: Library (Lib) files: plistlib_all.patch keywords: patch messages: 266269 nosy: Unit03 priority: normal severity: normal st

[issue27110] smtpd.__all__ list is incomplete

2016-05-24 Thread Jacek Kołodziej
New submission from Jacek Kołodziej: That's a child issue of #23883, created to propose a patch fixing smtpd module's __all__ list. -- components: Library (Lib) files: smtpd_all.patch keywords: patch messages: 266270 nosy: Unit03 priority: normal severity: normal status:

[issue27110] smtpd.__all__ list is incomplete

2016-05-24 Thread Jacek Kołodziej
Changes by Jacek Kołodziej : Added file: http://bugs.python.org/file42977/smtpd_all.patch ___ Python tracker <http://bugs.python.org/issue27110> ___ ___ Python-bugs-list m

[issue27112] tokenize.__all__ list is incomplete

2016-05-24 Thread Jacek Kołodziej
New submission from Jacek Kołodziej: That's a child issue of #23883, created to propose a patch fixing tokenize module's __all__ list. Changes in tests go farther: I've changed import from from tokenize import ... to import tokenize and adjusted all its usages ac

[issue27110] smtpd.__all__ list is incomplete

2016-05-24 Thread Jacek Kołodziej
Changes by Jacek Kołodziej : Removed file: http://bugs.python.org/file42972/smtpd_all.patch ___ Python tracker <http://bugs.python.org/issue27110> ___ ___ Python-bug

[issue23883] __all__ lists are incomplete

2016-05-24 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: Per Martin's request, I've created a few new issues for next batch of module's __all__ list updates: * cgi: #27105 * configparser: #27106 * mailbox: #27107 * mimetypes: #27108 * plistlib: #27109 * smtpd: #27110 * tokenize: #27112 I've

[issue27107] mailbox.__all__ list is incomplete

2016-05-24 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: David, what do you mean by "new format"? Can you point me to some existing code? -- ___ Python tracker <http://bugs.python.o

[issue27105] cgi.__all__ is incomplete

2016-05-24 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: Well, but it is documented in public docs: cgi.test() Robust test CGI script, usable as main program. Writes minimal HTTP headers and formats all information provided to the script in HTML form. Should I remove it from __all__ and probably from the

[issue27112] tokenize.__all__ list is incomplete

2016-05-24 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: I disagree: * blacklist has 48 entries now, whitelist would have 72 ones * whitelisting requires adding new public names to two places instead of one * test.support.check__all__ currently don't support whitelisting, it would need to be

[issue27108] mimetypes.__all__ list is incomplete

2016-05-25 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: Thank you, Martin. I'm uploading amended patch. -- Added file: http://bugs.python.org/file42988/mimetypes_all.v2.patch ___ Python tracker <http://bugs.python.org/is

[issue27105] cgi.__all__ is incomplete

2016-05-25 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: Martin: > Is there any advantage to having the test case in a separate MiscTestCase > class, as opposed to the existing CgiTests class? Other than "the first test [well, that I know of] for __all__ list was in separate class called MiscTestCase s

[issue23883] __all__ lists are incomplete

2016-05-25 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: In this case I'm proposing a small patch just for testing pydoc module's __all__ list and left the decision to you, whether to apply it or not. :) Test doesn't use test.support.check__all__ (see msg266312) - blacklist would be huge and expect

[issue27112] tokenize.__all__ list is incomplete

2016-05-25 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: > * All names in black list are implementation details. Names in white list are > stable and already repeated in docs. Assumption here is that implementation details shouldn't "look" public - they should have names starting with &quo

[issue27106] configparser.__all__ is incomplete

2016-09-05 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: Łukasz, Martin - I'm not sure how to proceed here, of course both ways out are reasonable. I'd be happy to provide (however small) patch for either one (adding Error to __all__ or just adding test for __all__). :) My inner librarian would of cou

[issue27112] tokenize.__all__ list is incomplete

2016-09-05 Thread Jacek Kołodziej
Changes by Jacek Kołodziej : Added file: http://bugs.python.org/file44373/tokenize_all.v2.patch ___ Python tracker <http://bugs.python.org/issue27112> ___ ___ Python-bug

[issue27112] tokenize.__all__ list is incomplete

2016-09-05 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: > I would lean toward ensuring the test fails if someone adds a new > implementation detail without an underscore prefix. It is also good to be > explicit that the ISTERMINAL() etc functions are special cases. Original patch meets these requireme

[issue27106] configparser.__all__ is incomplete

2016-09-06 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: That's completely fine for me. I'm attaching the patch that just adds test for __all__, then. :) -- Added file: http://bugs.python.org/file44393/configparser_all.v2.patch ___ Python tracker <http://bu