Jason R. Coombs added the comment:
I'm hoping those documentation edits address the deficiencies, but if not, we
can take another stab at it. Feel free to re-open as needed.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Jason R. Coombs added the comment:
New changeset b738237d6792acba85b1f6e6c8993a812c7fd815 by Jason R. Coombs (Miss
Islington (bot)) in branch '3.8':
bpo-39022, bpo-38594: Sync with importlib_metadata 1.3 (GH-17568) (GH-17569)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
New changeset b738237d6792acba85b1f6e6c8993a812c7fd815 by Jason R. Coombs (Miss
Islington (bot)) in branch '3.8':
bpo-39022, bpo-38594: Sync with importlib_metadata 1.3 (GH-17568) (GH-17569)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
New changeset b7a0109cd2bafaa21a4d50aad307e901c68f9156 by Jason R. Coombs in
branch 'master':
bpo-39022, bpo-38594: Sync with importlib_metadata 1.3 (GH-17568)
https://github.com/python/cpython/commit/b7a0109cd2bafaa21a4d50aad307e901c68f9156
Jason R. Coombs added the comment:
New changeset b7a0109cd2bafaa21a4d50aad307e901c68f9156 by Jason R. Coombs in
branch 'master':
bpo-39022, bpo-38594: Sync with importlib_metadata 1.3 (GH-17568)
https://github.com/python/cpython/commit/b7a0109cd2bafaa21a4d50aad307e901c68f9156
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +17041
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/17568
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +17040
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/17568
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
title: Synchronize importlib.metadata with importlib_metadata 1.2 ->
Synchronize importlib.metadata with importlib_metadata 1.3
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
I've merged the recommended changes into importlib_metadata 1.3 and I'm
including those changes in issue39022.
--
___
Python tracker
<https://bugs.python.org/issue38
New submission from Jason R. Coombs :
Calling for another refresh of importlib.metadata from the third-party package.
History at
https://importlib-metadata.readthedocs.io/en/latest/changelog%20(links).html.
--
messages: 358233
nosy: jaraco
priority: normal
severity: normal
status
Jason R. Coombs added the comment:
This issue was also [reported in prometheus
client](https://salsa.debian.org/debian/python-prometheus-client/commit/5aa256d8aab3b81604b855dc03f260342fc391fb)
where the workaround was to use daemon threads
Change by Jason R. Coombs :
--
nosy: +jaraco
___
Python tracker
<https://bugs.python.org/issue37193>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
Please have a look at
https://gitlab.com/python-devs/importlib_metadata/merge_requests/104/diffs,
which attempts to clarify the documentation to indicate how one would implement
a custom finder. If you have a prototype implementation, I'd be happy to have
Jason R. Coombs added the comment:
Good suggestions. Thanks for taking the time to articulate in such a friendly
way the shortcomings you encountered. I'm happy to help.
In [this ticket](https://gitlab.com/python-devs/importlib_metadata/issues/105),
I've mirrored this ticket in the backport
Change by Jason R. Coombs :
--
assignee: docs@python -> jaraco
___
Python tracker
<https://bugs.python.org/issue38594>
___
___
Python-bugs-list mailing list
Un
Jason R. Coombs added the comment:
New changeset 65444cf7fe84d8ca1f9b51c7f5992210751e08bb by Jason R. Coombs
(Claudiu Popa) in branch 'master':
bpo-38526: Fix zipfile.Path method name to be the correct one (#17317)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
I could imagine extending the shutdown code to catch the reported error
(https://github.com/python/cpython/blob/138ccbb02216ca086047c3139857fb44f3dab1f9/Lib/logging/__init__.py#L2130-L2135),
but that wouldn't address the error in emit.
Similarly
Jason R. Coombs added the comment:
In the downstream issue, it's also reported that crashes occur in emit as well,
suggesting that the comment is additionally wrong on that front.
--
___
Python tracker
<https://bugs.python.org/issue38
Jason R. Coombs added the comment:
The issue probably stems from
https://github.com/python/cpython/blob/138ccbb02216ca086047c3139857fb44f3dab1f9/Lib/logging/handlers.py#L828-L835.
I doubt the logic of that comment, as in the non-unix-socket case, the error
is raised if a connection cannot
Jason R. Coombs added the comment:
For background, this issue originated from
https://github.com/pytest-dev/pytest-services/issues/20.
--
___
Python tracker
<https://bugs.python.org/issue38
Jason R. Coombs added the comment:
I guess that makes sense, as `/dev/log` doesn't exist on macOS. So maybe this
usage is invalid. But still I'd expect the handler to error early or at least
not error on shutdown.
--
___
Python tracker
<ht
Change by Jason R. Coombs :
--
components: +Library (Lib), macOS
nosy: +ned.deily, ronaldoussoren
___
Python tracker
<https://bugs.python.org/issue38780>
___
___
Jason R. Coombs added the comment:
I only observe this issue on macOS. On Linux, the error doesn't occur.
--
___
Python tracker
<https://bugs.python.org/issue38
New submission from Jason R. Coombs :
On Python 3.8.0:
$ python -c "import logging.handlers, socket; handler =
logging.handlers.SysLogHandler(facility=logging.handlers.SysLogHandler.LOG_LOCAL7,
address='/dev/log', socktype=socket.SOC
Jason R. Coombs added the comment:
Same error on Python 2.7 and 3.7
--
versions: +Python 2.7, Python 3.7, Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue38
Jason R. Coombs added the comment:
This issue broke a date subclass in the calendra project
(https://github.com/jaraco/calendra/issues/11). I acknowledge this change was a
known breakage, but I mention it here and link the downstream issue for your
information.
--
nosy: +jaraco
Jason R. Coombs added the comment:
I've confirmed that the `metadata` directory doesn't exist in the repo. It also
doesn't appear on my Python 3.8.0b4 installation on macOS:
```
cpython master $ ls
/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/importlib
Jason R. Coombs added the comment:
I believe importlib/metadata/__init__ was moved to importlib.metadata. I’ll
inspect the repo for correctness, but there may be another issue with the old
files lingering.
--
___
Python tracker
<ht
Change by Jason R. Coombs :
--
pull_requests: +16062
pull_request: https://github.com/python/cpython/pull/16476
___
Python tracker
<https://bugs.python.org/issue36
Change by Jason R. Coombs :
--
pull_requests: +16061
pull_request: https://github.com/python/cpython/pull/16476
___
Python tracker
<https://bugs.python.org/issue38
Change by Jason R. Coombs :
--
pull_requests: +16059
pull_request: https://github.com/python/cpython/pull/16475
___
Python tracker
<https://bugs.python.org/issue38
Change by Jason R. Coombs :
--
pull_requests: +16060
pull_request: https://github.com/python/cpython/pull/16475
___
Python tracker
<https://bugs.python.org/issue36
Jason R. Coombs added the comment:
> Someone should look at how to do similar in 2.7 _if_ the project(s) that
> complained about the problem rely on such behavior in their last 2.7
> compatible releases.
Looking at the history, it seems that only two projects were mentioned,
Jason R. Coombs added the comment:
New changeset 80dd66ac278ecbabbf843526e3a56f5031da9562 by Jason R. Coombs in
branch '3.7':
[3.7] bpo-38216, bpo-36274: Allow subclasses to separately override validation
and encoding behavior (GH-16448) (GH-16461)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
New changeset 80dd66ac278ecbabbf843526e3a56f5031da9562 by Jason R. Coombs in
branch '3.7':
[3.7] bpo-38216, bpo-36274: Allow subclasses to separately override validation
and encoding behavior (GH-16448) (GH-16461)
https://github.com/python/cpython/commit
Change by Jason R. Coombs :
--
pull_requests: +16047
pull_request: https://github.com/python/cpython/pull/16462
___
Python tracker
<https://bugs.python.org/issue36
Change by Jason R. Coombs :
--
pull_requests: +16046
pull_request: https://github.com/python/cpython/pull/16462
___
Python tracker
<https://bugs.python.org/issue38
Change by Jason R. Coombs :
--
pull_requests: +16045
pull_request: https://github.com/python/cpython/pull/16461
___
Python tracker
<https://bugs.python.org/issue36
Change by Jason R. Coombs :
--
pull_requests: +16044
pull_request: https://github.com/python/cpython/pull/16461
___
Python tracker
<https://bugs.python.org/issue38
Jason R. Coombs added the comment:
New changeset 7774d7831e8809795c64ce27f7df52674581d298 by Jason R. Coombs in
branch 'master':
bpo-38216, bpo-36274: Allow subclasses to separately override validation and
encoding behavior (GH-16448)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
New changeset 7774d7831e8809795c64ce27f7df52674581d298 by Jason R. Coombs in
branch 'master':
bpo-38216, bpo-36274: Allow subclasses to separately override validation and
encoding behavior (GH-16448)
https://github.com/python/cpython/commit
Change by Jason R. Coombs :
--
pull_requests: +16027
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16448
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
pull_requests: +16028
pull_request: https://github.com/python/cpython/pull/16448
___
Python tracker
<https://bugs.python.org/issue36
Jason R. Coombs added the comment:
Also, with the CherryPy approach, the Python 2.7 story is more complicated. I
haven't yet addressed that in the CherryPy 17 maintenance branch (which
supports Python 2.7).
--
___
Python tracker
<ht
Jason R. Coombs added the comment:
In https://github.com/cherrypy/cherrypy/pull/1807, I discovered that there is
already a fairly straightforward means for a third-party package to override
the putrequest character validation (just monkeypatch
http.client._contains_disallowed_url_pchar_re
Jason R. Coombs added the comment:
I should say, though, this issue is a long-standing regression from Python 3.0.
Although intentional, the inability for a client to override the encoding of
the request line does make it impossible without replacing all of .putrequest
to override
Jason R. Coombs added the comment:
I've added PR 16321 illustrating my proposed solution. This solution, while
more invasive than Tim's more surgical solution, addresses the concerns brought
about by this issue as well as those articulated originally in issue36274.
I'm slightly inclined
Change by Jason R. Coombs :
--
pull_requests: +15900
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/16321
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
pull_requests: +15898
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16321
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
pull_requests: +15899
pull_request: https://github.com/python/cpython/pull/16321
___
Python tracker
<https://bugs.python.org/issue36
Jason R. Coombs added the comment:
> I'm not against that concept, but it is only appropriate for >= 3.9 as that'd
> be adding a feature. This issue is marked a release blocker to decide what
> to do for 3.5-3.7 (and maybe 3.8 if deemed a serious breaking change).
Jason R. Coombs added the comment:
Thanks for all the comments. I agree the current (secure by default)
implementation is desirable. I also agree that such usage was never explicitly
supported, so the "regression" here is perhaps over-stated. What I seek is to
avoid the Go reco
Jason R. Coombs added the comment:
I've created issue38216 to address the (perceived) regression.
--
___
Python tracker
<https://bugs.python.org/issue30
Change by Jason R. Coombs :
--
keywords: +3.6regression, 3.7regression
___
Python tracker
<https://bugs.python.org/issue38216>
___
___
Python-bugs-list mailin
Jason R. Coombs added the comment:
That's right - no longer a 3.7 regression here.
--
keywords: -3.7regression
___
Python tracker
<https://bugs.python.org/issue36
Jason R. Coombs added the comment:
I've created issue38216 to address the issue of sending invalid bytes in the
request line, separate from the original intention and title issue about
sending non-ASCII.
--
___
Python tracker
<ht
New submission from Jason R. Coombs :
The fix for issue30458 prevents any request line from transmitting non-ascii
characters. In some cases, it's useful to transmit these illegal bytes in order
to simulate a maliciously-crafted request (such as to ensure a web server
responds correctly
Jason R. Coombs added the comment:
> Should we open a separate issue to track (fixing) the regression?
Yes, I think so. The ticket I referenced mainly addresses an incompatibility
that was introduced with Python 3.0, so is much less urgent than the one
introduced more recently, so I beli
Jason R. Coombs added the comment:
As I considered a patch for this, I realized there are actually two issues, the
one in the title "http.client cannot send non-ASCII request lines" but also
"the protection for invalid requests prevents usage to generate invalid
requests&quo
Jason R. Coombs added the comment:
This change caused a regression or two captured in issue36274. Essentially, by
blocking invalid requests, it's now not possible for a system intentionally to
generate invalid requests for testing purposes. As these point releases of
Python start making
Jason R. Coombs added the comment:
I've started drafting a patch at
https://github.com/python/cpython/tree/feature/putrequest-hooks
--
___
Python tracker
<https://bugs.python.org/issue36
Jason R. Coombs added the comment:
I believe this issue is more recent and widespread than I originally thought. I
realized today that CherryPy is affected by this issue and [disabled nightly
tests](https://github.com/cherrypy/cherrypy/issues/1781#issuecomment-507836873)
as a result
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
New changeset a0d4aac50b362f4c33594a86e0e299d3f812e7b1 by Jason R. Coombs in
branch '3.8':
[3.8] bpo-38121: Sync importlib.metadata with 0.22 backport (GH-15993)
(GH-16064)
https://github.com/python/cpython/commit/a0d4aac50b362f4c33594a86e0e299d3f812e7b1
Change by Jason R. Coombs :
--
pull_requests: +15687
pull_request: https://github.com/python/cpython/pull/16064
___
Python tracker
<https://bugs.python.org/issue38
Jason R. Coombs added the comment:
I've addressed the requests made by rhettinger in issue38086 and issue38121.
--
status: open -> closed
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +15622
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15993
___
Python tracker
<https://bugs.python.org/issu
New submission from Jason R. Coombs :
Incorporate the changes from the 0.22 release
(https://gitlab.com/python-devs/importlib_metadata/blob/0.22/importlib_metadata/docs/changelog.rst)
including the new lightweight shim from PathFinder into
importlib.metadata.MetadataPathFinder
Jason R. Coombs added the comment:
New changeset c5a672315dffbc95acc1ca28584ec84ddb56626f by Jason R. Coombs (Miss
Islington (bot)) in branch '3.8':
bpo-36260: Add pitfalls to zipfile module documentation (GH-13378) (GH-15976)
https://github.com/python/cpython/commit
Change by Jason R. Coombs :
--
nosy: -jaraco
resolution: remind -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
New changeset 3ba51d587f6897a45301ce9126300c14fcd4eba2 by Jason R. Coombs
(JunWei Song) in branch 'master':
bpo-36260: Add pitfalls to zipfile module documentation (#13378)
https://github.com/python/cpython/commit/3ba51d587f6897a45301ce9126300c14fcd4eba2
Jason R. Coombs added the comment:
Thanks all for investigating and discussing this issue. I'm reviewing the PR,
and I can't help but wonder, does this same issue exist when building with
setuptools? Do you care about older Python versions? Would addressing these
issues in setuptools
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
New changeset 42edfcfd129c7ac4842b9e0cd453bbe3ff006669 by Jason R. Coombs (Miss
Islington (bot)) in branch '3.8':
bpo-36919: make test_source_encoding.test_issue2301 implementation-independent
(GH-13639) (GH-15952)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
New changeset c2119399488a297275db7f0590cff957b6ce8a2e by Jason R. Coombs (Miss
Islington (bot)) in branch '3.7':
bpo-36919: make test_source_encoding.test_issue2301 implementation-independent
(GH-13639) (GH-15953)
https://github.com/python/cpython/commit
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
Thanks for the contrib.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
New changeset fef5bdc645bc5d037505e3da2965dfabb73f58eb by Jason R. Coombs (Miss
Islington (bot)) in branch '3.8':
bpo-34519: Add additional aliases for HP Roman 8 (GH-8956) (GH-15945)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
New changeset 35d0934040223f1360b2b343005fcc8ebbc65c1a by Jason R. Coombs (Miss
Islington (bot)) in branch '3.8':
bpo-37305: add MIME type for Web App Manifest (GH-14199) (#15946)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
New changeset cbd7b2a399a8ff2ed9994c380b07ef598892b6b1 by Jason R. Coombs (Miss
Islington (bot)) in branch '3.8':
bpo-31163: Added return values to pathlib.Path instance's rename and replace
methods. (GH-13582) (GH-15944)
https://github.com/python/cpython
Jason R. Coombs added the comment:
New changeset b6643dcfc26859f935e4b3a6a2a203e8ef5320e2 by Jason R. Coombs
(Pavel Koneski) in branch 'master':
bpo-36919: make test_source_encoding.test_issue2301 implementation-independent
(#13639)
https://github.com/python/cpython/commit
Change by Jason R. Coombs :
--
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue36919>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
New changeset 4b41745b3c65ef4807cd1108dce12d3e0c173f20 by Jason R. Coombs
(Filip Š) in branch 'master':
bpo-37305: add MIME type for Web App Manifest (#14199)
https://github.com/python/cpython/commit/4b41745b3c65ef4807cd1108dce12d3e0c173f20
--
nosy
Jason R. Coombs added the comment:
New changeset 088a09af4bdeff52b9dedeb7acd1e82069f37d98 by Jason R. Coombs (hui
shang) in branch 'master':
bpo-31163: Added return values to pathlib.Path instance's rename and replace
methods. (GH-13582)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
New changeset a828514cc3715ebbc700fefa41c0ef044cbd6741 by Jason R. Coombs
(Michael Osipov) in branch 'master':
bpo-34519: Add additional aliases for HP Roman 8 (GH-8956)
https://github.com/python/cpython/commit/a828514cc3715ebbc700fefa41c0ef044cbd6741
Change by Jason R. Coombs :
--
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue37305>
___
___
Python-bugs-list mailin
Jason R. Coombs added the comment:
As an enhancement, this change should not be backported.
--
nosy: +jaraco
versions: +Python 3.9 -Python 3.6, Python 3.7
___
Python tracker
<https://bugs.python.org/issue34
Jason R. Coombs added the comment:
Thank you Tim for the reasoned issue and proposed solutions.
After reviewing these proposals with @eric.snow, we've decided that this
approach is dangerous in that the proposed approaches has the potential to
expose users unexpectedly to non-compliant
Jason R. Coombs added the comment:
Or even more concise:
trigger and breakpoint()
--
___
Python tracker
<https://bugs.python.org/issue38054>
___
___
Python-bug
Jason R. Coombs added the comment:
You could just do
breakpoint() if trigger else None
Concise, easy, and avoids complicating set_trace().
--
nosy: +jaraco
___
Python tracker
<https://bugs.python.org/issue38
Jason R. Coombs added the comment:
New changeset 97c2f68a4c0bf4e69a1e769928d7928fab73a666 by Jason R. Coombs in
branch '3.8':
[3.8] bpo-38086: Sync importlib.metadata with importlib_metadata 0.21.
(GH-15840) (#15861)
https://github.com/python/cpython/commit
Change by Jason R. Coombs :
--
pull_requests: +15508
pull_request: https://github.com/python/cpython/pull/15861
___
Python tracker
<https://bugs.python.org/issue38
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +15487
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15840
___
Python tracker
<https://bugs.python.org/issu
New submission from Jason R. Coombs :
Importlib_metadata 0.21 has been released (technically releasing at this
moment). This issue serves as an anchor to incorporate those changes
(https://gitlab.com/python-devs/importlib_metadata/blob/4b86813ecf7e40e6d553976e3f5604f90d475fb4
Jason R. Coombs added the comment:
New changeset ef66f31ce21cd759cc0c618c5c42ba6da0a06834 by Jason R. Coombs
(Steve Dower) in branch 'master':
bpo-32587: Fixes unsafe downcast in PC/winreg.c (GH-15766)
https://github.com/python/cpython/commit/ef66f31ce21cd759cc0c618c5c42ba6da0a06834
Jason R. Coombs added the comment:
New changeset ebe709dc1d7c1f9f07dc7d77e53674d2500b223e by Jason R. Coombs
(Anthony Sottile) in branch '3.7':
bpo-36853: Fix suspicious.py to actually print the unused rules (#13579)
(#15653)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
New changeset b365cfae4675ae90df329cb1179a5664e8283c13 by Jason R. Coombs (Miss
Islington (bot)) in branch '3.8':
bpo-36853: Fix suspicious.py to actually print the unused rules (GH-13579)
(GH-15649)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
New changeset bf69e160c431dc40d6530d427cec71c6a97522f5 by Jason R. Coombs (Miss
Islington (bot)) in branch '3.8':
bpo-38010 Sync importlib.metadata with importlib_metadata 0.20. (GH-15646)
(GH-15648)
https://github.com/python/cpython/commit
601 - 700 of 1483 matches
Mail list logo
