Jason R. Coombs added the comment:
What do you think about readlink returning something like:
class Link(str):
print_name = None # type: str | None
@property
def friendly_name(self) -> str:
return self.print_name or self
os.readlink would always return one of these Link obje
Jason R. Coombs added the comment:
> Changing readlink to always return the correct path was deliberate.
Understood. However, this statement assumes the "correct path" is the most
precise path to resolve the target. If you instead define "correct path" as the
one that
Jason R. Coombs added the comment:
> Unless you're specifically testing single steps through symlink chains, you
> probably want to just use realpath anyway.
I do see now the references to `realpath` in the docs... and I think that
satisfies the need I described above. It doesn't
Jason R. Coombs added the comment:
Perhaps related, I've encountered another apparent regression on Python 3.8 on
Windows when the current working directory is in a symlink to another volume
and one runs `setup.py develop` on a project using setuptools_scm
(https://github.com/pypa
New submission from Jason R. Coombs :
I've encountered an apparent regression on Python 3.8 on Windows when the
current working directory is in a symlink to another volume and one runs
`setup.py develop` on a project using setuptools_scm
(https://github.com/pypa/setuptools_scm/issues/436
Jason R. Coombs added the comment:
> Perhaps related...
Now I'm thinking the issue is different, so I've created issue40732 to track
the realpath issue.
--
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
nosy: +eryksun
___
Python tracker
<https://bugs.python.org/issue40732>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
It seems the underlying reason the behavior fails is the (intended) difference
resolving the empty path to a realpath when a symlink points to another volume.
The failing routine invokes realpath early
(https://github.com/pypa/setuptools_scm/blob
Jason R. Coombs added the comment:
To make matters more complicated, `git rev-parse --show-toplevel` also returns
the realpath:
```
# git rev-parse --show-toplevel
//vmware-host/Shared Folders/home/code/main/path
```
--
___
Python tracker
<ht
Jason R. Coombs added the comment:
Good news is it looks like the issue with setuptools_scm can be address in a
relatively straightforward manner
(https://github.com/pypa/setuptools_scm/issues/436#issuecomment-632899446).
I think that means the answers to the above questions
Jason R. Coombs added the comment:
> I'll see if `realpath` satisfies the test suite needs for path pie.
I've tried replacing `readlink` with `realpath` and the tests still pass on
Unix-like OSs, and also passes on Python 3.8 on Windows, but now fails on older
Pythons on Wind
Jason R. Coombs added the comment:
It's because on Unix:
```
>>> os.path.relpath('/Users/jaraco/code/main/path/.flake8', '')
'.flake8'
```
But on Windows, relpath raises an error for the comparable call:
```
>>> os.path.relpath('vmware-host\\shared
>>> fold
Change by Jason R. Coombs :
--
pull_requests: +21845
pull_request: https://github.com/python/cpython/pull/22915
___
Python tracker
<https://bugs.python.org/issue41
New submission from Jason R. Coombs :
In
[importlib_resources#68](https://github.com/python/importlib_resources/issues/68),
the project identified a deficiency with respect to pkg_resources for
resources in namespace packages.
The project has since merged support for these packages, slated
Jason R. Coombs added the comment:
This issue is fixed in zipp 3.4.0.
--
assignee: -> jaraco
stage: -> backport needed
___
Python tracker
<https://bugs.python.org/i
Jason R. Coombs added the comment:
New changeset df8d4c83a6e1727e766191896aeabde886979587 by Jason R. Coombs in
branch 'master':
bpo-41490: ``path`` and ``contents`` to aggressively close handles (#22915)
https://github.com/python/cpython/commit/df8d4c83a6e1727e766191896aeabde886979587
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +21926
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23010
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
New changeset d1a0a960ee493262fb95a0f5b795b5b6d75cecb8 by Jason R. Coombs in
branch 'master':
bpo-42043: Add support for zipfile.Path subclasses (#22716)
https://github.com/python/cpython/commit/d1a0a960ee493262fb95a0f5b795b5b6d75cecb8
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +21893
stage: backport needed -> patch review
pull_request: https://github.com/python/cpython/pull/22976
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
stage: patch review -> commit review
___
Python tracker
<https://bugs.python.org/issue42090>
___
___
Python-bugs-list mai
Jason R. Coombs added the comment:
Indeed, it was unexpected that consumers of the `uname_result` were using
`_replace`. In fact, the focus of the tests is on ensuring that users are able
to access the items by index, e.g. `uname()[0]`.
It should be possible to support `_replace
Change by Jason R. Coombs :
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issue42163>
___
___
Python-bugs-list mailing list
Unsubscrib
New submission from Jason R. Coombs :
On Windows:
Python 3.8.3 (tags/v3.8.3:6f8c832, May 13 2020, 22:37:02) [MSC v.1924 64 bit
(AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import ntpath
>>
Change by Jason R. Coombs :
--
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 2.7, Python 3.3, Python
3.4
___
Python tracker
<https://bugs.python.org/issue16
Jason R. Coombs added the comment:
CPython should also consider [this
change](https://github.com/pypa/distutils/commit/d9ba43436d), which unifies the
`DEBUG` handling, consolidates the exception trapping, and uses
`subprocess.check_call` to re-use exit code checking
Change by Jason R. Coombs :
--
pull_requests: +20542
pull_request: https://github.com/python/cpython/pull/21394
___
Python tracker
<https://bugs.python.org/issue16
New submission from Jason R. Coombs :
In [pypa/setuptools#2228](https://github.com/pypa/setuptools/issues/2228), by
adopting the distutils codebase from a late release of CPython, Setuptools
stumbled onto an API-breaking change in distutils rooted at issue39763.
Details are in the Setuptools
Jason R. Coombs added the comment:
I've flagged issue41207 as a regression stemming from this effort.
--
nosy: +jaraco
___
Python tracker
<https://bugs.python.org/issue39
Change by Jason R. Coombs :
--
versions: +Python 3.10
___
Python tracker
<https://bugs.python.org/issue41207>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
Well, the issue is potentially ignorable, especially if distutils is deprecated
and removed from CPython. Alternately, CPython could adopt the [patch from
distutils](https://github.com/pypa/distutils/pull/1/commits/c3a052aefbba0d5fda10790e676223c0dc12f0ed
Change by Jason R. Coombs :
--
nosy: +ncoghlan, paul.moore
___
Python tracker
<https://bugs.python.org/issue41282>
___
___
Python-bugs-list mailing list
Unsub
New submission from Jason R. Coombs :
Setuptools has adopted distutils as outlined in
[pypa/packaging-problems#127](https://github.com/pypa/packaging-problems/issues/127).
Although there are some straggling issues, the current release of Setuptools
fully obviates distutils if a certain
Change by Jason R. Coombs :
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue41282>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
Łukasz, would it be possible to add the deprecation warning and documented
deprecation to Python 3.9?
--
nosy: +lukasz.langa
___
Python tracker
<https://bugs.python.org/issue41
Jason R. Coombs added the comment:
In [pypa/distutils#1](https://github.com/pypa/distutils/pull/1), I learned that
the test doesn't have the intended effect. Patching `get_config_var()` has no
effect because the function under test calls `get_config_vars()`. In some
environments
Jason R. Coombs added the comment:
For easy reference, the relevant commit is
https://github.com/python/cpython/commit/97345680dc.
--
___
Python tracker
<https://bugs.python.org/issue18
Jason R. Coombs added the comment:
In
[pypa/distutils@7aa5abeafc](https://github.com/pypa/distutils/commit/7aa5abeafc1e0b1b351c4c8ac7eb14c310366a46),
I've pushed a fix (with a repro test in the parent commit). I recommend this
fix be applied to CPython 3.9
Jason R. Coombs added the comment:
Sure. I'll submit patches.
--
___
Python tracker
<https://bugs.python.org/issue41207>
___
___
Python-bugs-list mailin
Jason R. Coombs added the comment:
I learned the magical incantation to port commits from pypa/distutils to
CPython:
```
cpython bugfix/41207-rewrite-filenotfound $ git -C ~/p/pypa/distutils
format-patch HEAD~2 --stdout | git am --directory Lib
Applying: Add
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +20504
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21359
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
I created [jaraco/zipp#56](https://github.com/jaraco/zipp/issues/56) to track
the issue in the backport.
--
___
Python tracker
<https://bugs.python.org/issue41
Change by Jason R. Coombs :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
Yes, I generally agree with your assessment. Let me know if you have any
questions about the implementation as you're exploring a solution.
--
___
Python tracker
<https://bugs.python.org/issue41
Jason R. Coombs added the comment:
>>It seems you may have discovered a use-case that violates that expectation, a
>>case where `/a.txt` is identical to `a.txt`.
> The thing is: it's not.
I think maybe you misunderstood. I mean that the zipfile you have seems to be
t
Jason R. Coombs added the comment:
Thanks sorrow for filing a report.
I primarily developed this functionality. As I did, I found the 'zip' format to
be under-specified, so I used real-world examples as models to infer a spec.
It seems you may have discovered a use-case that violates
Jason R. Coombs added the comment:
I feel terrible and really regret that this was able to break things so badly.
What options are available at this point? I'd at the very least like to remove
the `loader.files()` behavior to avoid encouraging other loaders to implement
it. Should we also
Jason R. Coombs added the comment:
This issue stems from improper reliance on implementation details of
`importlib.resources.path`, which returns a context manager that is designed to
clean up the file after the context closes. certifi would have encountered the
same problem on older
Change by Jason R. Coombs :
--
pull_requests: +19878
pull_request: https://github.com/python/cpython/pull/20659
___
Python tracker
<https://bugs.python.org/issue39
Change by Jason R. Coombs :
--
pull_requests: +19875
pull_request: https://github.com/python/cpython/pull/20656
___
Python tracker
<https://bugs.python.org/issue39
Jason R. Coombs added the comment:
New changeset 161541ab45278df6603dd870113b10f13e4d9e16 by Jason R. Coombs in
branch 'master':
bpo-39791: Refresh importlib.metadata from importlib_metadata 1.6.1. (GH-20659)
https://github.com/python/cpython/commit/161541ab45278df6603dd870113b10f13e4d9e16
Jason R. Coombs added the comment:
New changeset a4fa9a95153a3800dea60b3029b2dcaf8a4f6acb by Miss Islington (bot)
in branch '3.9':
bpo-39791: Refresh importlib.metadata from importlib_metadata 1.6.1. (GH-20659)
(GH-20661)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
Thanks for the report Michael. I'm trying to figure out the best way to address
the issue. That test is shared with importlib_metadata, so needs to run without
CPython's test suite fixtures, such as the ones that generate non-ascii
filenames. I'm tempted
Change by Jason R. Coombs :
--
pull_requests: +19894
pull_request: https://github.com/python/cpython/pull/20681
___
Python tracker
<https://bugs.python.org/issue39
Jason R. Coombs added the comment:
See GH-20681 for a proposed fix. I've scheduled the build bots to run the
patch. Will build bots prove the fix? If not, can you test the patch in the
same environment where it was discovered?
--
___
Python
Jason R. Coombs added the comment:
New changeset 843c27765652e2322011fb3e5d88f4837de38c06 by Jason R. Coombs in
branch 'master':
bpo-39791 native hooks for importlib.resources.files (GH-20576)
https://github.com/python/cpython/commit/843c27765652e2322011fb3e5d88f4837de38c06
Jason R. Coombs added the comment:
I understand the issue here and can supply more details soon (no later than
this weekend).
--
___
Python tracker
<https://bugs.python.org/issue40
Jason R. Coombs added the comment:
Thanks for the thorough and considerate response.
I do think your original recommendation of reverting the broken feature is the
best approach at this point. That is, keep resources.files with the fallback
shim and eliminate support for loaders supplying
Change by Jason R. Coombs :
--
pull_requests: +20017
pull_request: https://github.com/python/cpython/pull/20820
___
Python tracker
<https://bugs.python.org/issue40
Jason R. Coombs added the comment:
Thanks for the notice Ned. I've revived the PR and addressed all the comments
from Victor. Any chance this can get into Python 3.7?
--
___
Python tracker
<https://bugs.python.org/issue37
Change by Jason R. Coombs :
--
pull_requests: +20049
pull_request: https://github.com/python/cpython/pull/20857
___
Python tracker
<https://bugs.python.org/issue40
Jason R. Coombs added the comment:
In [this latest
routine](https://github.com/jaraco/jaraco.develop/blob/6469c7a61e7349b93f191df38eed6cd020dd79be/jaraco/develop/macos-build-python.py),
on my macOS workstation with Homebrew installed locally, Python builds
successfully with just a few
Jason R. Coombs added the comment:
New changeset 2efe18bf277dd0f38a1d248ae6bdd30947c26880 by Jason R. Coombs in
branch 'master':
bpo-39791: Support file systems that cannot support non-ascii filenames
(skipping tests in that case). (#20681)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
I'm a little surprised from Nick's original post that the behavior is
triggered. After all, the code [already has a protection for a
previously-closed
zipfile](https://github.com/python/cpython/blob/0dd98c2d00a75efbec19c2ed942923981bc06683/Lib/zipfile.py
Jason R. Coombs added the comment:
This routine will repro the issue without relying on garbage collection to
trigger the error:
```
import io
import zipfile
buf = io.BytesIO()
zf = zipfile.ZipFile(buf, mode='w')
zp = zipfile.Path(zf)
with zp.joinpath('zile-a').open('w') as fp:
fp.write
Jason R. Coombs added the comment:
Yes. If I trust my message from earlier, this issue is resolved. Closing now.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
As I reviewed the PR, I do realize how tricky this change is going to be. In
addition to the three MSVC implementations in distutils, Setuptools has its own
(https://github.com/pypa/setuptools/blob/master/setuptools/msvc.py).
Interestingly, that file
Jason R. Coombs added the comment:
I've ported the initial patch over to the backport and am exploring options in
https://github.com/python/importlib_metadata/pull/266.
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Jason R. Coombs :
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issue42382>
___
___
Python-bugs-list mailing list
Unsubscrib
Jason R. Coombs added the comment:
In discussion, I realized that I don't yet understand what use-cases drive this
demand? What code is it that requires resolving a distribution from an entry
point?
--
___
Python tracker
<https://bugs.python.
Jason R. Coombs added the comment:
I'll take a look at the patch and convert it to a PR.
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
I've applied the patches and pushed them to
https://github.com/jaraco/cpython/tree/bugfix/bpo-38780.
```
cpython master $ http
https://bugs.python.org/file48933/0001-bpo-38780-Harden-socket-use-in-logging.handlers.patch
| git apply
cpython master $ git
Change by Jason R. Coombs :
--
pull_requests: +22527
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23661
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
Erlend, inspired by your patches, I created
https://github.com/python/cpython/pull/23661/commits/e9723003d49c722d57a69e5016b442d4d752fc6d,
which uses a NullSocket instance instead of None, allowing the
behavior-suppression to be encapsulated in a single
Change by Jason R. Coombs :
--
versions: +Python 3.10 -Python 2.7, Python 3.7
___
Python tracker
<https://bugs.python.org/issue38780>
___
___
Python-bugs-list m
Jason R. Coombs added the comment:
This issue was implemented, just not as fully as I'd have hoped. Still lacking
is native support for .files on the built-in package providers and removing the
legacy APIs or at least configuring them to rely on the files API, but as far
as supplying
Jason R. Coombs added the comment:
Thanks William for the detailed problem description.
If the issue has been fixed on Python 3.9 but not on 3.8, then it was likely a
redesign that enabled the improved behavior, a redesign that won't be ported
back to Python 3.8 and earlier
Jason R. Coombs added the comment:
The PR for the related issue does address pickling. Do you expect pickles to
work across Python versions?
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +22672
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23010
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
pull_requests: +22614
pull_request: https://github.com/python/cpython/pull/23758
___
Python tracker
<https://bugs.python.org/issue42
Jason R. Coombs added the comment:
If you wish for the functionality to be available in setuptools (backported),
please contribute the change at https://github.com/pypa/distutils. At some
point, contributions to CPython will also be synced there as well, and any
changes there get synced
Jason R. Coombs added the comment:
Pedro - thanks for the detailed report. Pull requests against
importlib_metadata are easier to accept because they can be tested more easily,
released more rapidly, and there's a straightforward way to port them to
CPython. Regardless, I see you've
Jason R. Coombs added the comment:
Yes - I keep both in sync.
--
___
Python tracker
<https://bugs.python.org/issue42382>
___
___
Python-bugs-list mailin
Change by Jason R. Coombs :
--
pull_requests: +22043
pull_request: https://github.com/python/cpython/pull/23127
___
Python tracker
<https://bugs.python.org/issue37
Jason R. Coombs added the comment:
Acknowledged. Thanks for the report. I'll likely address this issue alongside
the other (same PR).
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +21945
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23010
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
Please take a look at the PR. Let me know what you think about the limited
compatibility it adds (still doesn't allow _replace on 'processor').
--
___
Python tracker
<https://bugs.python.org/issue42
Jason R. Coombs added the comment:
New changeset c41559021213cfc9dc62a83fc63306b3bdc3e64b by MARUYAMA Norihiro in
branch 'master':
bpo-37193: remove thread objects which finished process its request (GH-13893)
https://github.com/python/cpython/commit/c41559021213cfc9dc62a83fc63306b3bdc3e64b
Change by Jason R. Coombs :
--
pull_requests: +22024
pull_request: https://github.com/python/cpython/pull/23107
___
Python tracker
<https://bugs.python.org/issue37
Jason R. Coombs added the comment:
I recommend a rollback. I’ll try to get to it later today.
--
___
Python tracker
<https://bugs.python.org/issue37193>
___
___
New submission from Jason R. Coombs :
In issue37193, I'd worked on an implementation in which a thread reference
would be removed as the thread was closing, but this led to a memory leak
caught by the buildbots (https://bugs.python.org/issue37193#msg380172).
As I tracked down the issue in GH
Jason R. Coombs added the comment:
I filed issue42263 to capture the underlying cause of the memory leak that led
to the buildbot failures and the rollback.
--
___
Python tracker
<https://bugs.python.org/issue37
Jason R. Coombs added the comment:
I marked bpo-42263 as a duplicate of this issue.
This issue is implicated in preventing the desired fix for bpo-37193, where a
thread wishes to remove the handle to itself after performing its duty. By
removing its own handle, it can never be joined
Change by Jason R. Coombs :
--
versions: +Python 3.10
___
Python tracker
<https://bugs.python.org/issue37788>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
Yes, I agree it's a duplicate of issue37788.
And yes, it does still leak if the list is never created or if the target is a
no-op.
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> fix for bpo-3640
Jason R. Coombs added the comment:
I don't think it's a race condition for two reasons: adding a `time.sleep(1)`
after `.start` still raises errors, and in issue37193, there were 10 threads
created, with at least 9 of those reaching termination before the test ended,
yet it showed 10
Jason R. Coombs added the comment:
> Regardless of whether PR 23611 is accepted, the test that it adds should be
> added to Python master to guard against regressions. I can submit that as a
> separate PR. Before I do that, do I need to create a new bpo ticket, or can I
> ju
Jason R. Coombs added the comment:
Can you tell me more about the use-case that exhibited this undesirable
behavior? That is, what loader is it that supports `open_binary` but not
`is_resource` and doesn't have a `__origin__`?
--
___
Python
Jason R. Coombs added the comment:
In [this
commit](https://github.com/python/importlib_resources/commit/bd20d893f11f387d285c666bc99fd2d4a7c33ef8),
I've reconciled and merged the changes from importlib_resources 3.2-5.0,
mainly the namespace package support
(https://importlib
Jason R. Coombs added the comment:
Thanks!
No rush, but ideally soon enough to be merged before the beta release of Python
3.10 (2021-05-03).
--
___
Python tracker
<https://bugs.python.org/issue42
1001 - 1100 of 1483 matches
Mail list logo