Karthikeyan Singaravelan added the comment:
Closing this as not a bug since autospeccing with create_autospec can be used
and spec only does attribute access validation.
Thanks
--
resolution: -> not a bug
stage: -> resolved
status: open -&g
Karthikeyan Singaravelan added the comment:
This seems to a reasonable change to me since dict.get returns the value then
making a contains check dict.__contains__ should return True instead of the
fixed return value of False. Below is a patch where the mock_wraps attribute is
set with the
Karthikeyan Singaravelan added the comment:
I am closing this in favor of issue21478 as the original report is now fixed.
Thanks.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
superseder: -> mock calls don't propagate to
Change by Karthikeyan Singaravelan :
--
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware
___
Python tracker
<https://bugs.python.org/issue38
Change by Karthikeyan Singaravelan :
--
nosy: +belopolsky, p-ganssle
___
Python tracker
<https://bugs.python.org/issue38082>
___
___
Python-bugs-list mailin
Karthikeyan Singaravelan added the comment:
Closing since docs are updated. Thank you Lisa.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Karthikeyan Singaravelan added the comment:
I will open a separate PR as discussed around mocking a class with an async
method which is patched with AsyncMock. Meanwhile a method that returns a
coroutine is patched with a MagicMock and needs to be explicitly mocked with an
AsyncMock as new
Karthikeyan Singaravelan added the comment:
async_case passes loop parameter to the queue used to collect tests and this
causes below DeprecationWarning with last change over deprecation in queues and
locks API.
./python.exe -m unittest Lib.unittest.test.test_async_case
/Users
Karthikeyan Singaravelan added the comment:
Few more tests and call sites
./python.exe -Wall -m test test_asyncio
Run tests sequentially
0:00:00 load avg: 2.41 [1/1] test_asyncio
/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/asyncio/locks.py:335:
DeprecationWarning: The loop
Karthikeyan Singaravelan added the comment:
Is it okay to have _asyncio_internal keyword with default value as False and
the places where it's used internally in stdlib like AsyncMock (Condition),
async_case (Queue) and other tests we can pass in True? I have a patch if that
would be a
Karthikeyan Singaravelan added the comment:
Ah okay. There were places like Condition's constructor that has a deprecation
warning and we construct a Lock with loop passed in the constructor and I
passed along _asyncio_internal. I would be happy to look into your PR since
mine is
Change by Karthikeyan Singaravelan :
--
pull_requests: +15519
pull_request: https://github.com/python/cpython/pull/15878
___
Python tracker
<https://bugs.python.org/issue32
Karthikeyan Singaravelan added the comment:
I did an initial try at the documentation. I think most of the functions are
very similar to the TestCase API and I just copied them to add the async
related information. I guess it could be improved to keep the length down with
still retaining
Karthikeyan Singaravelan added the comment:
I concur with Raymond here. Since mock is also part of stdlib and this issue
predates mock being merged to stdlib. I think adding it to unittest sort of
expands the unittest API being just an alias to mock.patch. mock.patch is used
in lot of
Karthikeyan Singaravelan added the comment:
Michael, any thoughts on this? This more feels like an enhancement to me and I
have marked it as 3.9 since I am not sure someone might be depending on the
behavior where they have used wraps but still expect default values for
magicmethods as they
Karthikeyan Singaravelan added the comment:
If we go ahead with this then we should also support other dunder methods of
tuple like __setitem__ and so on.
--
nosy: +cjw296, mariocj89, michael.foord
versions: -Python 2.7, Python 3.5, Python 3.6, Python 3.7
Karthikeyan Singaravelan added the comment:
Thanks for the report. I think this documentation part is missed in the linked
PR. I will prepare a PR that adds the versionchanged directive. Perhaps we can
also remove the important section or perhaps just keep the try..except example
to ensure
Change by Karthikeyan Singaravelan :
--
keywords: +patch
pull_requests: +15585
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15950
___
Python tracker
<https://bugs.python.org/issu
Karthikeyan Singaravelan added the comment:
The test added seems to have created an ImportWarning in
test_builtin.BuiltinTest.test_import .
./python.exe -Wall -m unittest -v test.test_builtin.BuiltinTest.test_import
test_import (test.test_builtin.BuiltinTest) ...
/Users
New submission from Karthikeyan Singaravelan :
Since d0cdeaab76fef8a6e5a04665df226b6659111e4e (bpo-32554) using random.seed
raises DeprecationWarning for some types. This is not handled in test_random
causing DeprecationWarnings. I will raise a PR for this.
commit
Change by Karthikeyan Singaravelan :
--
keywords: +patch
pull_requests: +15616
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15987
___
Python tracker
<https://bugs.python.org/issu
Karthikeyan Singaravelan added the comment:
Streams API is implemented as part of issue36889 in 3.8. I think we can close
this as a duplicate. Thanks.
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue34
Karthikeyan Singaravelan added the comment:
Closing as per OPs last message. Feel free to reopen if needed. Thanks.
--
nosy: +xtreak
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bug
Karthikeyan Singaravelan added the comment:
Sorry, is there an example of this use case. I went through the issue but have
trouble understanding it since there are different suggestions. I guess child
mock is always an AsyncMock irrespective of sync/async as I understand. We
already had
Karthikeyan Singaravelan added the comment:
The test is same as below and given that __spec__ an __name__ are passed as
None where ImportWarning is raised in Lib/importlib/_bootstrap.py 1074 . can we
just use self.assertWarns(ImportWarning) in the test?
>>> __import__('
Change by Karthikeyan Singaravelan :
--
resolution: -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder: -> Merge StreamWriter and StreamReader into just asyncio.Stream
___
Python tracker
<https://
Change by Karthikeyan Singaravelan :
--
pull_requests: +15628
pull_request: https://github.com/python/cpython/pull/16003
___
Python tracker
<https://bugs.python.org/issue37
Karthikeyan Singaravelan added the comment:
It was a conscious decision over not to do the proposed change in the issue.
There are other issues over signature difference during construction of mock
and in the call_matcher over presence/absence of self. It needs a more careful
fix
Karthikeyan Singaravelan added the comment:
Sure, I think these were not caught since deprecation warnings are not shown as
part of CI as failure. I just caught them at the sprint running with -Wall.
--
___
Python tracker
<https://bugs.python.
Change by Karthikeyan Singaravelan :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
title: Situs Judi Online Terpercaya -> Spam
___
Python tracker
<https://bugs.python
Change by Karthikeyan Singaravelan :
Removed file: https://bugs.python.org/file48605/images (3).jpg
___
Python tracker
<https://bugs.python.org/issue38129>
___
___
Pytho
Change by Karthikeyan Singaravelan :
--
Removed message: https://bugs.python.org/msg352053
___
Python tracker
<https://bugs.python.org/issue38129>
___
___
Pytho
Karthikeyan Singaravelan added the comment:
StreamReader and StreamWriter were merged to Stream with issue36889 and there
were also docs added for it along with asyncio docs rewritten. I am closing
this as fixed. Feel free to reopen if needed. Thanks.
--
nosy: +xtreak
resolution
Karthikeyan Singaravelan added the comment:
Current docs read as below with an example to show that earliest future is
returned. I guess this can be closed.
https://docs.python.org/dev/library/asyncio-task.html#asyncio.as_completed
Run awaitable objects in the aws set concurrently. Return
Karthikeyan Singaravelan added the comment:
I think this is a duplicate of issue37141 where multiple separators are
requested for readuntil. I guess we can close one of them as duplicates.
--
nosy: +xtreak
___
Python tracker
<ht
Change by Karthikeyan Singaravelan :
--
keywords: +patch
pull_requests: +15652
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/16029
___
Python tracker
<https://bugs.python.org/issu
Karthikeyan Singaravelan added the comment:
Given that the enhancement can only land on 3.9 I guess it will be a good
recipe on returning mock_open data for per file to be added to the unittest
examples page.
--
___
Python tracker
<ht
Karthikeyan Singaravelan added the comment:
Thanks for the report. This looks like a valid change to me as I can see from
the docstring it says it can be None but in the source code there is an
explicit check that if self._local._loop which is returned is None then raise a
RuntimeError. I
Karthikeyan Singaravelan added the comment:
IMO it gives a good segregation between other mocks and AsyncMock that using
assert_awaited_* makes it explicit and to cause less confusion over whether
this is an awaitable or a synchronous mock. I would favor in keeping the API. I
also found it
Karthikeyan Singaravelan added the comment:
asyncio tests are stable now and I couldn't find related reports. I guess it's
fixed in one of the commits and also AppVeyor is not used anymore. I guess this
can be closed as outdated.
--
nos
Karthikeyan Singaravelan added the comment:
Using test.bisect_cmd gets me to below test case
test_importlib leaked [1, 1, 1] references, sum=3
test_importlib failed
== Tests result: FAILURE ==
1 test failed:
test_importlib
Total duration: 3 sec 582 ms
Tests result: FAILURE
ran 1 tests
Change by Karthikeyan Singaravelan :
--
nosy: +belopolsky, p-ganssle
___
Python tracker
<https://bugs.python.org/issue38139>
___
___
Python-bugs-list mailin
Change by Karthikeyan Singaravelan :
--
type: crash -> behavior
___
Python tracker
<https://bugs.python.org/issue38139>
___
___
Python-bugs-list mai
Karthikeyan Singaravelan added the comment:
This seems to be same as issue22377 where UTC, GMT and value time.tzname in the
machine are the supported values.
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue38
Change by Karthikeyan Singaravelan :
--
nosy: +belopolsky, p-ganssle
___
Python tracker
<https://bugs.python.org/issue38051>
___
___
Python-bugs-list mailin
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue38013>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
I think this would be fixed by issue38013. Andrew I feel these are the same
issues here and can be closed.
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue37
Change by Karthikeyan Singaravelan :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> AsyncGenerator breaks when not iterated fully with
RuntimeError("can't send non-None value to a
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue38149>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
Just to add list.__contains__ and others might cause subtle changes as noted.
One example is around discussion at
https://github.com/python/cpython/pull/14700#discussion_r324054193 where my
code to fix mock.ANY was depending on this behavior to
New submission from Karthikeyan Singaravelan :
With issue37669 it was proposed to refactor out the mock_open handler to return
different mocks per file and an API change to make sure read_data accepts a
dictionary of file and return values it can only land on master if accepter.
It's al
Change by Karthikeyan Singaravelan :
--
keywords: +patch
pull_requests: +15711
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16090
___
Python tracker
<https://bugs.python.org/issu
Change by Karthikeyan Singaravelan :
--
pull_requests: +15713
pull_request: https://github.com/python/cpython/pull/16092
___
Python tracker
<https://bugs.python.org/issue12
Karthikeyan Singaravelan added the comment:
I believe it's still a problem with Mock though MagicMock and AsyncMock work
but I am not sure what would be the correct behavior that whether Mock should
behave like a coroutine or not as per the discussion here.
./python.exe
Python 3.
Karthikeyan Singaravelan added the comment:
awaited is now initialized with an Event object. Do you had any use case in
mind while designing it? I think it's a good choice to have True/False instead
of being used to give an Event object that is not used.
--
nosy: +xtreak
Change by Karthikeyan Singaravelan :
--
nosy: +cjw296, lisroach, mariocj89, xtreak
versions: +Python 3.9 -Python 2.7
___
Python tracker
<https://bugs.python.org/issue32
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue38164>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue38163>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Karthikeyan Singaravelan :
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue38174>
___
___
Python-bugs-list mailing list
Unsub
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue36274>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
I think it's more about how np.nan eq is implemented and not a bug in Python. I
find this answer to be a good explanation
https://stackoverflow.com/a/47788524/2610955
--
nosy: +xtreak
___
Python tr
Karthikeyan Singaravelan added the comment:
I think this should be fixed now as reported in
https://bugs.python.org/issue36046#msg352235 . Can you please try the latest
master branch?
--
nosy: +gregory.p.smith, xtreak
___
Python tracker
<ht
Karthikeyan Singaravelan added the comment:
I guess it's due to the binary not being built with ssl module. During build
did you get a message like below ?
Could not build the ssl module!
Python requires an OpenSSL 1.0.2 or 1.1 compatible libssl with
X509_VERIFY_PARAM_set1
Karthikeyan Singaravelan added the comment:
I don't think 3.7 needs a backport of the fix. I am closing this as fixed since
all PRs are merged. Please reopen if a backport is needed. Thanks @categulario.
--
___
Python tracker
&
Change by Karthikeyan Singaravelan :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Karthikeyan Singaravelan :
--
nosy: +rhettinger
type: -> enhancement
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issu
Karthikeyan Singaravelan added the comment:
Thanks for the confirmation. I am closing this as per issue36046.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
superseder: -> support dropping privileges when running
Karthikeyan Singaravelan added the comment:
Is there a reason why cherrypy doesn't URL encode the null byte in this test as
per comment :
https://github.com/cherrypy/cherrypy/issues/1781#issuecomment-504476658 ?
The original fix was adopted from golang
(https://github.com/golang/go/c
Karthikeyan Singaravelan added the comment:
sys.maxsize returns an integer so essentially sys.maxsize.__doc__ is giving
docs for int.__doc__. help(sys) to get to maxsize would help.
maxsize -- the largest supported length of containers.
python3
Python 3.8.0b4 (v3.8.0b4:d93605de72, Aug 29
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue38216>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
> @xtreak the encoded null-byte test would be an extra test case to consider.
> It is reasonable to test as many known invalid sequences as possible.
> Changing that byte to encoded notation would just replace one test with
> another
Change by Karthikeyan Singaravelan :
--
nosy: +paul.j3, rhettinger
versions: -Python 2.7, Python 3.5, Python 3.6, Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/issue38
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue38215>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Karthikeyan Singaravelan :
--
nosy: +pitrou
___
Python tracker
<https://bugs.python.org/issue38222>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Karthikeyan Singaravelan :
--
nosy: +inada.naoki
___
Python tracker
<https://bugs.python.org/issue38219>
___
___
Python-bugs-list mailing list
Unsub
Change by Karthikeyan Singaravelan :
--
nosy: +belopolsky, p-ganssle
___
Python tracker
<https://bugs.python.org/issue38228>
___
___
Python-bugs-list mailin
Karthikeyan Singaravelan added the comment:
For reference this is how urllib handled the same issue in their test suite :
https://github.com/urllib3/urllib3/pull/1673.
golang also received similar regression report as the change landed in 1.11.6
and discussion : https://github.com/golang/go
Karthikeyan Singaravelan added the comment:
Is this only about the test/ssl_servers.py ? I am not sure they are meant to be
used by users and might have path access for tests.
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.
Change by Karthikeyan Singaravelan :
--
title: A Path Traversal vulnerability in ssl_servers.py -> A Path Traversal
vulnerability in test/ssl_servers.py
___
Python tracker
<https://bugs.python.org/issu
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue38242>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue38242>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
Thanks for the report. There is a policy to report security vulnerabilities in
CPython : https://www.python.org/news/security/.
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue38
Change by Karthikeyan Singaravelan :
--
nosy: +ethan.furman
___
Python tracker
<https://bugs.python.org/issue38045>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
Closing this as the docs are merged with the initial patch to escape header
reverted. Thanks all for the reviews.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Karthikeyan Singaravelan added the comment:
Is this related to https://bugs.python.org/issue35941 given that it's related
to windows. Similar report https://bugs.python.org/issue37498
--
nosy: +xtreak
___
Python tracker
<https://bugs.py
Change by Karthikeyan Singaravelan :
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue38251>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
I think devguide has it's own repo that accepts PRs
https://github.com/python/devguide
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/is
Karthikeyan Singaravelan added the comment:
If I understand PR 16321 correctly it has a private hook to bypass validating
invalid bytes in URL added in 3.7.4 and also has the fix to accept non-ascii
values which is a regression from 2.7 to 3.0 . Will the latter to accept
non-ascii values
Change by Karthikeyan Singaravelan :
--
nosy: +maxking
___
Python tracker
<https://bugs.python.org/issue38232>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue38172>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
I am not sure about the difference between python 3.8-dev and nightly . The
pipelines seem to have same configuration. The version on both pipelines is
3.8.0b4+ and the nightly build passes :
https://travis-ci.org/pypa/bandersnatch/jobs/588664064
Karthikeyan Singaravelan added the comment:
A simplified example to reproduce the issue as below. It seems that the OSError
instance passed to the constructor is pickled such that during unpickling the
string part of OSError 'unittest' is passed to the constructor instead of the
Karthikeyan Singaravelan added the comment:
Thanks for the clarification and the answer link. I was also just debugging
along the similar lines around how OSError.__reduce__ treats the arguments
something like. Custom __reduce__ for aiohttp works as explained in the SO
answer.
class
Karthikeyan Singaravelan added the comment:
I think there was a bug in the past in regrtest or tempfile where the temporary
files for tests were not deleted and lead to disk space filled up in several
buildbots.
--
nosy: +pablogsal, vstinner, xtreak
Change by Karthikeyan Singaravelan :
--
nosy: +gvanrossum
___
Python tracker
<https://bugs.python.org/issue38277>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
IIRC there was a debate over allowing top level assignment expression without
parentheses in original PEP 572 issue and most of the docs and examples follow
using parentheses to avoid this confusion. I just noticed while reading the PEP
that list
Change by Karthikeyan Singaravelan :
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue38303>
___
___
Python-bugs-list mailin
Karthikeyan Singaravelan added the comment:
This is an issue tracker for CPython. The build log seems like an issue with
pyworld package. I would suggest creating an issue in their tracker.
--
nosy: +xtreak
___
Python tracker
<ht
Change by Karthikeyan Singaravelan :
--
nosy: +jaraco
___
Python tracker
<https://bugs.python.org/issue38342>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
The library was synced with https://bugs.python.org/issue38121 which seems to
be related to this.
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue38
101 - 200 of 3092 matches
Mail list logo