[issue47255] Many broken :meth: roles in the docs

2022-04-08 Thread Ken Jin
Ken Jin added the comment: It's 3.10 only. Presumably our sphinx version changed then and something broke. In 3.9 and earlier the links are all fine. See https://bugs.python.org/issue42182 for a similar issue I raised ages ago. -- nosy: +kj

[issue47234] PEP-484 "numeric tower" approach makes it hard/impossible to specify contracts in documentation

2022-04-06 Thread Ken Jin
Change by Ken Jin : -- nosy: -kj ___ Python tracker <https://bugs.python.org/issue47234> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue46769] Improve documentation for `typing.TypeVar`

2022-04-06 Thread Ken Jin
Ken Jin added the comment: New changeset d6a7ee69fb3263450ba47bed9104f4a68a08a9bd by Ken Jin in branch '3.9': [3.9] bpo-46769: Fix backticks in typing.rst to appease rstlint (GH-32375) https://github.com/python/cpython/commit/d6a7ee69fb3263450ba47bed9104f4a68a08a9bd

[issue46769] Improve documentation for `typing.TypeVar`

2022-04-06 Thread Ken Jin
Ken Jin added the comment: New changeset 80af26d25af5568229d31ecb2a8f1bf9702b7791 by Ken Jin in branch '3.10': [3.10] bpo-46769: Fix backticks in typing.rst to appease rstlint (GH-32374) https://github.com/python/cpython/commit/80af26d25af5568229d31ecb2a8f1bf9702b7791

[issue47104] Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase

2022-04-06 Thread Ken Jin
Ken Jin added the comment: I forgot to specify, that this is *only* on 3.10, not main. -- ___ Python tracker <https://bugs.python.org/issue47104> ___ ___ Pytho

[issue47104] Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase

2022-04-06 Thread Ken Jin
Ken Jin added the comment: Andrew, it seems that the post-commit CI has started failing after this commit. Specifically it says "test_asyncio failed (env changed)" >From this page, https://github.com/python/cpython/commits/3.10?after=3856b4995ec0e632d47b733cdecb5183ac8

[issue46769] Improve documentation for `typing.TypeVar`

2022-04-06 Thread Ken Jin
Change by Ken Jin : -- pull_requests: +30418 pull_request: https://github.com/python/cpython/pull/32375 ___ Python tracker <https://bugs.python.org/issue46

[issue46769] Improve documentation for `typing.TypeVar`

2022-04-06 Thread Ken Jin
Change by Ken Jin : -- pull_requests: +30417 pull_request: https://github.com/python/cpython/pull/32374 ___ Python tracker <https://bugs.python.org/issue46

[issue47189] What's new in Python 3.11: Faster CPython

2022-04-06 Thread Ken Jin
Change by Ken Jin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue47189] What's new in Python 3.11: Faster CPython

2022-04-06 Thread Ken Jin
New submission from Ken Jin : New changeset 9ffe47df5468a72603f730eae48c2fd4ec615ffa by Ken Jin in branch 'main': bpo-47189: What's New in 3.11: Faster CPython (GH-32235) https://github.com/python/cpython/commit/9ffe47df5468a72603f730eae48c2fd4ec615ffa

[issue47205] test_sched_getaffinity and setaffinity fail on FreeBSD buildbit

2022-04-03 Thread Ken Jin
Ken Jin added the comment: FWIW, seems like the buildbot started failing at either commit cb495a1e9f3acfcd8cb94a6b89c79d0909e3383f or 708812085355c92f32e547d1f1d1f29aefbbc27e. But I have no clue how commits changing the Windows build config can lead to test_posix failing. -- nosy

[issue47189] What's new in Python 3.11: Faster CPython

2022-04-01 Thread Ken Jin
Change by Ken Jin : -- keywords: +patch pull_requests: +30307 stage: -> patch review pull_request: https://github.com/python/cpython/pull/32235 ___ Python tracker <https://bugs.python.org/issu

[issue47189] What's new in Python 3.11: Faster CPython

2022-04-01 Thread Ken Jin
Change by Ken Jin : -- assignee: docs@python components: Documentation nosy: docs@python, kj priority: normal severity: normal status: open title: What's new in Python 3.11: Faster CPython versions: Python 3.11 ___ Python tracker <ht

[issue47164] [C API] Add private "CAST" macros to clean up casts in C code

2022-03-30 Thread Ken Jin
Ken Jin added the comment: @Victor, I'm not against (A) or any of the PRs you proposed. They look fine to me. My concern was with certain static inline functions (there are none here :). The _CAST macros have genuinely helped me debug code before

[issue47164] [C API] Add private "CAST" macros to clean up casts in C code

2022-03-30 Thread Ken Jin
Ken Jin added the comment: > tiny inline function obscures the meaning of code Sadly I have to agree with Mark for that specific case. I've had to debug a segfault before only because the inline function implicitly cast its arguments, and it was accessing a non-existent member. If it w

[issue47127] Specialize call for c functions with METH_FASTCALL|METH_KEYWORDS

2022-03-27 Thread Ken Jin
Ken Jin added the comment: New changeset 58448cbd96f77ebc6fca1f8030bedc7744eb66ef by Kumar Aditya in branch 'main': bpo-47127: Specialize calls for fastcall c methods with keywords (GH-32125) https://github.com/python/cpython/commit/58448cbd96f77ebc6fca1f8030bedc7744eb66ef -- nosy

[issue47130] mro and super don't feel so pythonic

2022-03-26 Thread Ken Jin
Ken Jin added the comment: Hi @mamliteria, this is the bug tracker for CPython. I understand that you have suggestions to improve super(), but feature suggestions usually go on the python-ideas mailing list [1]. So you might want to post on there instead. If you're interested, the MRO

[issue46939] Specialize calls for Python classes

2022-03-16 Thread Ken Jin
Change by Ken Jin : -- pull_requests: +30028 pull_request: https://github.com/python/cpython/pull/31936 ___ Python tracker <https://bugs.python.org/issue46

[issue46991] Specialize list[slice]

2022-03-14 Thread Ken Jin
Ken Jin added the comment: Closed for now. See https://github.com/python/cpython/pull/31870#issuecomment-1066884537 for an explanation. -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracke

[issue46991] Specialize list[slice]

2022-03-14 Thread Ken Jin
Change by Ken Jin : -- keywords: +patch pull_requests: +29969 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31870 ___ Python tracker <https://bugs.python.org/issu

[issue43224] Add support for PEP 646

2022-03-12 Thread Ken Jin
Ken Jin added the comment: New changeset af2277e461aee4eb96affd06b4af25aad31c81ea by Matthew Rahtz in branch 'main': bpo-43224: Implement PEP 646 changes to genericaliasobject.c (GH-31019) https://github.com/python/cpython/commit/af2277e461aee4eb96affd06b4af25aad31c81ea

[issue46991] Specialize list[slice]

2022-03-11 Thread Ken Jin
New submission from Ken Jin : According to https://github.com/faster-cpython/ideas/blob/main/stats.md#binary_subscr it's the second most common failed specialization. array.array[int] is quite hard to specialize, considering that array.array deals with 13 different item types based on its

[issue46881] Statically allocate and initialize the latin1 characters.

2022-03-11 Thread Ken Jin
Ken Jin added the comment: New changeset 54ab9ad312ea53db40e31712454272e1d4c0315f by Jelle Zijlstra in branch 'main': bpo-46881: Fix refleak from GH-31616 (GH-31805) https://github.com/python/cpython/commit/54ab9ad312ea53db40e31712454272e1d4c0315f -- nosy: +kj

[issue46939] Specialize calls for Python classes

2022-03-06 Thread Ken Jin
Change by Ken Jin : -- keywords: +patch pull_requests: +29827 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31707 ___ Python tracker <https://bugs.python.org/issu

[issue46939] Specialize calls for Python classes

2022-03-06 Thread Ken Jin
New submission from Ken Jin : Please see https://github.com/faster-cpython/ideas/issues/267. I hope I'm not stepping on anyone's toes here (sorry if I cause any duplicate work)! -- messages: 414618 nosy: Mark.Shannon, kj priority: normal severity: normal status: open title

[issue46921] Vectorcall support for super()

2022-03-05 Thread Ken Jin
Change by Ken Jin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46921] Vectorcall support for super()

2022-03-05 Thread Ken Jin
Ken Jin added the comment: New changeset 602024e6e12c69d836aa191d63db75862aec2493 by Ken Jin in branch 'main': bpo-46921: Vectorcall support for `super()` (GH-31687) https://github.com/python/cpython/commit/602024e6e12c69d836aa191d63db75862aec2493

[issue46921] Vectorcall support for super()

2022-03-04 Thread Ken Jin
Change by Ken Jin : -- keywords: +patch pull_requests: +29806 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31687 ___ Python tracker <https://bugs.python.org/issu

[issue46921] Vectorcall support for super()

2022-03-04 Thread Ken Jin
New submission from Ken Jin : This is related to bpo-46564. The changes are less ambitious but should produce a nice speedup. -- messages: 414535 nosy: kj priority: normal severity: normal status: open title: Vectorcall support for super() versions: Python 3.11

[issue46581] _typevar_types and _paramspec_tvars are missing from _GenericAlias.copy_with

2022-02-01 Thread Ken Jin
Ken Jin added the comment: > In short, I will do my best, but I suspect I will need patience and guidance > in arriving something acceptable. Yeah no worries. typing.py is really complex for many historical reasons. I still don't grasp all of it and probably never will. > w

[issue46564] Near zero-cost super().meth() calls via adaptive superinstructions

2022-02-01 Thread Ken Jin
Ken Jin added the comment: New changeset b9ebde8db7e176e021103745cd012bae700828b5 by Kumar Aditya in branch 'main': bpo-46564: do not create frame object for super object (GH-31002) https://github.com/python/cpython/commit/b9ebde8db7e176e021103745cd012bae700828b5

[issue46482] `typing.Annotation.__new__` is not covered

2022-02-01 Thread Ken Jin
Ken Jin added the comment: New changeset 4c0612ad00ba45dbea2a86f7db6d21546cf243f8 by Nikita Sobolev in branch 'main': bpo-46482: add a test for `typing.Annotation.__new__` (GH-30821) https://github.com/python/cpython/commit/4c0612ad00ba45dbea2a86f7db6d21546cf243f8

[issue46407] optimizing `1 << n` or `2 ** n` and modulo-only operations

2022-01-30 Thread Ken Jin
Change by Ken Jin : -- nosy: +kj nosy_count: 6.0 -> 7.0 pull_requests: +29206 pull_request: https://github.com/python/cpython/pull/31025 ___ Python tracker <https://bugs.python.org/issu

[issue46571] Strange `@typing.no_type_check` behavior for class variables

2022-01-30 Thread Ken Jin
Ken Jin added the comment: I agree with Jelle, let's go with (2). It feels strange to have a decorator modify types that it doesn't own. -- ___ Python tracker <https://bugs.python.org/issue46

[issue46581] _typevar_types and _paramspec_tvars are missing from _GenericAlias.copy_with

2022-01-30 Thread Ken Jin
Ken Jin added the comment: Wow! Thanks, that's an interesting find. My hunch is that we should be passing in _typevar_types and _paramspec_tvars in the copy_with of _GenericAlias and _ConcatenateGenericAlias. Inconsistent copy_with could trigger subtle bugs in ForwardRefs and get_type_hints

[issue46329] Split up the CALL_NO_KW and CALL_KW instructions.

2022-01-28 Thread Ken Jin
Change by Ken Jin : -- pull_requests: +29186 pull_request: https://github.com/python/cpython/pull/31005 ___ Python tracker <https://bugs.python.org/issue46

[issue46564] Near zero-cost super().meth() calls via adaptive superinstructions

2022-01-28 Thread Ken Jin
Ken Jin added the comment: > Oh, I didn't see your PR and commented as it was not mentioned in this bpo. No problem. In the future please check the "Pull Requests" section on the issue. People don't always say "I created a PR at xxx". Often times we just link the P

[issue46564] Near zero-cost super().meth() calls via adaptive superinstructions

2022-01-28 Thread Ken Jin
Ken Jin added the comment: @Kumar, my PR already has your changes. -- ___ Python tracker <https://bugs.python.org/issue46564> ___ ___ Python-bugs-list mailin

[issue46560] ParamSpec: Typo in doc string

2022-01-28 Thread Ken Jin
Ken Jin added the comment: Thanks for the fix Zackery. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46560] ParamSpec: Typo in doc string

2022-01-28 Thread Ken Jin
Ken Jin added the comment: New changeset ffa505b580464d9d90c29e69bd4db8c52275280a by Zackery Spytz in branch 'main': bpo-46560: Fix a typo in `typing.ParamSpec's` doc string (GH-30995) https://github.com/python/cpython/commit/ffa505b580464d9d90c29e69bd4db8c52275280a -- nosy: +kj

[issue46564] Near zero-cost super().meth() calls via adaptive superinstructions

2022-01-28 Thread Ken Jin
Change by Ken Jin : -- keywords: +patch pull_requests: +29172 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30992 ___ Python tracker <https://bugs.python.org/issu

[issue46564] Near zero-cost super().meth() calls via adaptive superinstructions

2022-01-28 Thread Ken Jin
New submission from Ken Jin : `super().meth()` is expensive. I propose to optimize 3 parts of this: 1. Avoid creating a temporary super() proxy object. 2. Avoid creating a bound method. 3. Avoid method lookup in super MRO using the inline cache. Credit for 1. and 2. doesn't belong to me

[issue46528] Simplify the VM's stack manipulations

2022-01-28 Thread Ken Jin
Ken Jin added the comment: > IIRC, Carl got a lot of benefit out of reordering the opcodes in the main > loop to put the most common ones at the top. I don't know if that is still > relevant or whether computed gotos, when enabled, change that calculus. AFAIK, on nix systems

[issue46533] Specialize for staticmethods and classmethods

2022-01-26 Thread Ken Jin
Ken Jin added the comment: Ah woops, my bad, I mixed up the two concepts. Thanks for the thorough explanation here! -- ___ Python tracker <https://bugs.python.org/issue46

[issue46516] Use existing unbound_local_error label in DELETE_FAST opcode

2022-01-26 Thread Ken Jin
Ken Jin added the comment: Not sure why the merge message didn't appear here, but thanks! -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46529] Improve test coverage of `Union` and `Optional` repr()

2022-01-26 Thread Ken Jin
Change by Ken Jin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46533] Specialize for staticmethods and classmethods

2022-01-26 Thread Ken Jin
Ken Jin added the comment: Slightly off topic rambling: My own toy attempts at classmethod specialization suggested that it barely sped anything up. Most of the time went to creation of the new classmethod object. I'd imagine supporting Py_TPFLAGS_METHOD_DESCRIPTOR would speed things up

[issue46529] Improve test coverage of `Union` and `Optional` repr()

2022-01-26 Thread Ken Jin
Ken Jin added the comment: New changeset d0c690b5f85c679de6059cf353fe0524e905530e by Nikita Sobolev in branch 'main': bpo-46529: increase coverage of `typing.Union.__repr__` method (GH-30911) https://github.com/python/cpython/commit/d0c690b5f85c679de6059cf353fe0524e905530e

[issue46523] Test suite skips failing tests when setUp[Class] fails

2022-01-25 Thread Ken Jin
Change by Ken Jin : -- title: Test suite skips failing tests -> Test suite skips failing tests when setUp[Class] fails ___ Python tracker <https://bugs.python.org/issu

[issue46523] Test suite skips failing tests

2022-01-25 Thread Ken Jin
Ken Jin added the comment: I vote for option 2. -- nosy: +ezio.melotti, gvanrossum, kj ___ Python tracker <https://bugs.python.org/issue46523> ___ ___ Python-bug

[issue46519] test_typing failing on branch 3.10

2022-01-25 Thread Ken Jin
Change by Ken Jin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46519] test_typing failing on branch 3.10

2022-01-25 Thread Ken Jin
Ken Jin added the comment: New changeset 9a7d01046723a8a0a10f9a26702c5e39e73d4414 by Ken Jin in branch '3.10': [3.10] bpo-46445, bpo-46519: Re-import typing.NewType (GH-30886) https://github.com/python/cpython/commit/9a7d01046723a8a0a10f9a26702c5e39e73d4414

[issue46445] Multiple inheritance of TypedDict is not covered in `test_typing`

2022-01-25 Thread Ken Jin
Ken Jin added the comment: New changeset 9a7d01046723a8a0a10f9a26702c5e39e73d4414 by Ken Jin in branch '3.10': [3.10] bpo-46445, bpo-46519: Re-import typing.NewType (GH-30886) https://github.com/python/cpython/commit/9a7d01046723a8a0a10f9a26702c5e39e73d4414

[issue46519] test_typing failing on branch 3.10

2022-01-25 Thread Ken Jin
Ken Jin added the comment: The test correctly fails on the first run in the CI, then skips itself on the second run, tricking the CI into thinking everything's passed. E.g. search for "test_typing" here https://github.com/python/cpython/runs/4902363883?check_suite_focus=true.

[issue46519] test_typing failing on branch 3.10

2022-01-25 Thread Ken Jin
Change by Ken Jin : -- keywords: +patch pull_requests: +29068 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30886 ___ Python tracker <https://bugs.python.org/issu

[issue46445] Multiple inheritance of TypedDict is not covered in `test_typing`

2022-01-25 Thread Ken Jin
Change by Ken Jin : -- pull_requests: +29067 pull_request: https://github.com/python/cpython/pull/30886 ___ Python tracker <https://bugs.python.org/issue46

[issue46519] test_typing failing on branch 3.10

2022-01-25 Thread Ken Jin
Ken Jin added the comment: Thanks Matheus for the report. I can reproduce this too. Unrelated: I'm confused why the CI checks passed on 3.10. Furthermore the buildbots aren't complaining. -- nosy: +kj, sobolevn ___ Python tracker <ht

[issue46491] typing: allow Annotated in outermost scope

2022-01-25 Thread Ken Jin
Ken Jin added the comment: Thanks Gregory for fixing this! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45680] Documentation on `GenericAlias` objects and `__class_getitem__` could be improved

2022-01-24 Thread Ken Jin
Ken Jin added the comment: > Wait... there's still PR 29479 open! Sorry, I was too excited when PR 29335 merged and missed that. In the future, please re-open if you feel I closed an issue wrongly. Thanks! -- resolution: fixed -> status: closed -

[issue46416] Direct invocation of `Lib/test/test_typing.py` fails

2022-01-24 Thread Ken Jin
Ken Jin added the comment: New changeset eaeb99468045b863d2dd3da3e3d1c3c9c78e1254 by Nikita Sobolev in branch '3.10': [3.10] bpo-46416: Allow direct invocation of `Lib/test/test_typing.py` (GH-30641) (GH-30697) https://github.com/python/cpython/commit

[issue46494] Mention typing_extensions in the typing documentation

2022-01-24 Thread Ken Jin
Ken Jin added the comment: Yes please, this is a great idea. -- keywords: +easy, newcomer friendly ___ Python tracker <https://bugs.python.org/issue46

[issue46470] `_remove_dups_flatten` in `typing.py` contains dead branch

2022-01-24 Thread Ken Jin
Change by Ken Jin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46396] `Concatenate` should not raise any semantic errors

2022-01-24 Thread Ken Jin
Ken Jin added the comment: I'm a little conflicted on this specific use case (but maybe I'm biased because I wrote the checks :). I'm a strong proponent of less runtime checks. However, in this case, the exceptions serve as easy hints to the user, and they're meant to catch the most basic

[issue46470] `_remove_dups_flatten` in `typing.py` contains dead branch

2022-01-24 Thread Ken Jin
Ken Jin added the comment: New changeset c144d9363107b50bcb0ccd01e7202e26a40c21f0 by Nikita Sobolev in branch 'main': bpo-46470: remove unused branch from `typing._remove_dups_flatten` (GH-30780) https://github.com/python/cpython/commit/c144d9363107b50bcb0ccd01e7202e26a40c21f0

[issue46465] Regression caused by CALL_FUNCTION specialization for C function calls

2022-01-23 Thread Ken Jin
Ken Jin added the comment: A short summary (thanks to Victor's findings!): - os.kill(pid, signal.SIGINT) is specialized to CALL_NO_KW_FAST - CALL_NO_KW_FAST doesn't check eval breaker, so the signal is ignored - signal handler wasn't called, test fails I'd like to add tests for some

[issue46465] Regression caused by CALL_FUNCTION specialization for C function calls

2022-01-23 Thread Ken Jin
Change by Ken Jin : -- keywords: +patch pull_requests: +29013 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30826 ___ Python tracker <https://bugs.python.org/issu

[issue46465] Regression caused by CALL_FUNCTION specialization for C function calls

2022-01-23 Thread Ken Jin
Ken Jin added the comment: Thanks @Victor for catching this and figuring it out. I had a hard time narrowing this down since I'm on Windows which doesn't support signals :(. I'll handle the required patch and tests. -- ___ Python tracker <ht

[issue46413] `__or__` is not covered for `_GenericAlias` and `_SpecialGenericAlias` in `typing`

2022-01-19 Thread Ken Jin
Change by Ken Jin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 ___ Python tracker <https://bugs.python.or

[issue45680] Documentation on `GenericAlias` objects and `__class_getitem__` could be improved

2022-01-19 Thread Ken Jin
Ken Jin added the comment: Phew, we're finally done. Thanks Alex for the PRs, and Ɓukasz, Guido (and many others) for all the reviews! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracke

[issue45680] Documentation on `GenericAlias` objects and `__class_getitem__` could be improved

2022-01-19 Thread Ken Jin
Ken Jin added the comment: New changeset 00645166b64e68001a425a15281a1ccdcb78f818 by Ken Jin in branch '3.9': [3.9] bpo-45680: Clarify documentation on ``GenericAlias`` objects (GH-29335) (GH-30689) https://github.com/python/cpython/commit/00645166b64e68001a425a15281a1ccdcb78f818

[issue45680] Documentation on `GenericAlias` objects and `__class_getitem__` could be improved

2022-01-19 Thread Ken Jin
Ken Jin added the comment: New changeset 1faf7c4effbe8b66f9b0347cab570fb3b5c91fb0 by Ken Jin in branch 'main': bpo-45680: Minor formatting fix in stdtypes.rst (GH-30690) https://github.com/python/cpython/commit/1faf7c4effbe8b66f9b0347cab570fb3b5c91fb0

[issue46413] `__or__` is not covered for `_GenericAlias` and `_SpecialGenericAlias` in `typing`

2022-01-19 Thread Ken Jin
Ken Jin added the comment: New changeset 0a49148e87cca11e3820cbff2abfd316986a68c6 by Nikita Sobolev in branch 'main': bpo-46413: properly test `__{r}or__` code paths in `_SpecialGenericAlias` (GH-30640) https://github.com/python/cpython/commit/0a49148e87cca11e3820cbff2abfd316986a68c6

[issue45680] Documentation on `GenericAlias` objects and `__class_getitem__` could be improved

2022-01-19 Thread Ken Jin
Change by Ken Jin : -- pull_requests: +2 pull_request: https://github.com/python/cpython/pull/30690 ___ Python tracker <https://bugs.python.org/issue45

[issue45680] Documentation on `GenericAlias` objects and `__class_getitem__` could be improved

2022-01-19 Thread Ken Jin
Change by Ken Jin : -- pull_requests: +28887 pull_request: https://github.com/python/cpython/pull/30689 ___ Python tracker <https://bugs.python.org/issue45

[issue45680] Documentation on `GenericAlias` objects and `__class_getitem__` could be improved

2022-01-19 Thread Ken Jin
Ken Jin added the comment: New changeset 0eae9a2a2db6cc5a72535f61bb988cc417011640 by Alex Waygood in branch 'main': bpo-45680: Clarify documentation on ``GenericAlias`` objects (GH-29335) https://github.com/python/cpython/commit/0eae9a2a2db6cc5a72535f61bb988cc417011640

[issue46416] Direct invocation of `Lib/test/test_typing.py` fails

2022-01-19 Thread Ken Jin
Ken Jin added the comment: New changeset 2792d6d18eab3efeb71e6397f88db86e610541f1 by Nikita Sobolev in branch 'main': bpo-46416: Allow direct invocation of `Lib/test/test_typing.py` (GH-30641) https://github.com/python/cpython/commit/2792d6d18eab3efeb71e6397f88db86e610541f1 -- nosy

[issue46424] `typing.Annotated` one type argument usage is not covered in tests

2022-01-18 Thread Ken Jin
Ken Jin added the comment: New changeset 32398294fb3fcf4ee74da54722fd0221c4e6cb74 by Nikita Sobolev in branch 'main': bpo-46424: [typing] cover `Annotation[arg]` invalid usage in tests (GH-30663) https://github.com/python/cpython/commit/32398294fb3fcf4ee74da54722fd0221c4e6cb74

[issue46395] `Concatenate` is not covered to be a return type in `test_typing`

2022-01-16 Thread Ken Jin
Ken Jin added the comment: > In this case, do we need to make this a `TypeError`? Right now you can use > `Concatenate` as the return type. Last I recall, we stopped checking anything in the param args of Callable since 3.10 because it has too many problems with inter-version

[issue46395] `Concatenate` is not covered to be a return type in `test_typing`

2022-01-16 Thread Ken Jin
Ken Jin added the comment: Sorry I'm confused: Callable[..., Concatenate] is invalid usage. So I don't think we need to test it. https://docs.python.org/3/library/typing.html#typing.Concatenate. "Concatenate is currently only valid when used as the first argument to a Cal

[issue46359] Continue to modernize `test_typing.py`

2022-01-13 Thread Ken Jin
Ken Jin added the comment: New changeset 8c49d057bf8618208d4ed67c9caecbfa71f7a2d0 by Nikita Sobolev in branch 'main': bpo-46359: Modernize `test_typing` by removing checks for EOL Python versions (GH-30563) https://github.com/python/cpython/commit/8c49d057bf8618208d4ed67c9caecbfa71f7a2d0

[issue46333] ForwardRef.__eq__ does not respect module parameter

2022-01-12 Thread Ken Jin
Ken Jin added the comment: @Andreas First of all, thanks for addressing my questions on the PR. I have one more question which I'll post here since it's not entirely related to your PR. ForwardRef isn't meant to be explicitly instantiated by a user [1] (it's a typing internal class), so do

[issue46244] typing._TypeVarLike missing __slots__

2022-01-10 Thread Ken Jin
Ken Jin added the comment: New changeset 081a2140083680ffc309e53699aea29e71760d70 by Arie Bovenberg in branch 'main': bpo-46244: Remove __slots__ from typing.TypeVar, .ParamSpec (#30444) https://github.com/python/cpython/commit/081a2140083680ffc309e53699aea29e71760d70

[issue45665] Problems caused by isinstance(list[int], type) returning True

2022-01-04 Thread Ken Jin
Ken Jin added the comment: > It does seem inconsistent that Any is not considered a type but list[int] is Yeah, almost none of the typing "types" are types ever since PEP 560. Issue45755 was a side effect too. -- ___ Python tr

[issue46244] typing._TypeVarLike missing __slots__

2022-01-04 Thread Ken Jin
Ken Jin added the comment: Good catch Arie. Would you like to submit a PR for this? -- ___ Python tracker <https://bugs.python.org/issue46244> ___ ___ Python-bug

[issue46104] Reduce use of old-style syntax in typing docs

2021-12-19 Thread Ken Jin
Ken Jin added the comment: New changeset 7c5c3f7254d78babcaf7a2ec187fd6ec53b8403c by Alex Waygood in branch 'main': bpo-46104: Fix example broken by GH-30148 (GH-30203) https://github.com/python/cpython/commit/7c5c3f7254d78babcaf7a2ec187fd6ec53b8403c

[issue46130] Untranslatable link text in whatsnew/3.10

2021-12-19 Thread Ken Jin
Ken Jin added the comment: Thanks Rafael for your efforts in docs translations. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46130] Untranslatable link text in whatsnew/3.10

2021-12-19 Thread Ken Jin
Ken Jin added the comment: New changeset 3d3615f41f4ea73fe6707eb3673dfab482cb6a2b by Rafael Fontenelle in branch 'main': bpo-46130: [docs] Add anchor for whatsnew/3.10 type hint section (GH-30199) https://github.com/python/cpython/commit/3d3615f41f4ea73fe6707eb3673dfab482cb6a2b

[issue46113] Typos and minor fixes in built in types documentation

2021-12-18 Thread Ken Jin
Change by Ken Jin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46113] Typos and minor fixes in built in types documentation

2021-12-18 Thread Ken Jin
Ken Jin added the comment: New changeset 0da17eb06943a66fcd826ff591d47c22c2c0595a by Miss Islington (bot) in branch '3.9': bpo-46113: Minor fixes in stdtypes documentation (GH-30167) (GH-30187) https://github.com/python/cpython/commit/0da17eb06943a66fcd826ff591d47c22c2c0595a

[issue46113] Typos and minor fixes in built in types documentation

2021-12-18 Thread Ken Jin
Ken Jin added the comment: New changeset bb286d45afa6740384bab97d0da68fe571efb6ec by Miss Islington (bot) in branch '3.10': bpo-46113: Minor fixes in stdtypes documentation (GH-30167) (GH-30186) https://github.com/python/cpython/commit/bb286d45afa6740384bab97d0da68fe571efb6ec

[issue46122] Update/fix types.UnionType to types.Union in Built-in Types documentation

2021-12-18 Thread Ken Jin
Ken Jin added the comment: Thanks for the PR Vivek. Can you please tell me the exact 3.10 version you're running? In earlier 3.10 versions (alpha, beta etc.) types.Union existed, but somewhere later (rc1,rc2) it became types.UnionType. The final 3.10.0 release has types.UnionType

[issue46113] Typos and minor fixes in built in types documentation

2021-12-18 Thread Ken Jin
Ken Jin added the comment: New changeset 6f2df4295123f8b961d49474b7668f7564a534a4 by Vivek Vashist in branch 'main': bpo-46113: Minor fixes in stdtypes documentation (GH-30167) https://github.com/python/cpython/commit/6f2df4295123f8b961d49474b7668f7564a534a4 -- nosy: +kj

[issue46104] Reduce use of old-style syntax in typing docs

2021-12-18 Thread Ken Jin
Ken Jin added the comment: New changeset 6ada013df170b0afb6b61a0d942388c6fd81cbc9 by Alex Waygood in branch 'main': bpo-46104: Reduce use of pre-PEP 526 syntax in typing docs (GH-30148) https://github.com/python/cpython/commit/6ada013df170b0afb6b61a0d942388c6fd81cbc9

[issue45755] Specialized generic class does not return class attributes in dir

2021-12-16 Thread Ken Jin
Ken Jin added the comment: Hi, I won't be backporting this to 3.9 since I don't like having jarring behavior changes so late into the bugfix cycle of a Python version. I'm tempted to backport to 3.10. For now, I'll be conservative and just merge it in main. Please do tell me if any of you

[issue45755] Specialized generic class does not return class attributes in dir

2021-12-16 Thread Ken Jin
Ken Jin added the comment: New changeset d6e13747161d7b634b47d2d3d212ed3be4a21fab by Ken Jin in branch 'main': bpo-45755: [typing] Reveal class attributes of generic in generic aliases in `dir()` (GH-29962) https://github.com/python/cpython/commit/d6e13747161d7b634b47d2d3d212ed3be4a21fab

[issue46097] Split function versions into 1-0xffff and 0x1000+ regions

2021-12-16 Thread Ken Jin
Change by Ken Jin : -- nosy: +kj ___ Python tracker <https://bugs.python.org/issue46097> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-12-15 Thread Ken Jin
Ken Jin added the comment: Happened to a PR I was reviewing today: https://github.com/python/cpython/runs/4535247255?check_suite_focus=true -- keywords: -patch nosy: +kj versions: +Python 3.11 ___ Python tracker <https://bugs.python.

[issue46046] I/O bound threads got to no chance to run with small CPU bound threads with new GIL

2021-12-14 Thread Ken Jin
Ken Jin added the comment: Hi, Thank you for your interest in Python, and especially the GIL. David Beazley opened an issue for his PyCon 2010 GIL talk at https://bugs.python.org/issue7946. You can discuss more on that issue (I suggest first reading through it, there's a really long

[issue46059] Typo in match Statement example

2021-12-14 Thread Ken Jin
Change by Ken Jin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46059] Typo in match Statement example

2021-12-14 Thread Ken Jin
Ken Jin added the comment: New changeset 1cbb88736c32ac30fd530371adf53fe7554be0a5 by Alex Waygood in branch 'main': bpo-46059: Clarify pattern-matching example in "control flow" docs (GH-30079) https://github.com/python/cpython/commit/1cbb88736c32ac30fd530371adf53f

  1   2   3   4   5   6   >