Change by Kyle Stanley :
--
keywords: +patch
pull_requests: +14425
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/14611
___
Python tracker
<https://bugs.python.org/issu
Kyle Stanley added the comment:
Actually, I don't believe that I have the appropriate permissions to manually
specify reviewers for PRs in the cpython repository. Do I have to be added a
member of the Python organization on GitHub for this? I'm registered as a PSF
contributing member, but I
Kyle Stanley added the comment:
Thanks for the feedback terry. Do you think it would be helpful to work through
some of the other commonly used functions in OS, adding condensed explanations
of exceptions which can be raised? In general, it seems quite useful for users
to be able to figure
Kyle Stanley added the comment:
The latest PR-14655 moved the last file, "threaded_import_hangers.py" into the
"test_importlib" directory. As far as I can tell, there's nothing else which
needs to be moved there, so the
Change by Kyle Stanley :
--
assignee: -> docs@python
components: +Documentation
nosy: +docs@python
type: -> enhancement
versions: +Python 3.7, Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/i
Kyle Stanley added the comment:
Thanks for the suggestion.
Personally I wouldn't be in favor of this particular change. It doesn't add any
additional functionality beyond saving a couple of characters. Also, this could
quickly get rather convoluted. For separation and clarity
New submission from Kyle Stanley :
Currently in the documentation for print()
(https://docs.python.org/3/library/functions.html#print), the phrasing for the
flush argument is:
Whether output is buffered is usually determined by file, but if the flush
keyword argument is true, the stream
Kyle Stanley added the comment:
> The JSON encoder for dictionaries preserves the order of the items in a
> dictionary
>From what I can tell, the JSON encoder does nothing to preserve the order of
>the keys. Although the default option is to not modify the existing
>dictio
Kyle Stanley added the comment:
>But we have precedent in this module and should maintain it.
In general, applying different rules to standard library modules and changing
private function naming conventions on a case-by-case basis creates rather
drastic inconsistency. There definit
Change by Kyle Stanley :
--
pull_requests: +14462
pull_request: https://github.com/python/cpython/pull/14655
___
Python tracker
<https://bugs.python.org/issue19
Kyle Stanley added the comment:
Typo: The PR in the above comment should be 14655, not 14642.
--
___
Python tracker
<https://bugs.python.org/issue19696>
___
___
Kyle Stanley added the comment:
Opened a new PR for moving "threaded_import_hangers" to "test_importlib/"
(PR-14642). This should be the final file in "tests/" to move into
"test_importlib/", so the issue can be closed if this PR is merged. I'll creat
Change by Kyle Stanley :
--
pull_requests: +14401
pull_request: https://github.com/python/cpython/pull/14582
___
Python tracker
<https://bugs.python.org/issue19
Kyle Stanley added the comment:
In order to avoid the merge conflicts, I'm going to move
test_threaded_imports.py and threaded_import_hangers.py in separate PRs. Here's
the PR for moving test_threaded_imports.py
https://github.com/python/cpython/pull/14582
Kyle Stanley added the comment:
Typo in previous comment: "test_threaded_imports.py" should be
"test_threaded_import.py".
--
___
Python tracker
<https://bug
Change by Kyle Stanley :
--
pull_requests: +14454
pull_request: https://github.com/python/cpython/pull/14642
___
Python tracker
<https://bugs.python.org/issue19
Kyle Stanley added the comment:
Thanks for reporting the issue. On PR-14593 I reviewed the changes with
interpreter screenshots showing the output of "pickle.loads(pickle.dumps(1,
protocol=pickle.HIGHEST_PROTOCOL), buffers=None)" in the latest version of
cpython maste
Kyle Stanley added the comment:
Created a new PR for moving the last two files "test_threaded_import.py" and
"threaded_import_hangers.py" to the directory "test_importlib".
(https://github.com/python/cpython/pull/14537)
There were some issues with aut
Kyle Stanley added the comment:
Oh okay thanks taleinat. I wasn't aware of the existence of the ideas mailing
list, I'll have to check that out next time.
--
___
Python tracker
<https://bugs.python.org/issue37
Kyle Stanley added the comment:
Minor clarifications:
This change is referring to the "Files and Directories" section of the "os.rst"
page in "cpython/Doc/library/os.rst".
Also, I realized that I forgot to add the colon before "exc" in a couple
loca
Change by Kyle Stanley :
--
pull_requests: +14350
pull_request: https://github.com/python/cpython/pull/14537
___
Python tracker
<https://bugs.python.org/issue19
New submission from Kyle Stanley :
In the section describing the functionality of os.chdir(), there is no mention
of possible errors that can be raised. This differentiates significantly from
the sections of other methods, such as os.is_dir():
"This method can raise :exc:`OS
Kyle Stanley added the comment:
> This is already backported to 3.6. I am not sure about what gets backported
> to 3.5 right now, I don't even see a 'Backport to 3.5' label on Github (which
> made me think we are discouraged to backport to 3.5). I can work on a manual
> backpo
New submission from Kyle Stanley :
Last month, several tests were moved into test_importlib
(https://bugs.python.org/issue19696): "test_pkg_import.py",
"test_threaded_import.py", and "threaded_import_hangers.py".
Those tests were created quite a while ago thoug
Change by Kyle Stanley :
--
nosy: +eric.snow, ncoghlan
___
Python tracker
<https://bugs.python.org/issue37890>
___
___
Python-bugs-list mailing list
Unsubscribe:
Kyle Stanley added the comment:
I'm not entirely certain as to which parts should be modernized, and which ones
can remain the same. A large part of my uncertainty is that there are no header
comments for "test_pkg_import.py" to explain the test coverage, so I
Change by Kyle Stanley :
--
stage: -> needs patch
type: -> enhancement
___
Python tracker
<https://bugs.python.org/issue37890>
___
___
Python-bugs-list
Kyle Stanley added the comment:
> A key question here is why are you trying to avoid the AttributeError case so
> much?
> but there's a reason that we don't have attribute existence tests before
> every single attribute access throughout the test suite
Hmm, good point. I m
Kyle Stanley added the comment:
> This might be a decent way to prevent the AttributeErrors, but still allows
> for differentiation of actual None values
Another alternative solution might be to use hasattr() before getattr(), if it
is not desirable for test_pkg_import.py to
Kyle Stanley added the comment:
Ah okay, I wasn't sure what exactly would be involved with the "modernization"
process, so those points were just rough ideas more than anything. I haven't
started working on anything yet since I figured it'd be worthwhile to wait for
approval f
Change by Kyle Stanley :
--
keywords: +needs review -patch
___
Python tracker
<https://bugs.python.org/issue34679>
___
___
Python-bugs-list mailing list
Unsub
Kyle Stanley added the comment:
> How do we identify whether or not set_wakeup_fd() is being called from a
> non-main thread?
Never mind, I think I found the answer to my own question and tested a patch
locally, I'll open a PR.
--
___
Change by Kyle Stanley :
--
keywords: +patch
pull_requests: +15163
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15477
___
Python tracker
<https://bugs.python.org/issu
Kyle Stanley added the comment:
> Skipping this call for non-main thread in proactor implementation makes sense.
How do we identify whether or not set_wakeup_fd() is being called from a
non-main thread?
--
nosy: +aeros167
___
Python trac
Kyle Stanley added the comment:
> May I suggest directing your efforts towards fixing known bugs or
> implementing requested features. It isn't our goal to create more work for
> one another
There frequently is value in improving code readability, as it can improve
mainta
Kyle Stanley added the comment:
Thanks for the explanation.
> Of course, you might argue that _once Python has NotImplemented_, it can be
> used elsewhere - but as I said, I don't think it should be encouraged.
Hmm, okay. My understanding of Raymond's explanation was more so
Kyle Stanley added the comment:
> Kyle, thanks for the fix.
> I have basically the same change in my PR but with test and news note.
No problem, that works for me. I was mostly just trying to help with resolving
some of the release blockers for
Change by Kyle Stanley :
--
nosy: +mark.dickinson, meador.inge
___
Python tracker
<https://bugs.python.org/issue23933>
___
___
Python-bugs-list mailing list
Unsub
Kyle Stanley added the comment:
> Would it be viable to rephrase the existing section in a manner that explains
> the functional purpose of NotImplemented without revolving around its use
> case in binary special methods?
To expand further upon this, here's an initial idea for
Kyle Stanley added the comment:
Thanks for the feedback Vedran and Raymond.
> It is not the purpose of the docs to list use cases. Mostly we say what
> something does or how it is defined. As Vedran says, how people use it is
> their own business.
The underlying issue h
Change by Kyle Stanley :
--
stage: resolved -> patch review
___
Python tracker
<https://bugs.python.org/issue37585>
___
___
Python-bugs-list mailing list
Un
New submission from Kyle Stanley :
In the documentation for the NotImplemented constant
(https://docs.python.org/3/library/constants.html#NotImplemented), the only use
case mentioned is for binary special methods, (such as object.__eq__(other)).
However, based on a conversation in a recent
Kyle Stanley added the comment:
> I would just read through the other tests files under test_importlib to see
> how other tests were done.
Okay, I'll start with that and report back with any ideas for potential changes
to test_pkg_import.
Kyle Stanley added the comment:
Reopening the issue for adding the documentation clarification, that comparing
the values view of two dictionaries will always return false (as was suggested
in the ML discussion
https://mail.python.org/archives/list/python-...@python.org/message
Kyle Stanley added the comment:
> python-dev likely isn't the right place. That is a forum for more mature
> ideas.
Agreed, that idea should be posted to python-list if they're having issues
posting to python-ideas. Python-dev certainly wouldn't be appro
Change by Kyle Stanley :
--
type: -> enhancement
___
Python tracker
<https://bugs.python.org/issue37812>
___
___
Python-bugs-list mailing list
Unsubscrib
Kyle Stanley added the comment:
> Any plan to reapply my change, or fix it?
I can try to help with this. I'm not the most familiar with the internals of
asyncio, but I think it would provide a good learning experience.
--
nosy: +aeros
Kyle Stanley added the comment:
I've opened PR-15735 which applies the same functionality as Victor's PR-13786,
but adds the public getter and setter methods (for both AbstractEventLoop and
BaseEventLoop) as requested by Andrew.
Since this is still causing intermittent CI failures from
Kyle Stanley added the comment:
> FWIW, I've confirmed again that the exact same script on the same machine
> seems fine under Python 3.x. Given the imminent demise of Python 2, perhaps
> this issue is just destined to be an unsolved historical oddity.
Since it doesn't seem to be
Kyle Stanley added the comment:
Created GH-16147 for replacing the *from_what* argument with *whence* in the IO
tutorial.
I would like to consider following up on this with another PR that adds the IO
constants `SEEK_SET`, `SEEK_CUR`, and `SEEK_END` to the tutorial. Those
constants would
Kyle Stanley added the comment:
> Thanks you Kyle!
No problem, thanks for merging it Antoine!
What do you think of the followup PR to make use of the SEEK_* constants listed
in the documentation? I think it would be useful to at least mention them in
the tutorial, or even make use of t
Change by Kyle Stanley :
--
keywords: +patch
pull_requests: +15757
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16147
___
Python tracker
<https://bugs.python.org/issu
Kyle Stanley added the comment:
Upon further consideration, I don't think this will address the issue. If the
RuntimeError was not being raised, this failure would be consistent rather than
intermittent.
I think I have have gotten a bit mixed up, even if the return value of
PyErr_Format
Change by Kyle Stanley :
--
pull_requests: +15390
pull_request: https://github.com/python/cpython/pull/15735
___
Python tracker
<https://bugs.python.org/issue34
Kyle Stanley added the comment:
Note that I'm not particularly experienced with the c-api, I'm just trying to
take a stab at understanding why the buildbot failure is occuring.
--
___
Python tracker
<https://bugs.python.org/issue37
Kyle Stanley added the comment:
I believe I found a potential fix, see
https://bugs.python.org/issue37224?@ok_message=msg%20352516%20created%0Aissue%2037224%20message_count%2C%20messages%20edited%20ok&@template=item#msg352514.
Should I attach the PR to that issue or this
Kyle Stanley added the comment:
Upon digging through Modules/_xxsubinterpretersmodule.c, I noticed that on line
2059, `PyInterpreterState_Delete(interp);` is commented out
(https://github.com/python/cpython/blob/bf169915ecdd42329726104278eb723a7dda2736/Modules/_xxsubinterpretersmodule.c
Kyle Stanley added the comment:
Clarification: In the above comment when I was referring to the commit made by
Eric Snow, I meant to link to
https://github.com/python/cpython/commit/7f8bfc9b9a8381ddb768421b5dd5cbd970266190.
--
___
Python tracker
Kyle Stanley added the comment:
Upon further reading of the documentation and some experimentation, it would
definitely not make sense to call `PyInterpreterState_Delete` here (since we're
only closing the sub-interpreter in the current thread), so that's not the
issue. I still have no idea
Kyle Stanley added the comment:
Clarification:
"If I'm not mistaken doesn't mean that the `return -1` within ..."
Should instead be:
"If I'm not mistaken doesn't this mean that the `return -1` within ..."
(I am really looking forward to moving issue over to GitHub at so
Kyle Stanley added the comment:
Ronald, is it feasible that the changes made in
https://github.com/python/cpython/pull/14748/files to THREAD_STACK_SIZE in
Python/thread_pthread.h could be causing intermittent failures for the Azure
macOS PR tests?
In a recent PR (https://github.com/python
Kyle Stanley added the comment:
> As you say, we currently have only one usage of NotImplemented outside its
> intended purpose. Maybe we should wait to see whether it becomes at least a
> little bit more popular, before thinking about blessing it.
> I know at least 3 in CPyt
Kyle Stanley added the comment:
It looks like the Azure macOS tests timed out again in the recently opened
PR-15688. Specifically, for test_multiprocessing_spawn and test_functools (both
of which also timed out in PR-15651, which Victor mentioned earlier):
0:26:41 load avg: 2.89 [418/419/1
Kyle Stanley added the comment:
> I have not yet thoroughly tested it though, and would like some feedback on
> it.
I performed some testing on Linux and it looks good as far as I can tell. I
added a few minor suggestions, but the auto-complete seems to be functioning as
d
Kyle Stanley added the comment:
> gpolo should be removed or marked inactive as he has not responded in several
> years.
Oh okay, good to know. I'm currently working on an issue to add github
usernames to the experts list, so I'll see if I can mark him as inactive as
well.
> Are
New submission from Kyle Stanley :
In the most recent development version of Python 3.9, when opening the file
selection menu through File > Open (or Ctrl-o) in the IDLE, the file names are
hidden. Clicking once on each of the icons or the areas in front of them can
make the names visi
Change by Kyle Stanley :
--
assignee: -> terry.reedy
components: +IDLE
nosy: +taleinat, terry.reedy
___
Python tracker
<https://bugs.python.org/issu
Kyle Stanley added the comment:
After PR-14958 was merged, I tested the latest development version of CPython
on Arch Linux 5.2.3 and I can confirm that the "Settings" window no longer
scales past the edge of the screen. Instead, the window size remains fixed and
the scroll area d
Kyle Stanley added the comment:
> Serhiy: Is there a reason not to use the functools.total_ordering decorator
> on TimerHandle, so you can get rid of __le__/__ge__/__gt__ rather than fixing
> them
> individually?
I strongly agree with this suggestion, unless there's some uni
Kyle Stanley added the comment:
Was unable to attach both files to the first comment, here's the second one of
the "Open" menu after clicking a few icons.
--
Added file: https://bugs.python.org/file48510/bpo-idle-open-menu-1.png
___
Pyth
Kyle Stanley added the comment:
Since the names are still there in the screenshots but slightly grayed out, it
may have to do with my local font settings. If so, an easy solution to this
would be using an override for the IDLE instead of relying the local themes. I
can't what practical
Kyle Stanley added the comment:
Corrections:
"I can't what practical" => "I can't imagine what practical..."
(PS: Definitely looking forward to the full move from bpo to github. Being able
to copy-paste temporary image files and edit comme
Kyle Stanley added the comment:
Correction: By "scroll the list of fonts" I meant that I went through all of
them by holding the down arrow from the top of the list (Adobe Courier - Z003),
scrolling through the list wouldn't accomplish anything. I did that starting
with a fo
Kyle Stanley added the comment:
> What is a 'DE'?
DE stands for Desktop Environment, usually they come with a number of packages
(mainly GUI) such as window managers, login managers, toolbars, theming, etc.
Some of the popular ones include Gnome, Plasma, Mate and LXDE. Usually anyth
Change by Kyle Stanley :
--
nosy: +gpolo
title: IDLE/Tkinter: File names are hidden in "Open" menu (Linux) -> Tkinter:
File names are hidden in "Open" menu (Linux)
___
Python tracker
<https://
Kyle Stanley added the comment:
>The named versions are just alternatives available for end-users
While it is true that the usage of 0,1,2 is more commonly used across the
repository, the constants are used several times across Lib/_compression.py and
Lib/_pyio.py. From my perspect
Kyle Stanley added the comment:
>Thus, if a user gives an OrderedDict (or a dict with a known order, in Python
>3.7+), it is useful that >he know that the order of its elements will not be
>changed upon transformation into JSON.
I would agree that it could be helpful
Kyle Stanley added the comment:
> OrderedDict is not recommended to preserve order any more.
> Please forget about OrderedDict unless you need additional feature
> OrderedDict provides. It is far inefficient than regular dict.
Thanks for the clarification. Should this recom
New submission from Kyle Stanley :
In the docs for the module stdtypes, the code example for several commonly used
functions are in the bytearray section instead of the str section, where new
users are far more likely to look. The new users are much more likely to
benefit from seeing
Kyle Stanley added the comment:
Clarification on option 1: The last sentence should be "A link to the bytearray
equivalent..."
Clarification on option 2: As a part of this option, a link to the str
equivalent could optionally b
Kyle Stanley added the comment:
>In my opinion the current documentation is correctly formed since the
>bytearray and str are two different classes in Python they could have
>different set of functions supported and hence the grouping of functions like
>islower() to be ke
New submission from Kyle Stanley :
In Python 3.1, three constants were added to the IO module to be used for the
whence argument of seek():
SEEK_SET or 0 – start of the stream
SEEK_CUR or 1 – current stream position
SEEK_END or 2 – end of the stream
However, there are at least 102
Change by Kyle Stanley :
--
assignee: -> docs@python
components: +Documentation, Tests
nosy: +docs@python
___
Python tracker
<https://bugs.python.org/issu
Kyle Stanley added the comment:
Added twouters to the nosy list since he's the makefile expert according to
https://devguide.python.org/experts/#miscellaneous.
--
nosy: +aeros167, twouters
___
Python tracker
<https://bugs.python.org/issue37
Kyle Stanley added the comment:
After testing it on Linux (through the latest dev version, launched with
`./.python -m idlelib`), the line numbers seem to be working quite well across
several different fonts and font sizes. My only suggestion for minor visual
improvement would
Kyle Stanley added the comment:
Clarification: Since I posted two potential suggestions, I'm referring to the
one using the interpreter, not the one that changed it into two lines and added
indentation.
--
___
Python tracker
<ht
Kyle Stanley added the comment:
Raymond, what were your thoughts on the alternative suggestion I posted on the
GitHub PR? My suggestion might have been too different from the original PR,
but personally I think it's a bit more appropriate for the tutorial than the
existing example. Would
Kyle Stanley added the comment:
Upon further consideration, I think that it would be best to leave the code
examples as is in the "inputoutput" tutorial, but it still be worth mentioning
that the constants exist as alternatives. This is due to adding the additional
step of
Kyle Stanley added the comment:
Based on the current status of the discussion in python-dev, the most agreed
upon solution so far seems to be updating the documentation to mention this
behavior, rather than modifying the existing behavior. I opened a PR which
updates the documentation
Change by Kyle Stanley :
--
pull_requests: +14723
pull_request: https://github.com/python/cpython/pull/14954
___
Python tracker
<https://bugs.python.org/issue37
Kyle Stanley added the comment:
Added Brett to the nosy list since he was the one who suggested a documentation
change.
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue37
Kyle Stanley added the comment:
> Please keep focused on the OP's thought that the JSON docs should explicitly
> promised that
> key/value pairs are added in the order that they are encountered. The
> existing JSON docs imply
> this pretty strongly, but it can be made more exp
Kyle Stanley added the comment:
> I would agree with changing the tutorial. The rest doesn't need to be
> changed.
Fair enough, that's understandable. I'll look into creating a PR for the
tutorial to attach to this issue. Thanks for the feedback Antoine and Raymond.
Kyle Stanley added the comment:
Upon further consideration, I think the code example suggestion I made using
the interpreter could be in a separate PR or issue and doesn't have to replace
the the current "Equivalent to ..." portion. I'll open a separate PR for that
(which isn'
Kyle Stanley added the comment:
Clarification: By "latest commit" should be "oldest commit" with regards to the
oldest commit in GitHub's history of the section of the "inputouput" tutorial
that used the
Kyle Stanley added the comment:
> I don't know. "whence" is the official name of the argument in the POSIX API
> Perhaps "from_what" is assumed to be more understandable by the average
> reader?
>From looking at the blame on GitHub, it looks like the u
Kyle Stanley added the comment:
> You can find my email in Git, and I'm on Zulip and Discourse; and I'd be
> happy to start or follow a thread in a forum you think appropriate. Or if
> you'd rather drop it entirely, that's fine too.
I think opening a thread in https://discuss.pyt
Kyle Stanley added the comment:
> I'm one of the first to advocate to replace ugly macros with clean static
> inline functions. Macros are evil and can be too easily misused.
As someone who has only more recently started learning the C-API (and C in
general), I'm certainly in
Kyle Stanley added the comment:
> Thanks, Kyle!
No problem, and thanks for all of the help from Andrew, Yury, and Victor!
> IMHO it will make asyncio more reliable, especially for tests on the CI.
Awesome, that was my primary intention. (:
> If it becomes an issue in Python 3.9
Kyle Stanley added the comment:
Is there a currently reliable way of accessing the GIL functions within the
sub-interpreters, without causing deadlock issues? I was trying to follow the
advice in the documentation
(https://docs.python.org/3/c-api/init.html?highlight=global%20interpreter
1 - 100 of 416 matches
Mail list logo
