Larry Hastings added the comment:
Confirmed.
--
assignee: -> larry
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue21629>
___
___
Changes by Larry Hastings :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Larry Hastings added the comment:
With this patch applied the test passes. (Patch is against 3.4 branch.) Look
good?
--
keywords: +patch
Added file: http://bugs.python.org/file35567/larry.bad.zipfile.1.diff
___
Python tracker
<h
Larry Hastings added the comment:
Roundup knows I'm the release manager for 3.4? It's well-informed! ;-)
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
ISTM that fixing this for 3.x (3? 4?) is worthwhile though. Or did somebody
already fix it in 3.x?
--
___
Python tracker
<http://bugs.python.org/issue15
Changes by Larry Hastings :
--
assignee: -> larry
___
Python tracker
<http://bugs.python.org/issue16490>
___
___
Python-bugs-list mailing list
Unsubscri
Larry Hastings added the comment:
I'm working on a solution for this--expect an announcement on c.l.p-d in, oh, a
week.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
http://mail.python.org/pipermail/python-dev/2012-December/122920.html
--
___
Python tracker
<http://bugs.python.org/issue16
New submission from Larry Hastings:
This bug tracker entry is to track adding "Argument Clinic" to CPython trunk.
Please see
http://mail.python.org/pipermail/python-dev/2012-December/122920.html for more
information.
--
assignee: larry
components: Interpreter Core
messag
Larry Hastings added the comment:
Sorry for the delay; this head cold is slowing me down. Here's the current
state of Argument Clinic as a patch for review. I look forward to your
comments!
--
Added file: http://bugs.python.org/file28248/larry.clinic.patch.
Larry Hastings added the comment:
Antoine, Stefan: There doesn't appear to be a bright line separating "this
should get a PEP" from "this doesn't need a PEP". That said, changes to the C
API for CPython don't seem to merit PEPs very often, the recent "
Larry Hastings added the comment:
I disagree that the Clinic DSL is "verbose". Certainly I find it
more succinct than what we do now.
On the other hand, the syntax you proposed in the python-dev message
you cite is insufficient to the task. Consider a function that
takes a &quo
Larry Hastings added the comment:
What lines end with a colon?
--
___
Python tracker
<http://bugs.python.org/issue16612>
___
___
Python-bugs-list mailin
Larry Hastings added the comment:
Ah. In that case, may I rewrite your critique as
"[...] some lines may end with a semicolon, some lines may not, some assignment
signs ("=") permit spaces around them, some don't."
The semicolon is optional, permitted explicitly so y
Larry Hastings added the comment:
I don't think we can solve the problem of the output being too long for your
liking. Personally I like the output; I find it eminently readable, and making
it shorter would impair that. I think in the majority of uses Clinic will be a
win for readab
Larry Hastings added the comment:
I have no current plan to write a PEP. I don't know how to settle the
difference of opinion here; the easiest thing would be if you convinced Guido
we needed one.
--
___
Python tracker
<http://bugs.py
Larry Hastings added the comment:
I'm a little confused. FindFirstFile is an ANSI API, so we get a narrow string
back. We call PyBytes_FromString(), which expects a narrow string and returns
a bytes object. Who's trying (and failing) to encode th
New submission from Larry Hastings:
The line declaring the function dbm.open looks like this:
def open(file, flag='r', mode=0o666):
The docstring for dbm.open looks like this:
open(file, flag='r', mode=438)
Obviously 438==0o666. But the author used the octal re
Larry Hastings added the comment:
(I was also considering proposing using annotations to tell the parser we want
the original representation in the docstring, but I suspect that's a bad idea.
That would instantly restrict the untamed frontier that is annota
Larry Hastings added the comment:
Okay, counter-proposal time. We add a new field to the Parameter object, the
preferred string representation of the default. If the parameter has a
default, it is always a string, by default repr(parameter_default_value); if
the parameter has no default
Larry Hastings added the comment:
Georg: what other functions do you know of where (as you suggest) the signature
could be improved?
--
___
Python tracker
<http://bugs.python.org/issue16
Larry Hastings added the comment:
My spies are everywhere! You cannot hide your black heart, Pitrou.
--
___
Python tracker
<http://bugs.python.org/issue16
New submission from Larry Hastings:
Python 3.3 added a nice new feature: if you don't supply enough positional
parameters to a function, it tells you the names of the positional parameters
you omitted.
Unfortunately, the code that prints this error message assumes that the
function is
Changes by Larry Hastings :
--
keywords: +patch
Added file:
http://bugs.python.org/file29044/lch.bandaid.for.malformed.fn.crash.1.patch
___
Python tracker
<http://bugs.python.org/issue17
Larry Hastings added the comment:
It sort of looks like this was closed because we assumed we were moving to
Unladen Swallow. We're not. Should this be reopened?
--
nosy: +larry
___
Python tracker
<http://bugs.python.org/i
New submission from Larry Hastings:
The implementations for LOAD_FAST, STORE_FAST, and DELETE_FAST don't check that
the index is <= the size of fastlocals. So it's a snap to crash the
interpreter with hand-written bytecode, by going past the end of the fastlocals
array. Kaboom!
Larry Hastings added the comment:
I'm not surprised it was discussed to death long ago. And I can get behind
wontfix. But let me just say that
a) I think an uncrashable Python interpreter is a laudable goal, and steps we
can take towards that should not be dismissed out of hand.
b) I
New submission from Larry Hastings:
Can you fix this before I tag 3.4a3 please?
--
assignee: pitrou
components: Build
keywords: buildbot
messages: 198466
nosy: larry, pitrou
priority: high
severity: normal
stage: needs patch
status: open
title: "make touch" broke "x86 Ub
Larry Hastings added the comment:
Sorry, here:
http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.x
--
___
Python tracker
<http://bugs.python.org/issue19
New submission from Larry Hastings:
The Win32 buildbots just started failing:
http://buildbot.python.org/all/waterfall?category=3.x.stable
They fail with this traceback:
test test_logging crashed -- Traceback (most recent call last):
File "../lib/test/regrtest.py", lin
New submission from Larry Hastings:
In r_string() (read a string) in marshal.c we see this comment:
/* The result fits into int because it must be <=n. */
read = fread(p->buf, 1, n, p->fp);
This comment was first committed in r36501 by MvL. Back then the "read" and
Larry Hastings added the comment:
Martin: The code is not statically type-safe, but it is mechanically safe,
which I think is why you wrote the comment in the first place.
The return value of fread() is size_t, but the "read" variable is Py_ssize_t.
So the function *could* the
Larry Hastings added the comment:
Does it break anything? (Besides, possibly, itself?)
--
___
Python tracker
<http://bugs.python.org/issue19262>
___
___
Pytho
Larry Hastings added the comment:
If its breakage is restricted to itself (and its tests) then you have my
blessing to check it in. (Sorry, can't help you with the test expertise.)
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Attached is a patch against current trunk merging Argument Clinic. I already
got the go-ahead to merge (took a poll in python-dev, got lots of +1s), but I
still wanted to post it here to let it soak a little, even only if it's just a
day. Unless some
Larry Hastings added the comment:
Spelling corrections from Arfrever (thanks Arfrever!), and some eentsy teensy
weentsy bugfixes from me. And with a dramatic new patch number just so
everybody can keep it straight.
--
title: Integrate "Argument Clinic" specialized pr
Larry Hastings added the comment:
Incorporated suggestions from Antoine and Berker Peksag. Thanks!
--
Added file: http://bugs.python.org/file32205/larry.clinic.patch.6.diff
___
Python tracker
<http://bugs.python.org/issue16
Larry Hastings added the comment:
I played with that at one point. Guido suggested it was a bad idea.
If you redirect stuff into a second file then you have way more points
of failure--the files could get out sync, for example. I tend to agree.
We could, however, change Clinic so it generated
Larry Hastings added the comment:
Incorporated a small change from Antoine and a ton of small changes
from Serhiy. Thanks guys!
--
Added file: http://bugs.python.org/file32212/larry.clinic.patch.7.diff
___
Python tracker
<http://bugs.python.
Larry Hastings added the comment:
So, this is fixed, but there's some suspicion of a memory leak?
If that's true, maybe we could mark this as closed then open a new
bug for the leak? This shows up as a big scary "release blocker"
against 3.4, and I'm like
Larry Hastings added the comment:
I can't follow all this. Is this considered fixed in 3.4 or not?
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Ping. Can we get this fixed before beta 1?
--
___
Python tracker
<http://bugs.python.org/issue16043>
___
___
Python-bugs-list m
Larry Hastings added the comment:
Ping. Please fix before "beta 1".
--
___
Python tracker
<http://bugs.python.org/issue16039>
___
___
Python-bugs-l
Larry Hastings added the comment:
Can we get this fixed in more recent versions? Like, maybe, trunk, before
"beta 1"?
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
Ping. Please fix before "beta 1".
--
___
Python tracker
<http://bugs.python.org/issue16040>
___
___
Python-bugs-l
Larry Hastings added the comment:
Ping. Please fix before "beta 1".
--
___
Python tracker
<http://bugs.python.org/issue16041>
___
___
Python-bugs-l
Larry Hastings added the comment:
Ping. Please fix before "beta 1".
--
___
Python tracker
<http://bugs.python.org/issue16037>
___
___
Python-bugs-l
Larry Hastings added the comment:
Ping. Please fix before "beta 1".
--
___
Python tracker
<http://bugs.python.org/issue16038>
___
___
Python-bugs-l
Larry Hastings added the comment:
Victor, are you going to write a patch for this before beta 1?
--
___
Python tracker
<http://bugs.python.org/issue18509>
___
___
Larry Hastings added the comment:
Ping. Please fix before "beta 1".
--
___
Python tracker
<http://bugs.python.org/issue19279>
___
___
Python-bugs-l
Larry Hastings added the comment:
It's a month before beta 1. This weekend is alpha 4; it'd be nice if it were
fixed for that, of course, but that does not seem likely.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
Checked in. Thanks everybody!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Larry Hastings added the comment:
Mr. D'Aprano emailed me about getting this in for alpha 4. Since nobody else
stepped up, I volunteered to check it in for him. There were some minor ReST
errors in statistics.rst but I fixed 'em.
--
no
Changes by Larry Hastings :
--
nosy: +larry
___
Python tracker
<http://bugs.python.org/issue18235>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
Checked in. Thanks, Mr. D'Aprano!
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.pyth
Larry Hastings added the comment:
There's also a test that hangs for 1 hour on the Ubuntu x86 buildbot.
Sample failure:
http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.x/builds/8803/
--
nosy: +larry
___
Python tracker
Changes by Larry Hastings :
--
nosy: -larry
___
Python tracker
<http://bugs.python.org/issue17123>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Larry Hastings:
Somebody needs to figure out how to best integrate Argument Clinic into the
build. Antoine, I think you said it sounded like... "fun"? Maybe? Anyway,
I'm hoping you're willing to take a stab at it. If not please assign the issue
Larry Hastings added the comment:
Drat!
--
___
Python tracker
<http://bugs.python.org/issue19358>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Larry Hastings :
--
nosy: -larry
___
Python tracker
<http://bugs.python.org/issue16113>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
Victor: a "new feature" is not a "release blocker".
--
priority: release blocker -> normal
___
Python tracker
<http://
Larry Hastings added the comment:
"release blocker" means "the release cannot go out until this issue is solved".
Adding SHA-3, while nice, is simply not something I am going to hold up 3.4
for, full stop.
Please stop marking this issue a
Changes by Larry Hastings :
--
nosy: -larry
___
Python tracker
<http://bugs.python.org/issue16113>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
You guys are making me cranky. Please stop adding me to this issue.
--
___
Python tracker
<http://bugs.python.org/issue16
Larry Hastings added the comment:
*sigh* fine. But the title of the issue is no longer accurate.
And, Christian, I generate the 3.4 maintenance branch during the release
process, not before. So if you have to remove sha3 you're going to have to
remove it from
Larry Hastings added the comment:
I thought it'd be more like, write a special C program that probes to see if
you have a built python in the current directory, and if not looks on the path
for a python3 (>=3.3), and if it finds a python it can use it runs Clinic on
its arguments. T
Larry Hastings added the comment:
> Well, why is clinic 3.3 only? It would be slightly easier
> if it accepted any "python3" executable.
Patches welcome! I have bigger fish to fry.
--
___
Python tracker
<http://bugs.py
Larry Hastings added the comment:
For a long time it was actually 3.4+ only. I was depending on a particular AST
node that wasn't exposed to Python until 3.4 trunk. But that went away, and I
tried it with 3.3 and it worked fine, so I labeled it 3.3+. For all I know it
works fine unde
Larry Hastings added the comment:
You're proposing that Clinic allow => ?
--
___
Python tracker
<http://bugs.python.org/issue19390>
___
___
Python-bugs-lis
Larry Hastings added the comment:
Fixed.
And, yeah, Clinic actually uses ast.parse where it can. (FWIW, most of the
parser was re-written by Dmitry Jemerov during the PyCon US 2013 sprints,
though I wound up re-re-writing most of what he did.)
--
assignee: -> larry
resolut
Larry Hastings added the comment:
Would this be a good time for me to ask about publishing the stack effect info?
I had to write my own parallel implementation of it for my assembler, so I
found it irritating that Python doesn't provi
Larry Hastings added the comment:
A week before beta? How confident are you in this new parser?
--
nosy: +larry
___
Python tracker
<http://bugs.python.org/issue19
New submission from Larry Hastings:
If you run Lib/test/test_userdict.py enough times, sooner or later it'll
produce a spurious error. I wrote a shell script that ran "./python -m test
test_userdict" a zillion times; here's a snippet of output from running that
script:
[
Larry Hastings added the comment:
Sigh. If dataflow analysis could inline the static _impl function, it would
notice that there are no code paths where the variable is uninitialized and
gets used. But I'm not surprised compilers aren't that sophisticated.
So I beat the problem to
Larry Hastings added the comment:
I don't know for sure--I haven't stepped through it--but here's an informed
guess. It relies on key collision.
The first dict is created the normal way. It contains two values, "one" (set
to 1) and "two" (set to 2), inser
New submission from Larry Hastings:
Let's see if we can get introspection information for builtins using the Clinic
for 3.4.
Georg suggested part of the approach while we were hanging out in Tokyo. I'd
considered it previously before but dispensed with the idea because it seemed
Larry Hastings added the comment:
If you review, you can ignore the changes to the .c files, those only got
touched because of the new autogenerated "def (" lines in the docstrings. No
other changes there.
--
___
Python trac
Larry Hastings added the comment:
(Well, except for Object/methodobject.c.)
--
___
Python tracker
<http://bugs.python.org/issue19674>
___
___
Python-bugs-list m
Changes by Larry Hastings :
--
nosy: +ncoghlan
___
Python tracker
<http://bugs.python.org/issue19674>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
I was deliberately trying to avoid something that a person might do by
accident. Also, "def (" is consistently only five bytes, whereas "pterodactyl
(" or whatever will often be much longer, in case static data size is a concern.
But
Changes by Larry Hastings :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue19674>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
I changed it to "(". Patch attached. Still works.
--
Added file:
http://bugs.python.org/file32763/larry.introspection.for.builtins.patch.2.txt
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
Anybody have a better name for __textsig__ ?
--
___
Python tracker
<http://bugs.python.org/issue19674>
___
___
Python-bugs-list m
New submission from Larry Hastings:
Attached is a patch exposing the old opcode_stack_effect() function to Python.
The patch does the following:
* renames opcode_stack_effect() to PyCompile_OpcodeStackEffect()
* removes the "static" modifier from PyCompile_OpcodeStackEffect()
Larry Hastings added the comment:
(Sponging around for a reviewer ;-)
--
___
Python tracker
<http://bugs.python.org/issue19722>
___
___
Python-bugs-list mailin
Changes by Larry Hastings :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue19722>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
New patch, incorporating Antoine's comments. Thanks, Antoine!
--
Added file:
http://bugs.python.org/file32782/larry.expose.stack.effect.patch.2.diff
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
You find the big
/*[clinic checksum: b6ded2204fd0aab263564feb5aae6bac840b5b94]*/
marker insufficient?
Perhaps this is simply something we will quickly get used to. How about we let
this sit for a while and see what other people think.
p.s. I accept your
Larry Hastings added the comment:
I quite agree. My plan is to write a quick HOWTO for now to get
people up and running for now, then flesh it out into a full document.
But I'm working like crazy right now to get a couple things done
before
Larry Hastings added the comment:
> However, to bikeshed a little, I would prefer
> "preprocessor" instead of "clinic", since jokes
> tend to wear off if one sees then too often.
"Argument Clinic" is the name of the tool. The marker /*[clinic]*/
was
Larry Hastings added the comment:
I went with __text_signature__. I also did some more polishing, and added /
fixed the unit tests, and even added a Misc/NEWS. Is it good enough to go in
before the beta?
--
Added file:
http://bugs.python.org/file32785
Larry Hastings added the comment:
Attached is a patch to at least add a "make clinic" target for the UNIX-like
platforms. This doesn't add anything for the Windows build.
--
keywords: +patch
stage: -> patch review
Added file: http://bugs.python.org/file32786/larry.m
Larry Hastings added the comment:
Okay, there's more than one way to skin this cat. This version uses os.walk().
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
(Whoops, forgot to attach the new diff.)
--
Added file: http://bugs.python.org/file32788/larry.make.clinic.patch.2.diff
___
Python tracker
<http://bugs.python.org/issue19
Larry Hastings added the comment:
stack_effect will never know about EXTENDED_ARG. Instead, you simply pass the
already-extended arg as the second argument.
Making the second argument support a default of None will be slightly
inconvenient, but I'll do it if you think it's a big i
New submission from Larry Hastings:
Two minor changes for Argument Clinic.
* Added a "version" directive, so a programmer can require a
specific version (or better) of Clinic.
* Finished off support for all the 'legacy' converters. The ones today
were those tha
Larry Hastings added the comment:
Are you sure the problem is fixed? I still see the same error on the same
buildbot.
http://buildbot.python.org/all/builders/AMD64%20Ubuntu%20LTS%203.x/builds/3168/steps/test/logs/stdio
--
___
Python tracker
<h
Larry Hastings added the comment:
Attached is revision 3 of the patch. I'm gonna check it in pretty soon, so as
to make beta (and feature freeze). I changed the API so the oparg is optional,
and it raises if it gets one it shouldn't have or didn't get one when it should.
-
Larry Hastings added the comment:
Attached is a fresh patch. I added a third new feature: the "self converter",
which allows you to change the type of (or rename) self. For an example of its
use, check out dbm.dbm.get in Modules/_dbmmodule.c.
--
title: Clinic fixes: add
Larry Hastings added the comment:
Fresh patch attached. pydoc now uses inspect.signature instead of
inspect.getfullargspec to generate the arguments for the function, and supports
builtins. That's everything :D
Planning on checking this in pretty soon, to get it in for beta (
901 - 1000 of 2389 matches
Mail list logo
