Louie Lu added the comment:
test_query were fixed in PR 2147, which is leak by not removing mock.Mock() in
dialog.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +2197
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30642>
___
__
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +2178
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30632>
___
__
New submission from Louie Lu:
Add unittest to test_open_completions, test_fetch_copmletions, and
test_get_entity in test_autocomplete
--
assignee: terry.reedy
components: IDLE
messages: 295755
nosy: louielu, terry.reedy
priority: normal
severity: normal
status: open
title: IDLE: add
Louie Lu added the comment:
Briefly speaking, I think this is not a *easy* issue. There is two things need
to concern in this issue.
First, it that the test case is *randomize*, lineno 282 randomly choice 10 file
to test. So you will need to stabilize this first.
Second, the minimize range
Louie Lu added the comment:
I agree with what you says that the prefix of ":" and "@" may confuse beginners
when using "goto line" function.
I survey some editor, that visual studio and sublime use this kind of navigate
bar, but visual studio will show up
Louie Lu added the comment:
Mariatta: yes, louisom is my GitHub account. but I migrate to mlouielu this new
account. Should I add louisom to b.p.o GitHub account list?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Louie Lu added the comment:
Without this segfault, I think you do a wrong operation. In other cases, for
example:
>>> issubclass(10, int)
Traceback (most recent call last):
File "", line 1, in
TypeError: issubclass() arg 1 must be a class
`issubclass` will return Ty
Louie Lu added the comment:
I can reproduce this bugs on 3.7, Linux.
Python 3.7.0a0 (heads/master:d3bedf356a, Jun 5 2017, 10:21:52)
[GCC 6.3.1 20170306] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> c
Louie Lu added the comment:
Haypo: How do you know that this is leaked at test_files() of
test_tools.test_unparse.DirectoryTestCase? The result of your command didn't
reveal that is leaked at which test case or function.
--
nosy: +louielu
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1960
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30521>
___
__
New submission from Louie Lu:
Propose a sublime-like navigate bar to replace current goto dialog.
Navigate bar current support two different mode: prefix ':' for goto line, and
prefix '@' for goto symbol.
When user use shortcut Ctrl+G to open goto line, it will prompt out a navigate
bar
Louie Lu added the comment:
Terry, on the original issue about goto dialog, I would like to propose another
approach, instead of using query.Query or simpledialog, how about to make it as
a single-window application like sublime text:
http://docs.sublimetext.info/en/latest/file_management
Louie Lu added the comment:
Ok, changed to query.Query will be good. But the problem still exist,
query.Query use "" to bind at button ok, should it re-bind to
"" at subclass such as AskInteger(Query) ?
--
versions: +Py
Louie Lu added the comment:
I fix this as:
if not self.autocompletewindow:
return
I think this another different behavior on different platform. I can't
reproduce this on Linux...
--
___
Python tracker <rep...@bugs.python.org>
Louie Lu added the comment:
Fix on Windows platform, the behavior was different on Linux and Windows when
calling acw.focus_get(), it will need to delay to get the correct focus.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.p
Louie Lu added the comment:
We can solve this problem by two ways.
One is to add set_line_and_column() to the end of goto_line_event(), but this
will make Return trigger set_line_and_column twice.
Another is to change the bind event in simpledialog from "" to
"" t
Louie Lu added the comment:
The patch is upload to PR 1821, if Roger get a GitHub account and linked to
b.p.o, we can rebase the first commit and change the author in commit message
to Roger's account information.
--
___
Python tracker <
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1907
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue14111>
___
__
Louie Lu added the comment:
Hi Huyk, which version of Python does the error message generated?
Also, could you try to provide a minimum reproduce python script and upload it?
it will be more easy to debug this problem if we can reproduce this.
--
nosy: +louielu
Louie Lu added the comment:
This bug is introduce at commit: 37e4ef7b17ce6e98ca725c0a53ae14c313c0e48c, then
fixed at commit: 998c20962ca3e2e693c1635efe76c0144dde76fc
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Louie Lu added the comment:
Another way to reproduce this problem:
>>> import datetime
>>> from collections import defaultdict as dd
>>> d = dd(datetime.datetime.now)
>>> d['foo']
Traceback (most recent call last):
File "", line 1, in
System
Louie Lu added the comment:
PR 1811 fix some bug in condition of hide_event, now it will work on three
different platforms. Terry, it will need your review.
--
versions: +Python 3.7
___
Python tracker <rep...@bugs.python.org>
<http://bugs.p
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1897
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue15786>
___
__
Louie Lu added the comment:
Roger, will you convert the patch to GitHub PR? The patch runs will, there are
only two point need to add:
1. user_interrupt should clear sys.settrace when step in
2. cancel_callback add a interp.write("\nKeyboardInterrupt\n"
Louie Lu added the comment:
Update roger's patch to current version.
Is there any reason this patch isn't merged? The problem in #26949 is a
separate issue about this problem.
--
Added file: http://bugs.python.org/file46893/0001-WIP.patch
Louie Lu added the comment:
The reproduce step can be reduce to:
1. open idlelib with debugger (./python -m idlelib -d)
2. enter print() (or any other function call)
3. Control-C breakout
Then it will restart the shell.
--
nosy: +louielu
___
Python
Louie Lu added the comment:
watch and awatch will detect value change and breakout, rwatch using dis module
to get the file bytecode, with the lineno it can detect current line is load
(read) or not.
--
___
Python tracker <rep...@bugs.python.
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1841
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30429>
___
__
Changes by Louie Lu <m...@louie.lu>:
--
type: -> enhancement
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30429>
___
___
New submission from Louie Lu:
Trying to add watchpoint function to bdb and pdb.
It's goal is to do as gdb for three different watch: watch, rwatch and a watch.
watch: when expr is written by program and value has changed, it will break
rwatch: when expr is read by program, it will break
awatch
Louie Lu added the comment:
Rebase markroseman patch to latest version, I own no credit on this patch.
Just want to check the effect about the patch.
--
Added file: http://bugs.python.org/file46884/0001-WIP.patch
___
Python tracker <
Louie Lu added the comment:
Mark, do you mind to rebase your patch to the latest version?
--
nosy: +louielu
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Louie Lu added the comment:
PR 1711 fix KeyboardInterrupt with adding rpc.repsonse_queue.put, but it will
not print out the exception traceback.
And for SystemExit, wait for discussion result.
--
___
Python tracker <rep...@bugs.python.org>
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1802
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26949>
___
__
Louie Lu added the comment:
The problem is cause by run.py:main function, when it catch KeyboardInterrupt
or SystemExit, it won't put a blank msg back to response_queue, that cause the
loop in run.py:main triggering except queue.Empty to continue the loop.
So, I think the KeyboardInterrupt
Louie Lu added the comment:
Terry: I see, I'll take some debugger stuff to try first.
Cheryl: If you got any problem on 4/5/6, feel free to ask me on IRC or here!
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Louie Lu added the comment:
Hi Robert, the submit flow has migrate to GitHub pull requests workflow, and it
is strongly preferred to used GitHub PR workflow, do you mind to convert your
patch to GitHub?
* GitHub repo: https://github.com/python/cpython
* devguide about PR: http://cpython
Louie Lu added the comment:
Cheryl: yes, I may work on 4a/4b and msg294004 on Monday, or do you start at
these tasks?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Louie Lu added the comment:
Roadmap definitely helps us for targeting what to do and clear the current
development status. Such as #27609 helps a lot for focus on improving on part
of the IDLE.
1. Should this be merged with the existing TODO.txt to ROADMAP.txt?
2. What does a "single w
Louie Lu added the comment:
Due to the merged of #30303, text_view now have _utest attribute for unittest,
upload the unittest of help_about dialog in PR 1697
--
nosy: +louielu
___
Python tracker <rep...@bugs.python.org>
<http://bugs.p
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1790
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30290>
___
__
Louie Lu added the comment:
terry, these close isn't changing anything. But I'm migrating my GitHub account
from old one to new one, thus will close the PR and reopen another one, sorry
for annoying mailing.
--
___
Python tracker <
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1739
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue23667>
___
__
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1738
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue23667>
___
__
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1737
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue23667>
___
__
Louie Lu added the comment:
PR 1602 add trailing whitespace highlight, which using color from error.
PR 1603 add TrimExtension to provide auto trim while saving the file.
--
nosy: +louielu
___
Python tracker <rep...@bugs.python.org>
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1694
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue23667>
___
__
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1693
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue23667>
___
__
Louie Lu added the comment:
This PR will add the short-key to F7, when using editor. It will prompt up a
dialog and user can input the command-line arguments then run the code.
--
nosy: +louielu
___
Python tracker <rep...@bugs.python.org>
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1682
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue28889>
___
__
Louie Lu added the comment:
Terry, the latest PR fix the problem both on Linux / MacOS and Windows, please
help to review and test if there is any problem on different platform, thanks!
--
___
Python tracker <rep...@bugs.python.org>
Louie Lu added the comment:
PR-1212 Add an explicit test for dispatch_return's assertion, could @benjaminp,
@tiran or @giampaolo help to review this? Thanks!
--
nosy: +benjamin.peterson, christian.heimes, giampaolo.rodola
___
Python tracker <
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1649
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30348>
___
__
New submission from Louie Lu:
Due to #21261, add relative unittest to test_autocomplete.py
--
assignee: terry.reedy
components: IDLE
messages: 293531
nosy: louielu, terry.reedy
priority: normal
severity: normal
status: open
title: IDLE: Add fetch completions and get entity unittest
type
Louie Lu added the comment:
Additional info for Windows platform: when creating autocompletewindow, it will
bind "" to winconfig, this cause a problem, when showing up the acw,
it will misbehavior calling multiple times about .
The result is, tk will not able to response
Louie Lu added the comment:
I'm mainly working on Linux, so these problem didn't affect me alot. I did some
test on these issue:
#24801: right click works on 5.8.18 AS version.
#24570: calltips work
#25988: wrong issue number (?)
--
#21603: concur with Ned, save as a file from foo to bar
Louie Lu added the comment:
@Terry, this is another too-fast-to-destroy problem. The latest PR commit has
fixed the issue on MacOS.
When we double click on autocompletewindow, it will try to focusOut
autocompletewindow then focusOn widget.text, but, we destroy too fast, after
destroy, tk
Louie Lu added the comment:
The step after installing newer Tk will require `make clean` and `make` again
to let linker link to the recent install version.
I can freeze the cursor after double click on any version of Tk I install,
8.5.9 / 8.5.18 / 8.6.4 on MacOS Sierra.
Maybe we should
Louie Lu added the comment:
There is a difference between Linux and Mac freeze. On linux, if freeze and I
insert pdb.set_trace() at the end of the hide_window, it will let cursor blink
again, while on Mac, this won't work.
I try self.widget.after(200, self.hide_window) and it doesn't work
Louie Lu added the comment:
Test PR on MacOS with Tk 5.8.9, when double click on listbox will cause freeze
after hide window
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1617
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue15786>
___
__
Louie Lu added the comment:
The reason why click on listbox will disappear is because we bind
HIDE_VIRTUAL_EVENT with on widget.text. When click on listbox, it
will focusOut the widget.text then focusOn listbox, thus trigger the hide
process.
The reason why click on listbox and move
Louie Lu added the comment:
I'm not sure the "safer" meaning. If it is about for beginner less confuse when
mistakenly typing "d[long_", the answer will be yes for only complete
string keys.
Impl complexity between str-only and not-str-only will not have too much
Louie Lu added the comment:
In this PR, it will complete dictionary key with string, int, and others.
for example:
d = {'long_key': 10, 'short_key': 20, 30: 40, (((1, 2), 3, 4), 5): 50}
d['lo -> d['long_key'
d[(((1 -> d[(((1, 2), 3, 4), 5)
d[3-> d[30
Th
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1612
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue21261>
___
__
Changes by Louie Lu <m...@louie.lu>:
--
type: -> enhancement
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30303>
___
___
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1601
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30303>
___
__
New submission from Louie Lu:
Relate to #30290, add _utest to textview to support direct unittest.
--
assignee: terry.reedy
components: IDLE
messages: 293228
nosy: louielu, terry.reedy
priority: normal
severity: normal
status: open
title: IDLE: Add _utest to textview
versions: Python
Louie Lu added the comment:
Serhiy, though this no need to add versionchanged, should this need to explicit
note in doc, that tempfile support os.PathLike?
also, I didn't get "add also tests for path-like objects returning bytes path",
if `tempfile.mkdtemp(dir=pathlike.Path(''), pr
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1598
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29947>
___
__
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1599
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29447>
___
__
Louie Lu added the comment:
@Brett, do you think if given a path-like dir, it should only be treated as
`str`, or it could be `str` and `bytes`?
My PR is now treated path-like dir as `str`, not `bytes`.
This will affect at this places:
tempfile.mkdtemp(dir=pathlike.Path(''), pre=b'', suf
Louie Lu added the comment:
Regards my words, some place need to changed to support PathLike, I'll test it
tomorrow.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Louie Lu added the comment:
Since tempfile is relay on `os`,
e.g. `file = _os.join.path(dir, pre+name+suf)`,
it can directly accept dir as PathLike type, this should need to add test case
for it.
--
nosy: +louielu
___
Python tracker <
Louie Lu added the comment:
And, another case, the __text_signature__ and i.signature() is similar, but not
the same:
>>> range.__init__.__text_signature__
'($self, /, *args, **kwargs)'
^
>>> str(i.signature(range.__init__))
'(self, /, *args, **kwargs)'
So we ca
Louie Lu added the comment:
But somehow in this case, List have no __text_signature__:
>>> str(i.signature(list))
'(iterable=(), /)'
>>> list.__text_signature__
'(iterable=(), /)'
>>> str(i.signature(List))
'(iterable=(), /)'
Louie Lu added the comment:
why will a 1 CPU environment using -j8?
isn't that too much for it?
--
nosy: +louielu
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Louie Lu added the comment:
Thing just getting weird. If we remove the guard, some of the builtin function
will get not-so-good signature result:
>>> i.signature(range.__init__)
>>> i.sig
Louie Lu added the comment:
> Did I do something wrong or do you need to allow me to push?
Yes, I've added you to the collaborators on my fork (lulouie/cpython).
But in fact, new GitHub workflow will need to do something different, not just
edit-and-commit. You will need to go to PR 1
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1528
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30247>
___
__
Changes by Louie Lu <m...@louie.lu>:
--
components: +Library (Lib)
nosy: +brett.cannon
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Louie Lu added the comment:
Relate to #29448
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30247>
___
___
Python-bugs-list
New submission from Louie Lu:
Several importlib.machinery class has 'path' attribute, make it possible to
handle os.PathLike.
--
messages: 292856
nosy: louielu
priority: normal
severity: normal
status: open
title: Make importlib.machinery class handle os.PathLike path
versions: Python
Louie Lu added the comment:
@Terry, the PR is created, it is now serving with signature. The two exception
(object not callable, invalid method signature) will return the corresponding
message.
The only thing I didn't figure out it how to change the color, so I didn't test
for this feature
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1490
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue19903>
___
__
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1483
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue15987>
___
__
Louie Lu added the comment:
ah, there are still some corner case about _first_param.sub(), some of them in
signature will be like `(ci)`, not `(self, ci)`, and the regex will replace the
first params to `()`, which is not correct.
--
___
Python
Louie Lu added the comment:
Terry, only this case was failed, others in unittest work very well.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Louie Lu added the comment:
Update to AST base type richcompare.
the unittest finished time was better than python version:
Ran 7 tests in 0.278s
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Louie Lu added the comment:
Provide a recursive way to compare AST nodes, it will compare with fields, but
no attributes.
The performance compare with ast.dump methods in unittest
# Recursive compare
./python -m unittest test.test_ast.ASTCompareTest
Changes by Louie Lu <m...@louie.lu>:
--
pull_requests: +1477
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue15987>
___
__
Louie Lu added the comment:
If we only need a binary True/False result, could we just return a compare of
dump(a) == dump(b)?
This can also add the include_attributes flags for need.
--
nosy: +louielu
___
Python tracker <rep...@bugs.python.
Louie Lu added the comment:
Brett, which implement method will you prefer?
If we want to carry comment at builtin_compile_impl, it will need to change the
grammar since tokenize just drop the comment when dealing with source code.
But if just using regex, will it be more easy with just
Louie Lu added the comment:
Ben, if you have any problem about how to get on with GitHub, I can help you at
#python-dev @ freenode, ping louielu on the chatroom.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Louie Lu added the comment:
> Thank you. I'll re-base my branch onto the master branch found at the GitHub
> repository.
You may re-clone a GitHub repository instead of rebase bitbucket repo.
> I don't maintain repositories at GitHub. Does that mean the contribution must
>
Louie Lu added the comment:
Ben, the process of submitting PR was migrated to GitHub, you will need to use
a GitHub account to do it.
You can refer to devguide for how to submit a PR here:
http://cpython-devguide.readthedocs.io/pullrequest.html
Louie Lu added the comment:
ah, I think Terry point out the problem behind why my 2.7 and Frank's 2.7 have
different behavior.
I'm using tk 8.6.6-1 on Linux, and it may be the problem from tk version.
--
___
Python tracker <rep...@bugs.python.
Louie Lu added the comment:
Is there any reason that the second case Terry provide still will failed with
ValueError?
class C:
def meth2(**kwds): pass
ip.signature(C().meth2)
Traceback (most recent call last):
File "/home/linux/Python/cpython/Lib/idlelib/idle_test/test_callti
Louie Lu added the comment:
I'm now testing to change getfullargspect to signature. It came out that
signature can't accept bound method with only _VAR_KEYWORD. This test case will
gave a ValueError:
>>> class C:
def m2(**kw):
pass
>>> c = C()
101 - 200 of 301 matches
Mail list logo
