Mark Shannon added the comment:
What does "seem wrong" mean?
What exactly is the problem?
--
___
Python tracker
<https://bugs.python.org/issue44417>
___
__
Mark Shannon added the comment:
This is going in the wrong direction.
Rather than add more complex instructions for use only by pattern matching, we
need to simplify the individual operations and re-use existing instructions.
That way pattern matching can benefit from the general performance
Mark Shannon added the comment:
New changeset ab030d6f9d73e7f6c2213c2e308d1ceb04761485 by Sergey Fedoseev in
branch 'main':
bpo-38211: Clean up type_init() (GH-16257)
https://github.com/python/cpython/commit/ab030d6f9d73e7f6c2213c2e308d1ceb04761485
--
nosy: +Ma
Change by Mark Shannon :
--
pull_requests: +25344
pull_request: https://github.com/python/cpython/pull/26759
___
Python tracker
<https://bugs.python.org/issue44
Change by Mark Shannon :
--
assignee: Mark.Shannon -> eric.snow
___
Python tracker
<https://bugs.python.org/issue43693>
___
___
Python-bugs-list mai
New submission from Mark Shannon :
When calling frame.clear(), the globals (and builtins) are cleared.
This is not the case in 3.10. We should restore the 3.10 behavior, as there is
no reason not to.
Victor, you've mentioned this problem. Did you have a specific example I can
add as a
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +25355
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26768
___
Python tracker
<https://bugs.python.org/issu
Change by Mark Shannon :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue2>
___
Mark Shannon added the comment:
No problem, I've added a simple test.
--
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issue2>
___
Change by Mark Shannon :
--
pull_requests: +25357
pull_request: https://github.com/python/cpython/pull/26771
___
Python tracker
<https://bugs.python.org/issue44
Mark Shannon added the comment:
New changeset 0982ded179f280176868c1c4eccf77bf70687816 by Mark Shannon in
branch 'main':
bpo-44032: Move pointer to code object from frame-object to frame specials
array. (GH-26771)
https://github.com/python/cpyt
Mark Shannon added the comment:
Ned, is this a regression (does 3.9 do the right thing on Windows) or an
inconsistency between Mac and Windows?
I suspect this might have something to do with the PREDICT macros. If that the
were the case 3.9 should show the same inconsistency between Windows
Mark Shannon added the comment:
Thanks Anthony, that's a big help.
--
___
Python tracker
<https://bugs.python.org/issue44297>
___
___
Python-bugs-list m
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +25382
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26801
___
Python tracker
<https://bugs.python.org/issu
Mark Shannon added the comment:
New changeset 82e5c28af7049c4f5343c808f172cbe2e145f49b by Mark Shannon in
branch 'main':
bpo-44297: Fix missing line number in generator expressions (GH-26801)
https://github.com/python/cpython/commit/82e5c28af7049c4f5343c808f172cb
Change by Mark Shannon :
--
pull_requests: +25402
pull_request: https://github.com/python/cpython/pull/26821
___
Python tracker
<https://bugs.python.org/issue44
Mark Shannon added the comment:
I think this is a combination of https://bugs.python.org/issue44297 and the
PREDICT macros.
I don't have a windows machine to confirm this on, but I suspect that if you
rewrite `doit` as:
def doit():
o = ((1,2), (3,4))
o = (a for
Mark Shannon added the comment:
New changeset 7674c83d81905d6afe989ca3f93f08b7939b057c by Mark Shannon in
branch '3.10':
bpo-44297: Fix missing line number in generator expressions (GH-26821)
https://github.com/python/cpython/commit/7674c83d81905d6afe989ca3f93f08
Mark Shannon added the comment:
New changeset fb68791a26e157ed3cdeb409c8d8b6cddc7535bd by Mark Shannon in
branch 'main':
bpo-44337: Improve LOAD_ATTR specialization (GH-26759)
https://github.com/python/cpython/commit/fb68791a26e157ed3cdeb409c8d8b6
Mark Shannon added the comment:
This appears to be a duplicate of https://bugs.python.org/issue44297
--
___
Python tracker
<https://bugs.python.org/issue44
Mark Shannon added the comment:
With the latest 3.10, I get:
File "/home/mark/test/test.py", line 13, in
next(bar().__await__(), None)
File "/home/mark/test/test.py", line 10, in bar
return [chunk async for chunk in foo()]
File "/home/mark/test/test.py&
Mark Shannon added the comment:
Hmm, I'm a bit puzzled by that.
Did you test with 3.10b3 or the latest build from the 3.10 branch with the fix
to https://bugs.python.org/issue44297 included?
--
___
Python tracker
<https://bugs.py
New submission from Mark Shannon :
It is possible to create a module without a dictionary:
m = types.ModuleType.__new__(types.ModuleType)
But that is the only way to create to a module without a dict; all other means
of creating a module, both in Python and in the C API, result in a fully
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +25428
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26847
___
Python tracker
<https://bugs.python.org/issu
Mark Shannon added the comment:
New changeset c3f52b4d707a78eb342372a2be00f3eb846a05b9 by Mark Shannon in
branch 'main':
bpo-44486: Make sure that modules always have a dictionary. (GH-26847)
https://github.com/python/cpython/commit/c3f52b4d707a78eb342372a2be00f3
Mark Shannon added the comment:
Thanks for the reproducer.
--
assignee: -> Mark.Shannon
___
Python tracker
<https://bugs.python.org/issue44297>
___
___
Py
Change by Mark Shannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Mark Shannon :
We are making lots of changes to the code object.
We should clearly document all the changes in one place and explain the new
design well before 3.11 beta.
--
assignee: docs@python
components: Documentation
messages: 396432
nosy: Mark.Shannon, docs
Change by Mark Shannon :
--
pull_requests: +25467
pull_request: https://github.com/python/cpython/pull/26890
___
Python tracker
<https://bugs.python.org/issue44
Change by Mark Shannon :
--
pull_requests: +25468
pull_request: https://github.com/python/cpython/pull/26891
___
Python tracker
<https://bugs.python.org/issue44
Mark Shannon added the comment:
> So, it's expected that `some_module` and `v` would be in the locals at this
> point.
If a function does not have the local variables `some_module` and `v`, then the
change wouldn't be visible to the debugee.
So what differe
Mark Shannon added the comment:
And today's price for uninformative error message goes to...
"AssertionError: 'False' != 'True'"
;)
I'm looking into it.
--
assignee: -> Mark.Shannon
___
Python t
Mark Shannon added the comment:
I cannot reproduce this on ubuntu
Ubuntu 20.04.2 LTS
gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
I've tried these configs:
./configure --with-pydebug
./configure
./configure --enable-optimizations
./configure --enable-optimizations --with-lto
I also
Mark Shannon added the comment:
Can someone with fedora reproduce this failure?
--
___
Python tracker
<https://bugs.python.org/issue44517>
___
___
Python-bug
Mark Shannon added the comment:
I think this is a worthwhile improvement.
A few comments on this issue and your PR.
1. We already have qualified names on functions and generators and those can be
modified by @decorators.
In those cases, the code object and the function would disagree.
Code
Mark Shannon added the comment:
New changeset 1b28187a0e3e914ee48de8032cbba0a965dd5563 by Batuhan Taskaya in
branch 'main':
bpo-44313: generate LOAD_ATTR/CALL_FUNCTION for top-level imported objects
(GH-26677)
https://github.com/python/cpython/commit/1b28187a0e3e914ee48de8032cbba0
Mark Shannon added the comment:
I suspect that the 0.1% increase is noise.
The size of importlib.h etc show a small decrease, suggesting that the
information content of the code object has *decreased*.
After all, the qualname has to stored somewhere and moving it from caller to
callee
New submission from Mark Shannon :
This breaks a key invariant of PEP 659.
Inserting `assert(cframe.use_tracing == 0);` at the top of all quickened
instructions results in several failures when running the test suite.
--
assignee: Mark.Shannon
components: Interpreter Core
messages
Mark Shannon added the comment:
This is a tricky one.
Which is the "correct" line appears to be subjective.
I'm inclined to leave it as is, as the tracing sequence seems better in the
case of method chaining.
See https://github.com/python/cpython/blob/main/Lib/test/test_
Change by Mark Shannon :
--
priority: release blocker ->
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +25617
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/27064
___
Python tracker
<https://bugs.python.org/issu
Mark Shannon added the comment:
New changeset 514f76bbac386c320a9f3a70797241c612544391 by Mark Shannon in
branch 'main':
bpo-44581: Don't execute quickened instructions if tracing is on (GH-27064)
https://github.com/python/cpython/commit/514f76bbac386c320a9f3a707
Change by Mark Shannon :
--
assignee: -> Mark.Shannon
___
Python tracker
<https://bugs.python.org/issue44570>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +25619
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27066
___
Python tracker
<https://bugs.python.org/issu
Change by Mark Shannon :
--
pull_requests: +25620
pull_request: https://github.com/python/cpython/pull/27067
___
Python tracker
<https://bugs.python.org/issue44
Change by Mark Shannon :
--
pull_requests: +25621
pull_request: https://github.com/python/cpython/pull/27068
___
Python tracker
<https://bugs.python.org/issue44
New submission from Mark Shannon :
In https://bugs.python.org/issue44032 we moved most of the data in the frame
stack, that is the locals, stack, and "specials" (globals, builtins, code etc),
from the heap allocated stack to a (mostly) contiguous array in memory.
That offered som
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +25626
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27077
___
Python tracker
<https://bugs.python.org/issu
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +25628
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27078
___
Python tracker
<https://bugs.python.org/issu
Change by Mark Shannon :
--
nosy: +brandtbucher
___
Python tracker
<https://bugs.python.org/issue44600>
___
___
Python-bugs-list mailing list
Unsubscribe:
Mark Shannon added the comment:
New changeset 9487a17e3c7cbb3f11c144775cd108601701bb74 by Mark Shannon in
branch 'main':
bpo-44207: Add an internal version number to function objects. (GH-27078)
https://github.com/python/cpython/commit/9487a17e3c7cbb3f11c144775cd108
Mark Shannon added the comment:
Thanks Ned, you're doing a fantastic job of finding these issues.
Sorry for keeping you so busy with this.
This one was a latent bug, exposed by fixing https://bugs.python.org/issue44570.
--
___
Python tr
Change by Mark Shannon :
--
pull_requests: +25653
pull_request: https://github.com/python/cpython/pull/27109
___
Python tracker
<https://bugs.python.org/issue44
Change by Mark Shannon :
--
keywords: +patch
nosy: +Mark.Shannon
nosy_count: 1.0 -> 2.0
pull_requests: +25654
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27109
___
Python tracker
<https://bugs.python.org/i
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +25655
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27109
___
Python tracker
<https://bugs.python.org/issu
Change by Mark Shannon :
--
pull_requests: -25654
___
Python tracker
<https://bugs.python.org/issue44614>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Mark Shannon :
--
pull_requests: -25653
___
Python tracker
<https://bugs.python.org/issue44570>
___
___
Python-bugs-list mailing list
Unsubscribe:
Mark Shannon added the comment:
New changeset e5862f79c16e28f1ec51d179698739a9b2d8c1d2 by Mark Shannon in
branch 'main':
bpo-44616: Mark all clean up instructions at end of named exception block as
artificial (GH-27109)
https://github.com/python/cpyt
Change by Mark Shannon :
--
pull_requests: +25678
pull_request: https://github.com/python/cpython/pull/27135
___
Python tracker
<https://bugs.python.org/issue44
Mark Shannon added the comment:
New changeset 794ff7d505f852dc4e0f94901dc7387afaead3bb by Mark Shannon in
branch '3.10':
bpo-44616: Mark all clean up instructions at end of named exception block as
artificial (GH-27109) (GH-27135)
https://github.com/python/cpyt
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +25680
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27138
___
Python tracker
<https://bugs.python.org/issu
Change by Mark Shannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +25697
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27160
___
Python tracker
<https://bugs.python.org/issu
Mark Shannon added the comment:
New changeset 641345d636320a6fca04a5271fa4c4c5ba3e5437 by Irit Katriel in
branch 'main':
bpo-26280: Port BINARY_SUBSCR to PEP 659 adaptive interpreter (GH-27043)
https://github.com/python/cpython/commit/641345d636320a6fca04a5271fa4c4
Mark Shannon added the comment:
New changeset f333ab0f2edec26a769ed558263ac662e5475451 by Mark Shannon in
branch 'main':
bpo-44622: Set line number of END_ASYNC_FOR to match that of iterator.
(GH-27160)
https://github.com/python/cpython/commit/f333ab0f2edec26a769ed558263ac6
Change by Mark Shannon :
--
pull_requests: +25700
pull_request: https://github.com/python/cpython/pull/27163
___
Python tracker
<https://bugs.python.org/issue44
Mark Shannon added the comment:
https://github.com/python/cpython/pull/18334 assumes that since all loops will
contain a backwards edge, checking for interrupts on JUMP_ABSOLUTE should be
sufficient.
However, https://github.com/python/cpython/pull/23743 changed the back edges in
while
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +25703
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/27167
___
Python tracker
<https://bugs.python.org/issu
Change by Mark Shannon :
--
pull_requests: +25719
pull_request: https://github.com/python/cpython/pull/27182
___
Python tracker
<https://bugs.python.org/issue44
Mark Shannon added the comment:
New changeset 000e70ad5246732fcbd27cf59268185cbd5ad734 by Mark Shannon in
branch 'main':
bpo-44645: Check for interrupts on any potentially backwards edge. (GH-27167)
https://github.com/python/cpython/commit/000e70ad5246732fcbd27cf5926818
Change by Mark Shannon :
--
pull_requests: +25720
pull_request: https://github.com/python/cpython/pull/27183
___
Python tracker
<https://bugs.python.org/issue44
Mark Shannon added the comment:
Can we at least include the fix, until we can come up with a better test?
That test fails on 3.9 as well as 3.10 and main.
With a 3.9 build and the test in #27194:
./python -m test test_threading -R :
0:00:00 load avg: 0.95 Run tests sequentially
0:00:00 load
Change by Mark Shannon :
--
pull_requests: +25755
pull_request: https://github.com/python/cpython/pull/27216
___
Python tracker
<https://bugs.python.org/issue44
Mark Shannon added the comment:
New changeset d09c13417890427f829e3df297beb0e27133f8f4 by Mark Shannon in
branch 'main':
bpo-44645: Check for interrupts on any potentially backwards edge (GH-27216)
https://github.com/python/cpython/commit/d09c13417890427f829e3df297beb0
Mark Shannon added the comment:
New changeset 37bdd2221ce3607a81d5d7fafc4603d95ca3e8cb by Miss Islington (bot)
in branch '3.10':
bpo-44645: Check for interrupts on any potentially backwards edge (GH-27216)
(GH-27235)
https://github.com/python/cpyt
Mark Shannon added the comment:
I say no, for a couple of reasons.
1. PEP 626 only applies to 3.10 onwards
2. The bytecode optimizer in 3.9 doesn't understand line numbers.
Changing it would be a lot of effort and likely to introduce more bugs than it
fixes.
Ultimately it is Łuk
Mark Shannon added the comment:
We can fix this for 3.9. The fix to 3.10 was trivial and should port easily.
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +25800
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27255
___
Python tracker
<https://bugs.python.org/issu
Mark Shannon added the comment:
Not quite trivial, but simple enough :)
--
___
Python tracker
<https://bugs.python.org/issue44621>
___
___
Python-bugs-list m
Mark Shannon added the comment:
New changeset ae0a2b756255629140efcbe57fc2e714f0267aa3 by Mark Shannon in
branch 'main':
bpo-44590: Lazily allocate frame objects (GH-27077)
https://github.com/python/cpython/commit/ae0a2b756255629140efcbe57fc2e7
New submission from Mark Shannon :
class C:
def __init__(self, cond):
if cond:
self.a = 1
self.b = 2
c1 = C(True)
c2 = C(False)
In Python 3.5, the dictionary keys are shared
-
>>> sys.getsize
Change by Mark Shannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Mark Shannon added the comment:
New changeset e5c8ddb1714fb51ab1defa24352c98e0f01205dc by Serhiy Storchaka in
branch 'main':
bpo-44707: Fix an undefined behavior of the null pointer arithmetic (GH-27292)
https://github.com/python/cpython/commit/e5c8ddb1714fb51ab1defa24352c98
Mark Shannon added the comment:
New changeset ddd1c418c05da0de978c75dfb3e4a5b8d27e1d9f by Irit Katriel in
branch 'main':
bpo-44725 : expose specialization stats in python (GH-27192)
https://github.com/python/cpython/commit/ddd1c418c05da0de978c75dfb3e4a5b8d27e1d9f
-
Mark Shannon added the comment:
Pablo,
There is another failure on that buildbot: test_inspect fails with
^^
File "/home/mark/repos/cpython/Lib/inspect.py", line 1154, in walktree
classes.sort(key=attrgetter('__modul
Change by Mark Shannon :
--
pull_requests: +26051
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/27542
___
Python tracker
<https://bugs.python.org/issu
Mark Shannon added the comment:
This isn't a bug. Although PEP 626 is not at all clear about this.
The key word in the PEP is "executed".
Because compound and multi-line constants are constants, the parts of them are
not "executed", but computed at compile time.
Hav
New submission from Mark Shannon :
Currently, instance dictionaries (__dict__ attribute) are created lazily when
the first attribute is set.
This is bad for performance for a number of reasons:
1. It causes additional checks on every attribute access.
2. It causes allocation of the object and
Mark Shannon added the comment:
Raymond,
When you say "this was mostly a net win" do you mean the more compact layout or
ordering?
The compact layout is obviously a win, and doesn't conflict with sharing. The
problem is that ordering conflicts with sharing.
As long as ins
New submission from Mark Shannon :
Add specializations of STORE_ATTR following the pattern of LOAD_ATTR and
LOAD_GLOBAL.
For this to work well we need https://bugs.python.org/issue44821, otherwise the
first assigned to an attribute of any object cannot be specialized.
--
messages
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +26091
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27589
___
Python tracker
<https://bugs.python.org/issu
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +26092
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27590
___
Python tracker
<https://bugs.python.org/issu
Mark Shannon added the comment:
New changeset cee67fa66129b5d1db5c8aa3884338f82f0da3de by Mark Shannon in
branch 'main':
bpo-44821: Eagerly assign __dict__ for new objects. (GH-27589)
https://github.com/python/cpython/commit/cee67fa66129b5d1db5c8aa3884338
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +26150
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27656
___
Python tracker
<https://bugs.python.org/issu
Mark Shannon added the comment:
New changeset b854557b49083d8625a433eb36aacb0c87d67c52 by Mark Shannon in
branch 'main':
bpo-44840: Compiler: Move duplication of exit blocks with no line numbers to
after CFG optimization. (GH-27656)
https://github.com/python/cpyt
Change by Mark Shannon :
--
pull_requests: +26161
pull_request: https://github.com/python/cpython/pull/27673
___
Python tracker
<https://bugs.python.org/issue44
Mark Shannon added the comment:
New changeset ac75f6bdd4748b3378dd321f862d13aa1898f77a by Mark Shannon in
branch 'main':
bpo-44826: Specialize STORE_ATTR (GH-27590)
https://github.com/python/cpython/commit/ac75f6bdd4748b3378dd321f862d13
Change by Mark Shannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Mark Shannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Mark Shannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> performance
___
Python tracker
<https://bugs.python
401 - 500 of 1194 matches
Mail list logo